Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class CalendarAPI extends API |
||
18 | { |
||
19 | /** |
||
20 | * @var Type\FolderIdType |
||
21 | */ |
||
22 | protected $folderId; |
||
23 | |||
24 | /** |
||
25 | * Pick a Calendar based on it's name |
||
26 | * |
||
27 | * @param string|null $displayName |
||
28 | * @return $this |
||
29 | */ |
||
30 | 6 | public function pickCalendar($displayName = null) |
|
42 | |||
43 | /** |
||
44 | * @return Type\FolderIdType |
||
45 | */ |
||
46 | 6 | public function getFolderId() |
|
54 | |||
55 | /** |
||
56 | * @param Type\FolderIdType $folderId |
||
57 | * @return $this |
||
58 | */ |
||
59 | public function setFolderId($folderId) |
||
65 | |||
66 | /** |
||
67 | * Create one or more calendar items |
||
68 | * |
||
69 | * @param $items CalendarItemType[]|CalendarItemType|array or more calendar items to create |
||
70 | * @param $options array Options to merge in to the request |
||
71 | * @return Type\ItemIdType[] |
||
72 | */ |
||
73 | 3 | public function createCalendarItems($items, $options = array()) |
|
89 | |||
90 | /** |
||
91 | * Get a list of calendar items between two dates/times |
||
92 | * |
||
93 | * @param string|DateTime $start |
||
94 | * @param string|DateTime $end |
||
95 | * @param array $options |
||
96 | * @return CalendarItemType[]|Type\FindItemParentType |
||
97 | */ |
||
98 | 6 | public function getCalendarItems($start = '12:00 AM', $end = '11:59 PM', $options = array()) |
|
126 | |||
127 | /** |
||
128 | * @param $id |
||
129 | * @param $changeKey |
||
130 | * @return Type\CalendarItemType |
||
131 | */ |
||
132 | 1 | public function getCalendarItem($id, $changeKey) |
|
136 | |||
137 | /** |
||
138 | * Updates a calendar item with changes |
||
139 | * |
||
140 | * @param $itemId Type\ItemIdType |
||
141 | * @param array $changes |
||
142 | * @param array $options |
||
143 | * @return Type\CalendarItemType[] |
||
144 | */ |
||
145 | 1 | public function updateCalendarItem(Type\ItemIdType $itemId, $changes, $options = array()) |
|
163 | |||
164 | /** |
||
165 | * @param Type\ItemIdType $itemId |
||
166 | * @param array $options |
||
167 | * @return bool |
||
168 | */ |
||
169 | 3 | public function deleteCalendarItem(Type\ItemIdType $itemId, $options = array()) |
|
178 | |||
179 | /** |
||
180 | * @param string $start |
||
181 | * @param string $end |
||
182 | * @param array $options |
||
183 | */ |
||
184 | 6 | public function deleteAllCalendarItems($start = '12:00 AM', $end = '11:59 PM', $options = array()) |
|
191 | |||
192 | /** |
||
193 | * Get a list of changes on the calendar items |
||
194 | * |
||
195 | * @param null $syncState |
||
196 | * @param array $options |
||
197 | * @return API\Message\SyncFolderItemsResponseMessageType |
||
198 | */ |
||
199 | 1 | public function listChanges($syncState = null, $options = array()) |
|
203 | |||
204 | /** |
||
205 | * @param Type\ItemIdType $itemId |
||
206 | * @param string $message |
||
207 | * @param string $sensitivity |
||
208 | * @param array $options |
||
209 | * |
||
210 | * @return Type\ItemIdType[] |
||
211 | */ |
||
212 | View Code Duplication | public function acceptMeeting($itemId, $message, $sensitivity = 'Private', $options = array()) |
|
228 | |||
229 | /** |
||
230 | * @param $itemId |
||
231 | * @param $message |
||
232 | * @param string $sensitivity |
||
233 | * @param array $options |
||
234 | * @return Type\ItemIdType[] |
||
235 | */ |
||
236 | View Code Duplication | public function declineMeeting($itemId, $message, $sensitivity = 'Private', $options = array()) |
|
252 | |||
253 | /** |
||
254 | * @param $startTime |
||
255 | * @param $endTime |
||
256 | * @param array $users |
||
257 | * @param array $options |
||
258 | * |
||
259 | * @return API\Message\GetUserAvailabilityResponseType |
||
260 | */ |
||
261 | public function getAvailabilityFor($startTime, $endTime, array $users, array $options = array()) |
||
292 | |||
293 | /** |
||
294 | * @param $startTime |
||
295 | * @param $endTime |
||
296 | * @param int $period The period of time to see if users of free for (in minutes) |
||
297 | * @param array $users |
||
298 | * @param array $options |
||
299 | * |
||
300 | * @return boolean |
||
301 | */ |
||
302 | public function areAvailable($startTime, $endTime, $period, array $users, array $options = []) |
||
336 | } |
||
337 |