ContactsAPI::getContacts() - Code Metrics - Inspection of "Added a simple usage for contacts" - Garethp/php-ews - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ed11ea...d84521 )

by Gareth

created 2016-01-25 10:13 UTC

ContactsAPI::getContacts() A

↳ Parent: ContactsAPI

Complexity

Conditions	2
Paths	2

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	21
ccs	0
cts	18
cp	0
rs	9.3142
cc	2
eloc	12
nc	2
nop	2
crap	6

<?php

namespace jamesiarmes\PEWS\Contacts;

use jamesiarmes\PEWS\API;
use jamesiarmes\PEWS\API\Type;

class ContactsAPI extends API
{
    /**
     * @var Type\FolderIdType
     */
    protected $folderId;

    /**
     * @return Type\FolderIdType
     */
    public function getFolderId()
    {
        if (!$this->folderId) {
            $this->folderId = $this->getFolderByDistinguishedId('contacts')->getFolderId();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }

        return $this->folderId;
    }

    /**
     * @param Type\FolderIdType $folderId
     */
    public function setFolderId($folderId)
    {
        $this->folderId = $folderId;
    }

    /**
     * @param Type\FolderIdType $folderId
     * @param array $options
     * @return Type
     */
    public function getContacts($folderId = null, $options = array())
    {
        if (!$folderId) {
            $folderId = $this->getFolderId();
        }

        $request = array(
            'Traversal' => 'Shallow',
            'ItemShape' => array(
                'BaseShape' => 'AllProperties'
            ),
            'ParentFolderIds' => array(
                'FolderId' => $folderId->toXmlObject()
            )
        );

        $request = array_replace_recursive($request, $options);

        $request = Type::buildFromArray($request);
        return $this->getClient()->FindItem($request);
    }
}


1			<?php
2
3			namespace jamesiarmes\PEWS\Contacts;
4
5			use jamesiarmes\PEWS\API;
6			use jamesiarmes\PEWS\API\Type;
7
8			class ContactsAPI extends API
9			{
10			/**
11			* @var Type\FolderIdType
12			*/
13			protected $folderId;
14
15			/**
16			* @return Type\FolderIdType
17			*/
18			public function getFolderId()
19			{
20			if (!$this->folderId) {
21			$this->folderId = $this->getFolderByDistinguishedId('contacts')->getFolderId();
			0 ignored issues – show Documentation Bug introduced 2016-01-25 10:21 UTC by Report Bug Copy Issue Report The method `getFolderId` does not exist on `object<jamesiarmes\PEWS\API\Type>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
22			}
23
24			return $this->folderId;
25			}
26
27			/**
28			* @param Type\FolderIdType $folderId
29			*/
30			public function setFolderId($folderId)
31			{
32			$this->folderId = $folderId;
33			}
34
35			/**
36			* @param Type\FolderIdType $folderId
37			* @param array $options
38			* @return Type
39			*/
40			public function getContacts($folderId = null, $options = array())
41			{
42			if (!$folderId) {
43			$folderId = $this->getFolderId();
44			}
45
46			$request = array(
47			'Traversal' => 'Shallow',
48			'ItemShape' => array(
49			'BaseShape' => 'AllProperties'
50			),
51			'ParentFolderIds' => array(
52			'FolderId' => $folderId->toXmlObject()
53			)
54			);
55
56			$request = array_replace_recursive($request, $options);
57
58			$request = Type::buildFromArray($request);
59			return $this->getClient()->FindItem($request);
60			}
61			}
62

Garethp / php-ews

Push — master ( ed11ea...d84521 )

ContactsAPI::getContacts() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like