Code Duplication - Garethp/php-ews - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 18-20 lines in 2 locations

src/MailAPI.php 1 location


     * @param $changes
     * @return Type\MessageType[]
     */
    public function updateMailItem($itemId, $changes)
    {
        //Create the request
        $request = array(
            'ItemChange' => array(
                'ItemId' => $itemId->toArray(),
                'Updates' => API\ItemUpdateBuilder::buildUpdateItemChanges('Message', 'message', $changes)
            )
        );

        $items = $this->updateItems($request);

        if (!is_array($items)) {
            $items = array($items);
        }

        return $items;
    }

    /**
     * @param $mailItem Type\MessageType|Type\ItemIdType

src/ContactsAPI.php 1 location


        return $result;
    }

    public function updateContactItem(Type\ItemIdType $itemId, $changes)
    {
        //Create the request
        $request = array(
            'ItemChange' => array(
                'ItemId' => $itemId->toArray(),
                'Updates' => API\ItemUpdateBuilder::buildUpdateItemChanges('Contact', 'contacts', $changes)
            )
        );

        $options = array();

        $items = $this->updateItems($request, $options);

        if (!is_array($items)) {
            $items = array($items);
        }

        return $items;
    }
}


		@@ 132-149 (lines=18) @@
129		* @param $changes
130		* @return Type\MessageType[]
131		*/
132		public function updateMailItem($itemId, $changes)
133		{
134		//Create the request
135		$request = array(
136		'ItemChange' => array(
137		'ItemId' => $itemId->toArray(),
138		'Updates' => API\ItemUpdateBuilder::buildUpdateItemChanges('Message', 'message', $changes)
139		)
140		);
141
142		$items = $this->updateItems($request);
143
144		if (!is_array($items)) {
145		$items = array($items);
146		}
147
148		return $items;
149		}
150
151		/**
152		* @param $mailItem Type\MessageType\|Type\ItemIdType

		@@ 119-138 (lines=20) @@
116		return $result;
117		}
118
119		public function updateContactItem(Type\ItemIdType $itemId, $changes)
120		{
121		//Create the request
122		$request = array(
123		'ItemChange' => array(
124		'ItemId' => $itemId->toArray(),
125		'Updates' => API\ItemUpdateBuilder::buildUpdateItemChanges('Contact', 'contacts', $changes)
126		)
127		);
128
129		$options = array();
130
131		$items = $this->updateItems($request, $options);
132
133		if (!is_array($items)) {
134		$items = array($items);
135		}
136
137		return $items;
138		}
139		}
140

Garethp / php-ews

Code Duplication Length = 18-20 lines in 2 locations

src/MailAPI.php 1 location

src/ContactsAPI.php 1 location