CharacterClass::getRessource()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 2
CRAP Score 1

Importance

Changes 0
Metric Value
dl 0
loc 4
ccs 2
cts 2
cp 1
rs 10
c 0
b 0
f 0
cc 1
eloc 2
nc 1
nop 0
crap 1
1
<?php namespace GameScan\WoW\Entity;
2
3
class CharacterClass extends Base
4
{
5
6 1
    public function getRessource()
7
    {
8 1
        return "/wow/data/character/classes";
9
    }
10
11 1
    public function getClasses()
12
    {
13 1
        return $this->getEntityInformations()->classes;
0 ignored issues
show
Documentation introduced by
The property classes does not exist on object<GameScan\WoW\EntityInformation>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
14
    }
15
16 1
    public function getClassesName()
17
    {
18 1
        $classes = $this->getClasses();
19 1
        $classesSet = array();
20 1
        foreach ($classes as $characterClass) {
21 1
            $classesSet[$characterClass->id] = $characterClass->name;
22 1
        }
23 1
        return  $classesSet;
24
    }
25
}
26