GalantomClientTest - Code Metrics - Galantom/galantom-api-php - Measure and Improve Code Quality continuously with Scrutinizer

GalantomClientTest A
last analyzed 2017-08-01 08:54 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
wmc	9
c	1
b	1
f	0
lcom	1
cbo	9
dl	0
loc	78
rs	10

4 Methods

Rating	Name	Size	Complexity
A	testEmptyFactory()	9	1
B	testServiceCommands()	38	5
A	providerServiceCommands()	6	1
A	getClient()	7	2

<?php

namespace GalantomApi\Tests;

use GalantomApi\GalantomClient;
use GuzzleHttp\Command\Guzzle\GuzzleClient;
use GuzzleHttp\Handler\MockHandler;
use GuzzleHttp\HandlerStack;
use GuzzleHttp\Psr7\Response;

/**
 * Class GalantomClientTest
 * @package GalantomApi\Tests
 */
class GalantomClientTest extends AbstractTest
{
    public function testEmptyFactory()
    {
        $galantom = GalantomClient::factory();

        static::assertInstanceOf(GuzzleClient::class, $galantom);
        static::assertInstanceOf(GalantomClient::class, $galantom);

        self::assertEquals('https://galantom.ro/api/', $galantom->getDescription()->getBaseUri()->__toString());
    }

    /**
     * @dataProvider providerServiceCommands
     * @param $method
     * @param $params
     */
    public function testServiceCommands($method, $params)
    {
        $queue = new MockHandler([
            new Response(200, ['Content-Type' => 'application/json'], '{"response": true}')
        ]);
        $handler = HandlerStack::create($queue);

        $client = $this->getClient($handler);

        $command = $client->getCommand($method, $params);
        $client->execute($command);

        $request = $queue->getLastRequest();

        $params['api_token'] = 999;

        //Resource Url
        $url = parse_url($request->getUri());

        $operation = $client->getDescription()->getOperation($method);
        //Make sure the url has the right method
        static::assertContains($operation->getUri(), $url['path']);

        $parameters = $operation->getParams();
        parse_str($url['query'], $uriParams);

        foreach ($parameters as $parameter) {
            $paramName = $parameter->getName();
            $paramValue = isset($params[$paramName]) ? $params[$paramName] : null;
            $uriValue = isset($uriParams[$paramName]) ? $uriParams[$paramName] : null;
            switch ($parameter->getLocation()) {
                case 'query':
                    static::assertEquals($paramValue, $uriValue);
                    break;

            }
        }
    }

    /**
     * Data for service calls
     */
    public function providerServiceCommands()
    {
        return [
            ['getPageDonations', ['id' => 159]],
        ];
    }

    /**
     * @param null $handler
     * @return GalantomClient
     */
    protected function getClient($handler = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return GalantomClient::factory([
            'api_token' => isset($_ENV['api_token']) ? $_ENV['api_token'] : 999,
            'handler' => $handler
        ]);
    }
}


1			<?php
2
3			namespace GalantomApi\Tests;
4
5			use GalantomApi\GalantomClient;
6			use GuzzleHttp\Command\Guzzle\GuzzleClient;
7			use GuzzleHttp\Handler\MockHandler;
8			use GuzzleHttp\HandlerStack;
9			use GuzzleHttp\Psr7\Response;
10
11			/**
12			* Class GalantomClientTest
13			* @package GalantomApi\Tests
14			*/
15			class GalantomClientTest extends AbstractTest
16			{
17			public function testEmptyFactory()
18			{
19			$galantom = GalantomClient::factory();
20
21			static::assertInstanceOf(GuzzleClient::class, $galantom);
22			static::assertInstanceOf(GalantomClient::class, $galantom);
23
24			self::assertEquals('https://galantom.ro/api/', $galantom->getDescription()->getBaseUri()->__toString());
25			}
26
27			/**
28			* @dataProvider providerServiceCommands
29			* @param $method
30			* @param $params
31			*/
32			public function testServiceCommands($method, $params)
33			{
34			$queue = new MockHandler([
35			new Response(200, ['Content-Type' => 'application/json'], '{"response": true}')
36			]);
37			$handler = HandlerStack::create($queue);
38
39			$client = $this->getClient($handler);
40
41			$command = $client->getCommand($method, $params);
42			$client->execute($command);
43
44			$request = $queue->getLastRequest();
45
46			$params['api_token'] = 999;
47
48			//Resource Url
49			$url = parse_url($request->getUri());
50
51			$operation = $client->getDescription()->getOperation($method);
52			//Make sure the url has the right method
53			static::assertContains($operation->getUri(), $url['path']);
54
55			$parameters = $operation->getParams();
56			parse_str($url['query'], $uriParams);
57
58			foreach ($parameters as $parameter) {
59			$paramName = $parameter->getName();
60			$paramValue = isset($params[$paramName]) ? $params[$paramName] : null;
61			$uriValue = isset($uriParams[$paramName]) ? $uriParams[$paramName] : null;
62			switch ($parameter->getLocation()) {
63			case 'query':
64			static::assertEquals($paramValue, $uriValue);
65			break;
66
67			}
68			}
69			}
70
71			/**
72			* Data for service calls
73			*/
74			public function providerServiceCommands()
75			{
76			return [
77			['getPageDonations', ['id' => 159]],
78			];
79			}
80
81			/**
82			* @param null $handler
83			* @return GalantomClient
84			*/
85			protected function getClient($handler = null)
			0 ignored issues – show Coding Style introduced 2017-07-31 15:57 UTC by Report Bug Copy Issue Report `getClient` uses the super-global variable `$_ENV` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
86			{
87			return GalantomClient::factory([
88			'api_token' => isset($_ENV['api_token']) ? $_ENV['api_token'] : 999,
89			'handler' => $handler
90			]);
91			}
92			}
93

Galantom / galantom-api-php

GalantomClientTest A last analyzed 2017-08-01 08:54 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

GalantomClientTest A
last analyzed 2017-08-01 08:54 UTC