GGGGino /
SkuskuCartBundle
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 97 |
| Code Lines | 78 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 2 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 14 | public function getConfigTreeBuilder() |
||
| 15 | { |
||
| 16 | $treeBuilder = new TreeBuilder(); |
||
| 17 | $rootNode = $treeBuilder->root('ggggino_skuskucart'); |
||
| 18 | |||
| 19 | /** @var array $defaultSteps gli step minimi e di default */ |
||
| 20 | $defaultSteps = array( |
||
| 21 | 'cart' => array( |
||
| 22 | 'form_type' => 'GGGGino\SkuskuCartBundle\Form\CartFlowType\CartStep1FormType', |
||
| 23 | 'label' => 'cart_resume' |
||
| 24 | ), |
||
| 25 | 'chosePayment' => array( |
||
| 26 | 'form_type' => 'GGGGino\SkuskuCartBundle\Form\CartFlowType\CartStep2FormType', |
||
| 27 | 'label' => 'chose_payment' |
||
| 28 | ), |
||
| 29 | 'payment' => array( |
||
| 30 | 'form_type' => 'GGGGino\SkuskuCartBundle\Form\CartFlowType\CartStep3FormType', |
||
| 31 | 'label' => 'payment' |
||
| 32 | ) |
||
| 33 | ); |
||
| 34 | |||
| 35 | /** @var array $defaultTemplates i template minimi */ |
||
| 36 | $defaultTemplates = array( |
||
| 37 | 'cart_layout' => 'GGGGinoSkuskuCartBundle::cart_page.html.twig' |
||
| 38 | ); |
||
| 39 | |||
| 40 | $defaultExtraFields = array(); |
||
| 41 | |||
| 42 | $rootNode |
||
| 43 | ->children() |
||
| 44 | ->booleanNode('allow_anonymous_shop') |
||
| 45 | ->defaultTrue() |
||
| 46 | ->end() |
||
| 47 | ->booleanNode('additional_fields') |
||
| 48 | ->defaultTrue() |
||
| 49 | ->end() |
||
| 50 | ->scalarNode('stepform_class') |
||
| 51 | ->defaultValue('GGGGino\SkuskuCartBundle\Form\CartFlow') |
||
| 52 | ->end() |
||
| 53 | ->enumNode('cart_mode') |
||
| 54 | ->values(array( |
||
| 55 | "single_page", |
||
| 56 | "steps", |
||
| 57 | )) |
||
| 58 | ->defaultValue('steps') |
||
| 59 | ->end() |
||
| 60 | ->arrayNode('stepform') |
||
| 61 | ->defaultValue($defaultSteps) |
||
| 62 | ->treatNullLike($defaultSteps) |
||
| 63 | ->arrayPrototype() |
||
| 64 | ->children() |
||
| 65 | ->scalarNode('form_type')->end() |
||
| 66 | ->scalarNode('label')->end() |
||
| 67 | ->end() |
||
| 68 | ->end() |
||
| 69 | ->beforeNormalization() |
||
| 70 | ->always(function($items) use ($defaultSteps){ |
||
| 71 | return array_merge($defaultSteps, $items); |
||
| 72 | }) |
||
| 73 | ->end() |
||
| 74 | ->end() |
||
| 75 | ->arrayNode('extra_fields') |
||
| 76 | ->defaultValue($defaultExtraFields) |
||
| 77 | ->treatNullLike($defaultExtraFields) |
||
| 78 | ->arrayPrototype() |
||
| 79 | ->children() |
||
| 80 | ->scalarNode('id')->end() |
||
| 81 | ->scalarNode('type')->end() |
||
| 82 | ->scalarNode('label')->end() |
||
| 83 | ->scalarNode('class')->end() |
||
| 84 | ->scalarNode('required')->end() |
||
| 85 | ->scalarNode('data')->end() |
||
| 86 | ->end() |
||
| 87 | ->end() |
||
| 88 | ->beforeNormalization() |
||
| 89 | ->always(function($items) use ($defaultExtraFields){ |
||
| 90 | return array_merge($defaultExtraFields, $items); |
||
| 91 | }) |
||
| 92 | ->end() |
||
| 93 | ->end() |
||
| 94 | ->arrayNode('templates') |
||
| 95 | ->defaultValue($defaultTemplates) |
||
| 96 | ->treatNullLike($defaultTemplates) |
||
| 97 | ->scalarPrototype()->end() |
||
| 98 | ->beforeNormalization() |
||
| 99 | ->always(function($items) use ($defaultTemplates){ |
||
| 100 | return array_merge($defaultTemplates, $items); |
||
| 101 | }) |
||
| 102 | ->end() |
||
| 103 | ->end() |
||
| 104 | ->scalarNode('redirect_after_done_route') |
||
| 105 | ->defaultNull() |
||
| 106 | ->end() |
||
| 107 | ->end() |
||
| 108 | ; |
||
| 109 | |||
| 110 | return $treeBuilder; |
||
| 111 | } |
||
| 113 |
