Issues in sendinvite.inc.php (master) - Issues in master - GEANT/CAT - Measure and Improve Code Quality continuously with Scrutinizer

Issues (204)

Security Analysis 13 potential vulnerabilities

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting (2)

Response Splitting can be used to send arbitrary responses.

File Manipulation (6)

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection (1)

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting (1)

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection (3)

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

web/admin/inc/sendinvite.inc.php (2 issues)

Labels

Severity

Minor 2

<?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a 
 * project that has received funding from the European Union’s Framework 
 * Programme 7 under Grant Agreements No. 238875 (GN3) and No. 605243 (GN3plus),
 * Horizon 2020 research and innovation programme under Grant Agreements No. 
 * 691567 (GN4-1) and No. 731122 (GN4-2).
 * On behalf of the aforementioned projects, GEANT Association is the sole owner
 * of the copyright in all material which was developed by a member of the GÉANT
 * project. GÉANT Vereniging (Association) is registered with the Chamber of 
 * Commerce in Amsterdam with registration number 40535155 and operates in the 
 * UK as a branch of GÉANT Vereniging.
 * 
 * Registered office: Hoekenrode 3, 1102BR Amsterdam, The Netherlands. 
 * UK branch address: City House, 126-130 Hills Road, Cambridge CB2 1PQ, UK
 *
 * License: see the web/copyright.inc.php file in the file structure or
 *          <base_url>/copyright.php after deploying the software
 */

require_once dirname(dirname(dirname(__DIR__))) . "/config/_config.php";

$auth = new \web\lib\admin\Authentication();
$auth->authenticate();

$catInstance = new \core\CAT();
$validator = new \web\lib\common\InputValidation();
$uiElements = new \web\lib\admin\UIElements();
$languageInstance = new \core\common\Language();
$languageInstance->setTextDomain("web_admin");

$mgmt = new \core\UserManagement;
$new_idp_authorized_fedadmin = FALSE;

// check if the user is authenticated, and we have a valid mail address
if (!isset($_SESSION['user']) || !isset($_POST['mailaddr'])) {
    throw new Exception("sendinvite: called either without authentication or without target mail address!");
}

$newmailaddress = htmlspecialchars(strip_tags(filter_input(INPUT_POST, 'mailaddr')));
$totalSegments = explode(",", $newmailaddress);
$validAddresses = core\common\OutsideComm::exfiltrateValidAddresses($newmailaddress);
$newcountry = "";

// fed admin stuff
// we are either inviting to co-manage an existing inst ...

$userObject = new \core\User($_SESSION['user']);
$federation = NULL;

const OPERATION_MODE_INVALID = 0;
const OPERATION_MODE_EDIT = 1;
const OPERATION_MODE_NEWFROMDB = 2;
const OPERATION_MODE_NEWUNLINKED = 3;
const OPERATION_MODE_SELF_ADMIN_ADD = 4;
const OPERATION_MODE_SELF_NEWFROMDB = 5;


$operationMode = OPERATION_MODE_INVALID;

// filter all input to make Scrutinizer unnecessarily happy

// what did we actually get?
if (isset($_GET['inst_id'])) {
    if (isset($_POST['self_registration'])) {
        \core\common\Logging::debug_s(4, "Self registration received\n");
        $operationMode = OPERATION_MODE_SELF_ADMIN_ADD;
        } else {
        $operationMode = OPERATION_MODE_EDIT;
    }
}

if (isset($_POST['creation'])) {
    $filteredCreation = htmlspecialchars(strip_tags(filter_input(INPUT_POST, 'creation')));
} else {
    $filteredCreation = NULL;
}

if (isset($_POST['name'])) {
    $filteredName = htmlspecialchars(strip_tags(filter_input(INPUT_POST, 'name')));
} else {
    $filteredName = NULL;
}

if (isset($_POST['country'])) {
    $filteredCountry = htmlspecialchars(strip_tags(filter_input(INPUT_POST, 'country')));
} else {
    $filteredCountry = NULL;
}

if (isset($_POST['externals'])) {
    $filteredExternals = htmlspecialchars(strip_tags(filter_input(INPUT_POST, 'externals')));
} else {
    $filteredExternals = NULL;
}

if ($filteredCreation == "new" && $filteredName !== NULL && $filteredCountry !== NULL) {
    $operationMode = OPERATION_MODE_NEWUNLINKED;
}

if ($filteredCreation == "existing" && $filteredExternals !== NULL && $filteredExternals != "FREETEXT") {
    if (isset($_POST['self_registration'])) {
        \core\common\Logging::debug_s(4, "Self registration received\n");
        $operationMode = OPERATION_MODE_SELF_NEWFROMDB;
        } else {
        $operationMode = OPERATION_MODE_NEWFROMDB;
    }
}
$redirectDestination = '';
switch ($operationMode) {
    case OPERATION_MODE_EDIT:
        $idp = $validator->existingIdP($_GET['inst_id']);
        // editing IdPs is done from within the popup. When we're done, send the 
        // user back to the popup (append the result of the operation later)
        $redirectDestination = "manageAdmins.inc.php?inst_id=" . $idp->identifier . "&";
        if (count($validAddresses) == 0) {
            header("Location: $redirectDestination" . "invitation=INVALIDSYNTAX");
            exit(1);
        }
        // is the user primary admin of this IdP?
        $is_owner = $idp->isPrimaryOwner($_SESSION['user']);
        // check if he is (also) federation admin for the federation this IdP is in. His invitations have more blessing then.
        $fedadmin = $userObject->isFederationAdmin($idp->federation);
        // check if he is either one, if not, complain
        if (!$is_owner && !$fedadmin) {
            echo "<p>" . sprintf(_("Something's wrong... you are a %s admin, but not for the %s the requested %s belongs to!"), $uiElements->nomenclatureFed, $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant) . "</p>";
            exit(1);
        }
        $prettyprintname = $idp->name;
        $newtokens = $mgmt->createTokens($fedadmin, $validAddresses, $idp);
        \core\common\Logging::writeSQLAudit_s($_SESSION['user'], "NEW", "IdP " . $idp->identifier . " - Token created for " . implode(",", $validAddresses));
                              writeSQLAudit_s($_SESSION['user'], "NEW", "IdP " . $idp->identifier . " - Token created for " . implode(",", $validAddresses));
        $introtext = "CO-ADMIN";
        $participant_type = $idp->type;
        break;
    case OPERATION_MODE_SELF_ADMIN_ADD:
        $idp = $validator->existingIdP($_GET['inst_id']);
        $allowedIdPs = $_SESSION['resyncedIdPs'];
        if (!in_array($idp->identifier, $allowedIdPs)) {
            throw new Exception("sendinvite: requested IdP token for and IdP identifier which is not within the allowed list for this user");
        }
        $validAddresses = [$_SESSION['auth_email']];
        $prettyprintname = $idp->name;
        $newtokens = $mgmt->createTokens("FED", $validAddresses, $idp);
        $newtokens = $mgmt->createTokens(/** @scrutinizer ignore-type */ "FED", $validAddresses, $idp);
        \core\common\Logging::writeSQLAudit_s($_SESSION['user'], "NEW", "IdP (self)" . $idp->identifier . " - Token created for " . implode(",", $validAddresses));
        $participant_type = $idp->type;
        $introtext = "SELF-ADMIN";
        break;
    case OPERATION_MODE_NEWUNLINKED:
        $redirectDestination = "../overview_federation.php?";
        if (count($validAddresses) == 0) {
            header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
            exit(1);
        }
        // run an input check and conversion of the raw inputs... just in case
        $newinstname = $validator->string($_POST['name']);
        $newcountry = $validator->string($_POST['country']);
        $participant_type = $validator->partType($_POST['participant_type']);
        $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($newcountry);
        if ($new_idp_authorized_fedadmin !== TRUE) {
            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureParticipant . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
        }
        $federation = $validator->existingFederation($newcountry);
        $prettyprintname = $newinstname;
        $introtext = "NEW-FED";
        // send the user back to his federation overview page, append the result of the operation later
        // do the token creation magic
        $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $newinstname, 0, $newcountry, $participant_type);
        \core\common\Logging::writeSQLAudit_s($_SESSION['user'], "NEW", "ORG FUTURE  - Token created for $participant_type " . implode(",", $validAddresses));
        break;
    case OPERATION_MODE_SELF_NEWFROMDB:
        $validAddresses = [$_SESSION['auth_email']];
        if (!isset($_SESSION['newIdPs']) || count($_SESSION['newIdPs']) !== 1) {
            throw new Exception("Tried eduroam DB based creation without ext identifiers");
        }
        $newIdPs = $_SESSION['newIdPs'];
        $externals = $validator->string($_POST['externals']);
        [$fedId, $newexternalid] = explode('-', $externals, 2);
        $found = [];
        foreach ($newIdPs as $allowed) {
            \core\common\Logging::debug_s(4, $allowed, "Allowed:\n", "\n");
            if (strtoupper($allowed[2]) === $fedId && $allowed[0] ===  $newexternalid) {
                $found = $allowed;
            }
        }
        if ($found == []) {
            throw new Exception("sendinvite: requested IdP token for and IdP identifier which is not within the allowed list for this user");
        }
        $federation = $validator->existingFederation($fedId);
        $newInstFlag = $federation->getAttributes('fed:autoregister-new-inst');
        if ($newInstFlag === []) {
            throw new Exception("sendinvite: You tried to register an IdP in self-service, but this federation does not allow self-service!");
        }
        $extinfo = $catInstance->getExternalDBEntityDetails($newexternalid, strtoupper($fedId).'01');
        // see if the inst name is defined in the currently set language; if not, pick its English name; if N/A, pick the last in the list
        $prettyprintname = "";
        foreach ($extinfo['names'] as $lang => $name) {
            if ($lang == $languageInstance->getLang()) {
                $prettyprintname = $name;
            }
        }
        if ($prettyprintname == "" && isset($extinfo['names']['en'])) {
            $prettyprintname = $extinfo['names']['en'];
        }
        if ($prettyprintname == "") {
            foreach ($extinfo['names'] as $name) {
                $prettyprintname = $name;
            }
        }
        if(\config\Master::FUNCTIONALITY_FLAGS['SINGLE_SERVICE'] === 'MSP') {
            $participant_type = \core\IdP::TYPE_SP;
        } else {
            $participant_type = $extinfo['type'];
        }
        // fill the rest of the text
        $introtext = "EXISTING-FED";
        // do the token creation magic
        $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $prettyprintname, $newexternalid, $fedId);
        \core\common\Logging::writeSQLAudit_s($_SESSION['user'], "NEW", "IdP FUTURE (self) - Token created for " . implode(",", $validAddresses));        
        break; 
    case OPERATION_MODE_NEWFROMDB:
        $redirectDestination = "../overview_federation.php?";
        if (count($validAddresses) == 0) {
            header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
            exit(1);
        }
        // a real external DB entry was submitted and all the required parameters are there
        $externals = $validator->string($_POST['externals']);
        [$fedId, $newexternalid] = explode('-', $externals, 2);
        $extinfo = $catInstance->getExternalDBEntityDetails($newexternalid, strtoupper($fedId).'01');
        $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($extinfo['country']);
        if ($new_idp_authorized_fedadmin !== TRUE) {
            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureParticipant . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
        }
        $federation = $validator->existingFederation($extinfo['country']);
        $newcountry = $extinfo['country'];
        // see if the inst name is defined in the currently set language; if not, pick its English name; if N/A, pick the last in the list
        $prettyprintname = "";
        foreach ($extinfo['names'] as $lang => $name) {
            if ($lang == $languageInstance->getLang()) {
                $prettyprintname = $name;
            }
        }
        if ($prettyprintname == "" && isset($extinfo['names']['en'])) {
            $prettyprintname = $extinfo['names']['en'];
        }
        if ($prettyprintname == "") {
            foreach ($extinfo['names'] as $name) {
                $prettyprintname = $name;
            }
        }
        if(\config\Master::FUNCTIONALITY_FLAGS['SINGLE_SERVICE'] === 'MSP') {
            $participant_type = \core\IdP::TYPE_SP;
        } else {
            $participant_type = $extinfo['type'];
        }
        // fill the rest of the text
        $introtext = "EXISTING-FED";
        // do the token creation magic
        $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $prettyprintname, $newexternalid, $fedId);
        \core\common\Logging::writeSQLAudit_s($_SESSION['user'], "NEW", "IdP FUTURE  - Token created for " . implode(",", $validAddresses));
        break;
    default: // includes OPERATION_MODE_INVALID
        // second param is TRUE, so the variable *will* contain a string
        // i.e. ignore Scrutinizer type warning later
        $wrongcontent = print_r($_POST, TRUE);
        echo "<pre>Wrong parameters in POST:
" . htmlspecialchars(/** @scrutinizer ignore-type */ $wrongcontent) . "
</pre>";
        exit(1);
}

// send, and invalidate the token immediately if the mail could not be sent!

$status = [];
$allEncrypted = TRUE;
$allClear = TRUE;
foreach ($newtokens as $onetoken => $oneDest) {
    $sent = \core\common\OutsideComm::adminInvitationMail($oneDest, $introtext, $onetoken, $prettyprintname, $federation, $participant_type);
    if ($sent["SENT"] === FALSE) {
        $mgmt->invalidateToken($onetoken);
    } else {
        $status[$onetoken] = $sent["TRANSPORT"];
        if (!$sent["TRANSPORT"]) {
            $allEncrypted = FALSE;
        } else {
            $allClear = FALSE;
        }
    }
}

if (count($status) == 0) {
    switch ($operationMode) {
        case OPERATION_MODE_SELF_ADMIN_ADD:
        case OPERATION_MODE_SELF_NEWFROMDB:
            print("FAILURE");
            break;
        default:
            header("Location: $redirectDestination" . "invitation=FAILURE");
            exit;
    }
}
$finalDestParams = "invitation=SUCCESS";
if (count($status) < count($totalSegments)) { // only a subset of mails was sent, update status
    $finalDestParams = "invitation=PARTIAL";
}
$finalDestParams .= "&successcount=" . count($status);
if ($allEncrypted === TRUE) {
    $finalDestParams .= "&transportsecurity=ENCRYPTED";
} elseif ($allClear === TRUE) {
    $finalDestParams .= "&transportsecurity=CLEAR";
} else {
    $finalDestParams .= "&transportsecurity=PARTIAL";
}

switch ($operationMode) {
    case OPERATION_MODE_SELF_ADMIN_ADD:
    case OPERATION_MODE_SELF_NEWFROMDB:
        print("SUCCESS");
        break;
    default:
        header("Location: $redirectDestination" . $finalDestParams);
}





GEANT / CAT

Issues (204)

Security Analysis 13 potential vulnerabilities

web/admin/inc/sendinvite.inc.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like