Test Failed
Push — master ( 215916...1607c4 )
by Tomasz
09:30
created
web/admin/action_enrollment.php 2 patches
Switch Indentation   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -52,36 +52,36 @@
 block discarded – undo
52 52
 }
53 53
 
54 54
 switch ($_GET['token']) {
55
-    case "EDUGAIN-SELF-REGISTER":
56
-        $token = "EDUGAIN-SELF-REGISTER";
57
-        $extIdUnfiltered = filter_input(INPUT_GET,'extid');
58
-        $extIdArray = explode('-', htmlspecialchars(strip_tags($extIdUnfiltered)), 2);
59
-        $ROid = $extIdArray[0];
60
-        $extId = $extIdArray[1];
61
-        $fed = new \core\Federation(strtoupper(substr($ROid,0,2)));
62
-        $newInstFlag = $fed->getAttributes('fed:autoregister-new-inst');
63
-        if ($newInstFlag === []) {
64
-            $elements->errorPage(_("Error creating new IdP!"),_("You tried to register in self-service, but this federation does not allow self-service!"));
65
-        }
66
-        // we must be sure that this person admins the ext institution and that it falls into the current federation
67
-        if ($validator->existingExtInstitution($extId, $userEmail, $ROid) === 1) {
55
+        case "EDUGAIN-SELF-REGISTER":
56
+            $token = "EDUGAIN-SELF-REGISTER";
57
+            $extIdUnfiltered = filter_input(INPUT_GET,'extid');
58
+            $extIdArray = explode('-', htmlspecialchars(strip_tags($extIdUnfiltered)), 2);
59
+            $ROid = $extIdArray[0];
60
+            $extId = $extIdArray[1];
61
+            $fed = new \core\Federation(strtoupper(substr($ROid,0,2)));
62
+            $newInstFlag = $fed->getAttributes('fed:autoregister-new-inst');
63
+            if ($newInstFlag === []) {
64
+                $elements->errorPage(_("Error creating new IdP!"),_("You tried to register in self-service, but this federation does not allow self-service!"));
65
+            }
66
+            // we must be sure that this person admins the ext institution and that it falls into the current federation
67
+            if ($validator->existingExtInstitution($extId, $userEmail, $ROid) === 1) {
68
+                $checkval = \core\UserManagement::TOKENSTATUS_OK_NEW;
69
+            }
70
+            // and check that this institution does not match anuthing in CAT.
71
+            $usermgmt = new \core\UserManagement();
72
+            if ($usermgmt->checkForCatMatch($extId, $ROid) === 1) {
73
+                $elements->errorPage(_("Error creating new IdP!"),_("You tried to register a new institution while it already has a match in CAT or your email is not not listed as admin for this institution in the eduroam DB!"));            
74
+            }
75
+            break;
76
+        case "SELF-REGISTER":
77
+            $token = "SELF-REGISTER";
68 78
             $checkval = \core\UserManagement::TOKENSTATUS_OK_NEW;
69
-        }
70
-        // and check that this institution does not match anuthing in CAT.
71
-        $usermgmt = new \core\UserManagement();
72
-        if ($usermgmt->checkForCatMatch($extId, $ROid) === 1) {
73
-            $elements->errorPage(_("Error creating new IdP!"),_("You tried to register a new institution while it already has a match in CAT or your email is not not listed as admin for this institution in the eduroam DB!"));            
74
-        }
75
-        break;
76
-    case "SELF-REGISTER":
77
-        $token = "SELF-REGISTER";
78
-        $checkval = \core\UserManagement::TOKENSTATUS_OK_NEW;
79
-        $federation = \config\ConfAssistant::CONSORTIUM['selfservice_registration'];
80
-        break;
81
-    default:
82
-        $tokenUnfiltered = $validator->token(filter_input(INPUT_GET,'token'));
83
-        $token = htmlspecialchars(strip_tags($tokenUnfiltered));
84
-        $checkval = $usermgmt->checkTokenValidity($token);
79
+            $federation = \config\ConfAssistant::CONSORTIUM['selfservice_registration'];
80
+            break;
81
+        default:
82
+            $tokenUnfiltered = $validator->token(filter_input(INPUT_GET,'token'));
83
+            $token = htmlspecialchars(strip_tags($tokenUnfiltered));
84
+            $checkval = $usermgmt->checkTokenValidity($token);
85 85
 }
86 86
 
87 87
 if ($checkval < 0) {
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 ?>
31 31
 <?php
32 32
 
33
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
33
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
34 34
 
35 35
 $auth = new \web\lib\admin\Authentication();
36 36
 $deco = new \web\lib\admin\PageDecoration();
@@ -44,24 +44,24 @@  discard block
 block discarded – undo
44 44
 
45 45
 
46 46
 if (!isset($_GET['token'])) {
47
-    $elements->errorPage(_("Error creating new IdP binding!"),_("This page needs to be called with a valid invitation token!"));
47
+    $elements->errorPage(_("Error creating new IdP binding!"), _("This page needs to be called with a valid invitation token!"));
48 48
 }
49 49
 
50 50
 if (\config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL && $_GET['token'] == "SELF-REGISTER") {
51
-    $elements->errorPage(_("Error creating new IdP binding!"),_("You tried to register in self-service, but this deployment does not allow self-service!"));
51
+    $elements->errorPage(_("Error creating new IdP binding!"), _("You tried to register in self-service, but this deployment does not allow self-service!"));
52 52
 }
53 53
 
54 54
 switch ($_GET['token']) {
55 55
     case "EDUGAIN-SELF-REGISTER":
56 56
         $token = "EDUGAIN-SELF-REGISTER";
57
-        $extIdUnfiltered = filter_input(INPUT_GET,'extid');
57
+        $extIdUnfiltered = filter_input(INPUT_GET, 'extid');
58 58
         $extIdArray = explode('-', htmlspecialchars(strip_tags($extIdUnfiltered)), 2);
59 59
         $ROid = $extIdArray[0];
60 60
         $extId = $extIdArray[1];
61
-        $fed = new \core\Federation(strtoupper(substr($ROid,0,2)));
61
+        $fed = new \core\Federation(strtoupper(substr($ROid, 0, 2)));
62 62
         $newInstFlag = $fed->getAttributes('fed:autoregister-new-inst');
63 63
         if ($newInstFlag === []) {
64
-            $elements->errorPage(_("Error creating new IdP!"),_("You tried to register in self-service, but this federation does not allow self-service!"));
64
+            $elements->errorPage(_("Error creating new IdP!"), _("You tried to register in self-service, but this federation does not allow self-service!"));
65 65
         }
66 66
         // we must be sure that this person admins the ext institution and that it falls into the current federation
67 67
         if ($validator->existingExtInstitution($extId, $userEmail, $ROid) === 1) {
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         // and check that this institution does not match anuthing in CAT.
71 71
         $usermgmt = new \core\UserManagement();
72 72
         if ($usermgmt->checkForCatMatch($extId, $ROid) === 1) {
73
-            $elements->errorPage(_("Error creating new IdP!"),_("You tried to register a new institution while it already has a match in CAT or your email is not not listed as admin for this institution in the eduroam DB!"));            
73
+            $elements->errorPage(_("Error creating new IdP!"), _("You tried to register a new institution while it already has a match in CAT or your email is not not listed as admin for this institution in the eduroam DB!"));            
74 74
         }
75 75
         break;
76 76
     case "SELF-REGISTER":
@@ -79,23 +79,23 @@  discard block
 block discarded – undo
79 79
         $federation = \config\ConfAssistant::CONSORTIUM['selfservice_registration'];
80 80
         break;
81 81
     default:
82
-        $tokenUnfiltered = $validator->token(filter_input(INPUT_GET,'token'));
82
+        $tokenUnfiltered = $validator->token(filter_input(INPUT_GET, 'token'));
83 83
         $token = htmlspecialchars(strip_tags($tokenUnfiltered));
84 84
         $checkval = $usermgmt->checkTokenValidity($token);
85 85
 }
86 86
 
87 87
 if ($checkval < 0) {
88 88
     echo $deco->pageheader(_("Error creating new IdP binding!"), "ADMIN-IDP");
89
-    echo "<h1>" . _("Error creating new IdP binding!") . "</h1>";
89
+    echo "<h1>"._("Error creating new IdP binding!")."</h1>";
90 90
     switch ($checkval) {
91 91
         case \core\UserManagement::TOKENSTATUS_FAIL_ALREADYCONSUMED:
92
-            echo "<p>" . sprintf(_("Sorry... this token has already been used. The %s is already created. If you got the invitation from a mailing list, probably someone else used it before you."), $elements->nomenclatureParticipant) . "</p>";
92
+            echo "<p>".sprintf(_("Sorry... this token has already been used. The %s is already created. If you got the invitation from a mailing list, probably someone else used it before you."), $elements->nomenclatureParticipant)."</p>";
93 93
             break;
94 94
         case \core\UserManagement::TOKENSTATUS_FAIL_EXPIRED:
95
-            echo "<p>" . sprintf(_("Sorry... this token has expired. Invitation tokens are valid for 24 hours. The %s administrator can create a new one for you."), $elements->nomenclatureFed) . "</p>";
95
+            echo "<p>".sprintf(_("Sorry... this token has expired. Invitation tokens are valid for 24 hours. The %s administrator can create a new one for you."), $elements->nomenclatureFed)."</p>";
96 96
             break;
97 97
         default:
98
-            echo "<p>" . _("Sorry... you have come to the enrollment page without a valid token. Are you a nasty person? If not, you should go to <a href='overview_user.php'>your profile page</a> instead.") . "</p>";
98
+            echo "<p>"._("Sorry... you have come to the enrollment page without a valid token. Are you a nasty person? If not, you should go to <a href='overview_user.php'>your profile page</a> instead.")."</p>";
99 99
     }
100 100
     echo $deco->footer();
101 101
     throw new Exception("Terminating because something is wrong with the token we received.");
@@ -109,17 +109,17 @@  discard block
 block discarded – undo
109 109
 switch ($token) {
110 110
     case "EDUGAIN-SELF-REGISTER":
111 111
         $newidp = $usermgmt->createIdPFromExternal($extId, $fed, $user);
112
-        $loggerInstance->writeAudit($user, "MOD", "IdP " . $newidp->identifier . " - selfservice eduGAIN registration");
112
+        $loggerInstance->writeAudit($user, "MOD", "IdP ".$newidp->identifier." - selfservice eduGAIN registration");
113 113
         break;    
114 114
     case "SELF-REGISTER":
115 115
         $fed = new \core\Federation($federation);
116 116
         $newidp = new \core\IdP($fed->newIdP('SELF', core\IdP::TYPE_IDPSP, $user, "FED", "SELFSERVICE"));
117
-        $loggerInstance->writeAudit($user, "MOD", "IdP " . $newidp->identifier . " - selfservice registration");
117
+        $loggerInstance->writeAudit($user, "MOD", "IdP ".$newidp->identifier." - selfservice registration");
118 118
         break;
119 119
     default:
120 120
         $newidp = $usermgmt->createIdPFromToken($token, $user);
121 121
         $usermgmt->invalidateToken($token);
122
-        $loggerInstance->writeAudit($user, "MOD", "IdP " . $newidp->identifier . " - Token used and invalidated");
122
+        $loggerInstance->writeAudit($user, "MOD", "IdP ".$newidp->identifier." - Token used and invalidated");
123 123
         break;
124 124
 }
125 125
 
Please login to merge, or discard this patch.
web/lib/admin/AbstractMap.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
         $wizard = new \web\lib\admin\Wizard($wizardMode);
139 139
         $wizard->setMessages();
140 140
         $retval = "<fieldset class='option_container_map'>
141
-        <legend><strong>" . _("Location") . "</strong></legend>";
141
+        <legend><strong>" . _("Location")."</strong></legend>";
142 142
         $retval .= $wizard->displayHelp("location");
143 143
         if ($additional) {
144 144
             $retval .= _("You can enter an <strong>additional</strong> location here. You can see the already defined locations in the 'General Information' field.");
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
      */
156 156
     protected function htmlPostEdit($allowDirectInput) {
157 157
         \core\common\Entity::intoThePotatoes();
158
-        $retval = "<br/>" . _("Latitude:") . " <input style='width:80px' name='geo_lat' id='geo_lat' " .($allowDirectInput ? "": "readonly"). ">" . _("Longitude:") . " <input name='geo_long' id='geo_long' style='width:80px' " .($allowDirectInput ? "": "readonly"). "></fieldset>";
158
+        $retval = "<br/>"._("Latitude:")." <input style='width:80px' name='geo_lat' id='geo_lat' ".($allowDirectInput ? "" : "readonly").">"._("Longitude:")." <input name='geo_long' id='geo_long' style='width:80px' ".($allowDirectInput ? "" : "readonly")."></fieldset>";
159 159
         \core\common\Entity::outOfThePotatoes();
160 160
         return $retval;
161 161
     }
Please login to merge, or discard this patch.
web/skins/msp/copyright.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 <head>
25 25
 <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1.0, user-scalable=no">
26 26
 <link rel="stylesheet" media="screen" type="text/css" href="<?php echo $Gui->skinObject->findResourceUrl("CSS", "cat-user.css"); ?>" />
27
-<title><?php echo config\Master::APPEARANCE['productname'];?> Copyright and Licensing</title>
27
+<title><?php echo config\Master::APPEARANCE['productname']; ?> Copyright and Licensing</title>
28 28
 </head>
29 29
 <body>
30 30
 <div id="wrap">
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
             <div id="user_page" style="display:block">
36 36
                 <?php echo $divs->divPagetitle(config\Master::APPEARANCE['productname']." Copyright and Licensing", ""); ?>
37 37
                 <div style="padding:20px">
38
-            <?php require dirname(dirname(__DIR__)) . "/copyright.inc.php"; ?>
38
+            <?php require dirname(dirname(__DIR__))."/copyright.inc.php"; ?>
39 39
                 </div>
40 40
             </div>
41 41
         </div>
Please login to merge, or discard this patch.
web/skins/msp/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
     print "vendorlogo ='';\n";
50 50
 }
51 51
 
52
-print 'downloadMessage = "'.$Gui->textTemplates->templates[\web\lib\user\DOWNLOAD_MESSAGE] . '";';
52
+print 'downloadMessage = "'.$Gui->textTemplates->templates[\web\lib\user\DOWNLOAD_MESSAGE].'";';
53 53
 //TODO modify this based on OS detection
54 54
 $userAgent = $_SERVER['HTTP_USER_AGENT'] ?? "";
55 55
 if (preg_match('/Android/', $userAgent)) {
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     <?php echo $divs->divHeading($visibility); ?>
80 80
     <div id="main_page">
81 81
         <div id="loading_ico">
82
-          <?php echo _("Authenticating") . "..." ?><br><img src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/loading51.gif"); ?>" alt="Authenticating ..."/>
82
+          <?php echo _("Authenticating")."..." ?><br><img src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/loading51.gif"); ?>" alt="Authenticating ..."/>
83 83
         </div>
84 84
         <div id="info_overlay"> <!-- device info -->
85 85
             <div id="info_window"></div>
Please login to merge, or discard this patch.
web/skins/msp/Divs.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     public function divSilverbullet() {
68 68
         $retval = "
69 69
 <div id='silverbullet'>"
70
-    . $this->Gui->textTemplates->templates[user\SB_GO_AWAY] . 
70
+    . $this->Gui->textTemplates->templates[user\SB_GO_AWAY]. 
71 71
     "</div>
72 72
     ";
73 73
         return $retval;
@@ -109,9 +109,9 @@  discard block
 block discarded – undo
109 109
     public function divProfiles() {
110 110
         return "
111 111
 <div id='profiles'> <!-- this is the profile selection filled during run time -->
112
-    <div id='profiles_h' class='sub_h'>" . $this->Gui->textTemplates->templates[user\PROFILE_SELECTION] . "
112
+    <div id='profiles_h' class='sub_h'>" . $this->Gui->textTemplates->templates[user\PROFILE_SELECTION]."
113 113
     </div>" .
114
-"<select id='profile_list'></select><div id='profile_desc' class='profile_desc'></div>" .
114
+"<select id='profile_list'></select><div id='profile_desc' class='profile_desc'></div>".
115 115
                 "</div>";
116 116
     }
117 117
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
     public function divInstitution($selectButton = TRUE) {
127 127
         $retval = "<div id='institution_name'>
128 128
     <span id='inst_name_span'></span> <div id='inst_extra_text'></div><!-- this will be filled with the IdP name -->" .
129
-                ($selectButton ? "<a  id='select_another' class='signin' href=\"\">" . $this->Gui->textTemplates->templates[user\INSTITUTION_SELECTION] . "</a>" : "") .
129
+                ($selectButton ? "<a  id='select_another' class='signin' href=\"\">".$this->Gui->textTemplates->templates[user\INSTITUTION_SELECTION]."</a>" : "").
130 130
                 "</div>";
131 131
         $retval .= $this->emptyImage('idp_logo', 'IdP Logo');
132 132
         return $retval;
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
     public function divOtherinstallers() {
141 141
         $retval = "
142 142
 <div class='sub_h'>
143
-    <div id='other_installers'>".$this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE] . "
143
+    <div id='other_installers'>".$this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE]."
144 144
          <table id='device_list' style='padding:0px;'>";
145 145
 
146 146
         foreach ($this->Gui->listDevices(isset($_REQUEST['hidden']) ? $_REQUEST['hidden'] : 0) as $group => $deviceGroup) {
@@ -148,18 +148,18 @@  discard block
 block discarded – undo
148 148
             $deviceIndex = 0;
149 149
 
150 150
             $imgTag = "";
151
-            $imgLocation = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/" . $group . ".png");
151
+            $imgLocation = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/".$group.".png");
152 152
             if ($imgLocation !== FALSE) {
153
-                $imgTag = '<img src="' . $imgLocation . '" alt="' . $group . ' Device" title="' . $group . ' Device">';
153
+                $imgTag = '<img src="'.$imgLocation.'" alt="'.$group.' Device" title="'.$group.' Device">';
154 154
             }
155
-            $retval .= '<tbody><tr><td class="vendor" rowspan="' . $groupIndex . '">' . $imgTag . '</td>';
155
+            $retval .= '<tbody><tr><td class="vendor" rowspan="'.$groupIndex.'">'.$imgTag.'</td>';
156 156
             foreach ($deviceGroup as $d => $D) {
157 157
                 if ($deviceIndex) {
158 158
                     $retval .= '<tr>';
159 159
                 }
160
-                $retval .= "<td><button id='" . $d . "'>" . $D['display'] . "</button>"
161
-                        . "<div class='device_info' id='info_" . $d . "'></div></td>"
162
-                        . "<td><button class='more_info_b' id='info_b_" . $d . "'>i</button></td></tr>\n";
160
+                $retval .= "<td><button id='".$d."'>".$D['display']."</button>"
161
+                        . "<div class='device_info' id='info_".$d."'></div></td>"
162
+                        . "<td><button class='more_info_b' id='info_b_".$d."'>i</button></td></tr>\n";
163 163
                 $deviceIndex++;
164 164
             }
165 165
             $retval .= "</tbody>";
@@ -172,15 +172,15 @@  discard block
 block discarded – undo
172 172
     }
173 173
 
174 174
     public function divGuessOs($operatingSystem) {
175
-        $vendorlogo = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/" . $operatingSystem['group'] . ".png");
175
+        $vendorlogo = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/".$operatingSystem['group'].".png");
176 176
         $vendorstyle = "";
177 177
         if ($vendorlogo !== FALSE) {
178
-            $vendorstyle = "style='background-image:url(\"" . $vendorlogo . "\")'";
178
+            $vendorstyle = "style='background-image:url(\"".$vendorlogo."\")'";
179 179
         }
180 180
         $deleteIcon = $this->Gui->skinObject->findResourceUrl("IMAGES", "icons/delete_32.png");
181 181
         $deleteImg = "";
182 182
         if ($deleteIcon !== FALSE) {
183
-            $deleteImg = "<img id='cross_icon_" . $operatingSystem['device'] . "' src='$deleteIcon' >";
183
+            $deleteImg = "<img id='cross_icon_".$operatingSystem['device']."' src='$deleteIcon' >";
184 184
         }
185 185
         return "
186 186
 <div class='sub_h' id='guess_os'>
@@ -188,23 +188,23 @@  discard block
 block discarded – undo
188 188
     <table id='browser'>
189 189
         <tr>
190 190
             <td>
191
-                <button class='large_button guess_os' $vendorstyle id='g_" . $operatingSystem['device'] . "'>
191
+                <button class='large_button guess_os' $vendorstyle id='g_".$operatingSystem['device']."'>
192 192
                     $deleteImg
193
-                    <div class='download_button_text_1' id='download_button_header_" . $operatingSystem['device'] . "'> " . $this->Gui->textTemplates->templates[user\DOWNLOAD_MESSAGE] . "
193
+                    <div class='download_button_text_1' id='download_button_header_".$operatingSystem['device']."'> ".$this->Gui->textTemplates->templates[user\DOWNLOAD_MESSAGE]."
194 194
                     </div>
195 195
                     <div class='download_button_text'>" .
196
-                $operatingSystem['display'] . "
196
+                $operatingSystem['display']."
197 197
                     </div>
198 198
                 </button>
199
-                <div class='device_info' id='info_g_" . $operatingSystem['device'] . "'></div>
199
+                <div class='device_info' id='info_g_" . $operatingSystem['device']."'></div>
200 200
           </td>
201 201
           <td style='vertical-align:top'>
202
-               <button class='more_info_b large_button' id='g_info_b_" . $operatingSystem['device'] . "'>i</button>
202
+               <button class='more_info_b large_button' id='g_info_b_" . $operatingSystem['device']."'>i</button>
203 203
           </td>
204 204
       </tr>
205 205
     </table> <!-- id='browser' -->
206 206
     <div class='sub_h'>
207
-       <a href='javascript:other_installers()'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE] . "</a>
207
+       <a href='javascript:other_installers()'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE]."</a>
208 208
     </div>
209 209
 </div> <!-- id='guess_os' -->";
210 210
     }
Please login to merge, or discard this patch.
web/skins/msp/user/cat_info.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
          " . $Tou['title'] . "
52 52
     </h1>
53 53
 <div id='tou_1'>" . $Tou['subtitle'] .
54
-               '<div style="direction:ltr">' . $Tou['short'] . "</div>
54
+                '<div style="direction:ltr">' . $Tou['short'] . "</div>
55 55
 </div>
56 56
 <div id='all_tou_link'><a href='javascript:showTOU()'>Click here to see the full terms</a></div>
57 57
 <div id='tou_2' style='display:none; padding-top:20px; direction:ltr'>" .
Please login to merge, or discard this patch.
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
  * the receiving end to strip this marker and not add the title by itself.
32 32
  *
33 33
  */
34
-require_once dirname(dirname(dirname((dirname(dirname(__FILE__)))))) . "/config/_config.php";
34
+require_once dirname(dirname(dirname((dirname(dirname(__FILE__))))))."/config/_config.php";
35 35
 
36 36
 $Gui = new \web\lib\user\Gui();
37 37
 
@@ -41,46 +41,46 @@  discard block
 block discarded – undo
41 41
 $subpage = $_REQUEST['subpage'];
42 42
 switch ($page) {
43 43
     case 'about':
44
-        include_once dirname(dirname(dirname(dirname(__FILE__)))) . "/user/about_cat.inc.php";
44
+        include_once dirname(dirname(dirname(dirname(__FILE__))))."/user/about_cat.inc.php";
45 45
         $out = "<div class='padding'>$out</div>";
46 46
         break;
47 47
     case 'tou':
48
-        include_once dirname(dirname(dirname(dirname(__FILE__)))) . "/user/tou.inc.php";
48
+        include_once dirname(dirname(dirname(dirname(__FILE__))))."/user/tou.inc.php";
49 49
         $out = "no_title<div>
50 50
            <h1>
51
-         " . $Tou['title'] . "
51
+         " . $Tou['title']."
52 52
     </h1>
53
-<div id='tou_1'>" . $Tou['subtitle'] .
54
-               '<div style="direction:ltr">' . $Tou['short'] . "</div>
53
+<div id='tou_1'>" . $Tou['subtitle'].
54
+               '<div style="direction:ltr">'.$Tou['short']."</div>
55 55
 </div>
56 56
 <div id='all_tou_link'><a href='javascript:showTOU()'>Click here to see the full terms</a></div>
57 57
 <div id='tou_2' style='display:none; padding-top:20px; direction:ltr'>" .
58
-                $Tou['full'] . "
58
+                $Tou['full']."
59 59
 </div>
60 60
 </div>
61 61
 ";
62 62
         break;
63 63
     case 'help':
64
-        include_once dirname(dirname(dirname(dirname(__FILE__)))) . "/user/faq.inc.php";
64
+        include_once dirname(dirname(dirname(dirname(__FILE__))))."/user/faq.inc.php";
65 65
         switch ($subpage) {
66 66
             case 'contact':
67 67
             case 'idp_not_listed':
68 68
             case 'device_not_listed':
69 69
             case 'what_is_eduroam':
70
-                $out = "no_title<div><h1>" . _("Help") . "</h1>";
70
+                $out = "no_title<div><h1>"._("Help")."</h1>";
71 71
                 foreach ($Faq as $faqItem) {
72 72
                     if (!empty($faqItem['id']) && $faqItem['id'] == $subpage) {
73
-                        $out .= "<div><h3>" . $faqItem['title'] . "</h3>\n";
74
-                        $out .= "" . $faqItem['text'] . "</div>\n";
73
+                        $out .= "<div><h3>".$faqItem['title']."</h3>\n";
74
+                        $out .= "".$faqItem['text']."</div>\n";
75 75
                     }
76 76
                 }
77 77
                 $out .= "</div>";
78 78
                 break;
79 79
             case 'faq':
80
-                $out = "no_title<div><h1>" . _("Frequently Asked Questions") . "</h1>";
80
+                $out = "no_title<div><h1>"._("Frequently Asked Questions")."</h1>";
81 81
                 foreach ($Faq as $faqItem) {
82
-                    $out .= "<div><h3>" . $faqItem['title'] . "</h3>\n";
83
-                    $out .= "" . $faqItem['text'] . "</div>\n";
82
+                    $out .= "<div><h3>".$faqItem['title']."</h3>\n";
83
+                    $out .= "".$faqItem['text']."</div>\n";
84 84
                 }
85 85
                 $out .= "</div>";
86 86
                 break;
@@ -104,15 +104,15 @@  discard block
 block discarded – undo
104 104
                     $rn = uniqid();
105 105
                     $_SESSION['remindIdP'] = $rn;
106 106
                     $out .= "<input type='hidden' id='remindIdPs' value='$rn'>";
107
-                    $out .= "<p><button type='button' onclick='goAdmin(); return(false);'>" . _("Login") . "</button>";
108
-                    $out .= "<br/><br/><p>" . _("Did you forget with which Identity Provider you logged in to the system? We can try to find out if you specify the email address with which you were invited to the system in the box below. This may not work if you were invited from a third-party website via the AdminAPI.") . "</p>";
109
-                    $out .= "<input id='remindIdP' type='text'/><button onclick='remindIdPF(); return false;'>" . _("Get IdP Reminder") . "</button>";
107
+                    $out .= "<p><button type='button' onclick='goAdmin(); return(false);'>"._("Login")."</button>";
108
+                    $out .= "<br/><br/><p>"._("Did you forget with which Identity Provider you logged in to the system? We can try to find out if you specify the email address with which you were invited to the system in the box below. This may not work if you were invited from a third-party website via the AdminAPI.")."</p>";
109
+                    $out .= "<input id='remindIdP' type='text'/><button onclick='remindIdPF(); return false;'>"._("Get IdP Reminder")."</button>";
110 110
                     $out .= "<div id='remindIdPd'><span id='remindIdPh'></span><ul id='remindIdPl'></ul></div>";
111 111
                     $out = "<div  class='padding'>$out</div>";
112 112
                 }
113 113
                 break;
114 114
             case 'develop':
115
-                include_once dirname(dirname(dirname(dirname(__FILE__)))) . "/user/devel.inc.php";
115
+                include_once dirname(dirname(dirname(dirname(__FILE__))))."/user/devel.inc.php";
116 116
                 $out = "<div class='padding'>$out</div>";
117 117
                 break;
118 118
         }
Please login to merge, or discard this patch.
web/skins/msp/resources/css/cat-user.css.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 header("Content-Type:text/css");
22
-require dirname(dirname(dirname(dirname(dirname(dirname(__FILE__)))))) . "/config/_config.php";
22
+require dirname(dirname(dirname(dirname(dirname(dirname(__FILE__))))))."/config/_config.php";
23 23
 $langInstance = new core\common\Language();
24 24
 $start = $langInstance->rtl ? "right" : "left";
25 25
 $end = $langInstance->rtl ? "left" : "right";
@@ -399,8 +399,8 @@  discard block
 block discarded – undo
399 399
 
400 400
 #message_only {
401 401
     padding-top: 20px;
402
-    padding-<?php echo $start;?>: 30px;
403
-    padding-<?php echo $end;?>: 30px;
402
+    padding-<?php echo $start; ?>: 30px;
403
+    padding-<?php echo $end; ?>: 30px;
404 404
     font-weight: normal;
405 405
     position: relative;
406 406
     font-size: 15px;
Please login to merge, or discard this patch.
utils/update_monitor_copy_2.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
  * in a separate way and it is crucial that the updates are porformed more often (hourly)
28 28
  */
29 29
 namespace utils;
30
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
30
+require_once dirname(dirname(__FILE__))."/config/_config.php";
31 31
 
32 32
 setlocale(LC_CTYPE, "en_US.UTF-8");
33 33
 
@@ -52,4 +52,4 @@  discard block
 block discarded – undo
52 52
 
53 53
 $timeEnd = microtime(true);
54 54
 $timeElapsed = $timeEnd - $timeStart;
55
-printf("Whole update done in %.2fs\n",$timeElapsed);
56 55
\ No newline at end of file
56
+printf("Whole update done in %.2fs\n", $timeElapsed);
57 57
\ No newline at end of file
Please login to merge, or discard this patch.
utils/UpdateFromMonitor.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
  * update the local copy
25 25
  */
26 26
 namespace utils;
27
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
27
+require_once dirname(dirname(__FILE__))."/config/_config.php";
28 28
 
29 29
 setlocale(LC_CTYPE, "en_US.UTF-8");
30 30
 
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         $this->db_ext->query("SET NAMES 'utf8'");
99 99
         $this->db_local->query("SET NAMES 'utf8mb4'");
100 100
         $result = $this->db_ext->query("SELECT * FROM $table");
101
-        $queryFields = implode(',', array_column($this->fields[$db][$table_name],0));
101
+        $queryFields = implode(',', array_column($this->fields[$db][$table_name], 0));
102 102
         while ($row = $result->fetch_assoc()) {
103 103
             $v = [];
104 104
             foreach ($this->fields[$db][$table_name] as $field) {
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
                     }
117 117
                 }
118 118
             }
119
-            $queryValues = implode(',',$v);
119
+            $queryValues = implode(',', $v);
120 120
             $query = "INSERT INTO $tmpTable (".$queryFields.") VALUES (".$queryValues.")";
121 121
             $this->db_local->query($query);
122 122
         }
@@ -134,9 +134,9 @@  discard block
 block discarded – undo
134 134
             $realms = explode(',', $row[1]);
135 135
             foreach ($contacts as $contact) {
136 136
                 foreach ($realms as $realm) {
137
-                    $email = empty($contact['mail']) ? 'NULL' :'"'.$contact['mail'].'"';
138
-                    $name = empty($contact['name']) ? 'NULL' :'"'.$contact['name'].'"';
139
-                    $phone = empty($contact['phone']) ? 'NULL' :'"'.$contact['phone'].'"';
137
+                    $email = empty($contact['mail']) ? 'NULL' : '"'.$contact['mail'].'"';
138
+                    $name = empty($contact['name']) ? 'NULL' : '"'.$contact['name'].'"';
139
+                    $phone = empty($contact['phone']) ? 'NULL' : '"'.$contact['phone'].'"';
140 140
                     $id = '"'.$row[2].'"';
141 141
                     $ROid = '"'.$row[3].'"';
142 142
                     $query = "INSERT INTO tmp_institution_admins (name, email, phone, inst_realm, instid, ROid)"
@@ -161,9 +161,9 @@  discard block
 block discarded – undo
161 161
     }
162 162
 
163 163
     private function escape($inp) {
164
-        $out=str_replace('\\','\\\\',$inp);
165
-        $out=str_replace('"','\"',$out);
166
-        $out=str_replace('?','\?',$out);
164
+        $out = str_replace('\\', '\\\\', $inp);
165
+        $out = str_replace('"', '\"', $out);
166
+        $out = str_replace('?', '\?', $out);
167 167
         $out = 'convert(cast(convert("'.$out.'" using latin1) as binary) using utf8)';
168 168
         return($out);
169 169
     }
Please login to merge, or discard this patch.