GEANT /
CAT
| Conditions | 10 |
| Paths | 14 |
| Total Lines | 37 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public static function deleteObsoleteTempDirs() { |
||
| 26 | $downloadsDirs = [ |
||
| 27 | 'site_installers' => dirname(dirname(dirname(dirname(__FILE__)))) . "/var/installer_cache", |
||
| 28 | 'silverbullet' => dirname(dirname(dirname(dirname(__FILE__)))) . "/var/silverbullet" |
||
| 29 | ]; |
||
| 30 | $tm = time(); |
||
| 31 | $i = 0; |
||
| 32 | $Cache = []; |
||
| 33 | $dbHandle = \core\DBConnection::handle("FRONTEND"); |
||
| 34 | $result = $dbHandle->exec("SELECT download_path FROM downloads WHERE download_path IS NOT NULL"); |
||
| 35 | // SELECT -> mysqli_result, not a boolean |
||
| 36 | while ($r = mysqli_fetch_row(/** @scrutinizer ignore-type */ $result)) { |
||
| 37 | $e = explode('/', $r[0]); |
||
| 38 | $Cache[$e[count($e) - 2]] = 1; |
||
| 39 | } |
||
| 40 | foreach ($downloadsDirs as $downloads) { |
||
| 41 | if ($handle = opendir($downloads)) { |
||
| 42 | /* This is the correct way to loop over the directory. */ |
||
| 43 | while (false !== ($entry = readdir($handle))) { |
||
| 44 | if ($entry === '.' || $entry === '..' || $entry === '.gitignore') { |
||
| 45 | continue; |
||
| 46 | } |
||
| 47 | $ftime = $tm - filemtime($downloads . '/' . $entry); |
||
| 48 | if ($ftime < 3600) { |
||
| 49 | continue; |
||
| 50 | } |
||
| 51 | if (isset($Cache[$entry])) { |
||
| 52 | continue; |
||
| 53 | } |
||
| 54 | \core\common\Entity::rrmdir($downloads . '/' . $entry); |
||
| 55 | $i = $i + 1; |
||
| 56 | print "$entry\n"; |
||
| 57 | } |
||
| 58 | closedir($handle); |
||
| 59 | } |
||
| 60 | } |
||
| 61 | return $i; |
||
| 62 | } |
||
| 64 |
