GEANT /
CAT
| Conditions | 10 |
| Paths | 11 |
| Total Lines | 27 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 64 | public function printMenu($menu = NULL, $id = NULL) { |
||
| 65 | $menu = $menu ?? $this->menu; |
||
| 66 | if (count($menu) == 0) { |
||
| 67 | return; |
||
| 68 | } |
||
| 69 | $out = "\n<ul>\n"; |
||
| 70 | foreach ($menu as $menuItem) { |
||
| 71 | $itemVisibility = $menuItem['visibility'] ?? 'all'; |
||
| 72 | if ($this->visibility === 'all' || $itemVisibility === 'all' || $itemVisibility === $this->visibility) { |
||
| 73 | $iD = $menuItem['id'] ?? $id; |
||
| 74 | $catInfo = NULL; |
||
| 75 | if (!empty($menuItem['catInfo'])) { |
||
| 76 | $catInfo = 'javascript:infoCAT("' . $iD . '", "' . $menuItem['catInfo'][0] . '","' . $menuItem['catInfo'][1] . '")'; |
||
| 77 | } |
||
| 78 | if (!empty($menuItem['link']) && substr($menuItem['link'], 0, 1) === '/') { |
||
| 79 | $menuItem['link'] = \core\CAT::getRootUrlPath() . $menuItem['link']; |
||
| 80 | } |
||
| 81 | $link = $catInfo ?? $menuItem['link'] ?? ''; |
||
| 82 | $class = empty($menuItem['class']) ? '' : ' class="' . $menuItem['class'] . '"'; |
||
| 83 | $submenu = $menuItem['submenu'] ?? []; |
||
| 84 | $out .= $this->printMenuItem($menuItem['text'], $link, $class); |
||
| 85 | $out .= $this->printMenu($submenu, $iD); |
||
| 86 | $out .= "</li>\n"; |
||
| 87 | } |
||
| 88 | } |
||
| 89 | $out .= '</ul>'; |
||
| 90 | return($out); |
||
| 91 | } |
||
| 105 |
