Test Failed
Pull Request — master (#274)
by
unknown
21:19
created
web/admin/overview_user.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 namespace core;
23 23
 
24
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
24
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
25 25
 
26 26
 $instMgmt = new \core\UserManagement();
27 27
 $deco = new \web\lib\admin\PageDecoration();
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
             <?php echo $uiElements->infoblock($user->getAttributes(), "user", "User"); ?>
62 62
             <tr>
63 63
                 <td>
64
-                    <?php echo "" . _("Unique Identifier") ?>
64
+                    <?php echo ""._("Unique Identifier") ?>
65 65
                 </td>
66 66
                 <td>
67 67
                 </td>
@@ -74,14 +74,14 @@  discard block
 block discarded – undo
74 74
     <div>
75 75
         <?php
76 76
         if (\config\Master::DB['USER']['readonly'] === FALSE) {
77
-            echo "<a href='edit_user.php'><button>" . _("Edit User Details") . "</button></a>";
77
+            echo "<a href='edit_user.php'><button>"._("Edit User Details")."</button></a>";
78 78
         }
79 79
 
80 80
         if ($user->isFederationAdmin()) {
81
-            echo "<form action='overview_federation.php' method='GET' accept-charset='UTF-8'><button type='submit'>" . sprintf(_('Click here for %s management tasks'), $uiElements->nomenclatureFed) . "</button></form>";
81
+            echo "<form action='overview_federation.php' method='GET' accept-charset='UTF-8'><button type='submit'>".sprintf(_('Click here for %s management tasks'), $uiElements->nomenclatureFed)."</button></form>";
82 82
         }
83 83
         if ($user->isSuperadmin()) {
84
-            echo "<form action='112365365321.php' method='GET' accept-charset='UTF-8'><button type='submit'>" . _('Click here to access the superadmin page') . "</button></form>";
84
+            echo "<form action='112365365321.php' method='GET' accept-charset='UTF-8'><button type='submit'>"._('Click here to access the superadmin page')."</button></form>";
85 85
         }
86 86
         ?>
87 87
     </div>
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         if (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_SILVERBULLET'] == "LOCAL") {
95 95
             $target = "https://wiki.geant.org/x/6Zg7Bw"; // Managed IdP manual
96 96
         }
97
-        $helptext = "<h3 style='display:inline;'>" . sprintf(_("(Need help? Refer to the <a href='%s'>%s administrator manual</a>)"), $target, $uiElements->nomenclatureParticipant) . "</h3>";
97
+        $helptext = "<h3 style='display:inline;'>".sprintf(_("(Need help? Refer to the <a href='%s'>%s administrator manual</a>)"), $target, $uiElements->nomenclatureParticipant)."</h3>";
98 98
     } else {
99 99
         $helptext = "";
100 100
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
         // we need to run the Federation constructor
104 104
         $cat = new \core\CAT;
105 105
         /// first parameter: number of Identity Providers; second param is the literal configured term for 'Identity Provider' (you may or may not be able to add a plural suffix for your locale)
106
-        echo "<h2>" . sprintf(ngettext("You are managing the following <span style='display:none'>%d </span>%s:", "You are managing the following <strong>%d</strong> %s:", sizeof($hasInst)), sizeof($hasInst), $uiElements->nomenclatureParticipant) . "</h2>";
106
+        echo "<h2>".sprintf(ngettext("You are managing the following <span style='display:none'>%d </span>%s:", "You are managing the following <strong>%d</strong> %s:", sizeof($hasInst)), sizeof($hasInst), $uiElements->nomenclatureParticipant)."</h2>";
107 107
         $instlist = [];
108 108
         $my_idps = [];
109 109
         $myFeds = [];
@@ -196,14 +196,14 @@  discard block
 block discarded – undo
196 196
                         <td>
197 197
                             <?php
198 198
                             if ($blessedUser && \config\Master::DB['INST']['readonly'] === FALSE) {
199
-                                echo "<div style='white-space: nowrap;'><form method='post' action='inc/manageAdmins.inc.php?inst_id=" . $the_inst->identifier . "' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'><button type='submit'>" . _("Add/Remove Administrators") . "</button></form></div>";
199
+                                echo "<div style='white-space: nowrap;'><form method='post' action='inc/manageAdmins.inc.php?inst_id=".$the_inst->identifier."' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'><button type='submit'>"._("Add/Remove Administrators")."</button></form></div>";
200 200
                             }
201 201
                             ?>
202 202
                         </td>
203 203
                         <td> <!-- danger zone --> 
204 204
 
205 205
                             <form action='edit_participant_result.php?inst_id=<?php echo $the_inst->identifier; ?>' method='post' accept-charset='UTF-8'>
206
-                                <button class='delete' type='submit' name='submitbutton' value='<?php echo \web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php echo ( \config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL ? sprintf(_("After deleting the %s, you can not recreate it yourself - you need a new invitation token from the %s administrator!"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed) . " " : "" ) . sprintf(_("Do you really want to delete your %s %s?"), $uiElements->nomenclatureParticipant, $the_inst->name); ?>')"><?php echo sprintf(_("Delete %s"), $uiElements->nomenclatureParticipant); ?></button>
206
+                                <button class='delete' type='submit' name='submitbutton' value='<?php echo \web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php echo (\config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL ? sprintf(_("After deleting the %s, you can not recreate it yourself - you need a new invitation token from the %s administrator!"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed)." " : "").sprintf(_("Do you really want to delete your %s %s?"), $uiElements->nomenclatureParticipant, $the_inst->name); ?>')"><?php echo sprintf(_("Delete %s"), $uiElements->nomenclatureParticipant); ?></button>
207 207
                             </form>
208 208
                             <form action='edit_participant_result.php?inst_id=<?php echo $the_inst->identifier; ?>' method='post' accept-charset='UTF-8'>
209 209
                                 <button class='delete' type='submit' name='submitbutton' value='<?php echo \web\lib\common\FormElements::BUTTON_FLUSH_AND_RESTART; ?>' onclick="return confirm('<?php echo sprintf(_("This action will delete all properties of the %s and start over the configuration from scratch. Do you really want to reset all settings of the %s %s?"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureParticipant, $the_inst->name); ?>')"><?php echo sprintf(_("Reset all %s settings"), $uiElements->nomenclatureParticipant); ?></button>
@@ -218,18 +218,18 @@  discard block
 block discarded – undo
218 218
         </table>
219 219
         <?php
220 220
     } else {
221
-        echo "<h2>" . sprintf(_("You are not managing any %s."), $uiElements->nomenclatureParticipant) . "</h2>";
221
+        echo "<h2>".sprintf(_("You are not managing any %s."), $uiElements->nomenclatureParticipant)."</h2>";
222 222
     }
223 223
     if (\config\Master::DB['INST']['readonly'] === FALSE) {
224 224
         if (\config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL) {
225
-            echo "<p>" . sprintf(_("Please ask your %s administrator to invite you to become an %s administrator."), $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant) . "</p>";
225
+            echo "<p>".sprintf(_("Please ask your %s administrator to invite you to become an %s administrator."), $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant)."</p>";
226 226
             echo "<hr/>
227 227
              <div style='white-space: nowrap;'>
228 228
                 <form action='action_enrollment.php' method='get' accept-charset='UTF-8'>" .
229
-            sprintf(_("Did you receive an invitation token to manage an %s? Please paste it here:"), $uiElements->nomenclatureParticipant) .
229
+            sprintf(_("Did you receive an invitation token to manage an %s? Please paste it here:"), $uiElements->nomenclatureParticipant).
230 230
             "        <input type='text' id='token' name='token'/>
231 231
                     <button type='submit'>" .
232
-            _("Go!") . "
232
+            _("Go!")."
233 233
                     </button>
234 234
                 </form>
235 235
              </div>";
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
             <div style='white-space: nowrap;'>
239 239
         <form action='action_enrollment.php' method='get'><button type='submit' accept-charset='UTF-8'>
240 240
                 <input type='hidden' id='token' name='token' value='SELF-REGISTER'/>" .
241
-            sprintf(_("New %s Registration"), $uiElements->nomenclatureParticipant) . "
241
+            sprintf(_("New %s Registration"), $uiElements->nomenclatureParticipant)."
242 242
             </button>
243 243
         </form>
244 244
         </div>";
Please login to merge, or discard this patch.
web/diag/action_realmcheck.php 1 patch
Spacing   +74 added lines, -74 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(__DIR__)) . "/config/_config.php";
22
+require_once dirname(dirname(__DIR__))."/config/_config.php";
23 23
 
24 24
 $loggerInstance = new \core\common\Logging();
25 25
 
@@ -69,13 +69,13 @@  discard block
 block discarded – undo
69 69
             $dnsChecksOR = new \core\diag\RFC7585Tests($check_realm, "aaa+auth:radius.tls.tcp");
70 70
         }
71 71
     } else {
72
-        $error_message = _("You asked for a realm check, but we don't know the realm for this profile!") . "</p>";
72
+        $error_message = _("You asked for a realm check, but we don't know the realm for this profile!")."</p>";
73 73
     }
74 74
 } else { // someone else's realm, and we don't know anything about it... only shallow checks
75 75
     $check_realm = $validator->realm($realm ?? $_SESSION['check_realm'] ?? "");
76 76
     if ($check_realm !== FALSE) {
77 77
         $_SESSION['check_realm'] = $check_realm;
78
-        $testsuite = new \core\diag\RADIUSTests($check_realm, "@" . $check_realm);
78
+        $testsuite = new \core\diag\RADIUSTests($check_realm, "@".$check_realm);
79 79
         $dnsChecks = new \core\diag\RFC7585Tests($check_realm);
80 80
     } else {
81 81
         $error_message = _("No valid realm name given, cannot execute any checks!");
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     var listofcas = "<?php echo _("You should update your list of accredited CAs") ?>";
123 123
     var getitfrom = "<?php echo _("Get it from here.") ?>";
124 124
     var listsource = "<?php echo \config\Diagnostics::RADIUSTESTS['accreditedCAsURL'] ?>";
125
-    var moretext = "<?php echo _("more") . "&raquo;" ?>";
125
+    var moretext = "<?php echo _("more")."&raquo;" ?>";
126 126
     var lesstext = "<?php echo "&laquo" ?>";
127 127
     var morealltext = "<?php echo _("Show detailed information for all tests") ?>";
128 128
     var unknownca_code = "<?php echo \core\diag\RADIUSTests::CERTPROB_UNKNOWN_CA ?>";
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
                         }
266 266
                     }
267 267
                     cliinfo = cliinfo + '<li><table><tbody><tr><td class="icon_td"><img class="icon" src="' + icons[level] + '" style="width: 24px;"></td><td>' + state;
268
-                    cliinfo = cliinfo + ' <?php echo "(" . sprintf(_("elapsed time: %sms."), "'+data.ca[key].certificate[c].time_millisec+'&nbsp;") . ")"; ?>' + add + '</td></tr>';
268
+                    cliinfo = cliinfo + ' <?php echo "(".sprintf(_("elapsed time: %sms."), "'+data.ca[key].certificate[c].time_millisec+'&nbsp;").")"; ?>' + add + '</td></tr>';
269 269
                     cliinfo = cliinfo + '</tbody></table></ul></li>';
270 270
                     if (data.ca[key].certificate[c].finalerror === 1) {
271 271
                         cliinfo = cliinfo + '<li>' + restskipped + '</li>';
@@ -468,8 +468,8 @@  discard block
 block discarded – undo
468 468
 <?php
469 469
 foreach (\config\Diagnostics::RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
470 470
     print "
471
-$(\"#live_src" . $hostindex . "_img\").attr('src',icon_loading);
472
-$(\"#live_src" . $hostindex . "_img\").show();
471
+$(\"#live_src" . $hostindex."_img\").attr('src',icon_loading);
472
+$(\"#live_src" . $hostindex."_img\").show();
473 473
 $.ajax({
474 474
     url: 'radius_tests.php?src=0&hostindex=$hostindex&realm='+realm,
475 475
     type: 'POST',
@@ -499,15 +499,15 @@  discard block
 block discarded – undo
499 499
 <?php
500 500
 foreach (\config\Diagnostics::RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
501 501
     if ($testedProfile !== NULL) {
502
-        $extraarg = "profile_id: " . $testedProfile->identifier . ", ";
502
+        $extraarg = "profile_id: ".$testedProfile->identifier.", ";
503 503
     } else {
504 504
         $extraarg = "";
505 505
     }
506 506
     print "
507
-$(\"#src" . $hostindex . "_img\").attr('src',icon_loading);
507
+$(\"#src" . $hostindex."_img\").attr('src',icon_loading);
508 508
 $(\"#src$hostindex\").html('');
509 509
 running_ajax_stat++;
510
-$.get('radius_tests.php',{test_type: 'udp', $extraarg realm: realm, src: $hostindex, lang: '" . $gui->languageInstance->getLang() . "', hostindex: '$hostindex'  }, udp, 'json');
510
+$.get('radius_tests.php',{test_type: 'udp', $extraarg realm: realm, src: $hostindex, lang: '".$gui->languageInstance->getLang()."', hostindex: '$hostindex'  }, udp, 'json');
511 511
 
512 512
 ";
513 513
 }
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
     if ($check_realm === FALSE) {
535 535
         print "<p>$error_message</p>";
536 536
     } else {
537
-        print "<h1>" . sprintf(_("Realm testing for: %s"), $check_realm) . "</h1>\n";
537
+        print "<h1>".sprintf(_("Realm testing for: %s"), $check_realm)."</h1>\n";
538 538
         ?>
539 539
         <div id="debug_out" style="display: none"></div>
540 540
         <div id="tabs" style="min-width: 600px; max-width:1000px">
@@ -556,25 +556,25 @@  discard block
 block discarded – undo
556 556
                     // NAPTR existence check
557 557
                     if ($dynType == "") {
558 558
                         $rfc7585suite = $dnsChecks;
559
-                        echo "<strong>" . _("DNS checks") . "</strong><div>";
559
+                        echo "<strong>"._("DNS checks")."</strong><div>";
560 560
                     } else {
561 561
                         if (count($orrealm) == 0) {
562 562
                             continue;
563 563
                         }
564 564
                         $rfc7585suite = $dnsChecksOR;
565
-                        echo "<strong>" . _("OpenRoaming DNS checks") . "</strong><div>";
565
+                        echo "<strong>"._("OpenRoaming DNS checks")."</strong><div>";
566 566
                     }
567 567
                     $naptr = $rfc7585suite->relevantNAPTR();
568 568
                     if ($naptr == \core\diag\RADIUSTests::RETVAL_NOTCONFIGURED) {
569 569
                         if ($dynType == "") {
570
-                        	echo "<tr><td>" . _("Dynamic discovery test is not configured") . "</td><td>";
570
+                        	echo "<tr><td>"._("Dynamic discovery test is not configured")."</td><td>";
571 571
                         } else {
572
-                        	echo "<tr><td>" . _("OpenRoaming connectivity test is not configured") . "</td><td>";
572
+                        	echo "<tr><td>"._("OpenRoaming connectivity test is not configured")."</td><td>";
573 573
                         }
574 574
                     } else {
575 575
                         echo "<table>";
576 576
                         // output in friendly words
577
-                        echo "<tr><td>" . _("Checking NAPTR existence:") . "</td><td>";
577
+                        echo "<tr><td>"._("Checking NAPTR existence:")."</td><td>";
578 578
                         switch ($naptr) {
579 579
                             case \core\diag\RFC7585Tests::RETVAL_NONAPTR:
580 580
                                 echo _("This realm has no NAPTR records.");
@@ -589,7 +589,7 @@  discard block
 block discarded – undo
589 589
 
590 590
                         // compliance checks for NAPTRs
591 591
                         if ($naptr > 0) {
592
-                            echo "<tr><td>" . _("Checking NAPTR compliance (flag = S and regex = {empty}):") . "</td><td>";
592
+                            echo "<tr><td>"._("Checking NAPTR compliance (flag = S and regex = {empty}):")."</td><td>";
593 593
                             $naptr_valid = $rfc7585suite->relevantNAPTRcompliance();
594 594
                             switch ($naptr_valid) {
595 595
                                 case \core\diag\RADIUSTests::RETVAL_OK:
@@ -604,7 +604,7 @@  discard block
 block discarded – undo
604 604
                         // SRV resolution
605 605
                         if ($naptr > 0 && $naptr_valid == \core\diag\RADIUSTests::RETVAL_OK) {
606 606
                             $srv = $rfc7585suite->relevantNAPTRsrvResolution();
607
-                            echo "<tr><td>" . _("Checking SRVs:") . "</td><td>";
607
+                            echo "<tr><td>"._("Checking SRVs:")."</td><td>";
608 608
                             switch ($srv) {
609 609
                                 case \core\diag\RADIUSTests::RETVAL_SKIPPED:
610 610
                                     echo _("This check was skipped.");
@@ -620,7 +620,7 @@  discard block
 block discarded – undo
620 620
                         // IP addresses for the hosts
621 621
                         if ($naptr > 0 && $naptr_valid == \core\diag\RADIUSTests::RETVAL_OK && $srv > 0) {
622 622
                             $hosts = $rfc7585suite->relevantNAPTRhostnameResolution();
623
-                            echo "<tr><td>" . _("Checking IP address resolution:") . "</td><td>";
623
+                            echo "<tr><td>"._("Checking IP address resolution:")."</td><td>";
624 624
                             switch ($srv) {
625 625
                                 case \core\diag\RADIUSTests::RETVAL_SKIPPED:
626 626
                                     echo _("This check was skipped.");
@@ -637,12 +637,12 @@  discard block
 block discarded – undo
637 637
                         echo "</table><br/>";
638 638
                         if ($dynType == "") {
639 639
                             if (count($testsuite->listerrors()) == 0) {
640
-                                echo sprintf(_("Realm is <strong>%s</strong> "), _(($naptr > 0 ? "DYNAMIC" : "STATIC"))) . _("with no DNS errors encountered. Congratulations!");
640
+                                echo sprintf(_("Realm is <strong>%s</strong> "), _(($naptr > 0 ? "DYNAMIC" : "STATIC")))._("with no DNS errors encountered. Congratulations!");
641 641
                             } else {
642
-                                echo sprintf(_("Realm is <strong>%s</strong> "), _(($naptr > 0 ? "DYNAMIC" : "STATIC"))) . _("but there were DNS errors! Check them!") . " " . _("You should re-run the tests after fixing the errors; more errors might be uncovered at that point. The exact error causes are listed below.");
642
+                                echo sprintf(_("Realm is <strong>%s</strong> "), _(($naptr > 0 ? "DYNAMIC" : "STATIC")))._("but there were DNS errors! Check them!")." "._("You should re-run the tests after fixing the errors; more errors might be uncovered at that point. The exact error causes are listed below.");
643 643
                                 echo "<div class='notacceptable'><table>";
644 644
                                 foreach ($testsuite->listerrors() as $details) {
645
-                                    echo "<tr><td>" . $details['TYPE'] . "</td><td>" . $details['TARGET'] . "</td></tr>";
645
+                                    echo "<tr><td>".$details['TYPE']."</td><td>".$details['TARGET']."</td></tr>";
646 646
                                 }
647 647
                                 echo "</table></div>";
648 648
                             }
@@ -661,13 +661,13 @@  discard block
 block discarded – undo
661 661
                  $("#dynamic_tests").show();
662 662
               ';
663 663
                         foreach ($rfc7585suite->NAPTR_hostname_records as $hostindex => $addr) {
664
-                            $host = ($addr['family'] == "IPv6" ? "[" : "") . $addr['IP'] . ($addr['family'] == "IPv6" ? "]" : "") . ":" . $addr['port'];
664
+                            $host = ($addr['family'] == "IPv6" ? "[" : "").$addr['IP'].($addr['family'] == "IPv6" ? "]" : "").":".$addr['port'];
665 665
                             $expectedName = $addr['hostname'];
666 666
                             print "
667 667
                             running_ajax_dyn++;
668
-                            $.ajax({url:'radius_tests.php', data:{test_type: 'capath', realm: realm, src: '$host', lang: '" . $gui->languageInstance->getLang() . "', hostindex: '$hostindex', expectedname: '$expectedName' }, error: eee, success: capath, dataType: 'json'}); 
668
+                            $.ajax({url:'radius_tests.php', data:{test_type: 'capath', realm: realm, src: '$host', lang: '".$gui->languageInstance->getLang()."', hostindex: '$hostindex', expectedname: '$expectedName' }, error: eee, success: capath, dataType: 'json'}); 
669 669
                             running_ajax_dyn++;
670
-                            $.ajax({url:'radius_tests.php', data:{test_type: 'clients', realm: realm, src: '$host', lang: '" . $gui->languageInstance->getLang() . "', hostindex: '$hostindex' }, error: eee, success: clients, dataType: 'json'}); 
670
+                            $.ajax({url:'radius_tests.php', data:{test_type: 'clients', realm: realm, src: '$host', lang: '".$gui->languageInstance->getLang()."', hostindex: '$hostindex' }, error: eee, success: clients, dataType: 'json'}); 
671 671
                        ";
672 672
                         }
673 673
                         echo "}
@@ -683,11 +683,11 @@  discard block
 block discarded – undo
683 683
                  $("#openroaming_tests").show();
684 684
               ';
685 685
                         foreach ($rfc7585suite->NAPTR_hostname_records as $hostindex => $addr) {
686
-                            $host = ($addr['family'] == "IPv6" ? "[" : "") . $addr['IP'] . ($addr['family'] == "IPv6" ? "]" : "") . ":" . $addr['port'];
686
+                            $host = ($addr['family'] == "IPv6" ? "[" : "").$addr['IP'].($addr['family'] == "IPv6" ? "]" : "").":".$addr['port'];
687 687
                             $expectedName = $addr['hostname'];
688 688
                             print "
689 689
                             running_ajax_openroaming++;
690
-                            $.ajax({url:'radius_tests.php', data:{test_type: 'openroamingcapath', realm: realm, src: '$host', lang: '" . $gui->languageInstance->getLang() . "', hostindex: '$hostindex', expectedname: '$expectedName' }, error: eee, success: capath, dataType: 'json'}); 
690
+                            $.ajax({url:'radius_tests.php', data:{test_type: 'openroamingcapath', realm: realm, src: '$host', lang: '".$gui->languageInstance->getLang()."', hostindex: '$hostindex', expectedname: '$expectedName' }, error: eee, success: capath, dataType: 'json'}); 
691 691
                        ";
692 692
                         }
693 693
                         echo "}
@@ -700,18 +700,18 @@  discard block
 block discarded – undo
700 700
                          $naptrs[1] = $naptr;
701 701
                      }
702 702
                 }
703
-                    echo "<strong>" . _("Static connectivity tests") . "</strong>
703
+                    echo "<strong>"._("Static connectivity tests")."</strong>
704 704
          <table><tr>
705 705
          <td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='main_static_ico' class='icon'></td><td id='main_static_result' style='display:none'>&nbsp;</td>
706 706
          </tr></table>";
707 707
                     if ($naptrs[0] > 0) {
708
-                        echo "<hr><strong>" . _("Dynamic connectivity tests") . "</strong>
708
+                        echo "<hr><strong>"._("Dynamic connectivity tests")."</strong>
709 709
          <table><tr>
710 710
          <td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='main_dynamic_ico' class='icon'></td><td id='main_dynamic_result' style='display:none'>&nbsp;</td>
711 711
          </tr></table>";
712 712
                     }
713 713
                     if (count($orrealm) && ($naptrs[1] > 0)) {
714
-                      echo "<hr><strong>" . _("OpenRoaming connectivity tests") . "</strong>
714
+                      echo "<hr><strong>"._("OpenRoaming connectivity tests")."</strong>
715 715
          <table><tr>
716 716
          <td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='main_openroaming_ico' class='icon'></td><td id='main_openroaming_result' style='display:none'>&nbsp;</td>
717 717
          </tr></table>";
@@ -731,12 +731,12 @@  discard block
 block discarded – undo
731 731
                     print "<p>";
732 732
                     foreach (\config\Diagnostics::RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
733 733
                         print "<hr>";
734
-                        printf(_("Testing from: %s"), "<strong>" . \config\Diagnostics::RADIUSTESTS['UDP-hosts'][$hostindex]['display_name'] . "</strong>");
734
+                        printf(_("Testing from: %s"), "<strong>".\config\Diagnostics::RADIUSTESTS['UDP-hosts'][$hostindex]['display_name']."</strong>");
735 735
                         print "<table id='results$hostindex'  style='width:100%' class='udp_results'>
736 736
 <tr>
737
-<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='src" . $hostindex . "_img'></td>
737
+<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='src".$hostindex."_img'></td>
738 738
 <td id='src$hostindex' colspan=2>
739
-" . _("testing...") . "
739
+"._("testing...")."
740 740
 </td>
741 741
 </tr>
742 742
 </table>";
@@ -747,7 +747,7 @@  discard block
 block discarded – undo
747 747
 
748 748
             </div>
749 749
             <?php
750
-            for ($i=3; $i<5; $i++) {
750
+            for ($i = 3; $i < 5; $i++) {
751 751
                 if ($i == 3 && $naptrs[0] <= 0) {
752 752
                    continue;
753 753
                 }
@@ -762,15 +762,15 @@  discard block
 block discarded – undo
762 762
                     $rfc7585suite = $dnsChecksOR;
763 763
                 }
764 764
             ?>
765
-                <div id="tabs-<?php echo $i;?>">
766
-                    <button id="run_<?php if ($i==3) echo 'd'; else echo 'o';?>_tests"; onclick="run_<?php if ($i==3) echo 'dynamic'; else echo 'openroaming';?>()"><?php if ($i==3) echo _("Repeat dynamic connectivity tests"); else echo _("Repeat OpenRoaming connectivity tests");?></button>
765
+                <div id="tabs-<?php echo $i; ?>">
766
+                    <button id="run_<?php if ($i == 3) echo 'd'; else echo 'o'; ?>_tests"; onclick="run_<?php if ($i == 3) echo 'dynamic'; else echo 'openroaming'; ?>()"><?php if ($i == 3) echo _("Repeat dynamic connectivity tests"); else echo _("Repeat OpenRoaming connectivity tests"); ?></button>
767 767
 
768 768
                 <?php
769 769
                     echo "<div id='";
770
-                    if ($i==3) { echo 'dynamic'; } else { echo 'openroaming'; }
770
+                    if ($i == 3) { echo 'dynamic'; } else { echo 'openroaming'; }
771 771
                     echo "_tests'><fieldset class='option_container'>
772 772
                 <legend><strong>";
773
-                    if ($i==3) {
773
+                    if ($i == 3) {
774 774
                      echo _("DYNAMIC connectivity tests");
775 775
                     } else {
776 776
                      echo _("OpenRoaming connectivity tests");
@@ -784,17 +784,17 @@  discard block
 block discarded – undo
784 784
                     }
785 785
                     $resultstoprint = [];
786 786
                     if (count($rfc7585suite->NAPTR_hostname_records) > 0) {
787
-                        $resultstoprint[] = '<div style="align:right; display: none;" id="' . $prefix1 . '_result_fail">' . _("Some errors were found during the tests, see below") . '</div><div style="align:right; display: none;" id="' . $prefix1 . '_result_pass">' . _("All tests passed, congratulations!") . '</div>';
788
-                        $resultstoprint[] = '<div style="align:right;"><a href="" class="moreall">' . _('Show detailed information for all tests') . '</a></div>' . '<p><strong>' . _("Checking server handshake...") . "</strong><p>";
787
+                        $resultstoprint[] = '<div style="align:right; display: none;" id="'.$prefix1.'_result_fail">'._("Some errors were found during the tests, see below").'</div><div style="align:right; display: none;" id="'.$prefix1.'_result_pass">'._("All tests passed, congratulations!").'</div>';
788
+                        $resultstoprint[] = '<div style="align:right;"><a href="" class="moreall">'._('Show detailed information for all tests').'</a></div>'.'<p><strong>'._("Checking server handshake...")."</strong><p>";
789 789
                         foreach ($rfc7585suite->NAPTR_hostname_records as $hostindex => $addr) {
790
-                            $bracketaddr = ($addr["family"] == "IPv6" ? "[" . $addr["IP"] . "]" : $addr["IP"]);
791
-                            $resultstoprint[] = '<p><strong>' . $bracketaddr . ' TCP/' . $addr['port'] . '</strong>';
790
+                            $bracketaddr = ($addr["family"] == "IPv6" ? "[".$addr["IP"]."]" : $addr["IP"]);
791
+                            $resultstoprint[] = '<p><strong>'.$bracketaddr.' TCP/'.$addr['port'].'</strong>';
792 792
                             $resultstoprint[] = '<ul style="list-style-type: none;" class="caresult"><li>';
793
-                            $resultstoprint[] = "<table id='" . $prefix2 . "caresults$hostindex'  style='width:100%'>
793
+                            $resultstoprint[] = "<table id='".$prefix2."caresults$hostindex'  style='width:100%'>
794 794
 <tr>
795
-<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='" . $prefix2 . "srcca$hostindex" . "_img'></td>
796
-<td id='" . $prefix2 . "srcca$hostindex'>
797
-" . _("testing...") . "
795
+<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='".$prefix2."srcca$hostindex"."_img'></td>
796
+<td id='" . $prefix2."srcca$hostindex'>
797
+"._("testing...")."
798 798
 </td>
799 799
 </tr>
800 800
 </table>";
@@ -802,26 +802,26 @@  discard block
 block discarded – undo
802 802
                         }
803 803
                         $clientstest = [];
804 804
                         foreach ($rfc7585suite->NAPTR_hostname_records as $hostindex => $addr) {
805
-                            $clientstest[] = '<p><strong>' . $addr['IP'] . ' TCP/' . $addr['port'] . '</strong></p><ol>';
806
-                            $clientstest[] = "<span id='" . $prefix2 . "clientresults$hostindex$clinx'><table style='width:100%'>
805
+                            $clientstest[] = '<p><strong>'.$addr['IP'].' TCP/'.$addr['port'].'</strong></p><ol>';
806
+                            $clientstest[] = "<span id='".$prefix2."clientresults$hostindex$clinx'><table style='width:100%'>
807 807
 <tr>
808 808
 <td class='icon_td'>";
809
-                            if ($i == 4 ) {
809
+                            if ($i == 4) {
810 810
                                 $clientstest[] = "<!--";
811 811
                             }
812
-                            $clientstest[] = "<img src='../resources/images/icons/loading51.gif' id='" . $prefix2 . "srcclient$hostindex" . "_img'></td>
813
-<td id='" . $prefix2 . "srcclient$hostindex'>
814
-" . _("testing...");
812
+                            $clientstest[] = "<img src='../resources/images/icons/loading51.gif' id='".$prefix2."srcclient$hostindex"."_img'></td>
813
+<td id='" . $prefix2."srcclient$hostindex'>
814
+"._("testing...");
815 815
 
816
-                            if ($i == 4 ) {
817
-                                $clientstest[] = "-->" . _("not implemented yet");
816
+                            if ($i == 4) {
817
+                                $clientstest[] = "-->"._("not implemented yet");
818 818
                             }
819 819
                             $clientstest[] = "</td></tr></table></span>";
820 820
                             $clientstest[] = '</ol>';
821 821
                         }
822 822
                         echo '<div style="align:right;">';
823 823
                         echo join('', $resultstoprint);
824
-                        echo '<span id="' . $prefix2 . 'clientstest" style="display: none;"><p><hr><b>' . _('Checking if certificates from  CAs are accepted...') . '</b><p>' . _('A few client certificates will be tested to check if servers are resistant to some certificate problems.') . '<p>';
824
+                        echo '<span id="'.$prefix2.'clientstest" style="display: none;"><p><hr><b>'._('Checking if certificates from  CAs are accepted...').'</b><p>'._('A few client certificates will be tested to check if servers are resistant to some certificate problems.').'<p>';
825 825
                         print join('', $clientstest);
826 826
                         echo '</span>';
827 827
                         echo '</div>';
@@ -835,7 +835,7 @@  discard block
 block discarded – undo
835 835
                 //     check if truncates/dies on Operator-Name
836 836
                 if ($my_profile !== NULL) {
837 837
                     echo "<div id='tabs-n'><fieldset class='option_container'>
838
-                <legend><strong>" . _("Live login test") . "</strong></legend>";
838
+                <legend><strong>" . _("Live login test")."</strong></legend>";
839 839
                     $prof_compl = $my_profile->getEapMethodsinOrderOfPreference(1);
840 840
                     if (count($prof_compl) > 0) {
841 841
                         $passwordReqired = FALSE;
@@ -848,34 +848,34 @@  discard block
 block discarded – undo
848 848
                                 $clientCertRequired = TRUE;
849 849
                             }
850 850
                         }
851
-                        echo "<div id='disposable_credential_container'><p>" . _("If you enter an existing login credential here, you can test the actual authentication from various checkpoints all over the world.") . "</p>
852
-                    <p>" . _("The test will use all EAP types you have set in your profile information to check whether the right CAs and server names are used, and of course whether the login with these credentials and the given EAP type actually worked. If you have set anonymous outer ID, the test will use that.") . "</p>
853
-                    <p>" . _("Note: the tool purposefully does not offer you to save these credentials, and they will never be saved in any way on the server side. Please use only <strong>temporary test accounts</strong> here; permanently valid test accounts in the wild are considered harmful!") . "</p></div>
851
+                        echo "<div id='disposable_credential_container'><p>"._("If you enter an existing login credential here, you can test the actual authentication from various checkpoints all over the world.")."</p>
852
+                    <p>" . _("The test will use all EAP types you have set in your profile information to check whether the right CAs and server names are used, and of course whether the login with these credentials and the given EAP type actually worked. If you have set anonymous outer ID, the test will use that.")."</p>
853
+                    <p>" . _("Note: the tool purposefully does not offer you to save these credentials, and they will never be saved in any way on the server side. Please use only <strong>temporary test accounts</strong> here; permanently valid test accounts in the wild are considered harmful!")."</p></div>
854 854
                     <form enctype='multipart/form-data' id='live_form' accept-charset='UTF-8'>
855 855
                     <input type='hidden' name='test_type' value='udp_login'>
856
-                    <input type='hidden' name='lang' value='" . $gui->languageInstance->getLang() . "'>
857
-                    <input type='hidden' name='profile_id' value='" . $my_profile->identifier . "'>
856
+                    <input type='hidden' name='lang' value='" . $gui->languageInstance->getLang()."'>
857
+                    <input type='hidden' name='profile_id' value='" . $my_profile->identifier."'>
858 858
                     <table id='live_tests'>";
859 859
 // if any password based EAP methods are available enable this section
860 860
                         if ($passwordReqired) {
861
-                            echo "<tr><td colspan='2'><strong>" . _("Password-based EAP types") . "</strong></td></tr>
862
-                        <tr><td>" . _("Real (inner) username:") . "</td><td><input type='text' id='username' class='mandatory' name='username'/></td></tr>";
863
-                            echo "<tr><td>" . _("Anonymous outer ID (optional):") . "</td><td><input type='text' id='outer_username' name='outer_username'/></td></tr>";
864
-                            echo "<tr><td>" . _("Password:") . "</td><td><input type='text' id='password' class='mandatory' name='password'/></td></tr>";
861
+                            echo "<tr><td colspan='2'><strong>"._("Password-based EAP types")."</strong></td></tr>
862
+                        <tr><td>" . _("Real (inner) username:")."</td><td><input type='text' id='username' class='mandatory' name='username'/></td></tr>";
863
+                            echo "<tr><td>"._("Anonymous outer ID (optional):")."</td><td><input type='text' id='outer_username' name='outer_username'/></td></tr>";
864
+                            echo "<tr><td>"._("Password:")."</td><td><input type='text' id='password' class='mandatory' name='password'/></td></tr>";
865 865
                         }
866 866
                         // ask for cert + privkey if TLS-based method is active
867 867
                         if ($clientCertRequired) {
868
-                            echo "<tr><td colspan='2'><strong>" . _("Certificate-based EAP types") . "</strong></td></tr>
869
-                        <tr><td>" . _("Certificate file (.p12 or .pfx):") . "</td><td><input type='file' id='cert' accept='application/x-pkcs12' name='cert'/></td></tr>
870
-                        <tr><td>" . _("Certificate password, if any:") . "</td><td><input type='text' id='privkey' name='privkey_pass'/></td></tr>
871
-                        <tr><td>" . _("Username, if different from certificate Subject:") . "</td><td><input type='text' id='tls_username' name='tls_username'/></td></tr>";
868
+                            echo "<tr><td colspan='2'><strong>"._("Certificate-based EAP types")."</strong></td></tr>
869
+                        <tr><td>" . _("Certificate file (.p12 or .pfx):")."</td><td><input type='file' id='cert' accept='application/x-pkcs12' name='cert'/></td></tr>
870
+                        <tr><td>" . _("Certificate password, if any:")."</td><td><input type='text' id='privkey' name='privkey_pass'/></td></tr>
871
+                        <tr><td>" . _("Username, if different from certificate Subject:")."</td><td><input type='text' id='tls_username' name='tls_username'/></td></tr>";
872 872
                         }
873
-                        echo "<tr><td colspan='2'><button id='submit_credentials'>" . _("Submit credentials") . "</button></td></tr></table></form>";
873
+                        echo "<tr><td colspan='2'><button id='submit_credentials'>"._("Submit credentials")."</button></td></tr></table></form>";
874 874
                         echo "<div id='live_login_results' style='display:none'>";
875 875
                         foreach (\config\Diagnostics::RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
876 876
                             print "<hr>";
877
-                            printf(_("Testing from: %s"), "<strong>" . \config\Diagnostics::RADIUSTESTS['UDP-hosts'][$hostindex]['display_name'] . "</strong>");
878
-                            print "<span style='position:relative'><img src='../resources/images/icons/loading51.gif' id='live_src" . $hostindex . "_img' style='width:24px; position: absolute; left: 20px; bottom: 0px; '></span>";
877
+                            printf(_("Testing from: %s"), "<strong>".\config\Diagnostics::RADIUSTESTS['UDP-hosts'][$hostindex]['display_name']."</strong>");
878
+                            print "<span style='position:relative'><img src='../resources/images/icons/loading51.gif' id='live_src".$hostindex."_img' style='width:24px; position: absolute; left: 20px; bottom: 0px; '></span>";
879 879
                             print "<div id='eap_test$hostindex' class='eap_test_results'></div>";
880 880
                         }
881 881
                         echo "</div>";
@@ -890,9 +890,9 @@  discard block
 block discarded – undo
890 890
             }
891 891
 
892 892
             if (isset($_POST['comefrom'])) {
893
-                $return = htmlspecialchars_decode($_POST['comefrom']) . ( $inst_id ? "?inst_id=" . $inst_id : "" );
893
+                $return = htmlspecialchars_decode($_POST['comefrom']).($inst_id ? "?inst_id=".$inst_id : "");
894 894
                 echo "<form method='post' action='$return' accept-charset='UTF-8'>
895
-                    <button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_CLOSE . "'>" . sprintf(_("Return to %s administrator area"), core\common\Entity::$nomenclature_idp) . "</button>"
895
+                    <button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_CLOSE."'>".sprintf(_("Return to %s administrator area"), core\common\Entity::$nomenclature_idp)."</button>"
896 896
                 . "</form>";
897 897
             }
898 898
             if ($check_realm !== FALSE) {
Please login to merge, or discard this patch.
devices/eap_config/DeviceXML.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
         $dom = new \DOMDocument('1.0', 'utf-8');
145 145
         $root = $dom->createElement($rootname);
146 146
         $dom->appendChild($root);
147
-        $ns = $dom->createAttributeNS( 'http://www.w3.org/2001/XMLSchema-instance', 'xsi:noNamespaceSchemaLocation' );
147
+        $ns = $dom->createAttributeNS('http://www.w3.org/2001/XMLSchema-instance', 'xsi:noNamespaceSchemaLocation');
148 148
         $ns->value = "eap-metadata.xsd";
149 149
         $root->appendChild($ns);
150 150
         $this->openRoamingToU = sprintf(_("I have read and agree to OpenRoaming Terms of Use at %s."), "https://wballiance.com/openroaming/toc-2020/");
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
                 if ($netDefinition['condition'] === 'internal:openroaming' &&
182 182
                         $this->attributes['internal:openroaming']) {
183 183
                     $this->setORtou();
184
-                    if (preg_match("/^ask/",$this->attributes['media:openroaming'][0])) {
184
+                    if (preg_match("/^ask/", $this->attributes['media:openroaming'][0])) {
185 185
                         $orNetwork = $netDefinition;
186 186
                         continue;                        
187 187
                     }
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
     }
239 239
     
240 240
     private function setORtou() {
241
-        if (preg_match("/preagreed/",$this->attributes['media:openroaming'][0])) {
241
+        if (preg_match("/preagreed/", $this->attributes['media:openroaming'][0])) {
242 242
             $this->addORtou = false;
243 243
         } else {
244 244
             $this->addORtou = true;
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
         $authMethods = new \core\DeviceXMLmain();
263 263
         $authMethods->setChild('AuthenticationMethod', $this->authMethodsList);
264 264
         $eapIdp->setChild('AuthenticationMethods', $authMethods);
265
-        $eapIdp->setChild('CredentialApplicability', $this->getCredentialApplicability($ssids,$oids));
265
+        $eapIdp->setChild('CredentialApplicability', $this->getCredentialApplicability($ssids, $oids));
266 266
 // TODO   $eap_idp->setChild('ValidUntil',$this->getValidUntil());
267 267
         $eapIdp->setChild('ProviderInfo', $this->providerInfo);
268 268
 // TODO   $eap_idp->setChild('VendorSpecific',$this->getVendorSpecific());
@@ -416,7 +416,7 @@  discard block
 block discarded – undo
416 416
                 $lng = $lngAttr['lang'] === 'any' ? \config\Master::APPEARANCE['defaultlocale'] : $lngAttr['lang'];
417 417
                 $tou .= "\n".$this->openRoamingToUArray[$lng];
418 418
                 $touObj->setValue($tou);
419
-                $out[] =  $touObj;
419
+                $out[] = $touObj;
420 420
             } 
421 421
         } else {
422 422
             $tou = $standardTou[0];
Please login to merge, or discard this patch.
web/admin/overview_sp.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 $deco = new \web\lib\admin\PageDecoration();
32 32
 $validator = new \web\lib\common\InputValidation();
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 } else {
39 39
     $link = 'http://';
40 40
 }
41
-$link .= $_SERVER['SERVER_NAME'] . $_SERVER['SCRIPT_NAME'];
41
+$link .= $_SERVER['SERVER_NAME'].$_SERVER['SCRIPT_NAME'];
42 42
 $link = htmlspecialchars($link);
43 43
 
44 44
 echo $deco->defaultPagePrelude(sprintf(_("%s: %s Dashboard"), \config\Master::APPEARANCE['productname'], $uiElements->nomenclatureHotspot));
@@ -102,21 +102,21 @@  discard block
 block discarded – undo
102 102
         <?php
103 103
         if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] !== NULL) {
104 104
             echo "<tr>
105
-                        <td>" . sprintf(_("Diagnose reachability and connection parameters of %ss"),$uiElements->nomenclatureInst) . "</td>
105
+                        <td>" . sprintf(_("Diagnose reachability and connection parameters of %ss"), $uiElements->nomenclatureInst)."</td>
106 106
                         <td><form method='post' action='../diag/action_realmcheck.php?inst_id=$my_inst->identifier' accept-charset='UTF-8'>
107 107
                               <!--<input type='text' name='realm' id='realm'>-->
108 108
                               <input type='hidden' name='comefrom' id='comefrom' value='$link'/>
109
-                              <button id='realmcheck' style='cursor:pointer;' type='submit'>" . _("Go!") . "</button>
109
+                              <button id='realmcheck' style='cursor:pointer;' type='submit'>"._("Go!")."</button>
110 110
                             </form>
111 111
                         </td>
112 112
                     </tr>";
113 113
         }
114 114
         if (\config\ConfAssistant::CONSORTIUM['name'] == "eduroam") { // SW: APPROVED
115 115
             echo "<tr>
116
-                        <td>" . sprintf(_("Check %s server status"), $uiElements->nomenclatureFed) . "</td>
116
+                        <td>" . sprintf(_("Check %s server status"), $uiElements->nomenclatureFed)."</td>
117 117
                         <td>
118 118
                            <form action='https://monitor.eduroam.org/mon_direct.php' accept-charset='UTF-8'>
119
-                              <button style='cursor:pointer;' type='submit'>" . _("Go!") . "</button>
119
+                              <button style='cursor:pointer;' type='submit'>" . _("Go!")."</button>
120 120
                            </form>
121 121
                         </td>
122 122
                     </tr>";
@@ -127,10 +127,10 @@  discard block
 block discarded – undo
127 127
     <?php
128 128
     $hotspotProfiles = $my_inst->listDeployments();
129 129
     if (count($hotspotProfiles) == 0) { // no profiles yet.
130
-        echo "<h2>" . sprintf(_("There are not yet any known deployments for your %s."), $uiElements->nomenclatureHotspot) . "</h2>";
130
+        echo "<h2>".sprintf(_("There are not yet any known deployments for your %s."), $uiElements->nomenclatureHotspot)."</h2>";
131 131
     }
132 132
     if (count($hotspotProfiles) > 0) { // no profiles yet.
133
-        echo "<h2>" . sprintf(_("Deployments for this %s"), $uiElements->nomenclatureHotspot) . "</h2>";
133
+        echo "<h2>".sprintf(_("Deployments for this %s"), $uiElements->nomenclatureHotspot)."</h2>";
134 134
         // display an info box with the connection data
135 135
     }
136 136
    
@@ -149,19 +149,19 @@  discard block
 block discarded – undo
149 149
         ?>
150 150
         <div style='display: table-row; margin-bottom: 20px;'>
151 151
             <div class='profilebox' style='display: table-cell;'>
152
-                <h2><?php echo core\DeploymentManaged::PRODUCTNAME . " (<span style='color:" . ( $deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>" . _("inactive") : "green;'>" . _("active") ) . "</span>)"; ?></h2>
152
+                <h2><?php echo core\DeploymentManaged::PRODUCTNAME." (<span style='color:".($deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>"._("inactive") : "green;'>"._("active"))."</span>)"; ?></h2>
153 153
                 <table>
154 154
                     <tr>
155 155
                         <td><strong><?php echo _("Your primary RADIUS server") ?></strong><br/>
156 156
                         <?php
157 157
                             if ($deploymentObject->host1_v4 !== NULL) {
158
-                                echo _("IPv4") . ": " . $deploymentObject->host1_v4;
158
+                                echo _("IPv4").": ".$deploymentObject->host1_v4;
159 159
                             }
160 160
                             if ($deploymentObject->host1_v4 !== NULL && $deploymentObject->host1_v6 !== NULL) {
161 161
                                 echo "<br/>";
162 162
                             }
163 163
                             if ($deploymentObject->host1_v6 !== NULL) {
164
-                                echo _("IPv6") . ": " . $deploymentObject->host1_v6;
164
+                                echo _("IPv6").": ".$deploymentObject->host1_v6;
165 165
                             }
166 166
                             ?>
167 167
                         </td>
@@ -169,9 +169,9 @@  discard block
 block discarded – undo
169 169
                         <td><?php echo $deploymentObject->port1; ?></td>
170 170
                         <td>
171 171
                             <?php
172
-                                echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_1]['icon'] . 
173
-                                     "' alt='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . 
174
-                                     "' title='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . "'>";
172
+                                echo "<img src='".$radiusMessages[$deploymentObject->radius_status_1]['icon']. 
173
+                                     "' alt='".$radiusMessages[$deploymentObject->radius_status_1]['text']. 
174
+                                     "' title='".$radiusMessages[$deploymentObject->radius_status_1]['text']."'>";
175 175
                             ?>
176 176
                         </td>
177 177
                     </tr>
@@ -179,22 +179,22 @@  discard block
 block discarded – undo
179 179
                         <td><strong><?php echo _("Your backup RADIUS server") ?><br/></strong>
180 180
                             <?php
181 181
                             if ($deploymentObject->host2_v4 !== NULL) {
182
-                                echo _("IPv4") . ": " . $deploymentObject->host2_v4;
182
+                                echo _("IPv4").": ".$deploymentObject->host2_v4;
183 183
                             }
184 184
                             if ($deploymentObject->host2_v4 !== NULL && $deploymentObject->host2_v6 !== NULL) {
185 185
                                 echo "<br/>";
186 186
                             }
187 187
                             if ($deploymentObject->host2_v6 !== NULL) {
188
-                                echo _("IPv6") . ": " . $deploymentObject->host2_v6;
188
+                                echo _("IPv6").": ".$deploymentObject->host2_v6;
189 189
                             }
190 190
                             ?></td>
191 191
                         <td><?php echo _("RADIUS port number: ") ?></td>
192 192
                         <td><?php echo $deploymentObject->port2; ?></td>
193 193
                         <td>
194 194
                             <?php
195
-                                echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_2]['icon'] .
196
-                                     "' alt='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . 
197
-                                     "' title='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . "'>";
195
+                                echo "<img src='".$radiusMessages[$deploymentObject->radius_status_2]['icon'].
196
+                                     "' alt='".$radiusMessages[$deploymentObject->radius_status_2]['text']. 
197
+                                     "' title='".$radiusMessages[$deploymentObject->radius_status_2]['text']."'>";
198 198
                             ?>
199 199
                         </td>
200 200
                     </tr>
@@ -245,12 +245,12 @@  discard block
 block discarded – undo
245 245
                                     if (array_key_exists('FAILURE', $res) && $res['FAILURE'] > 0) {
246 246
                                         echo '<br>';
247 247
                                         if ($res['FAILURE'] == 2) {
248
-                                            echo ' <span style="color: red;">' . _("Activation failure.") . '</span>';
248
+                                            echo ' <span style="color: red;">'._("Activation failure.").'</span>';
249 249
                                         } else {
250 250
                                             if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
251
-                                                echo ' <span style="color: red;">' . _("Activation failure for your primary RADIUS server.") . '</span>';
251
+                                                echo ' <span style="color: red;">'._("Activation failure for your primary RADIUS server.").'</span>';
252 252
                                             } else {
253
-                                                echo ' <span style="color: red;">' . _("Activation failure for your backup RADIUS server.") . '</span>';
253
+                                                echo ' <span style="color: red;">'._("Activation failure for your backup RADIUS server.").'</span>';
254 254
                                             }
255 255
                                         }
256 256
                                     }
@@ -270,12 +270,12 @@  discard block
 block discarded – undo
270 270
                                     if ($res['FAILURE'] > 0) {
271 271
                                         echo '<br>';
272 272
                                         if ($res['FAILURE'] == 2) {
273
-                                            echo ' <span style="color: red;">' . _("Failure during deactivation, your request is queued for handling") . '</span>';
273
+                                            echo ' <span style="color: red;">'._("Failure during deactivation, your request is queued for handling").'</span>';
274 274
                                         } else {
275 275
                                             if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
276
-                                                echo ' <span style="color: red;">' . _("Deactivation failure for your primary RADIUS server, your request is queued.") . '</span>';
276
+                                                echo ' <span style="color: red;">'._("Deactivation failure for your primary RADIUS server, your request is queued.").'</span>';
277 277
                                             } else {
278
-                                                echo ' <span style="color: red;">' . _("Deactivation failure for your backup RADIUS server, your request is queued.") . '</span>';
278
+                                                echo ' <span style="color: red;">'._("Deactivation failure for your backup RADIUS server, your request is queued.").'</span>';
279 279
                                             }
280 280
                                         }
281 281
                                     }
Please login to merge, or discard this patch.
web/lib/admin/UIElements.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
             sprintf(_("%s: Do not terminate EAP"), \core\ProfileSilverbullet::PRODUCTNAME) => "fed:silverbullet-noterm",
137 137
             sprintf(_("%s: max users per profile"), \core\ProfileSilverbullet::PRODUCTNAME) => "fed:silverbullet-maxusers",
138 138
             sprintf(_("Mint %s with CA on creation"), $this->nomenclatureIdP) => "fed:minted_ca_file",
139
-            sprintf(_("OpenRoaming: Allow %s Opt-In"),$this->nomenclatureParticipant) => "fed:openroaming",
139
+            sprintf(_("OpenRoaming: Allow %s Opt-In"), $this->nomenclatureParticipant) => "fed:openroaming",
140 140
             _("OpenRoaming: Custom NAPTR Target") => "fed:openroaming_customtarget",
141 141
             $ssidText => "media:SSID",
142 142
             $passpointOiText => "media:consortium_OI",
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         $find = array_keys($displayNames, $input, TRUE);
149 149
 
150 150
         if (count($find) == 0) { // this is an error! throw an Exception
151
-            throw new \Exception("The translation of an option name was requested, but the option is not known to the system: " . htmlentities($input));
151
+            throw new \Exception("The translation of an option name was requested, but the option is not known to the system: ".htmlentities($input));
152 152
         }
153 153
         \core\common\Entity::outOfThePotatoes();
154 154
         // none of the strings have HTML in them, only translators can provide own text for it -> no threat, but complained about by the security review
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 
171 171
         foreach ($optionlist as $option) {
172 172
             $type = $optioninfo->optionType($option['name']);
173
-            if (preg_match('/^' . $class . '/', $option['name']) && $option['level'] == "$level") {
173
+            if (preg_match('/^'.$class.'/', $option['name']) && $option['level'] == "$level") {
174 174
                 // all non-multilang attribs get this assignment ...
175 175
                 $language = "";
176 176
                 $content = $option['value'];
@@ -188,19 +188,19 @@  discard block
 block discarded – undo
188 188
                         $locationMarkers[] = $coords;
189 189
                         break;
190 190
                     case "file":
191
-                        $retval .= "<tr><td>" . $this->displayName($option['name']) . "</td><td>$language</td><td>";
191
+                        $retval .= "<tr><td>".$this->displayName($option['name'])."</td><td>$language</td><td>";
192 192
                         switch ($option['name']) {
193 193
                             case "general:logo_file":
194 194
                             case "fed:logo_file":
195
-                                $retval .= $this->previewImageinHTML('ROWID-' . $option['level'] . '-' . $option['row']);
195
+                                $retval .= $this->previewImageinHTML('ROWID-'.$option['level'].'-'.$option['row']);
196 196
                                 break;
197 197
                             case "eap:ca_file":
198 198
                             // fall-through intended: display both the same way
199 199
                             case "fed:minted_ca_file":
200
-                                $retval .= $this->previewCAinHTML('ROWID-' . $option['level'] . '-' . $option['row']);
200
+                                $retval .= $this->previewCAinHTML('ROWID-'.$option['level'].'-'.$option['row']);
201 201
                                 break;
202 202
                             case "support:info_file":
203
-                                $retval .= $this->previewInfoFileinHTML('ROWID-' . $option['level'] . '-' . $option['row']);
203
+                                $retval .= $this->previewInfoFileinHTML('ROWID-'.$option['level'].'-'.$option['row']);
204 204
                                 break;
205 205
                             default:
206 206
                         }
@@ -210,10 +210,10 @@  discard block
 block discarded – undo
210 210
                             // do not display the option at all; it gets auto-set by the ProfileSilverbullet constructor and doesn't have to be seen
211 211
                             break;
212 212
                         }
213
-                        $retval .= "<tr><td>" . $this->displayName($option['name']) . "</td><td>$language</td><td><strong>" . ($content == "on" ? _("on") : _("off") ) . "</strong></td></tr>";
213
+                        $retval .= "<tr><td>".$this->displayName($option['name'])."</td><td>$language</td><td><strong>".($content == "on" ? _("on") : _("off"))."</strong></td></tr>";
214 214
                         break;
215 215
                     default:
216
-                        $retval .= "<tr><td>" . $this->displayName($option['name']) . "</td><td>$language</td><td><strong>$content</strong></td></tr>";
216
+                        $retval .= "<tr><td>".$this->displayName($option['name'])."</td><td>$language</td><td><strong>$content</strong></td></tr>";
217 217
                 }
218 218
             }
219 219
         }
@@ -222,11 +222,11 @@  discard block
 block discarded – undo
222 222
             $locationCount = 0;
223 223
             foreach ($locationMarkers as $g) {
224 224
                 $locationCount++;
225
-                $marker .= '<marker name="' . $locationCount . '" lat="' . $g['lat'] . '" lng="' . $g['lon'] . '" />';
225
+                $marker .= '<marker name="'.$locationCount.'" lat="'.$g['lat'].'" lng="'.$g['lon'].'" />';
226 226
             }
227 227
             $marker .= '<\/markers>'; // some validator says this should be escaped
228 228
             $jMarker = json_encode($locationMarkers);
229
-            $retval .= '<tr><td><script>markers=\'' . $marker . '\'; jmarkers = \'' . $jMarker . '\';</script></td><td></td><td></td></tr>';
229
+            $retval .= '<tr><td><script>markers=\''.$marker.'\'; jmarkers = \''.$jMarker.'\';</script></td><td></td><td></td></tr>';
230 230
         }
231 231
         \core\common\Entity::outOfThePotatoes();
232 232
         return $retval;
@@ -242,11 +242,11 @@  discard block
 block discarded – undo
242 242
         \core\common\Entity::intoThePotatoes();
243 243
         $idpoptions = $myInst->getAttributes();
244 244
         $retval = "<div class='infobox'>
245
-        <h2>" . sprintf(_("General %s details"), $this->nomenclatureParticipant) . "</h2>
245
+        <h2>" . sprintf(_("General %s details"), $this->nomenclatureParticipant)."</h2>
246 246
         <table>
247 247
             <tr>
248 248
                 <td>
249
-                    " . _("Country:") . "
249
+                    " . _("Country:")."
250 250
                 </td>
251 251
                 <td>
252 252
                 </td>
@@ -256,16 +256,16 @@  discard block
 block discarded – undo
256 256
         $retval .= $myFed->name;
257 257
         $retval .= "</strong>
258 258
                 </td>
259
-            </tr>" . $this->infoblock($idpoptions, "general", "IdP") . "
259
+            </tr>" . $this->infoblock($idpoptions, "general", "IdP")."
260 260
         </table>
261 261
     </div>";
262 262
 
263 263
         $blocks = [["support", _("Global Helpdesk Details")], ["media", _("Media Properties")]];
264 264
         foreach ($blocks as $block) {
265 265
             $retval .= "<div class='infobox'>
266
-            <h2>" . $block[1] . "</h2>
266
+            <h2>" . $block[1]."</h2>
267 267
             <table>" .
268
-                    $this->infoblock($idpoptions, $block[0], "IdP") .
268
+                    $this->infoblock($idpoptions, $block[0], "IdP").
269 269
                     "</table>
270 270
         </div>";
271 271
         }
@@ -280,12 +280,12 @@  discard block
 block discarded – undo
280 280
      */
281 281
     private function displaySize(int $number) {
282 282
         if ($number > 1024 * 1024) {
283
-            return round($number / 1024 / 1024, 2) . " MiB";
283
+            return round($number / 1024 / 1024, 2)." MiB";
284 284
         }
285 285
         if ($number > 1024) {
286
-            return round($number / 1024, 2) . " KiB";
286
+            return round($number / 1024, 2)." KiB";
287 287
         }
288
-        return $number . " B";
288
+        return $number." B";
289 289
     }
290 290
 
291 291
     /**
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
         $ref = $validator->databaseReference($cAReference);
340 340
         $rawResult = UIElements::getBlobFromDB($ref['table'], $ref['rowindex'], FALSE);
341 341
         if (is_bool($rawResult)) { // we didn't actually get a CA!
342
-            $retval = "<div class='ca-summary'>" . _("There was an error while retrieving the certificate from the database!") . "</div>";
342
+            $retval = "<div class='ca-summary'>"._("There was an error while retrieving the certificate from the database!")."</div>";
343 343
             \core\common\Entity::outOfThePotatoes();
344 344
             return $retval;
345 345
         }
@@ -355,14 +355,14 @@  discard block
 block discarded – undo
355 355
 
356 356
         $details['name'] = preg_replace('/(.)\/(.)/', "$1<br/>$2", $details['name']);
357 357
         $details['name'] = preg_replace('/\//', "", $details['name']);
358
-        $certstatus = ( $details['root'] == 1 ? "R" : "I");
359
-        $certTooltip = ( $details['root'] == 1 ? _("Root CA") : _("Intermediate CA"));
358
+        $certstatus = ($details['root'] == 1 ? "R" : "I");
359
+        $certTooltip = ($details['root'] == 1 ? _("Root CA") : _("Intermediate CA"));
360 360
         if ($details['ca'] == 0 && $details['root'] != 1) {
361
-            $retval = "<div class='ca-summary' style='background-color:red'><div style='position:absolute; right: 0px; width:20px; height:20px; background-color:maroon;  border-radius:10px; text-align: center;'><div style='padding-top:3px; font-weight:bold; color:#ffffff;'>S</div></div>" . _("This is a <strong>SERVER</strong> certificate!") . "<br/>" . $details['name'] . "</div>";
361
+            $retval = "<div class='ca-summary' style='background-color:red'><div style='position:absolute; right: 0px; width:20px; height:20px; background-color:maroon;  border-radius:10px; text-align: center;'><div style='padding-top:3px; font-weight:bold; color:#ffffff;'>S</div></div>"._("This is a <strong>SERVER</strong> certificate!")."<br/>".$details['name']."</div>";
362 362
             \core\common\Entity::outOfThePotatoes();
363 363
             return $retval;
364 364
         }
365
-        $retval = "<div class='ca-summary'                                ><div style='position:absolute; right: 0px; width:20px; height:20px; background-color:#0000ff; border-radius:10px; text-align: center;'><div title='$certTooltip' style='padding-top:3px; font-weight:bold; color:#ffffff;'>$certstatus</div></div>" . $details['name'] . "</div>";
365
+        $retval = "<div class='ca-summary'                                ><div style='position:absolute; right: 0px; width:20px; height:20px; background-color:#0000ff; border-radius:10px; text-align: center;'><div title='$certTooltip' style='padding-top:3px; font-weight:bold; color:#ffffff;'>$certstatus</div></div>".$details['name']."</div>";
366 366
         \core\common\Entity::outOfThePotatoes();
367 367
         return $retval;
368 368
     }
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
      */
376 376
     public function previewImageinHTML($imageReference) {
377 377
         \core\common\Entity::intoThePotatoes();
378
-        $retval = "<img style='max-width:150px' src='inc/filepreview.php?id=" . $imageReference . "' alt='" . _("Preview of logo file") . "'/>";
378
+        $retval = "<img style='max-width:150px' src='inc/filepreview.php?id=".$imageReference."' alt='"._("Preview of logo file")."'/>";
379 379
         \core\common\Entity::outOfThePotatoes();
380 380
         return $retval;
381 381
     }
@@ -392,13 +392,13 @@  discard block
 block discarded – undo
392 392
         $ref = $validator->databaseReference($fileReference);
393 393
         $fileBlob = UIElements::getBlobFromDB($ref['table'], $ref['rowindex'], FALSE);
394 394
         if (is_bool($fileBlob)) { // we didn't actually get a file!
395
-            $retval = "<div class='ca-summary'>" . _("There was an error while retrieving the file from the database!") . "</div>";
395
+            $retval = "<div class='ca-summary'>"._("There was an error while retrieving the file from the database!")."</div>";
396 396
             \core\common\Entity::outOfThePotatoes();
397 397
             return $retval;
398 398
         }
399 399
         $decodedFileBlob = base64_decode($fileBlob);
400 400
         $fileinfo = new \finfo();
401
-        $retval = "<div class='ca-summary'>" . _("File exists") . " (" . $fileinfo->buffer($decodedFileBlob, FILEINFO_MIME_TYPE) . ", " . $this->displaySize(strlen($decodedFileBlob)) . ")<br/><a href='inc/filepreview.php?id=$fileReference'>" . _("Preview") . "</a></div>";
401
+        $retval = "<div class='ca-summary'>"._("File exists")." (".$fileinfo->buffer($decodedFileBlob, FILEINFO_MIME_TYPE).", ".$this->displaySize(strlen($decodedFileBlob)).")<br/><a href='inc/filepreview.php?id=$fileReference'>"._("Preview")."</a></div>";
402 402
         \core\common\Entity::outOfThePotatoes();
403 403
         return $retval;
404 404
     }
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
             $retval .= "<tr><td>";
427 427
         }
428 428
         $finalCaption = ($caption !== NULL ? $caption : $uiMessages[$level]['text']);
429
-        $retval .= "<img class='icon' src='" . $uiMessages[$level]['icon'] . "' alt='" . $finalCaption . "' title='" . $finalCaption . "'/>";
429
+        $retval .= "<img class='icon' src='".$uiMessages[$level]['icon']."' alt='".$finalCaption."' title='".$finalCaption."'/>";
430 430
         if (!$omittabletags) {
431 431
             $retval .= "</td><td>";
432 432
         }
@@ -508,8 +508,8 @@  discard block
 block discarded – undo
508 508
             return "";
509 509
         }
510 510
 
511
-        $loggerInstance->debug(4, "Consortium logo is at: " . ROOT . "/web/resources/images/consortium_logo_large.png");
512
-        $logogd = imagecreatefrompng(ROOT . "/web/resources/images/consortium_logo_large.png");
511
+        $loggerInstance->debug(4, "Consortium logo is at: ".ROOT."/web/resources/images/consortium_logo_large.png");
512
+        $logogd = imagecreatefrompng(ROOT."/web/resources/images/consortium_logo_large.png");
513 513
         if ($logogd === FALSE) { // consortium logo is bogus; don't do anything
514 514
             return "";
515 515
         }
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
535 535
         imagecolorallocate($whiteimage, 255, 255, 255);
536 536
         // also make sure the initial placement is a multitude of 12; otherwise "two half" symbols might be affected
537 537
         $targetplacementx = (int) ($symbolsize * round(($sizeinput[0] / 2 - ($targetwidth - $symbolsize + 1) / 2) / $symbolsize));
538
-        $targetplacementy = (int) ($symbolsize * round(($sizeinput[1] / 2 - ($targetheight - $symbolsize + 1 ) / 2) / $symbolsize));
538
+        $targetplacementy = (int) ($symbolsize * round(($sizeinput[1] / 2 - ($targetheight - $symbolsize + 1) / 2) / $symbolsize));
539 539
         imagecopyresized($inputgd, $whiteimage, $targetplacementx - $symbolsize, $targetplacementy - $symbolsize, 0, 0, $targetwidth + 2 * $symbolsize, $targetheight + 2 * $symbolsize, $targetwidth + 2 * $symbolsize, $targetheight + 2 * $symbolsize);
540 540
         imagecopyresized($inputgd, $logogd, $targetplacementx, $targetplacementy, 0, 0, $targetwidth, $targetheight, $sizelogo[0], $sizelogo[1]);
541 541
         ob_start();
@@ -585,9 +585,9 @@  discard block
 block discarded – undo
585 585
                 $message = "Your configuration appears to be fine.";
586 586
                 break;
587 587
             default:
588
-                throw new Exception("The result code level " . $test->test_result['global'] . " is not defined!");
588
+                throw new Exception("The result code level ".$test->test_result['global']." is not defined!");
589 589
         }
590
-        $out .= $this->boxFlexible($test->test_result['global'], "<br><strong>Test Summary</strong><br>" . $message . "<br>See below for details<br><hr>");
590
+        $out .= $this->boxFlexible($test->test_result['global'], "<br><strong>Test Summary</strong><br>".$message."<br>See below for details<br><hr>");
591 591
         foreach ($test->out as $testValue) {
592 592
             foreach ($testValue as $o) {
593 593
                 $out .= $this->boxFlexible($o['level'], $o['message']);
Please login to merge, or discard this patch.
web/admin/overview_org.php 1 patch
Spacing   +47 added lines, -47 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 function displaySilverbulletPropertyWidget(&$theProfile, $readonly, &$uiElements) {
32 32
     ?>
@@ -43,14 +43,14 @@  discard block
 block discarded – undo
43 43
                 <ul style='margin:1px'>
44 44
                     <?php
45 45
                     foreach ($completeness as $missing_attrib) {
46
-                        echo "<li>" . $uiElements->displayName($missing_attrib) . "</li>";
46
+                        echo "<li>".$uiElements->displayName($missing_attrib)."</li>";
47 47
                     }
48 48
                     ?>
49 49
                 </ul>
50 50
             </div>
51 51
             <?php
52 52
         } else {
53
-            echo sprintf(_("You can create up to %d users."), $maxusers[0]['value']) . "<br/>" . sprintf(_("Their credentials will carry the name <strong>%s</strong>."), $theProfile->realm);
53
+            echo sprintf(_("You can create up to %d users."), $maxusers[0]['value'])."<br/>".sprintf(_("Their credentials will carry the name <strong>%s</strong>."), $theProfile->realm);
54 54
         }
55 55
         ?>
56 56
         <br/>
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         if ($readonly === FALSE) {
60 60
             ?>
61 61
             <form action='edit_silverbullet.php?inst_id=<?php echo $theProfile->institution; ?>&amp;profile_id=<?php echo $theProfile->identifier; ?>' method='POST'>
62
-                <button <?php echo ( is_array($completeness) ? "disabled" : "" ); ?> type='submit' name='sb_action' value='sb_edit'><?php echo _("Manage User Base"); ?></button>
62
+                <button <?php echo (is_array($completeness) ? "disabled" : ""); ?> type='submit' name='sb_action' value='sb_edit'><?php echo _("Manage User Base"); ?></button>
63 63
             </form>
64 64
             <?php
65 65
         }
@@ -94,21 +94,21 @@  discard block
 block discarded – undo
94 94
                 $has_overrides = TRUE;
95 95
             }
96 96
         }
97
-        $buffer_eaptypediv = "<div style='margin-bottom:40px; float:left;'>" . _("<strong>EAP Types</strong> (in order of preference):") . "<br/>";
97
+        $buffer_eaptypediv = "<div style='margin-bottom:40px; float:left;'>"._("<strong>EAP Types</strong> (in order of preference):")."<br/>";
98 98
         $typelist = $theProfile->getEapMethodsinOrderOfPreference();
99 99
         $allcomplete = TRUE;
100 100
         foreach ($typelist as $eaptype) {
101 101
             $buffer_eaptypediv .= $eaptype->getPrintableRep();
102 102
             $completeness = $theProfile->isEapTypeDefinitionComplete($eaptype);
103 103
             if ($completeness === true) {
104
-                $buffer_eaptypediv .= " <div class='acceptable'>" . _("OK") . "</div>";
104
+                $buffer_eaptypediv .= " <div class='acceptable'>"._("OK")."</div>";
105 105
             } else {
106 106
                 $buffer_eaptypediv .= " <div class='notacceptable'>";
107 107
                 $buffer_eaptypediv .= _("Information needed!");
108 108
                 if (is_array($completeness)) {
109 109
                     $buffer_eaptypediv .= "<ul style='margin:1px'>";
110 110
                     foreach ($completeness as $missing_attrib) {
111
-                        $buffer_eaptypediv .= "<li>" . $uiElements->displayName($missing_attrib) . "</li>";
111
+                        $buffer_eaptypediv .= "<li>".$uiElements->displayName($missing_attrib)."</li>";
112 112
                     }
113 113
                     $buffer_eaptypediv .= "</ul>";
114 114
                 }
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
             foreach ($attribs as $attrib) {
121 121
                 if ($attrib['level'] == \core\Options::LEVEL_METHOD && !preg_match("/^internal:/", $attrib['name']) && !$justOnce) {
122 122
                     $justOnce = TRUE;
123
-                    $buffer_eaptypediv .= "<img src='../resources/images/icons/Letter-E-blue-icon.png' alt='" . _("Options on EAP Method/Device level are in effect.") . "'>";
123
+                    $buffer_eaptypediv .= "<img src='../resources/images/icons/Letter-E-blue-icon.png' alt='"._("Options on EAP Method/Device level are in effect.")."'>";
124 124
                 }
125 125
             }
126 126
             $buffer_eaptypediv .= "<br/>";
@@ -166,11 +166,11 @@  discard block
 block discarded – undo
166 166
                 if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] == "LOCAL") {
167 167
                     $diagUrl = "../diag/";
168 168
                 } else {
169
-                    $diagUrl = \config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] . "/diag/";
169
+                    $diagUrl = \config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS']."/diag/";
170 170
                 }
171 171
                 ?>
172
-                <form action='<?php echo $diagUrl . "action_realmcheck.php?inst_id=" . $theProfile->institution . "&profile_id=" . $theProfile->identifier ?>' method='post' accept-charset='UTF-8'>
173
-                    <input type='hidden' name='comefrom' value='<?php echo htmlspecialchars($link . $_SERVER['SCRIPT_NAME']); ?>'/>
172
+                <form action='<?php echo $diagUrl."action_realmcheck.php?inst_id=".$theProfile->institution."&profile_id=".$theProfile->identifier ?>' method='post' accept-charset='UTF-8'>
173
+                    <input type='hidden' name='comefrom' value='<?php echo htmlspecialchars($link.$_SERVER['SCRIPT_NAME']); ?>'/>
174 174
                     <button type='submit' name='profile_action' value='check' <?php echo ($has_realm ? "" : "disabled='disabled'"); ?> title='<?php echo _("The realm can only be checked if you configure the realm!"); ?>'>
175 175
                         <?php echo _("Check realm reachability"); ?>
176 176
                     </button>
@@ -203,9 +203,9 @@  discard block
 block discarded – undo
203 203
                 ?>
204 204
                 <div style='display: flex;'>
205 205
                     <?php
206
-                    $idpLevelUrl = $link . dirname(dirname($_SERVER['SCRIPT_NAME'])) . "?idp=" . $theProfile->institution;
207
-                    $displayurl = $idpLevelUrl . "&amp;profile=" . $theProfile->identifier;
208
-                    $QRurl = $idpLevelUrl . "&profile=" . $theProfile->identifier;
206
+                    $idpLevelUrl = $link.dirname(dirname($_SERVER['SCRIPT_NAME']))."?idp=".$theProfile->institution;
207
+                    $displayurl = $idpLevelUrl."&amp;profile=".$theProfile->identifier;
208
+                    $QRurl = $idpLevelUrl."&profile=".$theProfile->identifier;
209 209
                     $qrCode = new \chillerlan\QRCode\QRCode(new \chillerlan\QRCode\QROptions([
210 210
                                 'outputType' => \chillerlan\QRCode\QRCode::OUTPUT_IMAGE_PNG,
211 211
                                 'eccLevel' => \chillerlan\QRCode\QRCode::ECC_H,
@@ -217,9 +217,9 @@  discard block
 block discarded – undo
217 217
                     if (empty($rawQr)) {
218 218
                         throw new Exception("Something went seriously wrong during QR code generation!");
219 219
                     }
220
-                    $uri = "data:image/png;base64," . base64_encode($uiElements->pngInjectConsortiumLogo($rawQr, web\lib\admin\UIElements::QRCODE_PIXELS_PER_SYMBOL));
220
+                    $uri = "data:image/png;base64,".base64_encode($uiElements->pngInjectConsortiumLogo($rawQr, web\lib\admin\UIElements::QRCODE_PIXELS_PER_SYMBOL));
221 221
                     $size = getimagesize($uri);
222
-                    echo "<img width='" . ($size[0] / 4) . "' height='" . ($size[1] / 4) . "' src='$uri' alt='QR-code'/>";
222
+                    echo "<img width='".($size[0] / 4)."' height='".($size[1] / 4)."' src='$uri' alt='QR-code'/>";
223 223
 
224 224
                     //echo "<nobr>$displayurl</nobr></a>";
225 225
                     echo "<p>$displayurl</p></a>";
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
             <h2><?php
264 264
                 switch ($deploymentObject->consortium) {
265 265
                     case "eduroam":
266
-                        $displayname = config\ConfAssistant::CONSORTIUM['name'] . " " . core\DeploymentManaged::PRODUCTNAME;
266
+                        $displayname = config\ConfAssistant::CONSORTIUM['name']." ".core\DeploymentManaged::PRODUCTNAME;
267 267
                         break;
268 268
                     case "OpenRoaming":
269 269
                         $displayname = "OpenRoaming ANP";
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
                     default:
272 272
                         throw new Exception("We are supposed to operate on a roaming consortium we don't know.");
273 273
                 }
274
-                echo $displayname . " (<span style='color:" . ( $deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>" . _("inactive") : "green;'>" . _("active") ) . "</span>)";
274
+                echo $displayname." (<span style='color:".($deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>"._("inactive") : "green;'>"._("active"))."</span>)";
275 275
                 ?></h2>
276 276
             <table>
277 277
                 <caption><?php echo _("Deployment Details"); ?></caption>
@@ -285,13 +285,13 @@  discard block
 block discarded – undo
285 285
                     <td><strong><?php echo _("Your primary RADIUS server") ?></strong><br/>
286 286
                         <?php
287 287
                         if ($deploymentObject->host1_v4 !== NULL) {
288
-                            echo _("IPv4") . ": " . $deploymentObject->host1_v4;
288
+                            echo _("IPv4").": ".$deploymentObject->host1_v4;
289 289
                         }
290 290
                         if ($deploymentObject->host1_v4 !== NULL && $deploymentObject->host1_v6 !== NULL) {
291 291
                             echo "<br/>";
292 292
                         }
293 293
                         if ($deploymentObject->host1_v6 !== NULL) {
294
-                            echo _("IPv6") . ": " . $deploymentObject->host1_v6;
294
+                            echo _("IPv6").": ".$deploymentObject->host1_v6;
295 295
                         }
296 296
                         ?>
297 297
                     </td>
@@ -299,9 +299,9 @@  discard block
 block discarded – undo
299 299
                     <td><?php echo $deploymentObject->port1; ?></td>
300 300
                     <td>
301 301
                         <?php
302
-                        echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_1]['icon'] .
303
-                        "' alt='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] .
304
-                        "' title='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . "'>";
302
+                        echo "<img src='".$radiusMessages[$deploymentObject->radius_status_1]['icon'].
303
+                        "' alt='".$radiusMessages[$deploymentObject->radius_status_1]['text'].
304
+                        "' title='".$radiusMessages[$deploymentObject->radius_status_1]['text']."'>";
305 305
                         ?>
306 306
                     </td>
307 307
                 </tr>
@@ -309,22 +309,22 @@  discard block
 block discarded – undo
309 309
                     <td><strong><?php echo _("Your backup RADIUS server") ?><br/></strong>
310 310
                         <?php
311 311
                         if ($deploymentObject->host2_v4 !== NULL) {
312
-                            echo _("IPv4") . ": " . $deploymentObject->host2_v4;
312
+                            echo _("IPv4").": ".$deploymentObject->host2_v4;
313 313
                         }
314 314
                         if ($deploymentObject->host2_v4 !== NULL && $deploymentObject->host2_v6 !== NULL) {
315 315
                             echo "<br/>";
316 316
                         }
317 317
                         if ($deploymentObject->host2_v6 !== NULL) {
318
-                            echo _("IPv6") . ": " . $deploymentObject->host2_v6;
318
+                            echo _("IPv6").": ".$deploymentObject->host2_v6;
319 319
                         }
320 320
                         ?></td>
321 321
                     <td><?php echo _("RADIUS port number: ") ?></td>
322 322
                     <td><?php echo $deploymentObject->port2; ?></td>
323 323
                     <td>
324 324
                         <?php
325
-                        echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_2]['icon'] .
326
-                        "' alt='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] .
327
-                        "' title='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . "'>";
325
+                        echo "<img src='".$radiusMessages[$deploymentObject->radius_status_2]['icon'].
326
+                        "' alt='".$radiusMessages[$deploymentObject->radius_status_2]['text'].
327
+                        "' title='".$radiusMessages[$deploymentObject->radius_status_2]['text']."'>";
328 328
                         ?>
329 329
                     </td>
330 330
                 </tr>
@@ -376,12 +376,12 @@  discard block
 block discarded – undo
376 376
                             if (array_key_exists('FAILURE', $res) && $res['FAILURE'] > 0) {
377 377
                                 echo '<br>';
378 378
                                 if ($res['FAILURE'] == 2) {
379
-                                    echo ' <span style="color: red;">' . _("Activation failure.") . '</span>';
379
+                                    echo ' <span style="color: red;">'._("Activation failure.").'</span>';
380 380
                                 } else {
381 381
                                     if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
382
-                                        echo ' <span style="color: red;">' . _("Activation failure for your primary RADIUS server.") . '</span>';
382
+                                        echo ' <span style="color: red;">'._("Activation failure for your primary RADIUS server.").'</span>';
383 383
                                     } else {
384
-                                        echo ' <span style="color: red;">' . _("Activation failure for your backup RADIUS server.") . '</span>';
384
+                                        echo ' <span style="color: red;">'._("Activation failure for your backup RADIUS server.").'</span>';
385 385
                                     }
386 386
                                 }
387 387
                             }
@@ -416,12 +416,12 @@  discard block
 block discarded – undo
416 416
                                 if ($res['FAILURE'] > 0) {
417 417
                                     echo '<br>';
418 418
                                     if ($res['FAILURE'] == 2) {
419
-                                        echo ' <span style="color: red;">' . _("Failure during deactivation, your request is queued for handling") . '</span>';
419
+                                        echo ' <span style="color: red;">'._("Failure during deactivation, your request is queued for handling").'</span>';
420 420
                                     } else {
421 421
                                         if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
422
-                                            echo ' <span style="color: red;">' . _("Deactivation failure for your primary RADIUS server, your request is queued.") . '</span>';
422
+                                            echo ' <span style="color: red;">'._("Deactivation failure for your primary RADIUS server, your request is queued.").'</span>';
423 423
                                         } else {
424
-                                            echo ' <span style="color: red;">' . _("Deactivation failure for your backup RADIUS server, your request is queued.") . '</span>';
424
+                                            echo ' <span style="color: red;">'._("Deactivation failure for your backup RADIUS server, your request is queued.").'</span>';
425 425
                                         }
426 426
                                     }
427 427
                                 }
@@ -442,24 +442,24 @@  discard block
 block discarded – undo
442 442
         </div>
443 443
         <div style='width:20px;'></div> <!-- QR code space, reserved -->
444 444
         <div style='display: table-cell; min-width:200px;'>
445
-            <?php $tablecaption = _("Hotspot Usage Statistics");?>
445
+            <?php $tablecaption = _("Hotspot Usage Statistics"); ?>
446 446
             <h1><?php echo $tablecaption; ?></h1>
447
-            <h2><?php echo _("5 most recent authentications");?></h2>
448
-            <p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)");?></p>
447
+            <h2><?php echo _("5 most recent authentications"); ?></h2>
448
+            <p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)"); ?></p>
449 449
             <table class='authrecord'>
450
-    <caption><?php echo $tablecaption;?></caption>
450
+    <caption><?php echo $tablecaption; ?></caption>
451 451
     <tr style='text-align: left;'>
452
-        <th scope="col"><strong><?php echo _("Timestamp (UTC)");?></strong></th>
453
-        <th scope="col"><strong><?php echo _("Realm");?></strong></th>
454
-        <th scope="col"><strong><?php echo _("MAC Address");?></strong></th>
455
-        <th scope="col"><strong><?php echo _("Chargeable-User-Identity");?></strong></th>
456
-        <th scope="col"><strong><?php echo _("Result");?></strong></th>
457
-        <th scope="col"><strong><?php echo _("AP Identifier");?></strong></th>
452
+        <th scope="col"><strong><?php echo _("Timestamp (UTC)"); ?></strong></th>
453
+        <th scope="col"><strong><?php echo _("Realm"); ?></strong></th>
454
+        <th scope="col"><strong><?php echo _("MAC Address"); ?></strong></th>
455
+        <th scope="col"><strong><?php echo _("Chargeable-User-Identity"); ?></strong></th>
456
+        <th scope="col"><strong><?php echo _("Result"); ?></strong></th>
457
+        <th scope="col"><strong><?php echo _("AP Identifier"); ?></strong></th>
458 458
     </tr>
459 459
     <?php
460
-    $userAuthData = $deploymentObject->retrieveStatistics(0,5);
460
+    $userAuthData = $deploymentObject->retrieveStatistics(0, 5);
461 461
     foreach ($userAuthData as $oneRecord) {
462
-        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail" )."'>"
462
+        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail")."'>"
463 463
                 . "<td>".$oneRecord['activity_time']."</td>"
464 464
                 . "<td>".$oneRecord['realm']."</td>"
465 465
                 . "<td>".$oneRecord['mac']."</td>"
@@ -670,7 +670,7 @@  discard block
 block discarded – undo
670 670
                         <div>
671 671
                             <input type="hidden" name="consortium" value="eduroam"/>
672 672
                             <button type='submit' <?php echo ($hasMail > 0 ? "" : "disabled"); ?> name='profile_action' value='new'>
673
-                                <?php echo sprintf(_("Add %s deployment ..."), \config\ConfAssistant::CONSORTIUM['name'] . " " . \core\DeploymentManaged::PRODUCTNAME); ?>
673
+                                <?php echo sprintf(_("Add %s deployment ..."), \config\ConfAssistant::CONSORTIUM['name']." ".\core\DeploymentManaged::PRODUCTNAME); ?>
674 674
                             </button>
675 675
                             <span style='color: red;'>
676 676
                             <?php if ($hasMail == 0) { 
Please login to merge, or discard this patch.
core/common/Language.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -75,9 +75,9 @@  discard block
 block discarded – undo
75 75
         $loggerInstance = new \core\common\Logging();
76 76
         $olddomain = textdomain(NULL);
77 77
         $loggerInstance->debug(4, "set_locale($domain)\n");
78
-        $loggerInstance->debug(4, ROOT . "\n");
78
+        $loggerInstance->debug(4, ROOT."\n");
79 79
         textdomain($domain);
80
-        bindtextdomain($domain, ROOT . "/translation/");
80
+        bindtextdomain($domain, ROOT."/translation/");
81 81
         bind_textdomain_codeset($domain, "UTF-8");
82 82
         return $olddomain;
83 83
     }
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 
130 130
             // check if this language is supported by the CAT config
131 131
             foreach (\config\Master::LANGUAGES as $language => $value) {
132
-                if (preg_match("/^" . $language . ".*/", $tryLang)) {
132
+                if (preg_match("/^".$language.".*/", $tryLang)) {
133 133
                     $localeTmp = $value['locale'];
134 134
                     $langIndex = $language; // ???
135 135
                     break;
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
                 }
145 145
             }
146 146
         }
147
-        putenv("LC_ALL=" . $theLocale);
147
+        putenv("LC_ALL=".$theLocale);
148 148
         $_SESSION['language'] = $langIndex;
149 149
         $loggerInstance = new \core\common\Logging();
150 150
         $loggerInstance->debug(4, "selected lang:$langIndex:$theLocale\n");
Please login to merge, or discard this patch.
core/common/Entity.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     public function __construct()
111 111
     {
112 112
         $this->loggerInstance = new Logging();
113
-        $this->loggerInstance->debug(3, "--- BEGIN constructing class " . get_class($this) . " .\n");
113
+        $this->loggerInstance->debug(3, "--- BEGIN constructing class ".get_class($this)." .\n");
114 114
         $this->languageInstance = new Language();
115 115
         Entity::intoThePotatoes("core");
116 116
         // some config elements are displayable. We need some dummies to 
@@ -129,13 +129,13 @@  discard block
 block discarded – undo
129 129
         $dummy_organisation2a = _("organization");
130 130
         $dummy_organisation3 = _("entity");
131 131
         // and do something useless with the strings so that there's no "unused" complaint
132
-        if (strlen($dummy_NRO . $dummy_idp1 . $dummy_idp2 . $dummy_idp3 . $dummy_hotspot1 . $dummy_hotspot2 . $dummy_hotspot3 . $dummy_organisation1 . $dummy_organisation2 . $dummy_organisation2a . $dummy_organisation3) < 0) {
132
+        if (strlen($dummy_NRO.$dummy_idp1.$dummy_idp2.$dummy_idp3.$dummy_hotspot1.$dummy_hotspot2.$dummy_hotspot3.$dummy_organisation1.$dummy_organisation2.$dummy_organisation2a.$dummy_organisation3) < 0) {
133 133
             throw new Exception("Strings are usually not shorter than 0 characters. We've encountered a string blackhole.");
134 134
         }
135
-        $xyzVariableFed = \config\ConfAssistant::CONSORTIUM['nomenclature_federation'] . "";
136
-        $xyzVariableIdP = \config\ConfAssistant::CONSORTIUM['nomenclature_idp'] . "";
137
-        $xyzVariableHotspot = \config\ConfAssistant::CONSORTIUM['nomenclature_hotspot'] . "";
138
-        $xyzVariableParticipant = \config\ConfAssistant::CONSORTIUM['nomenclature_participant'] . "";
135
+        $xyzVariableFed = \config\ConfAssistant::CONSORTIUM['nomenclature_federation']."";
136
+        $xyzVariableIdP = \config\ConfAssistant::CONSORTIUM['nomenclature_idp']."";
137
+        $xyzVariableHotspot = \config\ConfAssistant::CONSORTIUM['nomenclature_hotspot']."";
138
+        $xyzVariableParticipant = \config\ConfAssistant::CONSORTIUM['nomenclature_participant']."";
139 139
         Entity::$nomenclature_fed = _($xyzVariableFed);
140 140
         Entity::$nomenclature_idp = _($xyzVariableIdP);
141 141
         Entity::$nomenclature_hotspot = _($xyzVariableHotspot);
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
      */
152 152
     public function __destruct()
153 153
     {
154
-        (new Logging())->debug(5, "--- KILL Destructing class " . get_class($this) . " .\n");
154
+        (new Logging())->debug(5, "--- KILL Destructing class ".get_class($this)." .\n");
155 155
     }
156 156
 
157 157
     /**
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     public static function createTemporaryDirectory($purpose = 'installer', $failIsFatal = 1)
185 185
     {
186 186
         $loggerInstance = new Logging();
187
-        $name = md5(time() . rand());
187
+        $name = md5(time().rand());
188 188
         $path = ROOT;
189 189
         switch ($purpose) {
190 190
             case 'silverbullet':
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
             default:
203 203
                 throw new Exception("unable to create temporary directory due to unknown purpose: $purpose\n");
204 204
         }
205
-        $tmpDir = $path . '/' . $name;
205
+        $tmpDir = $path.'/'.$name;
206 206
         $loggerInstance->debug(4, "temp dir: $purpose : $tmpDir\n");
207 207
         if (!mkdir($tmpDir, 0700, true)) {
208 208
             if ($failIsFatal) {
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      */
224 224
     public static function rrmdir($dir)
225 225
     {
226
-        foreach (glob($dir . '/*') as $file) {
226
+        foreach (glob($dir.'/*') as $file) {
227 227
             if (is_dir($file)) {
228 228
                 Entity::rrmdir($file);
229 229
             } else {
@@ -249,12 +249,12 @@  discard block
 block discarded – undo
249 249
         }
250 250
         // these substr() are guaranteed to yield actual string data, as the
251 251
         // base string is an MD5 hash - has sufficient length
252
-        $uuid = /** @scrutinizer ignore-type */ substr($chars, 0, 8) . '-';
253
-        $uuid .= /** @scrutinizer ignore-type */ substr($chars, 8, 4) . '-';
254
-        $uuid .= /** @scrutinizer ignore-type */ substr($chars, 12, 4) . '-';
255
-        $uuid .= /** @scrutinizer ignore-type */ substr($chars, 16, 4) . '-';
252
+        $uuid = /** @scrutinizer ignore-type */ substr($chars, 0, 8).'-';
253
+        $uuid .= /** @scrutinizer ignore-type */ substr($chars, 8, 4).'-';
254
+        $uuid .= /** @scrutinizer ignore-type */ substr($chars, 12, 4).'-';
255
+        $uuid .= /** @scrutinizer ignore-type */ substr($chars, 16, 4).'-';
256 256
         $uuid .= /** @scrutinizer ignore-type */ substr($chars, 20, 12);
257
-        return $prefix . $uuid;
257
+        return $prefix.$uuid;
258 258
     }
259 259
 
260 260
     /**
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
         for ($i = count($trace); $i--; $i > 0) {
296 296
             if (isset($trace[$i - 1]['class']) && preg_match('/Entity/', $trace[$i - 1]['class'])) {
297 297
                 if ($showTrace) {
298
-                    echo "FOUND caller: " . /** @scrutinizer ignore-type */ print_r($trace[$i], true) . " - class is " . $trace[$i]['class'];
298
+                    echo "FOUND caller: "./** @scrutinizer ignore-type */ print_r($trace[$i], true)." - class is ".$trace[$i]['class'];
299 299
                 }
300 300
                 $caller = $trace[$i];
301 301
                 break;
@@ -305,8 +305,8 @@  discard block
 block discarded – undo
305 305
         // otherwise, on the filename relative to ROOT
306 306
         $myName = $caller['class'] ?? substr($caller['file'], strlen(ROOT));
307 307
         if ($showTrace === TRUE) {
308
-            echo "<pre>" . /** @scrutinizer ignore-type */ print_r($trace, true) . "</pre>";
309
-            echo "CLASS = " . $myName . "<br/>";
308
+            echo "<pre>"./** @scrutinizer ignore-type */ print_r($trace, true)."</pre>";
309
+            echo "CLASS = ".$myName."<br/>";
310 310
         }
311 311
         if (preg_match("/diag/", $myName) == 1) {
312 312
             $ret = "diagnostics";
@@ -340,11 +340,11 @@  discard block
 block discarded – undo
340 340
         if ($catalogue === NULL) {
341 341
             $theCatalogue = Entity::determineOwnCatalogue($trace);
342 342
             textdomain($theCatalogue);
343
-            bindtextdomain($theCatalogue, ROOT . "/translation/");
343
+            bindtextdomain($theCatalogue, ROOT."/translation/");
344 344
             bind_textdomain_codeset($theCatalogue, "UTF-8");
345 345
         } else {
346 346
             textdomain($catalogue);
347
-            bindtextdomain($catalogue, ROOT . "/translation/");
347
+            bindtextdomain($catalogue, ROOT."/translation/");
348 348
             bind_textdomain_codeset($catalogue, "UTF-8");
349 349
         }
350 350
     }
Please login to merge, or discard this patch.
web/admin/inc/deploymentStats.inc.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
  * ******************************************************************************
10 10
  */
11 11
 
12
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
12
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
13 13
 
14 14
 $auth = new \web\lib\admin\Authentication();
15 15
 $auth->authenticate();
@@ -37,21 +37,21 @@  discard block
 block discarded – undo
37 37
 ?>
38 38
 
39 39
 <h1><?php $tablecaption = _("Deployment Usage Records"); echo $tablecaption; ?></h1>
40
-<p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)");?></p>
40
+<p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)"); ?></p>
41 41
 <table class='authrecord'>
42
-    <caption><?php echo $tablecaption;?></caption>
42
+    <caption><?php echo $tablecaption; ?></caption>
43 43
     <tr>
44
-        <th scope="col"><strong><?php echo _("Timestamp (UTC)");?></strong></th>
45
-        <th scope="col"><strong><?php echo _("Realm");?></strong></th>
46
-        <th scope="col"><strong><?php echo _("MAC Address");?></strong></th>
47
-        <th scope="col"><strong><?php echo _("Chargeable-User-Identity");?></strong></th>
48
-        <th scope="col"><strong><?php echo _("Result");?></strong></th>
49
-        <th scope="col"><strong><?php echo _("AP Identifier");?></strong></th>
44
+        <th scope="col"><strong><?php echo _("Timestamp (UTC)"); ?></strong></th>
45
+        <th scope="col"><strong><?php echo _("Realm"); ?></strong></th>
46
+        <th scope="col"><strong><?php echo _("MAC Address"); ?></strong></th>
47
+        <th scope="col"><strong><?php echo _("Chargeable-User-Identity"); ?></strong></th>
48
+        <th scope="col"><strong><?php echo _("Result"); ?></strong></th>
49
+        <th scope="col"><strong><?php echo _("AP Identifier"); ?></strong></th>
50 50
     </tr>
51 51
     <?php
52 52
     $userAuthData = $deployment->retrieveStatistics($backlogTime);
53 53
     foreach ($userAuthData as $oneRecord) {
54
-        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail" )."'>"
54
+        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail")."'>"
55 55
                 . "<td>".$oneRecord['activity_time']."</td>"
56 56
                 // $oneRecord['CN'] is a simple string, not an array, so disable Scrutinizer type check here
57 57
                 . "<td>".$oneRecord['realm']."</td>"
Please login to merge, or discard this patch.