GEANT / CAT

core/ProfileSilverbullet.php

Doc Comments +3 added lines

@@ -52,6 +52,9 @@
      */
     const PRODUCTNAME = "Managed IdP";
 
+    /**
+     * @param integer $length
+     */
     public static function random_str(
     $length, $keyspace = '23456789abcdefghijkmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'
     ) {

web/lib/admin/view/html/Table.php

Doc Comments +1 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
     
     /**
      * 
-     * @return number
+     * @return integer
      */
     public function size(){
         return count($this->rows);
@@ -53,7 +53,6 @@ 
     
     /**
      * 
-     * @param array $row
      */
     public function addRowArray($cells){
         $this->addRow(new Row($cells));

tests/unit/web/lib/admin/view/InstitutionPageBuilderTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      * @param unknown $input
      * @param unknown $owner
      * @throws Exception
-     * @return mixed
+     * @return MockInstitution
      */
     private function valid_IdP($input, $owner){
         if ($input == 1){

web/admin/inc/manageAdmins.inc.php

Switch Indentation +8 added lines, -8 removed lines

@@ -97,14 +97,14 @@
         case "SUCCESS":
             $cryptText = "";
             switch ($_GET['transportsecurity']) {
-            case "ENCRYPTED":
-                $cryptText = _("and <b>encrypted</b> to the mail domain");
-                break;
-            case "CLEAR":
-                $cryptText = _("but <b>in clear text</b> to the mail domain");
-                break;
-            default:
-                throw new Exception("Error: unknown encryption status of invitation!?!");
+                case "ENCRYPTED":
+                    $cryptText = _("and <b>encrypted</b> to the mail domain");
+                    break;
+                case "CLEAR":
+                    $cryptText = _("but <b>in clear text</b> to the mail domain");
+                    break;
+                default:
+                    throw new Exception("Error: unknown encryption status of invitation!?!");
             }
             echo $uiElements->boxRemark(sprintf(_("The invitation email was sent successfully %s."), $cryptText), _("The invitation email was sent."));
             break;

core/diag/RADIUSTests.php

Doc Comments +11 added lines

@@ -478,6 +478,9 @@ 
         return $cmdline;
     }
 
+    /**
+     * @param string $tmpDir
+     */
     private function thoroughChainChecks(&$testresults, &$intermOdditiesCAT, $tmpDir, $servercert, $eapIntermediates, $eapIntermediateCRLs) {
 
         // collect CA certificates, both the incoming EAP chain and from CAT config
@@ -636,6 +639,14 @@ 
         }
     }
 
+    /**
+     * @param string $tmpDir
+     * @param integer $probeindex
+     * @param string $innerUser
+     * @param string $password
+     * @param boolean $opnameCheck
+     * @param boolean $frag
+     */
     private function executeEapolTest($tmpDir, $probeindex, $eaptype, $innerUser, $password, $opnameCheck, $frag) {
         $finalInner = $innerUser;
         $finalOuter = $this->outerUsernameForChecks;

core/diag/Telepath.php

Doc Comments +3 added lines

@@ -120,6 +120,9 @@
         return Telepath::STATUS_GOOD;
     }
 
+    /**
+     * @param string $homeFlr
+     */
     private function checkNROFlow($visitedFlr, $homeFlr) {
         // TODO: this is a stub, need eduroam OT API to query the current server status
         // APIQueryNRODirect($visitedFlr, $homeFlr);

web/lib/admin/domain/SilverbulletInvitation.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     
     /**
      * 
-     * @param $silverbulletUser SilverbulletUser
+     * @param SilverbulletUser|null $silverbulletUser SilverbulletUser
      */
     public function __construct($silverbulletUser) {
         parent::__construct(self::TABLE, self::TYPE_INST);

web/lib/admin/OptionDisplay.php

Doc Comments +1 added lines, -1 removed lines

@@ -230,7 +230,7 @@
      * @param int $rowid the HTML field base name of the option to be displayed
      * @param string $optionName the name of the option to display
      * @param string $optionValue the value of the option to display
-     * @param mixed $optionLang the language of the option to display
+     * @param null|string $optionLang the language of the option to display
      * @param int $locationIndex which n of m locations is this, in case we are displaying a coordinate
      * @param int $allLocationCount how many locations in total exist, in case we are displaying a coordinate
      * @return string HTML code

web/lib/admin/UIElements.php

Doc Comments +11 added lines, -4 removed lines

@@ -120,6 +120,9 @@ 
         return $find[0];
     }
 
+    /**
+     * @param string $input
+     */
     public function tooltip($input) {
         $descriptions = [];
         if (count(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) > 0) {
@@ -256,6 +259,10 @@ 
         return $number . " B";
     }
 
+    /**
+     * @param string $ref
+     * @param boolean $checkpublic
+     */
     public static function getBlobFromDB($ref, $checkpublic) {
         $validator = new \web\lib\common\InputValidation();
         $reference = $validator->databaseReference($ref);
@@ -402,7 +409,7 @@ 
      * @param string $text the text to display
      * @param string $caption the caption to display
      * @param bool $omittabletags the output usually has tr/td table tags, this option suppresses them
-     * @return type
+     * @return string
      */
     public function boxOkay(string $text = NULL, string $caption = NULL, bool $omittabletags = FALSE) {
         return $this->boxFlexible(\core\common\Entity::L_OK, $text, $caption, $omittabletags);
@@ -414,7 +421,7 @@ 
      * @param string $text the text to display
      * @param string $caption the caption to display
      * @param bool $omittabletags the output usually has tr/td table tags, this option suppresses them
-     * @return type
+     * @return string
      */
     public function boxRemark(string $text = NULL, string $caption = NULL, bool $omittabletags = FALSE) {
         return $this->boxFlexible(\core\common\Entity::L_REMARK, $text, $caption, $omittabletags);
@@ -426,7 +433,7 @@ 
      * @param string $text the text to display
      * @param string $caption the caption to display
      * @param bool $omittabletags the output usually has tr/td table tags, this option suppresses them
-     * @return type
+     * @return string
      */
     public function boxWarning(string $text = NULL, string $caption = NULL, bool $omittabletags = FALSE) {
         return $this->boxFlexible(\core\common\Entity::L_WARN, $text, $caption, $omittabletags);
@@ -438,7 +445,7 @@ 
      * @param string $text the text to display
      * @param string $caption the caption to display
      * @param bool $omittabletags the output usually has tr/td table tags, this option suppresses them
-     * @return type
+     * @return string
      */
     public function boxError(string $text = NULL, string $caption = NULL, bool $omittabletags = FALSE) {
         return $this->boxFlexible(\core\common\Entity::L_ERROR, $text, $caption, $omittabletags);