Passed
Push — release_2_1 ( 584353...81e271 )
by Tomasz
27:15
created
core/Federation.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
                 } else { // this device has stats, but doesn't exist in current config. We don't even know its display name, so display its raw representation
104 104
                     $displayName = sprintf(_("(discontinued) %s"), $queryResult->dev_id);
105 105
                 }
106
-                if (! isset($dataArray[$inst_id])) {
106
+                if (!isset($dataArray[$inst_id])) {
107 107
                     $dataArray[$inst_id] = [];
108 108
                 }
109 109
             }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
                 $dataArray[$inst_id][$displayName] = ["ADMIN" => $queryResult->dl_admin, "SILVERBULLET" => $queryResult->dl_sb, "USER" => $queryResult->dl_user];
112 112
             } elseif ($detail === 'PROFILES') {
113 113
                 $profile_id = $queryResult->profile_id;
114
-                if (! isset($dataArray[$inst_id][$profile_id])) {
114
+                if (!isset($dataArray[$inst_id][$profile_id])) {
115 115
                     $dataArray[$inst_id][$profile_id] = [];
116 116
                 }
117 117
                 $dataArray[$inst_id][$profile_id][$displayName] = ["ADMIN" => $queryResult->dl_admin, "SILVERBULLET" => $queryResult->dl_sb, "USER" => $queryResult->dl_user];
@@ -160,20 +160,20 @@  discard block
 block discarded – undo
160 160
                     if ($device == "TOTAL") {
161 161
                         continue;
162 162
                     }
163
-                    $retstring .= "<tr><td>$device</td><td>" . $numbers['ADMIN'] . "</td><td>" . $numbers['SILVERBULLET'] . "</td><td>" . $numbers['USER'] . "</td></tr>";
163
+                    $retstring .= "<tr><td>$device</td><td>".$numbers['ADMIN']."</td><td>".$numbers['SILVERBULLET']."</td><td>".$numbers['USER']."</td></tr>";
164 164
                 }
165
-                $retstring .= "<tr><td><strong>TOTAL</strong></td><td><strong>" . $data['TOTAL']['ADMIN'] . "</strong></td><td><strong>" . $data['TOTAL']['SILVERBULLET'] . "</strong></td><td><strong>" . $data['TOTAL']['USER'] . "</strong></td></tr>";
165
+                $retstring .= "<tr><td><strong>TOTAL</strong></td><td><strong>".$data['TOTAL']['ADMIN']."</strong></td><td><strong>".$data['TOTAL']['SILVERBULLET']."</strong></td><td><strong>".$data['TOTAL']['USER']."</strong></td></tr>";
166 166
                 break;
167 167
             case "XML":
168 168
                 // the calls to date() operate on current date, so there is no chance for a FALSE to be returned. Silencing scrutinizer.
169
-                $retstring .= "<federation id='$this->tld' ts='" . /** @scrutinizer ignore-type */ date("Y-m-d") . "T" . /** @scrutinizer ignore-type */ date("H:i:s") . "'>\n";
169
+                $retstring .= "<federation id='$this->tld' ts='"./** @scrutinizer ignore-type */ date("Y-m-d")."T"./** @scrutinizer ignore-type */ date("H:i:s")."'>\n";
170 170
                 foreach ($data as $device => $numbers) {
171 171
                     if ($device == "TOTAL") {
172 172
                         continue;
173 173
                     }
174
-                    $retstring .= "  <device name='" . $device . "'>\n    <downloads group='admin'>" . $numbers['ADMIN'] . "</downloads>\n    <downloads group='managed_idp'>" . $numbers['SILVERBULLET'] . "</downloads>\n    <downloads group='user'>" . $numbers['USER'] . "</downloads>\n  </device>";
174
+                    $retstring .= "  <device name='".$device."'>\n    <downloads group='admin'>".$numbers['ADMIN']."</downloads>\n    <downloads group='managed_idp'>".$numbers['SILVERBULLET']."</downloads>\n    <downloads group='user'>".$numbers['USER']."</downloads>\n  </device>";
175 175
                 }
176
-                $retstring .= "<total>\n  <downloads group='admin'>" . $data['TOTAL']['ADMIN'] . "</downloads>\n  <downloads group='managed_idp'>" . $data['TOTAL']['SILVERBULLET'] . "</downloads>\n  <downloads group='user'>" . $data['TOTAL']['USER'] . "</downloads>\n</total>\n";
176
+                $retstring .= "<total>\n  <downloads group='admin'>".$data['TOTAL']['ADMIN']."</downloads>\n  <downloads group='managed_idp'>".$data['TOTAL']['SILVERBULLET']."</downloads>\n  <downloads group='user'>".$data['TOTAL']['USER']."</downloads>\n</total>\n";
177 177
                 $retstring .= "</federation>";
178 178
                 break;
179 179
             case "array":
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
         $identifier = $this->databaseHandle->lastID();
274 274
 
275 275
         if ($identifier == 0 || !$this->loggerInstance->writeAudit($ownerId, "NEW", "Organisation $identifier")) {
276
-            $text = "<p>Could not create a new " . common\Entity::$nomenclature_participant . "!</p>";
276
+            $text = "<p>Could not create a new ".common\Entity::$nomenclature_participant."!</p>";
277 277
             echo $text;
278 278
             throw new Exception($text);
279 279
         }
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
             return; // no update to fetch
418 418
         }
419 419
         $certDetails = openssl_x509_parse($entryInQuestion['CERT']);
420
-        $expiry = "20" . $certDetails['validTo'][0] . $certDetails['validTo'][1] . "-" . $certDetails['validTo'][2] . $certDetails['validTo'][3] . "-" . $certDetails['validTo'][4] . $certDetails['validTo'][5];
420
+        $expiry = "20".$certDetails['validTo'][0].$certDetails['validTo'][1]."-".$certDetails['validTo'][2].$certDetails['validTo'][3]."-".$certDetails['validTo'][4].$certDetails['validTo'][5];
421 421
         openssl_x509_export($entryInQuestion['CERT'], $pem);
422 422
         $updateQuery = "UPDATE federation_servercerts SET status = 'ISSUED', certificate = ?, expiry = ? WHERE ca_name = 'eduPKI' AND request_serial = ?";
423 423
         $this->databaseHandle->exec($updateQuery, "ssi", $pem, $expiry, $reqSerial);
Please login to merge, or discard this patch.