Passed
Push — master ( 24687e...3d1824 )
by Tomasz
03:18
created
devices/linux/Device_Linux.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
             $outString .= "# save user certificate\n";
66 66
             $outString .= 'echo "';
67 67
             $outString .= base64_encode($this->clientCert["certdata"])
68
-               . '" | base64 -d ' . " > \$HOME/$this->localDir/user.p12\n";
68
+                . '" | base64 -d ' . " > \$HOME/$this->localDir/user.p12\n";
69 69
         }
70 70
         if ($this->selectedEap == \core\common\EAP::EAPTYPE_TLS || $this->selectedEap == \core\common\EAP::EAPTYPE_SILVERBULLET) {
71 71
             $outString .= $this->printP12Dialog();
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -184,8 +184,8 @@  discard block
 block discarded – undo
184 184
 # will be the default value prompted to the user
185 185
 
186 186
     private function printFunctions() {
187
-        $url = (isset($this->attributes['support:url'][0]) && $this->attributes['support:url'][0] ) ? $this->attributes['support:url'][0] : $this->support_url_substitute;
188
-        $support = (isset($this->attributes['support:email'][0]) && $this->attributes['support:email'][0] ) ? $this->attributes['support:email'][0] : $this->support_email_substitute;
187
+        $url = (isset($this->attributes['support:url'][0]) && $this->attributes['support:url'][0]) ? $this->attributes['support:url'][0] : $this->support_url_substitute;
188
+        $support = (isset($this->attributes['support:email'][0]) && $this->attributes['support:email'][0]) ? $this->attributes['support:email'][0] : $this->support_email_substitute;
189 189
         $out = '
190 190
 my_name=$0
191 191
 
@@ -480,7 +480,7 @@  discard block
 block discarded – undo
480 480
 ';
481 481
 }
482 482
     $cert_prompt = $this->selectedEap == \core\common\EAP::EAPTYPE_TLS ? _("enter the password for the certificate file") : _("enter your import password");
483
-    $out .=  '   cert=$HOME/' . $this->localDir . '/user.p12
483
+    $out .= '   cert=$HOME/' . $this->localDir . '/user.p12
484 484
 
485 485
     PASSWORD=""
486 486
     prompt="' . $cert_prompt . '"
Please login to merge, or discard this patch.
devices/redirect_dev/Device_RedirectDev.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -11,15 +11,15 @@
 block discarded – undo
11 11
 namespace devices\redirect_dev;
12 12
 
13 13
 class Device_RedirectDev extends \core\DeviceConfig {
14
-   /**
15
-    * Constructs a Device object.
16
-    *
17
-    * @final not to be redefined
18
-    */
14
+    /**
15
+     * Constructs a Device object.
16
+     *
17
+     * @final not to be redefined
18
+     */
19 19
     final public function __construct() {
20 20
         parent::__construct();
21
-      $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_NONE]);
22
-      $this->loggerInstance->debug(4,"RedirectEx called");
21
+        $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_NONE]);
22
+        $this->loggerInstance->debug(4,"RedirectEx called");
23 23
     }
24 24
     public function writeDeviceInfo() {
25 25
         $out = "<p>";
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     final public function __construct() {
20 20
         parent::__construct();
21 21
       $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_NONE]);
22
-      $this->loggerInstance->debug(4,"RedirectEx called");
22
+      $this->loggerInstance->debug(4, "RedirectEx called");
23 23
     }
24 24
     public function writeDeviceInfo() {
25 25
         $out = "<p>";
Please login to merge, or discard this patch.
web/lib/admin/PageDecoration.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -206,8 +206,7 @@
 block discarded – undo
206 206
             $cutoffPosition = strrpos($_SERVER['PHP_SELF'], "accountstatus/");
207 207
         } elseif (strrpos($_SERVER['PHP_SELF'], "diag/")) {
208 208
             $cutoffPosition = strrpos($_SERVER['PHP_SELF'], "diag/");
209
-        }
210
-            else {
209
+        } else {
211 210
             $cutoffPosition = strrpos($_SERVER['PHP_SELF'], "/");
212 211
         }
213 212
 
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
                         <select id='lang' name='lang' onchange='this.form.submit()'>";
66 66
 
67 67
         foreach (CONFIG['LANGUAGES'] as $lang => $value) {
68
-            $retval .= "<option value='$lang' " . (strtoupper($language) == strtoupper($lang) ? "selected" : "" ) . " >" . $value['display'] . "</option> ";
68
+            $retval .= "<option value='$lang' " . (strtoupper($language) == strtoupper($lang) ? "selected" : "") . " >" . $value['display'] . "</option> ";
69 69
         }
70 70
         $retval .= "</select>";
71 71
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
         $retval .= "</form>
78 78
                 </div><!--langselection-->";
79 79
 
80
-        $logoUrl = "//" . $this->validator->hostname($_SERVER['SERVER_NAME']) . substr($_SERVER['PHP_SELF'], 0, (strrpos($_SERVER['PHP_SELF'], "admin/") !== FALSE ? strrpos($_SERVER['PHP_SELF'], "admin/") : strrpos($_SERVER['PHP_SELF'], "/")))."/resources/images/consortium_logo.png";        
80
+        $logoUrl = "//" . $this->validator->hostname($_SERVER['SERVER_NAME']) . substr($_SERVER['PHP_SELF'], 0, (strrpos($_SERVER['PHP_SELF'], "admin/") !== FALSE ? strrpos($_SERVER['PHP_SELF'], "admin/") : strrpos($_SERVER['PHP_SELF'], "/"))) . "/resources/images/consortium_logo.png";        
81 81
         $retval .= "<div class='consortium_logo'>
82 82
                     <img id='test_locate' src='$logoUrl' alt='Consortium Logo'>
83 83
                 </div> <!-- consortium_logo -->
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
         switch ($area) {
120 120
             case "ADMIN-IDP":
121 121
                 $cap1 = CONFIG['APPEARANCE']['productname_long'];
122
-                $cap2 = sprintf(_("Administrator Interface - Identity Provider"),$this->ui->nomenclature_inst);
122
+                $cap2 = sprintf(_("Administrator Interface - Identity Provider"), $this->ui->nomenclature_inst);
123 123
                 $advancedControls = TRUE;
124 124
                 break;
125 125
             case "ADMIN-IDP-USERS":
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
                 break;
140 140
             case "FEDERATION":
141 141
                 $cap1 = CONFIG['APPEARANCE']['productname_long'];
142
-                $cap2 = sprintf(_("Administrator Interface - %s Management"),$this->ui->nomenclature_fed);
142
+                $cap2 = sprintf(_("Administrator Interface - %s Management"), $this->ui->nomenclature_fed);
143 143
                 $advancedControls = TRUE;
144 144
                 break;
145 145
             case "USER":
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         // content from here on will SCROLL instead of being fixed at the top
169 169
         $retval .= "<div class='pagecontent'>"; // closes in footer again
170 170
         $retval .= "<div class='trick'>"; // closes in footer again
171
-        $retval .= "<div id='secondrow' style='border-bottom:5px solid ".CONFIG['APPEARANCE']['colour1']."; min-height:100px;'>
171
+        $retval .= "<div id='secondrow' style='border-bottom:5px solid " . CONFIG['APPEARANCE']['colour1'] . "; min-height:100px;'>
172 172
             <div id='secondarycaptions' style='display:inline-block; float:left'>
173 173
                 <h2>$cap2</h2>
174 174
             </div><!--secondarycaptions-->";
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
             $cutoffPosition = strrpos($_SERVER['PHP_SELF'], "/");
214 214
         }
215 215
 
216
-        $cssUrl = "//" . $this->validator->hostname($_SERVER['SERVER_NAME']) . substr($_SERVER['PHP_SELF'], 0, $cutoffPosition )."/resources/css/cat.css.php";
216
+        $cssUrl = "//" . $this->validator->hostname($_SERVER['SERVER_NAME']) . substr($_SERVER['PHP_SELF'], 0, $cutoffPosition) . "/resources/css/cat.css.php";
217 217
         
218 218
         $retval .= "<link rel='stylesheet' type='text/css' href='$cssUrl' />";
219 219
         $retval .= "<title>" . htmlspecialchars($pagetitle) . "</title>";
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
             $cutoffPosition = strrpos($_SERVER['PHP_SELF'], "/");
242 242
         }
243 243
         
244
-        $logoBase = "//" . $this->validator->hostname($_SERVER['SERVER_NAME']) . substr($_SERVER['PHP_SELF'], 0, $cutoffPosition)."/resources/images";
244
+        $logoBase = "//" . $this->validator->hostname($_SERVER['SERVER_NAME']) . substr($_SERVER['PHP_SELF'], 0, $cutoffPosition) . "/resources/images";
245 245
 
246 246
         return "<span id='logos' style='position:fixed; left:50%;'><img src='$logoBase/dante.png' alt='DANTE' style='height:23px;width:47px'/>
247 247
               <img src='$logoBase/eu.png' alt='EU' style='height:23px;width:27px;border-width:0px;'/></span>
Please login to merge, or discard this patch.
core/diag/RFC6614Tests.php 1 patch
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -246,11 +246,11 @@  discard block
 block discarded – undo
246 246
     }
247 247
 
248 248
         /**
249
-     * This function parses a X.509 cert and returns all certificatePolicies OIDs
250
-     * 
251
-     * @param array $cert (returned from openssl_x509_parse) 
252
-     * @return array of OIDs
253
-     */
249
+         * This function parses a X.509 cert and returns all certificatePolicies OIDs
250
+         * 
251
+         * @param array $cert (returned from openssl_x509_parse) 
252
+         * @return array of OIDs
253
+         */
254 254
     private function propertyCheckPolicy($cert) {
255 255
         $oids = [];
256 256
         if ($cert['extensions']['certificatePolicies']) {
@@ -263,11 +263,11 @@  discard block
 block discarded – undo
263 263
         return $oids;
264 264
     }
265 265
         /**
266
-     * This function parses a X.509 cert and returns the value of $field
267
-     * 
268
-     * @param array $cert (returned from openssl_x509_parse) 
269
-     * @return string value of the issuer field or ''
270
-     */
266
+         * This function parses a X.509 cert and returns the value of $field
267
+         * 
268
+         * @param array $cert (returned from openssl_x509_parse) 
269
+         * @return string value of the issuer field or ''
270
+         */
271 271
     private function getCertificateIssuer($cert) {
272 272
         $issuer = '';
273 273
         foreach ($cert['issuer'] as $key => $val) {
Please login to merge, or discard this patch.
web/lib/admin/http/DefaultContext.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
      *
28 28
      * @param AbstractPage $page
29 29
      */
30
-    public function __construct($page){
30
+    public function __construct($page) {
31 31
         $this->page = $page;
32 32
         $this->session = SessionStorage::getInstance('sb-messages');
33 33
     }
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
      *
37 37
      * @return AbstractPage
38 38
      */
39
-    public function getPage(){
39
+    public function getPage() {
40 40
         return $this->page;
41 41
     }
42 42
     
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      *
46 46
      * @return \web\lib\admin\storage\SessionStorage
47 47
      */
48
-    public function getSession(){
48
+    public function getSession() {
49 49
         return $this->session;
50 50
     }
51 51
     
Please login to merge, or discard this patch.
web/lib/admin/http/AbstractAjaxCommand.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
  * @author Zilvinas Vaira
11 11
  *
12 12
  */
13
-abstract class AbstractAjaxCommand extends AbstractCommand{
13
+abstract class AbstractAjaxCommand extends AbstractCommand {
14 14
     
15 15
     /**
16 16
      *
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
      * @param string $commandToken
24 24
      * @param DefaultContext $context
25 25
      */
26
-    public function __construct($commandToken, $context){
26
+    public function __construct($commandToken, $context) {
27 27
         parent::__construct($commandToken);
28 28
         $this->page = $context->getPage();
29 29
     }
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      * 
33 33
      * @param HtmlElementInterface $element
34 34
      */
35
-    public function publish($element){
35
+    public function publish($element) {
36 36
         $this->page->appendHtmlElement(DefaultAjaxPage::SECTION_RESPONSE, $element);
37 37
     }
38 38
     
Please login to merge, or discard this patch.
web/lib/admin/http/Message.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
      * 
42 42
      * @return string
43 43
      */
44
-    public function getText(){
44
+    public function getText() {
45 45
         return $this->text;
46 46
     }
47 47
     
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
      * @param string $prefix
51 51
      * @return string
52 52
      */
53
-    public function getClass($prefix = ''){
53
+    public function getClass($prefix = '') {
54 54
         return $prefix . '-' . $this->level;
55 55
     }
56 56
 }
Please login to merge, or discard this patch.
web/lib/admin/http/AbstractInvokerCommand.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
  * @author Zilvinas Vaira
8 8
  *
9 9
  */
10
-abstract class AbstractInvokerCommand extends AbstractCommand implements MessageInvokerInterface{
10
+abstract class AbstractInvokerCommand extends AbstractCommand implements MessageInvokerInterface {
11 11
 
12 12
     /**
13 13
      *
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      * {@inheritDoc}
31 31
      * @see \lib\http\MessageInvokerInterface::storeErrorMessage()
32 32
      */
33
-    public function storeErrorMessage($text){
33
+    public function storeErrorMessage($text) {
34 34
         $this->session->add($this->commandToken, new Message($text, Message::ERROR));
35 35
     }
36 36
     
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
      * {@inheritDoc}
40 40
      * @see \lib\http\MessageInvokerInterface::storeInfoMessage()
41 41
      */
42
-    public function storeInfoMessage($text){
42
+    public function storeInfoMessage($text) {
43 43
         $this->session->add($this->commandToken, new Message($text, Message::INFO));
44 44
     }
45 45
     
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
      * {@inheritDoc}
49 49
      * @see \lib\http\MessageInvokerInterface::publishMessages()
50 50
      */
51
-    public function publishMessages($receiver){
51
+    public function publishMessages($receiver) {
52 52
         $messages = $this->session->get($this->commandToken);
53 53
         foreach ($messages as $message) {
54 54
             $receiver->receiveMessage($message);
Please login to merge, or discard this patch.
web/lib/admin/http/SilverbulletAjaxController.php 2 patches
Braces   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,9 +33,9 @@
 block discarded – undo
33 33
     protected function doCreateCommand($commandToken) {
34 34
         if($commandToken == ValidateEmailAddress::COMMAND){
35 35
             return new ValidateEmailAddress($commandToken, $this->context);
36
-        }elseif($commandToken == GetTokenEmailDetails::COMMAND) {
36
+        } elseif($commandToken == GetTokenEmailDetails::COMMAND) {
37 37
             return new GetTokenEmailDetails($commandToken, $this->context);
38
-        }else {
38
+        } else {
39 39
             return new DefaultCommand($commandToken);
40 40
         }
41 41
     }
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
  * @author Zilvinas Vaira
9 9
  *
10 10
  */
11
-class SilverbulletAjaxController extends AbstractController{
11
+class SilverbulletAjaxController extends AbstractController {
12 12
 
13 13
     /**
14 14
      * 
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      *
22 22
      * @param DefaultContext $context Requires default context object.
23 23
      */
24
-    public function __construct($context){
24
+    public function __construct($context) {
25 25
         $this->context = $context;
26 26
     }
27 27
     
@@ -31,11 +31,11 @@  discard block
 block discarded – undo
31 31
      * @see \web\lib\admin\http\AbstractController::doCreateCommand()
32 32
      */
33 33
     protected function doCreateCommand($commandToken) {
34
-        if($commandToken == ValidateEmailAddress::COMMAND){
34
+        if ($commandToken == ValidateEmailAddress::COMMAND) {
35 35
             return new ValidateEmailAddress($commandToken, $this->context);
36
-        }elseif($commandToken == GetTokenEmailDetails::COMMAND) {
36
+        }elseif ($commandToken == GetTokenEmailDetails::COMMAND) {
37 37
             return new GetTokenEmailDetails($commandToken, $this->context);
38
-        }else {
38
+        } else {
39 39
             return new DefaultCommand($commandToken);
40 40
         }
41 41
     }
@@ -45,9 +45,9 @@  discard block
 block discarded – undo
45 45
      * {@inheritDoc}
46 46
      * @see \web\lib\admin\http\AbstractController::parseRequest()
47 47
      */
48
-    public function parseRequest(){
48
+    public function parseRequest() {
49 49
         $commandToken = '';
50
-        if(isset($_REQUEST[SilverbulletAjaxController::COMMAND])){
50
+        if (isset($_REQUEST[SilverbulletAjaxController::COMMAND])) {
51 51
             $commandToken = $_REQUEST[SilverbulletAjaxController::COMMAND];
52 52
         }
53 53
         $currentCommand = $this->createCommand($commandToken);
Please login to merge, or discard this patch.