Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 28 | class Psr4AutoloaderTest extends \PHPUnit\Framework\TestCase |
||
| 29 | { |
||
| 30 | protected $loader; |
||
| 31 | |||
| 32 | protected function setUp() |
||
| 33 | { |
||
| 34 | $this->loader = new MockPsr4Autoloader; |
||
| 35 | |||
| 36 | $this->loader->setFiles(array( |
||
| 37 | '/vendor/foo.bar/src/ClassName.php', |
||
| 38 | '/vendor/foo.bar/src/DoomClassName.php', |
||
| 39 | '/vendor/foo.bar/tests/ClassNameTest.php', |
||
| 40 | '/vendor/foo.bardoom/src/ClassName.php', |
||
| 41 | '/vendor/foo.bar.baz.dib/src/ClassName.php', |
||
| 42 | '/vendor/foo.bar.baz.dib.zim.gir/src/ClassName.php', |
||
| 43 | )); |
||
| 44 | |||
| 45 | $this->loader->addNamespace( |
||
| 46 | 'Foo\Bar', |
||
| 47 | '/vendor/foo.bar/src' |
||
| 48 | ); |
||
| 49 | |||
| 50 | $this->loader->addNamespace( |
||
| 51 | 'Foo\Bar', |
||
| 52 | '/vendor/foo.bar/tests' |
||
| 53 | ); |
||
| 54 | |||
| 55 | $this->loader->addNamespace( |
||
| 56 | 'Foo\BarDoom', |
||
| 57 | '/vendor/foo.bardoom/src' |
||
| 58 | ); |
||
| 59 | |||
| 60 | $this->loader->addNamespace( |
||
| 61 | 'Foo\Bar\Baz\Dib', |
||
| 62 | '/vendor/foo.bar.baz.dib/src' |
||
| 63 | ); |
||
| 64 | |||
| 65 | $this->loader->addNamespace( |
||
| 66 | 'Foo\Bar\Baz\Dib\Zim\Gir', |
||
| 67 | '/vendor/foo.bar.baz.dib.zim.gir/src' |
||
| 68 | ); |
||
| 69 | } |
||
| 70 | |||
| 71 | public function testExistingFile() |
||
| 72 | { |
||
| 73 | $actual = $this->loader->loadClass('Foo\Bar\ClassName'); |
||
| 74 | $expect = '/vendor/foo.bar/src/ClassName.php'; |
||
| 75 | $this->assertSame($expect, $actual); |
||
| 76 | |||
| 77 | $actual = $this->loader->loadClass('Foo\Bar\ClassNameTest'); |
||
| 78 | $expect = '/vendor/foo.bar/tests/ClassNameTest.php'; |
||
| 79 | $this->assertSame($expect, $actual); |
||
| 80 | } |
||
| 81 | |||
| 82 | public function testMissingFile() |
||
| 86 | } |
||
| 87 | |||
| 88 | public function testDeepFile() |
||
| 93 | } |
||
| 94 | |||
| 95 | public function testConfusion() |
||
| 104 | } |
||
| 105 | } |