View GitHub Repository CAT

Schedule Inspection
Subscribe
Passed
Push — master ( 14daf1...87f465 )
by Tomasz
05:44
created
Status
Category
Toggle Patches
web/basic.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -32,4 +32,4 @@
 
 block discarded – undo
32 32
33 33
34 34 
 // and now, serve actual data
35 
-include("skins/".$skinObject->skin."/basic.php");
35 
+include("skins/" . $skinObject->skin . "/basic.php");
Please login to merge, or discard this patch.
web/skins/classic/basic.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -141,7 +141,7 @@  discard block
 
 block discarded – undo
141 141 
     public function listIdPs() {
142 142 
         $instList = $this->orderIdentityProviders($this->country->tld);
143 143 
         $out = '';
144 
-        $out .= sprintf(_("Select your %s"), $this->nomenclature_inst );
144 
+        $out .= sprintf(_("Select your %s"), $this->nomenclature_inst);
145 145 
         $out .= '<select name="idp" onchange="submit_form(this)">';
146 146 
         if (!empty($instList)) {
147 147 
             if (!isset($this->idp)) {
 
@@ -235,7 +235,7 @@  discard block
 
 block discarded – undo
235 235 
                 }
236 236 
             }
237 237 
             $out .= '>' . $disp . '</option>';
238 
-            $deviceRedirects .= 'redirects[' . $iterator . '] = ' . ( $oneDevice['redirect'] ? 1 : 0 ) . ';';
238 
+            $deviceRedirects .= 'redirects[' . $iterator . '] = ' . ($oneDevice['redirect'] ? 1 : 0) . ';';
239 239 
             $iterator++;
240 240 
         }
241 241 
         $out .= '</select>';
 
@@ -278,9 +278,9 @@  discard block
 
 block discarded – undo
278 278 
         }
279 279 
         if ($out !== '') {
280 280 
             $out1 .= '<div class="user_info">';
281 
-            $out1 .=  sprintf(_("If you encounter problems you should ask for help at your %s"), $this->nomenclature_inst);
282 
-            $out1 .=  $out;
283 
-            $out1 .=  "</div>\n";
281 
+            $out1 .= sprintf(_("If you encounter problems you should ask for help at your %s"), $this->nomenclature_inst);
282 
+            $out1 .= $out;
283 
+            $out1 .= "</div>\n";
284 284 
         }
285 285 
         return($out1);
286 286 
     }
 
@@ -441,7 +441,7 @@  discard block
 
 block discarded – undo
441 441 
         </script>
442 442 
     </head>
443 443 
     <body style="">
444 
-        <?php print '<div id="motd">' . ( isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp' ) . '</div>'; ?>
444 
+        <?php print '<div id="motd">' . (isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp') . '</div>'; ?>
445 445 
         <form name="my_form" method="POST" action="<?php echo $_SERVER['SCRIPT_NAME'] ?>" accept-charset='UTF-8'>
446 446 
             <img src="<?php echo $skinObject->findResourceUrl("IMAGES", "consortium_logo.png"); ?>" style="width: 20%; padding-right:20px; padding-top:0px; float:right" alt="logo" />
447 447 
             <?php
Please login to merge, or discard this patch.
core/SanityTests.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch 
@@ -539,47 +539,47 @@
 
 block discarded – undo
539 539 
         ["SETTING" => CONFIG['APPEARANCE']['from-mail'],
540 540 
             "DEFVALUE" => "[email protected]",
541 541 
             "COMPLAINTSTRING" => "APPEARANCE/from-mail ",
542 
-            "REQUIRED" => FALSE,],
542 
+            "REQUIRED" => FALSE, ],
543 543 
         ["SETTING" => CONFIG['APPEARANCE']['support-contact']['url'],
544 544 
             "DEFVALUE" => "[email protected]?body=Only%20English%20language%20please!",
545 545 
             "COMPLAINTSTRING" => "APPEARANCE/support-contact/url ",
546 
-            "REQUIRED" => FALSE,],
546 
+            "REQUIRED" => FALSE, ],
547 547 
         ["SETTING" => CONFIG['APPEARANCE']['support-contact']['display'],
548 548 
             "DEFVALUE" => "[email protected]",
549 549 
             "COMPLAINTSTRING" => "APPEARANCE/support-contact/display ",
550 
-            "REQUIRED" => FALSE,],
550 
+            "REQUIRED" => FALSE, ],
551 551 
         ["SETTING" => CONFIG['APPEARANCE']['support-contact']['developer-mail'],
552 552 
             "DEFVALUE" => "[email protected]",
553 553 
             "COMPLAINTSTRING" => "APPEARANCE/support-contact/mail ",
554 
-            "REQUIRED" => FALSE,],
554 
+            "REQUIRED" => FALSE, ],
555 555 
         ["SETTING" => CONFIG['APPEARANCE']['abuse-mail'],
556 556 
             "DEFVALUE" => "[email protected]",
557 557 
             "COMPLAINTSTRING" => "APPEARANCE/abuse-mail ",
558 
-            "REQUIRED" => FALSE,],
558 
+            "REQUIRED" => FALSE, ],
559 559 
         ["SETTING" => CONFIG['APPEARANCE']['MOTD'],
560 560 
             "DEFVALUE" => "Release Candidate. All bugs to be shot on sight!",
561 561 
             "COMPLAINTSTRING" => "APPEARANCE/MOTD ",
562 
-            "REQUIRED" => FALSE,],
562 
+            "REQUIRED" => FALSE, ],
563 563 
         ["SETTING" => CONFIG['APPEARANCE']['webcert_CRLDP'],
564 564 
             "DEFVALUE" => ['list', 'of', 'CRL', 'pointers'],
565 565 
             "COMPLAINTSTRING" => "APPEARANCE/webcert_CRLDP ",
566 
-            "REQUIRED" => TRUE,],
566 
+            "REQUIRED" => TRUE, ],
567 567 
         ["SETTING" => CONFIG['APPEARANCE']['webcert_OCSP'],
568 568 
             "DEFVALUE" => ['list', 'of', 'OCSP', 'pointers'],
569 569 
             "COMPLAINTSTRING" => "APPEARANCE/webcert_OCSP ",
570 
-            "REQUIRED" => TRUE,],
570 
+            "REQUIRED" => TRUE, ],
571 571 
         ["SETTING" => CONFIG['DB']['INST']['host'],
572 572 
             "DEFVALUE" => "db.host.example",
573 573 
             "COMPLAINTSTRING" => "DB/INST ",
574 
-            "REQUIRED" => TRUE,],
574 
+            "REQUIRED" => TRUE, ],
575 575 
         ["SETTING" => CONFIG['DB']['INST']['host'],
576 576 
             "DEFVALUE" => "db.host.example",
577 577 
             "COMPLAINTSTRING" => "DB/USER ",
578 
-            "REQUIRED" => TRUE,],
578 
+            "REQUIRED" => TRUE, ],
579 579 
         ["SETTING" => CONFIG['DB']['EXTERNAL']['host'],
580 580 
             "DEFVALUE" => "customerdb.otherhost.example",
581 581 
             "COMPLAINTSTRING" => "DB/EXTERNAL ",
582 
-            "REQUIRED" => FALSE,],
582 
+            "REQUIRED" => FALSE, ],
583 583 
     ];
584 584
585 585 
     /**
Please login to merge, or discard this patch.
web/admin/inc/displayQRcode.inc.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -28,6 +28,6 @@
 
 block discarded – undo
28 28 
 $invitationObject = new core\SilverbulletInvitation($validator->token(filter_input(INPUT_POST, 'token')));
29 29 
 header("Content-Type:text/html;charset=utf-8");
30 30 
 ?>
31 
-<h1 style='text-align:center;'><?php echo _("Invitation Token QR Code");?></h1>
32 
-<img style='float:none' src='data:image/png;base64,<?php echo base64_encode($uiElements->pngInjectConsortiumLogo(\QRcode::png($invitationObject->link(), FALSE, QR_ECLEVEL_Q, 11), 11));?>'/>
33 
-<p>(<a href='<?php echo $link;?>'><?php echo $link;?>)</a></p>
31 
+<h1 style='text-align:center;'><?php echo _("Invitation Token QR Code"); ?></h1>
32 
+<img style='float:none' src='data:image/png;base64,<?php echo base64_encode($uiElements->pngInjectConsortiumLogo(\QRcode::png($invitationObject->link(), FALSE, QR_ECLEVEL_Q, 11), 11)); ?>'/>
33 
+<p>(<a href='<?php echo $link; ?>'><?php echo $link; ?>)</a></p>
Please login to merge, or discard this patch.
web/accountstatus/accountstatus.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36 
         // it can be VALID (exists and not redeemed, EXPIRED, REDEEMED or INVALID (non existent)
37 37 
         $invitationObject = new core\SilverbulletInvitation($cleanToken);
38 38 
     }
39 
-} elseif (isset($_SERVER['SSL_CLIENT_SAN_Email']) || isset($_SERVER['SSL_CLIENT_SAN_Email_0']) ) {
39 
+} elseif (isset($_SERVER['SSL_CLIENT_SAN_Email']) || isset($_SERVER['SSL_CLIENT_SAN_Email_0'])) {
40 40 
     // maybe the user authenticated with his client cert? Then pick any of his
41 41 
     // tokens to go on
42 42 
     $certname = $_SERVER['SSL_CLIENT_SAN_Email'] ?? $_SERVER['SSL_CLIENT_SAN_Email_0'];
 
@@ -60,7 +60,7 @@  discard block
 
 block discarded – undo
60 60
61 61 
 $statusInfo = ["token" => $cleanToken,
62 62 
     "invitation_object" => $invitationObject,
63 
-    "OS" => $Gui->operatingSystem,];
63 
+    "OS" => $Gui->operatingSystem, ];
64 64
65 65 
 if ($profile !== NULL) {
66 66 
     $attributes = $Gui->profileAttributes($profile->identifier);
Please login to merge, or discard this patch.
core/ProfileSilverbullet.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -455,7 +455,7 @@
 
 block discarded – undo
455 455 
                 $indexStatement = "$certstatus\t$expiryIndexTxt\t" . ($certstatus == "R" ? "$nowIndexTxt,unspecified" : "") . "\t$serialHex\tunknown\t/O=" . CONFIG_CONFASSISTANT['CONSORTIUM']['name'] . "/OU=$federation/CN=$cn/emailAddress=$cn\n";
456 456 
                 $logHandle->debug(4, "index.txt contents-to-be: $indexStatement");
457 457 
                 if (!file_put_contents($tempdir . "/index.txt", $indexStatement)) {
458 
-                $logHandle->debug(1,"Unable to write openssl index.txt file for revocation handling!");
458 
+                $logHandle->debug(1, "Unable to write openssl index.txt file for revocation handling!");
459 459 
                 }
460 460 
                 // index.txt.attr is dull but needs to exist
461 461 
                 file_put_contents($tempdir . "/index.txt.attr", "unique_subject = yes\n");
Please login to merge, or discard this patch.
core/SilverbulletInvitation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -133,7 +133,7 @@
 
 block discarded – undo
133 133 
             $certificatesNumber = ($certificatesResult ? $certificatesResult->num_rows : 0);
134 134 
             $this->loggerInstance->debug(5, "At token validation level, " . $certificatesNumber . " certificates exist.\n");
135 135 
             $this->associatedCertificates = \core\ProfileSilverbullet::enumerateCertDetails(/** @scrutinizer ignore-type */ $certificatesResult);
136 
-            $this->activationsRemaining = (int)$this->activationsTotal - (int)$certificatesNumber;
136 
+            $this->activationsRemaining = (int) $this->activationsTotal - (int) $certificatesNumber;
137 137 
             switch ($certificatesNumber) {
138 138 
                 case 0:
139 139 
                     // find out if it has expired
Please login to merge, or discard this patch.