Test Failed
Push — master ( 8f50f2...7d6c04 )
by Tomasz
11:11
created
web/skins/modern/user/cat_info.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
  * the receiving end to strip this marker and not add the title by itself.
32 32
  *
33 33
  */
34
-require_once dirname(dirname(dirname((dirname(dirname(__FILE__)))))) . "/config/_config.php";
34
+require_once dirname(dirname(dirname((dirname(dirname(__FILE__))))))."/config/_config.php";
35 35
 
36 36
 $Gui = new \web\lib\user\Gui();
37 37
 
@@ -41,46 +41,46 @@  discard block
 block discarded – undo
41 41
 $subpage = $_REQUEST['subpage'];
42 42
 switch ($page) {
43 43
     case 'about':
44
-        include_once dirname(dirname(dirname(dirname(__FILE__)))) . "/user/about_cat.inc.php";
44
+        include_once dirname(dirname(dirname(dirname(__FILE__))))."/user/about_cat.inc.php";
45 45
         $out = "<div class='padding'>$out</div>";
46 46
         break;
47 47
     case 'tou':
48
-        include_once dirname(dirname(dirname(dirname(__FILE__)))) . "/user/tou.inc.php";
48
+        include_once dirname(dirname(dirname(dirname(__FILE__))))."/user/tou.inc.php";
49 49
         $out = "no_title<div>
50 50
            <h1>
51
-         " . $Tou['title'] . "
51
+         " . $Tou['title']."
52 52
     </h1>
53
-<div id='tou_1'>" . $Tou['subtitle'] .
54
-               '<div style="direction:ltr">' . $Tou['short'] . "</div>
53
+<div id='tou_1'>" . $Tou['subtitle'].
54
+               '<div style="direction:ltr">'.$Tou['short']."</div>
55 55
 </div>
56 56
 <div id='all_tou_link'><a href='javascript:showTOU()'>Click here to see the full terms</a></div>
57 57
 <div id='tou_2' style='display:none; padding-top:20px; direction:ltr'>" .
58
-                $Tou['full'] . "
58
+                $Tou['full']."
59 59
 </div>
60 60
 </div>
61 61
 ";
62 62
         break;
63 63
     case 'help':
64
-        include_once dirname(dirname(dirname(dirname(__FILE__)))) . "/user/faq.inc.php";
64
+        include_once dirname(dirname(dirname(dirname(__FILE__))))."/user/faq.inc.php";
65 65
         switch ($subpage) {
66 66
             case 'contact':
67 67
             case 'idp_not_listed':
68 68
             case 'device_not_listed':
69 69
             case 'what_is_eduroam':
70
-                $out = "no_title<div><h1>" . _("Help") . "</h1>";
70
+                $out = "no_title<div><h1>"._("Help")."</h1>";
71 71
                 foreach ($Faq as $faqItem) {
72 72
                     if (!empty($faqItem['id']) && $faqItem['id'] == $subpage) {
73
-                        $out .= "<div><h3>" . $faqItem['title'] . "</h3>\n";
74
-                        $out .= "" . $faqItem['text'] . "</div>\n";
73
+                        $out .= "<div><h3>".$faqItem['title']."</h3>\n";
74
+                        $out .= "".$faqItem['text']."</div>\n";
75 75
                     }
76 76
                 }
77 77
                 $out .= "</div>";
78 78
                 break;
79 79
             case 'faq':
80
-                $out = "no_title<div><h1>" . _("Frequently Asked Questions") . "</h1>";
80
+                $out = "no_title<div><h1>"._("Frequently Asked Questions")."</h1>";
81 81
                 foreach ($Faq as $faqItem) {
82
-                    $out .= "<div><h3>" . $faqItem['title'] . "</h3>\n";
83
-                    $out .= "" . $faqItem['text'] . "</div>\n";
82
+                    $out .= "<div><h3>".$faqItem['title']."</h3>\n";
83
+                    $out .= "".$faqItem['text']."</div>\n";
84 84
                 }
85 85
                 $out .= "</div>";
86 86
                 break;
@@ -104,15 +104,15 @@  discard block
 block discarded – undo
104 104
                     $rn = uniqid();
105 105
                     $_SESSION['remindIdP'] = $rn;
106 106
                     $out .= "<input type='hidden' id='remindIdPs' value='$rn'>";
107
-                    $out .= "<p><button type='button' onclick='goAdmin(); return(false);'>" . _("Login") . "</button>";
108
-                    $out .= "<br/><br/><p>" . _("Did you forget with which Identity Provider you logged in to the system? We can try to find out if you specify the email address with which you were invited to the system in the box below. This may not work if you were invited from a third-party website via the AdminAPI.") . "</p>";
109
-                    $out .= "<input id='remindIdP' type='text'/><button onclick='remindIdPF(); return false;'>" . _("Get IdP Reminder") . "</button>";
107
+                    $out .= "<p><button type='button' onclick='goAdmin(); return(false);'>"._("Login")."</button>";
108
+                    $out .= "<br/><br/><p>"._("Did you forget with which Identity Provider you logged in to the system? We can try to find out if you specify the email address with which you were invited to the system in the box below. This may not work if you were invited from a third-party website via the AdminAPI.")."</p>";
109
+                    $out .= "<input id='remindIdP' type='text'/><button onclick='remindIdPF(); return false;'>"._("Get IdP Reminder")."</button>";
110 110
                     $out .= "<div id='remindIdPd'><span id='remindIdPh'></span><ul id='remindIdPl'></ul></div>";
111 111
                     $out = "<div  class='padding'>$out</div>";
112 112
                 }
113 113
                 break;
114 114
             case 'develop':
115
-                include_once dirname(dirname(dirname(dirname(__FILE__)))) . "/user/devel.inc.php";
115
+                include_once dirname(dirname(dirname(dirname(__FILE__))))."/user/devel.inc.php";
116 116
                 $out = "<div class='padding'>$out</div>";
117 117
                 break;
118 118
         }
Please login to merge, or discard this patch.
core/SilverbulletCertificate.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
         $invitationObject = new SilverbulletInvitation($token);
326 326
         $profile = new ProfileSilverbullet($invitationObject->profile);
327 327
         $inst = new IdP($profile->institution);
328
-        $loggerInstance->debug(5, "tokenStatus: done, got " . $invitationObject->invitationTokenStatus . ", " . $invitationObject->profile . ", " . $invitationObject->userId . ", " . $invitationObject->expiry . ", " . $invitationObject->invitationTokenString . "\n");
328
+        $loggerInstance->debug(5, "tokenStatus: done, got ".$invitationObject->invitationTokenStatus.", ".$invitationObject->profile.", ".$invitationObject->userId.", ".$invitationObject->expiry.", ".$invitationObject->invitationTokenString."\n");
329 329
         if ($invitationObject->invitationTokenStatus != SilverbulletInvitation::SB_TOKENSTATUS_VALID && $invitationObject->invitationTokenStatus != SilverbulletInvitation::SB_TOKENSTATUS_PARTIALLY_REDEEMED) {
330 330
             throw new Exception("Attempt to generate a SilverBullet installer with an invalid/redeemed/expired token. The user should never have got that far!");
331 331
         }
@@ -338,12 +338,12 @@  discard block
 block discarded – undo
338 338
             throw new Exception("Despite a valid token, the corresponding user was not found in database or database query error!");
339 339
         }
340 340
         $expiryObject = mysqli_fetch_object(/** @scrutinizer ignore-type */ $userrow);
341
-        $loggerInstance->debug(5, "EXP: " . $expiryObject->expiry . "\n");
341
+        $loggerInstance->debug(5, "EXP: ".$expiryObject->expiry."\n");
342 342
         $expiryDateObject = date_create_from_format("Y-m-d H:i:s", $expiryObject->expiry);
343 343
         if ($expiryDateObject === FALSE) {
344 344
             throw new Exception("The expiry date we got from the DB is bogus!");
345 345
         }
346
-        $loggerInstance->debug(5, $expiryDateObject->format("Y-m-d H:i:s") . "\n");
346
+        $loggerInstance->debug(5, $expiryDateObject->format("Y-m-d H:i:s")."\n");
347 347
         // date_create with no parameters can't fail, i.e. is never FALSE
348 348
         $validity = date_diff(/** @scrutinizer ignore-type */ date_create(), $expiryDateObject);
349 349
         $expiryDays = $validity->days + 1;
@@ -377,14 +377,14 @@  discard block
 block discarded – undo
377 377
         $exportedCertClear = "";
378 378
         openssl_pkcs12_export($cert, $exportedCertClear, $privateKey, "", ['extracerts' => [$issuingCaPem, $rootCaPem]]);
379 379
         $pkey_3des = "";
380
-        openssl_pkey_export($privateKey, $pkey_3des, $importPassword, [ "encrypt_key_cipher" => OPENSSL_CIPHER_3DES ]);
380
+        openssl_pkey_export($privateKey, $pkey_3des, $importPassword, ["encrypt_key_cipher" => OPENSSL_CIPHER_3DES]);
381 381
         // store resulting cert CN and expiry date in separate columns into DB - do not store the cert data itself as it contains the private key!
382 382
         // we need the *real* expiry date, not just the day-approximation
383 383
         $x509 = new \core\common\X509();
384 384
         $certString = "";
385 385
         openssl_x509_export($cert, $certString);
386 386
         $parsedCert = $x509->processCertificate($certString);
387
-        $loggerInstance->debug(5, "CERTINFO: " . /** @scrutinizer ignore-type */ print_r($parsedCert['full_details'], true));
387
+        $loggerInstance->debug(5, "CERTINFO: "./** @scrutinizer ignore-type */ print_r($parsedCert['full_details'], true));
388 388
         $realExpiryDate = date_create_from_format("U", $parsedCert['full_details']['validTo_time_t'])->format("Y-m-d H:i:s");
389 389
 
390 390
         // store new cert info in DB
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
         // let the RADIUS users know the actual username for CUI generation
397 397
         $radiusDbs = DBConnection::handle("RADIUS"); // is an array of server conns
398 398
         foreach ($radiusDbs as $oneRadiusDb) {
399
-            $oneRadiusDb->exec("INSERT IGNORE INTO radcheck (username, attribute, op, value) VALUES (?, 'CUI-Source-Username', ':=', ?)", "ss", ($profile->getUserById($invitationObject->userId))[$invitationObject->userId] , $csr["USERNAME"]);
399
+            $oneRadiusDb->exec("INSERT IGNORE INTO radcheck (username, attribute, op, value) VALUES (?, 'CUI-Source-Username', ':=', ?)", "ss", ($profile->getUserById($invitationObject->userId))[$invitationObject->userId], $csr["USERNAME"]);
400 400
         }
401 401
 
402 402
 // return PKCS#12 data stream
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
         $username = "";
454 454
         while ($usernameIsUnique === FALSE) {
455 455
             $usernameLocalPart = common\Entity::randomString(64 - 1 - strlen($realm), "0123456789abcdefghijklmnopqrstuvwxyz");
456
-            $username = $usernameLocalPart . "@" . $realm;
456
+            $username = $usernameLocalPart."@".$realm;
457 457
             $uniquenessQuery = $databaseHandle->exec("SELECT cn from silverbullet_certificate WHERE cn = ? AND ca_type = ?", "ss", $username, $certtype);
458 458
             // SELECT -> resource, not boolean
459 459
             if (mysqli_num_rows(/** @scrutinizer ignore-type */ $uniquenessQuery) == 0) {
Please login to merge, or discard this patch.
core/CAT.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
         parent::__construct();
110 110
         common\Entity::intoThePotatoes();
111 111
 
112
-        $this->catVersionString = sprintf("Unreleased %s Git Revision"    , "<a href='https://github.com/GEANT/CAT/tree/master/Changes.md'>") . "</a>";
112
+        $this->catVersionString = sprintf("Unreleased %s Git Revision", "<a href='https://github.com/GEANT/CAT/tree/master/Changes.md'>")."</a>";
113 113
 
114 114
         if (CAT::RELEASE_VERSION) {
115 115
             $major = CAT::VERSION_MAJOR;
@@ -117,14 +117,14 @@  discard block
 block discarded – undo
117 117
             $patch = CAT::VERSION_PATCH;
118 118
             $extra = CAT::VERSION_EXTRA;
119 119
             $temp_version = "CAT-$major.$minor";
120
-            $branch = "release_$major" . "_$minor";
120
+            $branch = "release_$major"."_$minor";
121 121
             if (CAT::VERSION_PATCH != 0) {
122 122
                 $temp_version .= ".$patch";
123 123
             }
124 124
             if (CAT::VERSION_EXTRA != "") {
125 125
                 $temp_version .= "-$extra";
126 126
             }
127
-            $this->catVersionString = sprintf("Release <a href='%s'>%s</a>", "https://github.com/GEANT/CAT/tree/" . $branch . "/Changes.md", $temp_version);
127
+            $this->catVersionString = sprintf("Release <a href='%s'>%s</a>", "https://github.com/GEANT/CAT/tree/".$branch."/Changes.md", $temp_version);
128 128
 
129 129
         }
130 130
         $product = \config\Master::APPEARANCE['productname'];
@@ -132,9 +132,9 @@  discard block
 block discarded – undo
132 132
         $maxYear = self::COPYRIGHT_MAX_YEAR;
133 133
         $holder = self::COPYRIGHT_HOLDER;
134 134
         $consortia = self::COPYRIGHT_CONSORTIA;
135
-        $this->catCopyright = "$product - " . $this->catVersionString . " &copy; $minYear-$maxYear $holder<br/>on behalf of $consortia; and others <a href='copyright.php'>Full Copyright and Licenses</a>";
135
+        $this->catCopyright = "$product - ".$this->catVersionString." &copy; $minYear-$maxYear $holder<br/>on behalf of $consortia; and others <a href='copyright.php'>Full Copyright and Licenses</a>";
136 136
         $this->catCopyrifhtAndLicense = "&copy; $minYear-$maxYear $holder<br/>on behalf of $consortia; and others <a href='copyright.php'>Full Copyright and Licenses</a>";
137
-        $this->catVersion = "$product<br>" . $this->catVersionString;
137
+        $this->catVersion = "$product<br>".$this->catVersionString;
138 138
 
139 139
         /* Federations are created in DB with bootstrapFederation, and listed via listFederations
140 140
          */
Please login to merge, or discard this patch.
web/skins/modern/accountstatus/resources/css/accountstatus.css.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,12 +17,12 @@
 block discarded – undo
17 17
  *          <base_url>/copyright.php after deploying the software
18 18
  */
19 19
 header("Content-Type:text/css");
20
-require_once dirname(dirname(dirname(dirname(dirname(dirname(__DIR__)))))) . "/config/_config.php";
20
+require_once dirname(dirname(dirname(dirname(dirname(dirname(__DIR__))))))."/config/_config.php";
21 21
 $langInstance = new core\common\Language();
22 22
 $start = $langInstance->rtl ? "right" : "left";
23 23
 ?>
24 24
 #sb_info {
25
-    padding-<?php echo $start;?>: 30px; 
25
+    padding-<?php echo $start; ?>: 30px; 
26 26
     font-size: 12px;  
27 27
     font-weight: normal; 
28 28
 }
Please login to merge, or discard this patch.
web/admin/css/silverbullet.css.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 // we need to know if we are serving a RTL language so we can flip some heading
22 22
 // items
23 23
 header("Content-Type:text/css");
24
-require_once dirname(dirname(dirname(__DIR__))) . "/config/_config.php";
24
+require_once dirname(dirname(dirname(__DIR__)))."/config/_config.php";
25 25
 $langInstance = new core\common\Language();
26 26
 $start = $langInstance->rtl ? "right" : "left";
27 27
 $end = $langInstance->rtl ? "left" : "right";
@@ -82,16 +82,16 @@  discard block
 block discarded – undo
82 82
     margin-bottom:3px;
83 83
 }
84 84
 .sb-date-picker{
85
-    padding-<?php echo $end;?>:25px;
85
+    padding-<?php echo $end; ?>:25px;
86 86
     width: 140px;
87 87
 }
88 88
 .sb-date-button{
89
-    margin-<?php echo $start;?>:-30px;
89
+    margin-<?php echo $start; ?>:-30px;
90 90
     min-height: 22px;
91
-    border-<?php echo $start;?>-style: solid;
91
+    border-<?php echo $start; ?>-style: solid;
92 92
     border-top-style: solid;
93
-    border-<?php echo $end;?>-style: solid;
94
-    border-<?php echo $end;?>-width: 1px;
93
+    border-<?php echo $end; ?>-style: solid;
94
+    border-<?php echo $end; ?>-width: 1px;
95 95
     border-bottom-width: 1px;
96 96
     border-radius: 1px;
97 97
     box-shadow: 0px 0px 0px #666666;
Please login to merge, or discard this patch.
web/admin/css/eapSorter.css.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 // we need to know if we are serving a RTL language so we can flip some heading
23 23
 // items
24 24
 header("Content-Type:text/css");
25
-require_once dirname(dirname(dirname(__DIR__))) . "/config/_config.php";
25
+require_once dirname(dirname(dirname(__DIR__)))."/config/_config.php";
26 26
 
27 27
 $langInstance = new core\common\Language();
28 28
 $start = $langInstance->rtl ? "right" : "left";
@@ -32,15 +32,15 @@  discard block
 block discarded – undo
32 32
 ol.eapmethods { list-style-position: inside; margin: 0; padding: 0px; padding-top: 20px; padding-bottom: 0px; width: 20em; }
33 33
 ol.eapmethods li{
34 34
     background: #CCF;
35
-    border-<?php echo $start;?>-style: inset;
36
-    border-<?php echo $start;?>-width: 1px;
37
-    border-<?php echo $start;?>-color: #8BBACB;
35
+    border-<?php echo $start; ?>-style: inset;
36
+    border-<?php echo $start; ?>-width: 1px;
37
+    border-<?php echo $start; ?>-color: #8BBACB;
38 38
     border-top-style: inset;
39 39
     border-top-width: 1px;
40 40
     border-top-color: #8BBACB;
41
-    border-<?php echo $end;?>-style: outset;
42
-    border-<?php echo $end;?>-width: 2px;
43
-    border-<?php echo $end;?>-color: #043D52;
41
+    border-<?php echo $end; ?>-style: outset;
42
+    border-<?php echo $end; ?>-width: 2px;
43
+    border-<?php echo $end; ?>-color: #043D52;
44 44
     border-bottom-style: outset;
45 45
     border-bottom-width: 2px;
46 46
     border-bottom-color: #043D52;
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
     background-position:95% 50%;
52 52
     margin: 2px 0px 2px 0px;
53 53
     padding: 3px;
54
-    padding-<?php echo $start;?>: 1em;
55
-    padding-<?php echo $end;?>: 0px;
54
+    padding-<?php echo $start; ?>: 1em;
55
+    padding-<?php echo $end; ?>: 0px;
56 56
 }
57 57
 
58 58
 table.eaptable td {
Please login to merge, or discard this patch.
web/skins/modern/resources/css/cat-user.css.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 header("Content-Type:text/css");
22
-require dirname(dirname(dirname(dirname(dirname(dirname(__FILE__)))))) . "/config/_config.php";
22
+require dirname(dirname(dirname(dirname(dirname(dirname(__FILE__))))))."/config/_config.php";
23 23
 $langInstance = new core\common\Language();
24 24
 $start = $langInstance->rtl ? "right" : "left";
25 25
 $end = $langInstance->rtl ? "left" : "right";
@@ -399,8 +399,8 @@  discard block
 block discarded – undo
399 399
 
400 400
 #message_only {
401 401
     padding-top: 20px;
402
-    padding-<?php echo $start;?>: 30px;
403
-    padding-<?php echo $end;?>: 30px;
402
+    padding-<?php echo $start; ?>: 30px;
403
+    padding-<?php echo $end; ?>: 30px;
404 404
     font-weight: normal;
405 405
     position: relative;
406 406
     font-size: 15px;
Please login to merge, or discard this patch.
core/EntityWithDBProperties.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
             case "core\User":
140 140
                 return $this->userName;
141 141
             default:
142
-                throw new Exception("Operating on a class where we don't know the relevant identifier in the DB - " . get_class($this) . "!");
142
+                throw new Exception("Operating on a class where we don't know the relevant identifier in the DB - ".get_class($this)."!");
143 143
         }
144 144
     }
145 145
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
      */
178 178
     public function beginFlushAttributes($extracondition = "")
179 179
     {
180
-        $quotedIdentifier = (!is_int($this->getRelevantIdentifier()) ? "\"" : "") . $this->getRelevantIdentifier() . (!is_int($this->getRelevantIdentifier()) ? "\"" : "");
180
+        $quotedIdentifier = (!is_int($this->getRelevantIdentifier()) ? "\"" : "").$this->getRelevantIdentifier().(!is_int($this->getRelevantIdentifier()) ? "\"" : "");
181 181
         $this->databaseHandle->exec("DELETE FROM $this->entityOptionTable WHERE $this->entityIdColumn = $quotedIdentifier AND option_name NOT LIKE '%_file' $extracondition");
182 182
         $this->updateFreshness();
183 183
         $execFlush = $this->databaseHandle->exec("SELECT row_id FROM $this->entityOptionTable WHERE $this->entityIdColumn = $quotedIdentifier $extracondition");
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
      */
198 198
     public function commitFlushAttributes(array $tobedeleted)
199 199
     {
200
-        $quotedIdentifier = (!is_int($this->getRelevantIdentifier()) ? "\"" : "") . $this->getRelevantIdentifier() . (!is_int($this->getRelevantIdentifier()) ? "\"" : "");
200
+        $quotedIdentifier = (!is_int($this->getRelevantIdentifier()) ? "\"" : "").$this->getRelevantIdentifier().(!is_int($this->getRelevantIdentifier()) ? "\"" : "");
201 201
         foreach (array_keys($tobedeleted) as $row_id) {
202 202
             $this->databaseHandle->exec("DELETE FROM $this->entityOptionTable WHERE $this->entityIdColumn = $quotedIdentifier AND row_id = $row_id");
203 203
             $this->updateFreshness();
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
     {
227 227
         $relevantId = $this->getRelevantIdentifier();
228 228
         $identifierType = (is_int($relevantId) ? "i" : "s");
229
-        $this->databaseHandle->exec("INSERT INTO $this->entityOptionTable ($this->entityIdColumn, option_name, option_lang, option_value) VALUES(?,?,?,?)", $identifierType . "sss", $relevantId, $attrName, $attrLang, $attrValue);
229
+        $this->databaseHandle->exec("INSERT INTO $this->entityOptionTable ($this->entityIdColumn, option_name, option_lang, option_value) VALUES(?,?,?,?)", $identifierType."sss", $relevantId, $attrName, $attrLang, $attrValue);
230 230
         $this->updateFreshness();
231 231
     }
232 232
 
Please login to merge, or discard this patch.
web/admin/overview_sp.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 $deco = new \web\lib\admin\PageDecoration();
32 32
 $validator = new \web\lib\common\InputValidation();
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 } else {
39 39
     $link = 'http://';
40 40
 }
41
-$link .= $_SERVER['SERVER_NAME'] . $_SERVER['SCRIPT_NAME'];
41
+$link .= $_SERVER['SERVER_NAME'].$_SERVER['SCRIPT_NAME'];
42 42
 $link = htmlspecialchars($link);
43 43
 
44 44
 echo $deco->defaultPagePrelude(sprintf(_("%s: %s Dashboard"), \config\Master::APPEARANCE['productname'], $uiElements->nomenclatureHotspot));
@@ -102,21 +102,21 @@  discard block
 block discarded – undo
102 102
         <?php
103 103
         if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] !== NULL) {
104 104
             echo "<tr>
105
-                        <td>" . sprintf(_("Diagnose reachability and connection parameters of %ss"),$uiElements->nomenclatureInst) . "</td>
105
+                        <td>" . sprintf(_("Diagnose reachability and connection parameters of %ss"), $uiElements->nomenclatureInst)."</td>
106 106
                         <td><form method='post' action='../diag/action_realmcheck.php?inst_id=$my_inst->identifier' accept-charset='UTF-8'>
107 107
                               <!--<input type='text' name='realm' id='realm'>-->
108 108
                               <input type='hidden' name='comefrom' id='comefrom' value='$link'/>
109
-                              <button id='realmcheck' style='cursor:pointer;' type='submit'>" . _("Go!") . "</button>
109
+                              <button id='realmcheck' style='cursor:pointer;' type='submit'>"._("Go!")."</button>
110 110
                             </form>
111 111
                         </td>
112 112
                     </tr>";
113 113
         }
114 114
         if (\config\ConfAssistant::CONSORTIUM['name'] == "eduroam") { // SW: APPROVED
115 115
             echo "<tr>
116
-                        <td>" . sprintf(_("Check %s server status"), $uiElements->nomenclatureFed) . "</td>
116
+                        <td>" . sprintf(_("Check %s server status"), $uiElements->nomenclatureFed)."</td>
117 117
                         <td>
118 118
                            <form action='https://monitor.eduroam.org/mon_direct.php' accept-charset='UTF-8'>
119
-                              <button style='cursor:pointer;' type='submit'>" . _("Go!") . "</button>
119
+                              <button style='cursor:pointer;' type='submit'>" . _("Go!")."</button>
120 120
                            </form>
121 121
                         </td>
122 122
                     </tr>";
@@ -127,10 +127,10 @@  discard block
 block discarded – undo
127 127
     <?php
128 128
     $hotspotProfiles = $my_inst->listDeployments();
129 129
     if (count($hotspotProfiles) == 0) { // no profiles yet.
130
-        echo "<h2>" . sprintf(_("There are not yet any known deployments for your %s."), $uiElements->nomenclatureHotspot) . "</h2>";
130
+        echo "<h2>".sprintf(_("There are not yet any known deployments for your %s."), $uiElements->nomenclatureHotspot)."</h2>";
131 131
     }
132 132
     if (count($hotspotProfiles) > 0) { // no profiles yet.
133
-        echo "<h2>" . sprintf(_("Deployments for this %s"), $uiElements->nomenclatureHotspot) . "</h2>";
133
+        echo "<h2>".sprintf(_("Deployments for this %s"), $uiElements->nomenclatureHotspot)."</h2>";
134 134
         // display an info box with the connection data
135 135
     }
136 136
    
@@ -149,19 +149,19 @@  discard block
 block discarded – undo
149 149
         ?>
150 150
         <div style='display: table-row_id; margin-bottom: 20px;'>
151 151
             <div class='profilebox' style='display: table-cell;'>
152
-                <h2><?php echo core\DeploymentManaged::PRODUCTNAME . " (<span style='color:" . ( $deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>" . _("inactive") : "green;'>" . _("active") ) . "</span>)"; ?></h2>
152
+                <h2><?php echo core\DeploymentManaged::PRODUCTNAME." (<span style='color:".($deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>"._("inactive") : "green;'>"._("active"))."</span>)"; ?></h2>
153 153
                 <table>
154 154
                     <tr>
155 155
                         <td><strong><?php echo _("Your primary RADIUS server") ?></strong><br/>
156 156
                         <?php
157 157
                             if ($deploymentObject->host1_v4 !== NULL) {
158
-                                echo _("IPv4") . ": " . $deploymentObject->host1_v4;
158
+                                echo _("IPv4").": ".$deploymentObject->host1_v4;
159 159
                             }
160 160
                             if ($deploymentObject->host1_v4 !== NULL && $deploymentObject->host1_v6 !== NULL) {
161 161
                                 echo "<br/>";
162 162
                             }
163 163
                             if ($deploymentObject->host1_v6 !== NULL) {
164
-                                echo _("IPv6") . ": " . $deploymentObject->host1_v6;
164
+                                echo _("IPv6").": ".$deploymentObject->host1_v6;
165 165
                             }
166 166
                             ?>
167 167
                         </td>
@@ -169,9 +169,9 @@  discard block
 block discarded – undo
169 169
                         <td><?php echo $deploymentObject->port1; ?></td>
170 170
                         <td>
171 171
                             <?php
172
-                                echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_1]['icon'] . 
173
-                                     "' alt='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . 
174
-                                     "' title='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . "'>";
172
+                                echo "<img src='".$radiusMessages[$deploymentObject->radius_status_1]['icon']. 
173
+                                     "' alt='".$radiusMessages[$deploymentObject->radius_status_1]['text']. 
174
+                                     "' title='".$radiusMessages[$deploymentObject->radius_status_1]['text']."'>";
175 175
                             ?>
176 176
                         </td>
177 177
                     </tr>
@@ -179,22 +179,22 @@  discard block
 block discarded – undo
179 179
                         <td><strong><?php echo _("Your backup RADIUS server") ?><br/></strong>
180 180
                             <?php
181 181
                             if ($deploymentObject->host2_v4 !== NULL) {
182
-                                echo _("IPv4") . ": " . $deploymentObject->host2_v4;
182
+                                echo _("IPv4").": ".$deploymentObject->host2_v4;
183 183
                             }
184 184
                             if ($deploymentObject->host2_v4 !== NULL && $deploymentObject->host2_v6 !== NULL) {
185 185
                                 echo "<br/>";
186 186
                             }
187 187
                             if ($deploymentObject->host2_v6 !== NULL) {
188
-                                echo _("IPv6") . ": " . $deploymentObject->host2_v6;
188
+                                echo _("IPv6").": ".$deploymentObject->host2_v6;
189 189
                             }
190 190
                             ?></td>
191 191
                         <td><?php echo _("RADIUS port number: ") ?></td>
192 192
                         <td><?php echo $deploymentObject->port2; ?></td>
193 193
                         <td>
194 194
                             <?php
195
-                                echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_2]['icon'] .
196
-                                     "' alt='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . 
197
-                                     "' title='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . "'>";
195
+                                echo "<img src='".$radiusMessages[$deploymentObject->radius_status_2]['icon'].
196
+                                     "' alt='".$radiusMessages[$deploymentObject->radius_status_2]['text']. 
197
+                                     "' title='".$radiusMessages[$deploymentObject->radius_status_2]['text']."'>";
198 198
                             ?>
199 199
                         </td>
200 200
                     </tr>
@@ -245,12 +245,12 @@  discard block
 block discarded – undo
245 245
                                     if (array_key_exists('FAILURE', $res) && $res['FAILURE'] > 0) {
246 246
                                         echo '<br>';
247 247
                                         if ($res['FAILURE'] == 2) {
248
-                                            echo ' <span style="color: red;">' . _("Activation failure.") . '</span>';
248
+                                            echo ' <span style="color: red;">'._("Activation failure.").'</span>';
249 249
                                         } else {
250 250
                                             if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
251
-                                                echo ' <span style="color: red;">' . _("Activation failure for your primary RADIUS server.") . '</span>';
251
+                                                echo ' <span style="color: red;">'._("Activation failure for your primary RADIUS server.").'</span>';
252 252
                                             } else {
253
-                                                echo ' <span style="color: red;">' . _("Activation failure for your backup RADIUS server.") . '</span>';
253
+                                                echo ' <span style="color: red;">'._("Activation failure for your backup RADIUS server.").'</span>';
254 254
                                             }
255 255
                                         }
256 256
                                     }
@@ -270,12 +270,12 @@  discard block
 block discarded – undo
270 270
                                     if ($res['FAILURE'] > 0) {
271 271
                                         echo '<br>';
272 272
                                         if ($res['FAILURE'] == 2) {
273
-                                            echo ' <span style="color: red;">' . _("Failure during deactivation, your request is queued for handling") . '</span>';
273
+                                            echo ' <span style="color: red;">'._("Failure during deactivation, your request is queued for handling").'</span>';
274 274
                                         } else {
275 275
                                             if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
276
-                                                echo ' <span style="color: red;">' . _("Deactivation failure for your primary RADIUS server, your request is queued.") . '</span>';
276
+                                                echo ' <span style="color: red;">'._("Deactivation failure for your primary RADIUS server, your request is queued.").'</span>';
277 277
                                             } else {
278
-                                                echo ' <span style="color: red;">' . _("Deactivation failure for your backup RADIUS server, your request is queued.") . '</span>';
278
+                                                echo ' <span style="color: red;">'._("Deactivation failure for your backup RADIUS server, your request is queued.").'</span>';
279 279
                                             }
280 280
                                         }
281 281
                                     }
Please login to merge, or discard this patch.