GEANT /
CAT
| Total Complexity | 65 |
| Total Lines | 464 |
| Duplicated Lines | 11.85 % |
| Changes | 0 | ||
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Device_Vista7 often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Device_Vista7, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 26 | class Device_Vista7 extends WindowsCommon { |
||
| 27 | |||
| 28 | final public function __construct() { |
||
| 29 | parent::__construct(); |
||
| 30 | $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_TLS, \core\common\EAP::EAPTYPE_PEAP_MSCHAP2, \core\common\EAP::EAPTYPE_PWD, \core\common\EAP::EAPTYPE_TTLS_PAP, \core\common\EAP::EAPTYPE_TTLS_MSCHAP2, \core\common\EAP::EAPTYPE_SILVERBULLET]); |
||
| 31 | $this->loggerInstance->debug(4, "This device supports the following EAP methods: "); |
||
| 32 | $this->loggerInstance->debug(4, $this->supportedEapMethods); |
||
| 33 | $this->specialities['internal:use_anon_outer'][serialize(\core\common\EAP::EAPTYPE_PEAP_MSCHAP2)] = _("Anonymous identities do not use the realm as specified in the profile - it is derived from the suffix of the user's username input instead."); |
||
| 34 | } |
||
| 35 | |||
| 36 | public function writeInstaller() { |
||
| 37 | $dom = textdomain(NULL); |
||
| 38 | textdomain("devices"); |
||
| 39 | // create certificate files and save their names in $caFiles arrary |
||
| 40 | $caFiles = $this->saveCertificateFiles('der'); |
||
| 41 | |||
| 42 | $allSSID = $this->attributes['internal:SSID']; |
||
| 43 | $delSSIDs = $this->attributes['internal:remove_SSID']; |
||
| 44 | $this->prepareInstallerLang(); |
||
| 45 | $setWired = isset($this->attributes['media:wired'][0]) && $this->attributes['media:wired'][0] == 'on' ? 1 : 0; |
||
| 46 | // create a list of profiles to be deleted after installation |
||
| 47 | $delProfiles = []; |
||
| 48 | foreach ($delSSIDs as $ssid => $cipher) { |
||
| 49 | if ($cipher == 'DEL') { |
||
| 50 | $delProfiles[] = $ssid; |
||
| 51 | } |
||
| 52 | if ($cipher == 'TKIP') { |
||
| 53 | $delProfiles[] = $ssid . ' (TKIP)'; |
||
| 54 | } |
||
| 55 | } |
||
| 56 | |||
| 57 | if ($this->selectedEap == \core\common\EAP::EAPTYPE_TLS || $this->selectedEap == \core\common\EAP::EAPTYPE_PEAP_MSCHAP2 || $this->selectedEap == \core\common\EAP::EAPTYPE_PWD || $this->selectedEap == \core\common\EAP::EAPTYPE_TTLS_PAP || $this->selectedEap == \core\common\EAP::EAPTYPE_SILVERBULLET) { |
||
| 58 | $windowsProfile = []; |
||
| 59 | $eapConfig = $this->prepareEapConfig($this->attributes); |
||
| 60 | $iterator = 0; |
||
| 61 | foreach ($allSSID as $ssid => $cipher) { |
||
| 62 | if ($cipher == 'TKIP') { |
||
| 63 | $windowsProfile[$iterator] = $this->writeWLANprofile($ssid . ' (TKIP)', $ssid, 'WPA', 'TKIP', $eapConfig, $iterator); |
||
| 64 | $iterator++; |
||
| 65 | } |
||
| 66 | $windowsProfile[$iterator] = $this->writeWLANprofile($ssid, $ssid, 'WPA2', 'AES', $eapConfig, $iterator); |
||
| 67 | $iterator++; |
||
| 68 | } |
||
| 69 | if ($setWired) { |
||
| 70 | $this->writeLANprofile($eapConfig); |
||
| 71 | } |
||
| 72 | } else { |
||
| 73 | print(" this EAP type is not handled yet.\n"); |
||
| 74 | return; |
||
| 75 | } |
||
| 76 | $this->loggerInstance->debug(4, "windowsProfile"); |
||
| 77 | $this->loggerInstance->debug(4, $windowsProfile); |
||
| 78 | |||
| 79 | $this->writeProfilesNSH($windowsProfile, $caFiles, $setWired); |
||
| 80 | $this->writeAdditionalDeletes($delProfiles); |
||
| 81 | if ($this->selectedEap == \core\common\EAP::EAPTYPE_SILVERBULLET) { |
||
| 82 | $this->writeClientP12File(); |
||
| 83 | } |
||
| 84 | $this->copyFiles($this->selectedEap); |
||
| 85 | $fedLogo = $this->attributes['fed:logo_file'] ?? NULL; |
||
| 86 | $idpLogo = $this->attributes['internal:logo_file'] ?? NULL; |
||
| 87 | $this->combineLogo($idpLogo, $fedLogo); |
||
| 88 | $this->writeMainNSH($this->selectedEap, $this->attributes); |
||
| 89 | $this->compileNSIS(); |
||
| 90 | $installerPath = $this->signInstaller(); |
||
| 91 | |||
| 92 | textdomain($dom); |
||
| 93 | return($installerPath); |
||
| 94 | } |
||
| 95 | |||
| 96 | private function prepareEapConfig($attr) { |
||
| 300 | } |
||
| 301 | |||
| 302 | /** |
||
| 303 | * produce PEAP, TLS and TTLS configuration files for Vista and Windows 7 |
||
| 304 | * |
||
| 305 | * @param string $wlanProfileName |
||
| 306 | * @param string $ssid |
||
| 307 | * @param string $auth can be one of "WPA", "WPA2" |
||
| 308 | * @param string $encryption can be one of: "TKIP", "AES" |
||
| 309 | * @param array $eapConfig XML configuration block with EAP config data (two entries, one for Vista, one for 7) |
||
| 310 | * @param int $profileNumber counter, which profile number is this |
||
| 311 | * @return string |
||
| 312 | */ |
||
| 313 | private function writeWLANprofile($wlanProfileName, $ssid, $auth, $encryption, $eapConfig, $profileNumber) { |
||
| 314 | $profileFileCont = '<?xml version="1.0"?> |
||
| 315 | <WLANProfile xmlns="http://www.microsoft.com/networking/WLAN/profile/v1"> |
||
| 316 | <name>' . $wlanProfileName . '</name> |
||
| 317 | <SSIDConfig> |
||
| 318 | <SSID> |
||
| 319 | <name>' . $ssid . '</name> |
||
| 320 | </SSID> |
||
| 321 | <nonBroadcast>true</nonBroadcast> |
||
| 322 | </SSIDConfig> |
||
| 323 | <connectionType>ESS</connectionType> |
||
| 324 | <connectionMode>auto</connectionMode> |
||
| 325 | <autoSwitch>false</autoSwitch> |
||
| 326 | <MSM> |
||
| 327 | <security> |
||
| 328 | <authEncryption> |
||
| 329 | <authentication>' . $auth . '</authentication> |
||
| 330 | <encryption>' . $encryption . '</encryption> |
||
| 331 | <useOneX>true</useOneX> |
||
| 332 | </authEncryption> |
||
| 333 | '; |
||
| 334 | if ($auth == 'WPA2') { |
||
| 335 | $profileFileCont .= '<PMKCacheMode>enabled</PMKCacheMode> |
||
| 336 | <PMKCacheTTL>720</PMKCacheTTL> |
||
| 337 | <PMKCacheSize>128</PMKCacheSize> |
||
| 338 | <preAuthMode>disabled</preAuthMode> |
||
| 339 | '; |
||
| 340 | } |
||
| 341 | $profileFileCont .= '<OneX xmlns="http://www.microsoft.com/networking/OneX/v1"> |
||
| 342 | <cacheUserData>true</cacheUserData> |
||
| 343 | <authMode>user</authMode> |
||
| 344 | '; |
||
| 345 | |||
| 346 | $closing = ' |
||
| 347 | </OneX> |
||
| 348 | </security> |
||
| 349 | </MSM> |
||
| 350 | </WLANProfile> |
||
| 351 | '; |
||
| 352 | |||
| 353 | if (!is_dir('w7')) { |
||
| 354 | mkdir('w7'); |
||
| 355 | } |
||
| 356 | if (!is_dir('vista')) { |
||
| 357 | mkdir('vista'); |
||
| 358 | } |
||
| 359 | $vistaFileName = "vista/wlan_prof-$profileNumber.xml"; |
||
| 360 | file_put_contents($vistaFileName, $profileFileCont . $eapConfig['vista'] . $closing); |
||
| 361 | $sevenFileName = "w7/wlan_prof-$profileNumber.xml"; |
||
| 362 | file_put_contents($sevenFileName, $profileFileCont . $eapConfig['w7'] . $closing); |
||
| 363 | $this->loggerInstance->debug(2, "Installer has been written into directory $this->FPATH\n"); |
||
| 364 | $this->loggerInstance->debug(4, "WLAN_Profile:$wlanProfileName:$encryption\n"); |
||
| 365 | return("\"$wlanProfileName\" \"$encryption\""); |
||
| 366 | } |
||
| 367 | |||
| 368 | private function writeLANprofile($eapConfig) { |
||
| 399 | } |
||
| 400 | |||
| 401 | private function writeMainNSH($eap, $attr) { |
||
| 441 | } |
||
| 442 | |||
| 443 | View Code Duplication | private function writeProfilesNSH($wlanProfiles, $caArray, $wired = 0) { |
|
| 444 | $this->loggerInstance->debug(4, "writeProfilesNSH"); |
||
| 445 | $this->loggerInstance->debug(4, $wlanProfiles); |
||
| 446 | $contentWlan = ''; |
||
| 447 | foreach ($wlanProfiles as $wlanProfile) { |
||
| 448 | $contentWlan .= "!insertmacro define_wlan_profile $wlanProfile\n"; |
||
| 449 | } |
||
| 450 | |||
| 451 | file_put_contents('profiles.nsh', $contentWlan); |
||
| 452 | |||
| 453 | $contentCerts = ''; |
||
| 454 | $fileHandleCerts = fopen('certs.nsh', 'w'); |
||
| 455 | if ($fileHandleCerts === FALSE) { |
||
| 456 | throw new Exception("Unable to open new file certs.nsh to write CAs!"); |
||
| 457 | } |
||
| 458 | if ($caArray) { |
||
| 459 | foreach ($caArray as $certAuthority) { |
||
| 460 | $store = $certAuthority['root'] ? "root" : "ca"; |
||
| 461 | $contentCerts .= '!insertmacro install_ca_cert "' . $certAuthority['file'] . '" "' . $certAuthority['sha1'] . '" "' . $store . "\"\n"; |
||
| 462 | } |
||
| 463 | fwrite($fileHandleCerts, $contentCerts); |
||
| 464 | } |
||
| 465 | fclose($fileHandleCerts); |
||
| 466 | } |
||
| 467 | |||
| 468 | private function copyFiles($eap) { |
||
| 487 | } |
||
| 488 | |||
| 489 | private $tlsOtherUsername = 0; |
||
| 490 | |||
| 492 |
Loading history...
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.