GEANT / CAT

web/admin/sanity_tests.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     'mailer',
 ];
 
-if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == "LOCAL" || CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == "LOCAL" ) {
+if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == "LOCAL" || CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == "LOCAL") {
     $Tests[] = 'makensis';
     $Tests[] = 'makensis=>NSISmodules';
 }

core/SanityTests.php

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
             }
             if ($passedTheWindmill) {
                 if (substr($schemaLine, 0, 1) == '(') { // a relevant line in schema
-                    $this->profile_option_ct = $this->profile_option_ct+1;
+                    $this->profile_option_ct = $this->profile_option_ct + 1;
                 } else { // anything else, quit parsing
                     break;
                 }

core/diag/Telepath.php

Doc Comments +4 added lines, -1 removed lines

@@ -81,6 +81,9 @@ 
 
      */
 
+    /**
+     * @param string $type
+     */
     private function genericAPIStatus($type, $param1 = NULL, $param2 = NULL) {
         $endpoints = [
             'tlr_test' => "https://monitor.eduroam.org/mapi/index.php?type=tlr_test&tlr=$param1",
@@ -185,7 +188,7 @@ 
      * realm (and indirectly that of the links and statuses of involved proxies
      * and returns a judgment whether external Monitoring API tests are warranted
      * or not
-     * @return boolean TRUE if external tests have to be run
+     * @return boolean|null TRUE if external tests have to be run
      */
     private function CATInternalTests() {
         // we are expecting to get a REJECT from all runs, because that means the packet got through to the IdP.

core/diag/Logopath.php

Spacing +1 added lines, -1 removed lines

@@ -239,7 +239,7 @@
             // leave his mail address, remove him/her from the list of recipients
             foreach (Logopath::CATEGORYBINDING as $index => $functionName) {
                 if (in_array(Logopath::ENDUSER, $theMail[$index]) && $this->userEmail === FALSE) {
-                    $theMail[$index] = array_diff($theMail[$index], [Logopath::ENDUSER] );
+                    $theMail[$index] = array_diff($theMail[$index], [Logopath::ENDUSER]);
                 }
             }