core\IdP

Complexity

Total Complexity

86

Size/Duplication

Total Lines	548
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

21 Methods

Rating	Name	Duplication	Size	Complexity
A	listProfiles()	0	14	3
A	__construct()	0	43	5
A	listOwners()	0	9	2
A	listDeployments()	0	16	4
A	destroy()	0	36	5
A	updateFreshness()	0	5	1
A	maxDeploymentStatus()	0	8	2
A	maxProfileStatus()	0	20	5
A	maxOpenRoamingStatus()	0	8	3
A	eligibility()	0	9	3
A	isPrimaryOwner()	0	8	4
B	getExternalDBSyncCandidates()	0	34	11
A	profileCount()	0	10	2
A	deploymentCount()	0	10	2
B	significantChanges()	0	27	8
A	newDeployment()	0	12	3
A	setExternalDBId()	0	8	5
A	getExternalDBSyncState()	0	6	4
A	removeExternalDBId()	0	6	5
A	getExternalDBId()	0	13	5
A	newProfile()	0	18	4

<?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a 
 * project that has received funding from the European Union’s Framework 
 * Programme 7 under Grant Agreements No. 238875 (GN3) and No. 605243 (GN3plus),
 * Horizon 2020 research and innovation programme under Grant Agreements No. 
 * 691567 (GN4-1) and No. 731122 (GN4-2).
 * On behalf of the aforementioned projects, GEANT Association is the sole owner
 * of the copyright in all material which was developed by a member of the GÉANT
 * project. GÉANT Vereniging (Association) is registered with the Chamber of 
 * Commerce in Amsterdam with registration number 40535155 and operates in the 
 * UK as a branch of GÉANT Vereniging.
 * 
 * Registered office: Hoekenrode 3, 1102BR Amsterdam, The Netherlands. 
 * UK branch address: City House, 126-130 Hills Road, Cambridge CB2 1PQ, UK
 *
 * License: see the web/copyright.inc.php file in the file structure or
 *          <base_url>/copyright.php after deploying the software
 */

/**
 * This file contains Federation, IdP and Profile classes.
 * These should be split into separate files later.
 *
 * @package Developer
 */
/**
 * 
 */

namespace core;

use \Exception;

The type \Exception was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * This class represents an Identity Provider (IdP).
 * IdPs have properties of their own, and may have one or more Profiles. The
 * profiles can override the institution-wide properties.
 *
 * @author Stefan Winter <stefan.winter@restena.lu>
 * @author Tomasz Wolniewicz <twoln@umk.pl>
 *
 * @license see LICENSE file in root directory
 *
 * @package Developer
 */
class IdP extends EntityWithDBProperties
{

    const EXTERNAL_DB_SYNCSTATE_NOT_SYNCED = 0;
    const EXTERNAL_DB_SYNCSTATE_SYNCED = 1;
    const EXTERNAL_DB_SYNCSTATE_NOTSUBJECTTOSYNCING = 2;
    const TYPE_IDP = 'IdP';
    const TYPE_SP = 'SP';
    const TYPE_IDPSP = 'IdPSP';

    /**
     *
     * @var integer synchronisation state with external database, if any
     */
    private $externalDbSyncstate;

    /**
     * The shortname of this IdP's federation
     * @var string 
     */
    public $federation;

    /**
     * The type of participant in DB enum notation
     * @var string
     */
    public $type;

    /**
     * Constructs an IdP object based on its details in the database.
     * Cannot be used to define a new IdP in the database! This happens via Federation::newIdP()
     *
     * @param int $instId the database row_id identifier
     * @throws Exception
     */
    public function __construct(int $instId)
    {
        $this->databaseType = "INST";
        parent::__construct(); // now databaseHandle and logging is available
        $this->entityOptionTable = "institution_option";
        $this->entityIdColumn = "institution_id";

        $this->identifier = $instId;

        $idp = $this->databaseHandle->exec("SELECT inst_id, country,external_db_syncstate, type FROM institution WHERE inst_id = $this->identifier");
        // SELECT -> returns resource, not boolean
        if (!$instQuery = mysqli_fetch_object(/** @scrutinizer ignore-type */ $idp)) {
            throw new Exception("IdP $this->identifier not found in database!");
        }

        $this->federation = $instQuery->country;
        $this->externalDbSyncstate = $instQuery->external_db_syncstate;

        // fetch attributes from DB; populates $this->attributes array
        $this->attributes = $this->retrieveOptionsFromDatabase("SELECT DISTINCT option_name, option_lang, option_value, row_id 
                                            FROM $this->entityOptionTable
                                            WHERE $this->entityIdColumn = ?  
                                            ORDER BY option_name", "IdP");

        $this->attributes[] = ["name" => "internal:country",
            "lang" => NULL,
            "value" => $this->federation,
            "level" => Options::LEVEL_IDP,
            "row_id" => 0,
            "flag" => NULL];

        $this->name = $this->languageInstance->getLocalisedValue($this->getAttributes('general:instname'));
        $eligibility = $this->eligibility($instQuery->type);
        if (in_array(IdP::ELIGIBILITY_IDP, $eligibility) && in_array(IdP::ELIGIBILITY_SP, $eligibility)) {
            $eligType = IdP::TYPE_IDPSP . "";
            $this->type = $eligType;
        } elseif (in_array(IdP::ELIGIBILITY_IDP, $eligibility)) {
            $eligType = IdP::TYPE_IDP . "";
        } else {
            $eligType = IdP::TYPE_SP . "";
        }
        $this->type = $eligType;
        $this->loggerInstance->debug(4, "--- END Constructing new IdP object $instId ... ---\n");
    }

    /**
     * This function retrieves all registered profiles for this IdP from the database
     *
     * @param bool $activeOnly if and set to non-zero will cause listing of only those institutions which have some valid profiles defined.
     * @return \core\AbstractProfile[] list of Profiles of this IdP
     */
    public function listProfiles(bool $activeOnly = FALSE)
    {
        $query = "SELECT profile_id FROM profile WHERE inst_id = $this->identifier" . ($activeOnly ? " AND showtime = 1" : "")." ORDER BY preference";
        $allProfiles = $this->databaseHandle->exec($query);
        $returnarray = [];
        // SELECT -> resource, not boolean
        while ($profileQuery = mysqli_fetch_object(/** @scrutinizer ignore-type */ $allProfiles)) {
            $oneProfile = ProfileFactory::instantiate($profileQuery->profile_id, $this);
            $oneProfile->institution = $this->identifier;
            $returnarray[] = $oneProfile;
        }

        $this->loggerInstance->debug(4, "listProfiles: " . /** @scrutinizer ignore-type */ print_r($returnarray, true));
        return $returnarray;
    }

    /**
     * This function retrieves all SP deployments for this organisation from the database
     *
     * @param bool $activeOnly if and set to non-zero will cause listing of only those institutions which have some valid profiles defined.
     * @return \core\AbstractDeployment[] list of deployments of this IdP
     */
    public function listDeployments(bool $activeOnly = FALSE, $deploymentId = null)
    {
        $deploymentSelect = '';
        if ($deploymentId !== null) {
            $deploymentSelect = " AND deployment_id = '$deploymentId'";
        }
        $query = "SELECT deployment_id FROM deployment WHERE inst_id = $this->identifier".$deploymentSelect.($activeOnly ? " AND status = ".AbstractDeployment::ACTIVE : "");
        $allDeployments = $this->databaseHandle->exec($query);
        $returnarray = [];
        // SELECT -> resource, not boolean
        while ($deploymentQuery = mysqli_fetch_object(/** @scrutinizer ignore-type */ $allDeployments)) {
            $returnarray[] = new DeploymentManaged($this, $deploymentQuery->deployment_id);
        }

        $this->loggerInstance->debug(4, "listDeployments: " . /** @scrutinizer ignore-type */ print_r($returnarray, true));
        return $returnarray;
    }

    const PROFILES_INCOMPLETE = 0;
    const PROFILES_CONFIGURED = 1;
    const PROFILES_SHOWTIME = 2;
    const PROFILES_REDIRECTED = 3;
    const DEPLOYMENTS_NONE = -1;
    const DEPLOYMENTS_INACTIVE = 0;
    const DEPLOYMENTS_ACTIVE = 1;
    
    const PROFILES_INDEX = [
        self::PROFILES_INCOMPLETE => 'PROFILES_INCOMPLETE',
        self::PROFILES_CONFIGURED => 'PROFILES_CONFIGURED',
        self::PROFILES_SHOWTIME => 'PROFILES_SHOWTIME',
        self::PROFILES_REDIRECTED => 'PROFILES_REDIRECTED',
    ];

    /**
     * looks through all the profiles of the inst and determines the highest prod-ready level among the profiles
     * @return int highest level of completeness of all the profiles of the inst or PROFILES_REDIRECTED if all profiles are redirected
     */
    
    public function maxProfileStatus()
    {
        $redirectProfileIds = [];
        $allProfileLevels = $this->databaseHandle->exec("SELECT profile_id, sufficient_config + showtime AS maxlevel FROM profile WHERE inst_id = $this->identifier ORDER BY maxlevel DESC");
        // SELECT yields a resource, not a boolean
        if ($allProfileLevels->num_rows == 0 ) {
            return self::PROFILES_INCOMPLETE;
        }
        $allProfilesArray = $allProfileLevels->fetch_all(MYSQLI_ASSOC);
        $max_level = $allProfilesArray[0]['maxlevel'];        
        $redirectProfiles = $this->databaseHandle->exec("SELECT profile.profile_id as profile_id FROM profile JOIN profile_option ON profile.profile_id=profile_option.profile_id WHERE inst_id = $this->identifier AND profile.showtime=1 AND option_name='device-specific:redirect' AND device_id IS NULL");
        while ($res = $redirectProfiles->fetch_object()) {
            $redirectProfileIds[] = $res->profile_id;
        }        
        foreach ($allProfilesArray as $profile) {
            if (!in_array($profile['profile_id'], $redirectProfileIds)) {
                return($max_level);
            }            
        }
        return self::PROFILES_REDIRECTED;
    }
    
    /**
     * looks through deployments of the inst and determines the highest deployment status
     * @return int the highest level of completeness (-1 none defined, 0 non active, 1 active) 
     */
    public function maxDeploymentStatus()
    {
        $allDeployments = $this->databaseHandle->exec("SELECT MAX(status) as status FROM deployment WHERE inst_id = $this->identifier");
        $res = $allDeployments->fetch_object();
        if ($res->status === null) {
            return self::DEPLOYMENTS_NONE;
        }
        return $res->status;
    }

    /**
     * looks through all the profiles of the inst and determines the highest 
     * participation/conformance level for OpenRoaming
     * 
     * @return int highest level of completeness of all the profiles of the inst
     */
    public function maxOpenRoamingStatus()
    {
        $allProfiles = $this->databaseHandle->exec("SELECT MIN(openroaming) AS maxlevel FROM profile WHERE inst_id = $this->identifier");
        // SELECT yields a resource, not a boolean
        while ($res = mysqli_fetch_object(/** @scrutinizer ignore-type */ $allProfiles)) {
            return (is_numeric($res->maxlevel) ? (int)$res->maxlevel : AbstractProfile::OVERALL_OPENROAMING_LEVEL_NO ); // insts without profiles should get a "NO"
        }
        return AbstractProfile::OVERALL_OPENROAMING_LEVEL_NO;
    }
    
    
    /** This function retrieves an array of authorised users which can
     * manipulate this institution.
     * 
     * @return array owners of the institution; numbered array with members ID, MAIL and LEVEL
     */
    public function listOwners()
    {
        $returnarray = [];
        $admins = $this->databaseHandle->exec("SELECT user_id, orig_mail, blesslevel FROM ownership WHERE institution_id = $this->identifier ORDER BY user_id");
        // SELECT -> resource, not boolean
        while ($ownerQuery = mysqli_fetch_object(/** @scrutinizer ignore-type */ $admins)) {
            $returnarray[] = ['ID' => $ownerQuery->user_id, 'MAIL' => $ownerQuery->orig_mail, 'LEVEL' => $ownerQuery->blesslevel];
        }
        return $returnarray;
    }

    /**
     * Primary owners are allowed to invite other (secondary) admins to the institution
     * 
     * @param string $user ID of a logged-in user
     * @return boolean TRUE if this user is an admin with FED-level blessing
     */
    public function isPrimaryOwner($user)
    {
        foreach ($this->listOwners() as $oneOwner) {
            if ($oneOwner['ID'] == $user && $oneOwner['LEVEL'] == "FED") {
                return TRUE;
            }
        }
        return FALSE;
    }

    /**
     * This function gets the profile count for a given IdP.
     * 
     * The count could be retrieved from the listProfiles method
     * but this is less expensive.
     *
     * @return int profile count
     */
    public function profileCount()
    {
        $result = $this->databaseHandle->exec("SELECT profile_id FROM profile 
             WHERE inst_id = $this->identifier");
        // SELECT -> resource, not boolean
        $numberOfRows = mysqli_num_rows(/** @scrutinizer ignore-type */ $result);
        if (is_string($numberOfRows)) {
            throw new Exception("Number of profiles > PHP_MAX_INT?");
        }
        return $numberOfRows;
    }

    /**
     * This function gets the deployment count for a given IdP.
     *
     * @return int deployment count
     */
    public function deploymentCount()
    {
        $result = $this->databaseHandle->exec("SELECT deployment_id FROM deployment
             WHERE inst_id = $this->identifier");
        // SELECT -> resource, not boolean
        $numberOfRows = mysqli_num_rows(/** @scrutinizer ignore-type */ $result);
        if (is_string($numberOfRows)) {
            throw new Exception("Number of deployments > PHP_MAX_INT?");
        }
        return $numberOfRows;
    }

    const ELIGIBILITY_IDP = "IdP";
    const ELIGIBILITY_SP = "SP";

    /**
     * checks whether the participant is an IdP, an SP, or both.
     * 
     * @return array list of eligibilities
     */
    public function eligibility($type)
    {
        switch ($type) {
            case "IdP":
                return [IdP::ELIGIBILITY_IDP];
            case "SP":
                return [IdP::ELIGIBILITY_SP];
            default:
                return [IdP::ELIGIBILITY_IDP, IdP::ELIGIBILITY_SP];
        }
    }

    /**
     * This function sets the timestamp of last modification of the child profiles to the current timestamp.
     * 
     * This is needed for installer caching: all installers which are on disk 
     * must be re-created if an attribute changes. This timestamp here
     * is used to determine if the installer on disk is still new enough.
     * 
     * @return void
     */
    public function updateFreshness()
    {
        // freshness is always defined for *Profiles*
        // IdP needs to update timestamp of all its profiles if an IdP-wide attribute changed
        $this->databaseHandle->exec("UPDATE profile SET last_change = CURRENT_TIMESTAMP WHERE inst_id = '$this->identifier'");
    }

    /**
     * Adds a new profile to this IdP.
     * 
     * Only creates the DB entry for the Profile. If you want to add attributes later, see Profile::addAttribute().
     *
     * @param string $type exactly "RADIUS" or "SILVERBULLET", all other values throw an Exception
     * @return AbstractProfile|NULL new Profile object if successful, or NULL if an error occurred
     * @throws Exception
     */
    public function newProfile(string $type)
    {
        $this->databaseHandle->exec("INSERT INTO profile (inst_id) VALUES($this->identifier)");
        $identifier = $this->databaseHandle->lastID();
        if ($identifier > 0) {
            switch ($type) {
                case AbstractProfile::PROFILETYPE_RADIUS:
                    return new ProfileRADIUS($identifier, $this);
                case AbstractProfile::PROFILETYPE_SILVERBULLET:
                    $theProfile = new ProfileSilverbullet($identifier, $this);
                    $theProfile->addSupportedEapMethod(new \core\common\EAP(\core\common\EAP::EAPTYPE_SILVERBULLET), 1);
                    $theProfile->setRealm($this->identifier . "-" . $theProfile->identifier . "." . strtolower($this->federation) . strtolower(\config\ConfAssistant::SILVERBULLET['realm_suffix']));
                    return $theProfile;
                default:
                    throw new Exception("This type of profile is unknown and can not be added.");
            }
        }
        return NULL;
    }

    /**
     * Adds a new hotspot deployment to this IdP.
     * 
     * Only creates the DB entry for the deployment. If you want to add attributes later, see Profile::addAttribute().
     *
     * @param string $type       exactly "RADIUS-SP" or "MANAGED-SP", all other values throw an Exception
     * @param string $consortium name of the consortium to attach this *Managed* SP to
     * @return DeploymentManaged the newly created deployment
     * @throws Exception
     */
    public function newDeployment(string $type, string $consortium = "eduroam")
    {
        switch ($type) {
            case AbstractDeployment::DEPLOYMENTTYPE_CLASSIC:
                // classic deployment exist in the eduroam DB. We don't do anything here.
                throw new Exception("This type of deployment is handled externally and requesting it here makes no sense.");
            case AbstractDeployment::DEPLOYMENTTYPE_MANAGED:
                $this->databaseHandle->exec("INSERT INTO deployment (inst_id) VALUES($this->identifier)");
                $identifier = $this->databaseHandle->lastID();
                return new DeploymentManaged($this, $identifier, $consortium);
            default:
                throw new Exception("This type of deployment is unknown and can not be added.");
        }
    }

    /**
     * deletes the IdP and all its profiles
     * 
     * @return void
     * @throws Exception
     */
    public function destroy()
    {
        common\Entity::intoThePotatoes();
        /* delete all profiles */
        foreach ($this->listProfiles() as $profile) {
            $profile->destroy();
        }
        /* double-check that all profiles are gone */
        $profiles = $this->listProfiles();

        if (count($profiles) > 0) {
            throw new Exception("This IdP shouldn't have any profiles any more!");
        }

        $this->databaseHandle->exec("DELETE FROM ownership WHERE institution_id = $this->identifier");
        $this->databaseHandle->exec("DELETE FROM institution_option WHERE institution_id = $this->identifier");
        $this->databaseHandle->exec("DELETE FROM institution WHERE inst_id = $this->identifier");

        // notify federation admins
        if (\config\Master::MAILSETTINGS['notify_nro']) {
            $fed = new Federation($this->federation);
            foreach ($fed->listFederationAdmins() as $id) {
                $user = new User($id);
                $message = sprintf(_("Hi,

    the %s %s in your %s federation %s has been deleted from %s.

    We thought you might want to know.

    Best regards,

    %s"), common\Entity::$nomenclature_participant, $this->name, \config\ConfAssistant::CONSORTIUM['display_name'], strtoupper($fed->name), \config\Master::APPEARANCE['productname'], \config\Master::APPEARANCE['productname_long']);
                $user->sendMailToUser(sprintf(_("%s in your federation was deleted"), common\Entity::$nomenclature_participant), $message);
            }
        }
        common\Entity::outOfThePotatoes();
    }

    /**
     * Performs a lookup in an external database to determine matching entities to this IdP. 
     * 
     * The business logic of this function is roaming consortium specific; if no match algorithm is known for the consortium, FALSE is returned.
     * 
     * @param string $type which type of entity are you looking for?
     * @return array list of entities in external database that correspond to this IdP
     */
    public function getExternalDBSyncCandidates($type)
    {
        $usedarray = [];
        $matchingCandidates = [];
        $syncstate = self::EXTERNAL_DB_SYNCSTATE_SYNCED;
        $alreadyUsed = $this->databaseHandle->exec("SELECT DISTINCT external_db_id, country FROM institution WHERE external_db_id IS NOT NULL AND external_db_syncstate = ?", "i", $syncstate);
        // SELECT -> resource, not boolean
        while ($alreadyUsedQuery = mysqli_fetch_object(/** @scrutinizer ignore-type */ $alreadyUsed)) {
            $usedarray[] = $alreadyUsedQuery->external_db_id;
        }
        if (\config\ConfAssistant::CONSORTIUM['name'] == "eduroam" && isset(\config\ConfAssistant::CONSORTIUM['deployment-voodoo']) && \config\ConfAssistant::CONSORTIUM['deployment-voodoo'] == "Operations Team") { // SW: APPROVED
            // extract all institutions from the country
            $list = [];
            $lowerFed = strtolower($this->federation);
            $eduroamDb = new ExternalEduroamDBData();
            $candidateList = $eduroamDb->listExternalEntities($lowerFed, $type);
            // and split them into ID, LANG, NAME pairs (operating on a resource, not boolean)
            foreach ($candidateList as $oneCandidate) {
                if (in_array($oneCandidate['ID'], $usedarray)) {
                    continue;
                }
                $list[] = $oneCandidate;
            }
            // now see if any of the languages in CAT match the best one we have got from DB
            $mynames = $this->getAttributes("general:instname");
            foreach ($mynames as $onename) {
                foreach ($list as $listentry) {
                    if ($onename['value'] == $listentry['name'] && array_search($listentry['ID'], $matchingCandidates) === FALSE) {
                        $matchingCandidates[] = $listentry['ID'];
                    }
                }
            }
        }
        return $matchingCandidates;
    }

    /**
     * returns the state of sync with the external DB.
     * 
     * @return int
     */
    public function getExternalDBSyncState()
    {
        if (\config\ConfAssistant::CONSORTIUM['name'] == "eduroam" && isset(\config\ConfAssistant::CONSORTIUM['deployment-voodoo']) && \config\ConfAssistant::CONSORTIUM['deployment-voodoo'] == "Operations Team") { // SW: APPROVED
            return $this->externalDbSyncstate;
        }
        return self::EXTERNAL_DB_SYNCSTATE_NOTSUBJECTTOSYNCING;
    }

    /**
     * Retrieves the external DB identifier of this institution. Returns FALSE if no ID is known.
     * 
     * @return object|boolean the external identifier; or FALSE if no external ID is known
     */
    public function getExternalDBId()
    {
        if (\config\ConfAssistant::CONSORTIUM['name'] == "eduroam" && isset(\config\ConfAssistant::CONSORTIUM['deployment-voodoo']) && \config\ConfAssistant::CONSORTIUM['deployment-voodoo'] == "Operations Team") { // SW: APPROVED
            $idQuery = $this->databaseHandle->exec("SELECT external_db_id, country FROM institution WHERE inst_id = $this->identifier AND external_db_syncstate = " . self::EXTERNAL_DB_SYNCSTATE_SYNCED);
            // SELECT -> it's a resource, not a boolean
            if (mysqli_num_rows(/** @scrutinizer ignore-type */ $idQuery) == 0) {
                return FALSE;
            }
            $externalIdQuery = mysqli_fetch_object(/** @scrutinizer ignore-type */ $idQuery);
            $externalIdQuery->ROid = strtoupper($externalIdQuery->country).'01';
            return $externalIdQuery;
        }
        return FALSE;
    }

    /**
     * Associates the external DB id with a CAT id
     * 
     * @param string $identifier the external DB id, which can be alphanumeric
     * @param string $country federation identifier in the eduroam DB
     * @return void
     */
    public function setExternalDBId(string $identifier, $country)
    {
        if (\config\ConfAssistant::CONSORTIUM['name'] == "eduroam" && isset(\config\ConfAssistant::CONSORTIUM['deployment-voodoo']) && \config\ConfAssistant::CONSORTIUM['deployment-voodoo'] == "Operations Team") { // SW: APPROVED
            $syncState = self::EXTERNAL_DB_SYNCSTATE_SYNCED;
            $alreadyUsed = $this->databaseHandle->exec("SELECT DISTINCT external_db_id FROM institution WHERE country = ? AND external_db_id = ? AND external_db_syncstate = ?", "ssi", $country, $identifier, $syncState);
            // SELECT -> resource, not boolean
            if (mysqli_num_rows(/** @scrutinizer ignore-type */ $alreadyUsed) == 0) {
                $this->databaseHandle->exec("UPDATE institution SET external_db_id = ?, external_db_syncstate = ? WHERE inst_id = ?", "sii", $identifier, $syncState, $this->identifier);
            }
        }
    }

    /**
     * removes the link between a CAT institution and the external DB
     * 
     * @return void
     */
    public function removeExternalDBId()
    {
        if (\config\ConfAssistant::CONSORTIUM['name'] == "eduroam" && isset(\config\ConfAssistant::CONSORTIUM['deployment-voodoo']) && \config\ConfAssistant::CONSORTIUM['deployment-voodoo'] == "Operations Team") { // SW: APPROVED
            if ($this->getExternalDBId() !== FALSE) {
                $syncState = self::EXTERNAL_DB_SYNCSTATE_NOT_SYNCED;
                $this->databaseHandle->exec("UPDATE institution SET external_db_id = NULL, external_db_syncstate = ? WHERE inst_id = ?", "ii", $syncState, $this->identifier);
            }
        }
    }

    public const INSTNAME_CHANGED = 1;

    /**
     * 
     * @param IdP $old the IdP instance with the old state
     * @param IdP $new the IdP instance with the new state
     * @return array list of changed things, and details about the change
     */
    public static function significantChanges($old, $new)
    {
        // check if the name of the inst was changed (in any language)
        $retval = [];
        $baseline = [];
        $newvalues = [];
        foreach ($old->getAttributes("general:instname") as $oldname) {
            $baseline[$oldname['lang']] = $oldname['value'];
        }
        foreach ($new->getAttributes("general:instname") as $newname) {
            $newvalues[$newname['lang']] = $newname['value'];
        }
        foreach ($baseline as $lang => $value) {
            if (!key_exists($lang, $newvalues)) {
                $retval[IdP::INSTNAME_CHANGED] .= "#[Language " . strtoupper($lang) . "] DELETED";
            } else {
                if ($value != $newvalues[$lang]) {
                    $retval[IdP::INSTNAME_CHANGED] .= "#[Language " . strtoupper($lang) . "] CHANGED from '" . $baseline[$lang] . "' to '" . $newvalues[$lang] . "'";
                }
            }
        }
        foreach ($newvalues as $lang => $value) {
            if (!key_exists($lang, $baseline)) {
                $retval[IdP::INSTNAME_CHANGED] .= "#[Language " . strtoupper($lang) . "] ADDED as '" . $value . "'";
            }
        }
        return $retval;
    }
}