Passed
Push — release_2_0 ( c174a1...0e4618 )
by Stefan
07:01
created
web/diag/adminQuery.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  * License: see the web/copyright.inc.php file in the file structure or
20 20
  *          <base_url>/copyright.php after deploying the software
21 21
  */
22
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
23 23
 $languageInstance = new \core\common\Language();
24 24
 $languageInstance->setTextDomain("diagnostics");
25 25
 
@@ -56,119 +56,119 @@  discard block
 block discarded – undo
56 56
     $select = "<div id='sp_abuse_problem'>
57 57
 <select style='margin-left: 0px;' id='select_sp_problem'>";
58 58
     foreach ($sp_problem as $pname => $pdesc) {
59
-        $select = $select . "<option value='$pname'>$pdesc</option>\n";
59
+        $select = $select."<option value='$pname'>$pdesc</option>\n";
60 60
     }
61
-    $select = $select . "</select></div>";
61
+    $select = $select."</select></div>";
62 62
     $res = "
63 63
 <table id='sp_questions'>
64 64
     <tr>
65
-        <td>" . _("Select your problem") . "</td>
65
+        <td>" . _("Select your problem")."</td>
66 66
         <td>$select</td>
67 67
     </tr>
68 68
     <tr>
69
-        <td>" . _("What is the realm of the IdP in question?") . "</td>
69
+        <td>"._("What is the realm of the IdP in question?")."</td>
70 70
         <td>
71 71
                 <input type='text' name='admin_realm' id='admin_realm' value=''>
72 72
                 <button id='realm_in_db_admin' accesskey='R' type='button'>" .
73
-            _("Check if this value is registered") .
73
+            _("Check if this value is registered").
74 74
             "</button>
75 75
         </td>
76 76
     </tr>
77 77
     <tr class='hidden_row'>
78
-        <td>" . _("What is the authentication timestamp of the user session in question?") . "</td>
78
+        <td>" . _("What is the authentication timestamp of the user session in question?")."</td>
79 79
         <td><input type='text' id='timestamp' name='timestamp'>
80 80
             <div id='datepicker'></div>
81 81
         </td>
82 82
     </tr>
83 83
     <tr class='hidden_row'>
84
-        <td>" . _("What is the MAC address of the user session in question?") . "</td>
84
+        <td>" . _("What is the MAC address of the user session in question?")."</td>
85 85
         <td><input type='text' id='mac' name='mac'></td>
86 86
     </tr>
87 87
     <tr class='hidden_row'>
88
-        <td>" . _("Additional comments") . "</td>
88
+        <td>" . _("Additional comments")."</td>
89 89
         <td><textarea id='freetext' name='freetext' cols='60' rows='5'></textarea></td>
90 90
     </tr>
91 91
     <tr class='hidden_row'>
92
-        <td>" . _("Please specify an email address on which the IdP can contact you") . "</td>
92
+        <td>" . _("Please specify an email address on which the IdP can contact you")."</td>
93 93
         <td><input type='text' id='email' name='email'></td>
94 94
     </tr>
95 95
     <tr class='hidden_row' id='send_query_to_idp'>
96
-        <td>" . _("Now you can send your query") . "</td>
97
-        <td><button type='submit' id='submit_idp_query' name='go'>" . _("Send") . "</button></td>
96
+        <td>" . _("Now you can send your query")."</td>
97
+        <td><button type='submit' id='submit_idp_query' name='go'>" . _("Send")."</button></td>
98 98
     </tr>
99 99
  </table>";
100
-    $res = $res . $javascript;
100
+    $res = $res.$javascript;
101 101
 }
102 102
 if ($queryType == 'idp') {
103 103
     $select = "<div id='idp_reported_problem' style='display:;'>
104 104
 <select style='margin-left:0px;' id='select_idp_problem'>";
105 105
     foreach ($idp_problem as $pname => $pdesc) {
106
-        $select = $select . "<option value='$pname'>$pdesc</option>\n";
106
+        $select = $select."<option value='$pname'>$pdesc</option>\n";
107 107
     }
108
-    $select = $select . "</select></div>";
108
+    $select = $select."</select></div>";
109 109
     $res = "
110 110
 <table id='idp_questions'>
111 111
     <tr>
112
-        <td>" . _("Select your problem") . "</td>
112
+        <td>" . _("Select your problem")."</td>
113 113
         <td>$select</td>
114 114
     </tr>
115 115
     <tr>
116
-        <td>" . _("Identify the SP by one of following means") . "</td>
116
+        <td>"._("Identify the SP by one of following means")."</td>
117 117
         <td></td>
118 118
     </tr>
119 119
     <tr id='by_opname'>
120
-        <td>" . _("SP Operator-Name attribute") . "</td>
120
+        <td>" . _("SP Operator-Name attribute")."</td>
121 121
         <td><input type='text' id='opname' name='opname' value=''></td>
122 122
     </tr>
123 123
     <tr id='spmanually'>
124
-        <td>" . _("Select the SP manually:") . "</td>
124
+        <td>" . _("Select the SP manually:")."</td>
125 125
         <td>
126 126
             <div id='select_asp_country'><a href='' id='asp_countries_list'>
127
-            <span id='opnameselect'>" . _("click to select country and organisation") . "</a></span>
127
+            <span id='opnameselect'>" . _("click to select country and organisation")."</a></span>
128 128
             </div>
129 129
             <div id='select_asp_area'></div>
130 130
         </td>
131 131
     </tr>
132 132
     <tr id='asp_desc' style='display: none;'>
133
-        <td>" . _("or") . ' ' . _("at least describe the SP location") . "</td>
133
+        <td>" . _("or").' '._("at least describe the SP location")."</td>
134 134
         <td><input type='text' id='asp_location' name='asp_location' value=''></td>
135 135
     </tr>
136 136
     <tr>
137
-        <td>" . _("What is the outer ID of the user session in question?") . "</td>
137
+        <td>" . _("What is the outer ID of the user session in question?")."</td>
138 138
         <td><input type='text' id='outer_id' name='outer_id' value=''></td>
139 139
     </tr>
140 140
     <tr>
141
-        <td>" . _("What is the authentication timestamp of the user session in question?") . "</td>
141
+        <td>" . _("What is the authentication timestamp of the user session in question?")."</td>
142 142
         <td>
143 143
             <input type='text' id='timestamp' name='timestamp'>
144 144
             <div id='datepicker'></div>
145 145
         </td>
146 146
     </tr>
147 147
     <tr>
148
-        <td>" . _("What is the MAC address of the user session in question?") . "</td>
148
+        <td>" . _("What is the MAC address of the user session in question?")."</td>
149 149
         <td><input type='text' id='mac' name='mac'></td>
150 150
     </tr>
151 151
     <tr>
152
-        <td>" . _("Additional comments about the problem") . "</td>
152
+        <td>" . _("Additional comments about the problem")."</td>
153 153
         <td><textarea id='freetext' name='freetext' cols='60' rows='5'></textarea></td>
154 154
     </tr>
155 155
     <tr>
156
-        <td>" . _("Do you have any contact details by which the user wishes to be contacted by the SP?") . "</td>
156
+        <td>" . _("Do you have any contact details by which the user wishes to be contacted by the SP?")."</td>
157 157
         <td><textarea id='c_details' name='c_details' cols='60' rows='5'></textarea></td>
158 158
     </tr>
159 159
     <tr>
160
-        <td>" . _("Please specify an email address on which the SP can contact you") . "</td>
160
+        <td>" . _("Please specify an email address on which the SP can contact you")."</td>
161 161
         <td><input type='text' id='email' name='email'></td>
162 162
     </tr>
163 163
     <tr class='hidden_row' id='send_query_to_sp'>
164
-        <td>" . _("Now you can send your query") . "</td>
165
-        <td><button type='submit' id='submit_sp_query' name='go'>" . _("Send") . "</button></td>
164
+        <td>" . _("Now you can send your query")."</td>
165
+        <td><button type='submit' id='submit_sp_query' name='go'>" . _("Send")."</button></td>
166 166
     </tr>
167 167
 </table>";
168
-    $res = $res . $javascript;
168
+    $res = $res.$javascript;
169 169
 }
170 170
 if ($queryType == 'idp_send' || $queryType == 'sp_send') {
171
-    include_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
171
+    include_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
172 172
     $cat = new \core\CAT();
173 173
     $returnArray = array();
174 174
     if (count((array) $o) > 0) {
Please login to merge, or discard this patch.
web/404.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  * @package UserGUI
27 27
  */
28 28
 error_reporting(E_ALL | E_STRICT);
29
-require dirname(dirname(__FILE__)) . "/config/_config.php";
29
+require dirname(dirname(__FILE__))."/config/_config.php";
30 30
 $langObject = new \core\common\Language();
31 31
 $langObject->setTextDomain("web_user");
32 32
 
@@ -38,25 +38,25 @@  discard block
 block discarded – undo
38 38
 <body style='background: #fff url(resources/images/bg_grey_tile.png) repeat-x;'>
39 39
     <div id="heading">
40 40
         <?php
41
-        print '<img src="'. dirname($_SERVER['SCRIPT_NAME']) .'/resources/images/consortium_logo.png" alt="Consortium Logo" style="float:right; padding-right:20px; padding-top:20px"/>';
42
-        print '<div id="motd">' . ( isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp' ) . '</div>';
43
-        print '<h1 style="padding-bottom:0px; height:1em;">' . sprintf(_("Welcome to %s"), CONFIG['APPEARANCE']['productname']) . '</h1>
44
-<h2 style="padding-bottom:0px; height:0px; vertical-align:bottom;">' . CONFIG['APPEARANCE']['productname_long'] . '</h2>';
41
+        print '<img src="'.dirname($_SERVER['SCRIPT_NAME']).'/resources/images/consortium_logo.png" alt="Consortium Logo" style="float:right; padding-right:20px; padding-top:20px"/>';
42
+        print '<div id="motd">'.(isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp').'</div>';
43
+        print '<h1 style="padding-bottom:0px; height:1em;">'.sprintf(_("Welcome to %s"), CONFIG['APPEARANCE']['productname']).'</h1>
44
+<h2 style="padding-bottom:0px; height:0px; vertical-align:bottom;">' . CONFIG['APPEARANCE']['productname_long'].'</h2>';
45 45
         echo '<table id="lang_select"><tr><td>';
46 46
         echo _("View this page in");
47 47
         ?>
48 48
         <?php
49 49
         foreach (CONFIG['LANGUAGES'] as $lang => $value) {
50
-            echo "<a href='javascript:changeLang(\"$lang\")'>" . $value['display'] . "</a> ";
50
+            echo "<a href='javascript:changeLang(\"$lang\")'>".$value['display']."</a> ";
51 51
         }
52
-        echo '</td><td style="text-align:right;padding-right:20px"><a href="' . dirname($_SERVER['SCRIPT_NAME']) . '?lang=' . $langObject->getLang() . '">' . _("Start page") . '</a></td></tr></table>';
52
+        echo '</td><td style="text-align:right;padding-right:20px"><a href="'.dirname($_SERVER['SCRIPT_NAME']).'?lang='.$langObject->getLang().'">'._("Start page").'</a></td></tr></table>';
53 53
         ?>
54 54
     </div> <!-- id="heading" -->
55 55
     <div id="main_body" style='padding:20px;'>
56
-        <h1><?php echo _("This is not the CAT you are looking for.");?></h1>
57
-        <p><?php echo _("Whatever you expected to see at this URL - it's not here. The only thing here is the number");?></p>
56
+        <h1><?php echo _("This is not the CAT you are looking for."); ?></h1>
57
+        <p><?php echo _("Whatever you expected to see at this URL - it's not here. The only thing here is the number"); ?></p>
58 58
         <h2>404</h2>
59
-        <p><?php echo sprintf(_("staring at you. Your mistake? Our error? Who knows! Maybe you should go back to the <a href='%s'>Start Page</a>."), dirname($_SERVER['SCRIPT_NAME']) . '?lang=' . $langObject->getLang());?></p>
59
+        <p><?php echo sprintf(_("staring at you. Your mistake? Our error? Who knows! Maybe you should go back to the <a href='%s'>Start Page</a>."), dirname($_SERVER['SCRIPT_NAME']).'?lang='.$langObject->getLang()); ?></p>
60 60
     </div> <!-- id="main_body" -->
61 61
 
62 62
         <?php echo $deco->footer();
Please login to merge, or discard this patch.
web/resources/css/cat.css.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
22
+require dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
23 23
 $colour1 = CONFIG['APPEARANCE']['colour1'];
24 24
 $colour2 = CONFIG['APPEARANCE']['colour2'];
25 25
 header('Content-type: text/css; charset=utf-8');
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 }
30 30
 
31 31
 body {
32
-    background: <?php echo $colour1;?>;
32
+    background: <?php echo $colour1; ?>;
33 33
     color: #000000;
34 34
     font-family:Verdana, Arial, Helvetica, sans-serif;
35 35
     font-size:11px;
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 }
45 45
 
46 46
 button {
47
-    background: <?php echo $colour2;?>; 
47
+    background: <?php echo $colour2; ?>; 
48 48
     color: #FFFFFF; 
49 49
     min-height: 23px;
50 50
     border-left-style: outset; 
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
 
396 396
 span.edu_cat {
397 397
     font-weight: bold;
398
-    color: <?php echo $colour2;?>;
398
+    color: <?php echo $colour2; ?>;
399 399
 }
400 400
 
401 401
 span.tooltip {
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
     border-bottom-style:solid;
492 492
     border-top-width:5px; 
493 493
     border-bottom-width:5px; 
494
-    border-color: <?php echo $colour1;?>; 
494
+    border-color: <?php echo $colour1; ?>; 
495 495
     padding-left:30px;
496 496
 }
497 497
 
@@ -561,7 +561,7 @@  discard block
 block discarded – undo
561 561
 }
562 562
 
563 563
 #close_button {
564
-    background: <?php echo $colour2;?>; 
564
+    background: <?php echo $colour2; ?>; 
565 565
     color: #FFFFFF; 
566 566
     height: 23px;
567 567
     border-left-style: inset; 
@@ -636,7 +636,7 @@  discard block
 block discarded – undo
636 636
     width: 30em; 
637 637
     padding-left: 10px; 
638 638
     padding-right: 0px; 
639
-    background: <?php echo $colour2;?>; 
639
+    background: <?php echo $colour2; ?>; 
640 640
     color: white; 
641 641
     box-shadow: 10px 10px 5px #888888;
642 642
 }
@@ -683,7 +683,7 @@  discard block
 block discarded – undo
683 683
     padding-top: 4px; 
684 684
     padding-bottom: 12px; 
685 685
     padding-left: 30px; 
686
-    background: <?php echo $colour1;?>; 
686
+    background: <?php echo $colour1; ?>; 
687 687
     text-align: left; 
688 688
     text-shadow: 10px 10px 5px #888888;
689 689
 }
@@ -693,9 +693,9 @@  discard block
 block discarded – undo
693 693
     border-bottom-style:solid;
694 694
     border-top-width:5px;
695 695
     border-bottom-width:5px;
696
-    border-color: <?php echo $colour1;?>;
696
+    border-color: <?php echo $colour1; ?>;
697 697
     padding-left:30px;
698
-    color: <?php echo $colour2;?>;
698
+    color: <?php echo $colour2; ?>;
699 699
 }
700 700
 
701 701
 #heading h1 { 
@@ -714,7 +714,7 @@  discard block
 block discarded – undo
714 714
     text-align: justify;
715 715
     border-bottom-style:solid;
716 716
     border-bottom-width:5px;
717
-    border-color: <?php echo $colour1;?>;
717
+    border-color: <?php echo $colour1; ?>;
718 718
     font-size: 11px;
719 719
     font-weight: normal;
720 720
 }
@@ -761,7 +761,7 @@  discard block
 block discarded – undo
761 761
 
762 762
 #faq {
763 763
     padding: 20px;
764
-    color: <?php echo $colour2;?>;
764
+    color: <?php echo $colour2; ?>;
765 765
     background: #ffffff;
766 766
 }
767 767
 
@@ -813,7 +813,7 @@  discard block
 block discarded – undo
813 813
 
814 814
 #line1 {
815 815
     top:145px;
816
-    color: <?php echo $colour2;?>;
816
+    color: <?php echo $colour2; ?>;
817 817
     font-size:20px;
818 818
 }
819 819
 
@@ -860,7 +860,7 @@  discard block
 block discarded – undo
860 860
 
861 861
 #front_page_leftmenu {
862 862
     border-right:solid; 
863
-    border-color: <?php echo $colour1;?>; 
863
+    border-color: <?php echo $colour1; ?>; 
864 864
     border-width:5px; 
865 865
     min-height:400px; 
866 866
     padding-left: 10px; 
@@ -885,11 +885,11 @@  discard block
 block discarded – undo
885 885
 }
886 886
 
887 887
 a:link {
888
-    color:<?php echo $colour2;?>;
888
+    color:<?php echo $colour2; ?>;
889 889
 }
890 890
 
891 891
 a:visited {
892
-    color:<?php echo $colour2;?>;
892
+    color:<?php echo $colour2; ?>;
893 893
 }
894 894
 
895 895
 a:hover {
@@ -897,7 +897,7 @@  discard block
 block discarded – undo
897 897
 }
898 898
 
899 899
 a:active {
900
-    color:<?php echo $colour2;?>;
900
+    color:<?php echo $colour2; ?>;
901 901
 }
902 902
 
903 903
 .comment {
Please login to merge, or discard this patch.
web/lib/user/Skinjob.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -95,17 +95,17 @@
 block discarded – undo
95 95
         }
96 96
 
97 97
         // does the file exist in the current skin's directory? Has precedence
98
-        if ($submodule !== '' && file_exists(__DIR__ . "/../../skins/" . $this->skin . "/" . $submodule . $path . $filename)) {
99
-            $extrapath = "/skins/" . $this->skin . "/" . $submodule;
98
+        if ($submodule !== '' && file_exists(__DIR__."/../../skins/".$this->skin."/".$submodule.$path.$filename)) {
99
+            $extrapath = "/skins/".$this->skin."/".$submodule;
100 100
         }
101
-        elseif (file_exists(__DIR__ . "/../../skins/" . $this->skin . $path . $filename)) {
102
-            $extrapath = "/skins/" . $this->skin;
103
-        } elseif (file_exists(__DIR__ . "/../../" . $path . $filename)) {
101
+        elseif (file_exists(__DIR__."/../../skins/".$this->skin.$path.$filename)) {
102
+            $extrapath = "/skins/".$this->skin;
103
+        } elseif (file_exists(__DIR__."/../../".$path.$filename)) {
104 104
             $extrapath = "";
105 105
         } else {
106 106
             return FALSE;
107 107
         }       
108
-        return htmlspecialchars(\core\CAT::getRootUrlPath() . $extrapath . $path . $filename, ENT_QUOTES);
108
+        return htmlspecialchars(\core\CAT::getRootUrlPath().$extrapath.$path.$filename, ENT_QUOTES);
109 109
     }
110 110
 
111 111
 }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -97,8 +97,7 @@
 block discarded – undo
97 97
         // does the file exist in the current skin's directory? Has precedence
98 98
         if ($submodule !== '' && file_exists(__DIR__ . "/../../skins/" . $this->skin . "/" . $submodule . $path . $filename)) {
99 99
             $extrapath = "/skins/" . $this->skin . "/" . $submodule;
100
-        }
101
-        elseif (file_exists(__DIR__ . "/../../skins/" . $this->skin . $path . $filename)) {
100
+        } elseif (file_exists(__DIR__ . "/../../skins/" . $this->skin . $path . $filename)) {
102 101
             $extrapath = "/skins/" . $this->skin;
103 102
         } elseif (file_exists(__DIR__ . "/../../" . $path . $filename)) {
104 103
             $extrapath = "";
Please login to merge, or discard this patch.
web/lib/user/Gui.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,10 +53,10 @@
 block discarded – undo
53 53
         $ourlocale = $this->langObject->getLang();
54 54
         header("Content-Type:text/html;charset=utf-8");
55 55
         echo "<!DOCTYPE html>
56
-          <html xmlns='http://www.w3.org/1999/xhtml' lang='" . $ourlocale . "'>
57
-          <head lang='" . $ourlocale . "'>
56
+          <html xmlns='http://www.w3.org/1999/xhtml' lang='" . $ourlocale."'>
57
+          <head lang='" . $ourlocale."'>
58 58
           <meta http-equiv='Content-Type' content='text/html; charset=UTF-8'>";
59
-        echo "<title>" . htmlspecialchars($pagetitle) . "</title>";
59
+        echo "<title>".htmlspecialchars($pagetitle)."</title>";
60 60
         echo '<script type="text/javascript">ie_version = 0;</script>
61 61
 <!--[if IE]>
62 62
 <script type="text/javascript">ie_version=1;</script>
Please login to merge, or discard this patch.
web/lib/admin/PageDecoration.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -49,13 +49,13 @@  discard block
 block discarded – undo
49 49
         $retval = "<div class='sidebar'><p>";
50 50
 
51 51
         if ($advancedControls) {
52
-            $retval .= "<strong>" . _("You are:") . "</strong> ".$_SESSION['name']
52
+            $retval .= "<strong>"._("You are:")."</strong> ".$_SESSION['name']
53 53
             ."<br/>
54 54
               <br/>
55
-              <a href='" . \core\CAT::getRootUrlPath() . "/admin/overview_user.php'>" . _("Go to your Profile page") . "</a> 
56
-              <a href='" . \core\CAT::getRootUrlPath() . "/admin/inc/logout.php'>" . _("Logout") . "</a> ";
55
+              <a href='" . \core\CAT::getRootUrlPath()."/admin/overview_user.php'>"._("Go to your Profile page")."</a> 
56
+              <a href='" . \core\CAT::getRootUrlPath()."/admin/inc/logout.php'>"._("Logout")."</a> ";
57 57
         }
58
-        $retval .= "<a href='" . \core\CAT::getRootUrlPath() . "/'>" . _("Start page") . "</a>
58
+        $retval .= "<a href='".\core\CAT::getRootUrlPath()."/'>"._("Start page")."</a>
59 59
             </p>
60 60
         </div> <!-- sidebar -->";
61 61
         \core\common\Entity::outOfThePotatoes();
@@ -79,22 +79,22 @@  discard block
 block discarded – undo
79 79
                     <h1>$cap1</h1>
80 80
                 </div><!--header_captions-->
81 81
                 <div id='langselection' style='padding-top:20px; padding-left:10px;'>
82
-                    <form action='$place' method='GET' accept-charset='UTF-8'>" . _("View this page in") . "&nbsp;
82
+                    <form action='$place' method='GET' accept-charset='UTF-8'>"._("View this page in")."&nbsp;
83 83
                         <select id='lang' name='lang' onchange='this.form.submit()'>";
84 84
 
85 85
         foreach (CONFIG['LANGUAGES'] as $lang => $value) {
86
-            $retval .= "<option value='$lang' " . (strtoupper($language) == strtoupper($lang) ? "selected" : "" ) . " >" . $value['display'] . "</option> ";
86
+            $retval .= "<option value='$lang' ".(strtoupper($language) == strtoupper($lang) ? "selected" : "")." >".$value['display']."</option> ";
87 87
         }
88 88
         $retval .= "</select>";
89 89
 
90 90
         foreach ($_GET as $var => $value) {
91 91
             if ($var != "lang" && $value != "") {
92
-                $retval .= "<input type='hidden' name='" . htmlspecialchars($var) . "' value='" . htmlspecialchars($value) . "'>";
92
+                $retval .= "<input type='hidden' name='".htmlspecialchars($var)."' value='".htmlspecialchars($value)."'>";
93 93
             }
94 94
         }
95 95
         $retval .= "</form>
96 96
                 </div><!--langselection-->";
97
-        $logoUrl = \core\CAT::getRootUrlPath() . "/resources/images/consortium_logo.png";
97
+        $logoUrl = \core\CAT::getRootUrlPath()."/resources/images/consortium_logo.png";
98 98
         $retval .= "<div class='consortium_logo'>
99 99
                     <img id='test_locate' src='$logoUrl' alt='Consortium Logo'>
100 100
                 </div> <!-- consortium_logo -->
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 
188 188
         if (isset(CONFIG['APPEARANCE']['MOTD']) && CONFIG['APPEARANCE']['MOTD'] != "") {
189 189
             $retval .= "<div id='header_MOTD' style='display:inline-block; padding-left:20px;vertical-align:top;'>
190
-              <p class='MOTD'>" . CONFIG['APPEARANCE']['MOTD'] . "</p>
190
+              <p class='MOTD'>" . CONFIG['APPEARANCE']['MOTD']."</p>
191 191
               </div><!--header_MOTD-->";
192 192
         }
193 193
         $retval .= $this->sidebar($advancedControls);
@@ -213,9 +213,9 @@  discard block
 block discarded – undo
213 213
           <html xmlns='http://www.w3.org/1999/xhtml' lang='$ourlocale'>
214 214
           <head lang='$ourlocale'>
215 215
           <meta http-equiv='Content-Type' content='text/html; charset=UTF-8'>";
216
-        $cssUrl = \core\CAT::getRootUrlPath() . "/resources/css/cat.css.php";
216
+        $cssUrl = \core\CAT::getRootUrlPath()."/resources/css/cat.css.php";
217 217
         $retval .= "<link rel='stylesheet' type='text/css' href='$cssUrl' />";
218
-        $retval .= "<title>" . htmlspecialchars($pagetitle) . "</title>";
218
+        $retval .= "<title>".htmlspecialchars($pagetitle)."</title>";
219 219
         return $retval;
220 220
     }
221 221
 
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
             // we may need to jump up one dir if we are either in admin/ or accountstatus/
230 230
             // (accountstatus courtesy of my good mood. It's userspace not admin space so
231 231
             // it shouldn't be using this function any more.)
232
-            $logoBase = \core\CAT::getRootUrlPath() . "/resources/images";
232
+            $logoBase = \core\CAT::getRootUrlPath()."/resources/images";
233 233
             return "<span id='logos' style='position:fixed; left:50%;'><img src='$logoBase/dante.png' alt='DANTE' style='height:23px;width:47px'/>
234 234
               <img src='$logoBase/eu.png' alt='EU' style='height:23px;width:27px;border-width:0px;'/></span>
235 235
               <span id='eu_text' style='text-align:right;'><a href='http://ec.europa.eu/dgs/connect/index_en.htm' style='text-decoration:none; vertical-align:top;'>European Commission Communications Networks, Content and Technology</a></span>";
@@ -251,9 +251,9 @@  discard block
 block discarded – undo
251 251
             <table style='width:100%'>
252 252
                 <tr>
253 253
                     <td style='padding-left:20px; padding-right:20px; text-align:left; vertical-align:top;'>
254
-                        " . $cat->CAT_COPYRIGHT . "</td>";
254
+                        " . $cat->CAT_COPYRIGHT."</td>";
255 255
         if (!empty(CONFIG['APPEARANCE']['privacy_notice_url'])) {
256
-            $retval .= "<td><a href='".CONFIG['APPEARANCE']['privacy_notice_url']."'>" . sprintf(_("%s Privacy Notice"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) . "</a></td>";
256
+            $retval .= "<td><a href='".CONFIG['APPEARANCE']['privacy_notice_url']."'>".sprintf(_("%s Privacy Notice"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])."</a></td>";
257 257
         }
258 258
         $retval .= "            <td style='padding-left:80px; padding-right:20px; text-align:right; vertical-align:top;'>";
259 259
 
Please login to merge, or discard this patch.
web/lib/admin/Authentication.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 
24 24
 use Exception;
25 25
 
26
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
26
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
27 27
 require_once CONFIG['AUTHENTICATION']['ssp-path-to-autoloader'];
28 28
 
29 29
 /**
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         if ($trailerPosition !== FALSE) {
123 123
             $base = substr($scriptself, 0, $trailerPosition);
124 124
             if ($base !== FALSE) {
125
-                $url = "//$servername" . $base . "/logout_check.php";
125
+                $url = "//$servername".$base."/logout_check.php";
126 126
             }
127 127
         }
128 128
 
Please login to merge, or discard this patch.
web/lib/admin/MapNone.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
      */
84 84
     public function htmlShowtime($wizard = FALSE, $additional = FALSE) {
85 85
         if (!$this->readOnly) {
86
- //           return $this->htmlPreEdit($wizard, $additional) . $this->htmlPostEdit(TRUE);
86
+    //           return $this->htmlPreEdit($wizard, $additional) . $this->htmlPostEdit(TRUE);
87 87
             return $this->htmlPreEdit($wizard, $additional) . $this->findLocationHtml() . $this->htmlPostEdit(TRUE);
88 88
         }
89 89
     }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 namespace web\lib\admin;
23 23
 
24
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
24
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
25 25
 
26 26
 /**
27 27
  * This class provides map display functionality
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     public function htmlShowtime($wizard = FALSE, $additional = FALSE) {
85 85
         if (!$this->readOnly) {
86 86
  //           return $this->htmlPreEdit($wizard, $additional) . $this->htmlPostEdit(TRUE);
87
-            return $this->htmlPreEdit($wizard, $additional) . $this->findLocationHtml() . $this->htmlPostEdit(TRUE);
87
+            return $this->htmlPreEdit($wizard, $additional).$this->findLocationHtml().$this->htmlPostEdit(TRUE);
88 88
         }
89 89
     }
90 90
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
         // quiesce warnings about unused parameter
109 109
         sprintf("%d", $number);
110 110
         $pair = json_decode($coords, true);
111
-        return "<table><tr><td>Latitude</td><td><strong>" . $pair['lat'] . "</strong></td></tr><tr><td>Longitude</td><td><strong>" . $pair['lon'] . "</strong></td></tr></table>";
111
+        return "<table><tr><td>Latitude</td><td><strong>".$pair['lat']."</strong></td></tr><tr><td>Longitude</td><td><strong>".$pair['lon']."</strong></td></tr></table>";
112 112
     }
113 113
     
114 114
     /**
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
      */
119 119
     private function findLocationHtml() {
120 120
         \core\common\Entity::intoThePotatoes();
121
-        $retval = "<button type='button' onclick='locateMe()'>" . _("Locate Me!") . "</button></p>";
121
+        $retval = "<button type='button' onclick='locateMe()'>"._("Locate Me!")."</button></p>";
122 122
         \core\common\Entity::outOfThePotatoes();
123 123
         return $retval;
124 124
     }
Please login to merge, or discard this patch.
web/lib/admin/MapOpenLayers.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 
23 23
 namespace web\lib\admin;
24 24
 
25
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
25
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
26 26
 
27 27
 /**
28 28
  * This class provides map display functionality
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         
86 86
 // use HTML5 geolocation
87 87
         function locateMe() {
88
-            $('#address').val(\"" . _("locating") . "\");
88
+            $('#address').val(\"" . _("locating")."\");
89 89
             navigator.geolocation.getCurrentPosition(locate_succes,locate_fail,{maximumAge:3600000, timeout:5000});
90 90
         }
91 91
         
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
                 view.fit(extent, {padding: [10, 0, 10, 0]});
208 208
             } else {
209 209
                 view.setCenter([0,0]);
210
-                locate_country('" . $cat->knownFederations[strtoupper($this->fedName)] . "'); // use the federation code to locate the country
210
+                locate_country('" . $cat->knownFederations[strtoupper($this->fedName)]."'); // use the federation code to locate the country
211 211
                 map.setView(view);
212 212
             }
213 213
             view.setMaxZoom(20);
@@ -229,14 +229,14 @@  discard block
 block discarded – undo
229 229
         function getAddressLocation() {
230 230
             var city = $('#address').val();
231 231
             if(city == '') {
232
-                alert(\"" . _("nothing entered in the address field") . "\");
232
+                alert(\"" . _("nothing entered in the address field")."\");
233 233
                 return false;
234 234
             }
235 235
             city = city.replace(/\s*,\s*/g,',+');
236 236
             city = city.replace(/ +/,'+');
237 237
             $.get(addressService+'?format=json&addressdetails=0&q='+city, '',  function(data) {
238 238
                 if (data[0] === undefined) {
239
-                    alert('" . _("Address not found, perhaps try another form, like putting the street number to the front.") . "');
239
+                    alert('" . _("Address not found, perhaps try another form, like putting the street number to the front.")."');
240 240
                     return;
241 241
                 }
242 242
                 showTmpPointer(data[0].lon, data[0].lat);
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
         if ($this->readOnly) {
288 288
             return "<div id='map' class='locationmap'></div><script>generateMap('map')</script>";
289 289
         } else {
290
-            return $this->htmlPreEdit($wizard, $additional) . $this->findLocationHtml() . "<span id='location-prompt'>You can drag the pointer to the final location before you save the results.</span><div id='map' class='locationmap'></div><script>generateMap('map')</script>" . $this->htmlPostEdit(FALSE);
290
+            return $this->htmlPreEdit($wizard, $additional).$this->findLocationHtml()."<span id='location-prompt'>You can drag the pointer to the final location before you save the results.</span><div id='map' class='locationmap'></div><script>generateMap('map')</script>".$this->htmlPostEdit(FALSE);
291 291
         }
292 292
     }
293 293
 
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
      */
311 311
     public static function optionListDisplayCode($coords, $number) {
312 312
         \core\common\Entity::intoThePotatoes();
313
-        $retval = "<button id='location_b_" . $number . "' class='location_button'>" . _("Click to see location") . " $number</button>";
313
+        $retval = "<button id='location_b_".$number."' class='location_button'>"._("Click to see location")." $number</button>";
314 314
         \core\common\Entity::outOfThePotatoes();
315 315
         return $retval;
316 316
     }
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
      */
323 323
     private function findLocationHtml() {
324 324
         \core\common\Entity::intoThePotatoes();
325
-        $retval = "<p>" . _("Address:") . " <input name='address' id='address' /><button type='button' onclick='getAddressLocation()'>" . _("Find address") . "</button> <button type='button' onclick='locateMe()'>" . _("Locate Me!") . "</button></p>";
325
+        $retval = "<p>"._("Address:")." <input name='address' id='address' /><button type='button' onclick='getAddressLocation()'>"._("Find address")."</button> <button type='button' onclick='locateMe()'>"._("Locate Me!")."</button></p>";
326 326
         \core\common\Entity::outOfThePotatoes();
327 327
         return $retval;
328 328
     }
Please login to merge, or discard this patch.