GEANT /
CAT
| Total Complexity | 58 |
| Total Lines | 396 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like Federation often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Federation, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 55 | class Federation extends EntityWithDBProperties { |
||
| 56 | |||
| 57 | /** |
||
| 58 | * the handle to the FRONTEND database (only needed for some stats access) |
||
| 59 | * |
||
| 60 | * @var DBConnection |
||
| 61 | */ |
||
| 62 | private $frontendHandle; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * the top-level domain of the Federation |
||
| 66 | * |
||
| 67 | * @var string |
||
| 68 | */ |
||
| 69 | public $tld; |
||
| 70 | |||
| 71 | /** |
||
| 72 | * retrieve the statistics from the database in an internal array representation |
||
| 73 | * |
||
| 74 | * @return array |
||
| 75 | */ |
||
| 76 | private function downloadStatsCore() { |
||
| 77 | $grossAdmin = 0; |
||
| 78 | $grossUser = 0; |
||
| 79 | $grossSilverbullet = 0; |
||
| 80 | $dataArray = []; |
||
| 81 | // first, find out which profiles belong to this federation |
||
| 82 | $cohesionQuery = "SELECT downloads.device_id as dev_id, sum(downloads.downloads_user) as dl_user, sum(downloads.downloads_silverbullet) as dl_sb, sum(downloads.downloads_admin) as dl_admin FROM profile, institution, downloads WHERE profile.inst_id = institution.inst_id AND institution.country = ? AND profile.profile_id = downloads.profile_id group by device_id"; |
||
| 83 | $profilesList = $this->databaseHandle->exec($cohesionQuery, "s", $this->tld); |
||
| 84 | $deviceArray = \devices\Devices::listDevices(); |
||
| 85 | // SELECT -> resource, no boolean |
||
| 86 | while ($queryResult = mysqli_fetch_object(/** @scrutinizer ignore-type */ $profilesList)) { |
||
| 87 | if (isset($deviceArray[$queryResult->dev_id])) { |
||
| 88 | $displayName = $deviceArray[$queryResult->dev_id]['display']; |
||
| 89 | } else { // this device has stats, but doesn't exist in current config. We don't even know its display name, so display its raw representation |
||
| 90 | $displayName = sprintf(_("(discontinued) %s"), $queryResult->dev_id); |
||
| 91 | } |
||
| 92 | $dataArray[$displayName] = ["ADMIN" => $queryResult->dl_admin, "SILVERBULLET" => $queryResult->dl_sb, "USER" => $queryResult->dl_user]; |
||
| 93 | $grossAdmin = $grossAdmin + $queryResult->dl_admin; |
||
| 94 | $grossSilverbullet = $grossSilverbullet + $queryResult->dl_sb; |
||
| 95 | $grossUser = $grossUser + $queryResult->dl_user; |
||
| 96 | } |
||
| 97 | $dataArray["TOTAL"] = ["ADMIN" => $grossAdmin, "SILVERBULLET" => $grossSilverbullet, "USER" => $grossUser]; |
||
| 98 | return $dataArray; |
||
| 99 | } |
||
| 100 | |||
| 101 | /** |
||
| 102 | * when a Federation attribute changes, invalidate caches of all IdPs |
||
| 103 | * in that federation (e.g. change of fed logo changes the actual |
||
| 104 | * installers) |
||
| 105 | * |
||
| 106 | * @return void |
||
| 107 | */ |
||
| 108 | public function updateFreshness() { |
||
| 112 | } |
||
| 113 | } |
||
| 114 | |||
| 115 | /** |
||
| 116 | * gets the download statistics for the federation |
||
| 117 | * @param string $format either as an html *table* or *XML* or *JSON* |
||
| 118 | * @return string|array |
||
| 119 | */ |
||
| 120 | public function downloadStats($format) { |
||
| 121 | $data = $this->downloadStatsCore(); |
||
| 122 | $retstring = ""; |
||
| 123 | |||
| 124 | switch ($format) { |
||
| 125 | case "table": |
||
| 126 | foreach ($data as $device => $numbers) { |
||
| 127 | if ($device == "TOTAL") { |
||
| 128 | continue; |
||
| 129 | } |
||
| 130 | $retstring .= "<tr><td>$device</td><td>" . $numbers['ADMIN'] . "</td><td>" . $numbers['SILVERBULLET'] . "</td><td>" . $numbers['USER'] . "</td></tr>"; |
||
| 131 | } |
||
| 132 | $retstring .= "<tr><td><strong>TOTAL</strong></td><td><strong>" . $data['TOTAL']['ADMIN'] . "</strong></td><td><strong>" . $data['TOTAL']['SILVERBULLET'] . "</strong></td><td><strong>" . $data['TOTAL']['USER'] . "</strong></td></tr>"; |
||
| 133 | break; |
||
| 134 | case "XML": |
||
| 135 | // the calls to date() operate on current date, so there is no chance for a FALSE to be returned. Silencing scrutinizer. |
||
| 136 | $retstring .= "<federation id='$this->tld' ts='" . /** @scrutinizer ignore-type */ date("Y-m-d") . "T" . /** @scrutinizer ignore-type */ date("H:i:s") . "'>\n"; |
||
| 137 | foreach ($data as $device => $numbers) { |
||
| 138 | if ($device == "TOTAL") { |
||
| 139 | continue; |
||
| 140 | } |
||
| 141 | $retstring .= " <device name='" . $device . "'>\n <downloads group='admin'>" . $numbers['ADMIN'] . "</downloads>\n <downloads group='managed_idp'>" . $numbers['SILVERBULLET'] . "</downloads>\n <downloads group='user'>" . $numbers['USER'] . "</downloads>\n </device>"; |
||
| 142 | } |
||
| 143 | $retstring .= "<total>\n <downloads group='admin'>" . $data['TOTAL']['ADMIN'] . "</downloads>\n <downloads group='managed_idp'>" . $data['TOTAL']['SILVERBULLET'] . "</downloads>\n <downloads group='user'>" . $data['TOTAL']['USER'] . "</downloads>\n</total>\n"; |
||
| 144 | $retstring .= "</federation>"; |
||
| 145 | break; |
||
| 146 | case "array": |
||
| 147 | return $data; |
||
| 148 | default: |
||
| 149 | throw new Exception("Statistics can be requested only in 'table' or 'XML' format!"); |
||
| 150 | } |
||
| 151 | |||
| 152 | return $retstring; |
||
| 153 | } |
||
| 154 | |||
| 155 | /** |
||
| 156 | * |
||
| 157 | * Constructs a Federation object. |
||
| 158 | * |
||
| 159 | * @param string $fedname textual representation of the Federation object |
||
| 160 | * Example: "lu" (for Luxembourg) |
||
| 161 | */ |
||
| 162 | public function __construct($fedname) { |
||
| 210 | } |
||
| 211 | |||
| 212 | /** |
||
| 213 | * Creates a new IdP inside the federation. |
||
| 214 | * |
||
| 215 | * @param string $type type of institution - IdP, SP or IdPSP |
||
| 216 | * @param string $ownerId Persistent identifier of the user for whom this IdP is created (first administrator) |
||
| 217 | * @param string $level Privilege level of the first administrator (was he blessed by a federation admin or a peer?) |
||
| 218 | * @param string $mail e-mail address with which the user was invited to administer (useful for later user identification if the user chooses a "funny" real name) |
||
| 219 | * @param string $bestnameguess name of the IdP, if already known, in the best-match language |
||
| 220 | * @return int identifier of the new IdP |
||
| 221 | */ |
||
| 222 | public function newIdP($type, $ownerId, $level, $mail = NULL, $bestnameguess = NULL) { |
||
| 223 | $this->databaseHandle->exec("INSERT INTO institution (country, type) VALUES('$this->tld', '$type')"); |
||
| 224 | $identifier = $this->databaseHandle->lastID(); |
||
| 225 | |||
| 226 | if ($identifier == 0 || !$this->loggerInstance->writeAudit($ownerId, "NEW", "IdP $identifier")) { |
||
| 227 | $text = "<p>Could not create a new " . CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_inst'] . "!</p>"; |
||
| 228 | echo $text; |
||
| 229 | throw new Exception($text); |
||
| 230 | } |
||
| 231 | |||
| 232 | if ($ownerId != "PENDING") { |
||
| 233 | if ($mail === NULL) { |
||
| 234 | throw new Exception("New IdPs in a federation need a mail address UNLESS created by API without OwnerId"); |
||
| 235 | } |
||
| 236 | $this->databaseHandle->exec("INSERT INTO ownership (user_id,institution_id, blesslevel, orig_mail) VALUES(?,?,?,?)", "siss", $ownerId, $identifier, $level, $mail); |
||
| 237 | } |
||
| 238 | if ($bestnameguess === NULL) { |
||
| 239 | $bestnameguess = "(no name yet, identifier $identifier)"; |
||
| 240 | } |
||
| 241 | $admins = $this->listFederationAdmins(); |
||
| 242 | |||
| 243 | // notify the fed admins... |
||
| 244 | |||
| 245 | foreach ($admins as $id) { |
||
| 246 | $user = new User($id); |
||
| 247 | /// arguments are: 1. nomenclature for "institution" |
||
| 248 | // 2. IdP name; |
||
| 249 | /// 3. consortium name (e.g. eduroam); |
||
| 250 | /// 4. federation shortname, e.g. "LU"; |
||
| 251 | /// 5. product name (e.g. eduroam CAT); |
||
| 252 | /// 6. product long name (e.g. eduroam Configuration Assistant Tool) |
||
| 253 | $message = sprintf(_("Hi, |
||
| 254 | |||
| 255 | the invitation for the new %s %s in your %s federation %s has been used and the IdP was created in %s. |
||
| 256 | |||
| 257 | We thought you might want to know. |
||
| 258 | |||
| 259 | Best regards, |
||
| 260 | |||
| 261 | %s"), common\Entity::$nomenclature_inst, $bestnameguess, CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], strtoupper($this->tld), CONFIG['APPEARANCE']['productname'], CONFIG['APPEARANCE']['productname_long']); |
||
| 262 | $retval = $user->sendMailToUser(sprintf(_("%s in your federation was created"), common\Entity::$nomenclature_inst), $message); |
||
| 263 | if ($retval === FALSE) { |
||
| 264 | $this->loggerInstance->debug(2, "Mail to federation admin was NOT sent!\n"); |
||
| 265 | } |
||
| 266 | } |
||
| 267 | |||
| 268 | return $identifier; |
||
| 269 | } |
||
| 270 | |||
| 271 | private $idpListAll; |
||
| 272 | private $idpListActive; |
||
| 273 | |||
| 274 | /** |
||
| 275 | * Lists all Identity Providers in this federation |
||
| 276 | * |
||
| 277 | * @param int $activeOnly if set to non-zero will list only those institutions which have some valid profiles defined. |
||
| 278 | * @return array (Array of IdP instances) |
||
| 279 | * |
||
| 280 | */ |
||
| 281 | public function listIdentityProviders($activeOnly = 0) { |
||
| 282 | // maybe we did this exercise before? |
||
| 283 | if ($activeOnly != 0 && count($this->idpListActive) > 0) { |
||
| 284 | return $this->idpListActive; |
||
| 285 | } |
||
| 286 | if ($activeOnly == 0 && count($this->idpListAll) > 0) { |
||
| 287 | return $this->idpListAll; |
||
| 288 | } |
||
| 289 | // default query is: |
||
| 290 | $allIDPs = $this->databaseHandle->exec("SELECT inst_id FROM institution |
||
| 291 | WHERE country = '$this->tld' ORDER BY inst_id"); |
||
| 292 | // the one for activeOnly is much more complex: |
||
| 293 | if ($activeOnly) { |
||
| 294 | $allIDPs = $this->databaseHandle->exec("SELECT distinct institution.inst_id AS inst_id |
||
| 295 | FROM institution |
||
| 296 | JOIN profile ON institution.inst_id = profile.inst_id |
||
| 297 | WHERE institution.country = '$this->tld' |
||
| 298 | AND profile.showtime = 1 |
||
| 299 | ORDER BY inst_id"); |
||
| 300 | } |
||
| 301 | |||
| 302 | $returnarray = []; |
||
| 303 | // SELECT -> resource, not boolean |
||
| 304 | while ($idpQuery = mysqli_fetch_object(/** @scrutinizer ignore-type */ $allIDPs)) { |
||
| 305 | $idp = new IdP($idpQuery->inst_id); |
||
| 306 | $name = $idp->name; |
||
| 307 | $idpInfo = ['entityID' => $idp->identifier, |
||
| 308 | 'title' => $name, |
||
| 309 | 'country' => strtoupper($idp->federation), |
||
| 310 | 'instance' => $idp]; |
||
| 311 | $returnarray[$idp->identifier] = $idpInfo; |
||
| 312 | } |
||
| 313 | if ($activeOnly != 0) { // we're only doing this once. |
||
| 314 | $this->idpListActive = $returnarray; |
||
| 315 | } else { |
||
| 316 | $this->idpListAll = $returnarray; |
||
| 317 | } |
||
| 318 | return $returnarray; |
||
| 319 | } |
||
| 320 | |||
| 321 | /** |
||
| 322 | * returns an array with information about the authorised administrators of the federation |
||
| 323 | * |
||
| 324 | * @return array list of the admins of this federation |
||
| 325 | */ |
||
| 326 | public function listFederationAdmins() { |
||
| 341 | } |
||
| 342 | |||
| 343 | /** |
||
| 344 | * cross-checks in the EXTERNAL customer DB which institutions exist there for the federations |
||
| 345 | * |
||
| 346 | * @param bool $unmappedOnly if set to TRUE, only returns those which do not have a known mapping to our internally known institutions |
||
| 347 | * @return array |
||
| 348 | */ |
||
| 349 | public function listExternalEntities($unmappedOnly) { |
||
| 383 | } |
||
| 384 | |||
| 385 | const UNKNOWN_IDP = -1; |
||
| 386 | const AMBIGUOUS_IDP = -2; |
||
| 387 | |||
| 388 | /** |
||
| 389 | * for a MySQL list of institutions, find an institution or find out that |
||
| 390 | * there is no single best match |
||
| 391 | * |
||
| 392 | * @param \mysqli_result $dbResult the query object to work with |
||
| 393 | * @param string $country used to return the country of the inst, if can be found out |
||
| 394 | * @return int the identifier of the inst, or one of the special return values if unsuccessful |
||
| 395 | */ |
||
| 396 | private static function findCandidates(\mysqli_result $dbResult, &$country) { |
||
| 412 | } |
||
| 413 | |||
| 414 | /** |
||
| 415 | * If we are running diagnostics, our input from the user is the realm. We |
||
| 416 | * need to find out which IdP this realm belongs to. |
||
| 417 | * @param string $realm the realm to search for |
||
| 418 | * @return array an array with two entries, CAT ID and DB ID, with either the respective ID of the IdP in the system, or UNKNOWN_IDP or AMBIGUOUS_IDP |
||
| 419 | */ |
||
| 420 | public static function determineIdPIdByRealm($realm) { |
||
| 441 | } |
||
| 442 | |||
| 443 | /** |
||
| 444 | * helper function to sort institutions by their name |
||
| 445 | * @param array $a an array with institution a's information |
||
| 446 | * @param array $b an array with institution b's information |
||
| 447 | * @return int the comparison result |
||
| 448 | */ |
||
| 449 | private function usortInstitution($a, $b) { |
||
| 454 |
Loading history...
This check looks for function or method calls that always return null and whose return value is assigned to a variable.
The method
getObject()can return nothing but null, so it makes no sense to assign that value to a variable.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.