Test Failed
Push — master ( 239970...076b28 )
by Tomasz
10:54
created
core/Federation.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
         $result = $this->databaseHandle->exec($query);
455 455
         $rows = $result->fetch_all();
456 456
         foreach ($rows as $row) {
457
-           $activeProfiles[] = $row[0];
457
+            $activeProfiles[] = $row[0];
458 458
         }
459 459
         $query = "SELECT institution.inst_id AS inst_id, profile.profile_id AS profile_id, profile_option.option_value AS cert FROM profile_option JOIN profile ON profile_option.profile_id=profile.profile_id JOIN institution ON profile.inst_id=institution.inst_id WHERE profile_option.option_name='eap:ca_file' and institution.country='".$this->tld."'";        
460 460
         $result = $this->databaseHandle->exec($query);
@@ -531,7 +531,7 @@  discard block
 block discarded – undo
531 531
                 'country' => strtoupper($idp->federation),
532 532
                 'instance' => $idp,
533 533
                 'realms' => $idpQuery->realms]
534
-                 ;
534
+                    ;
535 535
             $returnarray[$idp->identifier] = $idpInfo;
536 536
         }
537 537
         if ($activeOnly != 0) { // we're only doing this once.
Please login to merge, or discard this patch.
web/diag/radius_tests.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -374,7 +374,7 @@
 block discarded – undo
374 374
         throw new Exception("Unknown test requested: default case reached!");
375 375
 }
376 376
 $returnarray['datetime'] = date("Y-m-d H:i:s");
377
-if ($token!= '' && is_dir($jsonDir.'/'.$token)) {
377
+if ($token != '' && is_dir($jsonDir.'/'.$token)) {
378 378
     @mkdir($jsonDir.'/'.$token, 0777, true);
379 379
 }
380 380
 $json_data = json_encode($returnarray);
Please login to merge, or discard this patch.
web/admin/overview_federation.php 2 patches
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -424,17 +424,17 @@  discard block
 block discarded – undo
424 424
                 }
425 425
                 echo "<td class='inst_td'>
426 426
                          <input type='hidden' name='inst' value='" 
427
-                       . $index."'>"
428
-                       . "<span style='display:none' class='inst_name'>".$my_idp."</span>"
429
-                       . "<span>". $idp_instance->name."</span>"
430
-                       . " (<a href='overview_org.php?inst_id="
431
-                       . $idp_instance->identifier."'>" 
432
-                       . (in_array($index, $userIdps) ? _("manage") : _("view"))
433
-                       . "</a>)"
434
-                       . (empty($listOfSilverbulletRealms) ? "" : "<ul><li>" ) 
435
-                       . implode("</li><li>", $listOfSilverbulletRealms) 
436
-                       . (empty($listOfSilverbulletRealms) ? "" : "</li><ul>" )
437
-                       . "</td>";
427
+                        . $index."'>"
428
+                        . "<span style='display:none' class='inst_name'>".$my_idp."</span>"
429
+                        . "<span>". $idp_instance->name."</span>"
430
+                        . " (<a href='overview_org.php?inst_id="
431
+                        . $idp_instance->identifier."'>" 
432
+                        . (in_array($index, $userIdps) ? _("manage") : _("view"))
433
+                        . "</a>)"
434
+                        . (empty($listOfSilverbulletRealms) ? "" : "<ul><li>" ) 
435
+                        . implode("</li><li>", $listOfSilverbulletRealms) 
436
+                        . (empty($listOfSilverbulletRealms) ? "" : "</li><ul>" )
437
+                        . "</td>";
438 438
                 // deployment status; need to dive into profiles for this
439 439
                 // show happy eyeballs if at least one profile is configured/showtime                    
440 440
                 echo  "<td>$profileIcon</td>";
@@ -489,8 +489,8 @@  discard block
 block discarded – undo
489 489
                             echo "<form method='post' action='overview_federation.php' accept-charset='UTF-8'>
490 490
                                 <input type='hidden' name='invitation_id' value='".$oneinvite['token']."'/>
491 491
                                 <button class='delete' type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_DELETE."'>"._("Revoke Invitation")."</button> "
492
-                           . sprintf(_("(expires %s)"), $oneinvite['expiry'])
493
-                           . "</form>";
492
+                            . sprintf(_("(expires %s)"), $oneinvite['expiry'])
493
+                            . "</form>";
494 494
                         }
495 495
                         echo "      </td>";                          
496 496
                         echo "         </tr>";
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     <?php
98 98
     foreach ($cat->printCountryList(1) as $country => $name) {
99 99
         $selected = '';
100
-        if ($country == strtoupper($fed_id) ) {
100
+        if ($country == strtoupper($fed_id)) {
101 101
             $selected = 'selected';
102 102
         }
103 103
     echo "<option value='$country' $selected>$name</option>\n";
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
             /// nomenclature for 'federation', federation name, nomenclature for 'inst'
316 316
             echo "<tr><td colspan='9'><strong>".sprintf(_("The following %s are in your %s %s:"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed, '<span style="color:green">'.$thefed->name.'</span>')."</strong></td></tr>";
317 317
             echo "<tbody class='fedlist'>";
318
-            echo "<tr><td colspan='1'><strong>". _("Quick search:")." </strong><input style='background:#eeeeee;' type='text' id='qsearch_".$fedId."'></td>";
318
+            echo "<tr><td colspan='1'><strong>"._("Quick search:")." </strong><input style='background:#eeeeee;' type='text' id='qsearch_".$fedId."'></td>";
319 319
             echo "<td style='border-bottom-style: dotted;border-bottom-width: 1px;'><input type='checkbox' name='profilecheck' id='profile_ck_".$fedId."'></td>";
320 320
             echo "<td style='border-bottom-style: dotted;border-bottom-width: 1px;'><input type='checkbox' name='orcheck' id='or_ck_".$fedId."'></td>";
321 321
             echo "<td style='border-bottom-style: dotted;border-bottom-width: 1px;'><input type='checkbox' name='brokencert' id='brokencert_ck_".$fedId."'></td>";
@@ -428,14 +428,14 @@  discard block
 block discarded – undo
428 428
                          <input type='hidden' name='inst' value='" 
429 429
                        . $index."'>"
430 430
                        . "<span style='display:none' class='inst_name'>".$my_idp."</span>"
431
-                       . "<span>". $idp_instance->name."</span>"
431
+                       . "<span>".$idp_instance->name."</span>"
432 432
                        . " (<a href='overview_org.php?inst_id="
433 433
                        . $idp_instance->identifier."'>" 
434 434
                        . (in_array($index, $userIdps) ? _("manage") : _("view"))
435 435
                        . "</a>)"
436
-                       . (empty($listOfSilverbulletRealms) ? "" : "<ul><li>" ) 
436
+                       . (empty($listOfSilverbulletRealms) ? "" : "<ul><li>") 
437 437
                        . implode("</li><li>", $listOfSilverbulletRealms) 
438
-                       . (empty($listOfSilverbulletRealms) ? "" : "</li><ul>" )
438
+                       . (empty($listOfSilverbulletRealms) ? "" : "</li><ul>")
439 439
                        . "</td>";
440 440
                 // deployment status; need to dive into profiles for this
441 441
                 // show happy eyeballs if at least one profile is configured/showtime                    
Please login to merge, or discard this patch.
web/admin/edit_federation.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 $auth = new \web\lib\admin\Authentication();
32 32
 $deco = new \web\lib\admin\PageDecoration();
@@ -70,13 +70,13 @@  discard block
 block discarded – undo
70 70
         ?>
71 71
     </h1>
72 72
     <div class='infobox'>
73
-        <h2><?php $tablecaption = sprintf(_("%s Properties"),$uiElements->nomenclatureFed); echo $tablecaption?></h2>
73
+        <h2><?php $tablecaption = sprintf(_("%s Properties"), $uiElements->nomenclatureFed); echo $tablecaption?></h2>
74 74
         <table>
75
-            <caption><?php echo $tablecaption;?></caption>
75
+            <caption><?php echo $tablecaption; ?></caption>
76 76
             <tr>
77
-                <th class="wai-invisible" scope="col"><?php echo _("Property Type");?></th>
78
-                <th class="wai-invisible" scope="col"><?php echo _("Language if applicable");?></th>
79
-                <th class="wai-invisible" scope="col"><?php echo _("Property Value");?></th>
77
+                <th class="wai-invisible" scope="col"><?php echo _("Property Type"); ?></th>
78
+                <th class="wai-invisible" scope="col"><?php echo _("Language if applicable"); ?></th>
79
+                <th class="wai-invisible" scope="col"><?php echo _("Property Value"); ?></th>
80 80
             </tr>
81 81
             <tr>
82 82
                 <td><?php echo _("Country:"); ?></td>
@@ -87,11 +87,11 @@  discard block
 block discarded – undo
87 87
         </table>
88 88
     </div>
89 89
     <?php
90
-    echo "<form enctype='multipart/form-data' action='edit_federation_result.php?fed_id=$my_fed->tld" . "' method='post' accept-charset='UTF-8'>
91
-              <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::MAX_UPLOAD_SIZE . "'>";
90
+    echo "<form enctype='multipart/form-data' action='edit_federation_result.php?fed_id=$my_fed->tld"."' method='post' accept-charset='UTF-8'>
91
+              <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::MAX_UPLOAD_SIZE."'>";
92 92
     ?>
93 93
     <fieldset class="option_container">
94
-        <legend><strong><?php echo sprintf(_("%s Properties"),$uiElements->nomenclatureFed); ?></strong></legend>
94
+        <legend><strong><?php echo sprintf(_("%s Properties"), $uiElements->nomenclatureFed); ?></strong></legend>
95 95
         <?php
96 96
         $optionDisplay = new \web\lib\admin\OptionDisplay($fed_options, \core\Options::LEVEL_FED);
97 97
         echo $optionDisplay->prefilledOptionTable("fed", $my_fed->tld);
@@ -101,10 +101,10 @@  discard block
 block discarded – undo
101 101
     <?php
102 102
     echo "<div>";
103 103
     if ($editMode === 'fullaccess') {
104
-        echo "<button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_SAVE . "'>" . _("Save data") . "</button>";
104
+        echo "<button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_SAVE."'>"._("Save data")."</button>";
105 105
         $discardLabel = _("Discard changes");
106 106
     } else {
107 107
         $discardLabel = _("Return");
108 108
     }
109
-    echo "<button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_federation.php?fed_id=$fedPost\"'>" . $discardLabel . "</button></div></form>";
109
+    echo "<button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_federation.php?fed_id=$fedPost\"'>".$discardLabel."</button></div></form>";
110 110
     echo $deco->footer();
Please login to merge, or discard this patch.
utils/test_openroaming.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
  * License: see the web/copyright.php file in the file structure
9 9
  * ******************************************************************************
10 10
  */
11
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
11
+require_once dirname(dirname(__FILE__))."/config/_config.php";
12 12
 
13 13
 /**
14 14
  * The sctipt will be called from crontab
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 }
29 29
 
30 30
 
31
-while ( $row = mysqli_fetch_object(/** @scrutinizer ignore-type */ $allOpenRoamingProfiles)) {
31
+while ($row = mysqli_fetch_object(/** @scrutinizer ignore-type */ $allOpenRoamingProfiles)) {
32 32
     $profileId = $row->profile_id;
33 33
     $profile = \core\ProfileFactory::instantiate($profileId);
34 34
     $res = $profile->openroamingRedinessTest();
Please login to merge, or discard this patch.
utils/update_monitor_copy.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
  * update the local copy
25 25
  */
26 26
 
27
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
27
+require_once dirname(dirname(__FILE__))."/config/_config.php";
28 28
 setlocale(LC_CTYPE, "en_US.UTF-8");
29 29
 
30 30
 class updateFromMonitor {
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
         $tmp_table = 'tmp_'.$table_name;
114 114
         if ($this->tablesource[$table_name] == 'eduroam') {
115 115
             $this->db_local->select_db('monitor_copy');
116
-        } elseif($this->tablesource[$table_name] == 'eduroamv2') {
116
+        } elseif ($this->tablesource[$table_name] == 'eduroamv2') {
117 117
             $this->db_local->select_db('eduroamv2');
118 118
         }
119 119
         $this->db_local->query("CREATE TEMPORARY TABLE $tmp_table SELECT * FROM $table LIMIT 0");
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         $this->db->query("SET NAMES 'utf8'");
123 123
         $this->db_local->query("SET NAMES 'utf8mb4'");
124 124
         $result = $this->db->query("SELECT * FROM $table");
125
-        $queryFields = implode(',', array_column($this->fields[$table_name],0));
125
+        $queryFields = implode(',', array_column($this->fields[$table_name], 0));
126 126
         while ($row = $result->fetch_assoc()) {
127 127
             $v = [];
128 128
             foreach ($this->fields[$table_name] as $field) {
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
                     }
141 141
                 }
142 142
             }
143
-            $queryValues = implode(',',$v);
143
+            $queryValues = implode(',', $v);
144 144
             $query = "INSERT INTO $tmp_table (".$queryFields.") VALUES (".$queryValues.")";
145 145
             $this->db_local->query($query);
146 146
         }
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         $tmp_table = 'tmp_'.$table_name;
153 153
         if ($this->tablesource[$table_name] == 'eduroam') {
154 154
                 $this->db_local->select_db('monitor_copy');
155
-        } elseif($this->tablesource[$table_name] == 'eduroamv2') {
155
+        } elseif ($this->tablesource[$table_name] == 'eduroamv2') {
156 156
                 $this->db_local->select_db('eduroamv2');
157 157
         }
158 158
         $this->db_local->query("SET NAMES 'utf8mb4'");
@@ -161,9 +161,9 @@  discard block
 block discarded – undo
161 161
     }
162 162
 
163 163
     private function escape($inp) {
164
-        $out=str_replace('\\','\\\\',$inp);
165
-        $out=str_replace('"','\"',$out);
166
-        $out=str_replace('?','\?',$out);
164
+        $out = str_replace('\\', '\\\\', $inp);
165
+        $out = str_replace('"', '\"', $out);
166
+        $out = str_replace('?', '\?', $out);
167 167
         $out = 'convert(cast(convert("'.$out.'" using latin1) as binary) using utf8)';
168 168
         return($out);
169 169
     }
Please login to merge, or discard this patch.
web/diag/magicTelepath.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,10 +19,10 @@
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(__DIR__)) . "/config/_config.php";
22
+require_once dirname(dirname(__DIR__))."/config/_config.php";
23 23
 $realm = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'realm')));
24
-$visited = htmlspecialchars(strip_tags(filter_input(INPUT_GET,'visited')));
25
-$nro = htmlspecialchars(strip_tags(filter_input(INPUT_GET,'nro')));
24
+$visited = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'visited')));
25
+$nro = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'nro')));
26 26
 \core\CAT::sessionStart();
27 27
 $languageObject = new core\common\Language();
28 28
 $languageObject->setTextDomain("diagonstics");
Please login to merge, or discard this patch.
web/diag/testTelepath.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(__DIR__)) . "/config/_config.php";
22
+require_once dirname(dirname(__DIR__))."/config/_config.php";
23 23
 
24 24
 $therealm = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'realm')));
25 25
 $thevisited = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'visited')));
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     $validator = new \web\lib\common\InputValidation();
36 36
     
37 37
     echo "<pre>";
38
-    echo "Testing " . $validatedRealm . " in " . $validator->string($thevisited);
38
+    echo "Testing ".$validatedRealm." in ".$validator->string($thevisited);
39 39
     print_r($telepath->magic());
40 40
     echo "</pre>";
41 41
 }
42 42
\ No newline at end of file
Please login to merge, or discard this patch.
web/accountstatus/accountstatus.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  * @author Stefan Winter <[email protected]>
27 27
  * @package Core
28 28
  */
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 $cleanToken = FALSE;
32 32
 $invitationObject = new core\SilverbulletInvitation("INVALID");
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 
75 75
 $statusInfo = ["token" => $cleanToken,
76 76
     "invitation_object" => $invitationObject,
77
-    "OS" => $Gui->operatingSystem,];
77
+    "OS" => $Gui->operatingSystem, ];
78 78
 
79 79
 if ($profile !== NULL) {
80 80
     $attributes = $Gui->profileAttributes($profile->identifier);
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 $caAndSerial = htmlspecialchars(strip_tags($caAndSerialUnfiltered));
89 89
 
90 90
 if ($action !== NULL && $action !== FALSE && $action === \web\lib\common\FormElements::BUTTON_DELETE && $caAndSerial !== NULL && $caAndSerial !== FALSE) {
91
-    $tuple = explode(':',$caAndSerial);
91
+    $tuple = explode(':', $caAndSerial);
92 92
     $ca_type = $tuple[0];
93 93
     $serial = $tuple[1];
94 94
     if ($statusInfo['invitation_object']->invitationTokenStatus != \core\SilverbulletInvitation::SB_TOKENSTATUS_INVALID) {
@@ -103,12 +103,12 @@  discard block
 block discarded – undo
103 103
                 print "//REVOKING\n";
104 104
                 $certObject = new \core\SilverbulletCertificate($serial, $ca_type);
105 105
                 $certObject->revokeCertificate();
106
-                header("Location: accountstatus.php?token=" . $statusInfo['token']);
106
+                header("Location: accountstatus.php?token=".$statusInfo['token']);
107 107
                 exit;
108 108
             }
109 109
         }
110 110
     }
111
-    header("Location: accountstatus.php?token=" . $statusInfo['token']);
111
+    header("Location: accountstatus.php?token=".$statusInfo['token']);
112 112
     exit;
113 113
 }
114 114
 
@@ -133,4 +133,4 @@  discard block
 block discarded – undo
133 133
 $skinObject = new \web\lib\user\Skinjob($_REQUEST['skin'] ?? $_SESSION['skin'] ?? $fedskin[0] ?? \config\Master::APPEARANCE['skins'][0]);
134 134
 
135 135
 // and now, serve actual data
136
-require "../skins/" . $skinObject->skin . "/accountstatus/accountstatus.php";
136
+require "../skins/".$skinObject->skin."/accountstatus/accountstatus.php";
Please login to merge, or discard this patch.