Passed
Push — master ( 181714...135de8 )
by Tomasz
13:04
created
web/lib/admin/MapNone.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
      */
84 84
     public function htmlShowtime($wizard = FALSE, $additional = FALSE) {
85 85
         if (!$this->readOnly) {
86
- //           return $this->htmlPreEdit($wizard, $additional) . $this->htmlPostEdit(TRUE);
86
+    //           return $this->htmlPreEdit($wizard, $additional) . $this->htmlPostEdit(TRUE);
87 87
             return $this->htmlPreEdit($wizard, $additional) . $this->findLocationHtml() . $this->htmlPostEdit(TRUE);
88 88
         }
89 89
     }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     public function htmlShowtime($wizard = FALSE, $additional = FALSE) {
83 83
         if (!$this->readOnly) {
84 84
  //           return $this->htmlPreEdit($wizard, $additional) . $this->htmlPostEdit(TRUE);
85
-            return $this->htmlPreEdit($wizard, $additional) . $this->findLocationHtml() . $this->htmlPostEdit(TRUE);
85
+            return $this->htmlPreEdit($wizard, $additional).$this->findLocationHtml().$this->htmlPostEdit(TRUE);
86 86
         }
87 87
     }
88 88
 
@@ -104,11 +104,11 @@  discard block
 block discarded – undo
104 104
      */
105 105
     public static function optionListDisplayCode($coords, $number) {
106 106
         // quiesce warnings about unused parameter
107
-        if (strlen(sprintf("%d", $number)) <0) {
107
+        if (strlen(sprintf("%d", $number)) < 0) {
108 108
             throw new \Exception("A miracle! A string with negative length!");
109 109
         };
110 110
         $pair = json_decode($coords, true);
111
-        return "<table><tr><td>Latitude</td><td><strong>" . $pair['lat'] . "</strong></td></tr><tr><td>Longitude</td><td><strong>" . $pair['lon'] . "</strong></td></tr></table>";
111
+        return "<table><tr><td>Latitude</td><td><strong>".$pair['lat']."</strong></td></tr><tr><td>Longitude</td><td><strong>".$pair['lon']."</strong></td></tr></table>";
112 112
     }
113 113
     
114 114
     /**
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
      */
119 119
     private function findLocationHtml() {
120 120
         \core\common\Entity::intoThePotatoes();
121
-        $retval = "<button type='button' onclick='locateMe()'>" . _("Locate Me!") . "</button></p>";
121
+        $retval = "<button type='button' onclick='locateMe()'>"._("Locate Me!")."</button></p>";
122 122
         \core\common\Entity::outOfThePotatoes();
123 123
         return $retval;
124 124
     }
Please login to merge, or discard this patch.
web/lib/admin/Maintenance.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public static function deleteObsoleteTempDirs() {
36 36
         $downloadsDirs = [
37
-            'site_installers' => dirname(dirname(dirname(dirname(__FILE__)))) . "/var/installer_cache",
38
-            'silverbullet' => dirname(dirname(dirname(dirname(__FILE__)))) . "/var/silverbullet"
37
+            'site_installers' => dirname(dirname(dirname(dirname(__FILE__))))."/var/installer_cache",
38
+            'silverbullet' => dirname(dirname(dirname(dirname(__FILE__))))."/var/silverbullet"
39 39
         ];
40 40
         $tm = time();
41 41
         $i = 0;
@@ -54,14 +54,14 @@  discard block
 block discarded – undo
54 54
                     if ($entry === '.' || $entry === '..' || $entry === '.gitignore') {
55 55
                         continue;
56 56
                     }
57
-                    $ftime = $tm - filemtime($downloads . '/' . $entry);
57
+                    $ftime = $tm - filemtime($downloads.'/'.$entry);
58 58
                     if ($ftime < 3600) {
59 59
                         continue;
60 60
                     }
61 61
                     if (isset($Cache[$entry])) {
62 62
                         continue;
63 63
                     }
64
-                    \core\common\Entity::rrmdir($downloads . '/' . $entry);
64
+                    \core\common\Entity::rrmdir($downloads.'/'.$entry);
65 65
                     $i = $i + 1;
66 66
                     print "$entry\n";
67 67
                 }
Please login to merge, or discard this patch.
web/copyright.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
  * @author Stefan Winter <[email protected]>
26 26
  * @package Core
27 27
  */
28
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
28
+require_once dirname(dirname(__FILE__))."/config/_config.php";
29 29
 
30 30
 $Gui = new \web\lib\user\Gui();
31 31
 // ... unless overwritten by direct GET/POST parameter in the request or a SESSION setting
Please login to merge, or discard this patch.
web/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
  * @author Stefan Winter <[email protected]>
26 26
  * @package Core
27 27
  */
28
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
28
+require_once dirname(dirname(__FILE__))."/config/_config.php";
29 29
 
30 30
 $Gui = new \web\lib\user\Gui();
31 31
 // ... unless overwritten by direct GET/POST parameter in the request or a SESSION setting
Please login to merge, or discard this patch.
devices/linux/DeviceLinux.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -211,7 +211,7 @@
 block discarded – undo
211 211
         }
212 212
 
213 213
         if (!empty($this->attributes['internal:realm'][0])) {
214
-           $config['user_realm'] = $this->attributes['internal:realm'][0];
214
+            $config['user_realm'] = $this->attributes['internal:realm'][0];
215 215
         }
216 216
         
217 217
         if(!empty($this->attributes['internal:hint_userinput_suffix'][0]) && $this->attributes['internal:hint_userinput_suffix'][0] == 1) {
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -201,8 +201,7 @@
 block discarded – undo
201 201
             
202 202
         if ($this->selectedEap == \core\common\EAP::EAPTYPE_TLS && isset($this->attributes['eap-specific:tls_use_other_id']) && $this->attributes['eap-specific:tls_use_other_id'][0] == 'on') {
203 203
             $configRaw['use_other_tls_id'] = "True";
204
-        }
205
-        else {
204
+        } else {
206 205
             $configRaw['use_other_tls_id'] = "False";
207 206
         }
208 207
 
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     public function writeInstaller() {
61 61
         $installerPath = $this->installerBasename.".py";
62 62
         $this->copyFile("main.py", $installerPath);
63
-        $installer = fopen($installerPath,"a");
63
+        $installer = fopen($installerPath, "a");
64 64
         if ($installer === FALSE) {
65 65
             throw new Exception("Unable to open installer file for writing!");
66 66
         }
@@ -202,11 +202,11 @@  discard block
 block discarded – undo
202 202
            $config['user_realm'] = $this->attributes['internal:realm'][0];
203 203
         }
204 204
         
205
-        if(!empty($this->attributes['internal:hint_userinput_suffix'][0]) && $this->attributes['internal:hint_userinput_suffix'][0] == 1) {
205
+        if (!empty($this->attributes['internal:hint_userinput_suffix'][0]) && $this->attributes['internal:hint_userinput_suffix'][0] == 1) {
206 206
             $configRaw['hint_user_input'] = "True";
207 207
         }
208 208
         
209
-        if(!empty($this->attributes['internal:verify_userinput_suffix'][0]) && $this->attributes['internal:verify_userinput_suffix'][0] == 1) {
209
+        if (!empty($this->attributes['internal:verify_userinput_suffix'][0]) && $this->attributes['internal:verify_userinput_suffix'][0] == 1) {
210 210
             $configRaw['verify_user_realm_input'] = "True";
211 211
         }
212 212
         
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
             }
280 280
             $out .= "'DNS:$oneServer'";
281 281
         }
282
-        return "[".$out. "]";
282
+        return "[".$out."]";
283 283
     }
284 284
 
285 285
     /**
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
      * 
320 320
      * @return string
321 321
      */
322
-    private function mkCAfile(){
322
+    private function mkCAfile() {
323 323
         $out = '';
324 324
         $cAlist = $this->attributes['internal:CAs'][0];
325 325
         foreach ($cAlist as $oneCa) {
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
      */
336 336
     private function mkIntro() {
337 337
         \core\common\Entity::intoThePotatoes();
338
-        $out = _("This installer has been prepared for {0}").'\n\n'._("More information and comments:").'\n\nEMAIL: {1}\nWWW: {2}\n\n' .
338
+        $out = _("This installer has been prepared for {0}").'\n\n'._("More information and comments:").'\n\nEMAIL: {1}\nWWW: {2}\n\n'.
339 339
             _("Installer created with software from the GEANT project.");
340 340
         \core\common\Entity::outOfThePotatoes();
341 341
         return $out;
Please login to merge, or discard this patch.
devices/test_module/DeviceTestModule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -138,8 +138,8 @@
 block discarded – undo
138 138
      */
139 139
     private function zipInstaller() {
140 140
         // one can always access $this->attributes to check things
141
-        $fileName = $this->installerBasename . '.zip';
142
-        $output = system('zip -q ' . $fileName . ' *');
141
+        $fileName = $this->installerBasename.'.zip';
142
+        $output = system('zip -q '.$fileName.' *');
143 143
         if ($output === FALSE) {
144 144
             $this->loggerInstance->debug(2, "unable to zip the installer\n");
145 145
         }
Please login to merge, or discard this patch.
devices/redirect_dev/DeviceRedirectDev.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -22,15 +22,15 @@
 block discarded – undo
22 22
 namespace devices\redirect_dev;
23 23
 
24 24
 class DeviceRedirectDev extends \core\DeviceConfig {
25
-   /**
26
-    * Constructs a Device object.
27
-    *
28
-    * @final not to be redefined
29
-    */
25
+    /**
26
+     * Constructs a Device object.
27
+     *
28
+     * @final not to be redefined
29
+     */
30 30
     final public function __construct() {
31 31
         parent::__construct();
32
-      $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_NONE]);
33
-      $this->loggerInstance->debug(4,"RedirectEx called");
32
+        $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_NONE]);
33
+        $this->loggerInstance->debug(4,"RedirectEx called");
34 34
     }
35 35
     
36 36
     /**
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     final public function __construct() {
31 31
         parent::__construct();
32 32
       $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_NONE]);
33
-      $this->loggerInstance->debug(4,"RedirectEx called");
33
+      $this->loggerInstance->debug(4, "RedirectEx called");
34 34
     }
35 35
     
36 36
     /**
Please login to merge, or discard this patch.
web/skins/modern/test.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
          <?php if (empty($_REQUEST['idp'])) { ?>
92 92
               <div id="front_page">
93 93
                   <?php
94
-                         echo $divs->divTopWelcome();
94
+                            echo $divs->divTopWelcome();
95 95
 //                         echo $divs->div_roller();
96 96
 //                         echo $divs->div_main_button(); ?>
97 97
               </div> <!-- id="front_page" -->
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -28,9 +28,9 @@  discard block
 block discarded – undo
28 28
 ?>
29 29
 
30 30
 <!-- JQuery -->
31
-<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL","jquery/jquery.js") ?>"></script>
32
-<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL","jquery/jquery-migrate-1.2.1.js") ?>"></script>
33
-<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL","jquery/jquery-ui.js") ?>"></script>
31
+<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL", "jquery/jquery.js") ?>"></script>
32
+<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL", "jquery/jquery-migrate-1.2.1.js") ?>"></script>
33
+<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL", "jquery/jquery-ui.js") ?>"></script>
34 34
 <!-- JQuery -->
35 35
 
36 36
 <script type="text/javascript">
@@ -44,10 +44,10 @@  discard block
 block discarded – undo
44 44
 $operatingSystem = $Gui->detectOS();
45 45
 $Gui->loggerInstance->debug(4, $operatingSystem);
46 46
 if ($operatingSystem) {
47
-    print "recognisedOS = '" . $operatingSystem['device'] . "';\n";
47
+    print "recognisedOS = '".$operatingSystem['device']."';\n";
48 48
 }
49 49
 
50
-print 'downloadMessage = "' . $Gui->textTemplates->templates[\web\lib\user\DOWNLOAD_MESSAGE] . '";';
50
+print 'downloadMessage = "'.$Gui->textTemplates->templates[\web\lib\user\DOWNLOAD_MESSAGE].'";';
51 51
 //TODO modify this based on OS detection
52 52
 if (preg_match('/Android/', $_SERVER['HTTP_USER_AGENT'])) {
53 53
     $profile_list_size = 1;
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 require "user/js/cat_js.php";
59 59
 ?>
60 60
     var loading_ico = new Image();
61
-    loading_ico.src = "<?php echo $Gui->skinObject->findResourceUrl("IMAGES","icons/loading51.gif")?>";
61
+    loading_ico.src = "<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/loading51.gif")?>";
62 62
 </script>
63 63
 <?php $Gui->languageInstance->setTextDomain("web_user"); ?>
64 64
 <!-- DiscoJuice -->
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
     front_page = 0;
68 68
     var lang = "<?php echo($Gui->languageInstance->getLang()) ?>";
69 69
 </script>
70
-<link rel="stylesheet" type="text/css" href="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL","discojuice/css/discojuice.css")?>" />
70
+<link rel="stylesheet" type="text/css" href="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL", "discojuice/css/discojuice.css")?>" />
71 71
 <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1.0, user-scalable=no">
72
-<link rel="stylesheet" media="screen" type="text/css" href="<?php echo $Gui->skinObject->findResourceUrl("CSS","cat-user.css");?>" />
72
+<link rel="stylesheet" media="screen" type="text/css" href="<?php echo $Gui->skinObject->findResourceUrl("CSS", "cat-user.css"); ?>" />
73 73
 </head>
74 74
 <body>
75 75
 <div id="wrap">
@@ -77,14 +77,14 @@  discard block
 block discarded – undo
77 77
     <?php echo $divs->divHeading($visibility); ?>
78 78
     <div id="main_page">
79 79
         <div id="loading_ico">
80
-          <?php echo _("Authenticating") . "..." ?><br><img src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES","icons/loading51.gif")?>" alt="Authenticating ..."/>
80
+          <?php echo _("Authenticating")."..." ?><br><img src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/loading51.gif")?>" alt="Authenticating ..."/>
81 81
         </div>
82 82
         <div id="info_overlay"> <!-- device info -->
83 83
             <div id="info_window"></div>
84
-            <img id="info_menu_close" class="close_button" src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES","icons/button_cancel.png")?>" ALT="Close"/>
84
+            <img id="info_menu_close" class="close_button" src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/button_cancel.png")?>" ALT="Close"/>
85 85
         </div>
86 86
         <div id="main_menu_info" style="display:none"> <!-- stuff triggered form main menu -->
87
-          <img id="main_menu_close" class="close_button" src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES","icons/button_cancel.png")?>" ALT="Close"/>
87
+          <img id="main_menu_close" class="close_button" src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/button_cancel.png")?>" ALT="Close"/>
88 88
           <div id="main_menu_content"></div>
89 89
         </div>
90 90
         <div id="main_body">
Please login to merge, or discard this patch.
devices/ms/Files/common.inc 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1115,12 +1115,12 @@
 block discarded – undo
1115 1115
         $certUsernameLabel = WindowsCommon::sprintNsis(_("Username:"));
1116 1116
         $certUsernameLength = strlen($certUsernameLabel);
1117 1117
         $labelLength = max($certPasswordLength,$certUsernameLength);
1118
-  ?>
1118
+    ?>
1119 1119
   ${NSD_CreateLabel} 0 0 100% 32u "<?php WindowsCommon::echoNsis(_("Selected file: \$Cert_file"))?>"
1120 1120
   !else
1121 1121
   <?php $certPasswordLabel = WindowsCommon::sprintNsis(_("import password:"));
1122 1122
         $certPasswordLength = strlen($certPasswordLabel);
1123
-  ?>
1123
+    ?>
1124 1124
   !insertmacro debug_cat 4 "Unpacking SB_cert.p12"
1125 1125
   File "SB_cert.p12"
1126 1126
   nsArray::Set Delete_files "SB_cert.p12"
Please login to merge, or discard this patch.
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -146,10 +146,10 @@  discard block
 block discarded – undo
146 146
 !define MUI_HEADERIMAGE_BITMAP "cat_150.bmp"
147 147
 !define MUI_COMPONENTSPAGE_SMALLDESC
148 148
 
149
-!define WELCOME_HEADER "<?php printf(WindowsCommon::sprintNsis(_("Welcome to the %s installer")),\config\ConfAssistant::CONSORTIUM['display_name'])?>"
150
-!define FAREWELL_HEADER "<?php WindowsCommon::echoNsis( _("Installation complete"))?>"
151
-!define FAREWELL_TEXT	"<?php WindowsCommon::echoNsis( _("Network profiles have been installed."))?>$\r$\n$\n <?php WindowsCommon::echoNsis(  _("Your system is ready."))?>"
152
-!define FAREWELL_FAIL	"<?php WindowsCommon::echoNsis( _("Network installation had errors."))?>$\r$\n$\n <?php WindowsCommon::echoNsis( _("Please contact \${SUPPORT}."))?>"
149
+!define WELCOME_HEADER "<?php printf(WindowsCommon::sprintNsis(_("Welcome to the %s installer")), \config\ConfAssistant::CONSORTIUM['display_name'])?>"
150
+!define FAREWELL_HEADER "<?php WindowsCommon::echoNsis(_("Installation complete"))?>"
151
+!define FAREWELL_TEXT	"<?php WindowsCommon::echoNsis(_("Network profiles have been installed."))?>$\r$\n$\n <?php WindowsCommon::echoNsis(_("Your system is ready."))?>"
152
+!define FAREWELL_FAIL	"<?php WindowsCommon::echoNsis(_("Network installation had errors."))?>$\r$\n$\n <?php WindowsCommon::echoNsis(_("Please contact \${SUPPORT}."))?>"
153 153
 ;--------------------------------
154 154
 ;Languages
155 155
 !insertmacro MUI_LANGUAGE "${LANG}"
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 ;--------------------------------
158 158
 ; Licence file
159 159
 !ifdef LICENSE_FILE
160
-LicenseForceSelection checkbox "<?php WindowsCommon::echoNsis( _("Accept"))?>"
160
+LicenseForceSelection checkbox "<?php WindowsCommon::echoNsis(_("Accept"))?>"
161 161
 LicenseText "<?php WindowsCommon::echoNsis(_("If you accept the conditions then select Accept and then click Install to continue."))?>"
162 162
 LicenseData ${LICENSE_FILE}
163 163
 !endif
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 VIAddVersionKey "CompanyName" "GÉANT"
171 171
 VIAddVersionKey "ProductVersion" "${VERSION}"
172 172
 
173
-MiscButtonText "" "" "" "<?php WindowsCommon::echoNsis( _("Finish"))?>"
173
+MiscButtonText "" "" "" "<?php WindowsCommon::echoNsis(_("Finish"))?>"
174 174
 ;----------------------------------
175 175
 ;  FUNCTIONS
176 176
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 
205 205
 !macro install_ca_cert ca_file ca_fingerprint level
206 206
    !insertmacro debug_cat 2 "locating certificate  SHA=${ca_fingerprint} Level=${level}"
207
-   DetailPrint "<?php WindowsCommon::echoNsis( _("searching for certificate"))?> ${ca_file}"
207
+   DetailPrint "<?php WindowsCommon::echoNsis(_("searching for certificate"))?> ${ca_file}"
208 208
    File "${ca_file}"
209 209
    nsArray::Set Delete_files "${ca_file}"
210 210
    !insertmacro debug_cat 2 "Testing machine store root"
@@ -266,13 +266,13 @@  discard block
 block discarded – undo
266 266
    ${EndIf}
267 267
    !insertmacro debug_cat 2 "installing certificate $TEMP\${ca_file}"
268 268
    !insertmacro debug_cat 3 "Execute: certutil -addstore -user ${level} $TEMP\${ca_file}"
269
-   DetailPrint "<?php WindowsCommon::echoNsis( _("installing certificate"))?> ${ca_file}"
269
+   DetailPrint "<?php WindowsCommon::echoNsis(_("installing certificate"))?> ${ca_file}"
270 270
    nsExec::Exec '"certutil" -addstore -user ${level} "$TEMP"\${ca_file}'
271 271
    Pop $0
272 272
    !insertmacro debug_cat 3 "certutil returned $0"
273 273
    ${If} $0 != 0
274 274
      IfSilent +2
275
-     MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis( _("could not install certificate"))?>  ${ca_file}"
275
+     MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis(_("could not install certificate"))?>  ${ca_file}"
276 276
      !insertmacro debug_cat 1 "could not install certificate ${ca_file}"
277 277
    ${EndIf}
278 278
 no_install_${ca_file}:
@@ -479,26 +479,26 @@  discard block
 block discarded – undo
479 479
   pop $R0
480 480
   ${If} $tkip_count > 0
481 481
     ${If} $aes_count > 1
482
-      StrCpy $R1 "$\r$\n$\n<?php WindowsCommon::echoNsis( _("The non TKIP profiles are preferred. Always use them if you have a choice."))?>"
482
+      StrCpy $R1 "$\r$\n$\n<?php WindowsCommon::echoNsis(_("The non TKIP profiles are preferred. Always use them if you have a choice."))?>"
483 483
     ${Else}
484
-     StrCpy $R1 "$\r$\n$\n<?php WindowsCommon::echoNsis( _("The non TKIP profile is preferred. Always use it if you have a choice."))?>"
484
+     StrCpy $R1 "$\r$\n$\n<?php WindowsCommon::echoNsis(_("The non TKIP profile is preferred. Always use it if you have a choice."))?>"
485 485
     ${EndIf}
486 486
   ${Else}
487 487
     StrCpy $R1 ""
488 488
   ${EndIf}
489 489
   ${If} $profile_count > 0
490
-    StrCpy $welcome_message "<?php WindowsCommon::echoNsis( _("This installer has been prepared for \${ORGANISATION}"))?>.$\r$\n\
491
-<?php WindowsCommon::echoNsis( _("The installer will create the following wireless profiles:"))?>$\r$\n\
490
+    StrCpy $welcome_message "<?php WindowsCommon::echoNsis(_("This installer has been prepared for \${ORGANISATION}"))?>.$\r$\n\
491
+<?php WindowsCommon::echoNsis(_("The installer will create the following wireless profiles:"))?>$\r$\n\
492 492
 $R0.\
493 493
 $R1$\r$\n$\n\
494
-<?php WindowsCommon::echoNsis( _("More information and comments:"))?>$\r$\n\
494
+<?php WindowsCommon::echoNsis(_("More information and comments:"))?>$\r$\n\
495 495
    EMAIL: ${SUPPORT}$\r$\n\
496 496
    WWW: ${URL}"
497 497
 ${Else}
498
-StrCpy $welcome_message "<?php WindowsCommon::echoNsis( _("This installer has been prepared for \${ORGANISATION}"))?>.$\r$\n\
499
-<?php WindowsCommon::echoNsis( _("The installer will create the wireless profile:"))?> $R0.\
498
+StrCpy $welcome_message "<?php WindowsCommon::echoNsis(_("This installer has been prepared for \${ORGANISATION}"))?>.$\r$\n\
499
+<?php WindowsCommon::echoNsis(_("The installer will create the wireless profile:"))?> $R0.\
500 500
 $R1$\r$\n$\n\
501
-<?php WindowsCommon::echoNsis( _("More information and comments:"))?>$\r$\n\
501
+<?php WindowsCommon::echoNsis(_("More information and comments:"))?>$\r$\n\
502 502
    EMAIL: ${SUPPORT}$\r$\n\
503 503
    WWW: ${URL}"
504 504
 ${EndIf}
@@ -524,7 +524,7 @@  discard block
 block discarded – undo
524 524
   SendMessage $HEADLINE ${WM_SETFONT} $HEADLINE_FONT 0
525 525
 ;TRANSLATION
526 526
   nsDialogs::CreateControl STATIC ${WS_VISIBLE}|${WS_CHILD}|${WS_CLIPSIBLINGS} 0 120u 46u -130u -32u "$welcome_message\
527
-$\r$\n$\r$\n<?php WindowsCommon::echoNsis( _("Installer created with software from the GEANT project."))?>"
527
+$\r$\n$\r$\n<?php WindowsCommon::echoNsis(_("Installer created with software from the GEANT project."))?>"
528 528
   Pop $TEXT
529 529
 
530 530
   SetCtlColors $DIALOG "" 0xffffff
@@ -661,18 +661,18 @@  discard block
 block discarded – undo
661 661
     ${If} $wireless_result == 1
662 662
       !insertmacro debug_cat 1 "wlan_test.exe did not find wireless configuration service"
663 663
       IfSilent +2
664
-      MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis( _("Windows wireless configuration service is not enabled. The installer cannot continue."))?>"
664
+      MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis(_("Windows wireless configuration service is not enabled. The installer cannot continue."))?>"
665 665
       Call Cleanup
666 666
     ${EndIf}
667 667
     ${If} $wireless_result == 2
668 668
       IfSilent +2
669
-      MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis( _("No wireless interfaces found. The installer cannot continue."))?>"
669
+      MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis(_("No wireless interfaces found. The installer cannot continue."))?>"
670 670
       Call Cleanup
671 671
     ${EndIf}
672 672
   ${Else}
673 673
     ${If} $wireless_result > 0
674 674
        IfSilent +3
675
-       MessageBox MB_YESNO "<?php WindowsCommon::echoNsis( _("No wireless interfaces found. Wireless access will not be configured. Would you like to continue and configure access on the wired interface?"))?>" IDYES wired_yes
675
+       MessageBox MB_YESNO "<?php WindowsCommon::echoNsis(_("No wireless interfaces found. Wireless access will not be configured. Would you like to continue and configure access on the wired interface?"))?>" IDYES wired_yes
676 676
        Call Cleanup
677 677
        wired_yes:
678 678
        Push 1
@@ -688,7 +688,7 @@  discard block
 block discarded – undo
688 688
     ${If} $wired == 1
689 689
       ${If} $force_wired == 0
690 690
         IfSilent wired
691
-        MessageBox MB_YESNO "<?php WindowsCommon::echoNsis( _("Do you want to enable access on wired interfaces?"))?>" IDYES wired
691
+        MessageBox MB_YESNO "<?php WindowsCommon::echoNsis(_("Do you want to enable access on wired interfaces?"))?>" IDYES wired
692 692
         Push 0
693 693
         Pop $wired
694 694
         wired:
@@ -729,7 +729,7 @@  discard block
 block discarded – undo
729 729
 ;================================
730 730
 
731 731
 Function ShowInstfiles
732
-  !insertmacro MUI_HEADER_TEXT "<?php WindowsCommon::echoNsis( _("Profiles installation"))?>" " "
732
+  !insertmacro MUI_HEADER_TEXT "<?php WindowsCommon::echoNsis(_("Profiles installation"))?>" " "
733 733
 FunctionEnd
734 734
 ;================================
735 735
 ;  Check if a wireless profile exist and put it on delete list
@@ -748,7 +748,7 @@  discard block
 block discarded – undo
748 748
 
749 749
 Function FindProfile
750 750
   Pop $R8
751
-  DetailPrint "<?php WindowsCommon::echoNsis( _("Checking for profile \$R8"))?>"
751
+  DetailPrint "<?php WindowsCommon::echoNsis(_("Checking for profile \$R8"))?>"
752 752
   !insertmacro debug_cat 2 "Checking for profile $R8"
753 753
   !insertmacro debug_cat 3 "Exec: $Netsh wlan show profiles $R8"
754 754
   nsExec::Exec  '"$Netsh" wlan show profiles "$R8"'
@@ -756,7 +756,7 @@  discard block
 block discarded – undo
756 756
   !insertmacro debug_cat 4 "netsh returned $0"
757 757
   ${If} $0 == 0
758 758
     !insertmacro debug_cat 1 "found profile $R8"
759
-    DetailPrint "<?php WindowsCommon::echoNsis( _("found profile \$R8"))?>"
759
+    DetailPrint "<?php WindowsCommon::echoNsis(_("found profile \$R8"))?>"
760 760
     Push 0
761 761
   ${Else}
762 762
     !insertmacro debug_cat 1 "profile $R8 not found"
@@ -853,7 +853,7 @@  discard block
 block discarded – undo
853 853
     ${If} $Symantec_installed  != 0
854 854
      !insertmacro debug_cat 3 "Symantec problem"
855 855
      IfSilent +2
856
-     MessageBox MB_OK|MB_ICONEXCLAMATION "<?php printf(WindowsCommon::sprintNsis(_("Please READ this message it is IMPORTANT.$\\r$\\nInstallation problems may be due to the fact that Symantec Endpoint Protection is installed on your machine.$\\r$\\nWhile this is a well-known bug of the Symantec product, about which the installer can not do anything, there is a workaround.$\\r$\\nWhen you close this window the installer will exit and an explorer window will be started (it could appear underneath already opened windows). In this window you should see a script named inst_cat. Start it by double-clicking, It will install the profiles. You will need to login to %s with your username and password.")),\config\ConfAssistant::CONSORTIUM['display_name']) ?>"
856
+     MessageBox MB_OK|MB_ICONEXCLAMATION "<?php printf(WindowsCommon::sprintNsis(_("Please READ this message it is IMPORTANT.$\\r$\\nInstallation problems may be due to the fact that Symantec Endpoint Protection is installed on your machine.$\\r$\\nWhile this is a well-known bug of the Symantec product, about which the installer can not do anything, there is a workaround.$\\r$\\nWhen you close this window the installer will exit and an explorer window will be started (it could appear underneath already opened windows). In this window you should see a script named inst_cat. Start it by double-clicking, It will install the profiles. You will need to login to %s with your username and password.")), \config\ConfAssistant::CONSORTIUM['display_name']) ?>"
857 857
     Exec '"explorer" /select,"$EXEDIR\inst_cat.cmd"'
858 858
     Quit
859 859
 
@@ -1186,7 +1186,7 @@  discard block
 block discarded – undo
1186 1186
 Function PFXCertificateSelect
1187 1187
   !ifndef SILVERBULLET
1188 1188
 ;TRANSLATION
1189
-!insertmacro MUI_HEADER_TEXT "<?php printf(WindowsCommon::sprintNsis(_("%s installer for")),\config\ConfAssistant::CONSORTIUM['display_name'])?> " "<?php WindowsCommon::echoNsis(_("Install personal certificate"))?>"
1189
+!insertmacro MUI_HEADER_TEXT "<?php printf(WindowsCommon::sprintNsis(_("%s installer for")), \config\ConfAssistant::CONSORTIUM['display_name'])?> " "<?php WindowsCommon::echoNsis(_("Install personal certificate"))?>"
1190 1190
 ;TRANSLATION
1191 1191
     IfSilent +2
1192 1192
   MessageBox MB_OK "<?php WindowsCommon::echoNsis(_("Preparing to install personal certificate."))?>$\r$\n<?php WindowsCommon::echoNsis(_("Click OK to continue"))?> "
@@ -1202,7 +1202,7 @@  discard block
 block discarded – undo
1202 1202
         $certPasswordLength = strlen($certPasswordLabel);
1203 1203
         $certUsernameLabel = WindowsCommon::sprintNsis(_("Username:"));
1204 1204
         $certUsernameLength = strlen($certUsernameLabel);
1205
-        $labelLength = max($certPasswordLength,$certUsernameLength);
1205
+        $labelLength = max($certPasswordLength, $certUsernameLength);
1206 1206
   ?>
1207 1207
   ${NSD_CreateLabel} 0 0 100% 32u "<?php WindowsCommon::echoNsis(_("Selected file: \$Cert_file"))?>"
1208 1208
   !else
@@ -1219,11 +1219,11 @@  discard block
 block discarded – undo
1219 1219
   !insertmacro debug_cat 3 "Vista level (Vista without Service pack): $VistaNoSP";
1220 1220
   ${If} $VistaNoSP == 0
1221 1221
     !ifdef PFX_USERNAME
1222
-       !define LABEL_LENGTH "<?php echo($labelLength*3.5)?>u"
1223
-       !define TEXT_START "<?php echo($labelLength*3.5 +5)?>u"
1222
+       !define LABEL_LENGTH "<?php echo($labelLength * 3.5)?>u"
1223
+       !define TEXT_START "<?php echo($labelLength * 3.5 + 5)?>u"
1224 1224
     !else
1225
-       !define LABEL_LENGTH "<?php echo($certPasswordLength*3.5)?>u"
1226
-       !define TEXT_START "<?php echo($certPasswordLength*3.5 +5)?>u"
1225
+       !define LABEL_LENGTH "<?php echo($certPasswordLength * 3.5)?>u"
1226
+       !define TEXT_START "<?php echo($certPasswordLength * 3.5 + 5)?>u"
1227 1227
     !endif
1228 1228
     ${NSD_CreateLabel} 0 35u ${LABEL_LENGTH} 12u "<?php echo $certPasswordLabel?>"
1229 1229
     ${NSD_CreatePassword} ${TEXT_START} 34.5u 120u 12u ""
@@ -1595,7 +1595,7 @@  discard block
 block discarded – undo
1595 1595
 Section "-start"
1596 1596
 SectionIn RO
1597 1597
 
1598
-!insertmacro MUI_HEADER_TEXT "<?php WindowsCommon::echoNsis( _("Installation"))?>" "<?php WindowsCommon::echoNsis( _("Checking for existing wireless profiles"))?>"
1598
+!insertmacro MUI_HEADER_TEXT "<?php WindowsCommon::echoNsis(_("Installation"))?>" "<?php WindowsCommon::echoNsis(_("Checking for existing wireless profiles"))?>"
1599 1599
 !ifndef PWD
1600 1600
 !include "certs.nsh"
1601 1601
 !endif
Please login to merge, or discard this patch.