Passed
Push — master ( 56c883...f703ed )
by Maja
04:39
created
web/user/faq.inc.php 1 patch
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -12,52 +12,52 @@
 block discarded – undo
12 12
     this is just an include file for Gui class definition
13 13
 */
14 14
     $Faq = [
15
-      [
15
+        [
16 16
         'id'=>'idp_not_listed',
17 17
         'title'=>sprintf(_("My %s is not listed. Can't I just use any of the other ones?"),$Gui->nomenclature_inst),
18 18
         'text'=>sprintf(_("No! The installers contain security settings which are specific to the %s. If you are not from that %s, your computer will detect that you are about to send your username and credential to an unauthorised server and will abort the login. Using a different %s installer is <i>guaranteed to not work</i>!"), $Gui->nomenclature_inst, $Gui->nomenclature_inst, $Gui->nomenclature_inst)
19
-         ],
20
-      [
19
+            ],
20
+        [
21 21
         'id'=>'idp_not_listed',
22 22
         'title'=>sprintf(_("What can I do to get my %s listed?"), $Gui->nomenclature_inst),
23 23
         'text'=>sprintf(_("Contact %s administrators at your %s and complain. It will take at most one hour of their time to get things done."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $Gui->nomenclature_inst)
24 24
 ],
25
-      [
25
+        [
26 26
         'id'=>'device_not_listed',
27 27
         'title'=>sprintf(_("My device is not listed! Does that mean I can't do %s?"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
28 28
         'text'=>sprintf(_("No. The CAT tool can only support Operating Systems which can be automatically configured in some way. Many other devices can still be used with %s, but must be configured manually. Please contact your %s Identity Provider to get help in setting up such a device."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
29
-      ],
29
+        ],
30 30
 
31
-      [
31
+        [
32 32
         'title'=>sprintf(_("I can connect to %s simply by providing username and password, what is the point of using an installer?"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
33 33
         'text'=>sprintf(_("When you are connecting from an unconfigured device your security is at risk. The very point of preconfiguration is to set up security, when this is done, your device will first confirm that it talks to the correct authentication server and will never send your password to an untrusted one."))
34 34
 ],
35
-      [
35
+        [
36 36
         'title'=>sprintf(_("Is it safe to use %s installers?"),CONFIG['APPEARANCE']['productname']),
37 37
         'text'=>sprintf(_("%s installers configure security settings on your device, therefore you should be sure that you are using genuine ones."),CONFIG['APPEARANCE']['productname']).' '.( isset(CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']) && CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'] != "" ? sprintf(_("This is why %s installers are digitally signed by %s. Watch out for a system message confirming this."),CONFIG['APPEARANCE']['productname'],CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']):""),
38 38
         
39 39
 ],
40
-      [
40
+        [
41 41
         'title'=>_("Windows 'SmartScreen' or 'Internet Explorer' tell me that the file is not commonly downloaded and possibly harmful. Should I be concerned?"),
42 42
         'text'=>_("Contrary to what the name suggests, 'SmartScreen' isn't actually very smart. The warning merely means that the file has not yet been downloaded by enough users to make Microsoft consider it popular (which would strangely enough make it be considered 'safe'). This message alone is not a security problem.")." ".(isset(CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']) && CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'] != "" ? sprintf(_("So long as the file is carrying a valid signature from %s, the download is safe."),CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'])." ":"").sprintf(_("Please see also Microsoft's FAQ regarding SmartScreen at %s."),"<a href='http://windows.microsoft.com/en-US/windows7/SmartScreen-Filter-frequently-asked-questions-IE9?SignedIn=1'>Microsoft FAQ</a>")
43 43
         
44 44
 ],
45
-      [
45
+        [
46 46
         'title'=>sprintf(_("I can see %s network and my device is configured but it does not connect, what can be the cause?"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
47
-      'text'=>sprintf(_("There can be a number of different reasons. The network you see may not be a genuine %s one and your device silently drops the connection attempt; there may be something wrong with the configuration of the network; your account may have expired; there may be a connection problem with your home authentication server; you may have broken the regulations of the network you are using and have been refused access as a consequence. You should contact your %s and report the problem, the administrators should be able to trace your connections."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $Gui->nomenclature_inst)
47
+        'text'=>sprintf(_("There can be a number of different reasons. The network you see may not be a genuine %s one and your device silently drops the connection attempt; there may be something wrong with the configuration of the network; your account may have expired; there may be a connection problem with your home authentication server; you may have broken the regulations of the network you are using and have been refused access as a consequence. You should contact your %s and report the problem, the administrators should be able to trace your connections."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $Gui->nomenclature_inst)
48 48
 ],
49
-      [
49
+        [
50 50
         'id'=>'contact',
51 51
         'title'=>sprintf(_("I have a question about this web site. Whom should I contact?")),
52 52
         'text'=>sprintf(_("You should send a mail to %s."),CONFIG['APPEARANCE']['support-contact']['display'])
53
-      ],
53
+        ],
54 54
 ];
55 55
 
56 56
     if (CONFIG_CONFASSISTANT['CONSORTIUM']['name'] == "eduroam") {
57
-       array_push($Faq,
58
-         [
59
-           'id'=>'what_is_'.CONFIG_CONFASSISTANT['CONSORTIUM']['name'],
60
-           'title'=>sprintf(_("What is this %s thing anyway?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
61
-           'text'=>sprintf(_("%s is a global WiFi roaming consortium which gives members of education and research access to the internet <i>for free</i> on all %s hotspots on the planet. There are several million %s users already, enjoying free internet access on more than 6.000 hotspots! Visit <a href='http://www.eduroam.org'>the %s homepage</a> for more details."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
62
-         ]);
57
+        array_push($Faq,
58
+            [
59
+            'id'=>'what_is_'.CONFIG_CONFASSISTANT['CONSORTIUM']['name'],
60
+            'title'=>sprintf(_("What is this %s thing anyway?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
61
+            'text'=>sprintf(_("%s is a global WiFi roaming consortium which gives members of education and research access to the internet <i>for free</i> on all %s hotspots on the planet. There are several million %s users already, enjoying free internet access on more than 6.000 hotspots! Visit <a href='http://www.eduroam.org'>the %s homepage</a> for more details."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
62
+            ]);
63 63
     }
64 64
\ No newline at end of file
Please login to merge, or discard this patch.
devices/ms/Files/common.inc 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1019,12 +1019,12 @@
 block discarded – undo
1019 1019
         $certUsernameLabel = WindowsCommon::sprint_nsi(_("Username:"));
1020 1020
         $certUsernameLength = strlen($certUsernameLabel);
1021 1021
         $labelLength = max($certPasswordLength,$certUsernameLength);
1022
-  ?>
1022
+    ?>
1023 1023
   ${NSD_CreateLabel} 0 0 100% 32u "<?php WindowsCommon::echo_nsi(_("Selected file: \$Cert_file"))?>"
1024 1024
   !else
1025 1025
   <?php $certPasswordLabel = WindowsCommon::sprint_nsi(_("import password:"));
1026 1026
         $certPasswordLength = strlen($certPasswordLabel);
1027
-  ?>
1027
+    ?>
1028 1028
   !insertmacro debug_cat 4 "Unpacking SB_cert.p12"
1029 1029
   File "SB_cert.p12"
1030 1030
   nsArray::Set Delete_files "SB_cert.p12"
Please login to merge, or discard this patch.
web/skins/classic/user/js/cat_js.php 1 patch
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -11,14 +11,14 @@  discard block
 block discarded – undo
11 11
 <?php 
12 12
 $cat = new core\CAT();
13 13
 function escaped_echo($s) {
14
-   echo preg_replace('/"/','&quot;',$s);
14
+    echo preg_replace('/"/','&quot;',$s);
15 15
 }
16 16
 
17 17
 $langObject = new \core\common\Language();
18 18
 $langObject->setTextDomain('web_user');
19 19
 $idpId = filter_input(INPUT_GET, 'idp', FILTER_VALIDATE_INT) ?? filter_input(INPUT_POST, 'idp', FILTER_VALIDATE_INT);
20 20
 $profileId = filter_input(INPUT_GET, 'profile', FILTER_VALIDATE_INT) ?? filter_input(INPUT_POST, 'profile', FILTER_VALIDATE_INT);
21
- ?>
21
+    ?>
22 22
 var n;
23 23
 var profile;
24 24
 var generateTimer;
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
 }
354 354
 
355 355
 <?php if($idpId) { 
356
-      print "front_page = 0;\n";
356
+        print "front_page = 0;\n";
357 357
 } ?>
358 358
 
359 359
 function showTOU(){
@@ -487,7 +487,7 @@  discard block
 block discarded – undo
487 487
 if ($profileId) {
488 488
     print "listProfiles($idpId,$profileId);";
489 489
 }
490
- ?>
490
+    ?>
491 491
 
492 492
 $(".signin").click(function(event){
493 493
      pressedButton = $(this);
@@ -548,12 +548,12 @@  discard block
 block discarded – undo
548 548
         });
549 549
 DiscoJuice.Constants.Countries = {
550 550
 <?php 
551
-  $C = $Gui->printCountryList(1);
552
-     $ret = '';
553
-   foreach ($C as $key => $val) {
551
+    $C = $Gui->printCountryList(1);
552
+        $ret = '';
553
+    foreach ($C as $key => $val) {
554 554
     $ret .= "'$key': \"$val\",";
555
-   }
556
-   echo substr($ret, 0, -1);
555
+    }
556
+    echo substr($ret, 0, -1);
557 557
 ?>
558 558
         };
559 559
 
Please login to merge, or discard this patch.
core/diag/RFC7585Tests.php 1 patch
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -185,7 +185,6 @@
 block discarded – undo
185 185
      * - RETVAL_NOTCONFIGURED; needs CONFIG_DIAGNOSTICS['RADIUSTESTS']['TLS-discoverytag']
186 186
      * - RETVAL_INVALID (at least one format error)
187 187
      * - RETVAL_OK (all fine)
188
-
189 188
      * @return int one of two RETVALs above
190 189
      */
191 190
     public function relevantNAPTRcompliance() {
Please login to merge, or discard this patch.
devices/linux/Device_Linux.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@
 block discarded – undo
137 137
         
138 138
         $out .= 'Config.sb_user_file = """' . $this->mkSbUserFile() . '"""' . "\n";
139 139
         if (!empty($this->attributes['internal:realm'][0])) {
140
-           $out .= 'Config.user_realm = "' . $this->attributes['internal:realm'][0] . "\"\n";
140
+            $out .= 'Config.user_realm = "' . $this->attributes['internal:realm'][0] . "\"\n";
141 141
         }
142 142
         if(!empty($this->attributes['internal:hint_userinput_suffix'][0]) && $this->attributes['internal:hint_userinput_suffix'][0] == 1) {
143 143
             $out .= "Config.hint_user_input = True\n";
Please login to merge, or discard this patch.
web/skins/modern/test.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
          <?php if (empty($_REQUEST['idp'])) { ?>
82 82
               <div id="front_page">
83 83
                   <?php
84
-                         echo $divs->div_top_welcome();
84
+                            echo $divs->div_top_welcome();
85 85
 //                         echo $divs->div_roller();
86 86
 //                         echo $divs->div_main_button(); ?>
87 87
               </div> <!-- id="front_page" -->
Please login to merge, or discard this patch.
core/diag/Sociopath.php 1 patch
Indentation   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -57,34 +57,34 @@
 block discarded – undo
57 57
         $confAssistantText = _("You should use appropriate configuration assistants [MGW: see if the realm exists in CAT, then display link to config] or contact your Identity Provider [MGW: show contact info].");
58 58
         $this->qaArray = [
59 59
             0 => ["AREA" => AbstractTest::INFRA_DEVICE,
60
-                  "TXT" => _("Have you ever used the network succesfully, e.g. at your home institution without roaming?"),
61
-                  "FACTOR" => 0.5,
62
-                  "VERDICTLECTURE" => sprintf(_("If your device has never worked before with this setup, then very likely your device configuation is wrong. %s"), $confAssistantText)],
60
+                    "TXT" => _("Have you ever used the network succesfully, e.g. at your home institution without roaming?"),
61
+                    "FACTOR" => 0.5,
62
+                    "VERDICTLECTURE" => sprintf(_("If your device has never worked before with this setup, then very likely your device configuation is wrong. %s"), $confAssistantText)],
63 63
             1 => ["AREA" => AbstractTest::INFRA_DEVICE, 
64
-                  "TXT" => _("Did the device previously work when roaming, i.e. at other hotspots away from your home institution?"), 
65
-                  "FACTOR" => 0.33,
66
-                  "VERDICTLECTURE" => sprintf(_("If roaming consistently does not work, then very likely your device configuration is wrong. Typical errors causing this symptom include: using a routing ('outer') username without the @realm.tld suffix - those potentially work at home, but can not be used when roaming. %s"),$confAssistantText)],
64
+                    "TXT" => _("Did the device previously work when roaming, i.e. at other hotspots away from your home institution?"), 
65
+                    "FACTOR" => 0.33,
66
+                    "VERDICTLECTURE" => sprintf(_("If roaming consistently does not work, then very likely your device configuration is wrong. Typical errors causing this symptom include: using a routing ('outer') username without the @realm.tld suffix - those potentially work at home, but can not be used when roaming. %s"),$confAssistantText)],
67 67
             2 => ["AREA" => AbstractTest::INFRA_DEVICE, 
68
-                  "TXT" => _("Did you recently change the configuration on your device?"), 
69
-                  "FACTOR" => 3,
70
-                  "VERDICTLECTURE" => _("Accounts only need to be configured once, and can then be used anywhere on the planet without any changes. If you recently changed the configuration, that change may very well be at fault. You should never change your network configuration unless explicitly instructed so by your Identity Provider; even in the case of temporary login issues.")],
68
+                    "TXT" => _("Did you recently change the configuration on your device?"), 
69
+                    "FACTOR" => 3,
70
+                    "VERDICTLECTURE" => _("Accounts only need to be configured once, and can then be used anywhere on the planet without any changes. If you recently changed the configuration, that change may very well be at fault. You should never change your network configuration unless explicitly instructed so by your Identity Provider; even in the case of temporary login issues.")],
71 71
             3 => ["AREA" => AbstractTest::INFRA_DEVICE, 
72
-                  "TXT" => _("Do your other devices still work?"),
73
-                  "VERDICTLECTURE" => _("If all devices stopped working simultaneously, there may be a problem with your account as such. Maybe your account expired, or you were forced to change the password? These questions are best answered by your Identity Provider [MGW: display contact info]"),
74
-                  "FACTOR" => 0.33],
72
+                    "TXT" => _("Do your other devices still work?"),
73
+                    "VERDICTLECTURE" => _("If all devices stopped working simultaneously, there may be a problem with your account as such. Maybe your account expired, or you were forced to change the password? These questions are best answered by your Identity Provider [MGW: display contact info]"),
74
+                    "FACTOR" => 0.33],
75 75
             4 => ["AREA" => AbstractTest::INFRA_SP_80211, 
76
-                  "TXT" => _("Is the place you are currently at heavily crowded, or is a network-intensive workload going on?"), 
77
-                  "FACTOR" => 3,
78
-                  "VERDICTLECTURE" => _("The network is likely overloaded at this location and point in time. You may have to wait until later before you get a better connectivity. If you think the network should be reinforced for more capacity at this place, you should inform the hotspot provider. [MGW: add contact info]")],            
76
+                    "TXT" => _("Is the place you are currently at heavily crowded, or is a network-intensive workload going on?"), 
77
+                    "FACTOR" => 3,
78
+                    "VERDICTLECTURE" => _("The network is likely overloaded at this location and point in time. You may have to wait until later before you get a better connectivity. If you think the network should be reinforced for more capacity at this place, you should inform the hotspot provider. [MGW: add contact info]")],            
79 79
             5 => ["AREA" => AbstractTest::INFRA_SP_80211, 
80
-                  "TXT" => _("Does the connection get better when you move around?"), 
81
-                  "FACTOR" => 3,
82
-                  "VERDICTLECTURE" => _("You should move to a different location to achieve better network coverage and service. If you think the exact spot you are at deserves better coverage, you should inform the hotspot provider. [MGW: add contact info]")],
80
+                    "TXT" => _("Does the connection get better when you move around?"), 
81
+                    "FACTOR" => 3,
82
+                    "VERDICTLECTURE" => _("You should move to a different location to achieve better network coverage and service. If you think the exact spot you are at deserves better coverage, you should inform the hotspot provider. [MGW: add contact info]")],
83 83
             
84 84
             6 => ["AREA" => AbstractTest::INFRA_SP_LAN, 
85
-                  "TXT" => _("Do you see errors stating something similar to 'Unable to get IP address'?"), 
86
-                  "FACTOR" => 3,
87
-                  "VERDICTLECTURE" => _("The evidence at hand suggests that there may be an infrastructure problem at this particular hotspot provider. There is nothing you can do to solve this problem locally. Please be patient and try again at a later time.")],
85
+                    "TXT" => _("Do you see errors stating something similar to 'Unable to get IP address'?"), 
86
+                    "FACTOR" => 3,
87
+                    "VERDICTLECTURE" => _("The evidence at hand suggests that there may be an infrastructure problem at this particular hotspot provider. There is nothing you can do to solve this problem locally. Please be patient and try again at a later time.")],
88 88
         ];
89 89
     }
90 90
 
Please login to merge, or discard this patch.