Passed
Push — master ( 70cda0...819efa )
by Maja
07:06
created
web/diag/magicTelepath.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,10 +19,10 @@
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(__DIR__)) . "/config/_config.php";
22
+require_once dirname(dirname(__DIR__))."/config/_config.php";
23 23
 $realm = filter_input(INPUT_GET, 'realm', FILTER_SANITIZE_STRING);
24
-$visited = filter_input(INPUT_GET,'visited', FILTER_SANITIZE_STRING);
25
-$nro = filter_input(INPUT_GET,'nro', FILTER_SANITIZE_STRING);
24
+$visited = filter_input(INPUT_GET, 'visited', FILTER_SANITIZE_STRING);
25
+$nro = filter_input(INPUT_GET, 'nro', FILTER_SANITIZE_STRING);
26 26
 \core\CAT::sessionStart();
27 27
 $languageObject = new core\common\Language();
28 28
 $languageObject->setTextDomain("diagonstics");
Please login to merge, or discard this patch.
web/admin/inc/option_xhr.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
23 23
 
24 24
 \core\CAT::sessionStart();
25 25
 
Please login to merge, or discard this patch.
web/user/remindIdP.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
23 23
 
24 24
 \core\CAT::sessionStart();
25 25
 
Please login to merge, or discard this patch.
web/lib/admin/MapOpenLayers.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         
84 84
 // use HTML5 geolocation
85 85
         function locateMe() {
86
-            $('#address').val(\"" . _("locating") . "\");
86
+            $('#address').val(\"" . _("locating")."\");
87 87
             navigator.geolocation.getCurrentPosition(locate_succes,locate_fail,{maximumAge:3600000, timeout:5000});
88 88
         }
89 89
         
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
                 view.fit(extent, {padding: [10, 0, 10, 0]});
206 206
             } else {
207 207
                 view.setCenter([0,0]);
208
-                locate_country('" . $cat->knownFederations[strtoupper($this->fedName)] . "'); // use the federation code to locate the country
208
+                locate_country('" . $cat->knownFederations[strtoupper($this->fedName)]."'); // use the federation code to locate the country
209 209
                 map.setView(view);
210 210
             }
211 211
             view.setMaxZoom(20);
@@ -227,14 +227,14 @@  discard block
 block discarded – undo
227 227
         function getAddressLocation() {
228 228
             var city = $('#address').val();
229 229
             if(city == '') {
230
-                alert(\"" . _("nothing entered in the address field") . "\");
230
+                alert(\"" . _("nothing entered in the address field")."\");
231 231
                 return false;
232 232
             }
233 233
             city = city.replace(/\s*,\s*/g,',+');
234 234
             city = city.replace(/ +/,'+');
235 235
             $.get(addressService+'?format=json&addressdetails=0&q='+city, '',  function(data) {
236 236
                 if (data[0] === undefined) {
237
-                    alert('" . _("Address not found, perhaps try another form, like putting the street number to the front.") . "');
237
+                    alert('" . _("Address not found, perhaps try another form, like putting the street number to the front.")."');
238 238
                     return;
239 239
                 }
240 240
                 showTmpPointer(data[0].lon, data[0].lat);
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
         if ($this->readOnly) {
286 286
             return "<div id='map' class='locationmap'></div><script>generateMap('map')</script>";
287 287
         } else {
288
-            return $this->htmlPreEdit($wizard, $additional) . $this->findLocationHtml() . "<span id='location-prompt'>You can drag the pointer to the final location before you save the results.</span><div id='map' class='locationmap'></div><script>generateMap('map')</script>" . $this->htmlPostEdit(FALSE);
288
+            return $this->htmlPreEdit($wizard, $additional).$this->findLocationHtml()."<span id='location-prompt'>You can drag the pointer to the final location before you save the results.</span><div id='map' class='locationmap'></div><script>generateMap('map')</script>".$this->htmlPostEdit(FALSE);
289 289
         }
290 290
     }
291 291
 
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
         // we don't need this parameter in this subclass
311 311
         unset($coords);
312 312
         \core\common\Entity::intoThePotatoes();
313
-        $retval = "<button id='location_b_" . $number . "' class='location_button'>" . _("Click to see location") . " $number</button>";
313
+        $retval = "<button id='location_b_".$number."' class='location_button'>"._("Click to see location")." $number</button>";
314 314
         \core\common\Entity::outOfThePotatoes();
315 315
         return $retval;
316 316
     }
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
      */
323 323
     private function findLocationHtml() {
324 324
         \core\common\Entity::intoThePotatoes();
325
-        $retval = "<p>" . _("Address:") . " <input name='address' id='address' /><button type='button' onclick='getAddressLocation()'>" . _("Find address") . "</button> <button type='button' onclick='locateMe()'>" . _("Locate Me!") . "</button></p>";
325
+        $retval = "<p>"._("Address:")." <input name='address' id='address' /><button type='button' onclick='getAddressLocation()'>"._("Find address")."</button> <button type='button' onclick='locateMe()'>"._("Locate Me!")."</button></p>";
326 326
         \core\common\Entity::outOfThePotatoes();
327 327
         return $retval;
328 328
     }
Please login to merge, or discard this patch.
web/lib/admin/OptionParser.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -338,14 +338,14 @@  discard block
 block discarded – undo
338 338
                 case \core\Options::TYPECODE_TEXT:
339 339
                 case \core\Options::TYPECODE_COORDINATES:
340 340
                 case \core\Options::TYPECODE_INTEGER:
341
-                    $varName = $listOfEntries["$objId-" . self::VALIDATOR_FUNCTIONS[$optioninfo['type']]['field']];
341
+                    $varName = $listOfEntries["$objId-".self::VALIDATOR_FUNCTIONS[$optioninfo['type']]['field']];
342 342
                     if (!empty($varName)) {
343 343
                         $content = call_user_func_array([$this->validator, self::VALIDATOR_FUNCTIONS[$optioninfo['type']]['function']], array_merge([$varName], self::VALIDATOR_FUNCTIONS[$optioninfo['type']]['extraarg']));
344 344
                         break;
345 345
                     }
346 346
                     continue 2;
347 347
                 case \core\Options::TYPECODE_BOOLEAN:
348
-                    $varName = $listOfEntries["$objId-" . \core\Options::TYPECODE_BOOLEAN];
348
+                    $varName = $listOfEntries["$objId-".\core\Options::TYPECODE_BOOLEAN];
349 349
                     if (!empty($varName)) {
350 350
                         $contentValid = $this->validator->boolean($varName);
351 351
                         if ($contentValid) {
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
                     }
359 359
                     continue 2;
360 360
                 case \core\Options::TYPECODE_STRING:
361
-                    $previsionalContent = $listOfEntries["$objId-" . \core\Options::TYPECODE_STRING];
361
+                    $previsionalContent = $listOfEntries["$objId-".\core\Options::TYPECODE_STRING];
362 362
                     if (!empty($previsionalContent)) {
363 363
                         $content = $this->furtherStringChecks($objValue, $previsionalContent, $bad);
364 364
                         if ($content === FALSE) {
@@ -369,15 +369,15 @@  discard block
 block discarded – undo
369 369
                     continue 2;
370 370
                 case \core\Options::TYPECODE_FILE:
371 371
                     // this is either actually an uploaded file, or a reference to a DB entry of a previously uploaded file
372
-                    $reference = $listOfEntries["$objId-" . \core\Options::TYPECODE_STRING];
372
+                    $reference = $listOfEntries["$objId-".\core\Options::TYPECODE_STRING];
373 373
                     if (!empty($reference)) { // was already in, by ROWID reference, extract
374 374
                         // ROWID means it's a multi-line string (simple strings are inline in the form; so allow whitespace)
375 375
                         $content = $this->validator->string(urldecode($reference), TRUE);
376 376
                         break;
377 377
                     }
378
-                    $fileName = $listOfEntries["$objId-" . \core\Options::TYPECODE_FILE] ?? "";
378
+                    $fileName = $listOfEntries["$objId-".\core\Options::TYPECODE_FILE] ?? "";
379 379
                     if ($fileName != "") { // let's do the download
380
-                        $rawContent = \core\common\OutsideComm::downloadFile("file:///" . $fileName);
380
+                        $rawContent = \core\common\OutsideComm::downloadFile("file:///".$fileName);
381 381
 
382 382
                         if ($rawContent === FALSE || !$this->checkUploadSanity($objValue, $rawContent)) {
383 383
                             $bad[] = $objValue;
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
                     }
389 389
                     continue 2;
390 390
                 default:
391
-                    throw new Exception("Internal Error: Unknown option type " . $objValue . "!");
391
+                    throw new Exception("Internal Error: Unknown option type ".$objValue."!");
392 392
             }
393 393
             // lang can be NULL here, if it's not a multilang attribute, or a ROWID reference. Never mind that.
394 394
             $retval[] = ["$objValue" => ["lang" => $languageFlag, "content" => $content]];
Please login to merge, or discard this patch.
web/lib/admin/Authentication.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@
 block discarded – undo
121 121
         if ($trailerPosition !== FALSE) {
122 122
             $base = substr($scriptself, 0, $trailerPosition);
123 123
             if ($base !== FALSE) {
124
-                $url = "//$servername" . $base . "/logout_check.php";
124
+                $url = "//$servername".$base."/logout_check.php";
125 125
             }
126 126
         }
127 127
 
Please login to merge, or discard this patch.
web/lib/admin/AbstractMap.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -136,19 +136,19 @@  discard block
 block discarded – undo
136 136
     protected function htmlPreEdit($wizardMode, $additional) {
137 137
         \core\common\Entity::intoThePotatoes();
138 138
         $retval = "<fieldset class='option_container'>
139
-        <legend><strong>" . _("Location") . "</strong></legend>";
139
+        <legend><strong>" . _("Location")."</strong></legend>";
140 140
 
141 141
         if ($wizardMode) {
142
-            $retval .= "<p>" .
143
-                    _("The user download interface (see <a href='../'>here</a>), uses geolocation to suggest possibly matching IdPs to the user. The more precise you define the location here, the easier your users will find you.") .
142
+            $retval .= "<p>".
143
+                    _("The user download interface (see <a href='../'>here</a>), uses geolocation to suggest possibly matching IdPs to the user. The more precise you define the location here, the easier your users will find you.").
144 144
                     "</p>
145 145
                      <ul>" .
146 146
                     _("<li>Drag the marker in the map to your place, or</li>
147 147
 <li>enter your street address in the field below for lookup, or</li>
148
-<li>use the 'Locate Me!' button</li>") .
148
+<li>use the 'Locate Me!' button</li>").
149 149
                     "</ul>
150 150
                      <strong>" .
151
-                    _("We will use the coordinates as indicated by the marker for geolocation.") .
151
+                    _("We will use the coordinates as indicated by the marker for geolocation.").
152 152
                     "</strong>";
153 153
         }
154 154
         if ($additional) {
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
      */
167 167
     protected function htmlPostEdit($allowDirectInput) {
168 168
         \core\common\Entity::intoThePotatoes();
169
-        $retval = "<br/>" . _("Latitude:") . " <input style='width:80px' name='geo_lat' id='geo_lat' " .($allowDirectInput ? "": "readonly"). ">" . _("Longitude:") . " <input name='geo_long' id='geo_long' style='width:80px' " .($allowDirectInput ? "": "readonly"). "></fieldset>";
169
+        $retval = "<br/>"._("Latitude:")." <input style='width:80px' name='geo_lat' id='geo_lat' ".($allowDirectInput ? "" : "readonly").">"._("Longitude:")." <input name='geo_long' id='geo_long' style='width:80px' ".($allowDirectInput ? "" : "readonly")."></fieldset>";
170 170
         \core\common\Entity::outOfThePotatoes();
171 171
         return $retval;
172 172
     }
Please login to merge, or discard this patch.
core/diag/RFC7585Tests.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
             $this->NAPTR_executed = RADIUSTests::RETVAL_NOTCONFIGURED;
168 168
             return RADIUSTests::RETVAL_NOTCONFIGURED;
169 169
         }
170
-        $NAPTRs = dns_get_record($this->realm . ".", DNS_NAPTR);
170
+        $NAPTRs = dns_get_record($this->realm.".", DNS_NAPTR);
171 171
         if ($NAPTRs === FALSE || count($NAPTRs) == 0) {
172 172
             $this->NAPTR_executed = RFC7585Tests::RETVAL_NONAPTR;
173 173
             return RFC7585Tests::RETVAL_NONAPTR;
Please login to merge, or discard this patch.
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -197,7 +197,6 @@
 block discarded – undo
197 197
      * - RETVAL_NOTCONFIGURED; needs \config\Diagnostics::RADIUSTESTS['TLS-discoverytag']
198 198
      * - RETVAL_INVALID (at least one format error)
199 199
      * - RETVAL_OK (all fine)
200
-
201 200
      * @return int one of two RETVALs above
202 201
      */
203 202
     public function relevantNAPTRcompliance()
Please login to merge, or discard this patch.
web/admin/inc/sendinvite.inc.php 2 patches
Switch Indentation   +85 added lines, -85 removed lines patch added patch discarded remove patch
@@ -72,96 +72,96 @@
 block discarded – undo
72 72
 }
73 73
 
74 74
 switch ($operationMode) {
75
-    case OPERATION_MODE_EDIT:
76
-        $idp = $validator->existingIdP($_GET['inst_id']);
77
-        // editing IdPs is done from within the popup. When we're done, send the 
78
-        // user back to the popup (append the result of the operation later)
79
-        $redirectDestination = "manageAdmins.inc.php?inst_id=" . $idp->identifier . "&";
80
-        if (count($validAddresses) == 0) {
81
-            header("Location: $redirectDestination" . "invitation=INVALIDSYNTAX");
82
-            exit(1);
83
-        }
84
-        // is the user primary admin of this IdP?
85
-        $is_owner = $idp->isPrimaryOwner($_SESSION['user']);
86
-        // check if he is (also) federation admin for the federation this IdP is in. His invitations have more blessing then.
87
-        $fedadmin = $userObject->isFederationAdmin($idp->federation);
88
-        // check if he is either one, if not, complain
89
-        if (!$is_owner && !$fedadmin) {
90
-            echo "<p>" . sprintf(_("Something's wrong... you are a %s admin, but not for the %s the requested %s belongs to!"), $uiElements->nomenclatureFed, $uiElements->nomenclatureFed, $uiElements->nomenclatureInst) . "</p>";
91
-            exit(1);
92
-        }
75
+        case OPERATION_MODE_EDIT:
76
+            $idp = $validator->existingIdP($_GET['inst_id']);
77
+            // editing IdPs is done from within the popup. When we're done, send the 
78
+            // user back to the popup (append the result of the operation later)
79
+            $redirectDestination = "manageAdmins.inc.php?inst_id=" . $idp->identifier . "&";
80
+            if (count($validAddresses) == 0) {
81
+                header("Location: $redirectDestination" . "invitation=INVALIDSYNTAX");
82
+                exit(1);
83
+            }
84
+            // is the user primary admin of this IdP?
85
+            $is_owner = $idp->isPrimaryOwner($_SESSION['user']);
86
+            // check if he is (also) federation admin for the federation this IdP is in. His invitations have more blessing then.
87
+            $fedadmin = $userObject->isFederationAdmin($idp->federation);
88
+            // check if he is either one, if not, complain
89
+            if (!$is_owner && !$fedadmin) {
90
+                echo "<p>" . sprintf(_("Something's wrong... you are a %s admin, but not for the %s the requested %s belongs to!"), $uiElements->nomenclatureFed, $uiElements->nomenclatureFed, $uiElements->nomenclatureInst) . "</p>";
91
+                exit(1);
92
+            }
93 93
 
94
-        $prettyprintname = $idp->name;
95
-        $newtokens = $mgmt->createTokens($fedadmin, $validAddresses, $idp);
96
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP " . $idp->identifier . " - Token created for " . implode(",", $validAddresses));
97
-        $introtext = "CO-ADMIN";
98
-        $participant_type = $idp->type;
99
-        break;
100
-    case OPERATION_MODE_NEWUNLINKED:
101
-        $redirectDestination = "../overview_federation.php?";
102
-        if (count($validAddresses) == 0) {
103
-            header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
104
-            exit(1);
105
-        }
106
-        // run an input check and conversion of the raw inputs... just in case
107
-        $newinstname = $validator->string($_POST['name']);
108
-        $newcountry = $validator->string($_POST['country']);
109
-        $participant_type = $validator->partType($_POST['participant_type']);
110
-        $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($newcountry);
111
-        if ($new_idp_authorized_fedadmin !== TRUE) {
112
-            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureInst . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
113
-        }
114
-        $federation = $validator->existingFederation($newcountry);
115
-        $prettyprintname = $newinstname;
116
-        $introtext = "NEW-FED";
117
-        // send the user back to his federation overview page, append the result of the operation later
118
-        // do the token creation magic
119
-        $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $newinstname, 0, $newcountry, $participant_type);
120
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "ORG FUTURE  - Token created for $participant_type " . implode(",", $validAddresses));
121
-        break;
122
-    case OPERATION_MODE_NEWFROMDB:
123
-        $redirectDestination = "../overview_federation.php?";
124
-        if (count($validAddresses) == 0) {
125
-            header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
126
-            exit(1);
127
-        }
128
-        // a real external DB entry was submitted and all the required parameters are there
129
-        $newexternalid = $validator->string($_POST['externals']);
130
-        $extinfo = $catInstance->getExternalDBEntityDetails($newexternalid);
131
-        $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($extinfo['country']);
132
-        if ($new_idp_authorized_fedadmin !== TRUE) {
133
-            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureInst . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
134
-        }
135
-        $federation = $validator->existingFederation($extinfo['country']);
136
-        $newcountry = $extinfo['country'];
137
-        // see if the inst name is defined in the currently set language; if not, pick its English name; if N/A, pick the last in the list
138
-        $prettyprintname = "";
139
-        foreach ($extinfo['names'] as $lang => $name) {
140
-            if ($lang == $languageInstance->getLang()) {
141
-                $prettyprintname = $name;
94
+            $prettyprintname = $idp->name;
95
+            $newtokens = $mgmt->createTokens($fedadmin, $validAddresses, $idp);
96
+            $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP " . $idp->identifier . " - Token created for " . implode(",", $validAddresses));
97
+            $introtext = "CO-ADMIN";
98
+            $participant_type = $idp->type;
99
+            break;
100
+        case OPERATION_MODE_NEWUNLINKED:
101
+            $redirectDestination = "../overview_federation.php?";
102
+            if (count($validAddresses) == 0) {
103
+                header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
104
+                exit(1);
142 105
             }
143
-        }
144
-        if ($prettyprintname == "" && isset($extinfo['names']['en'])) {
145
-            $prettyprintname = $extinfo['names']['en'];
146
-        }
147
-        if ($prettyprintname == "") {
148
-            foreach ($extinfo['names'] as $name) {
149
-                $prettyprintname = $name;
106
+            // run an input check and conversion of the raw inputs... just in case
107
+            $newinstname = $validator->string($_POST['name']);
108
+            $newcountry = $validator->string($_POST['country']);
109
+            $participant_type = $validator->partType($_POST['participant_type']);
110
+            $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($newcountry);
111
+            if ($new_idp_authorized_fedadmin !== TRUE) {
112
+                throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureInst . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
150 113
             }
151
-        }
152
-        $participant_type = $extinfo['type'];
153
-        // fill the rest of the text
154
-        $introtext = "EXISTING-FED";
155
-        // do the token creation magic
156
-        $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $prettyprintname, $newexternalid);
157
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP FUTURE  - Token created for " . implode(",", $validAddresses));
158
-        break;
159
-    default: // includes OPERATION_MODE_INVALID
160
-        $wrongcontent = print_r($_POST, TRUE);
161
-        echo "<pre>Wrong parameters in POST:
114
+            $federation = $validator->existingFederation($newcountry);
115
+            $prettyprintname = $newinstname;
116
+            $introtext = "NEW-FED";
117
+            // send the user back to his federation overview page, append the result of the operation later
118
+            // do the token creation magic
119
+            $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $newinstname, 0, $newcountry, $participant_type);
120
+            $loggerInstance->writeAudit($_SESSION['user'], "NEW", "ORG FUTURE  - Token created for $participant_type " . implode(",", $validAddresses));
121
+            break;
122
+        case OPERATION_MODE_NEWFROMDB:
123
+            $redirectDestination = "../overview_federation.php?";
124
+            if (count($validAddresses) == 0) {
125
+                header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
126
+                exit(1);
127
+            }
128
+            // a real external DB entry was submitted and all the required parameters are there
129
+            $newexternalid = $validator->string($_POST['externals']);
130
+            $extinfo = $catInstance->getExternalDBEntityDetails($newexternalid);
131
+            $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($extinfo['country']);
132
+            if ($new_idp_authorized_fedadmin !== TRUE) {
133
+                throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureInst . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
134
+            }
135
+            $federation = $validator->existingFederation($extinfo['country']);
136
+            $newcountry = $extinfo['country'];
137
+            // see if the inst name is defined in the currently set language; if not, pick its English name; if N/A, pick the last in the list
138
+            $prettyprintname = "";
139
+            foreach ($extinfo['names'] as $lang => $name) {
140
+                if ($lang == $languageInstance->getLang()) {
141
+                    $prettyprintname = $name;
142
+                }
143
+            }
144
+            if ($prettyprintname == "" && isset($extinfo['names']['en'])) {
145
+                $prettyprintname = $extinfo['names']['en'];
146
+            }
147
+            if ($prettyprintname == "") {
148
+                foreach ($extinfo['names'] as $name) {
149
+                    $prettyprintname = $name;
150
+                }
151
+            }
152
+            $participant_type = $extinfo['type'];
153
+            // fill the rest of the text
154
+            $introtext = "EXISTING-FED";
155
+            // do the token creation magic
156
+            $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $prettyprintname, $newexternalid);
157
+            $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP FUTURE  - Token created for " . implode(",", $validAddresses));
158
+            break;
159
+        default: // includes OPERATION_MODE_INVALID
160
+            $wrongcontent = print_r($_POST, TRUE);
161
+            echo "<pre>Wrong parameters in POST:
162 162
 " . htmlspecialchars($wrongcontent) . "
163 163
 </pre>";
164
-        exit(1);
164
+            exit(1);
165 165
 }
166 166
 
167 167
 // send, and invalidate the token immediately if the mail could not be sent!
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  *          <base_url>/copyright.php after deploying the software
21 21
  */
22 22
 
23
-require_once dirname(dirname(dirname(__DIR__))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(__DIR__)))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $auth->authenticate();
@@ -76,9 +76,9 @@  discard block
 block discarded – undo
76 76
         $idp = $validator->existingIdP($_GET['inst_id']);
77 77
         // editing IdPs is done from within the popup. When we're done, send the 
78 78
         // user back to the popup (append the result of the operation later)
79
-        $redirectDestination = "manageAdmins.inc.php?inst_id=" . $idp->identifier . "&";
79
+        $redirectDestination = "manageAdmins.inc.php?inst_id=".$idp->identifier."&";
80 80
         if (count($validAddresses) == 0) {
81
-            header("Location: $redirectDestination" . "invitation=INVALIDSYNTAX");
81
+            header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
82 82
             exit(1);
83 83
         }
84 84
         // is the user primary admin of this IdP?
@@ -87,13 +87,13 @@  discard block
 block discarded – undo
87 87
         $fedadmin = $userObject->isFederationAdmin($idp->federation);
88 88
         // check if he is either one, if not, complain
89 89
         if (!$is_owner && !$fedadmin) {
90
-            echo "<p>" . sprintf(_("Something's wrong... you are a %s admin, but not for the %s the requested %s belongs to!"), $uiElements->nomenclatureFed, $uiElements->nomenclatureFed, $uiElements->nomenclatureInst) . "</p>";
90
+            echo "<p>".sprintf(_("Something's wrong... you are a %s admin, but not for the %s the requested %s belongs to!"), $uiElements->nomenclatureFed, $uiElements->nomenclatureFed, $uiElements->nomenclatureInst)."</p>";
91 91
             exit(1);
92 92
         }
93 93
 
94 94
         $prettyprintname = $idp->name;
95 95
         $newtokens = $mgmt->createTokens($fedadmin, $validAddresses, $idp);
96
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP " . $idp->identifier . " - Token created for " . implode(",", $validAddresses));
96
+        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP ".$idp->identifier." - Token created for ".implode(",", $validAddresses));
97 97
         $introtext = "CO-ADMIN";
98 98
         $participant_type = $idp->type;
99 99
         break;
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
         $participant_type = $validator->partType($_POST['participant_type']);
110 110
         $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($newcountry);
111 111
         if ($new_idp_authorized_fedadmin !== TRUE) {
112
-            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureInst . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
112
+            throw new Exception("Something's wrong... you want to create a new ".$uiElements->nomenclatureInst.", but are not a ".$uiElements->nomenclatureFed." admin for the ".$uiElements->nomenclatureFed." it should be in!");
113 113
         }
114 114
         $federation = $validator->existingFederation($newcountry);
115 115
         $prettyprintname = $newinstname;
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
         // send the user back to his federation overview page, append the result of the operation later
118 118
         // do the token creation magic
119 119
         $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $newinstname, 0, $newcountry, $participant_type);
120
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "ORG FUTURE  - Token created for $participant_type " . implode(",", $validAddresses));
120
+        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "ORG FUTURE  - Token created for $participant_type ".implode(",", $validAddresses));
121 121
         break;
122 122
     case OPERATION_MODE_NEWFROMDB:
123 123
         $redirectDestination = "../overview_federation.php?";
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
         $extinfo = $catInstance->getExternalDBEntityDetails($newexternalid);
131 131
         $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($extinfo['country']);
132 132
         if ($new_idp_authorized_fedadmin !== TRUE) {
133
-            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureInst . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
133
+            throw new Exception("Something's wrong... you want to create a new ".$uiElements->nomenclatureInst.", but are not a ".$uiElements->nomenclatureFed." admin for the ".$uiElements->nomenclatureFed." it should be in!");
134 134
         }
135 135
         $federation = $validator->existingFederation($extinfo['country']);
136 136
         $newcountry = $extinfo['country'];
@@ -154,12 +154,12 @@  discard block
 block discarded – undo
154 154
         $introtext = "EXISTING-FED";
155 155
         // do the token creation magic
156 156
         $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $prettyprintname, $newexternalid);
157
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP FUTURE  - Token created for " . implode(",", $validAddresses));
157
+        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP FUTURE  - Token created for ".implode(",", $validAddresses));
158 158
         break;
159 159
     default: // includes OPERATION_MODE_INVALID
160 160
         $wrongcontent = print_r($_POST, TRUE);
161 161
         echo "<pre>Wrong parameters in POST:
162
-" . htmlspecialchars($wrongcontent) . "
162
+" . htmlspecialchars($wrongcontent)."
163 163
 </pre>";
164 164
         exit(1);
165 165
 }
@@ -184,14 +184,14 @@  discard block
 block discarded – undo
184 184
 }
185 185
 
186 186
 if (count($status) == 0) {
187
-    header("Location: $redirectDestination" . "invitation=FAILURE");
187
+    header("Location: $redirectDestination"."invitation=FAILURE");
188 188
     exit;
189 189
 }
190 190
 $finalDestParams = "invitation=SUCCESS";
191 191
 if (count($status) < count($totalSegments)) { // only a subset of mails was sent, update status
192 192
     $finalDestParams = "invitation=PARTIAL";
193 193
 }
194
-$finalDestParams .= "&successcount=" . count($status);
194
+$finalDestParams .= "&successcount=".count($status);
195 195
 if ($allEncrypted === TRUE) {
196 196
     $finalDestParams .= "&transportsecurity=ENCRYPTED";
197 197
 } elseif ($allClear === TRUE) {
@@ -200,4 +200,4 @@  discard block
 block discarded – undo
200 200
     $finalDestParams .= "&transportsecurity=PARTIAL";
201 201
 }
202 202
 
203
-header("Location: $redirectDestination" . $finalDestParams);
203
+header("Location: $redirectDestination".$finalDestParams);
Please login to merge, or discard this patch.