Passed
Push — release_2_0 ( eaf51a...10a0f3 )
by Stefan
11:08
created
web/skins/modern/Divs.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
49 49
         $location = $this->Gui->skinObject->findResourceUrl("IMAGES", "consortium_logo.png");
50 50
         if ($location !== FALSE) {
51 51
             $retval .= "<div id='cat_logo'>
52
-            <a href='" . CONFIG_CONFASSISTANT['CONSORTIUM']['homepage'] . "'><img id='logo_img' src='$location' alt='Consortium Logo'/></a>
52
+            <a href='" . CONFIG_CONFASSISTANT['CONSORTIUM']['homepage']."'><img id='logo_img' src='$location' alt='Consortium Logo'/></a>
53 53
             <span>Configuration Assistant Tool</span>
54 54
             </div>";
55 55
         }
56
-        $retval .= "<div id='motd'>" . (isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp') . "</div>";
56
+        $retval .= "<div id='motd'>".(isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp')."</div>";
57 57
         $loc2 = $this->Gui->skinObject->findResourceUrl("IMAGES", "icons/menu.png");
58 58
         if ($loc2 !== FALSE) {
59 59
             $retval .= "<img id='hamburger' src='$loc2' alt='Menu'/>";
@@ -71,13 +71,13 @@  discard block
 block discarded – undo
71 71
     public function divUserWelcome() {
72 72
         $retval = "
73 73
 <div id='user_welcome'> <!-- this information is shown just before the download -->
74
-    <strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PAGEHEADING] . "</strong>
74
+    <strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PAGEHEADING]."</strong>
75 75
     <p>
76 76
     <span id='download_info'>
77 77
     <!-- the empty href is dynamically exchanged with the actual path by jQuery at runtime -->
78
-        " . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_DOWNLOAD] . "
78
+        " . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_DOWNLOAD]."
79 79
     </span>
80
-    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_HEADING] . "
80
+    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_HEADING]."
81 81
     <br/>
82 82
     <br/>";
83 83
         switch (CONFIG_CONFASSISTANT['CONSORTIUM']['name']) {
@@ -87,11 +87,11 @@  discard block
 block discarded – undo
87 87
         }
88 88
         $retval .= "
89 89
     </p>
90
-    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_USAGE] . "
91
-    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PROBLEMS] . "
90
+    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_USAGE]."
91
+    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PROBLEMS]."
92 92
     </p>
93 93
     <p>
94
-    <a href='javascript:back_to_downloads()'><strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_BACKTODOWNLOADS] . "</strong></a>
94
+    <a href='javascript:back_to_downloads()'><strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_BACKTODOWNLOADS]."</strong></a>
95 95
     </p>
96 96
 </div> <!-- id='user_welcomer_page' -->
97 97
 ";
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     public function divSilverbullet() {
102 102
         $retval = "
103 103
 <div id='silverbullet'>"
104
-                . $this->Gui->textTemplates->templates[user\SB_GO_AWAY] .
104
+                . $this->Gui->textTemplates->templates[user\SB_GO_AWAY].
105 105
                 "</div>
106 106
     ";
107 107
         return $retval;
@@ -114,10 +114,10 @@  discard block
 block discarded – undo
114 114
         }
115 115
         return "
116 116
 <div id='welcome_top1'>
117
-    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_GREET] . "
117
+    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_GREET]."
118 118
 </div>
119 119
 <div id='top_invite'>
120
-    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_PURPOSE] . $retval . "
120
+    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_PURPOSE].$retval."
121 121
 </div>";
122 122
     }
123 123
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         $retval = "
126 126
 <div id='roller'>
127 127
     <div id='slides'>
128
-        <span id='line1'>" . $this->Gui->textTemplates->templates[user\FRONTPAGE_ROLLER_EASY] . "</span>
128
+        <span id='line1'>" . $this->Gui->textTemplates->templates[user\FRONTPAGE_ROLLER_EASY]."</span>
129 129
         <span id='line2'></span>
130 130
         <span id='line3'></span>
131 131
         <span id='line4'>";
@@ -177,9 +177,9 @@  discard block
 block discarded – undo
177 177
     public function divProfiles() {
178 178
         return "
179 179
 <div id='profiles'> <!-- this is the profile selection filled during run time -->
180
-    <div id='profiles_h' class='sub_h'>" . $this->Gui->textTemplates->templates[user\PROFILE_SELECTION] . "
180
+    <div id='profiles_h' class='sub_h'>" . $this->Gui->textTemplates->templates[user\PROFILE_SELECTION]."
181 181
     </div>" .
182
-                "<select id='profile_list'></select><div id='profile_desc' class='profile_desc'></div>" .
182
+                "<select id='profile_list'></select><div id='profile_desc' class='profile_desc'></div>".
183 183
                 "</div>";
184 184
     }
185 185
 
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
     public function divInstitution($selectButton = TRUE) {
194 194
         $retval = "<div id='institution_name'>
195 195
     <span id='inst_name_span'></span> <div id='inst_extra_text'></div><!-- this will be filled with the IdP name -->" .
196
-                ($selectButton ? "<a  id='select_another' class='signin' href=\"\">" . $this->Gui->textTemplates->templates[user\INSTITUTION_SELECTION] . "</a>" : "") .
196
+                ($selectButton ? "<a  id='select_another' class='signin' href=\"\">".$this->Gui->textTemplates->templates[user\INSTITUTION_SELECTION]."</a>" : "").
197 197
                 "</div>";
198 198
         $retval .= $this->emptyImage('idp_logo', 'IdP Logo');
199 199
         return $retval;
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
     public function divOtherinstallers() {
208 208
         $retval = "
209 209
 <div class='sub_h'>
210
-    <div id='other_installers'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE] . "
210
+    <div id='other_installers'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE]."
211 211
          <table id='device_list' style='padding:0px;'>";
212 212
 
213 213
         foreach ($this->Gui->listDevices(isset($_REQUEST['hidden']) ? $_REQUEST['hidden'] : 0) as $group => $deviceGroup) {
@@ -215,18 +215,18 @@  discard block
 block discarded – undo
215 215
             $deviceIndex = 0;
216 216
 
217 217
             $imgTag = "";
218
-            $imgLocation = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/" . $group . ".png");
218
+            $imgLocation = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/".$group.".png");
219 219
             if ($imgLocation !== FALSE) {
220
-                $imgTag = '<img src="' . $imgLocation . '" alt="' . $group . ' Device" title="' . $group . ' Device">';
220
+                $imgTag = '<img src="'.$imgLocation.'" alt="'.$group.' Device" title="'.$group.' Device">';
221 221
             }
222
-            $retval .= '<tbody><tr><td class="vendor" rowspan="' . $groupIndex . '">' . $imgTag . '</td>';
222
+            $retval .= '<tbody><tr><td class="vendor" rowspan="'.$groupIndex.'">'.$imgTag.'</td>';
223 223
             foreach ($deviceGroup as $d => $D) {
224 224
                 if ($deviceIndex) {
225 225
                     $retval .= '<tr>';
226 226
                 }
227
-                $retval .= "<td><button id='" . $d . "'>" . $D['display'] . "</button>"
228
-                        . "<div class='device_info' id='info_" . $d . "'></div></td>"
229
-                        . "<td><button class='more_info_b' id='info_b_" . $d . "'>i</button></td></tr>\n";
227
+                $retval .= "<td><button id='".$d."'>".$D['display']."</button>"
228
+                        . "<div class='device_info' id='info_".$d."'></div></td>"
229
+                        . "<td><button class='more_info_b' id='info_b_".$d."'>i</button></td></tr>\n";
230 230
                 $deviceIndex++;
231 231
             }
232 232
             $retval .= "</tbody>";
@@ -240,15 +240,15 @@  discard block
 block discarded – undo
240 240
     }
241 241
 
242 242
     public function divGuessOs($operatingSystem) {
243
-        $vendorlogo = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/" . $operatingSystem['group'] . ".png");
243
+        $vendorlogo = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/".$operatingSystem['group'].".png");
244 244
         $vendorstyle = "";
245 245
         if ($vendorlogo !== FALSE) {
246
-            $vendorstyle = "style='background-image:url(\"" . $vendorlogo . "\")'";
246
+            $vendorstyle = "style='background-image:url(\"".$vendorlogo."\")'";
247 247
         }
248 248
         $deleteIcon = $this->Gui->skinObject->findResourceUrl("IMAGES", "icons/delete_32.png");
249 249
         $deleteImg = "";
250 250
         if ($deleteIcon !== FALSE) {
251
-            $deleteImg = "<img id='cross_icon_" . $operatingSystem['device'] . "' src='$deleteIcon' >";
251
+            $deleteImg = "<img id='cross_icon_".$operatingSystem['device']."' src='$deleteIcon' >";
252 252
         }
253 253
         return "
254 254
 <div class='sub_h' id='guess_os'>
@@ -256,23 +256,23 @@  discard block
 block discarded – undo
256 256
     <table id='browser'>
257 257
         <tr>
258 258
             <td>
259
-                <button class='large_button guess_os' $vendorstyle id='g_" . $operatingSystem['device'] . "'>
259
+                <button class='large_button guess_os' $vendorstyle id='g_".$operatingSystem['device']."'>
260 260
                     $deleteImg
261
-                    <div class='download_button_text_1' id='download_button_header_" . $operatingSystem['device'] . "'> " . $this->Gui->textTemplates->templates[user\DOWNLOAD_MESSAGE] . "
261
+                    <div class='download_button_text_1' id='download_button_header_".$operatingSystem['device']."'> ".$this->Gui->textTemplates->templates[user\DOWNLOAD_MESSAGE]."
262 262
                     </div>
263 263
                     <div class='download_button_text'>" .
264
-                $operatingSystem['display'] . "
264
+                $operatingSystem['display']."
265 265
                     </div>
266 266
                 </button>
267
-                <div class='device_info' id='info_g_" . $operatingSystem['device'] . "'></div>
267
+                <div class='device_info' id='info_g_" . $operatingSystem['device']."'></div>
268 268
           </td>
269 269
           <td style='vertical-align:top'>
270
-               <button class='more_info_b large_button' id='g_info_b_" . $operatingSystem['device'] . "'>i</button>
270
+               <button class='more_info_b large_button' id='g_info_b_" . $operatingSystem['device']."'>i</button>
271 271
           </td>
272 272
       </tr>
273 273
     </table> <!-- id='browser' -->
274 274
     <div class='sub_h'>
275
-       <a href='javascript:other_installers()'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE] . "</a>
275
+       <a href='javascript:other_installers()'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE]."</a>
276 276
     </div>
277 277
 </div> <!-- id='guess_os' -->";
278 278
     }
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
             </td>";
289 289
 
290 290
         if (!empty(CONFIG['APPEARANCE']['privacy_notice_url'])) {
291
-            $retval .= "<td><a href='" . CONFIG['APPEARANCE']['privacy_notice_url'] . "'>" . sprintf(_("%s Privacy Notice"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) . "</a></td>";
291
+            $retval .= "<td><a href='".CONFIG['APPEARANCE']['privacy_notice_url']."'>".sprintf(_("%s Privacy Notice"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])."</a></td>";
292 292
         }
293 293
         $retval .= "<td>";
294 294
         if (CONFIG_CONFASSISTANT['CONSORTIUM']['name'] == "eduroam" && isset(CONFIG_CONFASSISTANT['CONSORTIUM']['deployment-voodoo']) && CONFIG_CONFASSISTANT['CONSORTIUM']['deployment-voodoo'] == "Operations Team") {
Please login to merge, or discard this patch.
web/skins/modern/copyright.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
             <div id="user_page" style="display:block">
36 36
                 <?php echo $divs->divPagetitle("eduroam CAT Copyright and Licensing", ""); ?>
37 37
                 <div style="padding:20px">
38
-            <?php require dirname(dirname(__DIR__)) . "/copyright.inc.php"; ?>
38
+            <?php require dirname(dirname(__DIR__))."/copyright.inc.php"; ?>
39 39
                 </div>
40 40
             </div>
41 41
         </div>
Please login to merge, or discard this patch.
web/skins/modern/index.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,10 +43,10 @@  discard block
 block discarded – undo
43 43
 $operatingSystem = $Gui->detectOS();
44 44
 $Gui->loggerInstance->debug(4, $operatingSystem);
45 45
 if ($operatingSystem) {
46
-    print "recognisedOS = '" . $operatingSystem['device'] . "';\n";
46
+    print "recognisedOS = '".$operatingSystem['device']."';\n";
47 47
 }
48 48
 
49
-print 'downloadMessage = "' . $Gui->textTemplates->templates[\web\lib\user\DOWNLOAD_MESSAGE] . '";';
49
+print 'downloadMessage = "'.$Gui->textTemplates->templates[\web\lib\user\DOWNLOAD_MESSAGE].'";';
50 50
 //TODO modify this based on OS detection
51 51
 $userAgent = $_SERVER['HTTP_USER_AGENT'] ?? "";
52 52
 if (preg_match('/Android/', $userAgent)) {
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     <?php echo $divs->divHeading($visibility); ?>
76 76
     <div id="main_page">
77 77
         <div id="loading_ico">
78
-          <?php echo _("Authenticating") . "..." ?><br><img src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/loading51.gif"); ?>" alt="Authenticating ..."/>
78
+          <?php echo _("Authenticating")."..." ?><br><img src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/loading51.gif"); ?>" alt="Authenticating ..."/>
79 79
         </div>
80 80
         <div id="info_overlay"> <!-- device info -->
81 81
             <div id="info_window"></div>
Please login to merge, or discard this patch.
web/skins/modern/test.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
          <?php if (empty($_REQUEST['idp'])) { ?>
92 92
               <div id="front_page">
93 93
                   <?php
94
-                         echo $divs->divTopWelcome();
94
+                            echo $divs->divTopWelcome();
95 95
 //                         echo $divs->div_roller();
96 96
 //                         echo $divs->div_main_button(); ?>
97 97
               </div> <!-- id="front_page" -->
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -28,9 +28,9 @@  discard block
 block discarded – undo
28 28
 ?>
29 29
 
30 30
 <!-- JQuery -->
31
-<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL","jquery/jquery.js") ?>"></script>
32
-<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL","jquery/jquery-migrate-1.2.1.js") ?>"></script>
33
-<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL","jquery/jquery-ui.js") ?>"></script>
31
+<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL", "jquery/jquery.js") ?>"></script>
32
+<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL", "jquery/jquery-migrate-1.2.1.js") ?>"></script>
33
+<script type="text/javascript" src="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL", "jquery/jquery-ui.js") ?>"></script>
34 34
 <!-- JQuery -->
35 35
 
36 36
 <script type="text/javascript">
@@ -44,10 +44,10 @@  discard block
 block discarded – undo
44 44
 $operatingSystem = $Gui->detectOS();
45 45
 $Gui->loggerInstance->debug(4, $operatingSystem);
46 46
 if ($operatingSystem) {
47
-    print "recognisedOS = '" . $operatingSystem['device'] . "';\n";
47
+    print "recognisedOS = '".$operatingSystem['device']."';\n";
48 48
 }
49 49
 
50
-print 'downloadMessage = "' . $Gui->textTemplates->templates[\web\lib\user\DOWNLOAD_MESSAGE] . '";';
50
+print 'downloadMessage = "'.$Gui->textTemplates->templates[\web\lib\user\DOWNLOAD_MESSAGE].'";';
51 51
 //TODO modify this based on OS detection
52 52
 if (preg_match('/Android/', $_SERVER['HTTP_USER_AGENT'])) {
53 53
     $profile_list_size = 1;
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 include("user/js/cat_js.php");
59 59
 ?>
60 60
     var loading_ico = new Image();
61
-    loading_ico.src = "<?php echo $Gui->skinObject->findResourceUrl("IMAGES","icons/loading51.gif")?>";
61
+    loading_ico.src = "<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/loading51.gif")?>";
62 62
 </script>
63 63
 <?php $Gui->langObject->setTextDomain("web_user"); ?>
64 64
 <!-- DiscoJuice -->
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
     front_page = 0;
68 68
     var lang = "<?php echo($Gui->langObject->getLang()) ?>";
69 69
 </script>
70
-<link rel="stylesheet" type="text/css" href="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL","discojuice/css/discojuice.css")?>" />
70
+<link rel="stylesheet" type="text/css" href="<?php echo $Gui->skinObject->findResourceUrl("EXTERNAL", "discojuice/css/discojuice.css")?>" />
71 71
 <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1.0, user-scalable=no">
72
-<link rel="stylesheet" media="screen" type="text/css" href="<?php echo $Gui->skinObject->findResourceUrl("CSS","cat-user.css");?>" />
72
+<link rel="stylesheet" media="screen" type="text/css" href="<?php echo $Gui->skinObject->findResourceUrl("CSS", "cat-user.css"); ?>" />
73 73
 </head>
74 74
 <body>
75 75
 <div id="wrap">
@@ -77,14 +77,14 @@  discard block
 block discarded – undo
77 77
     <?php echo $divs->divHeading($visibility); ?>
78 78
     <div id="main_page">
79 79
         <div id="loading_ico">
80
-          <?php echo _("Authenticating") . "..." ?><br><img src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES","icons/loading51.gif")?>" alt="Authenticating ..."/>
80
+          <?php echo _("Authenticating")."..." ?><br><img src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/loading51.gif")?>" alt="Authenticating ..."/>
81 81
         </div>
82 82
         <div id="info_overlay"> <!-- device info -->
83 83
             <div id="info_window"></div>
84
-            <img id="info_menu_close" class="close_button" src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES","icons/button_cancel.png")?>" ALT="Close"/>
84
+            <img id="info_menu_close" class="close_button" src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/button_cancel.png")?>" ALT="Close"/>
85 85
         </div>
86 86
         <div id="main_menu_info" style="display:none"> <!-- stuff triggered form main menu -->
87
-          <img id="main_menu_close" class="close_button" src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES","icons/button_cancel.png")?>" ALT="Close"/>
87
+          <img id="main_menu_close" class="close_button" src="<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "icons/button_cancel.png")?>" ALT="Close"/>
88 88
           <div id="main_menu_content"></div>
89 89
         </div>
90 90
         <div id="main_body">
Please login to merge, or discard this patch.
web/admin/inc/manageNewInst.inc.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  */
21 21
 ?>
22 22
 <?php
23
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $uiElements = new \web\lib\admin\UIElements();
@@ -57,8 +57,8 @@  discard block
 block discarded – undo
57 57
 <?php
58 58
 echo sprintf(_("On this page, you can add a new %s to your %s. Please fill out the form below to send out an email invitation to the new %s administrator."), $uiElements->nomenclatureInst, $uiElements->nomenclatureFed, $uiElements->nomenclatureInst);
59 59
 if (CONFIG['DB']['enforce-external-sync']) {
60
-    echo "<p>" . sprintf(_("You can either register a known %s (as defined in the %s database) or create a totally new %s."), $uiElements->nomenclatureInst, CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $uiElements->nomenclatureInst) . "</p>";
61
-    echo "<p>" . sprintf(_("The latter one is typically for an %s which is yet in a testing phase and therefore doesn't appear in the %s database yet."), $uiElements->nomenclatureInst, CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) . "</p>";    
60
+    echo "<p>".sprintf(_("You can either register a known %s (as defined in the %s database) or create a totally new %s."), $uiElements->nomenclatureInst, CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $uiElements->nomenclatureInst)."</p>";
61
+    echo "<p>".sprintf(_("The latter one is typically for an %s which is yet in a testing phase and therefore doesn't appear in the %s database yet."), $uiElements->nomenclatureInst, CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])."</p>";    
62 62
 }
63 63
 ?>
64 64
 <hr/>
@@ -68,12 +68,12 @@  discard block
 block discarded – undo
68 68
         <?php
69 69
         if (CONFIG['DB']['enforce-external-sync']) {
70 70
             echo "<tr><td>
71
-                <input type='radio' name='creation' value='existing'>" . _("Existing IdP:") . "</input>
71
+                <input type='radio' name='creation' value='existing'>" . _("Existing IdP:")."</input>
72 72
                      </td>";
73 73
 
74 74
             echo "<td colspan='2'>
75 75
                 <select id='externals' name='externals' onchange='document.sendinvite.creation[0].checked=true; document.sendinvite.mailaddr.value=this.options[this.selectedIndex].id;'>
76
-                    <option value='FREETEXT'>" . _("--- select IdP here ---") . "</option>";
76
+                    <option value='FREETEXT'>" . _("--- select IdP here ---")."</option>";
77 77
 
78 78
             foreach ($feds as $fed_value) {
79 79
                 $thefed = new \core\Federation(strtoupper($fed_value['value']));
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
                 $entities = $thefed->listExternalEntities(TRUE, \core\Federation::EDUROAM_DB_TYPE_IDP);
83 83
 
84 84
                 foreach ($entities as $v) {
85
-                    echo "<option id='" . $v['contactlist'] . "' value='" . $v['ID'] . "'>[" . $fed_value['value'] . "] " . $v['name'] . "</option>";
85
+                    echo "<option id='".$v['contactlist']."' value='".$v['ID']."'>[".$fed_value['value']."] ".$v['name']."</option>";
86 86
                 }
87 87
             }
88 88
 
Please login to merge, or discard this patch.
devices/Devices-template.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
                             "eduroamCAT",
378 378
                             "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>",
379 379
                             "<a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>",
380
-                            "<a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
380
+                            "<a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
381 381
                 ],
382 382
             ],
383 383
             'android_pie' => [
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
                             "eduroamCAT",
393 393
                             "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>",
394 394
                             "<a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>",
395
-                            "<a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
395
+                            "<a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
396 396
                 ],
397 397
             ],
398 398
             'android_oreo' => [
@@ -407,7 +407,7 @@  discard block
 block discarded – undo
407 407
                             "eduroamCAT",
408 408
                             "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>",
409 409
                             "<a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>",
410
-                            "<a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
410
+                            "<a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
411 411
                 ],
412 412
             ],
413 413
             'android_nougat' => [
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
                             "eduroamCAT",
423 423
                             "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>",
424 424
                             "<a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>",
425
-                            "<a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
425
+                            "<a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
426 426
                 ],
427 427
             ],
428 428
             'android_marshmallow' => [
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
437 437
                             "eduroamCAT",
438 438
                             "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>",
439 439
                             "<a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>",
440
-                            "<a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
440
+                            "<a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
441 441
                 ],
442 442
             ],
443 443
             'android_lollipop' => [
@@ -452,7 +452,7 @@  discard block
 block discarded – undo
452 452
                             "eduroamCAT",
453 453
                             "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>",
454 454
                             "<a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>",
455
-                            "<a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
455
+                            "<a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
456 456
                 ],
457 457
             ],
458 458
             'android_kitkat' => [
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
                             "eduroamCAT",
468 468
                             "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>",
469 469
                             "<a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>",
470
-                            "<a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
470
+                            "<a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
471 471
                 ],
472 472
             ],
473 473
             'android_43' => [
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
                             "eduroamCAT",
483 483
                             "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>",
484 484
                             "<a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>",
485
-                            "<a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
485
+                            "<a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
486 486
                 ],
487 487
             ],
488 488
             'android_legacy' => [
Please login to merge, or discard this patch.
core/UserAPI.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         $this->installerPath = $cache['path'];
84 84
         if ($this->installerPath !== NULL && $token === NULL && $password === NULL) {
85 85
             $this->loggerInstance->debug(4, "Using cached installer for: $device\n");
86
-            $installerProperties['link'] = "API.php?action=downloadInstaller&lang=" . $this->languageInstance->getLang() . "&profile=$profileId&device=$device&generatedfor=$generatedFor";
86
+            $installerProperties['link'] = "API.php?action=downloadInstaller&lang=".$this->languageInstance->getLang()."&profile=$profileId&device=$device&generatedfor=$generatedFor";
87 87
             $installerProperties['mime'] = $cache['mime'];
88 88
         } else {
89 89
             $myInstaller = $this->generateNewInstaller($device, $profile, $generatedFor, $token, $password);
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
             $this->loggerInstance->debug(5, "generateNewInstaller() - Device setup done");
172 172
             $installer = $dev->writeInstaller();
173 173
             $this->loggerInstance->debug(5, "generateNewInstaller() - writeInstaller complete");
174
-            $iPath = $dev->FPATH . '/tmp/' . $installer;
174
+            $iPath = $dev->FPATH.'/tmp/'.$installer;
175 175
             if ($iPath && is_file($iPath)) {
176 176
                 if (isset($dev->options['mime'])) {
177 177
                     $out['mime'] = $dev->options['mime'];
@@ -179,17 +179,17 @@  discard block
 block discarded – undo
179 179
                     $info = new \finfo();
180 180
                     $out['mime'] = $info->file($iPath, FILEINFO_MIME_TYPE);
181 181
                 }
182
-                $this->installerPath = $dev->FPATH . '/' . $installer;
182
+                $this->installerPath = $dev->FPATH.'/'.$installer;
183 183
                 rename($iPath, $this->installerPath);
184 184
                 $integerEap = (new \core\common\EAP($dev->selectedEap))->getIntegerRep();
185 185
                 $profile->updateCache($device, $this->installerPath, $out['mime'], $integerEap);
186 186
                 if (CONFIG['DEBUG_LEVEL'] < 4) {
187
-                    \core\common\Entity::rrmdir($dev->FPATH . '/tmp');
187
+                    \core\common\Entity::rrmdir($dev->FPATH.'/tmp');
188 188
                 }
189
-                $this->loggerInstance->debug(4, "Generated installer: " . $this->installerPath . ": for: $device, EAP:" . $integerEap . "\n");
190
-                $out['link'] = "API.php?action=downloadInstaller&lang=" . $this->languageInstance->getLang() . "&profile=" . $profile->identifier . "&device=$device&generatedfor=$generatedFor";
189
+                $this->loggerInstance->debug(4, "Generated installer: ".$this->installerPath.": for: $device, EAP:".$integerEap."\n");
190
+                $out['link'] = "API.php?action=downloadInstaller&lang=".$this->languageInstance->getLang()."&profile=".$profile->identifier."&device=$device&generatedfor=$generatedFor";
191 191
             } else {
192
-                $this->loggerInstance->debug(2, "Installer generation failed for: " . $profile->identifier . ":$device:" . $this->languageInstance->getLang() . "\n");
192
+                $this->loggerInstance->debug(2, "Installer generation failed for: ".$profile->identifier.":$device:".$this->languageInstance->getLang()."\n");
193 193
                 $out['link'] = 0;
194 194
             }
195 195
         }
@@ -302,9 +302,9 @@  discard block
 block discarded – undo
302 302
         $file = $this->installerPath;
303 303
         $filetype = $output['mime'];
304 304
         $this->loggerInstance->debug(4, "installer MIME type:$filetype\n");
305
-        header("Content-type: " . $filetype);
306
-        header('Content-Disposition: inline; filename="' . basename($file) . '"');
307
-        header('Content-Length: ' . filesize($file));
305
+        header("Content-type: ".$filetype);
306
+        header('Content-Disposition: inline; filename="'.basename($file).'"');
307
+        header('Content-Length: '.filesize($file));
308 308
         ob_clean();
309 309
         flush();
310 310
         readfile($file);
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
         $filetype = $info->buffer($inputImage, FILEINFO_MIME_TYPE);
326 326
         $offset = 60 * 60 * 24 * 30;
327 327
         // gmdate cannot fail here - time() is its default argument (and integer), and we are adding an integer to it
328
-        $expiresString = "Expires: " . /** @scrutinizer ignore-type */ gmdate("D, d M Y H:i:s", time() + $offset) . " GMT";
328
+        $expiresString = "Expires: "./** @scrutinizer ignore-type */ gmdate("D, d M Y H:i:s", time() + $offset)." GMT";
329 329
         $blob = $inputImage;
330 330
 
331 331
         if ($resize === TRUE) {
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
         $filetype = 'image/png'; // default, only one code path where it can become different
381 381
         list($width, $height, $resize) = $this->testForResize($widthIn, $heightIn);
382 382
         if ($resize) {
383
-            $logoFile = ROOT . '/web/downloads/logos/' . $identifier . '_' . $width . '_' . $height . '.png';
383
+            $logoFile = ROOT.'/web/downloads/logos/'.$identifier.'_'.$width.'_'.$height.'.png';
384 384
         }
385 385
         if (is_file($logoFile)) { // $logoFile could be an empty string but then we will get a FALSE
386 386
             $this->loggerInstance->debug(4, "Using cached logo $logoFile for: $identifier\n");
@@ -473,7 +473,7 @@  discard block
 block discarded – undo
473 473
             if (!isset($device['match'])) {
474 474
                 continue;
475 475
             }
476
-            if (preg_match('/' . $device['match'] . '/', $browser)) {
476
+            if (preg_match('/'.$device['match'].'/', $browser)) {
477 477
                 return $this->returnDevice($devId, $device);
478 478
             }
479 479
         }
Please login to merge, or discard this patch.
web/diag/findRealm.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
  * @return boolean
37 37
  */
38 38
 
39
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
39
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
40 40
 
41 41
 // we are referring to $_SESSION later in the file
42 42
 CAT_session_start();
Please login to merge, or discard this patch.
web/user/faq.inc.php 2 patches
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -23,54 +23,54 @@
 block discarded – undo
23 23
     this is just an include file for Gui class definition
24 24
 */
25 25
     $Faq = [
26
-      [
26
+        [
27 27
         'id'=>'idp_not_listed',
28 28
         'title'=>_("My organisation is not listed. Can't I just use any of the other ones?"),
29 29
         'text'=>_("No! The installers contain security settings which are specific to the organisation. If you are not from that organisation, your device will detect that you are about to send your username and credential to an unauthorised server and will abort the login. Using an installer from a different organisation is <i>guaranteed to not work</i>!")
30
-         ],
31
-      [
30
+            ],
31
+        [
32 32
         'id'=>'idp_not_listed',
33 33
         'title'=>_("What can I do to get my organisation listed?"),
34 34
         'text'=>sprintf(_("Contact %s administrators within your organisation and request that they add their organisation to the system. It will take at most one hour of their time to get things done."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
35 35
 ],
36
-      [
36
+        [
37 37
         'id'=>'device_not_listed',
38 38
         'title'=>sprintf(_("My device is not listed! Does that mean I can't do %s?"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
39 39
         'text'=>sprintf(_("No. The CAT tool can only support Operating Systems which can be automatically configured in some way. Many other devices can still be used with %s, but must be configured manually. Please contact your organisation to get help in setting up such a device."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
40
-      ],
40
+        ],
41 41
 
42
-      [
42
+        [
43 43
         'title'=>sprintf(_("I can connect to %s simply by providing username and password, what is the point of using an installer?"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
44 44
         'text'=>sprintf(_("When you are connecting from an unconfigured device your security is at risk. The very point of preconfiguration is to set up security, when this is done, your device will first confirm that it talks to the correct authentication server and will never send your password to an untrusted one."))
45 45
 ],
46
-      [
46
+        [
47 47
         'title'=>sprintf(_("Is it safe to use %s installers?"),CONFIG['APPEARANCE']['productname']),
48 48
         'text'=>sprintf(_("%s installers configure security settings on your device, therefore you should be sure that you are using genuine ones."),CONFIG['APPEARANCE']['productname']).' '.( isset(CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']) && CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'] != "" ? sprintf(_("This is why %s installers are digitally signed by %s. Watch out for a system message confirming this."),CONFIG['APPEARANCE']['productname'],CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']):""),
49 49
         
50 50
 ],
51
-      [
51
+        [
52 52
         'title'=>_("Windows 'SmartScreen' or 'Internet Explorer' tell me that the file is not commonly downloaded and possibly harmful. Should I be concerned?"),
53 53
         'text'=>_("Contrary to what the name suggests, 'SmartScreen' isn't actually very smart. The warning merely means that the file has not yet been downloaded by enough users to make Microsoft consider it popular (which would strangely enough make it be considered 'safe'). This message alone is not a security problem.")." ".(isset(CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']) && CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'] != "" ? sprintf(_("So long as the file is carrying a valid signature from %s, the download is safe."),CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'])." ":"").sprintf(_("Please see also Microsoft's FAQ regarding SmartScreen at %s."),"<a href='http://windows.microsoft.com/en-US/windows7/SmartScreen-Filter-frequently-asked-questions-IE9?SignedIn=1'>Microsoft FAQ</a>")
54 54
         
55 55
 ],
56
-      [
56
+        [
57 57
         'title'=>sprintf(_("I can see %s network and my device is configured but it does not connect, what can be the cause?"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
58
-      'text'=>sprintf(_("There can be a number of different reasons. The network you see may not be a genuine %s one and your device silently drops the connection attempt; there may be something wrong with the configuration of the network; your account may have expired; there may be a connection problem with your home authentication server; you may have broken the regulations of the network you are using and have been refused access as a consequence. You should contact your organisation and report the problem, the administrators should be able to trace your connections."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
58
+        'text'=>sprintf(_("There can be a number of different reasons. The network you see may not be a genuine %s one and your device silently drops the connection attempt; there may be something wrong with the configuration of the network; your account may have expired; there may be a connection problem with your home authentication server; you may have broken the regulations of the network you are using and have been refused access as a consequence. You should contact your organisation and report the problem, the administrators should be able to trace your connections."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
59 59
 ],
60
-      [
60
+        [
61 61
         'id'=>'contact',
62 62
         'title'=>sprintf(_("I have a question about this web site. Whom should I contact?")),
63 63
         'text'=>sprintf(_("You should send a mail to %s."),CONFIG['APPEARANCE']['support-contact']['display'])
64
-      ],
64
+        ],
65 65
 ];
66 66
 
67 67
     if (CONFIG_CONFASSISTANT['CONSORTIUM']['name'] == "eduroam") {
68 68
         $eduroamDb = new core\ExternalEduroamDBData();
69 69
         $SPs = $eduroamDb->allServiceProviders();
70
-       array_push($Faq,
71
-         [
72
-           'id'=>'what_is_'.CONFIG_CONFASSISTANT['CONSORTIUM']['name'],
73
-           'title'=>sprintf(_("What is this %s thing anyway?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
74
-           'text'=>sprintf(_("%s is a global WiFi roaming consortium which gives members of education and research access to the internet <i>for free</i> on all %s hotspots on the planet. There are several million %s users already, enjoying free internet access on more than %d hotspots! Visit <a href='http://www.eduroam.org'>the %s homepage</a> or <a href='http://monitor.eduroam.org/map_service_loc.php'>the %s location map</a> for more details."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $SPs, CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
75
-         ]);
70
+        array_push($Faq,
71
+            [
72
+            'id'=>'what_is_'.CONFIG_CONFASSISTANT['CONSORTIUM']['name'],
73
+            'title'=>sprintf(_("What is this %s thing anyway?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
74
+            'text'=>sprintf(_("%s is a global WiFi roaming consortium which gives members of education and research access to the internet <i>for free</i> on all %s hotspots on the planet. There are several million %s users already, enjoying free internet access on more than %d hotspots! Visit <a href='http://www.eduroam.org'>the %s homepage</a> or <a href='http://monitor.eduroam.org/map_service_loc.php'>the %s location map</a> for more details."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $SPs, CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
75
+            ]);
76 76
     }
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -31,36 +31,36 @@  discard block
 block discarded – undo
31 31
       [
32 32
         'id'=>'idp_not_listed',
33 33
         'title'=>_("What can I do to get my organisation listed?"),
34
-        'text'=>sprintf(_("Contact %s administrators within your organisation and request that they add their organisation to the system. It will take at most one hour of their time to get things done."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
34
+        'text'=>sprintf(_("Contact %s administrators within your organisation and request that they add their organisation to the system. It will take at most one hour of their time to get things done."), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
35 35
 ],
36 36
       [
37 37
         'id'=>'device_not_listed',
38
-        'title'=>sprintf(_("My device is not listed! Does that mean I can't do %s?"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
39
-        'text'=>sprintf(_("No. The CAT tool can only support Operating Systems which can be automatically configured in some way. Many other devices can still be used with %s, but must be configured manually. Please contact your organisation to get help in setting up such a device."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
38
+        'title'=>sprintf(_("My device is not listed! Does that mean I can't do %s?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
39
+        'text'=>sprintf(_("No. The CAT tool can only support Operating Systems which can be automatically configured in some way. Many other devices can still be used with %s, but must be configured manually. Please contact your organisation to get help in setting up such a device."), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
40 40
       ],
41 41
 
42 42
       [
43
-        'title'=>sprintf(_("I can connect to %s simply by providing username and password, what is the point of using an installer?"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
43
+        'title'=>sprintf(_("I can connect to %s simply by providing username and password, what is the point of using an installer?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
44 44
         'text'=>sprintf(_("When you are connecting from an unconfigured device your security is at risk. The very point of preconfiguration is to set up security, when this is done, your device will first confirm that it talks to the correct authentication server and will never send your password to an untrusted one."))
45 45
 ],
46 46
       [
47
-        'title'=>sprintf(_("Is it safe to use %s installers?"),CONFIG['APPEARANCE']['productname']),
48
-        'text'=>sprintf(_("%s installers configure security settings on your device, therefore you should be sure that you are using genuine ones."),CONFIG['APPEARANCE']['productname']).' '.( isset(CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']) && CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'] != "" ? sprintf(_("This is why %s installers are digitally signed by %s. Watch out for a system message confirming this."),CONFIG['APPEARANCE']['productname'],CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']):""),
47
+        'title'=>sprintf(_("Is it safe to use %s installers?"), CONFIG['APPEARANCE']['productname']),
48
+        'text'=>sprintf(_("%s installers configure security settings on your device, therefore you should be sure that you are using genuine ones."), CONFIG['APPEARANCE']['productname']).' '.(isset(CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']) && CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'] != "" ? sprintf(_("This is why %s installers are digitally signed by %s. Watch out for a system message confirming this."), CONFIG['APPEARANCE']['productname'], CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']) : ""),
49 49
         
50 50
 ],
51 51
       [
52 52
         'title'=>_("Windows 'SmartScreen' or 'Internet Explorer' tell me that the file is not commonly downloaded and possibly harmful. Should I be concerned?"),
53
-        'text'=>_("Contrary to what the name suggests, 'SmartScreen' isn't actually very smart. The warning merely means that the file has not yet been downloaded by enough users to make Microsoft consider it popular (which would strangely enough make it be considered 'safe'). This message alone is not a security problem.")." ".(isset(CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']) && CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'] != "" ? sprintf(_("So long as the file is carrying a valid signature from %s, the download is safe."),CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'])." ":"").sprintf(_("Please see also Microsoft's FAQ regarding SmartScreen at %s."),"<a href='http://windows.microsoft.com/en-US/windows7/SmartScreen-Filter-frequently-asked-questions-IE9?SignedIn=1'>Microsoft FAQ</a>")
53
+        'text'=>_("Contrary to what the name suggests, 'SmartScreen' isn't actually very smart. The warning merely means that the file has not yet been downloaded by enough users to make Microsoft consider it popular (which would strangely enough make it be considered 'safe'). This message alone is not a security problem.")." ".(isset(CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name']) && CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'] != "" ? sprintf(_("So long as the file is carrying a valid signature from %s, the download is safe."), CONFIG_CONFASSISTANT['CONSORTIUM']['signer_name'])." " : "").sprintf(_("Please see also Microsoft's FAQ regarding SmartScreen at %s."), "<a href='http://windows.microsoft.com/en-US/windows7/SmartScreen-Filter-frequently-asked-questions-IE9?SignedIn=1'>Microsoft FAQ</a>")
54 54
         
55 55
 ],
56 56
       [
57
-        'title'=>sprintf(_("I can see %s network and my device is configured but it does not connect, what can be the cause?"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
58
-      'text'=>sprintf(_("There can be a number of different reasons. The network you see may not be a genuine %s one and your device silently drops the connection attempt; there may be something wrong with the configuration of the network; your account may have expired; there may be a connection problem with your home authentication server; you may have broken the regulations of the network you are using and have been refused access as a consequence. You should contact your organisation and report the problem, the administrators should be able to trace your connections."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
57
+        'title'=>sprintf(_("I can see %s network and my device is configured but it does not connect, what can be the cause?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
58
+      'text'=>sprintf(_("There can be a number of different reasons. The network you see may not be a genuine %s one and your device silently drops the connection attempt; there may be something wrong with the configuration of the network; your account may have expired; there may be a connection problem with your home authentication server; you may have broken the regulations of the network you are using and have been refused access as a consequence. You should contact your organisation and report the problem, the administrators should be able to trace your connections."), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
59 59
 ],
60 60
       [
61 61
         'id'=>'contact',
62 62
         'title'=>sprintf(_("I have a question about this web site. Whom should I contact?")),
63
-        'text'=>sprintf(_("You should send a mail to %s."),CONFIG['APPEARANCE']['support-contact']['display'])
63
+        'text'=>sprintf(_("You should send a mail to %s."), CONFIG['APPEARANCE']['support-contact']['display'])
64 64
       ],
65 65
 ];
66 66
 
@@ -71,6 +71,6 @@  discard block
 block discarded – undo
71 71
          [
72 72
            'id'=>'what_is_'.CONFIG_CONFASSISTANT['CONSORTIUM']['name'],
73 73
            'title'=>sprintf(_("What is this %s thing anyway?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']),
74
-           'text'=>sprintf(_("%s is a global WiFi roaming consortium which gives members of education and research access to the internet <i>for free</i> on all %s hotspots on the planet. There are several million %s users already, enjoying free internet access on more than %d hotspots! Visit <a href='http://www.eduroam.org'>the %s homepage</a> or <a href='http://monitor.eduroam.org/map_service_loc.php'>the %s location map</a> for more details."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'],CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $SPs, CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
74
+           'text'=>sprintf(_("%s is a global WiFi roaming consortium which gives members of education and research access to the internet <i>for free</i> on all %s hotspots on the planet. There are several million %s users already, enjoying free internet access on more than %d hotspots! Visit <a href='http://www.eduroam.org'>the %s homepage</a> or <a href='http://monitor.eduroam.org/map_service_loc.php'>the %s location map</a> for more details."), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $SPs, CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])
75 75
          ]);
76 76
     }
Please login to merge, or discard this patch.