Test Failed
Push — master ( a0369a...56fe09 )
by Tomasz
10:10
created
web/lib/admin/Wizard.php 2 patches
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -89,13 +89,13 @@  discard block
 block discarded – undo
89 89
                 $ssidlist .= ", '<strong>" . $ssid . "</strong>'";
90 90
             }
91 91
             $ssidlist = substr($ssidlist, 2);
92
-             $h .= sprintf(ngettext("We will always configure this SSID for WPA2/AES: %s.", "We will always configure these SSIDs for WPA2/AES: %s.", count(\config\ConfAssistant::CONSORTIUM['ssid'])), $ssidlist);
93
-             $h .= "<br/>" . sprintf(_("It is also possible to define custom additional SSIDs with the option '%s' below."), $this->displayName("media:SSID"));
92
+                $h .= sprintf(ngettext("We will always configure this SSID for WPA2/AES: %s.", "We will always configure these SSIDs for WPA2/AES: %s.", count(\config\ConfAssistant::CONSORTIUM['ssid'])), $ssidlist);
93
+                $h .= "<br/>" . sprintf(_("It is also possible to define custom additional SSIDs with the option '%s' below."), $this->displayName("media:SSID"));
94 94
         } else {
95
-             $h .=  _("Please configure which SSIDs should be configured in the installers.");
95
+                $h .=  _("Please configure which SSIDs should be configured in the installers.");
96 96
         }
97
-         $h .= " " . _("By default, we will only configure the SSIDs with WPA2/AES encryption. By using the '(with WPA/TKIP)' option you can specify that we should include legacy support for WPA/TKIP where possible.");
98
-         $h .= "</li>";
97
+            $h .= " " . _("By default, we will only configure the SSIDs with WPA2/AES encryption. By using the '(with WPA/TKIP)' option you can specify that we should include legacy support for WPA/TKIP where possible.");
98
+            $h .= "</li>";
99 99
 
100 100
         $h .= "<li>";
101 101
         $h .= "<strong>" . ( count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0 ? _("Additional Hotspot 2.0 / Passpoint Consortia:") : _("Hotspot 2.0 / Passpoint Consortia:")) . " </strong>";
@@ -135,19 +135,19 @@  discard block
 block discarded – undo
135 135
             "<p>" . _("Optionally, you can provide a longer descriptive text about who this profile is for. If you specify it, it will be displayed on the download page after the user has selected the profile name in the list.") . "</p>".
136 136
             "<p>" . _("You can also tell us your RADIUS realm. ");
137 137
             if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] !== NULL) {
138
-               $h .= sprintf(_("This is useful if you want to use the sanity check module later, which tests reachability of your realm in the %s infrastructure. "), \config\ConfAssistant::CONSORTIUM['display_name']);
138
+                $h .= sprintf(_("This is useful if you want to use the sanity check module later, which tests reachability of your realm in the %s infrastructure. "), \config\ConfAssistant::CONSORTIUM['display_name']);
139 139
             }
140 140
         $h .= _("It is required to enter the realm name if you want to support anonymous outer identities (see below).") . "</p>";
141 141
         $this->helpMessage['profile'] = $h;
142 142
         
143 143
         // REALM
144 144
         $h = "<p>".sprintf(_("Some installers support a feature called 'Anonymous outer identity'. If you don't know what this is, please read <a href='%s'>this article</a>."), "https://confluence.terena.org/display/H2eduroam/eap-types")."</p>".
145
-          "<p>"._("On some platforms, the installers can suggest username endings and/or verify the user input to contain the realm suffix.")."</p>".
146
-          "<p>"._("The realm check feature needs to know an outer ID which actually gets a chance to authenticate. If your RADIUS server lets only select usernames pass, it is useful to supply the information which of those (outer ID) username we can use for testing.")."</p>";
145
+            "<p>"._("On some platforms, the installers can suggest username endings and/or verify the user input to contain the realm suffix.")."</p>".
146
+            "<p>"._("The realm check feature needs to know an outer ID which actually gets a chance to authenticate. If your RADIUS server lets only select usernames pass, it is useful to supply the information which of those (outer ID) username we can use for testing.")."</p>";
147 147
         $this->helpMessage['realm'] = $h;
148 148
         
149 149
         // REDIRECT
150
-         $h ="<p>"._("The CAT has a download area for end users. There, they will, for example, learn about the support pointers you entered earlier. The CAT can also immediately offer the installers for the profile for download. If you don't want that, you can instead enter a web site location where you want your users to be redirected to. You, as the administrator, can still download the profiles to place them on that page (see the 'Compatibility Matrix' button on the dashboard).") . "</p>";
150
+            $h ="<p>"._("The CAT has a download area for end users. There, they will, for example, learn about the support pointers you entered earlier. The CAT can also immediately offer the installers for the profile for download. If you don't want that, you can instead enter a web site location where you want your users to be redirected to. You, as the administrator, can still download the profiles to place them on that page (see the 'Compatibility Matrix' button on the dashboard).") . "</p>";
151 151
         $this->helpMessage['redirect'] = $h;
152 152
         
153 153
         // EAP
Please login to merge, or discard this patch.
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -107,85 +107,85 @@  discard block
 block discarded – undo
107 107
         foreach ($optionsList as $option) {
108 108
             $this->optionsHelp[$option] = $this->displayName($option, true);
109 109
         }
110
-        array_multisort(array_column($this->optionsHelp,'display'), SORT_ASC, $this->optionsHelp);
110
+        array_multisort(array_column($this->optionsHelp, 'display'), SORT_ASC, $this->optionsHelp);
111 111
     }
112 112
     
113 113
     public function setMessages() {
114 114
         // FED general
115
-        $h = "<p><h3>" . _("Here you set federation-level options.") . "</h3><p>";
116
-        $h .= "<i>" . _("The following options are available:") . "</i><p>";
115
+        $h = "<p><h3>"._("Here you set federation-level options.")."</h3><p>";
116
+        $h .= "<i>"._("The following options are available:")."</i><p>";
117 117
         if (isset($this->optionsHelp)) {
118 118
             $h .= "<dl>";
119 119
             foreach ($this->optionsHelp as $o) {
120
-                $h .= "<dt>". $o['display'] . "</dt>";
121
-                $h .= "<dd>" . $o['help'] . "</dd>";
120
+                $h .= "<dt>".$o['display']."</dt>";
121
+                $h .= "<dd>".$o['help']."</dd>";
122 122
             }
123 123
             $h .= "</dl>";
124 124
         }
125 125
         $this->helpMessage['fed_general'] = $h;
126 126
         // SUPPORT
127
-        $h = "<p>" . _("This section can be used to upload specific Terms of Use for your users and to display details of how your users can reach your local helpdesk.") . "</p>";
127
+        $h = "<p>"._("This section can be used to upload specific Terms of Use for your users and to display details of how your users can reach your local helpdesk.")."</p>";
128 128
         if (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_RADIUS'] == "LOCAL") {
129
-            $h .= "<p>" .
130
-            sprintf(_("Do you provide helpdesk services for your users? If so, it would be nice if you would tell us the pointers to this helpdesk."), $this->nomenclatureParticipant) . "</p>" .
131
-            "<p>" .
132
-            _("If you enter a value here, it will be added to the installers for all your users, and will be displayed on the download page. If you operate separate helpdesks for different user groups (we call this 'profiles') specify per-profile helpdesk information later in this wizard. If you operate no help desk at all, just leave these fields empty.") . "</p>";
129
+            $h .= "<p>".
130
+            sprintf(_("Do you provide helpdesk services for your users? If so, it would be nice if you would tell us the pointers to this helpdesk."), $this->nomenclatureParticipant)."</p>".
131
+            "<p>".
132
+            _("If you enter a value here, it will be added to the installers for all your users, and will be displayed on the download page. If you operate separate helpdesks for different user groups (we call this 'profiles') specify per-profile helpdesk information later in this wizard. If you operate no help desk at all, just leave these fields empty.")."</p>";
133 133
             if (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_SILVERBULLET'] == "LOCAL") {
134
-                $h .= "<p>" . sprintf(_("For %s deployments, providing at least a local e-mail contact is required."), \config\ConfAssistant::SILVERBULLET['product_name']) . " " . _("This is the contact point for your organisation. It may be displayed publicly.") . "</p>";
134
+                $h .= "<p>".sprintf(_("For %s deployments, providing at least a local e-mail contact is required."), \config\ConfAssistant::SILVERBULLET['product_name'])." "._("This is the contact point for your organisation. It may be displayed publicly.")."</p>";
135 135
             }
136 136
         } elseif (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_SILVERBULLET'] == "LOCAL") {
137
-            $h .= "<p>" . _("Providing at least a local support e-mail contact is required.") . " " . _("This is the contact point for your end users' level 1 support.") . "</p>";
137
+            $h .= "<p>"._("Providing at least a local support e-mail contact is required.")." "._("This is the contact point for your end users' level 1 support.")."</p>";
138 138
         }
139 139
         $this->helpMessage['support'] = $h;
140 140
 
141 141
         // MEDIA
142
-        $h = "<p>" .
143
-            sprintf(_("In this section, you define on which media %s should be configured on user devices."), \config\ConfAssistant::CONSORTIUM['display_name']) . "</p><ul>";
142
+        $h = "<p>".
143
+            sprintf(_("In this section, you define on which media %s should be configured on user devices."), \config\ConfAssistant::CONSORTIUM['display_name'])."</p><ul>";
144 144
         $h .= "<li>";
145
-        $h .= "<strong>" . ( count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0 ? _("Additional SSIDs:") : _("SSIDs:")) . " </strong>";
145
+        $h .= "<strong>".(count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0 ? _("Additional SSIDs:") : _("SSIDs:"))." </strong>";
146 146
         if (count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0) {
147 147
             $ssidlist = "";
148 148
             foreach (\config\ConfAssistant::CONSORTIUM['ssid'] as $ssid) {
149
-                $ssidlist .= ", '<strong>" . $ssid . "</strong>'";
149
+                $ssidlist .= ", '<strong>".$ssid."</strong>'";
150 150
             }
151 151
             $ssidlist = substr($ssidlist, 2);
152 152
              $h .= sprintf(ngettext("We will always configure this SSID for WPA2/AES: %s.", "We will always configure these SSIDs for WPA2/AES: %s.", count(\config\ConfAssistant::CONSORTIUM['ssid'])), $ssidlist);
153
-             $h .= "<br/>" . sprintf(_("It is also possible to define custom additional SSIDs with the option '%s' below."), $this->displayName("media:SSID"));
153
+             $h .= "<br/>".sprintf(_("It is also possible to define custom additional SSIDs with the option '%s' below."), $this->displayName("media:SSID"));
154 154
         } else {
155
-             $h .=  _("Please configure which SSIDs should be configured in the installers.");
155
+             $h .= _("Please configure which SSIDs should be configured in the installers.");
156 156
         }
157
-         $h .= " " . _("By default, we will only configure the SSIDs with WPA2/AES encryption. By using the '(with WPA/TKIP)' option you can specify that we should include legacy support for WPA/TKIP where possible.");
157
+         $h .= " "._("By default, we will only configure the SSIDs with WPA2/AES encryption. By using the '(with WPA/TKIP)' option you can specify that we should include legacy support for WPA/TKIP where possible.");
158 158
          $h .= "</li>";
159 159
 
160 160
         $h .= "<li>";
161
-        $h .= "<strong>" . ( count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0 ? _("Additional Hotspot 2.0 / Passpoint Consortia:") : _("Hotspot 2.0 / Passpoint Consortia:")) . " </strong>";
161
+        $h .= "<strong>".(count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0 ? _("Additional Hotspot 2.0 / Passpoint Consortia:") : _("Hotspot 2.0 / Passpoint Consortia:"))." </strong>";
162 162
         if (count(\config\ConfAssistant::CONSORTIUM['interworking-consortium-oi']) > 0) {
163 163
             $consortiumlist = "";
164 164
             foreach (\config\ConfAssistant::CONSORTIUM['interworking-consortium-oi'] as $oi) {
165
-                $consortiumlist .= ", '<strong>" . $oi . "</strong>'";
165
+                $consortiumlist .= ", '<strong>".$oi."</strong>'";
166 166
             }
167 167
             $consortiumlist = substr($consortiumlist, 2);
168 168
             $h .= sprintf(ngettext("We will always configure this Consortium OI: %s.", "We will always configure these Consortium OIs: %s.", count(\config\ConfAssistant::CONSORTIUM['interworking-consortium-oi'])), $consortiumlist);
169 169
 
170
-            $h .= "<br/>" . sprintf(_("It is also possible to define custom additional OIs with the option '%s' below."), $this->displayName("media:consortium_OI"));
170
+            $h .= "<br/>".sprintf(_("It is also possible to define custom additional OIs with the option '%s' below."), $this->displayName("media:consortium_OI"));
171 171
         } else {
172 172
             $h .= _("Please configure which Consortium OIs should be configured in the installers.");
173 173
         }
174 174
         $h .= "</li>";
175
-        $h .= "<li><strong>" . _("Support for wired IEEE 802.1X:") . " </strong>"
176
-        . _("If you want to configure your users' devices with IEEE 802.1X support for wired ethernet, please check the corresponding box. Note that this makes the installation process a bit more difficult on some platforms (Windows: needs administrator privileges; Apple: attempting to install a profile with wired support on a device without an active wired ethernet card will fail).") .
175
+        $h .= "<li><strong>"._("Support for wired IEEE 802.1X:")." </strong>"
176
+        . _("If you want to configure your users' devices with IEEE 802.1X support for wired ethernet, please check the corresponding box. Note that this makes the installation process a bit more difficult on some platforms (Windows: needs administrator privileges; Apple: attempting to install a profile with wired support on a device without an active wired ethernet card will fail).").
177 177
         "</li>";
178
-        $h .= "<li><strong>" . _("Removal of bootstrap/onboarding SSIDs:") . " </strong>"
178
+        $h .= "<li><strong>"._("Removal of bootstrap/onboarding SSIDs:")." </strong>"
179 179
         . _("If you use a captive portal to distribute configurations, you may want to unconfigure/disable that SSID after the bootstrap process. With this option, the SSID will either be removed, or be defined as 'Only connect manually'.")
180 180
         . "</li>";
181 181
         $h .= "</ul>";
182 182
         $this->helpMessage['media'] = $h;
183 183
         
184 184
         // IDP GENERAL
185
-        $h = "<p>" .
186
-        _("Some properties are valid across all deployment profiles. This is the place where you can describe those properties in a fine-grained way. The solicited information is used as follows:") . "</p>".
185
+        $h = "<p>".
186
+        _("Some properties are valid across all deployment profiles. This is the place where you can describe those properties in a fine-grained way. The solicited information is used as follows:")."</p>".
187 187
             "<ul>".
188
-                "<li>"._("<strong>Logo</strong>: When you submit a logo, we will embed this logo into all installers where a custom logo is possible. We accept any image format, but for best results, we suggest SVG. If you don't upload a logo, we will use the generic logo instead (see top-right corner of this page).") . "</li>".
188
+                "<li>"._("<strong>Logo</strong>: When you submit a logo, we will embed this logo into all installers where a custom logo is possible. We accept any image format, but for best results, we suggest SVG. If you don't upload a logo, we will use the generic logo instead (see top-right corner of this page).")."</li>".
189 189
                 "<li>".sprintf(_("<strong>%s</strong>: The organisation may have names in multiple languages. It is recommended to always populate at least the 'default/other' language, as it is used as a fallback if the system does not have a name in the exact language the user requests a download in."), $this->displayName("general:instname"))."</li>".
190 190
                 "<li>".sprintf(_("<strong>%s</strong>: This acronym will be used as an element of the installer file name instead of one automatically created from first letters of every word in the institution name. You may add acronyms for multiple languages (but only one per language). The acronym will also be used as a keyword for the organisation search on the user's downloads page."), $this->displayName("general:instshortname"))."</li>".
191 191
                 "<li>".sprintf(_("<strong>%s</strong>: You may add several versions of the organisation name or acronyms which will be used as additional keywords exclusively for the organisation search on the user's downloads page."), $this->displayName("general:instaltname"))."</li>".
@@ -193,13 +193,13 @@  discard block
 block discarded – undo
193 193
         $this->helpMessage['idp_general'] = $h;
194 194
         
195 195
         // PROFILE GENERAL
196
-        $h = "<p>" . _("First of all we need a name for the profile. This will be displayed to end users, so you may want to choose a descriptive name like 'Professors', 'Students of the Faculty of Bioscience', etc.") . "</p>".
197
-            "<p>" . _("Optionally, you can provide a longer descriptive text about who this profile is for. If you specify it, it will be displayed on the download page after the user has selected the profile name in the list.") . "</p>".
198
-            "<p>" . _("You can also tell us your RADIUS realm. ");
196
+        $h = "<p>"._("First of all we need a name for the profile. This will be displayed to end users, so you may want to choose a descriptive name like 'Professors', 'Students of the Faculty of Bioscience', etc.")."</p>".
197
+            "<p>"._("Optionally, you can provide a longer descriptive text about who this profile is for. If you specify it, it will be displayed on the download page after the user has selected the profile name in the list.")."</p>".
198
+            "<p>"._("You can also tell us your RADIUS realm. ");
199 199
             if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] !== NULL) {
200 200
                $h .= sprintf(_("This is useful if you want to use the sanity check module later, which tests reachability of your realm in the %s infrastructure. "), \config\ConfAssistant::CONSORTIUM['display_name']);
201 201
             }
202
-        $h .= _("It is required to enter the realm name if you want to support anonymous outer identities (see below).") . "</p>";
202
+        $h .= _("It is required to enter the realm name if you want to support anonymous outer identities (see below).")."</p>";
203 203
         $this->helpMessage['profile'] = $h;
204 204
         
205 205
         // REALM
@@ -209,24 +209,24 @@  discard block
 block discarded – undo
209 209
         $this->helpMessage['realm'] = $h;
210 210
         
211 211
         // REDIRECT
212
-         $h ="<p>"._("The CAT has a download area for end users. There, they will, for example, learn about the support pointers you entered earlier. The CAT can also immediately offer the installers for the profile for download. If you don't want that, you can instead enter a web site location where you want your users to be redirected to. You, as the administrator, can still download the profiles to place them on that page (see the 'Compatibility Matrix' button on the dashboard).") . "</p>";
212
+         $h = "<p>"._("The CAT has a download area for end users. There, they will, for example, learn about the support pointers you entered earlier. The CAT can also immediately offer the installers for the profile for download. If you don't want that, you can instead enter a web site location where you want your users to be redirected to. You, as the administrator, can still download the profiles to place them on that page (see the 'Compatibility Matrix' button on the dashboard).")."</p>";
213 213
         $this->helpMessage['redirect'] = $h;
214 214
         
215 215
         // EAP
216
-        $h = "<p>"._("Now, we need to know which EAP types your IdP supports. If you support multiple EAP types, you can assign every type a priority (1=highest). This tool will always generate an automatic installer for the EAP type with the highest priority; only if the user's device can't use that EAP type, we will use an EAP type further down in the list.") . "</p>";
216
+        $h = "<p>"._("Now, we need to know which EAP types your IdP supports. If you support multiple EAP types, you can assign every type a priority (1=highest). This tool will always generate an automatic installer for the EAP type with the highest priority; only if the user's device can't use that EAP type, we will use an EAP type further down in the list.")."</p>";
217 217
         $this->helpMessage['eap_support'] = $h;
218 218
         
219 219
         // LOCATIOM
220
-        $h = "<p>" .
221
-                    _("The user download interface (see <a href='../'>here</a>), uses geolocation to suggest possibly matching IdPs to the user. The more precise you define the location here, the easier your users will find you.") .
220
+        $h = "<p>".
221
+                    _("The user download interface (see <a href='../'>here</a>), uses geolocation to suggest possibly matching IdPs to the user. The more precise you define the location here, the easier your users will find you.").
222 222
                     "</p>
223 223
                      <ul>" .
224 224
                     _("<li>Drag the marker in the map to your place, or</li>
225 225
 <li>enter your street address in the field below for lookup, or</li>
226
-<li>use the 'Locate Me!' button</li>") .
226
+<li>use the 'Locate Me!' button</li>").
227 227
                     "</ul>
228 228
                      <strong>" .
229
-                    _("We will use the coordinates as indicated by the marker for geolocation.") .
229
+                    _("We will use the coordinates as indicated by the marker for geolocation.").
230 230
                     "</strong>";
231 231
         $this->helpMessage['location'] = $h;
232 232
     }
Please login to merge, or discard this patch.
web/admin/sort_profiles_result.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 ?>
28 28
 
29 29
 <?php
30
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
30
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
31 31
 
32 32
 $deco = new \web\lib\admin\PageDecoration();
33 33
 $validator = new \web\lib\common\InputValidation();
Please login to merge, or discard this patch.
web/admin/duplicate_profile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 ?>
28 28
 
29 29
 <?php
30
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
30
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
31 31
 
32 32
 $deco = new \web\lib\admin\PageDecoration();
33 33
 $validator = new \web\lib\common\InputValidation();
Please login to merge, or discard this patch.
web/admin/duplicate_profile_result.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 ?>
30 30
 
31 31
 <?php
32
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
32
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
33 33
 
34 34
 $deco = new \web\lib\admin\PageDecoration();
35 35
 $validator = new \web\lib\common\InputValidation();
@@ -101,13 +101,13 @@  discard block
 block discarded – undo
101 101
     } 
102 102
 }
103 103
 
104
-$newProfileName =  $validator->string($_POST['new_profile'], true);
104
+$newProfileName = $validator->string($_POST['new_profile'], true);
105 105
 $origProfileName = $validator->string($_POST['orig_profile_name'], true);
106 106
 $handle = \core\DBConnection::handle("INST");
107 107
 
108 108
 $result = runSelect($my_profile->identifier, $fields, 'profile', $handle);
109 109
 $row = $result->fetch_assoc();
110
-$row['showtime']= 0;
110
+$row['showtime'] = 0;
111 111
 $row['preference'] = 1000;
112 112
 copyRow($row, $fields, 'profile', $handle);
113 113
 $newProfileId = $handle->lastID();
Please login to merge, or discard this patch.
web/diag/adminQuery.php 1 patch
Spacing   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  * License: see the web/copyright.inc.php file in the file structure or
20 20
  *          <base_url>/copyright.php after deploying the software
21 21
  */
22
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
23 23
 $languageInstance = new \core\common\Language();
24 24
 $languageInstance->setTextDomain("diagnostics");
25 25
 $loggerInstance = new \core\common\Logging();
@@ -63,47 +63,47 @@  discard block
 block discarded – undo
63 63
     $select = "<div id='sp_abuse_problem'>
64 64
 <select style='margin-left: 0px;' id='select_sp_problem'>";
65 65
     foreach ($sp_problem as $pname => $pdesc) {
66
-        $select = $select . "<option value='$pname'>$pdesc</option>\n";
66
+        $select = $select."<option value='$pname'>$pdesc</option>\n";
67 67
     }
68
-    $select = $select . "</select></div>";
68
+    $select = $select."</select></div>";
69 69
     $res = "
70 70
 <input type='hidden' name='token' id='token' value=''>
71 71
 <input type='hidden' name='tests_result' id='tests_result' value=''>
72 72
 <table id='sp_questions'>
73 73
     <tr id='sp_problem_selector'>
74
-        <td>" . _("Select your problem") . "</td>
74
+        <td>" . _("Select your problem")."</td>
75 75
         <td>$select</td>
76 76
     </tr>
77 77
     <tr>
78
-        <td>" . _("What is the realm of the IdP in question?") . "</td>
78
+        <td>"._("What is the realm of the IdP in question?")."</td>
79 79
         <td>
80 80
                 <input type='text' name='admin_realm' id='admin_realm' value='$realmFromURL'>
81
-                <button class='diag_button' id='realm_in_db_admin' style='display: none;' accesskey='R' type='button'>" .
82
-                _("Check this realm") .
81
+                <button class='diag_button' id='realm_in_db_admin' style='display: none;' accesskey='R' type='button'>".
82
+                _("Check this realm").
83 83
                 "</button>
84 84
                 <div id='tests_info_area'></div>
85 85
         </td>
86 86
     </tr>
87 87
     <tr id='outer_user_row' class='hidden_row'>
88
-        <td>" . _("Do you prefer to use a specific outer identity for diagnostics test?") . "</td>
88
+        <td>" . _("Do you prefer to use a specific outer identity for diagnostics test?")."</td>
89 89
         <td>  <input type='text' name='outer_user' id='outer_user' value=''><span id='outer_user_realm'></span>
90 90
     </tr>
91 91
     <tr class='hidden_row'>
92
-        <td>" . _("What is the authentication timestamp of the user session in question?") . "</td>
92
+        <td>" . _("What is the authentication timestamp of the user session in question?")."</td>
93 93
         <td><input type='text' id='timestamp' name='timestamp'>
94 94
             <div id='datepicker'></div>
95 95
         </td>
96 96
     </tr>
97 97
     <tr class='hidden_row'>
98
-        <td>" . _("What is the MAC address of the user session in question?") . "</td>
98
+        <td>" . _("What is the MAC address of the user session in question?")."</td>
99 99
         <td><input type='text' id='mac' name='mac'></td>
100 100
     </tr>
101 101
     <tr class='hidden_row'>
102
-        <td>" . _("Additional comments") . "</td>
102
+        <td>" . _("Additional comments")."</td>
103 103
         <td><textarea id='freetext' name='freetext' cols='60' rows='5'></textarea></td>
104 104
     </tr>
105 105
     <tr class='hidden_row'>
106
-        <td>" . _("Please specify an email address on which the IdP can contact you") . "</td>
106
+        <td>" . _("Please specify an email address on which the IdP can contact you")."</td>
107 107
         <td><input type='text' id='email' name='email'></td>
108 108
     </tr>
109 109
     <tr>
@@ -111,82 +111,82 @@  discard block
 block discarded – undo
111 111
         <td></td>
112 112
     </tr>
113 113
     <tr class='hidden_row' id='send_query_to_idp'>
114
-        <td>" . _("Now you can send your query") . "</td>
115
-        <td><button type='submit' class='diag_button' id='submit_idp_query' name='go'>" . _("Send") . "</button></td>
114
+        <td>" . _("Now you can send your query")."</td>
115
+        <td><button type='submit' class='diag_button' id='submit_idp_query' name='go'>" . _("Send")."</button></td>
116 116
     </tr>
117 117
  </table>";
118
-    $res = $res . $javascript;
118
+    $res = $res.$javascript;
119 119
 }
120 120
 if ($queryType == 'idp') {
121 121
     $select = "<div id='idp_reported_problem' style='display:;'>
122 122
 <select style='margin-left:0px;' id='select_idp_problem'>";
123 123
     foreach ($idp_problem as $pname => $pdesc) {
124
-        $select = $select . "<option value='$pname'>$pdesc</option>\n";
124
+        $select = $select."<option value='$pname'>$pdesc</option>\n";
125 125
     }
126
-    $select = $select . "</select></div>";
126
+    $select = $select."</select></div>";
127 127
     $res = "
128 128
 <table id='idp_questions'>
129 129
     <tr>
130
-        <td>" . _("Select your problem") . "</td>
130
+        <td>" . _("Select your problem")."</td>
131 131
         <td>$select</td>
132 132
     </tr>
133 133
     <tr>
134
-        <td>" . _("Identify the SP by one of following means") . "</td>
134
+        <td>"._("Identify the SP by one of following means")."</td>
135 135
         <td></td>
136 136
     </tr>
137 137
     <tr id='by_opname'>
138
-        <td>" . _("SP Operator-Name attribute") . "</td>
138
+        <td>" . _("SP Operator-Name attribute")."</td>
139 139
         <td><input type='text' id='opname' name='opname' value=''></td>
140 140
     </tr>
141 141
     <tr id='spmanually'>
142
-        <td>" . _("Select the SP manually:") . "</td>
142
+        <td>" . _("Select the SP manually:")."</td>
143 143
         <td>
144 144
             <div id='select_asp_country'><a href='' id='asp_countries_list'>
145
-            <span id='opnameselect'>" . _("click to select country and organisation") . "</a></span>
145
+            <span id='opnameselect'>" . _("click to select country and organisation")."</a></span>
146 146
             </div>
147 147
             <div id='select_asp_area'></div>
148 148
         </td>
149 149
     </tr>
150 150
     <tr id='asp_desc' style='display: none;'>
151
-        <td>" . _("or") . ' ' . _("at least describe the SP location") . "</td>
151
+        <td>" . _("or").' '._("at least describe the SP location")."</td>
152 152
         <td><input type='text' id='asp_location' name='asp_location' value=''></td>
153 153
     </tr>
154 154
     <tr>
155
-        <td>" . _("What is the outer ID of the user session in question?") . "</td>
155
+        <td>" . _("What is the outer ID of the user session in question?")."</td>
156 156
         <td><input type='text' id='outer_id' name='outer_id' value=''></td>
157 157
     </tr>
158 158
     <tr>
159
-        <td>" . _("What is the authentication timestamp of the user session in question?") . "</td>
159
+        <td>" . _("What is the authentication timestamp of the user session in question?")."</td>
160 160
         <td>
161 161
             <input type='text' id='timestamp' name='timestamp'>
162 162
             <div id='datepicker'></div>
163 163
         </td>
164 164
     </tr>
165 165
     <tr>
166
-        <td>" . _("What is the MAC address of the user session in question?") . "</td>
166
+        <td>" . _("What is the MAC address of the user session in question?")."</td>
167 167
         <td><input type='text' id='mac' name='mac'></td>
168 168
     </tr>
169 169
     <tr>
170
-        <td>" . _("Additional comments about the problem") . "</td>
170
+        <td>" . _("Additional comments about the problem")."</td>
171 171
         <td><textarea id='freetext' name='freetext' cols='60' rows='5'></textarea></td>
172 172
     </tr>
173 173
     <tr>
174
-        <td>" . _("Do you have any contact details by which the user wishes to be contacted by the SP?") . "</td>
174
+        <td>" . _("Do you have any contact details by which the user wishes to be contacted by the SP?")."</td>
175 175
         <td><textarea id='c_details' name='c_details' cols='60' rows='5'></textarea></td>
176 176
     </tr>
177 177
     <tr>
178
-        <td>" . _("Please specify an email address on which the SP can contact you") . "</td>
178
+        <td>" . _("Please specify an email address on which the SP can contact you")."</td>
179 179
         <td><input type='text' id='email' name='email'></td>
180 180
     </tr>
181 181
     <tr class='hidden_row' id='send_query_to_sp'>
182
-        <td>" . _("Now you can send your query") . "</td>
183
-        <td><button type='submit' class='diag_button' id='submit_sp_query' name='go'>" . _("Send") . "</button></td>
182
+        <td>" . _("Now you can send your query")."</td>
183
+        <td><button type='submit' class='diag_button' id='submit_sp_query' name='go'>" . _("Send")."</button></td>
184 184
     </tr>
185 185
 </table>";
186
-    $res = $res . $javascript;
186
+    $res = $res.$javascript;
187 187
 }
188 188
 if ($queryType == 'idp_send' || $queryType == 'sp_send') {
189
-    include_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
189
+    include_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
190 190
     $cat = new \core\CAT();
191 191
     $returnArray = array();
192 192
     if (count((array) $o) > 0) {
@@ -195,8 +195,8 @@  discard block
 block discarded – undo
195 195
             switch ($key) {
196 196
                 case 'realm':
197 197
                     $pos = strpos($value, '@');
198
-                    if ($pos !== FALSE ) {
199
-                        $value = substr($value, $pos+1);
198
+                    if ($pos !== FALSE) {
199
+                        $value = substr($value, $pos + 1);
200 200
                     }
201 201
                 case 'email':
202 202
                     $returnArray[$key] = filter_var($value, FILTER_VALIDATE_EMAIL);
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
         $mail = \core\common\OutsideComm::mailHandle();
238 238
         $emails = ['[email protected]'];
239 239
         //$emails = explode(',', $returnArray['idpcontact']);
240
-        $mail->FromName = \config\Master::APPEARANCE['productname'] . " Notification System";
240
+        $mail->FromName = \config\Master::APPEARANCE['productname']." Notification System";
241 241
         foreach ($emails as $email) {
242 242
             $mail->addAddress($email);
243 243
         }
@@ -247,11 +247,11 @@  discard block
 block discarded – undo
247 247
         } else {
248 248
             $link = 'http://';
249 249
         }
250
-        $link .= $_SERVER['SERVER_NAME'] . \core\CAT::getRootUrlPath() . '/diag/show_realmcheck.php?token=' . $returnArray['token'];
250
+        $link .= $_SERVER['SERVER_NAME'].\core\CAT::getRootUrlPath().'/diag/show_realmcheck.php?token='.$returnArray['token'];
251 251
         $returnArray['testurl'] = $link;
252 252
         $mail->Subject = _('Suspected a technical problem with the IdP');
253
-        $txt = _("We suspect a technical problem with the IdP handling the realm") . ' ' . 
254
-                $returnArray['realm'] . ".\n";
253
+        $txt = _("We suspect a technical problem with the IdP handling the realm").' '. 
254
+                $returnArray['realm'].".\n";
255 255
         $txt .= _("The CAT diagnostic test was run for this realm during reporting.\n");
256 256
         $txt .= _("The overall result was ");
257 257
         if ($returnArray['tests_result'] == 0) {
@@ -259,15 +259,15 @@  discard block
 block discarded – undo
259 259
         } else {
260 260
             $txt .= _("failure");
261 261
         }
262
-        $txt .= ".\n" . _("To see details go to ");
262
+        $txt .= ".\n"._("To see details go to ");
263 263
         $txt .= "$link\n\n";
264
-        $txt .= _("The reported problem details are as follows") . "\n";
265
-        $txt .= _("timestamp") . ": " . $returnArray['timestamp'] . "\n";
266
-        $txt .= _("client MAC address") . ": " . $returnArray['mac'] . "\n";
264
+        $txt .= _("The reported problem details are as follows")."\n";
265
+        $txt .= _("timestamp").": ".$returnArray['timestamp']."\n";
266
+        $txt .= _("client MAC address").": ".$returnArray['mac']."\n";
267 267
         if ($returnArray['freetext']) {
268
-            $txt .= _("additional comments") . ': ' . $returnArray['freetext'] . "\n";
268
+            $txt .= _("additional comments").': '.$returnArray['freetext']."\n";
269 269
         }
270
-        $txt .= "\n" . _("You can contact the incident reporter at") . ' ' . $returnArray['email'];
270
+        $txt .= "\n"._("You can contact the incident reporter at").' '.$returnArray['email'];
271 271
         
272 272
         $mail->Body = $txt;
273 273
         $sent = $mail->send();
Please login to merge, or discard this patch.
web/diag/findRealm.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
             $telepath = new \core\diag\Telepath($givenRealm);
109 109
             $outerUser = $telepath->getOuter();
110 110
         }
111
-        $testsuite = new \core\diag\RADIUSTests($givenRealm, $outerUser . '@' . $givenRealm);
111
+        $testsuite = new \core\diag\RADIUSTests($givenRealm, $outerUser.'@'.$givenRealm);
112 112
        
113 113
         $naptr = $rfc7585suite->relevantNAPTR(); 
114 114
         if ($naptr != \core\diag\RADIUSTests::RETVAL_NOTCONFIGURED && $naptr > 0) {
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 $json_data = json_encode($returnArray);
207 207
 
208 208
 if ($token) {
209
-    $loggerInstance->debug(4, 'JSON data written to ' .$jsonDir.'/'.$token);
209
+    $loggerInstance->debug(4, 'JSON data written to '.$jsonDir.'/'.$token);
210 210
     file_put_contents($jsonDir.'/'.$token.'/realm', $json_data);
211 211
 }
212 212
 header("Content-type: application/json; utf-8");
Please login to merge, or discard this patch.
core/AbstractProfile.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
                     // for now (no OpenRoaming client certs available) only run server-side tests
333 333
                     foreach ($listOfIPs as $oneIP) {
334 334
                         $connectionResult = $connectionTests->cApathCheck($oneIP);
335
-                        if ($connectionResult != \core\diag\AbstractTest::RETVAL_OK || ( isset($connectionTests->TLS_CA_checks_result['cert_oddity']) && count($connectionTests->TLS_CA_checks_result['cert_oddity']) > 0)) {
335
+                        if ($connectionResult != \core\diag\AbstractTest::RETVAL_OK || (isset($connectionTests->TLS_CA_checks_result['cert_oddity']) && count($connectionTests->TLS_CA_checks_result['cert_oddity']) > 0)) {
336 336
                             $allHostsOkay = FALSE;
337 337
                         } else {
338 338
                             $oneHostOkay = TRUE;
@@ -486,7 +486,7 @@  discard block
 block discarded – undo
486 486
             // which is different from the outer username we put into installers
487 487
             return $this->getAttributes("internal:checkuser_value")[0]['value']."@".$realm;
488 488
         }
489
-        if (count($this->getAttributes("internal:use_anon_outer")) > 0 && $this->getAttributes("internal:anon_local_value")[0]['value'] != NULL ) {
489
+        if (count($this->getAttributes("internal:use_anon_outer")) > 0 && $this->getAttributes("internal:anon_local_value")[0]['value'] != NULL) {
490 490
             // no special check username, but there is an anon outer ID for
491 491
             // installers - so let's use that one
492 492
             return $this->getAttributes("internal:anon_local_value")[0]['value']."@".$realm;
@@ -642,7 +642,7 @@  discard block
 block discarded – undo
642 642
         }
643 643
 
644 644
         $monthlyList = [];
645
-        $monthly = $this->frontendHandle->exec("SELECT downloads_user,device_id FROM downloads_history WHERE profile_id=? AND stat_date=DATE_FORMAT(NOW(),'%Y-%m-01')", "i",  $this->identifier);
645
+        $monthly = $this->frontendHandle->exec("SELECT downloads_user,device_id FROM downloads_history WHERE profile_id=? AND stat_date=DATE_FORMAT(NOW(),'%Y-%m-01')", "i", $this->identifier);
646 646
         while ($statsQuery = mysqli_fetch_object(/** @scrutinizer ignore-type */ $monthly)) {
647 647
             $monthlyList[$statsQuery->device_id] = $statsQuery->downloads_user;
648 648
         }
@@ -654,7 +654,7 @@  discard block
 block discarded – undo
654 654
         }        
655 655
         
656 656
         \core\common\Entity::intoThePotatoes();
657
-        ksort($finalarray, SORT_STRING|SORT_FLAG_CASE);
657
+        ksort($finalarray, SORT_STRING | SORT_FLAG_CASE);
658 658
         \core\common\Entity::outOfThePotatoes();
659 659
         return $finalarray;
660 660
     }
@@ -964,7 +964,7 @@  discard block
 block discarded – undo
964 964
         $profileStatus = self::CERT_STATUS_NONE;
965 965
         foreach ($rows as $row) {
966 966
             $encodedCert = $row[0];
967
-            $tm = $x509->processCertificate(base64_decode($encodedCert))['full_details']['validTo_time_t']- time();
967
+            $tm = $x509->processCertificate(base64_decode($encodedCert))['full_details']['validTo_time_t'] - time();
968 968
             if ($tm < \config\ConfAssistant::CERT_WARNINGS['expiry_critical']) {
969 969
                 $certStatus = self::CERT_STATUS_ERROR;
970 970
             } elseif ($tm < \config\ConfAssistant::CERT_WARNINGS['expiry_warning']) {
Please login to merge, or discard this patch.
web/admin/inc/manageDBLink.inc.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  */
21 21
 ?>
22 22
 <?php
23
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $auth->authenticate();
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
 // if we have a pushed close button, submit attributes and send user back to the overview page
37 37
 // if external DB sync is disabled globally, the user never gets to this page. If he came here *anyway* -> send him back immediately.
38
-if ((isset($_POST['submitbutton']) && $_POST['submitbutton'] == web\lib\common\FormElements::BUTTON_CLOSE ) || \config\Master::DB['enforce-external-sync'] == FALSE) {
38
+if ((isset($_POST['submitbutton']) && $_POST['submitbutton'] == web\lib\common\FormElements::BUTTON_CLOSE) || \config\Master::DB['enforce-external-sync'] == FALSE) {
39 39
     header("Location: ../overview_federation.php");
40 40
     exit;
41 41
 }
@@ -92,9 +92,9 @@  discard block
 block discarded – undo
92 92
     $cat = new \core\CAT();
93 93
     switch ($my_inst->getExternalDBSyncState()) {
94 94
         case \core\IdP::EXTERNAL_DB_SYNCSTATE_SYNCED:
95
-            printf(_("This %s is linked to the %s database."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name']) . "</p>";
96
-            echo "<p>" . sprintf(_("The following information about the IdP is stored in the %s DB and %s DB:"), \config\Master::APPEARANCE['productname'], \config\ConfAssistant::CONSORTIUM['display_name']) . "</p>";
97
-            echo "<table><tr><td>" . sprintf(_("Information in <strong>%s Database</strong>"), \config\Master::APPEARANCE['productname']) . "</td><td>" . sprintf(_("Information in <strong>%s Database</strong>"), \config\ConfAssistant::CONSORTIUM['display_name']) . "</td></tr>";
95
+            printf(_("This %s is linked to the %s database."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name'])."</p>";
96
+            echo "<p>".sprintf(_("The following information about the IdP is stored in the %s DB and %s DB:"), \config\Master::APPEARANCE['productname'], \config\ConfAssistant::CONSORTIUM['display_name'])."</p>";
97
+            echo "<table><tr><td>".sprintf(_("Information in <strong>%s Database</strong>"), \config\Master::APPEARANCE['productname'])."</td><td>".sprintf(_("Information in <strong>%s Database</strong>"), \config\ConfAssistant::CONSORTIUM['display_name'])."</td></tr>";
98 98
             echo "<tr><td>";
99 99
             // left-hand side: CAT DB
100 100
             echo "<table>";
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
                 } else {
107 107
                     $language = \config\Master::LANGUAGES[$name['lang']]['display'] ?? "(unsupported language)";
108 108
                 }
109
-                echo "<tr><td>" . sprintf(_("%s Name (%s)"), $uiElements->nomenclatureParticipant, $language) . "</td><td>" . $name['value'] . "</td></tr>";
109
+                echo "<tr><td>".sprintf(_("%s Name (%s)"), $uiElements->nomenclatureParticipant, $language)."</td><td>".$name['value']."</td></tr>";
110 110
             }
111 111
 
112 112
             $admins = $my_inst->listOwners();
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
                 if (count($username) == 0) {
118 118
                     $username[0]['value'] = _("Unnamed User");
119 119
                 }
120
-                echo "<tr><td>" . _("Administrator [invited as]") . "</td><td>" . $username[0]['value'] . " [" . $admin['MAIL'] . "]</td></tr>";
120
+                echo "<tr><td>"._("Administrator [invited as]")."</td><td>".$username[0]['value']." [".$admin['MAIL']."]</td></tr>";
121 121
             }
122 122
             echo "</table>";
123 123
             // end of left-hand side
@@ -127,38 +127,38 @@  discard block
 block discarded – undo
127 127
             $externalid = $extIdObject->external_db_id;
128 128
             $ROid = $extIdObject->ROid;
129 129
             if (is_bool($extIdObject)) { // we are in SYNCED state so this cannot happen
130
-                throw new Exception("We are in SYNCSTATE_SYNCED but still there is no external DB Id available for the " . $uiElements->nomenclatureParticipant . "!");
130
+                throw new Exception("We are in SYNCSTATE_SYNCED but still there is no external DB Id available for the ".$uiElements->nomenclatureParticipant."!");
131 131
             }
132 132
 
133 133
             $extinfo = $cat->getExternalDBEntityDetails($externalid, $ROid);
134 134
 
135 135
             echo "<table>";
136 136
             foreach ($extinfo['names'] as $lang => $name) {
137
-                echo "<tr><td>" . sprintf(_("%s Name (%s)"), $uiElements->nomenclatureParticipant, $lang) . "</td><td>$name</td>";
137
+                echo "<tr><td>".sprintf(_("%s Name (%s)"), $uiElements->nomenclatureParticipant, $lang)."</td><td>$name</td>";
138 138
             }
139 139
             foreach ($extinfo['admins'] as $number => $admin_details) {
140
-                echo "<tr><td>" . _("Administrator email") . "</td><td>" . $admin_details['email'] . "</td></tr>";
140
+                echo "<tr><td>"._("Administrator email")."</td><td>".$admin_details['email']."</td></tr>";
141 141
             }
142 142
             echo "</table>";
143 143
             // end of right-hand side
144 144
             echo "</td></tr></table>";
145
-            echo "<p>" . _("If this mapping is not correct any more, you can remove the link:") . " ";
145
+            echo "<p>"._("If this mapping is not correct any more, you can remove the link:")." ";
146 146
             echo "<form name='form-unlink-inst' action='inc/manageDBLink.inc.php?inst_id=$my_inst->identifier' method='post' accept-charset='UTF-8'>";
147
-            echo "<button type='submit' class='delete' name='submitbutton' id='submit' value='" . web\lib\common\FormElements::BUTTON_DELETE . "'>" . _("Unlink") . "</button></form>";
147
+            echo "<button type='submit' class='delete' name='submitbutton' id='submit' value='".web\lib\common\FormElements::BUTTON_DELETE."'>"._("Unlink")."</button></form>";
148 148
             break;
149 149
         case \core\IdP::EXTERNAL_DB_SYNCSTATE_NOT_SYNCED:
150 150
             $temparray = [];
151
-            printf(_("This %s is not yet linked to the %s database."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name']) . " ";
152
-            echo "<strong>" . _("This means that its profiles are not made available on the user download page.") . "</strong> ";
151
+            printf(_("This %s is not yet linked to the %s database."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name'])." ";
152
+            echo "<strong>"._("This means that its profiles are not made available on the user download page.")."</strong> ";
153 153
             printf(_("You can link it to the %s database below."), \config\ConfAssistant::CONSORTIUM['display_name']);
154 154
             $candidates = $my_inst->getExternalDBSyncCandidates($my_inst->type);
155 155
             echo "<br/><form name='form-link-inst' action='inc/manageDBLink.inc.php?inst_id=$my_inst->identifier' method='post' accept-charset='UTF-8'>";
156
-            printf(_("Please select an entity from the %s DB which corresponds to this CAT %s."), \config\ConfAssistant::CONSORTIUM['display_name'], $uiElements->nomenclatureParticipant) . " ";
156
+            printf(_("Please select an entity from the %s DB which corresponds to this CAT %s."), \config\ConfAssistant::CONSORTIUM['display_name'], $uiElements->nomenclatureParticipant)." ";
157 157
             if (count($candidates) > 0) {
158 158
                 printf(_("Particularly promising entries (names in CAT and %s DB are a 100%% match) are on top of the list."), \config\ConfAssistant::CONSORTIUM['display_name']);
159 159
             }
160 160
             echo "<table>";
161
-            echo "<tr><th>" . _("Link to this entity?") . "</th><th>" . sprintf(_("%s Name"), $uiElements->nomenclatureParticipant) . "</th><th>" . _("Administrators") . "</th></tr>";
161
+            echo "<tr><th>"._("Link to this entity?")."</th><th>".sprintf(_("%s Name"), $uiElements->nomenclatureParticipant)."</th><th>"._("Administrators")."</th></tr>";
162 162
 
163 163
             foreach ($candidates as $candidate) {
164 164
                 $info = $cat->getExternalDBEntityDetails($candidate, strtoupper($my_inst->federation).'01');
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
                 }
169 169
                 echo "</td><td>";
170 170
                 foreach ($info['admins'] as $number => $admin_details) {
171
-                    echo "[E-Mail] " . $admin_details['email'] . "<br/>";
171
+                    echo "[E-Mail] ".$admin_details['email']."<br/>";
172 172
                 }
173 173
                 echo "</td></tr>";
174 174
                 $temparray[] = $candidate;
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
             $buffer = "";
181 181
 
182 182
             foreach ($unmappedentities as $v) {
183
-                $buffer .= "<option value='" . $v['ID'] . "'>[ID " . $v['ID'] . "] " . $v['name'] . "</option>";
183
+                $buffer .= "<option value='".$v['ID']."'>[ID ".$v['ID']."] ".$v['name']."</option>";
184 184
             }
185 185
 
186 186
             if ($buffer != "") {
@@ -191,9 +191,9 @@  discard block
 block discarded – undo
191 191
             }
192 192
             // issue a big red warning if there are no link candidates at all in the federation
193 193
             if (empty($buffer) && empty($candidates)) {
194
-                echo "<tr><td style='color:#ff0000' colspan='2'>" . sprintf(_('There is no single unmapped %s in the external database for this %s!'), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed) . "</td></tr>";
194
+                echo "<tr><td style='color:#ff0000' colspan='2'>".sprintf(_('There is no single unmapped %s in the external database for this %s!'), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed)."</td></tr>";
195 195
             }
196
-            echo "</table><button type='submit' name='submitbutton' id='submit' value='" . web\lib\common\FormElements::BUTTON_SAVE . "' disabled >" . _("Create Link") . "</button></form>";
196
+            echo "</table><button type='submit' name='submitbutton' id='submit' value='".web\lib\common\FormElements::BUTTON_SAVE."' disabled >"._("Create Link")."</button></form>";
197 197
             break;
198 198
         default:
199 199
     }
Please login to merge, or discard this patch.
web/lib/common/InputValidation.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     private function inputValidationError($customtext)
41 41
     {
42 42
         \core\common\Entity::intoThePotatoes();
43
-        $retval = "<p>" . _("Input validation error: ") . $customtext . "</p>";
43
+        $retval = "<p>"._("Input validation error: ").$customtext."</p>";
44 44
         \core\common\Entity::outOfThePotatoes();
45 45
         return $retval;
46 46
     }
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         $postFed = $fedIdentifiers[$correctIndex];
98 98
         $temp = new \core\Federation($postFed);
99 99
         if ($owner === NULL) {
100
-            return [$temp,'readonly'];
100
+            return [$temp, 'readonly'];
101 101
         }
102 102
         $user = new \core\User($owner);        
103 103
         foreach ($temp->listFederationAdmins() as $oneowner) {
@@ -105,9 +105,9 @@  discard block
 block discarded – undo
105 105
                 return [$temp, 'fullaccess'];
106 106
             }
107 107
         }
108
-        if ($user->isSuperadmin()|| $user->isSupport()) {
108
+        if ($user->isSuperadmin() || $user->isSupport()) {
109 109
                 $this->loggerInstance->debug(4, "You are the superadmin/support\n");
110
-                return [$temp,'readonly'];                
110
+                return [$temp, 'readonly'];                
111 111
             }
112 112
         throw new Exception($this->inputValidationError(sprintf("User is not %s administrator!", \core\common\Entity::$nomenclature_fed)));
113 113
     }
@@ -168,18 +168,18 @@  discard block
 block discarded – undo
168 168
             }
169 169
             if ($user->isFederationAdmin($temp->federation)) {
170 170
                 $this->loggerInstance->debug(4, "You are fed admin for this IdP\n");
171
-                return [$temp,'readonly'];
171
+                return [$temp, 'readonly'];
172 172
             }
173 173
             if ($user->isSuperadmin() || $user->isSupport()) {
174 174
                 $this->loggerInstance->debug(4, "You are the superadmin/support\n");
175
-                return [$temp,'readonly'];                
175
+                return [$temp, 'readonly'];                
176 176
             }
177 177
             throw new Exception($this->inputValidationError("This IdP identifier is not accessible!"));
178 178
         }
179 179
         if ($claimedFedBinding !== NULL && strtoupper($temp->federation) != strtoupper($claimedFedBinding->tld)) {
180 180
             throw new Exception($this->inputValidationError("This IdP does not belong to the claimed federation!"));
181 181
         }
182
-        return [$temp,'nouser'];
182
+        return [$temp, 'nouser'];
183 183
     }
184 184
 
185 185
     /**
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
      * @throws Exception
258 258
      */
259 259
     public function existingExtInstitution($extId, $userEmail = NULL, $ROid = NULL) {
260
-        if ($ROid === NULL || !preg_match('/^[A-Z][A-Z]01$/', $ROid) ) {
260
+        if ($ROid === NULL || !preg_match('/^[A-Z][A-Z]01$/', $ROid)) {
261 261
             throw new Exception("$ROid: No correct federation identifier profided");
262 262
         }
263 263
         if ($userEmail === NULL) {
@@ -645,7 +645,7 @@  discard block
 block discarded – undo
645 645
         try {
646 646
             $image->readImageBlob($binary);
647 647
         } catch (\ImagickException $exception) {
648
-            echo "Error" . $exception->getMessage();
648
+            echo "Error".$exception->getMessage();
649 649
             return FALSE;
650 650
         }
651 651
         // image survived the sanity check
Please login to merge, or discard this patch.