Passed
Push — release_2_1 ( 8ffb06...6b1ac5 )
by Maja
10:32
created
core/User.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -154,8 +154,8 @@  discard block
 block discarded – undo
154 154
         common\Entity::intoThePotatoes();
155 155
         $mail = \core\common\OutsideComm::mailHandle();
156 156
 // who to whom?
157
-        $mail->FromName = \config\Master::APPEARANCE['productname'] . " Notification System";
158
-        $mail->addReplyTo(\config\Master::APPEARANCE['support-contact']['developer-mail'], \config\Master::APPEARANCE['productname'] . " " . _("Feedback"));
157
+        $mail->FromName = \config\Master::APPEARANCE['productname']." Notification System";
158
+        $mail->addReplyTo(\config\Master::APPEARANCE['support-contact']['developer-mail'], \config\Master::APPEARANCE['productname']." "._("Feedback"));
159 159
         $mail->addAddress($mailaddr[0]["value"]);
160 160
 // what do we want to say?
161 161
         $mail->Subject = $subject;
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
                 }
219 219
                 $lookFor .= "$name";
220 220
             }
221
-            $finding = preg_match("/^(" . $lookFor . "):(.*)/", $oneRow->user_id, $matches);
221
+            $finding = preg_match("/^(".$lookFor."):(.*)/", $oneRow->user_id, $matches);
222 222
             if ($finding === 0 || $finding === FALSE) {
223 223
                 return FALSE;
224 224
             }
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
                         $matchedProviders[] = $idp;
237 237
                         $name = $idp;
238 238
                         if ($skipCurl == 0) {
239
-                            $url = \config\Diagnostics::EDUGAINRESOLVER['url'] . "?action=get_entity_name&type=idp&e_id=$idp&lang=$lang";
239
+                            $url = \config\Diagnostics::EDUGAINRESOLVER['url']."?action=get_entity_name&type=idp&e_id=$idp&lang=$lang";
240 240
                             $ch = curl_init($url);
241 241
                             if ($ch === FALSE) {
242 242
                                 $loggerInstance->debug(2, "Unable ask eduGAIN about IdP - CURL init failed!");
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
                             }
253 253
                             curl_close($ch);
254 254
                         }
255
-                        $listOfProviders[] = User::PROVIDER_STRINGS[$providerStrings[0]] . " - IdP: " . $name;
255
+                        $listOfProviders[] = User::PROVIDER_STRINGS[$providerStrings[0]]." - IdP: ".$name;
256 256
                     }
257 257
                     break;
258 258
                 case $providerStrings[1]:
Please login to merge, or discard this patch.
web/user/faq.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -50,19 +50,19 @@  discard block
 block discarded – undo
50 50
 
51 51
 array_push($FAQ, [
52 52
     'title' => sprintf(_("Is it safe to use %s installers?"), \config\Master::APPEARANCE['productname']),
53
-    'text' => sprintf(_("%s installers configure security settings on your device, therefore you should be sure that you are using genuine ones."), \config\Master::APPEARANCE['productname']) . ' ' . ( isset(\config\ConfAssistant::CONSORTIUM['signer_name']) && \config\ConfAssistant::CONSORTIUM['signer_name'] != "" ? sprintf(_("This is why %s installers are digitally signed by %s. Watch out for a system message confirming this."), \config\Master::APPEARANCE['productname'], \config\ConfAssistant::CONSORTIUM['signer_name']) : ""),
53
+    'text' => sprintf(_("%s installers configure security settings on your device, therefore you should be sure that you are using genuine ones."), \config\Master::APPEARANCE['productname']).' '.(isset(\config\ConfAssistant::CONSORTIUM['signer_name']) && \config\ConfAssistant::CONSORTIUM['signer_name'] != "" ? sprintf(_("This is why %s installers are digitally signed by %s. Watch out for a system message confirming this."), \config\Master::APPEARANCE['productname'], \config\ConfAssistant::CONSORTIUM['signer_name']) : ""),
54 54
 ]);
55 55
 
56 56
 array_push($FAQ, [
57 57
     'title' => _("Windows 'SmartScreen' or 'Internet Explorer' tell me that the file is not commonly downloaded and possibly harmful. Should I be concerned?"),
58
-    'text' => _("Contrary to what the name suggests, 'SmartScreen' isn't actually very smart. The warning merely means that the file has not yet been downloaded by enough users to make Microsoft consider it popular (which would strangely enough make it be considered 'safe'). This message alone is not a security problem.") . " " . (isset(\config\ConfAssistant::CONSORTIUM['signer_name']) && \config\ConfAssistant::CONSORTIUM['signer_name'] != "" ? sprintf(_("So long as the file is carrying a valid signature from %s, the download is safe."), \config\ConfAssistant::CONSORTIUM['signer_name']) . " " : "") . sprintf(_("Please see also Microsoft's FAQ regarding SmartScreen at %s."), "<a href='http://windows.microsoft.com/en-US/windows7/SmartScreen-Filter-frequently-asked-questions-IE9?SignedIn=1'>Microsoft FAQ</a>")
58
+    'text' => _("Contrary to what the name suggests, 'SmartScreen' isn't actually very smart. The warning merely means that the file has not yet been downloaded by enough users to make Microsoft consider it popular (which would strangely enough make it be considered 'safe'). This message alone is not a security problem.")." ".(isset(\config\ConfAssistant::CONSORTIUM['signer_name']) && \config\ConfAssistant::CONSORTIUM['signer_name'] != "" ? sprintf(_("So long as the file is carrying a valid signature from %s, the download is safe."), \config\ConfAssistant::CONSORTIUM['signer_name'])." " : "").sprintf(_("Please see also Microsoft's FAQ regarding SmartScreen at %s."), "<a href='http://windows.microsoft.com/en-US/windows7/SmartScreen-Filter-frequently-asked-questions-IE9?SignedIn=1'>Microsoft FAQ</a>")
59 59
 ]);
60 60
 
61 61
 if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] == NULL) {
62 62
     $text = sprintf(_("There can be a number of different reasons. The network you see may not be a genuine %s one and your device silently drops the connection attempt; there may be something wrong with the configuration of the network; your account may have expired; there may be a connection problem with your home authentication server; you may have broken the regulations of the network you are using and have been refused access as a consequence. You should contact your organisation and report the problem, the administrators should be able to trace your connections."), \config\ConfAssistant::CONSORTIUM['display_name']);
63 63
 } else {
64 64
     if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] == 'LOCAL') {
65
-        $diagUrl = \config\Master::PATHS['cat_base_url'] . "diag/";
65
+        $diagUrl = \config\Master::PATHS['cat_base_url']."diag/";
66 66
     } else {
67 67
         $diagUrl = \config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'];
68 68
     }
@@ -99,8 +99,8 @@  discard block
 block discarded – undo
99 99
     $tocText = "";
100 100
     $fullText = "";
101 101
     foreach ($FAQ as $faq) {
102
-        $tocText .= '<a href="#toc' . $counter . '">' . $faq['title'] . "</a><br>\n";
103
-        $fullText .= "<dt><a name=toc$counter>" . $faq['title'] . "</a></dt>\n<dd>" . $faq['text'] . "</dd>\n";
102
+        $tocText .= '<a href="#toc'.$counter.'">'.$faq['title']."</a><br>\n";
103
+        $fullText .= "<dt><a name=toc$counter>".$faq['title']."</a></dt>\n<dd>".$faq['text']."</dd>\n";
104 104
         $counter++;
105 105
     }
106 106
     ?>
Please login to merge, or discard this patch.
core/Options.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -142,17 +142,17 @@  discard block
 block discarded – undo
142 142
         foreach (array_keys($this->typeDb) as $name) {
143 143
             if ($className === 0) {
144 144
                 $tempArray[] = $name;
145
-            } elseif (preg_match('/^' . $className . ':/', $name) > 0) {
145
+            } elseif (preg_match('/^'.$className.':/', $name) > 0) {
146 146
                 $tempArray[] = $name;
147 147
             }
148 148
         }
149 149
         $returnArray = $tempArray;
150 150
         // remove silverbullet-specific options if this deployment is not SB
151 151
         foreach ($tempArray as $key => $val) {
152
-            if (( \config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_SILVERBULLET'] != 'LOCAL') && (preg_match('/^fed:silverbullet/', $val) > 0)) {
152
+            if ((\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_SILVERBULLET'] != 'LOCAL') && (preg_match('/^fed:silverbullet/', $val) > 0)) {
153 153
                 unset($returnArray[$key]);
154 154
             }
155
-            if (( \config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_RADIUS'] != 'LOCAL') && (preg_match('/^fed:minted_ca_file/', $val) > 0)) {
155
+            if ((\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_RADIUS'] != 'LOCAL') && (preg_match('/^fed:minted_ca_file/', $val) > 0)) {
156 156
                 unset($returnArray[$key]);
157 157
             }
158 158
         }
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
         if (isset($this->typeDb[$optionname])) {
173 173
             return $this->typeDb[$optionname];
174 174
         }
175
-        throw new Exception("Metadata about an option was requested, but the option name does not exist in the system: " . htmlentities($optionname));
175
+        throw new Exception("Metadata about an option was requested, but the option name does not exist in the system: ".htmlentities($optionname));
176 176
     }
177 177
 
178 178
     /**
Please login to merge, or discard this patch.
config/_config.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,14 +21,14 @@  discard block
 block discarded – undo
21 21
  */
22 22
 
23 23
 require_once "autoloader.php";
24
-require_once __DIR__ . "/../packageRoot.php";
24
+require_once __DIR__."/../packageRoot.php";
25 25
 
26 26
 // enable Composer autoloader, if exists
27
-if (file_exists(__DIR__ . "/../vendor/autoload.php") !== FALSE) {
28
-    include_once __DIR__ . "/../vendor/autoload.php";
27
+if (file_exists(__DIR__."/../vendor/autoload.php") !== FALSE) {
28
+    include_once __DIR__."/../vendor/autoload.php";
29 29
 }
30 30
 
31
-if (!file_exists(ROOT . "/config/Master.php")) {
31
+if (!file_exists(ROOT."/config/Master.php")) {
32 32
     echo "Master configuration file not found. You need to configure the product! At least config/Master.php is required!";
33 33
     throw new Exception("Master config file not found!");
34 34
 }
@@ -36,14 +36,14 @@  discard block
 block discarded – undo
36 36
 /* load sub-configs if we are dealing with those in this installation */
37 37
 
38 38
 if (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_SILVERBULLET'] == 'LOCAL' || \config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_RADIUS'] == 'LOCAL') {
39
-    if (!file_exists(ROOT . "/config/ConfAssistant.php")) {
39
+    if (!file_exists(ROOT."/config/ConfAssistant.php")) {
40 40
         echo "ConfAssistant configuration file not found. You need to configure the product!";
41 41
         throw new Exception("ConfAssistant config file not found!");
42 42
     }
43 43
 }
44 44
 
45 45
 if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] == 'LOCAL') {
46
-    if (!file_exists(ROOT . "/config/Diagnostics.php")) {
46
+    if (!file_exists(ROOT."/config/Diagnostics.php")) {
47 47
         echo "Diagnostics configuration file not found. You need to configure the product!";
48 48
         throw new Exception("Diagnostics config file not found!");
49 49
     }
Please login to merge, or discard this patch.
web/admin/edit_federation_result.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
  * @author Stefan Winter <[email protected]>
26 26
  */
27 27
 
28
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
28
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
29 29
 
30 30
 $auth = new \web\lib\admin\Authentication();
31 31
 $deco = new \web\lib\admin\PageDecoration();
@@ -46,18 +46,18 @@  discard block
 block discarded – undo
46 46
 
47 47
 if ($submitGiven == web\lib\common\FormElements::BUTTON_SAVE) { // here we go
48 48
     $fed_name = $my_fed->name;
49
-    echo "<h1>" . sprintf(_("Submitted attributes for %s '%s'"), $uiElements->nomenclatureFed, $fed_name) . "</h1>";
49
+    echo "<h1>".sprintf(_("Submitted attributes for %s '%s'"), $uiElements->nomenclatureFed, $fed_name)."</h1>";
50 50
     echo "<table>";
51 51
     echo $optionParser->processSubmittedFields($my_fed, $_POST, $_FILES);
52 52
     echo "</table>";
53 53
 
54 54
     $loggerInstance = new \core\common\Logging();
55
-    $loggerInstance->writeAudit($_SESSION['user'], "MOD", "FED " . $my_fed->name . " - attributes changed");
55
+    $loggerInstance->writeAudit($_SESSION['user'], "MOD", "FED ".$my_fed->name." - attributes changed");
56 56
 
57 57
     // re-instantiate ourselves... profiles need fresh data
58 58
 
59 59
     $my_fed = $validator->existingFederation($_GET['fed_id'], $_SESSION['user']);
60 60
 
61
-    echo "<br/><form method='post' action='overview_federation.php' accept-charset='UTF-8'><button type='submit'>" . _("Continue to dashboard") . "</button></form>";
61
+    echo "<br/><form method='post' action='overview_federation.php' accept-charset='UTF-8'><button type='submit'>"._("Continue to dashboard")."</button></form>";
62 62
 }
63 63
 echo $deco->footer();
Please login to merge, or discard this patch.
utils/installTranslations.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
  * License: see the web/copyright.php file in the file structure
9 9
  * ******************************************************************************
10 10
  */
11
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
11
+require_once dirname(dirname(__FILE__))."/config/_config.php";
12 12
 
13 13
 const AREAS = ["web_admin", "web_user", "devices", "core", "diagnostics"];
14 14
 foreach (\config\Master::LANGUAGES as $lang => $details) {
Please login to merge, or discard this patch.
web/lib/admin/API.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -607,8 +607,7 @@
 block discarded – undo
607 607
         $output = json_encode(["result" => "SUCCESS", "details" => $details], JSON_PRETTY_PRINT);
608 608
         if ($output === FALSE) {
609 609
             $this->returnError(API::ERROR_INTERNAL_ERROR, "Unable to JSON encode return data: ". json_last_error(). " - ". json_last_error_msg());
610
-        }
611
-        else {
610
+        } else {
612 611
             echo $output;
613 612
         }
614 613
     }
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
     const ACTIONS = [
255 255
         // Inst-level actions.
256 256
         API::ACTION_NEWINST_BY_REF => [
257
-            "REQ" => [API::AUXATTRIB_EXTERNALID,],
257
+            "REQ" => [API::AUXATTRIB_EXTERNALID, ],
258 258
             "OPT" => [
259 259
                 'general:geo_coordinates',
260 260
                 'general:logo_file',
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
             "FLAG" => [],
272 272
         ],
273 273
         API::ACTION_NEWINST => [
274
-            "REQ" => [API::AUXATTRIB_INSTTYPE,], // "IdP", "SP" or "IdPSP"
274
+            "REQ" => [API::AUXATTRIB_INSTTYPE, ], // "IdP", "SP" or "IdPSP"
275 275
             "OPT" => [
276 276
                 'general:instname',
277 277
                 'general:geo_coordinates',
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
     public function scrub($inputJson, $fedObject) {        
491 491
         $optionInstance = \core\Options::instance();
492 492
         $parameters = [];
493
-        $allPossibleAttribs = array_merge(API::ACTIONS[$inputJson['ACTION']]['REQ'], API::ACTIONS[$inputJson['ACTION']]['OPT'],  API::ACTIONS[$inputJson['ACTION']]['FLAG']);
493
+        $allPossibleAttribs = array_merge(API::ACTIONS[$inputJson['ACTION']]['REQ'], API::ACTIONS[$inputJson['ACTION']]['OPT'], API::ACTIONS[$inputJson['ACTION']]['FLAG']);
494 494
         // some actions don't need parameters. Don't get excited when there aren't any.
495 495
         if (!isset($inputJson['PARAMETERS'])) {
496 496
             return [];
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
                         break;
534 534
                 }   
535 535
             } elseif (preg_match("/^FLAG-/", $oneIncomingParam['NAME'])) {
536
-                if ($oneIncomingParam['VALUE'] != "TRUE" && $oneIncomingParam['VALUE'] != "FALSE" ) {
536
+                if ($oneIncomingParam['VALUE'] != "TRUE" && $oneIncomingParam['VALUE'] != "FALSE") {
537 537
                     continue;
538 538
                 }
539 539
             } else {
@@ -591,8 +591,8 @@  discard block
 block discarded – undo
591 591
 
592 592
                 case \core\Options::TYPECODE_COORDINATES:
593 593
                     $extension = \core\Options::TYPECODE_TEXT;
594
-                    $coercedInline["option"][$basename] = $oneAttrib['NAME'] . "#";
595
-                    $coercedInline["value"][$basename . "-" . $extension] = $oneAttrib['VALUE'];
594
+                    $coercedInline["option"][$basename] = $oneAttrib['NAME']."#";
595
+                    $coercedInline["value"][$basename."-".$extension] = $oneAttrib['VALUE'];
596 596
                     break;
597 597
                 case \core\Options::TYPECODE_TEXT:
598 598
                 // Fall-through: they all get the same treatment.
@@ -602,18 +602,18 @@  discard block
 block discarded – undo
602 602
                 // Fall-through: they all get the same treatment.
603 603
                 case \core\Options::TYPECODE_INTEGER:
604 604
                     $extension = $optionInfo['type'];
605
-                    $coercedInline["option"][$basename] = $oneAttrib['NAME'] . "#";
606
-                    $coercedInline["value"][$basename . "-" . $extension] = $oneAttrib['VALUE'];
605
+                    $coercedInline["option"][$basename] = $oneAttrib['NAME']."#";
606
+                    $coercedInline["value"][$basename."-".$extension] = $oneAttrib['VALUE'];
607 607
                     if ($optionInfo['flag'] == "ML") {
608
-                        $coercedInline["value"][$basename . "-lang"] = $oneAttrib['LANG'];
608
+                        $coercedInline["value"][$basename."-lang"] = $oneAttrib['LANG'];
609 609
                     }
610 610
                     break;
611 611
                 case \core\Options::TYPECODE_FILE:
612 612
                     // Binary data is expected in base64 encoding. This is true also for PEM files!
613 613
                     $extension = $optionInfo['type'];
614
-                    $coercedInline["option"][$basename] = $oneAttrib['NAME'] . "#";
615
-                    file_put_contents($dir['dir'] . "/" . $basename . "-" . $extension, base64_decode($oneAttrib['VALUE']));
616
-                    $coercedFile["value"]['tmp_name'][$basename . "-" . $extension] = $dir['dir'] . "/" . $basename . "-" . $extension;
614
+                    $coercedInline["option"][$basename] = $oneAttrib['NAME']."#";
615
+                    file_put_contents($dir['dir']."/".$basename."-".$extension, base64_decode($oneAttrib['VALUE']));
616
+                    $coercedFile["value"]['tmp_name'][$basename."-".$extension] = $dir['dir']."/".$basename."-".$extension;
617 617
                     break;
618 618
                 default:
619 619
                     throw new Exception("We don't seem to know this type code!");
@@ -642,7 +642,7 @@  discard block
 block discarded – undo
642 642
     public function returnSuccess($details) {
643 643
         $output = json_encode(["result" => "SUCCESS", "details" => $details], JSON_PRETTY_PRINT);
644 644
         if ($output === FALSE) {
645
-            $this->returnError(API::ERROR_INTERNAL_ERROR, "Unable to JSON encode return data: ". json_last_error(). " - ". json_last_error_msg());
645
+            $this->returnError(API::ERROR_INTERNAL_ERROR, "Unable to JSON encode return data: ".json_last_error()." - ".json_last_error_msg());
646 646
         }
647 647
         else {
648 648
             echo $output;
Please login to merge, or discard this patch.
web/admin/112365365321.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(__DIR__)) . '/config/_config.php';
22
+require_once dirname(dirname(__DIR__)).'/config/_config.php';
23 23
 
24 24
 $uiElements = new web\lib\admin\UIElements();
25 25
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
                         // filesystem cleanup
76 76
                     case web\lib\common\FormElements::BUTTON_DELETE:
77 77
                         $i = web\lib\admin\Maintenance::deleteObsoleteTempDirs();
78
-                        echo "<div class='ca-summary'><table>" . $uiElements->boxRemark(sprintf("Deleted %d cache directories.", $i), "Cache deleted") . "</table></div>";
78
+                        echo "<div class='ca-summary'><table>".$uiElements->boxRemark(sprintf("Deleted %d cache directories.", $i), "Cache deleted")."</table></div>";
79 79
                         break;
80 80
                     default:
81 81
                         break;
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
                     $admin_query = $dbHandle->exec("SELECT SUM(downloads_admin) AS admin, SUM(downloads_user) AS user, SUM(downloads_silverbullet) as silverbullet FROM downloads WHERE device_id = '$index'");
142 142
                     // SELECT -> mysqli_result, not boolean
143 143
                     while ($a = mysqli_fetch_object(/** @scrutinizer ignore-type */ $admin_query)) {
144
-                        echo "<td>" . $device_array['display'] . "</td><td>" . $a->admin . "</td><td>" . $a->user . "</td><td>" . $a->silverbullet . "</td><td>" . sprintf("%s", $a->user + $a->silverbullet) . "</td>";
144
+                        echo "<td>".$device_array['display']."</td><td>".$a->admin."</td><td>".$a->user."</td><td>".$a->silverbullet."</td><td>".sprintf("%s", $a->user + $a->silverbullet)."</td>";
145 145
                         $gross_admin = $gross_admin + $a->admin;
146 146
                         $gross_user = $gross_user + $a->user;
147 147
                         $gross_silverbullet = $gross_silverbullet + $a->silverbullet;
Please login to merge, or discard this patch.
web/admin/overview_sp.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -150,8 +150,8 @@  discard block
 block discarded – undo
150 150
                         <td>
151 151
                             <?php
152 152
                                 echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_1]['icon'] . 
153
-                                     "' alt='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . 
154
-                                     "' title='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . "'>";
153
+                                        "' alt='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . 
154
+                                        "' title='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . "'>";
155 155
                             ?>
156 156
                         </td>
157 157
                     </tr>
@@ -173,8 +173,8 @@  discard block
 block discarded – undo
173 173
                         <td>
174 174
                             <?php
175 175
                                 echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_2]['icon'] .
176
-                                     "' alt='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . 
177
-                                     "' title='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . "'>";
176
+                                        "' alt='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . 
177
+                                        "' title='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . "'>";
178 178
                             ?>
179 179
                         </td>
180 180
                     </tr>
Please login to merge, or discard this patch.
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 $deco = new \web\lib\admin\PageDecoration();
32 32
 $validator = new \web\lib\common\InputValidation();
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 } else {
39 39
     $link = 'http://';
40 40
 }
41
-$link .= $_SERVER['SERVER_NAME'] . $_SERVER['SCRIPT_NAME'];
41
+$link .= $_SERVER['SERVER_NAME'].$_SERVER['SCRIPT_NAME'];
42 42
 $link = htmlspecialchars($link);
43 43
 
44 44
 echo $deco->defaultPagePrelude(sprintf(_("%s: %s Dashboard"), \config\Master::APPEARANCE['productname'], $uiElements->nomenclatureHotspot));
@@ -102,21 +102,21 @@  discard block
 block discarded – undo
102 102
         <?php
103 103
         if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] !== NULL) {
104 104
             echo "<tr>
105
-                        <td>" . sprintf(_("Diagnose reachability and connection parameters of %ss"),$uiElements->nomenclatureInst) . "</td>
105
+                        <td>" . sprintf(_("Diagnose reachability and connection parameters of %ss"), $uiElements->nomenclatureInst)."</td>
106 106
                         <td><form method='post' action='../diag/action_realmcheck.php?inst_id=$my_inst->identifier' accept-charset='UTF-8'>
107 107
                               <!--<input type='text' name='realm' id='realm'>-->
108 108
                               <input type='hidden' name='comefrom' id='comefrom' value='$link'/>
109
-                              <button id='realmcheck' style='cursor:pointer;' type='submit'>" . _("Go!") . "</button>
109
+                              <button id='realmcheck' style='cursor:pointer;' type='submit'>"._("Go!")."</button>
110 110
                             </form>
111 111
                         </td>
112 112
                     </tr>";
113 113
         }
114 114
         if (\config\ConfAssistant::CONSORTIUM['name'] == "eduroam") { // SW: APPROVED
115 115
             echo "<tr>
116
-                        <td>" . sprintf(_("Check %s server status"), $uiElements->nomenclatureFed) . "</td>
116
+                        <td>" . sprintf(_("Check %s server status"), $uiElements->nomenclatureFed)."</td>
117 117
                         <td>
118 118
                            <form action='https://monitor.eduroam.org/mon_direct.php' accept-charset='UTF-8'>
119
-                              <button style='cursor:pointer;' type='submit'>" . _("Go!") . "</button>
119
+                              <button style='cursor:pointer;' type='submit'>" . _("Go!")."</button>
120 120
                            </form>
121 121
                         </td>
122 122
                     </tr>";
@@ -127,10 +127,10 @@  discard block
 block discarded – undo
127 127
     <?php
128 128
     $hotspotProfiles = $my_inst->listDeployments();
129 129
     if (count($hotspotProfiles) == 0) { // no profiles yet.
130
-        echo "<h2>" . sprintf(_("There are not yet any known deployments for your %s."), $uiElements->nomenclatureHotspot) . "</h2>";
130
+        echo "<h2>".sprintf(_("There are not yet any known deployments for your %s."), $uiElements->nomenclatureHotspot)."</h2>";
131 131
     }
132 132
     if (count($hotspotProfiles) > 0) { // no profiles yet.
133
-        echo "<h2>" . sprintf(_("Deployments for this %s"), $uiElements->nomenclatureHotspot) . "</h2>";
133
+        echo "<h2>".sprintf(_("Deployments for this %s"), $uiElements->nomenclatureHotspot)."</h2>";
134 134
         // display an info box with the connection data
135 135
     }
136 136
    
@@ -149,19 +149,19 @@  discard block
 block discarded – undo
149 149
         ?>
150 150
         <div style='display: table-row_id; margin-bottom: 20px;'>
151 151
             <div class='profilebox' style='display: table-cell;'>
152
-                <h2><?php echo core\DeploymentManaged::PRODUCTNAME . " (<span style='color:" . ( $deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>" . _("inactive") : "green;'>" . _("active") ) . "</span>)"; ?></h2>
152
+                <h2><?php echo core\DeploymentManaged::PRODUCTNAME." (<span style='color:".($deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>"._("inactive") : "green;'>"._("active"))."</span>)"; ?></h2>
153 153
                 <table>
154 154
                     <tr>
155 155
                         <td><strong><?php echo _("Your primary RADIUS server") ?></strong><br/>
156 156
                         <?php
157 157
                             if ($deploymentObject->host1_v4 !== NULL) {
158
-                                echo _("IPv4") . ": " . $deploymentObject->host1_v4;
158
+                                echo _("IPv4").": ".$deploymentObject->host1_v4;
159 159
                             }
160 160
                             if ($deploymentObject->host1_v4 !== NULL && $deploymentObject->host1_v6 !== NULL) {
161 161
                                 echo "<br/>";
162 162
                             }
163 163
                             if ($deploymentObject->host1_v6 !== NULL) {
164
-                                echo _("IPv6") . ": " . $deploymentObject->host1_v6;
164
+                                echo _("IPv6").": ".$deploymentObject->host1_v6;
165 165
                             }
166 166
                             ?>
167 167
                         </td>
@@ -169,9 +169,9 @@  discard block
 block discarded – undo
169 169
                         <td><?php echo $deploymentObject->port1; ?></td>
170 170
                         <td>
171 171
                             <?php
172
-                                echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_1]['icon'] . 
173
-                                     "' alt='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . 
174
-                                     "' title='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . "'>";
172
+                                echo "<img src='".$radiusMessages[$deploymentObject->radius_status_1]['icon']. 
173
+                                     "' alt='".$radiusMessages[$deploymentObject->radius_status_1]['text']. 
174
+                                     "' title='".$radiusMessages[$deploymentObject->radius_status_1]['text']."'>";
175 175
                             ?>
176 176
                         </td>
177 177
                     </tr>
@@ -179,22 +179,22 @@  discard block
 block discarded – undo
179 179
                         <td><strong><?php echo _("Your backup RADIUS server") ?><br/></strong>
180 180
                             <?php
181 181
                             if ($deploymentObject->host2_v4 !== NULL) {
182
-                                echo _("IPv4") . ": " . $deploymentObject->host2_v4;
182
+                                echo _("IPv4").": ".$deploymentObject->host2_v4;
183 183
                             }
184 184
                             if ($deploymentObject->host2_v4 !== NULL && $deploymentObject->host2_v6 !== NULL) {
185 185
                                 echo "<br/>";
186 186
                             }
187 187
                             if ($deploymentObject->host2_v6 !== NULL) {
188
-                                echo _("IPv6") . ": " . $deploymentObject->host2_v6;
188
+                                echo _("IPv6").": ".$deploymentObject->host2_v6;
189 189
                             }
190 190
                             ?></td>
191 191
                         <td><?php echo _("RADIUS port number: ") ?></td>
192 192
                         <td><?php echo $deploymentObject->port2; ?></td>
193 193
                         <td>
194 194
                             <?php
195
-                                echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_2]['icon'] .
196
-                                     "' alt='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . 
197
-                                     "' title='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . "'>";
195
+                                echo "<img src='".$radiusMessages[$deploymentObject->radius_status_2]['icon'].
196
+                                     "' alt='".$radiusMessages[$deploymentObject->radius_status_2]['text']. 
197
+                                     "' title='".$radiusMessages[$deploymentObject->radius_status_2]['text']."'>";
198 198
                             ?>
199 199
                         </td>
200 200
                     </tr>
@@ -245,12 +245,12 @@  discard block
 block discarded – undo
245 245
                                     if (array_key_exists('FAILURE', $res) && $res['FAILURE'] > 0) {
246 246
                                         echo '<br>';
247 247
                                         if ($res['FAILURE'] == 2) {
248
-                                            echo ' <span style="color: red;">' . _("Activation failure.") . '</span>';
248
+                                            echo ' <span style="color: red;">'._("Activation failure.").'</span>';
249 249
                                         } else {
250 250
                                             if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
251
-                                                echo ' <span style="color: red;">' . _("Activation failure for your primary RADIUS server.") . '</span>';
251
+                                                echo ' <span style="color: red;">'._("Activation failure for your primary RADIUS server.").'</span>';
252 252
                                             } else {
253
-                                                echo ' <span style="color: red;">' . _("Activation failure for your backup RADIUS server.") . '</span>';
253
+                                                echo ' <span style="color: red;">'._("Activation failure for your backup RADIUS server.").'</span>';
254 254
                                             }
255 255
                                         }
256 256
                                     }
@@ -270,12 +270,12 @@  discard block
 block discarded – undo
270 270
                                     if ($res['FAILURE'] > 0) {
271 271
                                         echo '<br>';
272 272
                                         if ($res['FAILURE'] == 2) {
273
-                                            echo ' <span style="color: red;">' . _("Failure during deactivation, your request is queued for handling") . '</span>';
273
+                                            echo ' <span style="color: red;">'._("Failure during deactivation, your request is queued for handling").'</span>';
274 274
                                         } else {
275 275
                                             if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
276
-                                                echo ' <span style="color: red;">' . _("Deactivation failure for your primary RADIUS server, your request is queued.") . '</span>';
276
+                                                echo ' <span style="color: red;">'._("Deactivation failure for your primary RADIUS server, your request is queued.").'</span>';
277 277
                                             } else {
278
-                                                echo ' <span style="color: red;">' . _("Deactivation failure for your backup RADIUS server, your request is queued.") . '</span>';
278
+                                                echo ' <span style="color: red;">'._("Deactivation failure for your backup RADIUS server, your request is queued.").'</span>';
279 279
                                             }
280 280
                                         }
281 281
                                     }
Please login to merge, or discard this patch.