Passed
Push — release_2_1 ( 61624e...7f34c3 )
by Stefan
10:19
created
devices/ms/DeviceVista7.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
                 $delProfiles[] = $ssid;
77 77
             }
78 78
             if ($cipher == 'TKIP') {
79
-                $delProfiles[] = $ssid . ' (TKIP)';
79
+                $delProfiles[] = $ssid.' (TKIP)';
80 80
             }
81 81
         }
82 82
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
             $iterator = 0;
87 87
             foreach ($allSSID as $ssid => $cipher) {
88 88
                 if ($cipher == 'TKIP') {
89
-                    $windowsProfile[$iterator] = $this->writeWLANprofile($ssid . ' (TKIP)', $ssid, 'WPA', 'TKIP', $eapConfig, $iterator);
89
+                    $windowsProfile[$iterator] = $this->writeWLANprofile($ssid.' (TKIP)', $ssid, 'WPA', 'TKIP', $eapConfig, $iterator);
90 90
                     $iterator++;
91 91
                 }
92 92
                 $windowsProfile[$iterator] = $this->writeWLANprofile($ssid, $ssid, 'WPA2', 'AES', $eapConfig, $iterator);
@@ -148,10 +148,10 @@  discard block
 block discarded – undo
148 148
         $profileFileCont = '<EAPConfig><EapHostConfig xmlns="http://www.microsoft.com/provisioning/EapHostConfig">
149 149
 <EapMethod>
150 150
 <Type xmlns="http://www.microsoft.com/provisioning/EapCommon">' .
151
-                $this->selectedEap["OUTER"] . '</Type>
151
+                $this->selectedEap["OUTER"].'</Type>
152 152
 <VendorId xmlns="http://www.microsoft.com/provisioning/EapCommon">0</VendorId>
153 153
 <VendorType xmlns="http://www.microsoft.com/provisioning/EapCommon">0</VendorType>
154
-<AuthorId xmlns="http://www.microsoft.com/provisioning/EapCommon">' . $authorId . '</AuthorId>
154
+<AuthorId xmlns="http://www.microsoft.com/provisioning/EapCommon">' . $authorId.'</AuthorId>
155 155
 </EapMethod>
156 156
 ';
157 157
 
@@ -164,9 +164,9 @@  discard block
 block discarded – undo
164 164
             $profileFileCont .= '
165 165
 <Config xmlns="http://www.microsoft.com/provisioning/EapHostConfig">
166 166
 <EAPIdentityProviderList xmlns="urn:ietf:params:xml:ns:yang:ietf-eap-metadata">
167
-<EAPIdentityProvider ID="' . $this->deviceUUID . '" namespace="urn:UUID">
167
+<EAPIdentityProvider ID="' . $this->deviceUUID.'" namespace="urn:UUID">
168 168
 <ProviderInfo>
169
-<DisplayName>' . $this->translateString($attr['general:instname'][0]) . '</DisplayName>
169
+<DisplayName>' . $this->translateString($attr['general:instname'][0]).'</DisplayName>
170 170
 </ProviderInfo>
171 171
 <AuthenticationMethods>
172 172
 <AuthenticationMethod>
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
                 if ($outerUser == '') {
179 179
                     $profileFileCont .= '<AnonymousIdentity>@</AnonymousIdentity>';
180 180
                 } else {
181
-                    $profileFileCont .= '<AnonymousIdentity>' . $outerUser . '@' . $realm . '</AnonymousIdentity>';
181
+                    $profileFileCont .= '<AnonymousIdentity>'.$outerUser.'@'.$realm.'</AnonymousIdentity>';
182 182
                 }
183 183
             }
184 184
             $profileFileCont .= '</ClientSideCredential>
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
             $profileFileCont .= '
197 197
 </ServerSideCredential>
198 198
 <InnerAuthenticationMethod>
199
-<NonEAPAuthMethod>' .$innerMethod. '</NonEAPAuthMethod>
199
+<NonEAPAuthMethod>' .$innerMethod.'</NonEAPAuthMethod>
200 200
 </InnerAuthenticationMethod>
201 201
 <VendorSpecific>
202 202
 <SessionResumption>false</SessionResumption>
@@ -221,11 +221,11 @@  discard block
 block discarded – undo
221 221
 </eapTls:CredentialsSource>
222 222
 <eapTls:ServerValidation>
223 223
 <eapTls:DisableUserPromptForServerValidation>true</eapTls:DisableUserPromptForServerValidation>
224
-<eapTls:ServerNames>' . $servers . '</eapTls:ServerNames>';
224
+<eapTls:ServerNames>' . $servers.'</eapTls:ServerNames>';
225 225
             if ($caArray) {
226 226
                 foreach ($caArray as $certAuthority) {
227 227
                     if ($certAuthority['root']) {
228
-                        $profileFileCont .= "<eapTls:TrustedRootCA>" . $certAuthority['sha1'] . "</eapTls:TrustedRootCA>\n";
228
+                        $profileFileCont .= "<eapTls:TrustedRootCA>".$certAuthority['sha1']."</eapTls:TrustedRootCA>\n";
229 229
                     }
230 230
                 }
231 231
             }
@@ -257,11 +257,11 @@  discard block
 block discarded – undo
257 257
 <msPeap:EapType>
258 258
 <msPeap:ServerValidation>
259 259
 <msPeap:DisableUserPromptForServerValidation>true</msPeap:DisableUserPromptForServerValidation> 
260
-<msPeap:ServerNames>' . $servers . '</msPeap:ServerNames>';
260
+<msPeap:ServerNames>' . $servers.'</msPeap:ServerNames>';
261 261
             if ($caArray) {
262 262
                 foreach ($caArray as $certAuthority) {
263 263
                     if ($certAuthority['root']) {
264
-                        $vistaExt .= "<msPeap:TrustedRootCA>" . $certAuthority['sha1'] . "</msPeap:TrustedRootCA>\n";
264
+                        $vistaExt .= "<msPeap:TrustedRootCA>".$certAuthority['sha1']."</msPeap:TrustedRootCA>\n";
265 265
                     }
266 266
                 }
267 267
             }
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
 <msChapV2:UseWinLogonCredentials>false</msChapV2:UseWinLogonCredentials> 
275 275
 </msChapV2:EapType>
276 276
 </baseEap:Eap>
277
-<msPeap:EnableQuarantineChecks>' . $nea . '</msPeap:EnableQuarantineChecks>
277
+<msPeap:EnableQuarantineChecks>' . $nea.'</msPeap:EnableQuarantineChecks>
278 278
 <msPeap:RequireCryptoBinding>false</msPeap:RequireCryptoBinding>
279 279
 </msPeap:EapType>
280 280
 </baseEap:Eap>
@@ -286,11 +286,11 @@  discard block
 block discarded – undo
286 286
 <EapType xmlns="http://www.microsoft.com/provisioning/MsPeapConnectionPropertiesV1">
287 287
 <ServerValidation>
288 288
 <DisableUserPromptForServerValidation>true</DisableUserPromptForServerValidation>
289
-<ServerNames>' . $servers . '</ServerNames>';
289
+<ServerNames>' . $servers.'</ServerNames>';
290 290
             if ($caArray) {
291 291
                 foreach ($caArray as $certAuthority) {
292 292
                     if ($certAuthority['root']) {
293
-                        $w7Ext .= "<TrustedRootCA>" . $certAuthority['sha1'] . "</TrustedRootCA>\n";
293
+                        $w7Ext .= "<TrustedRootCA>".$certAuthority['sha1']."</TrustedRootCA>\n";
294 294
                     }
295 295
                 }
296 296
             }
@@ -303,14 +303,14 @@  discard block
 block discarded – undo
303 303
 <UseWinLogonCredentials>false</UseWinLogonCredentials> 
304 304
 </EapType>
305 305
 </Eap>
306
-<EnableQuarantineChecks>' . $nea . '</EnableQuarantineChecks>
306
+<EnableQuarantineChecks>' . $nea.'</EnableQuarantineChecks>
307 307
 <RequireCryptoBinding>false</RequireCryptoBinding>
308 308
 ';
309 309
             if ($useAnon) {
310 310
                 $w7Ext .= '<PeapExtensions>
311 311
 <IdentityPrivacy xmlns="http://www.microsoft.com/provisioning/MsPeapConnectionPropertiesV2">
312 312
 <EnableIdentityPrivacy>true</EnableIdentityPrivacy>
313
-<AnonymousUserName>' . $outerUser . '</AnonymousUserName>
313
+<AnonymousUserName>' . $outerUser.'</AnonymousUserName>
314 314
 </IdentityPrivacy>
315 315
 </PeapExtensions>
316 316
             ';
@@ -328,8 +328,8 @@  discard block
 block discarded – undo
328 328
         $profileFileContEnd = '</EapHostConfig></EAPConfig>
329 329
 ';
330 330
         $returnArray = [];
331
-        $returnArray['vista'] = $profileFileCont . $vistaExt . $profileFileContEnd;
332
-        $returnArray['w7'] = $profileFileCont . $w7Ext . $profileFileContEnd;
331
+        $returnArray['vista'] = $profileFileCont.$vistaExt.$profileFileContEnd;
332
+        $returnArray['w7'] = $profileFileCont.$w7Ext.$profileFileContEnd;
333 333
         return $returnArray;
334 334
     }
335 335
 
@@ -348,10 +348,10 @@  discard block
 block discarded – undo
348 348
     private function writeWLANprofile($wlanProfileName, $ssid, $auth, $encryption, $eapConfig, $profileNumber) {
349 349
         $profileFileCont = '<?xml version="1.0"?>
350 350
 <WLANProfile xmlns="http://www.microsoft.com/networking/WLAN/profile/v1">
351
-<name>' . $wlanProfileName . '</name>
351
+<name>' . $wlanProfileName.'</name>
352 352
 <SSIDConfig>
353 353
 <SSID>
354
-<name>' . $ssid . '</name>
354
+<name>' . $ssid.'</name>
355 355
 </SSID>
356 356
 <nonBroadcast>true</nonBroadcast>
357 357
 </SSIDConfig>
@@ -361,8 +361,8 @@  discard block
 block discarded – undo
361 361
 <MSM>
362 362
 <security>
363 363
 <authEncryption>
364
-<authentication>' . $auth . '</authentication>
365
-<encryption>' . $encryption . '</encryption>
364
+<authentication>' . $auth.'</authentication>
365
+<encryption>' . $encryption.'</encryption>
366 366
 <useOneX>true</useOneX>
367 367
 </authEncryption>
368 368
 ';
@@ -392,9 +392,9 @@  discard block
 block discarded – undo
392 392
             mkdir('vista');
393 393
         }
394 394
         $vistaFileName = "vista/wlan_prof-$profileNumber.xml";
395
-        file_put_contents($vistaFileName, $profileFileCont . $eapConfig['vista'] . $closing);
395
+        file_put_contents($vistaFileName, $profileFileCont.$eapConfig['vista'].$closing);
396 396
         $sevenFileName = "w7/wlan_prof-$profileNumber.xml";
397
-        file_put_contents($sevenFileName, $profileFileCont . $eapConfig['w7'] . $closing);
397
+        file_put_contents($sevenFileName, $profileFileCont.$eapConfig['w7'].$closing);
398 398
         $this->loggerInstance->debug(2, "Installer has been written into directory $this->FPATH\n");
399 399
         $this->loggerInstance->debug(4, "WLAN_Profile:$wlanProfileName:$encryption\n");
400 400
         return("\"$wlanProfileName\" \"$encryption\"");
@@ -431,8 +431,8 @@  discard block
 block discarded – undo
431 431
             mkdir('vista');
432 432
         }
433 433
         
434
-        file_put_contents("vista/lan_prof.xml", $profileFileCont . $eapConfig['vista'] . $closing);
435
-        file_put_contents("w7/lan_prof.xml", $profileFileCont . $eapConfig['w7'] . $closing);
434
+        file_put_contents("vista/lan_prof.xml", $profileFileCont.$eapConfig['vista'].$closing);
435
+        file_put_contents("w7/lan_prof.xml", $profileFileCont.$eapConfig['w7'].$closing);
436 436
         
437 437
     }
438 438
 
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
     private function writeMainNSH($eap, $attr) {
447 447
         $this->loggerInstance->debug(4, "writeMainNSH");
448 448
         $this->loggerInstance->debug(4, $attr);
449
-        $this->loggerInstance->debug(4, "MYLANG=" . $this->lang . "\n");
449
+        $this->loggerInstance->debug(4, "MYLANG=".$this->lang."\n");
450 450
 
451 451
         $eapOptions = [
452 452
             \core\common\EAP::PEAP => ['str' => 'PEAP', 'exec' => 'user'],
@@ -477,8 +477,8 @@  discard block
 block discarded – undo
477 477
         $this->loggerInstance->debug(4, "EAP_STR=$eapStr\n");
478 478
         $this->loggerInstance->debug(4, $eap);
479 479
 
480
-        $fcontents .= '!define ' . $eapStr;
481
-        $fcontents .= "\n" . '!define EXECLEVEL "' . $execLevel . '"';
480
+        $fcontents .= '!define '.$eapStr;
481
+        $fcontents .= "\n".'!define EXECLEVEL "'.$execLevel.'"';
482 482
         $fcontents .= $this->writeNsisDefines($attr);
483 483
         file_put_contents('main.nsh', $fcontents);
484 484
     }
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
         }
508 508
         foreach ($caArray as $certAuthority) {
509 509
             $store = $certAuthority['root'] ? "root" : "ca";
510
-            $contentCerts .= '!insertmacro install_ca_cert "' . $certAuthority['file'] . '" "' . $certAuthority['sha1'] . '" "' . $store . "\"\n";
510
+            $contentCerts .= '!insertmacro install_ca_cert "'.$certAuthority['file'].'" "'.$certAuthority['sha1'].'" "'.$store."\"\n";
511 511
         }
512 512
         fwrite($fileHandleCerts, $contentCerts);
513 513
         fclose($fileHandleCerts);
Please login to merge, or discard this patch.
devices/ms/MsTlsProfile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
     private function getCredentialSource()
46 46
     {
47 47
         $element = new \core\DeviceXMLmain();
48
-        $element->setChild('CertificateStore','');
48
+        $element->setChild('CertificateStore', '');
49 49
         return($element);
50 50
     }
51 51
     
Please login to merge, or discard this patch.
devices/ms/MsPeapProfile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     {
39 39
         $element = new \core\DeviceXMLmain();
40 40
         $element->setChild('ServerValidation', $this->getPeapServerValidation());
41
-        $element->setChild('FastReconnect','true');
41
+        $element->setChild('FastReconnect', 'true');
42 42
         $element->setChild('InnerEapOptional', 'false');
43 43
         $element->setChild('Eap', $this->getMsChapV2(), self::MS_BASEEAPCONN_NS);
44 44
         $element->setChild('EnableQuarantineChecks', $this->nea);
Please login to merge, or discard this patch.
devices/ms/MsOneX.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,8 +43,8 @@
 block discarded – undo
43 43
     {
44 44
         $element = new \core\DeviceXMLmain();
45 45
         $element->setChild('Type', $this->eapConfig->type, self::MS_EAPCOMMON_NS);
46
-        $element->setChild('VendorId',0, self::MS_EAPCOMMON_NS);
47
-        $element->setChild('VendorType',0, self::MS_EAPCOMMON_NS);
46
+        $element->setChild('VendorId', 0, self::MS_EAPCOMMON_NS);
47
+        $element->setChild('VendorType', 0, self::MS_EAPCOMMON_NS);
48 48
         $element->setChild('AuthorId', $this->eapConfig->authorId, self::MS_EAPCOMMON_NS);
49 49
         return($element);
50 50
     }
Please login to merge, or discard this patch.
devices/ms/MsWlanProfile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
         $dom = new \DOMDocument('1.0', 'utf-8');
74 74
         $root = $dom->createElement($rootname);
75 75
         $dom->appendChild($root);
76
-        $ns = $dom->createAttributeNS( null, 'xmlns' );
76
+        $ns = $dom->createAttributeNS(null, 'xmlns');
77 77
         $ns->value = "http://www.microsoft.com/networking/WLAN/profile/v1";
78 78
         $root->appendChild($ns);        
79 79
         \core\DeviceXMLmain::marshalObject($dom, $root, 'WLANprofile', $this->getWLANprofile(), '', true);
Please login to merge, or discard this patch.
core/DeviceXMLmain.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
                 $node->appendChild($childNode);
212 212
             }
213 213
             if (!empty($namespace)) {
214
-                $ns = $domElement->createAttributeNS(null,'xmlns');
214
+                $ns = $domElement->createAttributeNS(null, 'xmlns');
215 215
                 $ns->value = $namespace;
216 216
                 $childNode->appendChild($ns);  
217 217
             }
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
                 $nextChild = $domElement->createElement($nameC, $cl);    
239 239
                 $childNode->appendChild($nextChild);
240 240
                 if (!empty($namespaceC)) {
241
-                    $ns = $domElement->createAttributeNS(null,'xmlns');
241
+                    $ns = $domElement->createAttributeNS(null, 'xmlns');
242 242
                     $ns->value = $namespaceC;
243 243
                     $nextChild->appendChild($ns);  
244 244
                 }
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
                             $childNode->appendChild($nextChild);
261 261
                         }
262 262
                         if (!empty($namespaceC)) {
263
-                            $ns = $domElement->createAttributeNS(null,'xmlns');
263
+                            $ns = $domElement->createAttributeNS(null, 'xmlns');
264 264
                             $ns->value = $namespaceC;
265 265
                             $nextChild->appendChild($ns);  
266 266
                         }
Please login to merge, or discard this patch.
config/ConfAssistant-template.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
                     ], 
91 91
                 'condition' => TRUE],
92 92
             'OpenRoaming® (%REALM%)' => [
93
-                'ssid' => [],     /* OpenRoaming has left SSIDs behind */
93
+                'ssid' => [], /* OpenRoaming has left SSIDs behind */
94 94
                 'oi' => [
95 95
                     '5A03BA0000', /* OpenRoaming/AllIdentities/SettlementFree/NoPersonalData/BaselineQoS */
96 96
                     '5A03BA0800', /* OpenRoaming/EduIdentities/SettlementFree/NoPersonalData/BaselineQoS */
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
         'makensis' => 'makensis',
156 156
         'zip' => 'zip',
157 157
         'trust-store-mozilla' => '/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem',
158
-        'trust-store-custom' => __DIR__ . "/known-roots.pem",
158
+        'trust-store-custom' => __DIR__."/known-roots.pem",
159 159
     ];
160 160
 
161 161
     /**
@@ -193,13 +193,13 @@  discard block
 block discarded – undo
193 193
             'db' => 'radacct',
194 194
             'user' => 'someuser',
195 195
             'pass' => 'somepass',
196
-            'readonly' => TRUE,],
196
+            'readonly' => TRUE, ],
197 197
         'RADIUS_2' => [
198 198
             'host' => 'auth-2.hosted.eduroam.org',
199 199
             'db' => 'radacct',
200 200
             'user' => 'someuser',
201 201
             'pass' => 'somepass',
202
-            'readonly' => TRUE,],
202
+            'readonly' => TRUE, ],
203 203
     ];
204 204
 
205 205
     /**
Please login to merge, or discard this patch.
web/admin/inc/profileAutodetectCA.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
  */
21 21
 ?>
22 22
 <?php
23
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $languageInstance = new \core\common\Language();
Please login to merge, or discard this patch.
web/admin/edit_profile.php 1 patch
Spacing   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 $deco = new \web\lib\admin\PageDecoration();
32 32
 $validator = new \web\lib\common\InputValidation();
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
         $detectRealm = $validator->string($_POST['realm_to_detect']);
111 111
         $localname = $validator->string($_POST['username_to_detect']);
112 112
         $checker = new \core\diag\RADIUSTests($detectRealm, $localname);
113
-        $detectionResult = $checker->autodetectCAWithProbe($localname . "@" . $detectRealm);
113
+        $detectionResult = $checker->autodetectCAWithProbe($localname."@".$detectRealm);
114 114
         $loggerInstance->debug(2, "CA Auto-Detection yields:");
115 115
         $loggerInstance->debug(2, $detectionResult);
116 116
         if ($detectionResult['ROOT_CA'] !== NULL) { // we are lucky!
@@ -142,8 +142,8 @@  discard block
 block discarded – undo
142 142
     <?php
143 143
     echo $uiElements->instLevelInfoBoxes($my_inst);
144 144
 
145
-    echo "<form enctype='multipart/form-data' action='edit_profile_result.php?inst_id=$my_inst->identifier" . ($my_profile !== NULL ? "&amp;profile_id=" . $my_profile->identifier : "") . "' method='post' accept-charset='UTF-8'>
146
-                <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::MAX_UPLOAD_SIZE . "'>";
145
+    echo "<form enctype='multipart/form-data' action='edit_profile_result.php?inst_id=$my_inst->identifier".($my_profile !== NULL ? "&amp;profile_id=".$my_profile->identifier : "")."' method='post' accept-charset='UTF-8'>
146
+                <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::MAX_UPLOAD_SIZE."'>";
147 147
     $optionDisplay = new \web\lib\admin\OptionDisplay($profile_options, \core\Options::LEVEL_PROFILE);
148 148
     ?>
149 149
     <fieldset class="option_container">
@@ -152,19 +152,19 @@  discard block
 block discarded – undo
152 152
         </legend>
153 153
         <?php
154 154
         if ($wizardStyle) {
155
-            echo "<p>" . _("We will now define a profile for your user group(s).  You can add as many profiles as you like by choosing the appropriate button on the end of the page. After we are done, the wizard is finished and you will be taken to the main IdP administration page.") . "</p>";
155
+            echo "<p>"._("We will now define a profile for your user group(s).  You can add as many profiles as you like by choosing the appropriate button on the end of the page. After we are done, the wizard is finished and you will be taken to the main IdP administration page.")."</p>";
156 156
         }
157 157
         ?>
158 158
         <h3><?php echo _("Profile Name and RADIUS realm"); ?></h3>
159 159
         <?php
160 160
         if ($wizardStyle) {
161
-            echo "<p>" . _("First of all we need a name for the profile. This will be displayed to end users, so you may want to choose a descriptive name like 'Professors', 'Students of the Faculty of Bioscience', etc.") . "</p>";
162
-            echo "<p>" . _("Optionally, you can provide a longer descriptive text about who this profile is for. If you specify it, it will be displayed on the download page after the user has selected the profile name in the list.") . "</p>";
163
-            echo "<p>" . _("You can also tell us your RADIUS realm. ");
161
+            echo "<p>"._("First of all we need a name for the profile. This will be displayed to end users, so you may want to choose a descriptive name like 'Professors', 'Students of the Faculty of Bioscience', etc.")."</p>";
162
+            echo "<p>"._("Optionally, you can provide a longer descriptive text about who this profile is for. If you specify it, it will be displayed on the download page after the user has selected the profile name in the list.")."</p>";
163
+            echo "<p>"._("You can also tell us your RADIUS realm. ");
164 164
             if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] !== NULL) {
165 165
                 printf(_("This is useful if you want to use the sanity check module later, which tests reachability of your realm in the %s infrastructure. "), \config\ConfAssistant::CONSORTIUM['display_name']);
166 166
             }
167
-            echo _("It is required to enter the realm name if you want to support anonymous outer identities (see below).") . "</p>";
167
+            echo _("It is required to enter the realm name if you want to support anonymous outer identities (see below).")."</p>";
168 168
         }
169 169
 
170 170
         echo $optionDisplay->prefilledOptionTable("profile", $my_inst->federation);
@@ -219,9 +219,9 @@  discard block
 block discarded – undo
219 219
 
220 220
         <?php
221 221
         if ($wizardStyle) {
222
-            echo "<p>" . sprintf(_("Some installers support a feature called 'Anonymous outer identity'. If you don't know what this is, please read <a href='%s'>this article</a>."), "https://confluence.terena.org/display/H2eduroam/eap-types") . "</p>";
223
-            echo "<p>" . _("On some platforms, the installers can suggest username endings and/or verify the user input to contain the realm suffix.") . "</p>";
224
-            echo "<p>" . _("The realm check feature needs to know an outer ID which actually gets a chance to authenticate. If your RADIUS server lets only select usernames pass, it is useful to supply the information which of those (outer ID) username we can use for testing.") . "</p>";
222
+            echo "<p>".sprintf(_("Some installers support a feature called 'Anonymous outer identity'. If you don't know what this is, please read <a href='%s'>this article</a>."), "https://confluence.terena.org/display/H2eduroam/eap-types")."</p>";
223
+            echo "<p>"._("On some platforms, the installers can suggest username endings and/or verify the user input to contain the realm suffix.")."</p>";
224
+            echo "<p>"._("The realm check feature needs to know an outer ID which actually gets a chance to authenticate. If your RADIUS server lets only select usernames pass, it is useful to supply the information which of those (outer ID) username we can use for testing.")."</p>";
225 225
         }
226 226
         ?>
227 227
         <p>
@@ -240,37 +240,37 @@  discard block
 block discarded – undo
240 240
             <tr>
241 241
                 <!-- checkbox and input field for anonymity support, available only when realm is known-->
242 242
                 <td>
243
-                    <span id='anon_support_label' style='<?php echo ($realm == "" ? "color:#999999" : "" ); ?>'>
243
+                    <span id='anon_support_label' style='<?php echo ($realm == "" ? "color:#999999" : ""); ?>'>
244 244
                         <?php echo _("Enable Anonymous Outer Identity:"); ?>
245 245
                     </span>
246 246
                 </td>
247 247
                 <td>
248
-                    <input type='checkbox' <?php echo ($useAnon != FALSE ? "checked" : "" ) . ($realm == "" ? " disabled" : "" ); ?> name='anon_support' onclick='
248
+                    <input type='checkbox' <?php echo ($useAnon != FALSE ? "checked" : "").($realm == "" ? " disabled" : ""); ?> name='anon_support' onclick='
249 249
                             if (this.form.elements["anon_support"].checked !== true) {
250 250
                                 this.form.elements["anon_local"].setAttribute("disabled", "disabled");
251 251
                             } else {
252 252
                                 this.form.elements["anon_local"].removeAttribute("disabled");
253 253
                             }
254 254
                             ;'/>
255
-                    <input type='text' <?php echo ($useAnon == FALSE ? "disabled" : "" ); ?> name='anon_local' value='<?php echo $anonLocal; ?>'/>
255
+                    <input type='text' <?php echo ($useAnon == FALSE ? "disabled" : ""); ?> name='anon_local' value='<?php echo $anonLocal; ?>'/>
256 256
                 </td>
257 257
             </tr>
258 258
             <tr>
259 259
                 <!-- checkbox and input field for check realm outer id, available only when realm is known-->
260 260
                 <td>
261
-                    <span id='checkuser_label' style='<?php echo ($realm == "" ? "color:#999999" : "" ); ?>'>
261
+                    <span id='checkuser_label' style='<?php echo ($realm == "" ? "color:#999999" : ""); ?>'>
262 262
                         <?php echo _("Use special Outer Identity for realm checks:"); ?>
263 263
                     </span>
264 264
                 </td>
265 265
                 <td>
266
-                    <input type='checkbox' <?php echo ($checkuserOuter != FALSE ? "checked" : "" ) . ($realm == "" ? " disabled" : "" ); ?> name='checkuser_support' onclick='
266
+                    <input type='checkbox' <?php echo ($checkuserOuter != FALSE ? "checked" : "").($realm == "" ? " disabled" : ""); ?> name='checkuser_support' onclick='
267 267
                             if (this.form.elements["checkuser_support"].checked !== true) {
268 268
                                 this.form.elements["checkuser_local"].setAttribute("disabled", "disabled");
269 269
                             } else {
270 270
                                 this.form.elements["checkuser_local"].removeAttribute("disabled");
271 271
                             }
272 272
                             ;'/>
273
-                    <input type='text' <?php echo ($checkuserOuter == FALSE ? "disabled" : "" ); ?> name='checkuser_local' value='<?php echo $checkuserValue; ?>'/>
273
+                    <input type='text' <?php echo ($checkuserOuter == FALSE ? "disabled" : ""); ?> name='checkuser_local' value='<?php echo $checkuserValue; ?>'/>
274 274
                 </td>
275 275
             </tr>
276 276
             <tr>
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
                 </td>
286 286
                 <td>
287 287
                     <input type='checkbox' <?php
288
-                    echo ($verify != FALSE ? "checked" : "" );
288
+                    echo ($verify != FALSE ? "checked" : "");
289 289
                     ?> name='verify_support' onclick='
290 290
                                 if (this.form.elements["verify_support"].checked !== true || this.form.elements["realm"].value.length == 0) {
291 291
                                     this.form.elements["hint_support"].setAttribute("disabled", "disabled");
@@ -297,12 +297,12 @@  discard block
 block discarded – undo
297 297
             </tr>
298 298
             <tr>
299 299
                 <td>
300
-                    <span id='hint_label' style='<?php echo ($realm == "" ? "color:#999999" : "" ); ?>'>
300
+                    <span id='hint_label' style='<?php echo ($realm == "" ? "color:#999999" : ""); ?>'>
301 301
                         <?php echo _("Enforce exact realm in username"); ?>
302 302
                     </span>
303 303
                 </td>
304 304
                 <td>
305
-                    <input type='checkbox' <?php echo ($verify == FALSE ? "disabled" : "" ); ?> name='hint_support' <?php echo ( $hint != FALSE ? "checked" : "" ); ?> />
305
+                    <input type='checkbox' <?php echo ($verify == FALSE ? "disabled" : ""); ?> name='hint_support' <?php echo ($hint != FALSE ? "checked" : ""); ?> />
306 306
                 </td>
307 307
             </tr>
308 308
         </table>
@@ -312,20 +312,20 @@  discard block
 block discarded – undo
312 312
 
313 313
     <?php
314 314
     if ($wizardStyle) {
315
-        echo "<p>" . _("The CAT has a download area for end users. There, they will, for example, learn about the support pointers you entered earlier. The CAT can also immediately offer the installers for the profile for download. If you don't want that, you can instead enter a web site location where you want your users to be redirected to. You, as the administrator, can still download the profiles to place them on that page (see the 'Compatibility Matrix' button on the dashboard).") . "</p>";
315
+        echo "<p>"._("The CAT has a download area for end users. There, they will, for example, learn about the support pointers you entered earlier. The CAT can also immediately offer the installers for the profile for download. If you don't want that, you can instead enter a web site location where you want your users to be redirected to. You, as the administrator, can still download the profiles to place them on that page (see the 'Compatibility Matrix' button on the dashboard).")."</p>";
316 316
     }
317 317
     ?>
318 318
     <p>
319 319
 
320 320
         <?php
321
-        echo "<span id='redirect_label' style='" . ($realm == "" ? "color:#999999" : "" ) . "'><label for='redirect'>" . _("Redirect end users to own web page:") . "</label></span>
322
-                          <input type='checkbox'  name='redirect' id='redirect' " . ($blacklisted === FALSE ? "" : "checked " ) . "onclick='
321
+        echo "<span id='redirect_label' style='".($realm == "" ? "color:#999999" : "")."'><label for='redirect'>"._("Redirect end users to own web page:")."</label></span>
322
+                          <input type='checkbox'  name='redirect' id='redirect' " . ($blacklisted === FALSE ? "" : "checked ")."onclick='
323 323
                               if (this.form.elements[\"redirect\"].checked != true) {
324 324
                                 this.form.elements[\"redirect_target\"].setAttribute(\"disabled\", \"disabled\");
325 325
                               } else {
326 326
                                 this.form.elements[\"redirect_target\"].removeAttribute(\"disabled\");
327 327
                               };'/>
328
-                          <input type='text' name='redirect_target' " . ($blacklisted !== FALSE ? "value='$blacklisted'" : "disabled" ) . "/>";
328
+                          <input type='text' name='redirect_target' " . ($blacklisted !== FALSE ? "value='$blacklisted'" : "disabled")."/>";
329 329
         ?>
330 330
     </p>
331 331
 
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
     <legend><strong><?php echo _("Supported EAP types"); ?></strong></legend>
335 335
     <?php
336 336
     if ($wizardStyle) {
337
-        echo "<p>" . _("Now, we need to know which EAP types your IdP supports. If you support multiple EAP types, you can assign every type a priority (1=highest). This tool will always generate an automatic installer for the EAP type with the highest priority; only if the user's device can't use that EAP type, we will use an EAP type further down in the list.") . "</p>";
337
+        echo "<p>"._("Now, we need to know which EAP types your IdP supports. If you support multiple EAP types, you can assign every type a priority (1=highest). This tool will always generate an automatic installer for the EAP type with the highest priority; only if the user's device can't use that EAP type, we will use an EAP type further down in the list.")."</p>";
338 338
     }
339 339
     ?>
340 340
     <?php
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
                         <?php
368 368
                         $D = [];
369 369
                         foreach ($prefill_methods as $prio => $value) {
370
-                            print '<li>' . $value->getPrintableRep() . "</li>\n";
370
+                            print '<li>'.$value->getPrintableRep()."</li>\n";
371 371
                             $D[$value->getPrintableRep()] = $prio;
372 372
                         }
373 373
                         ?>
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
                             }
394 394
                             $display = $a->getPrintableRep();
395 395
                             if (!isset($D[$a->getPrintableRep()])) {
396
-                                print '<li class="eap1">' . $a->getPrintableRep() . "</li>\n";
396
+                                print '<li class="eap1">'.$a->getPrintableRep()."</li>\n";
397 397
                             }
398 398
                         }
399 399
                         ?>
@@ -406,8 +406,8 @@  discard block
 block discarded – undo
406 406
     foreach ($methods as $a) {
407 407
         $display = $a->getPrintableRep();
408 408
         $v = isset($D[$display]) ? $D[$display] : '';
409
-        print '<input type="hidden" class="eapm" name="' . $display . '" id="EAP-' . $display . '" value="' . $display . '">';
410
-        print '<input type="hidden" class="eapmv" name="' . $display . '-priority" id="EAP-' . $display . '-priority" value="' . $v . '">';
409
+        print '<input type="hidden" class="eapm" name="'.$display.'" id="EAP-'.$display.'" value="'.$display.'">';
410
+        print '<input type="hidden" class="eapmv" name="'.$display.'-priority" id="EAP-'.$display.'-priority" value="'.$v.'">';
411 411
     }
412 412
     ?>
413 413
     <br style="clear:both;" />
@@ -427,11 +427,11 @@  discard block
 block discarded – undo
427 427
 foreach ($optionsAlreadySet as $optionNames) {
428 428
     if (preg_match("/^support:/", $optionNames)) {
429 429
         $has_support_options[$optionNames] = "SET";
430
-        $support_text .= "<li><strong>" . $uiElements->displayName($optionNames) . "</strong></li>";
430
+        $support_text .= "<li><strong>".$uiElements->displayName($optionNames)."</strong></li>";
431 431
     }
432 432
     if (preg_match("/^media:/", $optionNames)) {
433 433
         $has_media_options[$optionNames] = "SET";
434
-        $media_text .= "<li><strong>" . $uiElements->displayName($optionNames) . "</strong></li>";
434
+        $media_text .= "<li><strong>".$uiElements->displayName($optionNames)."</strong></li>";
435 435
     }
436 436
 }
437 437
 $fields = [
@@ -440,12 +440,12 @@  discard block
 block discarded – undo
440 440
     "media" => _("Media Properties for this profile")];
441 441
 
442 442
 foreach ($fields as $name => $description) {
443
-    echo "<fieldset class='option_container' id='" . $name . "_override'>
443
+    echo "<fieldset class='option_container' id='".$name."_override'>
444 444
     <legend><strong>$description</strong></legend>
445 445
     <p>";
446 446
 
447
-    if (count(${"has_" . $name . "_options"}) > 0) {
448
-        printf(ngettext("The option %s is already defined IdP-wide. If you set it here on profile level, this setting will override the IdP-wide one.", "The options %s are already defined IdP-wide. If you set them here on profile level, these settings will override the IdP-wide ones.", count(${"has_" . $name . "_options"})), "<ul>" . ${$name . "_text"} . "</ul>");
447
+    if (count(${"has_".$name."_options"}) > 0) {
448
+        printf(ngettext("The option %s is already defined IdP-wide. If you set it here on profile level, this setting will override the IdP-wide one.", "The options %s are already defined IdP-wide. If you set them here on profile level, these settings will override the IdP-wide ones.", count(${"has_".$name."_options"})), "<ul>".${$name."_text"}."</ul>");
449 449
     }
450 450
 
451 451
     echo "</p>";
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
458 458
 }
459 459
 
460 460
 if ($wizardStyle) {
461
-    echo "<p>" . _("When you are sure that everything is correct, please click on 'Save data' and you will be taken to your IdP Dashboard page.") . "</p>";
461
+    echo "<p>"._("When you are sure that everything is correct, please click on 'Save data' and you will be taken to your IdP Dashboard page.")."</p>";
462 462
 }
463
-echo "<p><button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_SAVE . "'>" . _("Save data") . "</button><button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_org.php?inst_id=$my_inst->identifier\"'>" . _("Discard changes") . "</button></p></form>";
463
+echo "<p><button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_SAVE."'>"._("Save data")."</button><button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_org.php?inst_id=$my_inst->identifier\"'>"._("Discard changes")."</button></p></form>";
464 464
 echo $deco->footer();
Please login to merge, or discard this patch.