Passed
Push — master ( a7aa10...668d26 )
by Tomasz
07:06
created
web/admin/inc/userStats.inc.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
  * ******************************************************************************
10 10
  */
11 11
 
12
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
12
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
13 13
 
14 14
 $auth = new \web\lib\admin\Authentication();
15 15
 $auth->authenticate();
@@ -29,30 +29,30 @@  discard block
 block discarded – undo
29 29
 ?>
30 30
 
31 31
 <h1><?php $tablecaption = _("User Authentication Records"); echo $tablecaption; ?></h1>
32
-<p><?php echo _("Note that:");?></p>
32
+<p><?php echo _("Note that:"); ?></p>
33 33
 <ul>
34
-    <li><?php echo _("Authentication records are deleted after six months retention time");?></li>
35
-    <li><?php echo _("Operator Domain is based on the RADIUS attribute 'Operator-Name' and not sent by all hotspots");?></li>
36
-    <li><?php echo _("Different MAC addresses per credential may be due to MAC Address randomisation in recent operating systems");?></li>
34
+    <li><?php echo _("Authentication records are deleted after six months retention time"); ?></li>
35
+    <li><?php echo _("Operator Domain is based on the RADIUS attribute 'Operator-Name' and not sent by all hotspots"); ?></li>
36
+    <li><?php echo _("Different MAC addresses per credential may be due to MAC Address randomisation in recent operating systems"); ?></li>
37 37
 </ul>
38 38
 <table class='authrecord'>
39
-    <caption><?php echo $tablecaption;?></caption>
39
+    <caption><?php echo $tablecaption; ?></caption>
40 40
     <tr>
41
-        <th scope="col"><strong><?php echo _("Timestamp");?></strong></th>
42
-        <th scope="col"><strong><?php echo _("Credential");?></strong></th>
43
-        <th scope="col"><strong><?php echo _("MAC Address");?></strong></th>
44
-        <th scope="col"><strong><?php echo _("Result");?></strong></th>
45
-        <th scope="col"><strong><?php echo _("Operator Domain");?></strong></th>
41
+        <th scope="col"><strong><?php echo _("Timestamp"); ?></strong></th>
42
+        <th scope="col"><strong><?php echo _("Credential"); ?></strong></th>
43
+        <th scope="col"><strong><?php echo _("MAC Address"); ?></strong></th>
44
+        <th scope="col"><strong><?php echo _("Result"); ?></strong></th>
45
+        <th scope="col"><strong><?php echo _("Operator Domain"); ?></strong></th>
46 46
     </tr>
47 47
     <?php
48 48
     $userAuthData = $profile->getUserAuthRecords($userInt);
49 49
     foreach ($userAuthData as $oneRecord) {
50
-        echo "<tr class='".($oneRecord['RESULT'] == "Access-Accept" ? "auth-success" : "auth-fail" )."'>"
50
+        echo "<tr class='".($oneRecord['RESULT'] == "Access-Accept" ? "auth-success" : "auth-fail")."'>"
51 51
                 . "<td>".$oneRecord['TIMESTAMP']."</td>"
52
-                . "<td>".substr_replace($oneRecord['CN'], "@…", strpos($oneRecord['CN'],"@"))."</td>"
52
+                . "<td>".substr_replace($oneRecord['CN'], "@…", strpos($oneRecord['CN'], "@"))."</td>"
53 53
                 . "<td>".$oneRecord['MAC']."</td>"
54 54
                 . "<td>".($oneRecord['RESULT'] == "Access-Accept" ? _("Success") : _("Failure"))."</td>"
55
-                . "<td>".substr($oneRecord['OPERATOR'] ?? "1(unknown)",1)."</td>"
55
+                . "<td>".substr($oneRecord['OPERATOR'] ?? "1(unknown)", 1)."</td>"
56 56
                 . "</tr>";
57 57
     }
58 58
     ?>
Please login to merge, or discard this patch.
web/admin/inc/displayQRcode.inc.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  */
21 21
 ?>
22 22
 <?php
23
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $languageInstance = new \core\common\Language();
@@ -38,8 +38,8 @@  discard block
 block discarded – undo
38 38
 $invitationObject = new core\SilverbulletInvitation($validator->token(filter_input(INPUT_POST, 'token')));
39 39
 header("Content-Type:text/html;charset=utf-8");
40 40
 ?>
41
-<h1 style='text-align:center;'><?php echo _("Invitation Token QR Code");?></h1>
42
-<img alt='<?php echo _("Invitation Token QR Code");?>' style='float:none' src='data:image/png;base64,<?php 
41
+<h1 style='text-align:center;'><?php echo _("Invitation Token QR Code"); ?></h1>
42
+<img alt='<?php echo _("Invitation Token QR Code"); ?>' style='float:none' src='data:image/png;base64,<?php 
43 43
 $size = 10;
44 44
 $qrCode = new \chillerlan\QRCode\QRCode(new \chillerlan\QRCode\QROptions([
45 45
                     'outputType' => \chillerlan\QRCode\QRCode::OUTPUT_IMAGE_PNG,
@@ -51,5 +51,5 @@  discard block
 block discarded – undo
51 51
 if (empty($rawQr)) {
52 52
     throw new Exception("Something went seriously wrong during QR code generation!");
53 53
 }
54
-echo base64_encode($uiElements->pngInjectConsortiumLogo($rawQr, $size));?>'/>
55
-<p>(<a href='<?php echo $invitationObject->link();?>'><?php echo $invitationObject->link();?>)</a></p>
54
+echo base64_encode($uiElements->pngInjectConsortiumLogo($rawQr, $size)); ?>'/>
55
+<p>(<a href='<?php echo $invitationObject->link(); ?>'><?php echo $invitationObject->link(); ?>)</a></p>
Please login to merge, or discard this patch.
web/skins/modern/user/js/cat_js.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  */
21 21
 
22 22
 $cat = new \web\lib\user\Gui();
23
-$idpId = filter_input(INPUT_GET, 'idp', FILTER_VALIDATE_INT) ?? filter_input(INPUT_POST, 'idp', FILTER_VALIDATE_INT)?? 0;
23
+$idpId = filter_input(INPUT_GET, 'idp', FILTER_VALIDATE_INT) ?? filter_input(INPUT_POST, 'idp', FILTER_VALIDATE_INT) ?? 0;
24 24
 $profileId = filter_input(INPUT_GET, 'profile', FILTER_VALIDATE_INT) ?? filter_input(INPUT_POST, 'profile', FILTER_VALIDATE_INT) ?? 0;
25 25
 $skinObject = $Gui->skinObject;
26 26
     ?>
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         otherdata = j.otherdata;
84 84
     if(! result) {
85 85
       alert("<?php $cat->javaScriptEscapedEcho(_("no matching data found"))?>");
86
-      document.location.href='<?php echo rtrim(dirname($_SERVER['SCRIPT_NAME']), '/') . '/' ?>';
86
+      document.location.href='<?php echo rtrim(dirname($_SERVER['SCRIPT_NAME']), '/').'/' ?>';
87 87
     }
88 88
     j = j.data;
89 89
     n = j.length;
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
        result = j1.status;
221 221
        if(! result) {
222 222
             alert("<?php $cat->javaScriptEscapedEcho(_("no matching data found")) ?>");
223
-            document.location.href='<?php echo rtrim(dirname($_SERVER['SCRIPT_NAME']), '/') . '/' ?>';
223
+            document.location.href='<?php echo rtrim(dirname($_SERVER['SCRIPT_NAME']), '/').'/' ?>';
224 224
        }
225 225
        j = j1.data;
226 226
        if(j.description !== undefined && j.description) {
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
          $("#profile_desc").hide();
232 232
          $("#profile_desc").text('');
233 233
        }
234
-       updateTxt = '<span class="user_info"><?php $cat->javaScriptEscapedEcho(_("This entry was last updated at:"));?>'+' '+j.last_changed+'</span><br/>';
234
+       updateTxt = '<span class="user_info"><?php $cat->javaScriptEscapedEcho(_("This entry was last updated at:")); ?>'+' '+j.last_changed+'</span><br/>';
235 235
        if(j.local_url !== undefined && j.local_url) 
236 236
        txt = txt+'<span class="user_info"><?php $cat->javaScriptEscapedEcho(_("WWW:")); ?> <a href="'+j.local_url+'" target="_blank">'+j.local_url+'</a></span><br/>';
237 237
        if(j.local_email !== undefined && j.local_email) 
Please login to merge, or discard this patch.
web/skins/example/accountstatus.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -16,12 +16,12 @@
 block discarded – undo
16 16
  * License: see the web/copyright.inc.php file in the file structure or
17 17
  *          <base_url>/copyright.php after deploying the software
18 18
  */?>
19
-<h1>Example Skin (Pick-Up and Status page for <?php echo \core\ProfileSilverbullet::PRODUCTNAME;?>)</h1>
20
-<img alt='Consortium logo' src="<?php echo $Gui->skinObject->findresourceUrl("IMAGES","consortium_logo.png");?>"/>
19
+<h1>Example Skin (Pick-Up and Status page for <?php echo \core\ProfileSilverbullet::PRODUCTNAME; ?>)</h1>
20
+<img alt='Consortium logo' src="<?php echo $Gui->skinObject->findresourceUrl("IMAGES", "consortium_logo.png"); ?>"/>
21 21
 <p>This skin is much more sober and less bloated than the default one. As it happens, it also doesn't do anything.</p>
22 22
 <p>But at least it goes to show that it's possible to include custom images/CSS/external software using findResourceUrl(..., $filename):
23
-<img alt='Custom image' src="<?php echo $Gui->skinObject->findresourceUrl("IMAGES","custom.png");?>"/>
24
-<p>For <?php echo \core\ProfileSilverbullet::PRODUCTNAME;?>, this page can make use of the request status info we have collected prior to invocation of the skinned page:</p>
23
+<img alt='Custom image' src="<?php echo $Gui->skinObject->findresourceUrl("IMAGES", "custom.png"); ?>"/>
24
+<p>For <?php echo \core\ProfileSilverbullet::PRODUCTNAME; ?>, this page can make use of the request status info we have collected prior to invocation of the skinned page:</p>
25 25
 <pre>
26
-    <?php print_r($statusInfo);?>
26
+    <?php print_r($statusInfo); ?>
27 27
 </pre>
Please login to merge, or discard this patch.
web/skins/example/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
  */
21 21
 ?>
22 22
 <h1>Example Skin (main user frontpage)</h1>
23
-<img alt='Consortium logo' src="<?php echo $Gui->skinObject->findresourceUrl("IMAGES","consortium_logo.png");?>"/>
23
+<img alt='Consortium logo' src="<?php echo $Gui->skinObject->findresourceUrl("IMAGES", "consortium_logo.png"); ?>"/>
24 24
 <p>This skin is much more sober and less bloated than the default one. As it happens, it also doesn't do anything.</p>
25 25
 <p>But at least it goes to show that it's possible to include custom images/CSS/external software using findResourceUrl(..., $filename):
26
-<img alt='Custom image' src="<?php echo $Gui->skinObject->findresourceUrl("IMAGES","custom.png");?>"/>
26
+<img alt='Custom image' src="<?php echo $Gui->skinObject->findresourceUrl("IMAGES", "custom.png"); ?>"/>
Please login to merge, or discard this patch.
config/Main-template.php 2 patches
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,6 @@
 block discarded – undo
148 148
          *    mails, just configure the signing cert with these parameters. All must
149 149
          *    be non-NULL for signing to happen. If you don't need a keypass, make 
150 150
          *    it an empty string instead.
151
-
152 151
          * @var array
153 152
          */
154 153
         const MAILSETTINGS = [// we always use Submission
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
                 'db' => 'cat',
216 216
                 'user' => 'kitty',
217 217
                 'pass' => 'somepass',
218
-                'readonly' => FALSE,],
218
+                'readonly' => FALSE, ],
219 219
             // this DB stores diagnostics data. The connection details can be
220 220
             // identical to INST as there is no table overlap
221 221
             'DIAGNOSTICS' => [
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
                 'db' => 'cat',
224 224
                 'user' => 'kitty',
225 225
                 'pass' => 'somepass',
226
-                'readonly' => FALSE,],
226
+                'readonly' => FALSE, ],
227 227
             // this slice of DB user is about the downloads table. The corresponding
228 228
             // DB user should have write access to update statistics and the cache
229 229
             // locations of installers. 
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
                 'db' => 'cat',
234 234
                 'user' => 'kitty',
235 235
                 'pass' => 'somepass',
236
-                'readonly' => FALSE,],
236
+                'readonly' => FALSE, ],
237 237
             // this slice of DB use is about user management in the user_options
238 238
             // table. Giving the corresponding user only read-only access means that
239 239
             // all user properties have to "magically" occur in the table by OOB
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
                 'db' => 'cat',
245 245
                 'user' => 'kitty',
246 246
                 'pass' => 'somepass',
247
-                'readonly' => FALSE,],
247
+                'readonly' => FALSE, ],
248 248
             /*   If you use this tool in conjunction with an external customer management database, you can configure that every 
249 249
              * institution entry in CAT MUST correspond to a customer entry in an external database. If you want this, set this
250 250
              * config variable to TRUE.
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
                 'db' => 'customer_db',
265 265
                 'user' => 'customerservice',
266 266
                 'pass' => '2lame4u',
267
-                'readonly' => TRUE,],
267
+                'readonly' => TRUE, ],
268 268
             'enforce-external-sync' => TRUE,
269 269
         ];
270 270
         /**
Please login to merge, or discard this patch.
utils/notify_invitation_expiry.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 // please run this as a cron job every hour
23 23
 
24
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
24
+require_once dirname(dirname(__FILE__))."/config/_config.php";
25 25
 
26 26
 // iterate through all federations and see if there are recently expired 
27 27
 // invitations for any of them
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     $admins = $this_fed->listFederationAdmins();
56 56
     $mailtext = "Hello,
57 57
 
58
-invitation tokens for the following new ". \config\ConfAssistant::CONSORTIUM['nomenclature_institution'] ." have recently expired:
58
+invitation tokens for the following new ". \config\ConfAssistant::CONSORTIUM['nomenclature_institution']." have recently expired:
59 59
 
60 60
 ";
61 61
     foreach ($listofinstnames as $instname) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     if ($numberofexistingidps > 0) {
66 66
         $mailtext .= "
67 67
 
68
-Additionally, $numberofexistingidps invitations for an existing ". \config\ConfAssistant::CONSORTIUM['nomenclature_institution']." have expired.
68
+Additionally, $numberofexistingidps invitations for an existing ".\config\ConfAssistant::CONSORTIUM['nomenclature_institution']." have expired.
69 69
         ";
70 70
     }
71 71
     $mailtext .= "
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
 Greetings,
75 75
 
76
-A humble " . \config\Main::APPEARANCE['productname'] . " cron job
76
+A humble " . \config\Main::APPEARANCE['productname']." cron job
77 77
 ";
78 78
 
79 79
     foreach ($admins as $admin) {
Please login to merge, or discard this patch.
utils/installTranslations.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
  * License: see the web/copyright.php file in the file structure
9 9
  * ******************************************************************************
10 10
  */
11
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
11
+require_once dirname(dirname(__FILE__))."/config/_config.php";
12 12
 
13 13
 const AREAS = ["web_admin", "web_user", "devices", "core", "diagnostics"];
14 14
 foreach (\config\Main::LANGUAGES as $lang => $details) {
Please login to merge, or discard this patch.
web/diag/adminQuery.php 1 patch
Spacing   +44 added lines, -44 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  * License: see the web/copyright.inc.php file in the file structure or
20 20
  *          <base_url>/copyright.php after deploying the software
21 21
  */
22
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
23 23
 $languageInstance = new \core\common\Language();
24 24
 $languageInstance->setTextDomain("diagnostics");
25 25
 $loggerInstance = new \core\common\Logging();
@@ -61,43 +61,43 @@  discard block
 block discarded – undo
61 61
     $select = "<div id='sp_abuse_problem'>
62 62
 <select style='margin-left: 0px;' id='select_sp_problem'>";
63 63
     foreach ($sp_problem as $pname => $pdesc) {
64
-        $select = $select . "<option value='$pname'>$pdesc</option>\n";
64
+        $select = $select."<option value='$pname'>$pdesc</option>\n";
65 65
     }
66
-    $select = $select . "</select></div>";
66
+    $select = $select."</select></div>";
67 67
     $res = "
68 68
 <input type='hidden' name='token' id='token' value=''>
69 69
 <input type='hidden' name='tests_result' id='tests_result' value=''>
70 70
 <table id='sp_questions'>
71 71
     <tr id='sp_problem_selector'>
72
-        <td>" . _("Select your problem") . "</td>
72
+        <td>" . _("Select your problem")."</td>
73 73
         <td>$select</td>
74 74
     </tr>
75 75
     <tr>
76
-        <td>" . _("What is the realm of the IdP in question?") . "</td>
76
+        <td>"._("What is the realm of the IdP in question?")."</td>
77 77
         <td>
78 78
                 <input type='text' name='admin_realm' id='admin_realm' value='$realmFromURL'>
79
-                <button class='diag_button' id='realm_in_db_admin' style='display: none;' accesskey='R' type='button'>" .
80
-                _("Check this realm") .
79
+                <button class='diag_button' id='realm_in_db_admin' style='display: none;' accesskey='R' type='button'>".
80
+                _("Check this realm").
81 81
                 "</button>
82 82
                 <div id='tests_info_area'></div>
83 83
         </td>
84 84
     </tr>
85 85
     <tr class='hidden_row'>
86
-        <td>" . _("What is the authentication timestamp of the user session in question?") . "</td>
86
+        <td>" . _("What is the authentication timestamp of the user session in question?")."</td>
87 87
         <td><input type='text' id='timestamp' name='timestamp'>
88 88
             <div id='datepicker'></div>
89 89
         </td>
90 90
     </tr>
91 91
     <tr class='hidden_row'>
92
-        <td>" . _("What is the MAC address of the user session in question?") . "</td>
92
+        <td>" . _("What is the MAC address of the user session in question?")."</td>
93 93
         <td><input type='text' id='mac' name='mac'></td>
94 94
     </tr>
95 95
     <tr class='hidden_row'>
96
-        <td>" . _("Additional comments") . "</td>
96
+        <td>" . _("Additional comments")."</td>
97 97
         <td><textarea id='freetext' name='freetext' cols='60' rows='5'></textarea></td>
98 98
     </tr>
99 99
     <tr class='hidden_row'>
100
-        <td>" . _("Please specify an email address on which the IdP can contact you") . "</td>
100
+        <td>" . _("Please specify an email address on which the IdP can contact you")."</td>
101 101
         <td><input type='text' id='email' name='email'></td>
102 102
     </tr>
103 103
     <tr>
@@ -105,82 +105,82 @@  discard block
 block discarded – undo
105 105
         <td></td>
106 106
     </tr>
107 107
     <tr class='hidden_row' id='send_query_to_idp'>
108
-        <td>" . _("Now you can send your query") . "</td>
109
-        <td><button type='submit' class='diag_button' id='submit_idp_query' name='go'>" . _("Send") . "</button></td>
108
+        <td>" . _("Now you can send your query")."</td>
109
+        <td><button type='submit' class='diag_button' id='submit_idp_query' name='go'>" . _("Send")."</button></td>
110 110
     </tr>
111 111
  </table>";
112
-    $res = $res . $javascript;
112
+    $res = $res.$javascript;
113 113
 }
114 114
 if ($queryType == 'idp') {
115 115
     $select = "<div id='idp_reported_problem' style='display:;'>
116 116
 <select style='margin-left:0px;' id='select_idp_problem'>";
117 117
     foreach ($idp_problem as $pname => $pdesc) {
118
-        $select = $select . "<option value='$pname'>$pdesc</option>\n";
118
+        $select = $select."<option value='$pname'>$pdesc</option>\n";
119 119
     }
120
-    $select = $select . "</select></div>";
120
+    $select = $select."</select></div>";
121 121
     $res = "
122 122
 <table id='idp_questions'>
123 123
     <tr>
124
-        <td>" . _("Select your problem") . "</td>
124
+        <td>" . _("Select your problem")."</td>
125 125
         <td>$select</td>
126 126
     </tr>
127 127
     <tr>
128
-        <td>" . _("Identify the SP by one of following means") . "</td>
128
+        <td>"._("Identify the SP by one of following means")."</td>
129 129
         <td></td>
130 130
     </tr>
131 131
     <tr id='by_opname'>
132
-        <td>" . _("SP Operator-Name attribute") . "</td>
132
+        <td>" . _("SP Operator-Name attribute")."</td>
133 133
         <td><input type='text' id='opname' name='opname' value=''></td>
134 134
     </tr>
135 135
     <tr id='spmanually'>
136
-        <td>" . _("Select the SP manually:") . "</td>
136
+        <td>" . _("Select the SP manually:")."</td>
137 137
         <td>
138 138
             <div id='select_asp_country'><a href='' id='asp_countries_list'>
139
-            <span id='opnameselect'>" . _("click to select country and organisation") . "</a></span>
139
+            <span id='opnameselect'>" . _("click to select country and organisation")."</a></span>
140 140
             </div>
141 141
             <div id='select_asp_area'></div>
142 142
         </td>
143 143
     </tr>
144 144
     <tr id='asp_desc' style='display: none;'>
145
-        <td>" . _("or") . ' ' . _("at least describe the SP location") . "</td>
145
+        <td>" . _("or").' '._("at least describe the SP location")."</td>
146 146
         <td><input type='text' id='asp_location' name='asp_location' value=''></td>
147 147
     </tr>
148 148
     <tr>
149
-        <td>" . _("What is the outer ID of the user session in question?") . "</td>
149
+        <td>" . _("What is the outer ID of the user session in question?")."</td>
150 150
         <td><input type='text' id='outer_id' name='outer_id' value=''></td>
151 151
     </tr>
152 152
     <tr>
153
-        <td>" . _("What is the authentication timestamp of the user session in question?") . "</td>
153
+        <td>" . _("What is the authentication timestamp of the user session in question?")."</td>
154 154
         <td>
155 155
             <input type='text' id='timestamp' name='timestamp'>
156 156
             <div id='datepicker'></div>
157 157
         </td>
158 158
     </tr>
159 159
     <tr>
160
-        <td>" . _("What is the MAC address of the user session in question?") . "</td>
160
+        <td>" . _("What is the MAC address of the user session in question?")."</td>
161 161
         <td><input type='text' id='mac' name='mac'></td>
162 162
     </tr>
163 163
     <tr>
164
-        <td>" . _("Additional comments about the problem") . "</td>
164
+        <td>" . _("Additional comments about the problem")."</td>
165 165
         <td><textarea id='freetext' name='freetext' cols='60' rows='5'></textarea></td>
166 166
     </tr>
167 167
     <tr>
168
-        <td>" . _("Do you have any contact details by which the user wishes to be contacted by the SP?") . "</td>
168
+        <td>" . _("Do you have any contact details by which the user wishes to be contacted by the SP?")."</td>
169 169
         <td><textarea id='c_details' name='c_details' cols='60' rows='5'></textarea></td>
170 170
     </tr>
171 171
     <tr>
172
-        <td>" . _("Please specify an email address on which the SP can contact you") . "</td>
172
+        <td>" . _("Please specify an email address on which the SP can contact you")."</td>
173 173
         <td><input type='text' id='email' name='email'></td>
174 174
     </tr>
175 175
     <tr class='hidden_row' id='send_query_to_sp'>
176
-        <td>" . _("Now you can send your query") . "</td>
177
-        <td><button type='submit' class='diag_button' id='submit_sp_query' name='go'>" . _("Send") . "</button></td>
176
+        <td>" . _("Now you can send your query")."</td>
177
+        <td><button type='submit' class='diag_button' id='submit_sp_query' name='go'>" . _("Send")."</button></td>
178 178
     </tr>
179 179
 </table>";
180
-    $res = $res . $javascript;
180
+    $res = $res.$javascript;
181 181
 }
182 182
 if ($queryType == 'idp_send' || $queryType == 'sp_send') {
183
-    include_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
183
+    include_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
184 184
     $cat = new \core\CAT();
185 185
     $returnArray = array();
186 186
     if (count((array) $o) > 0) {
@@ -189,8 +189,8 @@  discard block
 block discarded – undo
189 189
             switch ($key) {
190 190
                 case 'realm':
191 191
                     $pos = strpos($value, '@');
192
-                    if ($pos !== FALSE ) {
193
-                        $value = substr($value, $pos+1);
192
+                    if ($pos !== FALSE) {
193
+                        $value = substr($value, $pos + 1);
194 194
                     }
195 195
                 case 'email':
196 196
                 case 'mac':
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
         $mail = \core\common\OutsideComm::mailHandle();
227 227
         $emails = ['[email protected]'];
228 228
         //$emails = explode(',', $returnArray['idpcontact']);
229
-        $mail->FromName = \config\Main::APPEARANCE['productname'] . " Notification System";
229
+        $mail->FromName = \config\Main::APPEARANCE['productname']." Notification System";
230 230
         foreach ($emails as $email) {
231 231
             $mail->addAddress($email);
232 232
         }
@@ -236,11 +236,11 @@  discard block
 block discarded – undo
236 236
         } else {
237 237
             $link = 'http://';
238 238
         }
239
-        $link .= $_SERVER['SERVER_NAME'] . \core\CAT::getRootUrlPath() . '/diag/show_realmcheck.php?token=' . $returnArray['token'];
239
+        $link .= $_SERVER['SERVER_NAME'].\core\CAT::getRootUrlPath().'/diag/show_realmcheck.php?token='.$returnArray['token'];
240 240
         $returnArray['testurl'] = $link;
241 241
         $mail->Subject = _('Suspected a technical problem with the IdP');
242
-        $txt = _("We suspect a technical problem with the IdP handling the realm") . ' ' . 
243
-                $returnArray['realm'] . ".\n";
242
+        $txt = _("We suspect a technical problem with the IdP handling the realm").' '. 
243
+                $returnArray['realm'].".\n";
244 244
         $txt .= _("The CAT diagnostic test was run for this realm during reporting.\n");
245 245
         $txt .= _("The overall result was ");
246 246
         if ($returnArray['tests_result'] == 0) {
@@ -248,15 +248,15 @@  discard block
 block discarded – undo
248 248
         } else {
249 249
             $txt .= _("failure");
250 250
         }
251
-        $txt .= ".\n" . _("To see details go to ");
251
+        $txt .= ".\n"._("To see details go to ");
252 252
         $txt .= "$link\n\n";
253
-        $txt .= _("The reported problem details are as follows") . "\n";
254
-        $txt .= _("timestamp") . ": " . $returnArray['timestamp'] . "\n";
255
-        $txt .= _("client MAC address") . ": " . $returnArray['mac'] . "\n";
253
+        $txt .= _("The reported problem details are as follows")."\n";
254
+        $txt .= _("timestamp").": ".$returnArray['timestamp']."\n";
255
+        $txt .= _("client MAC address").": ".$returnArray['mac']."\n";
256 256
         if ($returnArray['freetext']) {
257
-            $txt .= _("additional comments") . ': ' . $returnArray['freetext'] . "\n";
257
+            $txt .= _("additional comments").': '.$returnArray['freetext']."\n";
258 258
         }
259
-        $txt .= "\n" . _("You can contact the incident reporter at") . ' ' . $returnArray['email'];
259
+        $txt .= "\n"._("You can contact the incident reporter at").' '.$returnArray['email'];
260 260
         
261 261
         $mail->Body = $txt;
262 262
         $sent = $mail->send();
Please login to merge, or discard this patch.