Passed
Push — master ( b32147...6275ed )
by Maja
06:20
created
core/Psr4Autoloader.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -156,8 +156,8 @@
 block discarded – undo
156 156
             // replace namespace separators with directory separators
157 157
             // in the relative class name, append with .php
158 158
             $file = $base_dir
159
-                  . str_replace('\\', '/', $relative_class)
160
-                  . '.php';
159
+                    . str_replace('\\', '/', $relative_class)
160
+                    . '.php';
161 161
 
162 162
             // if the mapped file exists, require it
163 163
             if ($this->requireFile($file)) {
Please login to merge, or discard this patch.
core/diag/RFC6614Tests.php 1 patch
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -246,11 +246,11 @@  discard block
 block discarded – undo
246 246
     }
247 247
 
248 248
         /**
249
-     * This function parses a X.509 cert and returns all certificatePolicies OIDs
250
-     * 
251
-     * @param array $cert (returned from openssl_x509_parse) 
252
-     * @return array of OIDs
253
-     */
249
+         * This function parses a X.509 cert and returns all certificatePolicies OIDs
250
+         * 
251
+         * @param array $cert (returned from openssl_x509_parse) 
252
+         * @return array of OIDs
253
+         */
254 254
     private function propertyCheckPolicy($cert) {
255 255
         $oids = [];
256 256
         if ($cert['extensions']['certificatePolicies']) {
@@ -263,11 +263,11 @@  discard block
 block discarded – undo
263 263
         return $oids;
264 264
     }
265 265
         /**
266
-     * This function parses a X.509 cert and returns the value of $field
267
-     * 
268
-     * @param array $cert (returned from openssl_x509_parse) 
269
-     * @return string value of the issuer field or ''
270
-     */
266
+         * This function parses a X.509 cert and returns the value of $field
267
+         * 
268
+         * @param array $cert (returned from openssl_x509_parse) 
269
+         * @return string value of the issuer field or ''
270
+         */
271 271
     private function getCertificateIssuer($cert) {
272 272
         $issuer = '';
273 273
         foreach ($cert['issuer'] as $key => $val) {
Please login to merge, or discard this patch.
web/admin/overview_federation.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -311,8 +311,8 @@
 block discarded – undo
311 311
                             echo "<form method='post' action='overview_federation.php' accept-charset='UTF-8'>
312 312
                                 <input type='hidden' name='invitation_id' value='" . $oneinvite['token'] . "'/>
313 313
                                 <button class='delete' type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_DELETE . "'>" . _("Revoke Invitation") . "</button> "
314
-                              . sprintf(_("(expires %s)"),$oneinvite['expiry'])
315
-                              .     "</form>";
314
+                                . sprintf(_("(expires %s)"),$oneinvite['expiry'])
315
+                                .     "</form>";
316 316
                         }
317 317
                         echo "      </td>
318 318
                                  </tr>";
Please login to merge, or discard this patch.
web/lib/admin/MapNone.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
      */
84 84
     public function htmlShowtime($wizard = FALSE, $additional = FALSE) {
85 85
         if (!$this->readOnly) {
86
- //           return $this->htmlPreEdit($wizard, $additional) . $this->htmlPostEdit(TRUE);
86
+    //           return $this->htmlPreEdit($wizard, $additional) . $this->htmlPostEdit(TRUE);
87 87
             return $this->htmlPreEdit($wizard, $additional) . $this->findLocationHtml() . $this->htmlPostEdit(TRUE);
88 88
         }
89 89
     }
Please login to merge, or discard this patch.
core/diag/Sociopath.php 1 patch
Indentation   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -67,45 +67,45 @@
 block discarded – undo
67 67
         // let's start the numbering at 1
68 68
         $this->qaArray = [
69 69
             1 => ["AREA" => AbstractTest::INFRA_DEVICE,
70
-                  "TXT" => _("Have you ever used the network succesfully, e.g. at your home institution without roaming?"),
71
-                  "FACTOR_YES" => 0.8, // that's good, but it doesn't mean strikingly much
72
-                  "FACTOR_NO" => 2, // that's bad, and points strongly to a config on this end
73
-                  "VERDICTLECTURE" => sprintf(_("If your device has never worked before with this setup, then very likely your device configuation is wrong. %s"), $confAssistantText)],
70
+                    "TXT" => _("Have you ever used the network succesfully, e.g. at your home institution without roaming?"),
71
+                    "FACTOR_YES" => 0.8, // that's good, but it doesn't mean strikingly much
72
+                    "FACTOR_NO" => 2, // that's bad, and points strongly to a config on this end
73
+                    "VERDICTLECTURE" => sprintf(_("If your device has never worked before with this setup, then very likely your device configuation is wrong. %s"), $confAssistantText)],
74 74
             2 => ["AREA" => AbstractTest::INFRA_DEVICE, 
75
-                  "TXT" => _("Did the device previously work when roaming, i.e. at other hotspots away from your home institution?"), 
76
-                  "FACTOR_YES" => 0.6, // that's good, and somewhat encouraging
77
-                  "FACTOR_NO" => 3, // that is almost a smoking gun
78
-                  "VERDICTLECTURE" => sprintf(_("If roaming consistently does not work, then very likely your device configuration is wrong. Typical errors causing this symptom include: using a routing ('outer') username without the @realm.tld suffix - those potentially work at your home organisation, but can not be used when roaming. %s"),$confAssistantText)],
75
+                    "TXT" => _("Did the device previously work when roaming, i.e. at other hotspots away from your home institution?"), 
76
+                    "FACTOR_YES" => 0.6, // that's good, and somewhat encouraging
77
+                    "FACTOR_NO" => 3, // that is almost a smoking gun
78
+                    "VERDICTLECTURE" => sprintf(_("If roaming consistently does not work, then very likely your device configuration is wrong. Typical errors causing this symptom include: using a routing ('outer') username without the @realm.tld suffix - those potentially work at your home organisation, but can not be used when roaming. %s"),$confAssistantText)],
79 79
             3 => ["AREA" => AbstractTest::INFRA_DEVICE, 
80
-                  "TXT" => _("Did you recently change the configuration on your device?"), 
81
-                  "FACTOR_YES" => 3, // that is almost a smoking gun
82
-                  "FACTOR_NO" => 0.6, // encouraging
83
-                  "VERDICTLECTURE" => _("Accounts only need to be configured once, and can then be used anywhere on the planet without any changes. If you recently changed the configuration, that change may very well be at fault. You should never change your network configuration unless explicitly instructed so by your Identity Provider; even in the case of temporary login issues.")],
80
+                    "TXT" => _("Did you recently change the configuration on your device?"), 
81
+                    "FACTOR_YES" => 3, // that is almost a smoking gun
82
+                    "FACTOR_NO" => 0.6, // encouraging
83
+                    "VERDICTLECTURE" => _("Accounts only need to be configured once, and can then be used anywhere on the planet without any changes. If you recently changed the configuration, that change may very well be at fault. You should never change your network configuration unless explicitly instructed so by your Identity Provider; even in the case of temporary login issues.")],
84 84
             4 => ["AREA" => AbstractTest::INFRA_DEVICE, 
85
-                  "TXT" => _("Did you recently change your password?"), 
86
-                  "FACTOR_YES" => 1.5, // that doesn't mean it is the source of the problem, but it /might/ be that the user forgot to provide the new password
87
-                  "FACTOR_NO" => 0.6, // encouraging
88
-                  "VERDICTLECTURE" => _("When you change your password, you also need to supply the new password in the device configuration.")],
85
+                    "TXT" => _("Did you recently change your password?"), 
86
+                    "FACTOR_YES" => 1.5, // that doesn't mean it is the source of the problem, but it /might/ be that the user forgot to provide the new password
87
+                    "FACTOR_NO" => 0.6, // encouraging
88
+                    "VERDICTLECTURE" => _("When you change your password, you also need to supply the new password in the device configuration.")],
89 89
             5 => ["AREA" => AbstractTest::INFRA_DEVICE, 
90
-                  "TXT" => _("If you use more than one device: do your other devices still work?"),
91
-                  "FACTOR_YES" => 0.33, // seems that all is okay with the account as such
92
-                  "FACTOR_NO" => 3, // now that is suspicious indeed
93
-                  "VERDICTLECTURE" => _("If all devices stopped working simultaneously, there may be a problem with your account as such. Maybe your account expired, or you were forced to change the password? These questions are best answered by your Identity Provider [MGW: display contact info]"),],
90
+                    "TXT" => _("If you use more than one device: do your other devices still work?"),
91
+                    "FACTOR_YES" => 0.33, // seems that all is okay with the account as such
92
+                    "FACTOR_NO" => 3, // now that is suspicious indeed
93
+                    "VERDICTLECTURE" => _("If all devices stopped working simultaneously, there may be a problem with your account as such. Maybe your account expired, or you were forced to change the password? These questions are best answered by your Identity Provider [MGW: display contact info]"),],
94 94
             6 => ["AREA" => AbstractTest::INFRA_SP_80211, 
95
-                  "TXT" => _("Is the place you are currently at heavily crowded, or is a network-intensive workload going on?"), 
96
-                  "FACTOR_YES" => 3,
97
-                  "FACTOR_NO" => 0.33,
98
-                  "VERDICTLECTURE" => _("The network is likely overloaded at this location and point in time. You may have to wait until later before you get a better connectivity. If you think the network should be reinforced for more capacity at this place, you should inform the hotspot provider. [MGW: add contact info]")],            
95
+                    "TXT" => _("Is the place you are currently at heavily crowded, or is a network-intensive workload going on?"), 
96
+                    "FACTOR_YES" => 3,
97
+                    "FACTOR_NO" => 0.33,
98
+                    "VERDICTLECTURE" => _("The network is likely overloaded at this location and point in time. You may have to wait until later before you get a better connectivity. If you think the network should be reinforced for more capacity at this place, you should inform the hotspot provider. [MGW: add contact info]")],            
99 99
             7 => ["AREA" => AbstractTest::INFRA_SP_80211, 
100
-                  "TXT" => _("Does the connection get better when you move around?"), 
101
-                  "FACTOR_YES" => 3,
102
-                  "FACTOR_NO" => 0.33,
103
-                  "VERDICTLECTURE" => _("You should move to a different location to achieve better network coverage and service. If you think the exact spot you are at deserves better coverage, you should inform the hotspot provider. [MGW: add contact info]")],
100
+                    "TXT" => _("Does the connection get better when you move around?"), 
101
+                    "FACTOR_YES" => 3,
102
+                    "FACTOR_NO" => 0.33,
103
+                    "VERDICTLECTURE" => _("You should move to a different location to achieve better network coverage and service. If you think the exact spot you are at deserves better coverage, you should inform the hotspot provider. [MGW: add contact info]")],
104 104
             8 => ["AREA" => AbstractTest::INFRA_SP_LAN, 
105
-                  "TXT" => _("Do you see errors stating something similar to 'Unable to get IP address'?"), 
106
-                  "FACTOR_YES" => 5, // gotcha
107
-                  "FACTOR_YES" => 0.5, // the user saying no is not conclusive; maybe the device isn't that verbose or he's not looking at the right spot
108
-                  "VERDICTLECTURE" => _("The evidence at hand suggests that there may be an infrastructure problem at this particular hotspot provider. There is nothing you can do to solve this problem locally. Please be patient and try again at a later time.")],
105
+                    "TXT" => _("Do you see errors stating something similar to 'Unable to get IP address'?"), 
106
+                    "FACTOR_YES" => 5, // gotcha
107
+                    "FACTOR_YES" => 0.5, // the user saying no is not conclusive; maybe the device isn't that verbose or he's not looking at the right spot
108
+                    "VERDICTLECTURE" => _("The evidence at hand suggests that there may be an infrastructure problem at this particular hotspot provider. There is nothing you can do to solve this problem locally. Please be patient and try again at a later time.")],
109 109
         ];
110 110
         \core\common\Entity::outOfThePotatoes();
111 111
     }
Please login to merge, or discard this patch.
web/skins/modern/diag/diag.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -156,7 +156,7 @@
 block discarded – undo
156 156
                         echo "0\">";
157 157
                         echo _("This service is for authenticated admins only.") . '<br>';
158 158
                         echo "<a href=\"diag.php?admin=1\">" .
159
-                             _("eduroam® admin access is needed") . "</a>";
159
+                                _("eduroam® admin access is needed") . "</a>";
160 160
                     }
161 161
                 ?>
162 162
             </div> 
Please login to merge, or discard this patch.
devices/linux/DeviceLinux.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -211,7 +211,7 @@
 block discarded – undo
211 211
         }
212 212
 
213 213
         if (!empty($this->attributes['internal:realm'][0])) {
214
-           $config['user_realm'] = $this->attributes['internal:realm'][0];
214
+            $config['user_realm'] = $this->attributes['internal:realm'][0];
215 215
         }
216 216
         
217 217
         if(!empty($this->attributes['internal:hint_userinput_suffix'][0]) && $this->attributes['internal:hint_userinput_suffix'][0] == 1) {
Please login to merge, or discard this patch.
devices/redirect_dev/DeviceRedirectDev.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -22,15 +22,15 @@
 block discarded – undo
22 22
 namespace devices\redirect_dev;
23 23
 
24 24
 class DeviceRedirectDev extends \core\DeviceConfig {
25
-   /**
26
-    * Constructs a Device object.
27
-    *
28
-    * @final not to be redefined
29
-    */
25
+    /**
26
+     * Constructs a Device object.
27
+     *
28
+     * @final not to be redefined
29
+     */
30 30
     final public function __construct() {
31 31
         parent::__construct();
32
-      $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_NONE]);
33
-      $this->loggerInstance->debug(4,"RedirectEx called");
32
+        $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_NONE]);
33
+        $this->loggerInstance->debug(4,"RedirectEx called");
34 34
     }
35 35
     
36 36
     /**
Please login to merge, or discard this patch.
devices/PP_OSU_XML/DevicePPOSUXML.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -101,8 +101,8 @@  discard block
 block discarded – undo
101 101
       <NodeName>CATPasspointSetting</NodeName>
102 102
       <Node>
103 103
         <NodeName>AAAServerTrustRoot</NodeName>';
104
-      foreach ($this->attributes['internal:CAs'][0] as $oneCert) {
105
-          $content .= '<Node>
104
+        foreach ($this->attributes['internal:CAs'][0] as $oneCert) {
105
+            $content .= '<Node>
106 106
                          <NodeName>'.$oneCert['uuid'].'</NodeName>
107 107
                              <Node>
108 108
                                <NodeName>CertSHA256Fingerprint</NodeName>
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
                              </Node>
111 111
                        </Node>
112 112
                   ';
113
-      }
114
-      $content .= '</Node>
113
+        }
114
+        $content .= '</Node>
115 115
       <Node>
116 116
         <NodeName>Credential</NodeName>
117 117
         <Node>
Please login to merge, or discard this patch.