Passed
Push — release_2_1 ( a48ea7...fb4f05 )
by Stefan
09:56
created
web/admin/action_enrollment.php 1 patch
Switch Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,14 +49,14 @@
 block discarded – undo
49 49
 }
50 50
 
51 51
 switch ($_GET['token']) {
52
-    case "SELF-REGISTER":
53
-        $token = "SELF-REGISTER";
54
-        $checkval = \core\UserManagement::TOKENSTATUS_OK_NEW;
55
-        $federation = \config\ConfAssistant::CONSORTIUM['selfservice_registration'];
56
-        break;
57
-    default:
58
-        $token = $validator->token(filter_input(INPUT_GET,'token',FILTER_SANITIZE_STRING));
59
-        $checkval = $usermgmt->checkTokenValidity($token);
52
+        case "SELF-REGISTER":
53
+            $token = "SELF-REGISTER";
54
+            $checkval = \core\UserManagement::TOKENSTATUS_OK_NEW;
55
+            $federation = \config\ConfAssistant::CONSORTIUM['selfservice_registration'];
56
+            break;
57
+        default:
58
+            $token = $validator->token(filter_input(INPUT_GET,'token',FILTER_SANITIZE_STRING));
59
+            $checkval = $usermgmt->checkTokenValidity($token);
60 60
 }
61 61
 
62 62
 if ($checkval < 0) {
Please login to merge, or discard this patch.
web/admin/inc/sendinvite.inc.php 1 patch
Switch Indentation   +87 added lines, -87 removed lines patch added patch discarded remove patch
@@ -98,98 +98,98 @@
 block discarded – undo
98 98
 }
99 99
 
100 100
 switch ($operationMode) {
101
-    case OPERATION_MODE_EDIT:
102
-        $idp = $validator->existingIdP($_GET['inst_id']);
103
-        // editing IdPs is done from within the popup. When we're done, send the 
104
-        // user back to the popup (append the result of the operation later)
105
-        $redirectDestination = "manageAdmins.inc.php?inst_id=" . $idp->identifier . "&";
106
-        if (count($validAddresses) == 0) {
107
-            header("Location: $redirectDestination" . "invitation=INVALIDSYNTAX");
108
-            exit(1);
109
-        }
110
-        // is the user primary admin of this IdP?
111
-        $is_owner = $idp->isPrimaryOwner($_SESSION['user']);
112
-        // check if he is (also) federation admin for the federation this IdP is in. His invitations have more blessing then.
113
-        $fedadmin = $userObject->isFederationAdmin($idp->federation);
114
-        // check if he is either one, if not, complain
115
-        if (!$is_owner && !$fedadmin) {
116
-            echo "<p>" . sprintf(_("Something's wrong... you are a %s admin, but not for the %s the requested %s belongs to!"), $uiElements->nomenclatureFed, $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant) . "</p>";
117
-            exit(1);
118
-        }
101
+        case OPERATION_MODE_EDIT:
102
+            $idp = $validator->existingIdP($_GET['inst_id']);
103
+            // editing IdPs is done from within the popup. When we're done, send the 
104
+            // user back to the popup (append the result of the operation later)
105
+            $redirectDestination = "manageAdmins.inc.php?inst_id=" . $idp->identifier . "&";
106
+            if (count($validAddresses) == 0) {
107
+                header("Location: $redirectDestination" . "invitation=INVALIDSYNTAX");
108
+                exit(1);
109
+            }
110
+            // is the user primary admin of this IdP?
111
+            $is_owner = $idp->isPrimaryOwner($_SESSION['user']);
112
+            // check if he is (also) federation admin for the federation this IdP is in. His invitations have more blessing then.
113
+            $fedadmin = $userObject->isFederationAdmin($idp->federation);
114
+            // check if he is either one, if not, complain
115
+            if (!$is_owner && !$fedadmin) {
116
+                echo "<p>" . sprintf(_("Something's wrong... you are a %s admin, but not for the %s the requested %s belongs to!"), $uiElements->nomenclatureFed, $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant) . "</p>";
117
+                exit(1);
118
+            }
119 119
 
120
-        $prettyprintname = $idp->name;
121
-        $newtokens = $mgmt->createTokens($fedadmin, $validAddresses, $idp);
122
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP " . $idp->identifier . " - Token created for " . implode(",", $validAddresses));
123
-        $introtext = "CO-ADMIN";
124
-        $participant_type = $idp->type;
125
-        break;
126
-    case OPERATION_MODE_NEWUNLINKED:
127
-        $redirectDestination = "../overview_federation.php?";
128
-        if (count($validAddresses) == 0) {
129
-            header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
130
-            exit(1);
131
-        }
132
-        // run an input check and conversion of the raw inputs... just in case
133
-        $newinstname = $validator->string($_POST['name']);
134
-        $newcountry = $validator->string($_POST['country']);
135
-        $participant_type = $validator->partType($_POST['participant_type']);
136
-        $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($newcountry);
137
-        if ($new_idp_authorized_fedadmin !== TRUE) {
138
-            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureParticipant . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
139
-        }
140
-        $federation = $validator->existingFederation($newcountry);
141
-        $prettyprintname = $newinstname;
142
-        $introtext = "NEW-FED";
143
-        // send the user back to his federation overview page, append the result of the operation later
144
-        // do the token creation magic
145
-        $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $newinstname, 0, $newcountry, $participant_type);
146
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "ORG FUTURE  - Token created for $participant_type " . implode(",", $validAddresses));
147
-        break;
148
-    case OPERATION_MODE_NEWFROMDB:
149
-        $redirectDestination = "../overview_federation.php?";
150
-        if (count($validAddresses) == 0) {
151
-            header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
152
-            exit(1);
153
-        }
154
-        // a real external DB entry was submitted and all the required parameters are there
155
-        $newexternalid = $validator->string($_POST['externals']);
156
-        $extinfo = $catInstance->getExternalDBEntityDetails($newexternalid);
157
-        $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($extinfo['country']);
158
-        if ($new_idp_authorized_fedadmin !== TRUE) {
159
-            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureParticipant . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
160
-        }
161
-        $federation = $validator->existingFederation($extinfo['country']);
162
-        $newcountry = $extinfo['country'];
163
-        // see if the inst name is defined in the currently set language; if not, pick its English name; if N/A, pick the last in the list
164
-        $prettyprintname = "";
165
-        foreach ($extinfo['names'] as $lang => $name) {
166
-            if ($lang == $languageInstance->getLang()) {
167
-                $prettyprintname = $name;
120
+            $prettyprintname = $idp->name;
121
+            $newtokens = $mgmt->createTokens($fedadmin, $validAddresses, $idp);
122
+            $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP " . $idp->identifier . " - Token created for " . implode(",", $validAddresses));
123
+            $introtext = "CO-ADMIN";
124
+            $participant_type = $idp->type;
125
+            break;
126
+        case OPERATION_MODE_NEWUNLINKED:
127
+            $redirectDestination = "../overview_federation.php?";
128
+            if (count($validAddresses) == 0) {
129
+                header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
130
+                exit(1);
168 131
             }
169
-        }
170
-        if ($prettyprintname == "" && isset($extinfo['names']['en'])) {
171
-            $prettyprintname = $extinfo['names']['en'];
172
-        }
173
-        if ($prettyprintname == "") {
174
-            foreach ($extinfo['names'] as $name) {
175
-                $prettyprintname = $name;
132
+            // run an input check and conversion of the raw inputs... just in case
133
+            $newinstname = $validator->string($_POST['name']);
134
+            $newcountry = $validator->string($_POST['country']);
135
+            $participant_type = $validator->partType($_POST['participant_type']);
136
+            $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($newcountry);
137
+            if ($new_idp_authorized_fedadmin !== TRUE) {
138
+                throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureParticipant . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
176 139
             }
177
-        }
178
-        $participant_type = $extinfo['type'];
179
-        // fill the rest of the text
180
-        $introtext = "EXISTING-FED";
181
-        // do the token creation magic
182
-        $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $prettyprintname, $newexternalid);
183
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP FUTURE  - Token created for " . implode(",", $validAddresses));
184
-        break;
185
-    default: // includes OPERATION_MODE_INVALID
186
-        // second param is TRUE, so the variable *will* contain a string
187
-        // i.e. ignore Scrutinizer type warning later
188
-        $wrongcontent = print_r($_POST, TRUE);
189
-        echo "<pre>Wrong parameters in POST:
140
+            $federation = $validator->existingFederation($newcountry);
141
+            $prettyprintname = $newinstname;
142
+            $introtext = "NEW-FED";
143
+            // send the user back to his federation overview page, append the result of the operation later
144
+            // do the token creation magic
145
+            $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $newinstname, 0, $newcountry, $participant_type);
146
+            $loggerInstance->writeAudit($_SESSION['user'], "NEW", "ORG FUTURE  - Token created for $participant_type " . implode(",", $validAddresses));
147
+            break;
148
+        case OPERATION_MODE_NEWFROMDB:
149
+            $redirectDestination = "../overview_federation.php?";
150
+            if (count($validAddresses) == 0) {
151
+                header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
152
+                exit(1);
153
+            }
154
+            // a real external DB entry was submitted and all the required parameters are there
155
+            $newexternalid = $validator->string($_POST['externals']);
156
+            $extinfo = $catInstance->getExternalDBEntityDetails($newexternalid);
157
+            $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($extinfo['country']);
158
+            if ($new_idp_authorized_fedadmin !== TRUE) {
159
+                throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureParticipant . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
160
+            }
161
+            $federation = $validator->existingFederation($extinfo['country']);
162
+            $newcountry = $extinfo['country'];
163
+            // see if the inst name is defined in the currently set language; if not, pick its English name; if N/A, pick the last in the list
164
+            $prettyprintname = "";
165
+            foreach ($extinfo['names'] as $lang => $name) {
166
+                if ($lang == $languageInstance->getLang()) {
167
+                    $prettyprintname = $name;
168
+                }
169
+            }
170
+            if ($prettyprintname == "" && isset($extinfo['names']['en'])) {
171
+                $prettyprintname = $extinfo['names']['en'];
172
+            }
173
+            if ($prettyprintname == "") {
174
+                foreach ($extinfo['names'] as $name) {
175
+                    $prettyprintname = $name;
176
+                }
177
+            }
178
+            $participant_type = $extinfo['type'];
179
+            // fill the rest of the text
180
+            $introtext = "EXISTING-FED";
181
+            // do the token creation magic
182
+            $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $prettyprintname, $newexternalid);
183
+            $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP FUTURE  - Token created for " . implode(",", $validAddresses));
184
+            break;
185
+        default: // includes OPERATION_MODE_INVALID
186
+            // second param is TRUE, so the variable *will* contain a string
187
+            // i.e. ignore Scrutinizer type warning later
188
+            $wrongcontent = print_r($_POST, TRUE);
189
+            echo "<pre>Wrong parameters in POST:
190 190
 " . htmlspecialchars(/** @scrutinizer ignore-type */ $wrongcontent) . "
191 191
 </pre>";
192
-        exit(1);
192
+            exit(1);
193 193
 }
194 194
 
195 195
 // send, and invalidate the token immediately if the mail could not be sent!
Please login to merge, or discard this patch.
web/admin/edit_hotspot.php 1 patch
Switch Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -156,12 +156,12 @@
 block discarded – undo
156 156
     }
157 157
     if (isset($_POST['command'])) {
158 158
         switch ($_POST['command']) {
159
-        case web\lib\common\FormElements::BUTTON_CLOSE:
160
-            header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
161
-            exit(0);
162
-        default:
163
-            header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
164
-            exit(0);
159
+            case web\lib\common\FormElements::BUTTON_CLOSE:
160
+                header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
161
+                exit(0);
162
+            default:
163
+                header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
164
+                exit(0);
165 165
         }
166 166
     }
167 167
     $vlan = $deployment->getAttributes("managedsp:vlan")[0]['value'] ?? NULL;
Please login to merge, or discard this patch.
web/admin/API.php 1 patch
Switch Indentation   +383 added lines, -383 removed lines patch added patch discarded remove patch
@@ -84,231 +84,231 @@  discard block
 block discarded – undo
84 84
 }
85 85
 
86 86
 switch ($inputDecoded['ACTION']) {
87
-    case web\lib\admin\API::ACTION_NEWINST:
88
-        // create the inst, no admin, no attributes
89
-        $typeRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_INSTTYPE);
90
-        if ($typeRaw === FALSE) {
91
-            throw new Exception("We did not receive a valid participant type!");
92
-        }
93
-        $type = $validator->partType($typeRaw);
94
-        $idp = new \core\IdP($fed->newIdP($type, "PENDING", "API"));
95
-        // now add all submitted attributes
96
-        $inputs = $adminApi->uglify($scrubbedParameters);
97
-        $optionParser->processSubmittedFields($idp, $inputs["POST"], $inputs["FILES"]);
98
-        $adminApi->returnSuccess([web\lib\admin\API::AUXATTRIB_CAT_INST_ID => $idp->identifier]);
99
-        break;
100
-    case web\lib\admin\API::ACTION_DELINST:
101
-        try {
102
-            $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
103
-        } catch (Exception $e) {
104
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
105
-            exit(1);
106
-        }
107
-        $idp->destroy();
108
-        $adminApi->returnSuccess([]);
109
-        break;
110
-    case web\lib\admin\API::ACTION_ADMIN_LIST:
111
-        try {
112
-            $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
113
-        } catch (Exception $e) {
114
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
115
-            exit(1);
116
-        }
117
-        $adminApi->returnSuccess($idp->listOwners());
118
-        break;
119
-    case web\lib\admin\API::ACTION_ADMIN_ADD:
120
-        // IdP in question
121
-        try {
122
-            $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
123
-        } catch (Exception $e) {
124
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
125
-            exit(1);
126
-        }
127
-        // here is the token
128
-        $mgmt = new core\UserManagement();
129
-        // we know we have an admin ID but scrutinizer wants this checked more explicitly
130
-        $admin = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_ADMINID);
131
-        if ($admin === FALSE) {
132
-            throw new Exception("A required parameter is missing, and this wasn't caught earlier?!");
133
-        }
134
-        $newtokens = $mgmt->createTokens(true, [$admin], $idp);
135
-        $URL = "https://" . $_SERVER['SERVER_NAME'] . dirname($_SERVER['SCRIPT_NAME']) . "/action_enrollment.php?token=" . array_keys($newtokens)[0];
136
-        $success = ["TOKEN URL" => $URL, "TOKEN" => array_keys($newtokens)[0]];
137
-        // done with the essentials - display in response. But if we also have an email address, send it there
138
-        $email = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_TARGETMAIL);
139
-        if ($email !== FALSE) {
140
-            $sent = \core\common\OutsideComm::adminInvitationMail($email, "EXISTING-FED", array_keys($newtokens)[0], $idp->name, $fed, $idp->type);
141
-            $success["EMAIL SENT"] = $sent["SENT"];
142
-            if ($sent["SENT"] === TRUE) {
143
-                $success["EMAIL TRANSPORT SECURE"] = $sent["TRANSPORT"];
87
+        case web\lib\admin\API::ACTION_NEWINST:
88
+            // create the inst, no admin, no attributes
89
+            $typeRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_INSTTYPE);
90
+            if ($typeRaw === FALSE) {
91
+                throw new Exception("We did not receive a valid participant type!");
144 92
             }
145
-        }
146
-        $adminApi->returnSuccess($success);
147
-        break;
148
-    case web\lib\admin\API::ACTION_ADMIN_DEL:
149
-        // IdP in question
150
-        try {
151
-            $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
152
-        } catch (Exception $e) {
153
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
154
-            exit(1);
155
-        }
156
-        $currentAdmins = $idp->listOwners();
157
-        $toBeDeleted = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_ADMINID);
158
-        if ($toBeDeleted === FALSE) {
159
-            throw new Exception("A required parameter is missing, and this wasn't caught earlier?!");
160
-        }
161
-        $found = FALSE;
162
-        foreach ($currentAdmins as $oneAdmin) {
163
-            if ($oneAdmin['MAIL'] == $toBeDeleted) {
164
-                $found = TRUE;
165
-                $mgmt = new core\UserManagement();
166
-                $mgmt->removeAdminFromIdP($idp, $oneAdmin['ID']);
93
+            $type = $validator->partType($typeRaw);
94
+            $idp = new \core\IdP($fed->newIdP($type, "PENDING", "API"));
95
+            // now add all submitted attributes
96
+            $inputs = $adminApi->uglify($scrubbedParameters);
97
+            $optionParser->processSubmittedFields($idp, $inputs["POST"], $inputs["FILES"]);
98
+            $adminApi->returnSuccess([web\lib\admin\API::AUXATTRIB_CAT_INST_ID => $idp->identifier]);
99
+            break;
100
+        case web\lib\admin\API::ACTION_DELINST:
101
+            try {
102
+                $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
103
+            } catch (Exception $e) {
104
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
105
+                exit(1);
167 106
             }
168
-        }
169
-        if ($found) {
107
+            $idp->destroy();
170 108
             $adminApi->returnSuccess([]);
171
-        }
172
-        $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "The admin with ID $toBeDeleted is not associated to IdP " . $idp->identifier);
173
-        break;
174
-    case web\lib\admin\API::ACTION_STATISTICS_FED:
175
-        $adminApi->returnSuccess($fed->downloadStats("array"));
176
-        break;
177
-    case \web\lib\admin\API::ACTION_FEDERATION_LISTIDP:
178
-        $retArray = [];
179
-        $idpIdentifier = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID);
180
-        if ($idpIdentifier === FALSE) {
181
-            $allIdPs = $fed->listIdentityProviders(0);
182
-            foreach ($allIdPs as $instanceId => $oneIdP) {
183
-                $theIdP = $oneIdP["instance"];
184
-                $retArray[$instanceId] = $theIdP->getAttributes();
185
-            }
186
-        } else {
109
+            break;
110
+        case web\lib\admin\API::ACTION_ADMIN_LIST:
187 111
             try {
188
-                $thisIdP = $validator->existingIdP($idpIdentifier, NULL, $fed);
112
+                $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
189 113
             } catch (Exception $e) {
190 114
                 $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
191 115
                 exit(1);
192 116
             }
193
-            $retArray[$idpIdentifier] = $thisIdP->getAttributes();
194
-            foreach ($thisIdP->listProfiles() as $oneProfile) {
195
-                $retArray[$idpIdentifier]["PROFILES"][$oneProfile->identifier] = $oneProfile->getAttributes();
117
+            $adminApi->returnSuccess($idp->listOwners());
118
+            break;
119
+        case web\lib\admin\API::ACTION_ADMIN_ADD:
120
+            // IdP in question
121
+            try {
122
+                $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
123
+            } catch (Exception $e) {
124
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
125
+                exit(1);
196 126
             }
197
-        }
198
-        foreach ($retArray as $instNumber => $oneInstData) {
199
-            foreach ($oneInstData as $attribNumber => $oneAttrib) {
200
-                if ($oneAttrib['name'] == "general:logo_file") {
201
-                    // JSON doesn't cope well with raw binary data, so b64 it
202
-                    $retArray[$instNumber][$attribNumber]['value'] = base64_encode($oneAttrib['value']);
127
+            // here is the token
128
+            $mgmt = new core\UserManagement();
129
+            // we know we have an admin ID but scrutinizer wants this checked more explicitly
130
+            $admin = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_ADMINID);
131
+            if ($admin === FALSE) {
132
+                throw new Exception("A required parameter is missing, and this wasn't caught earlier?!");
133
+            }
134
+            $newtokens = $mgmt->createTokens(true, [$admin], $idp);
135
+            $URL = "https://" . $_SERVER['SERVER_NAME'] . dirname($_SERVER['SCRIPT_NAME']) . "/action_enrollment.php?token=" . array_keys($newtokens)[0];
136
+            $success = ["TOKEN URL" => $URL, "TOKEN" => array_keys($newtokens)[0]];
137
+            // done with the essentials - display in response. But if we also have an email address, send it there
138
+            $email = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_TARGETMAIL);
139
+            if ($email !== FALSE) {
140
+                $sent = \core\common\OutsideComm::adminInvitationMail($email, "EXISTING-FED", array_keys($newtokens)[0], $idp->name, $fed, $idp->type);
141
+                $success["EMAIL SENT"] = $sent["SENT"];
142
+                if ($sent["SENT"] === TRUE) {
143
+                    $success["EMAIL TRANSPORT SECURE"] = $sent["TRANSPORT"];
144
+                }
145
+            }
146
+            $adminApi->returnSuccess($success);
147
+            break;
148
+        case web\lib\admin\API::ACTION_ADMIN_DEL:
149
+            // IdP in question
150
+            try {
151
+                $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
152
+            } catch (Exception $e) {
153
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
154
+                exit(1);
155
+            }
156
+            $currentAdmins = $idp->listOwners();
157
+            $toBeDeleted = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_ADMINID);
158
+            if ($toBeDeleted === FALSE) {
159
+                throw new Exception("A required parameter is missing, and this wasn't caught earlier?!");
160
+            }
161
+            $found = FALSE;
162
+            foreach ($currentAdmins as $oneAdmin) {
163
+                if ($oneAdmin['MAIL'] == $toBeDeleted) {
164
+                    $found = TRUE;
165
+                    $mgmt = new core\UserManagement();
166
+                    $mgmt->removeAdminFromIdP($idp, $oneAdmin['ID']);
167
+                }
168
+            }
169
+            if ($found) {
170
+                $adminApi->returnSuccess([]);
171
+            }
172
+            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "The admin with ID $toBeDeleted is not associated to IdP " . $idp->identifier);
173
+            break;
174
+        case web\lib\admin\API::ACTION_STATISTICS_FED:
175
+            $adminApi->returnSuccess($fed->downloadStats("array"));
176
+            break;
177
+        case \web\lib\admin\API::ACTION_FEDERATION_LISTIDP:
178
+            $retArray = [];
179
+            $idpIdentifier = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID);
180
+            if ($idpIdentifier === FALSE) {
181
+                $allIdPs = $fed->listIdentityProviders(0);
182
+                foreach ($allIdPs as $instanceId => $oneIdP) {
183
+                    $theIdP = $oneIdP["instance"];
184
+                    $retArray[$instanceId] = $theIdP->getAttributes();
185
+                }
186
+            } else {
187
+                try {
188
+                    $thisIdP = $validator->existingIdP($idpIdentifier, NULL, $fed);
189
+                } catch (Exception $e) {
190
+                    $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
191
+                    exit(1);
192
+                }
193
+                $retArray[$idpIdentifier] = $thisIdP->getAttributes();
194
+                foreach ($thisIdP->listProfiles() as $oneProfile) {
195
+                    $retArray[$idpIdentifier]["PROFILES"][$oneProfile->identifier] = $oneProfile->getAttributes();
203 196
                 }
204
-                if ($attribNumber == "PROFILES") {
205
-                    // scan for included fed:logo_file and b64 escape it, t2oo
206
-                    foreach ($oneAttrib as $profileNumber => $profileContent) {
207
-                            foreach ($profileContent as $oneProfileIterator => $oneProfileContent) {
208
-                                    if ($oneProfileContent['name'] == "fed:logo_file" || $oneProfileContent['name'] == "general:logo_file" || $oneProfileContent['name'] == "eap:ca_file") {
209
-                                            $retArray[$instNumber]["PROFILES"][$profileNumber][$oneProfileIterator]['value'] = base64_encode($oneProfileContent['value']);
210
-                                    }
211
-                            }
197
+            }
198
+            foreach ($retArray as $instNumber => $oneInstData) {
199
+                foreach ($oneInstData as $attribNumber => $oneAttrib) {
200
+                    if ($oneAttrib['name'] == "general:logo_file") {
201
+                        // JSON doesn't cope well with raw binary data, so b64 it
202
+                        $retArray[$instNumber][$attribNumber]['value'] = base64_encode($oneAttrib['value']);
203
+                    }
204
+                    if ($attribNumber == "PROFILES") {
205
+                        // scan for included fed:logo_file and b64 escape it, t2oo
206
+                        foreach ($oneAttrib as $profileNumber => $profileContent) {
207
+                                foreach ($profileContent as $oneProfileIterator => $oneProfileContent) {
208
+                                        if ($oneProfileContent['name'] == "fed:logo_file" || $oneProfileContent['name'] == "general:logo_file" || $oneProfileContent['name'] == "eap:ca_file") {
209
+                                                $retArray[$instNumber]["PROFILES"][$profileNumber][$oneProfileIterator]['value'] = base64_encode($oneProfileContent['value']);
210
+                                        }
211
+                                }
212
+                        }
212 213
                     }
213 214
                 }
214 215
             }
215
-        }
216
-        $adminApi->returnSuccess($retArray);
217
-        break;
218
-    case \web\lib\admin\API::ACTION_NEWPROF_RADIUS:
219
-    // fall-through intended: both get mostly identical treatment
220
-    case web\lib\admin\API::ACTION_NEWPROF_SB:
221
-        try {
222
-            $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
223
-        } catch (Exception $e) {
224
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
225
-            exit(1);
226
-        }
227
-        if ($inputDecoded['ACTION'] == web\lib\admin\API::ACTION_NEWPROF_RADIUS) {
228
-            $type = "RADIUS";
229
-        } else {
230
-            $type = "SILVERBULLET";
231
-        }
232
-        $profile = $idp->newProfile($type);
233
-        if ($profile === NULL) {
234
-            $adminApi->returnError(\web\lib\admin\API::ERROR_INTERNAL_ERROR, "Unable to create a new Profile, for no apparent reason. Please contact support.");
235
-            exit(1);
236
-        }
237
-        $inputs = $adminApi->uglify($scrubbedParameters);
238
-        $optionParser->processSubmittedFields($profile, $inputs["POST"], $inputs["FILES"]);
239
-        if ($inputDecoded['ACTION'] == web\lib\admin\API::ACTION_NEWPROF_SB) {
240
-            // auto-accept ToU?
241
-            if ($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_TOU) !== FALSE) {
242
-                $profile->addAttribute("hiddenprofile:tou_accepted", NULL, 1);
243
-            }
244
-            // we're done at this point
245
-            $adminApi->returnSuccess([\web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID => $profile->identifier]);
216
+            $adminApi->returnSuccess($retArray);
246 217
             break;
247
-        }
248
-        if (!$profile instanceof core\ProfileRADIUS) {
249
-            throw new Exception("Can't be. This is only here to convince Scrutinizer that we're really talking RADIUS.");
250
-        }
251
-        /* const AUXATTRIB_PROFILE_REALM = 'ATTRIB-PROFILE-REALM';
252
-          const AUXATTRIB_PROFILE_OUTERVALUE = 'ATTRIB-PROFILE-OUTERVALUE'; */
253
-        $realm = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_REALM);
254
-        $outer = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_OUTERVALUE);
255
-        if ($realm !== FALSE) {
256
-            if ($outer === FALSE) {
257
-                $outer = "";
258
-                $profile->setAnonymousIDSupport(FALSE);
218
+        case \web\lib\admin\API::ACTION_NEWPROF_RADIUS:
219
+        // fall-through intended: both get mostly identical treatment
220
+        case web\lib\admin\API::ACTION_NEWPROF_SB:
221
+            try {
222
+                $idp = $validator->existingIdP($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_INST_ID), NULL, $fed);
223
+            } catch (Exception $e) {
224
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "IdP identifier does not exist!");
225
+                exit(1);
226
+            }
227
+            if ($inputDecoded['ACTION'] == web\lib\admin\API::ACTION_NEWPROF_RADIUS) {
228
+                $type = "RADIUS";
259 229
             } else {
260
-                $outer = $outer . "@";
261
-                $profile->setAnonymousIDSupport(TRUE);
230
+                $type = "SILVERBULLET";
262 231
             }
263
-            $profile->setRealm($outer . $realm);
264
-        }
265
-        /* const AUXATTRIB_PROFILE_TESTUSER = 'ATTRIB-PROFILE-TESTUSER'; */
266
-        $testuser = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_TESTUSER);
267
-        if ($testuser !== FALSE) {
268
-            $profile->setRealmCheckUser(TRUE, $testuser);
269
-        }
270
-        /* const AUXATTRIB_PROFILE_INPUT_HINT = 'ATTRIB-PROFILE-HINTREALM';
232
+            $profile = $idp->newProfile($type);
233
+            if ($profile === NULL) {
234
+                $adminApi->returnError(\web\lib\admin\API::ERROR_INTERNAL_ERROR, "Unable to create a new Profile, for no apparent reason. Please contact support.");
235
+                exit(1);
236
+            }
237
+            $inputs = $adminApi->uglify($scrubbedParameters);
238
+            $optionParser->processSubmittedFields($profile, $inputs["POST"], $inputs["FILES"]);
239
+            if ($inputDecoded['ACTION'] == web\lib\admin\API::ACTION_NEWPROF_SB) {
240
+                // auto-accept ToU?
241
+                if ($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_TOU) !== FALSE) {
242
+                    $profile->addAttribute("hiddenprofile:tou_accepted", NULL, 1);
243
+                }
244
+                // we're done at this point
245
+                $adminApi->returnSuccess([\web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID => $profile->identifier]);
246
+                break;
247
+            }
248
+            if (!$profile instanceof core\ProfileRADIUS) {
249
+                throw new Exception("Can't be. This is only here to convince Scrutinizer that we're really talking RADIUS.");
250
+            }
251
+            /* const AUXATTRIB_PROFILE_REALM = 'ATTRIB-PROFILE-REALM';
252
+          const AUXATTRIB_PROFILE_OUTERVALUE = 'ATTRIB-PROFILE-OUTERVALUE'; */
253
+            $realm = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_REALM);
254
+            $outer = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_OUTERVALUE);
255
+            if ($realm !== FALSE) {
256
+                if ($outer === FALSE) {
257
+                    $outer = "";
258
+                    $profile->setAnonymousIDSupport(FALSE);
259
+                } else {
260
+                    $outer = $outer . "@";
261
+                    $profile->setAnonymousIDSupport(TRUE);
262
+                }
263
+                $profile->setRealm($outer . $realm);
264
+            }
265
+            /* const AUXATTRIB_PROFILE_TESTUSER = 'ATTRIB-PROFILE-TESTUSER'; */
266
+            $testuser = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_TESTUSER);
267
+            if ($testuser !== FALSE) {
268
+                $profile->setRealmCheckUser(TRUE, $testuser);
269
+            }
270
+            /* const AUXATTRIB_PROFILE_INPUT_HINT = 'ATTRIB-PROFILE-HINTREALM';
271 271
           const AUXATTRIB_PROFILE_INPUT_VERIFY = 'ATTRIB-PROFILE-VERIFYREALM'; */
272
-        $hint = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_INPUT_HINT);
273
-        $enforce = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_INPUT_VERIFY);
274
-        if ($enforce !== FALSE) {
275
-            $profile->setInputVerificationPreference($enforce, $hint);
276
-        }
277
-        /* const AUXATTRIB_PROFILE_EAPTYPE */
278
-        $iterator = 1;
279
-        foreach ($scrubbedParameters as $oneParam) {
280
-            if ($oneParam['NAME'] == web\lib\admin\API::AUXATTRIB_PROFILE_EAPTYPE && is_int($oneParam["VALUE"])) {
281
-                $type = new \core\common\EAP($oneParam["VALUE"]);
282
-                $profile->addSupportedEapMethod($type, $iterator);
283
-                $iterator = $iterator + 1;
272
+            $hint = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_INPUT_HINT);
273
+            $enforce = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_PROFILE_INPUT_VERIFY);
274
+            if ($enforce !== FALSE) {
275
+                $profile->setInputVerificationPreference($enforce, $hint);
284 276
             }
285
-        }
286
-        // reinstantiate $profile freshly from DB - it was updated in the process
287
-        $profileFresh = new core\ProfileRADIUS($profile->identifier);
288
-        $profileFresh->prepShowtime();
289
-        $adminApi->returnSuccess([\web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID => $profileFresh->identifier]);
290
-        break;
291
-    case web\lib\admin\API::ACTION_ENDUSER_NEW:
292
-    // fall-through intentional, those two actions are doing nearly identical things
293
-    case web\lib\admin\API::ACTION_ENDUSER_CHANGEEXPIRY:
294
-        $prof_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
295
-        if ($prof_id === FALSE) {
296
-            exit(1);
297
-        }
298
-        $evaluation = $adminApi->commonSbProfileChecks($fed, $prof_id);
299
-        if ($evaluation === FALSE) {
300
-            exit(1);
301
-        }
302
-        list($idp, $profile) = $evaluation;
303
-        $user = $validator->string($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERNAME));
304
-        $expiryRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_EXPIRY);
305
-        if ($expiryRaw === FALSE) {
306
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "The expiry date wasn't found in the request.");
277
+            /* const AUXATTRIB_PROFILE_EAPTYPE */
278
+            $iterator = 1;
279
+            foreach ($scrubbedParameters as $oneParam) {
280
+                if ($oneParam['NAME'] == web\lib\admin\API::AUXATTRIB_PROFILE_EAPTYPE && is_int($oneParam["VALUE"])) {
281
+                    $type = new \core\common\EAP($oneParam["VALUE"]);
282
+                    $profile->addSupportedEapMethod($type, $iterator);
283
+                    $iterator = $iterator + 1;
284
+                }
285
+            }
286
+            // reinstantiate $profile freshly from DB - it was updated in the process
287
+            $profileFresh = new core\ProfileRADIUS($profile->identifier);
288
+            $profileFresh->prepShowtime();
289
+            $adminApi->returnSuccess([\web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID => $profileFresh->identifier]);
307 290
             break;
308
-        }
309
-        $expiry = new DateTime($expiryRaw);
310
-        try {
311
-            switch ($inputDecoded['ACTION']) {
291
+        case web\lib\admin\API::ACTION_ENDUSER_NEW:
292
+        // fall-through intentional, those two actions are doing nearly identical things
293
+        case web\lib\admin\API::ACTION_ENDUSER_CHANGEEXPIRY:
294
+            $prof_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
295
+            if ($prof_id === FALSE) {
296
+                exit(1);
297
+            }
298
+            $evaluation = $adminApi->commonSbProfileChecks($fed, $prof_id);
299
+            if ($evaluation === FALSE) {
300
+                exit(1);
301
+            }
302
+            list($idp, $profile) = $evaluation;
303
+            $user = $validator->string($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERNAME));
304
+            $expiryRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_EXPIRY);
305
+            if ($expiryRaw === FALSE) {
306
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "The expiry date wasn't found in the request.");
307
+                break;
308
+            }
309
+            $expiry = new DateTime($expiryRaw);
310
+            try {
311
+                switch ($inputDecoded['ACTION']) {
312 312
                 case web\lib\admin\API::ACTION_ENDUSER_NEW:
313 313
                     $retval = $profile->addUser($user, $expiry);
314 314
                     break;
@@ -321,7 +321,7 @@  discard block
 block discarded – undo
321 321
                         $retval = 1; // function doesn't have any failure vectors not raising an Exception and doesn't return a value
322 322
                     }
323 323
                     break;
324
-            }
324
+                }
325 325
         } catch (Exception $e) {
326 326
             $adminApi->returnError(web\lib\admin\API::ERROR_INTERNAL_ERROR, "The operation failed. Maybe a duplicate username, or malformed expiry date?");
327 327
             exit(1);
@@ -332,25 +332,25 @@  discard block
 block discarded – undo
332 332
         }
333 333
         $adminApi->returnSuccess([web\lib\admin\API::AUXATTRIB_SB_USERNAME => $user, \web\lib\admin\API::AUXATTRIB_SB_USERID => $retval]);
334 334
         break;
335
-    case \web\lib\admin\API::ACTION_ENDUSER_DEACTIVATE:
336
-    // fall-through intended: both actions are very similar
337
-    case \web\lib\admin\API::ACTION_TOKEN_NEW:
338
-        $profile_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
339
-        if ($profile_id === FALSE) {
340
-            exit(1);
341
-        }
342
-        $evaluation = $adminApi->commonSbProfileChecks($fed, $profile_id);
343
-        if ($evaluation === FALSE) {
344
-            exit(1);
345
-        }
346
-        list($idp, $profile) = $evaluation;
347
-        $userId = $validator->integer($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERID));
348
-        if ($userId === FALSE) {
349
-            $adminApi->returnError(\web\lib\admin\API::ERROR_INVALID_PARAMETER, "User ID is not an integer.");
350
-            exit(1);
351
-        }
352
-        $additionalInfo = [];
353
-        switch ($inputDecoded['ACTION']) { // this is where the two differ
335
+        case \web\lib\admin\API::ACTION_ENDUSER_DEACTIVATE:
336
+        // fall-through intended: both actions are very similar
337
+        case \web\lib\admin\API::ACTION_TOKEN_NEW:
338
+            $profile_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
339
+            if ($profile_id === FALSE) {
340
+                exit(1);
341
+            }
342
+            $evaluation = $adminApi->commonSbProfileChecks($fed, $profile_id);
343
+            if ($evaluation === FALSE) {
344
+                exit(1);
345
+            }
346
+            list($idp, $profile) = $evaluation;
347
+            $userId = $validator->integer($adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERID));
348
+            if ($userId === FALSE) {
349
+                $adminApi->returnError(\web\lib\admin\API::ERROR_INVALID_PARAMETER, "User ID is not an integer.");
350
+                exit(1);
351
+            }
352
+            $additionalInfo = [];
353
+            switch ($inputDecoded['ACTION']) { // this is where the two differ
354 354
             case \web\lib\admin\API::ACTION_ENDUSER_DEACTIVATE:
355 355
                 $result = $profile->deactivateUser($userId);
356 356
                 break;
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
                     }
384 384
                 }
385 385
                 break;
386
-        }
386
+            }
387 387
 
388 388
         if ($result !== TRUE) {
389 389
             $adminApi->returnError(\web\lib\admin\API::ERROR_INVALID_PARAMETER, "These parameters did not lead to an existing, active user.");
@@ -391,69 +391,69 @@  discard block
 block discarded – undo
391 391
         }
392 392
         $adminApi->returnSuccess($additionalInfo);
393 393
         break;
394
-    case \web\lib\admin\API::ACTION_ENDUSER_IDENTIFY:
395
-        $profile_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
396
-        if ($profile_id === FALSE) {
397
-            exit(1);
398
-        }
399
-        $evaluation = $adminApi->commonSbProfileChecks($fed, $profile_id);
400
-        if ($evaluation === FALSE) {
401
-            exit(1);
402
-        }
403
-        list($idp, $profile) = $evaluation;
404
-        $userId = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERID);
405
-        $userName = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERNAME);
406
-        $certSerial = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTSERIAL);
407
-		$certCN = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTCN);
408
-        if ($userId === FALSE && $userName === FALSE && $certSerial === FALSE && $certCN === FALSE) {
409
-            // we need at least one of those
410
-            $adminApi->returnError(\web\lib\admin\API::ERROR_MISSING_PARAMETER, "At least one of User ID, Username, certificate serial, or certificate CN is required.");
411
-            break;
412
-        }
413
-        if ($certSerial !== FALSE) { // we got a cert serial
414
-            $serial = explode(":", $certSerial);
415
-            $cert = new \core\SilverbulletCertificate($serial[1], $serial[0]);
394
+        case \web\lib\admin\API::ACTION_ENDUSER_IDENTIFY:
395
+            $profile_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
396
+            if ($profile_id === FALSE) {
397
+                exit(1);
416 398
             }
417
-        if ($certCN !== FALSE) { // we got a cert CN
418
-            $cert = new \core\SilverbulletCertificate($certCN);
419
-        }
420
-        if ($cert !== NULL) { // we found a cert; verify it and extract userId
421
-            if ($cert->status == \core\SilverbulletCertificate::CERTSTATUS_INVALID) {
422
-                return $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Certificate not found.");
399
+            $evaluation = $adminApi->commonSbProfileChecks($fed, $profile_id);
400
+            if ($evaluation === FALSE) {
401
+                exit(1);
423 402
             }
424
-            if ($cert->profileId != $profile->identifier) {
425
-                return $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Certificate does not belong to this profile.");
403
+            list($idp, $profile) = $evaluation;
404
+            $userId = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERID);
405
+            $userName = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERNAME);
406
+            $certSerial = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTSERIAL);
407
+		    $certCN = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTCN);
408
+            if ($userId === FALSE && $userName === FALSE && $certSerial === FALSE && $certCN === FALSE) {
409
+                // we need at least one of those
410
+                $adminApi->returnError(\web\lib\admin\API::ERROR_MISSING_PARAMETER, "At least one of User ID, Username, certificate serial, or certificate CN is required.");
411
+                break;
426 412
             }
427
-            $userId = $cert->userId;
428
-        }
429
-        if ($userId !== FALSE) {
430
-            $userList = $profile->getUserById($userId);
431
-        }
432
-        if ($userName !== FALSE) {
433
-            $userList = $profile->getUserByName($userName);
434
-        }
435
-        if (count($userList) === 1) {
436
-            foreach ($userList as $oneUserId => $oneUserName) {
437
-                return $adminApi->returnSuccess([web\lib\admin\API::AUXATTRIB_SB_USERNAME => $oneUserName, \web\lib\admin\API::AUXATTRIB_SB_USERID => $oneUserId]);
413
+            if ($certSerial !== FALSE) { // we got a cert serial
414
+                $serial = explode(":", $certSerial);
415
+                $cert = new \core\SilverbulletCertificate($serial[1], $serial[0]);
416
+                }
417
+            if ($certCN !== FALSE) { // we got a cert CN
418
+                $cert = new \core\SilverbulletCertificate($certCN);
438 419
             }
439
-        }
440
-        $adminApi->returnError(\web\lib\admin\API::ERROR_INVALID_PARAMETER, "No matching user found in this profile.");
441
-        break;
442
-    case \web\lib\admin\API::ACTION_ENDUSER_LIST:
443
-    // fall-through: those two are similar
444
-    case \web\lib\admin\API::ACTION_TOKEN_LIST:
445
-        $profile_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
446
-        if ($profile_id === FALSE) {
447
-            exit(1);
448
-        }
449
-        $evaluation = $adminApi->commonSbProfileChecks($fed, $profile_id);
450
-        if ($evaluation === FALSE) {
451
-            exit(1);
452
-        }
453
-        list($idp, $profile) = $evaluation;
454
-        $allUsers = $profile->listAllUsers();
455
-        // this is where they differ
456
-        switch ($inputDecoded['ACTION']) {
420
+            if ($cert !== NULL) { // we found a cert; verify it and extract userId
421
+                if ($cert->status == \core\SilverbulletCertificate::CERTSTATUS_INVALID) {
422
+                    return $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Certificate not found.");
423
+                }
424
+                if ($cert->profileId != $profile->identifier) {
425
+                    return $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Certificate does not belong to this profile.");
426
+                }
427
+                $userId = $cert->userId;
428
+            }
429
+            if ($userId !== FALSE) {
430
+                $userList = $profile->getUserById($userId);
431
+            }
432
+            if ($userName !== FALSE) {
433
+                $userList = $profile->getUserByName($userName);
434
+            }
435
+            if (count($userList) === 1) {
436
+                foreach ($userList as $oneUserId => $oneUserName) {
437
+                    return $adminApi->returnSuccess([web\lib\admin\API::AUXATTRIB_SB_USERNAME => $oneUserName, \web\lib\admin\API::AUXATTRIB_SB_USERID => $oneUserId]);
438
+                }
439
+            }
440
+            $adminApi->returnError(\web\lib\admin\API::ERROR_INVALID_PARAMETER, "No matching user found in this profile.");
441
+            break;
442
+        case \web\lib\admin\API::ACTION_ENDUSER_LIST:
443
+        // fall-through: those two are similar
444
+        case \web\lib\admin\API::ACTION_TOKEN_LIST:
445
+            $profile_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
446
+            if ($profile_id === FALSE) {
447
+                exit(1);
448
+            }
449
+            $evaluation = $adminApi->commonSbProfileChecks($fed, $profile_id);
450
+            if ($evaluation === FALSE) {
451
+                exit(1);
452
+            }
453
+            list($idp, $profile) = $evaluation;
454
+            $allUsers = $profile->listAllUsers();
455
+            // this is where they differ
456
+            switch ($inputDecoded['ACTION']) {
457 457
             case \web\lib\admin\API::ACTION_ENDUSER_LIST:
458 458
                 $adminApi->returnSuccess($allUsers);
459 459
                 break;
@@ -472,105 +472,105 @@  discard block
 block discarded – undo
472 472
                     $infoSet[$oneTokenObject->userId] = [\web\lib\admin\API::AUXATTRIB_TOKEN => $oneTokenObject->invitationTokenString, "STATUS" => $oneTokenObject->invitationTokenStatus];
473 473
                 }
474 474
                 $adminApi->returnSuccess($infoSet);
475
-        }
476
-        break;
477
-    case \web\lib\admin\API::ACTION_TOKEN_REVOKE:
478
-        $tokenRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_TOKEN);
479
-        if ($tokenRaw === FALSE) {
480
-            exit(1);
481
-        }
482
-        $token = new core\SilverbulletInvitation($tokenRaw);
483
-        if ($token->invitationTokenStatus !== core\SilverbulletInvitation::SB_TOKENSTATUS_VALID && $token->invitationTokenStatus !== core\SilverbulletInvitation::SB_TOKENSTATUS_PARTIALLY_REDEEMED) {
484
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "This is not a currently valid token.");
485
-            exit(1);
486
-        }
487
-        $token->revokeInvitation();
488
-        $adminApi->returnSuccess([]);
489
-        break;
490
-    case \web\lib\admin\API::ACTION_CERT_LIST:
491
-        $prof_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
492
-        $user_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERID);
493
-        if ($prof_id === FALSE || !is_int($user_id)) {
494
-            exit(1);
495
-        }
496
-        $evaluation = $adminApi->commonSbProfileChecks($fed, $prof_id);
497
-        if ($evaluation === FALSE) {
498
-            exit(1);
499
-        }
500
-        list($idp, $profile) = $evaluation;
501
-        $invitations = $profile->userStatus($user_id);
502
-        // now pull out cert information from the object
503
-        $certs = [];
504
-        foreach ($invitations as $oneInvitation) {
505
-            $certs = array_merge($certs, $oneInvitation->associatedCertificates);
506
-        }
507
-        // extract relevant subset of information from cert objects
508
-        $certDetails = [];
509
-        foreach ($certs as $cert) {
510
-            $certDetails[$cert->ca_type . ":" . $cert->serial] = ["ISSUED" => $cert->issued, "EXPIRY" => $cert->expiry, "STATUS" => $cert->status, "DEVICE" => $cert->device, "CN" => $cert->username, "ANNOTATION" => $cert->annotation];
511
-        }
512
-        $adminApi->returnSuccess($certDetails);
513
-        break;
514
-    case \web\lib\admin\API::ACTION_CERT_REVOKE:
515
-        $prof_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
516
-        if ($prof_id === FALSE) {
517
-            exit(1);
518
-        }
519
-        $evaluation = $adminApi->commonSbProfileChecks($fed, $prof_id);
520
-        if ($evaluation === FALSE) {
521
-            exit(1);
522
-        }
523
-        list($idp, $profile) = $evaluation;
524
-        // tear apart the serial
525
-        $serialRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTSERIAL);
526
-        if ($serialRaw === FALSE) {
527
-            exit(1);
528
-        }
529
-        $serial = explode(":", $serialRaw);
530
-        $cert = new \core\SilverbulletCertificate($serial[1], $serial[0]);
531
-        if ($cert->status == \core\SilverbulletCertificate::CERTSTATUS_INVALID) {
532
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Serial not found.");
533
-        }
534
-        if ($cert->profileId != $profile->identifier) {
535
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Serial does not belong to this profile.");
536
-        }
537
-        $cert->revokeCertificate();
538
-        $adminApi->returnSuccess([]);
475
+            }
539 476
         break;
540
-    case \web\lib\admin\API::ACTION_CERT_ANNOTATE:
541
-        $prof_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
542
-        if ($prof_id === FALSE) {
543
-            exit(1);
544
-        }
545
-        $evaluation = $adminApi->commonSbProfileChecks($fed, $prof_id);
546
-        if ($evaluation === FALSE) {
547
-            exit(1);
548
-        }
549
-        list($idp, $profile) = $evaluation;
550
-        // tear apart the serial
551
-        $serialRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTSERIAL);
552
-        if ($serialRaw === FALSE) {
553
-            exit(1);
554
-        }
555
-        $serial = explode(":", $serialRaw);
556
-        $cert = new \core\SilverbulletCertificate($serial[1], $serial[0]);
557
-        if ($cert->status == \core\SilverbulletCertificate::CERTSTATUS_INVALID) {
558
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Serial not found.");
559
-        }
560
-        if ($cert->profileId != $profile->identifier) {
561
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Serial does not belong to this profile.");
562
-        }
563
-        $annotationRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTANNOTATION);
564
-        if ($annotationRaw === FALSE) {
565
-            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Unable to extract annotation.");
477
+        case \web\lib\admin\API::ACTION_TOKEN_REVOKE:
478
+            $tokenRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_TOKEN);
479
+            if ($tokenRaw === FALSE) {
480
+                exit(1);
481
+            }
482
+            $token = new core\SilverbulletInvitation($tokenRaw);
483
+            if ($token->invitationTokenStatus !== core\SilverbulletInvitation::SB_TOKENSTATUS_VALID && $token->invitationTokenStatus !== core\SilverbulletInvitation::SB_TOKENSTATUS_PARTIALLY_REDEEMED) {
484
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "This is not a currently valid token.");
485
+                exit(1);
486
+            }
487
+            $token->revokeInvitation();
488
+            $adminApi->returnSuccess([]);
566 489
             break;
567
-        }
568
-        $annotation = json_decode($annotationRaw, TRUE);
569
-        $cert->annotate($annotation);
570
-        $adminApi->returnSuccess([]);
490
+        case \web\lib\admin\API::ACTION_CERT_LIST:
491
+            $prof_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
492
+            $user_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_USERID);
493
+            if ($prof_id === FALSE || !is_int($user_id)) {
494
+                exit(1);
495
+            }
496
+            $evaluation = $adminApi->commonSbProfileChecks($fed, $prof_id);
497
+            if ($evaluation === FALSE) {
498
+                exit(1);
499
+            }
500
+            list($idp, $profile) = $evaluation;
501
+            $invitations = $profile->userStatus($user_id);
502
+            // now pull out cert information from the object
503
+            $certs = [];
504
+            foreach ($invitations as $oneInvitation) {
505
+                $certs = array_merge($certs, $oneInvitation->associatedCertificates);
506
+            }
507
+            // extract relevant subset of information from cert objects
508
+            $certDetails = [];
509
+            foreach ($certs as $cert) {
510
+                $certDetails[$cert->ca_type . ":" . $cert->serial] = ["ISSUED" => $cert->issued, "EXPIRY" => $cert->expiry, "STATUS" => $cert->status, "DEVICE" => $cert->device, "CN" => $cert->username, "ANNOTATION" => $cert->annotation];
511
+            }
512
+            $adminApi->returnSuccess($certDetails);
513
+            break;
514
+        case \web\lib\admin\API::ACTION_CERT_REVOKE:
515
+            $prof_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
516
+            if ($prof_id === FALSE) {
517
+                exit(1);
518
+            }
519
+            $evaluation = $adminApi->commonSbProfileChecks($fed, $prof_id);
520
+            if ($evaluation === FALSE) {
521
+                exit(1);
522
+            }
523
+            list($idp, $profile) = $evaluation;
524
+            // tear apart the serial
525
+            $serialRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTSERIAL);
526
+            if ($serialRaw === FALSE) {
527
+                exit(1);
528
+            }
529
+            $serial = explode(":", $serialRaw);
530
+            $cert = new \core\SilverbulletCertificate($serial[1], $serial[0]);
531
+            if ($cert->status == \core\SilverbulletCertificate::CERTSTATUS_INVALID) {
532
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Serial not found.");
533
+            }
534
+            if ($cert->profileId != $profile->identifier) {
535
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Serial does not belong to this profile.");
536
+            }
537
+            $cert->revokeCertificate();
538
+            $adminApi->returnSuccess([]);
539
+            break;
540
+        case \web\lib\admin\API::ACTION_CERT_ANNOTATE:
541
+            $prof_id = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_CAT_PROFILE_ID);
542
+            if ($prof_id === FALSE) {
543
+                exit(1);
544
+            }
545
+            $evaluation = $adminApi->commonSbProfileChecks($fed, $prof_id);
546
+            if ($evaluation === FALSE) {
547
+                exit(1);
548
+            }
549
+            list($idp, $profile) = $evaluation;
550
+            // tear apart the serial
551
+            $serialRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTSERIAL);
552
+            if ($serialRaw === FALSE) {
553
+                exit(1);
554
+            }
555
+            $serial = explode(":", $serialRaw);
556
+            $cert = new \core\SilverbulletCertificate($serial[1], $serial[0]);
557
+            if ($cert->status == \core\SilverbulletCertificate::CERTSTATUS_INVALID) {
558
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Serial not found.");
559
+            }
560
+            if ($cert->profileId != $profile->identifier) {
561
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Serial does not belong to this profile.");
562
+            }
563
+            $annotationRaw = $adminApi->firstParameterInstance($scrubbedParameters, web\lib\admin\API::AUXATTRIB_SB_CERTANNOTATION);
564
+            if ($annotationRaw === FALSE) {
565
+                $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_PARAMETER, "Unable to extract annotation.");
566
+                break;
567
+            }
568
+            $annotation = json_decode($annotationRaw, TRUE);
569
+            $cert->annotate($annotation);
570
+            $adminApi->returnSuccess([]);
571 571
 
572
-        break;
572
+            break;
573 573
 
574
-    default:
575
-        $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_ACTION, "Not implemented yet.");
574
+        default:
575
+            $adminApi->returnError(web\lib\admin\API::ERROR_INVALID_ACTION, "Not implemented yet.");
576 576
 }
577 577
\ No newline at end of file
Please login to merge, or discard this patch.