Test Failed
Push — master ( c5b6f9...e099c4 )
by Maja
11:40
created
web/admin/edit_federation.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 $auth = new \web\lib\admin\Authentication();
32 32
 $deco = new \web\lib\admin\PageDecoration();
@@ -70,13 +70,13 @@  discard block
 block discarded – undo
70 70
         ?>
71 71
     </h1>
72 72
     <div class='infobox'>
73
-        <h2><?php $tablecaption = sprintf(_("%s Properties"),$uiElements->nomenclatureFed); echo $tablecaption?></h2>
73
+        <h2><?php $tablecaption = sprintf(_("%s Properties"), $uiElements->nomenclatureFed); echo $tablecaption?></h2>
74 74
         <table>
75
-            <caption><?php echo $tablecaption;?></caption>
75
+            <caption><?php echo $tablecaption; ?></caption>
76 76
             <tr>
77
-                <th class="wai-invisible" scope="col"><?php echo _("Property Type");?></th>
78
-                <th class="wai-invisible" scope="col"><?php echo _("Language if applicable");?></th>
79
-                <th class="wai-invisible" scope="col"><?php echo _("Property Value");?></th>
77
+                <th class="wai-invisible" scope="col"><?php echo _("Property Type"); ?></th>
78
+                <th class="wai-invisible" scope="col"><?php echo _("Language if applicable"); ?></th>
79
+                <th class="wai-invisible" scope="col"><?php echo _("Property Value"); ?></th>
80 80
             </tr>
81 81
             <tr>
82 82
                 <td><?php echo _("Country:"); ?></td>
@@ -87,11 +87,11 @@  discard block
 block discarded – undo
87 87
         </table>
88 88
     </div>
89 89
     <?php
90
-    echo "<form enctype='multipart/form-data' action='edit_federation_result.php?fed_id=$my_fed->tld" . "' method='post' accept-charset='UTF-8'>
91
-              <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::MAX_UPLOAD_SIZE . "'>";
90
+    echo "<form enctype='multipart/form-data' action='edit_federation_result.php?fed_id=$my_fed->tld"."' method='post' accept-charset='UTF-8'>
91
+              <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::MAX_UPLOAD_SIZE."'>";
92 92
     ?>
93 93
     <fieldset class="option_container">
94
-        <legend><strong><?php echo sprintf(_("%s Properties"),$uiElements->nomenclatureFed); ?></strong></legend>
94
+        <legend><strong><?php echo sprintf(_("%s Properties"), $uiElements->nomenclatureFed); ?></strong></legend>
95 95
         <?php
96 96
         $optionDisplay = new \web\lib\admin\OptionDisplay($fed_options, \core\Options::LEVEL_FED);
97 97
         echo $optionDisplay->prefilledOptionTable("fed", $my_fed->tld);
@@ -101,10 +101,10 @@  discard block
 block discarded – undo
101 101
     <?php
102 102
     echo "<div>";
103 103
     if ($editMode === 'fullaccess') {
104
-        echo "<button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_SAVE . "'>" . _("Save data") . "</button>";
104
+        echo "<button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_SAVE."'>"._("Save data")."</button>";
105 105
         $discardLabel = _("Discard changes");
106 106
     } else {
107 107
         $discardLabel = _("Return");
108 108
     }
109
-    echo "<button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_federation.php?fed_id=$fedPost\"'>" . $discardLabel . "</button></div></form>";
109
+    echo "<button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_federation.php?fed_id=$fedPost\"'>".$discardLabel."</button></div></form>";
110 110
     echo $deco->footer();
Please login to merge, or discard this patch.
web/lib/common/InputValidation.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     private function inputValidationError($customtext)
41 41
     {
42 42
         \core\common\Entity::intoThePotatoes();
43
-        $retval = "<p>" . _("Input validation error: ") . $customtext . "</p>";
43
+        $retval = "<p>"._("Input validation error: ").$customtext."</p>";
44 44
         \core\common\Entity::outOfThePotatoes();
45 45
         return $retval;
46 46
     }
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         $postFed = $fedIdentifiers[$correctIndex];
98 98
         $temp = new \core\Federation($postFed);
99 99
         if ($owner === NULL) {
100
-            return [$temp,'readonly'];
100
+            return [$temp, 'readonly'];
101 101
         }
102 102
         $user = new \core\User($owner);        
103 103
         foreach ($temp->listFederationAdmins() as $oneowner) {
@@ -105,9 +105,9 @@  discard block
 block discarded – undo
105 105
                 return [$temp, 'fullaccess'];
106 106
             }
107 107
         }
108
-        if ($user->isSuperadmin()|| $user->isSupport()) {
108
+        if ($user->isSuperadmin() || $user->isSupport()) {
109 109
                 $this->loggerInstance->debug(4, "You are the superadmin/support\n");
110
-                return [$temp,'readonly'];                
110
+                return [$temp, 'readonly'];                
111 111
             }
112 112
         throw new Exception($this->inputValidationError(sprintf("User is not %s administrator!", \core\common\Entity::$nomenclature_fed)));
113 113
     }
@@ -168,18 +168,18 @@  discard block
 block discarded – undo
168 168
             }
169 169
             if ($user->isFederationAdmin($temp->federation)) {
170 170
                 $this->loggerInstance->debug(4, "You are fed admin for this IdP\n");
171
-                return [$temp,'readonly'];
171
+                return [$temp, 'readonly'];
172 172
             }
173 173
             if ($user->isSuperadmin() || $user->isSupport()) {
174 174
                 $this->loggerInstance->debug(4, "You are the superadmin/support\n");
175
-                return [$temp,'readonly'];                
175
+                return [$temp, 'readonly'];                
176 176
             }
177 177
             throw new Exception($this->inputValidationError("This IdP identifier is not accessible!"));
178 178
         }
179 179
         if ($claimedFedBinding !== NULL && strtoupper($temp->federation) != strtoupper($claimedFedBinding->tld)) {
180 180
             throw new Exception($this->inputValidationError("This IdP does not belong to the claimed federation!"));
181 181
         }
182
-        return [$temp,'nouser'];
182
+        return [$temp, 'nouser'];
183 183
     }
184 184
 
185 185
     /**
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
         try {
622 622
             $image->readImageBlob($binary);
623 623
         } catch (\ImagickException $exception) {
624
-            echo "Error" . $exception->getMessage();
624
+            echo "Error".$exception->getMessage();
625 625
             return FALSE;
626 626
         }
627 627
         // image survived the sanity check
Please login to merge, or discard this patch.
utils/test_openroaming.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
  * License: see the web/copyright.php file in the file structure
9 9
  * ******************************************************************************
10 10
  */
11
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
11
+require_once dirname(dirname(__FILE__))."/config/_config.php";
12 12
 
13 13
 /**
14 14
  * The sctipt will be called from crontab
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 }
29 29
 
30 30
 
31
-while ( $row = mysqli_fetch_object(/** @scrutinizer ignore-type */ $allOpenRoamingProfiles)) {
31
+while ($row = mysqli_fetch_object(/** @scrutinizer ignore-type */ $allOpenRoamingProfiles)) {
32 32
     $profileId = $row->profile_id;
33 33
     $profile = \core\ProfileFactory::instantiate($profileId);
34 34
     $res = $profile->openroamingRedinessTest();
Please login to merge, or discard this patch.
utils/update_monitor_copy.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
  * update the local copy
25 25
  */
26 26
 
27
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
27
+require_once dirname(dirname(__FILE__))."/config/_config.php";
28 28
 setlocale(LC_CTYPE, "en_US.UTF-8");
29 29
 
30 30
 class updateFromMonitor {
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
         $tmp_table = 'tmp_'.$table_name;
114 114
         if ($this->tablesource[$table_name] == 'eduroam') {
115 115
             $this->db_local->select_db('monitor_copy');
116
-        } elseif($this->tablesource[$table_name] == 'eduroamv2') {
116
+        } elseif ($this->tablesource[$table_name] == 'eduroamv2') {
117 117
             $this->db_local->select_db('eduroamv2');
118 118
         }
119 119
         $this->db_local->query("CREATE TEMPORARY TABLE $tmp_table SELECT * FROM $table LIMIT 0");
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         $this->db->query("SET NAMES 'utf8'");
123 123
         $this->db_local->query("SET NAMES 'utf8mb4'");
124 124
         $result = $this->db->query("SELECT * FROM $table");
125
-        $queryFields = implode(',', array_column($this->fields[$table_name],0));
125
+        $queryFields = implode(',', array_column($this->fields[$table_name], 0));
126 126
         while ($row = $result->fetch_assoc()) {
127 127
             $v = [];
128 128
             foreach ($this->fields[$table_name] as $field) {
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
                     }
141 141
                 }
142 142
             }
143
-            $queryValues = implode(',',$v);
143
+            $queryValues = implode(',', $v);
144 144
             $query = "INSERT INTO $tmp_table (".$queryFields.") VALUES (".$queryValues.")";
145 145
             $this->db_local->query($query);
146 146
         }
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         $tmp_table = 'tmp_'.$table_name;
153 153
         if ($this->tablesource[$table_name] == 'eduroam') {
154 154
                 $this->db_local->select_db('monitor_copy');
155
-        } elseif($this->tablesource[$table_name] == 'eduroamv2') {
155
+        } elseif ($this->tablesource[$table_name] == 'eduroamv2') {
156 156
                 $this->db_local->select_db('eduroamv2');
157 157
         }
158 158
         $this->db_local->query("SET NAMES 'utf8mb4'");
@@ -161,9 +161,9 @@  discard block
 block discarded – undo
161 161
     }
162 162
 
163 163
     private function escape($inp) {
164
-        $out=str_replace('\\','\\\\',$inp);
165
-        $out=str_replace('"','\"',$out);
166
-        $out=str_replace('?','\?',$out);
164
+        $out = str_replace('\\', '\\\\', $inp);
165
+        $out = str_replace('"', '\"', $out);
166
+        $out = str_replace('?', '\?', $out);
167 167
         $out = 'convert(cast(convert("'.$out.'" using latin1) as binary) using utf8)';
168 168
         return($out);
169 169
     }
Please login to merge, or discard this patch.
core/DBConnection.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -62,24 +62,24 @@  discard block
 block discarded – undo
62 62
             case "EXTERNAL":
63 63
             case "FRONTEND":
64 64
             case "DIAGNOSTICS":
65
-                if (!isset(self::${"instance" . $theDb})) {
65
+                if (!isset(self::${"instance".$theDb})) {
66 66
                     $class = __CLASS__;
67
-                    self::${"instance" . $theDb} = new $class($database);
68
-                    DBConnection::${"instance" . $theDb}->databaseInstance = $theDb;
67
+                    self::${"instance".$theDb} = new $class($database);
68
+                    DBConnection::${"instance".$theDb}->databaseInstance = $theDb;
69 69
                 }
70
-                return self::${"instance" . $theDb};
70
+                return self::${"instance".$theDb};
71 71
             case "RADIUS":
72
-                if (!isset(self::${"instance" . $theDb})) {
72
+                if (!isset(self::${"instance".$theDb})) {
73 73
                     $class = __CLASS__;
74 74
                     foreach (\config\ConfAssistant::DB as $name => $oneRadiusAuthDb) {
75 75
                         $theInstance = new $class($name);
76
-                        self::${"instance" . $theDb}[] = $theInstance;
76
+                        self::${"instance".$theDb}[] = $theInstance;
77 77
                         $theInstance->databaseInstance = $theDb;
78 78
                     }
79 79
                 }
80
-                return self::${"instance" . $theDb};
80
+                return self::${"instance".$theDb};
81 81
             default:
82
-                throw new Exception("This type of database (" . strtoupper($database) . ") is not known!");
82
+                throw new Exception("This type of database (".strtoupper($database).") is not known!");
83 83
         }
84 84
     }
85 85
 
@@ -121,18 +121,18 @@  discard block
 block discarded – undo
121 121
             }
122 122
         }
123 123
         // log exact query to debug log, if log level is at 5
124
-        $this->loggerInstance->debug(5, "DB ATTEMPT: ".$this->databaseInstance .": " . $querystring . "\n");
124
+        $this->loggerInstance->debug(5, "DB ATTEMPT: ".$this->databaseInstance.": ".$querystring."\n");
125 125
         if ($types !== NULL) {
126
-            $this->loggerInstance->debug(5, "Argument type sequence: $types, parameters are: " . /** @scrutinizer ignore-type */ print_r($arguments, true));
126
+            $this->loggerInstance->debug(5, "Argument type sequence: $types, parameters are: "./** @scrutinizer ignore-type */ print_r($arguments, true));
127 127
         }
128 128
 
129 129
         if ($this->connection->connect_error) {
130
-            throw new Exception("ERROR: Cannot send query to $this->databaseInstance database (no connection, error number" . $this->connection->connect_error . ")!");
130
+            throw new Exception("ERROR: Cannot send query to $this->databaseInstance database (no connection, error number".$this->connection->connect_error.")!");
131 131
         }
132 132
         if ($types === NULL) {
133 133
             $result = $this->connection->query($querystring);
134 134
             if ($result === FALSE) {
135
-                throw new Exception("DB: Unable to execute simple statement! Error was --> " . $this->connection->error . " <--");
135
+                throw new Exception("DB: Unable to execute simple statement! Error was --> ".$this->connection->error." <--");
136 136
             }
137 137
         } else {
138 138
             // fancy! prepared statement with dedicated argument list
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
                 }
149 149
                 $prepResult = $statementObject->prepare($querystring);
150 150
                 if ($prepResult === FALSE) {
151
-                    throw new Exception("DB: Unable to prepare statement! Statement was --> $querystring <--, error was --> " . $statementObject->error . " <--.");
151
+                    throw new Exception("DB: Unable to prepare statement! Statement was --> $querystring <--, error was --> ".$statementObject->error." <--.");
152 152
                 }
153 153
                 $this->preparedStatements[$querystring] = $statementObject;
154 154
             }
@@ -161,11 +161,11 @@  discard block
 block discarded – undo
161 161
             array_unshift($localArray, $types);
162 162
             $retval = call_user_func_array([$statementObject, "bind_param"], $localArray);
163 163
             if ($retval === FALSE) {
164
-                throw new Exception("DB: Unable to bind parameters to prepared statement! Argument array was --> " . var_export($localArray, TRUE) . " <--. Error was --> " . $statementObject->error . " <--");
164
+                throw new Exception("DB: Unable to bind parameters to prepared statement! Argument array was --> ".var_export($localArray, TRUE)." <--. Error was --> ".$statementObject->error." <--");
165 165
             }
166 166
             $result = $statementObject->execute();
167 167
             if ($result === FALSE) {
168
-                throw new Exception("DB: Unable to execute prepared statement! Error was --> " . $statementObject->error . " <--");
168
+                throw new Exception("DB: Unable to execute prepared statement! Error was --> ".$statementObject->error." <--");
169 169
             }
170 170
             $selectResult = $statementObject->get_result();
171 171
             if ($selectResult !== FALSE) {
@@ -175,14 +175,14 @@  discard block
 block discarded – undo
175 175
 
176 176
         // all cases where $result could be FALSE have been caught earlier
177 177
         if ($this->connection->errno) {
178
-            throw new Exception("ERROR: Cannot execute query in $this->databaseInstance database - (hopefully escaped) query was '$querystring', errno was " . $this->connection->errno . "!");
178
+            throw new Exception("ERROR: Cannot execute query in $this->databaseInstance database - (hopefully escaped) query was '$querystring', errno was ".$this->connection->errno."!");
179 179
         }
180 180
 
181 181
 
182 182
         if ($isMoreThanSelect || \config\Master::DEBUG_LEVEL == 5) {
183
-            $this->loggerInstance->writeSQLAudit("[DB: " . strtoupper($this->databaseInstance) . "] " . $querystring);
183
+            $this->loggerInstance->writeSQLAudit("[DB: ".strtoupper($this->databaseInstance)."] ".$querystring);
184 184
             if ($types !== NULL) {
185
-                $this->loggerInstance->writeSQLAudit("Argument type sequence: $types, parameters are: " . /** @scrutinizer ignore-type */ print_r($arguments, true));
185
+                $this->loggerInstance->writeSQLAudit("Argument type sequence: $types, parameters are: "./** @scrutinizer ignore-type */ print_r($arguments, true));
186 186
             }
187 187
         }
188 188
         return $result;
@@ -280,13 +280,13 @@  discard block
 block discarded – undo
280 280
         if (isset(\config\Master::DB[$databaseCapitalised])) {
281 281
             $this->connection = new \mysqli(\config\Master::DB[$databaseCapitalised]['host'], \config\Master::DB[$databaseCapitalised]['user'], \config\Master::DB[$databaseCapitalised]['pass'], \config\Master::DB[$databaseCapitalised]['db']);
282 282
             if ($this->connection->connect_error) {
283
-                throw new Exception("ERROR: Unable to connect to $database database! This is a fatal error, giving up (error number " . $this->connection->connect_errno . ").");
283
+                throw new Exception("ERROR: Unable to connect to $database database! This is a fatal error, giving up (error number ".$this->connection->connect_errno.").");
284 284
             }
285 285
             $this->readOnly = \config\Master::DB[$databaseCapitalised]['readonly'];
286 286
         } else { // one of the RADIUS DBs
287 287
             $this->connection = new \mysqli(\config\ConfAssistant::DB[$databaseCapitalised]['host'], \config\ConfAssistant::DB[$databaseCapitalised]['user'], \config\ConfAssistant::DB[$databaseCapitalised]['pass'], \config\ConfAssistant::DB[$databaseCapitalised]['db']);
288 288
             if ($this->connection->connect_error) {
289
-                throw new Exception("ERROR: Unable to connect to $database database! This is a fatal error, giving up (error number " . $this->connection->connect_errno . ").");
289
+                throw new Exception("ERROR: Unable to connect to $database database! This is a fatal error, giving up (error number ".$this->connection->connect_errno.").");
290 290
             }
291 291
             $this->readOnly = \config\ConfAssistant::DB[$databaseCapitalised]['readonly'];
292 292
         }
Please login to merge, or discard this patch.
web/diag/diag.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
23 23
 $admin = filter_input(INPUT_GET, 'admin', FILTER_VALIDATE_INT);
24 24
 $sp = filter_input(INPUT_GET, 'sp', FILTER_VALIDATE_INT);
25 25
 $givenRealm = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'realm')));
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
             unset($q_el[$idx]);
36 36
             $q_r = preg_replace("/\?.*/", "", $_SERVER['REQUEST_URI']);
37 37
             if (count($q_el)) {
38
-                $q_r = $q_r . '?' . implode('&', $q_el);
38
+                $q_r = $q_r.'?'.implode('&', $q_el);
39 39
             }
40 40
             $_SERVER['REQUEST_URI'] = $q_r;
41 41
         }
@@ -44,11 +44,11 @@  discard block
 block discarded – undo
44 44
     $auth->authenticate();
45 45
 }
46 46
 if (isset($_SESSION['admin_diag_auth'])) {
47
-   $admin =  1;
47
+   $admin = 1;
48 48
    unset($_SESSION['admin_diag_auth']);
49 49
 }
50 50
 $Gui = new \web\lib\user\Gui();
51 51
 $skinObject = new \web\lib\user\Skinjob($_REQUEST['skin'] ?? $_SESSION['skin'] ?? $fedskin[0] ?? \config\Master::APPEARANCE['skins'][0]);
52
-require "../skins/" . $skinObject->skin . "/diag/diag.php";
52
+require "../skins/".$skinObject->skin."/diag/diag.php";
53 53
 
54 54
 
Please login to merge, or discard this patch.
web/diag/magicTelepath.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,10 +19,10 @@
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(__DIR__)) . "/config/_config.php";
22
+require_once dirname(dirname(__DIR__))."/config/_config.php";
23 23
 $realm = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'realm')));
24
-$visited = htmlspecialchars(strip_tags(filter_input(INPUT_GET,'visited')));
25
-$nro = htmlspecialchars(strip_tags(filter_input(INPUT_GET,'nro')));
24
+$visited = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'visited')));
25
+$nro = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'nro')));
26 26
 \core\CAT::sessionStart();
27 27
 $languageObject = new core\common\Language();
28 28
 $languageObject->setTextDomain("diagonstics");
Please login to merge, or discard this patch.
web/diag/testTelepath.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(__DIR__)) . "/config/_config.php";
22
+require_once dirname(dirname(__DIR__))."/config/_config.php";
23 23
 
24 24
 $therealm = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'realm')));
25 25
 $thevisited = htmlspecialchars(strip_tags(filter_input(INPUT_GET, 'visited')));
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     $validator = new \web\lib\common\InputValidation();
36 36
     
37 37
     echo "<pre>";
38
-    echo "Testing " . $validatedRealm . " in " . $validator->string($thevisited);
38
+    echo "Testing ".$validatedRealm." in ".$validator->string($thevisited);
39 39
     print_r($telepath->magic());
40 40
     echo "</pre>";
41 41
 }
42 42
\ No newline at end of file
Please login to merge, or discard this patch.
web/lib/admin/PageDecoration.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -73,17 +73,17 @@  discard block
 block discarded – undo
73 73
         $retval = "<div class='sidebar'><p>";
74 74
         $user = new \core\User($_SESSION['user']);
75 75
         if ($advancedControls) {
76
-            $retval .= "<strong>" . _("You are:") . "</strong> ".$_SESSION['name']
76
+            $retval .= "<strong>"._("You are:")."</strong> ".$_SESSION['name']
77 77
             ."<br/>
78 78
               <br/>";
79 79
             if ($user->isFederationAdmin()) {
80
-                $retval .= "<a href='" . \core\CAT::getRootUrlPath() . "/admin/overview_federation.php'>" . _("The NRO page") . "</a> ";
80
+                $retval .= "<a href='".\core\CAT::getRootUrlPath()."/admin/overview_federation.php'>"._("The NRO page")."</a> ";
81 81
 
82 82
             }
83
-            $retval .= "<a href='" . \core\CAT::getRootUrlPath() . "/admin/overview_user.php'>" . _("Go to your Profile page") . "</a> 
84
-              <a href='" . \core\CAT::getRootUrlPath() . "/admin/inc/logout.php'>" . _("Logout") . "</a> ";
83
+            $retval .= "<a href='".\core\CAT::getRootUrlPath()."/admin/overview_user.php'>"._("Go to your Profile page")."</a> 
84
+              <a href='" . \core\CAT::getRootUrlPath()."/admin/inc/logout.php'>"._("Logout")."</a> ";
85 85
         }
86
-        $retval .= "<a href='" . \core\CAT::getRootUrlPath() . "/'>" . _("Start page") . "</a>
86
+        $retval .= "<a href='".\core\CAT::getRootUrlPath()."/'>"._("Start page")."</a>
87 87
             </p>
88 88
         </div> <!-- sidebar -->";
89 89
         \core\common\Entity::outOfThePotatoes();
@@ -107,23 +107,23 @@  discard block
 block discarded – undo
107 107
                     <h1>$cap1</h1>
108 108
                 </div><!--header_captions-->
109 109
                 <div id='langselection' style='padding-top:20px; padding-".$this->start.":10px;'>
110
-                    <form action='$place' method='GET' accept-charset='UTF-8'>" . _("View this page in") . "&nbsp;
110
+                    <form action='$place' method='GET' accept-charset='UTF-8'>"._("View this page in")."&nbsp;
111 111
                         <select id='lang' name='lang' onchange='this.form.submit()'>";
112 112
 
113 113
         foreach (\config\Master::LANGUAGES as $lang => $getValue) {
114
-            $retval .= "<option value='$lang' " . (strtoupper($language) == strtoupper($lang) ? "selected" : "" ) . " >" . $getValue['display'] . "</option> ";
114
+            $retval .= "<option value='$lang' ".(strtoupper($language) == strtoupper($lang) ? "selected" : "")." >".$getValue['display']."</option> ";
115 115
         }
116 116
         $retval .= "</select>";
117 117
 
118 118
         foreach ($_GET as $getVar => $getValue) {
119 119
             $filterValue = htmlspecialchars(strip_tags(filter_input(INPUT_GET, $getVar)));
120 120
             if ($getVar != "lang" && $getValue != "") {
121
-                $retval .= "<input type='hidden' name='" . htmlspecialchars($getVar) . "' value='" . htmlspecialchars($filterValue) . "'>";
121
+                $retval .= "<input type='hidden' name='".htmlspecialchars($getVar)."' value='".htmlspecialchars($filterValue)."'>";
122 122
             }
123 123
         }
124 124
         $retval .= "</form>
125 125
                 </div><!--langselection-->";
126
-        $logoUrl = \core\CAT::getRootUrlPath() . "/resources/images/consortium_logo.png";
126
+        $logoUrl = \core\CAT::getRootUrlPath()."/resources/images/consortium_logo.png";
127 127
         $retval .= "<div class='consortium_logo'>
128 128
                     <img id='test_locate' src='$logoUrl' alt='Consortium Logo'>
129 129
                 </div> <!-- consortium_logo -->
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 
217 217
         if (isset(\config\Master::APPEARANCE['MOTD']) && \config\Master::APPEARANCE['MOTD'] != "") {
218 218
             $retval .= "<div id='header_MOTD' style='display:inline-block; padding-".$this->start.":20px;vertical-align:top;'>
219
-              <p class='MOTD'>" . \config\Master::APPEARANCE['MOTD'] . "</p>
219
+              <p class='MOTD'>" . \config\Master::APPEARANCE['MOTD']."</p>
220 220
               </div><!--header_MOTD-->";
221 221
         }
222 222
         $retval .= $this->sidebar($advancedControls);
@@ -242,9 +242,9 @@  discard block
 block discarded – undo
242 242
           <html xmlns='http://www.w3.org/1999/xhtml' lang='$ourlocale'".($this->langObject->rtl ? "dir='rtl'" : "").">
243 243
           <head lang='$ourlocale'>
244 244
           <meta http-equiv='Content-Type' content='text/html; charset=UTF-8'>";
245
-        $cssUrl = \core\CAT::getRootUrlPath() . "/resources/css/cat.css.php";
245
+        $cssUrl = \core\CAT::getRootUrlPath()."/resources/css/cat.css.php";
246 246
         $retval .= "<link rel='stylesheet' type='text/css' href='$cssUrl' />";
247
-        $retval .= "<title>" . htmlspecialchars($pagetitle) . "</title>";
247
+        $retval .= "<title>".htmlspecialchars($pagetitle)."</title>";
248 248
         return $retval;
249 249
     }
250 250
 
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
             // we may need to jump up one dir if we are either in admin/ or accountstatus/
259 259
             // (accountstatus courtesy of my good mood. It's userspace not admin space so
260 260
             // it shouldn't be using this function any more.)
261
-            $logoBase = \core\CAT::getRootUrlPath() . "/resources/images";
261
+            $logoBase = \core\CAT::getRootUrlPath()."/resources/images";
262 262
             return "<span id='logos'><img src='$logoBase/dante.png' alt='DANTE' style='height:23px;width:47px'/>
263 263
               <img src='$logoBase/eu.png' alt='EU' style='height:23px;width:27px;border-width:0px;'/></span>
264 264
               <span id='eu_text' style='text-align:right;'><a href='http://ec.europa.eu/dgs/connect/index_en.htm' style='text-decoration:none; vertical-align:top;'>European Commission Communications Networks, Content and Technology</a></span>";
Please login to merge, or discard this patch.