Passed
Push — master ( 87e53a...e7e40e )
by Tomasz
03:39
created
web/diag/action_realmcheck.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
           <head lang='" . $ourlocale . "'>
25 25
           <meta http-equiv='Content-Type' content='text/html; charset=UTF-8'>";
26 26
     // diag area needs its own CSS at some point, but use the user area one for now
27
-    $cssUrl = $gui->skinObject->findResourceUrl("CSS","cat.css.php");
27
+    $cssUrl = $gui->skinObject->findResourceUrl("CSS", "cat.css.php");
28 28
     echo "<link rel='stylesheet' type='text/css' href='$cssUrl' />";
29 29
     echo "<title>" . htmlspecialchars(_("Sanity check for dynamic discovery of realms")) . "</title>";
30 30
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         // checking our own stuff. Enable thorough checks
48 48
         $check_thorough = TRUE;
49 49
         $check_realm = $checkrealm[0]['value'];
50
-        $testsuite = new \core\diag\RADIUSTests($check_realm, $my_profile->getRealmCheckOuterUsername(), $my_profile->getEapMethodsinOrderOfPreference(1), $my_profile->getCollapsedAttributes()['eap:server_name'] , $my_profile->getCollapsedAttributes()["eap:ca_file"]);
50
+        $testsuite = new \core\diag\RADIUSTests($check_realm, $my_profile->getRealmCheckOuterUsername(), $my_profile->getEapMethodsinOrderOfPreference(1), $my_profile->getCollapsedAttributes()['eap:server_name'], $my_profile->getCollapsedAttributes()["eap:ca_file"]);
51 51
         $rfc7585suite = new \core\diag\RFC7585Tests($check_realm);
52 52
     } else {
53 53
         $error_message = _("You asked for a realm check, but we don't know the realm for this profile!") . "</p>";
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         }
66 66
     }
67 67
     if ($check_realm) {
68
-        $testsuite = new \core\diag\RADIUSTests($check_realm, "@".$check_realm);
68
+        $testsuite = new \core\diag\RADIUSTests($check_realm, "@" . $check_realm);
69 69
         $rfc7585suite = new \core\diag\RFC7585Tests($check_realm);
70 70
     } else {
71 71
         $error_message = _("No valid realm name given, cannot execute any checks!");
@@ -751,13 +751,13 @@  discard block
 block discarded – undo
751 751
         }
752 752
         
753 753
         if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == "LOCAL") {
754
-            $returnUrl = "../admin/overview_idp.php?inst_id=".$my_inst->identifier;
754
+            $returnUrl = "../admin/overview_idp.php?inst_id=" . $my_inst->identifier;
755 755
         } else {
756
-            $returnUrl = CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS']."/admin/overview_idp.php?inst_id=".$my_inst->identifier;
756
+            $returnUrl = CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] . "/admin/overview_idp.php?inst_id=" . $my_inst->identifier;
757 757
         }
758 758
         ?>
759
-        <form method='post' action='<?php echo $returnUrl;?>' accept-charset='UTF-8'>
760
-            <button type='submit' name='submitbutton' value='<?php echo web\lib\common\FormElements::BUTTON_CLOSE; ?>'><?php echo sprintf(_("Return to %s administrator area"),$gui->nomenclature_inst); ?></button>
759
+        <form method='post' action='<?php echo $returnUrl; ?>' accept-charset='UTF-8'>
760
+            <button type='submit' name='submitbutton' value='<?php echo web\lib\common\FormElements::BUTTON_CLOSE; ?>'><?php echo sprintf(_("Return to %s administrator area"), $gui->nomenclature_inst); ?></button>
761 761
         </form>
762 762
         <script>
763 763
 
Please login to merge, or discard this patch.
web/admin/112365365321.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 ini_set('display_errors', '0');
30 30
 require_once(dirname(dirname(__DIR__)) . '/config/_config.php');
31 31
 
32
-if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == "LOCAL" || CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == "LOCAL" ) {
32
+if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == "LOCAL" || CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == "LOCAL") {
33 33
     $Tests[] = 'makensis';
34 34
     $Tests[] = 'makensis=>NSISmodules';
35 35
     $Tests[] = 'makensis=>NSIS_GetVersion';
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
                     <th>Device</th>
179 179
                     <th>Admin Downloads</th>
180 180
                     <th>User Downloads (classic)</th>
181
-                    <th>User Downloads (<?php echo \core\ProfileSilverbullet::PRODUCTNAME;?>)</th>
181
+                    <th>User Downloads (<?php echo \core\ProfileSilverbullet::PRODUCTNAME; ?>)</th>
182 182
                     <th>User Downloads (total)</th>
183 183
                 </tr>
184 184
                 <?php
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
                     echo "<tr>";
190 190
                     $admin_query = $dbHandle->exec("SELECT SUM(downloads_admin) AS admin, SUM(downloads_user) AS user, SUM(downloads_silverbullet) as silverbullet FROM downloads WHERE device_id = '$index'");
191 191
                     while ($a = mysqli_fetch_object($admin_query)) {
192
-                        echo "<td>" . $device_array['display'] . "</td><td>" . $a->admin . "</td><td>" . $a->user . "</td><td>" . $a->silverbullet . "</td><td>" . sprintf("%s",$a->user + $a->silverbullet) . "</td>";
192
+                        echo "<td>" . $device_array['display'] . "</td><td>" . $a->admin . "</td><td>" . $a->user . "</td><td>" . $a->silverbullet . "</td><td>" . sprintf("%s", $a->user + $a->silverbullet) . "</td>";
193 193
                         $gross_admin = $gross_admin + $a->admin;
194 194
                         $gross_user = $gross_user + $a->user;
195 195
                         $gross_silverbullet = $gross_silverbullet + $a->silverbullet;
Please login to merge, or discard this patch.
web/admin/edit_idp.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
             sprintf(_("In this section, you define on which media %s should be configured on user devices."), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) . "</p>
138 138
           <ul>";
139 139
             echo "<li>";
140
-            echo "<strong>" . ( count(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) > 0 ? _("Additional SSIDs:") : _("SSIDs:")) . " </strong>";
140
+            echo "<strong>" . (count(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) > 0 ? _("Additional SSIDs:") : _("SSIDs:")) . " </strong>";
141 141
             if (count(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) > 0) {
142 142
                 $ssidlist = "";
143 143
                 foreach (CONFIG_CONFASSISTANT['CONSORTIUM']['ssid'] as $ssid) {
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
             echo "</li>";
157 157
 
158 158
             echo "<li>";
159
-            echo "<strong>" . ( count(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) > 0 ? _("Additional Hotspot 2.0 / Passpoint Consortia:") : _("Hotspot 2.0 / Passpoint Consortia:")) . " </strong>";
159
+            echo "<strong>" . (count(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) > 0 ? _("Additional Hotspot 2.0 / Passpoint Consortia:") : _("Hotspot 2.0 / Passpoint Consortia:")) . " </strong>";
160 160
             if (count(CONFIG_CONFASSISTANT['CONSORTIUM']['interworking-consortium-oi']) > 0) {
161 161
                 $consortiumlist = "";
162 162
                 foreach (CONFIG_CONFASSISTANT['CONSORTIUM']['interworking-consortium-oi'] as $oi) {
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
         <legend><strong><?php echo _("Helpdesk Details for all users"); ?></strong></legend>
187 187
         <?php
188 188
         if ($wizardStyle) {
189
-            echo "<p>"._("This section can be used to upload specific Terms of Use for your users and to display details of how your users can reach your local helpdesk.")."</p>";
189
+            echo "<p>" . _("This section can be used to upload specific Terms of Use for your users and to display details of how your users can reach your local helpdesk.") . "</p>";
190 190
             
191 191
             if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == "LOCAL") {
192 192
                 echo "<p>" .
@@ -194,10 +194,10 @@  discard block
 block discarded – undo
194 194
                 "<p>" .
195 195
                 _("If you enter a value here, it will be added to the installers for all your users, and will be displayed on the download page. If you operate separate helpdesks for different user groups (we call this 'profiles'), or operate no help desk at all, you can also leave any of these fields empty and optionally specify per-profile helpdesk information later in this wizard.") . "</p>";
196 196
                 if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == "LOCAL") {
197
-                echo "<p>" . sprintf(_("For %s deployments, providing at least a local e-mail contact is required."), core\ProfileSilverbullet::PRODUCTNAME) ." " . _("This is the contact point for your end users' level 1 support.") . "</p>";
197
+                echo "<p>" . sprintf(_("For %s deployments, providing at least a local e-mail contact is required."), core\ProfileSilverbullet::PRODUCTNAME) . " " . _("This is the contact point for your end users' level 1 support.") . "</p>";
198 198
                 }
199 199
             } elseif (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == "LOCAL") {
200
-                echo "<p>". _("Providing at least a local support e-mail contact is required.")." "._("This is the contact point for your end users' level 1 support.")."</p>";
200
+                echo "<p>" . _("Providing at least a local support e-mail contact is required.") . " " . _("This is the contact point for your end users' level 1 support.") . "</p>";
201 201
             }
202 202
             
203 203
         }
Please login to merge, or discard this patch.
config/_config.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 
95 95
 /* load sub-configs if we are dealing with those in this installation */
96 96
 
97
-if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == 'LOCAL' || CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == 'LOCAL' ) {
97
+if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == 'LOCAL' || CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == 'LOCAL') {
98 98
     include(ROOT . "/config/config-confassistant.php");
99 99
 }
100 100
 
Please login to merge, or discard this patch.
web/admin/overview_idp.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         <div class='infobox' style='text-align:center;'>
57 57
             <h2><?php echo sprintf(_("QR Code for %s download area"), $uiElements->nomenclature_inst); ?></h2>
58 58
             <?php
59
-            $displayurl = ( isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == "on" ? 'https://' : 'http://') . $_SERVER['SERVER_NAME'] . dirname(dirname($_SERVER['SCRIPT_NAME'])) . "?idp=" . $my_inst->identifier;
59
+            $displayurl = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == "on" ? 'https://' : 'http://') . $_SERVER['SERVER_NAME'] . dirname(dirname($_SERVER['SCRIPT_NAME'])) . "?idp=" . $my_inst->identifier;
60 60
             $uri = "data:image/png;base64," . base64_encode($uiElements->pngInjectConsortiumLogo(QRcode::png($displayurl, FALSE, QR_ECLEVEL_Q, QRCODE_PIXELS_PER_SYMBOL), QRCODE_PIXELS_PER_SYMBOL));
61 61
             $size = getimagesize($uri);
62 62
             echo "<img width='" . ($size[0] / 4) . "' height='" . ($size[1] / 4) . "' src='$uri' alt='QR-code'/>";
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
             </td>
90 90
             <td>
91 91
                 <form action='edit_idp_result.php?inst_id=<?php echo $my_inst->identifier; ?>' method='post' accept-charset='UTF-8'>
92
-                    <button class='delete' type='submit' name='submitbutton' value='<?php echo web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php echo ( CONFIG_CONFASSISTANT['CONSORTIUM']['selfservice_registration'] === NULL ? sprintf(_("After deleting the IdP, you can not recreate it yourself - you need a new invitation token from the %s administrator!"), $uiElements->nomenclature_fed) . " " : "" ) . sprintf(_("Do you really want to delete your %s %s?"), $uiElements->nomenclature_inst, $my_inst->name); ?>')"><?php echo sprintf(_("Delete %s"), $uiElements->nomenclature_inst); ?></button>
92
+                    <button class='delete' type='submit' name='submitbutton' value='<?php echo web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php echo (CONFIG_CONFASSISTANT['CONSORTIUM']['selfservice_registration'] === NULL ? sprintf(_("After deleting the IdP, you can not recreate it yourself - you need a new invitation token from the %s administrator!"), $uiElements->nomenclature_fed) . " " : "") . sprintf(_("Do you really want to delete your %s %s?"), $uiElements->nomenclature_inst, $my_inst->name); ?>')"><?php echo sprintf(_("Delete %s"), $uiElements->nomenclature_inst); ?></button>
93 93
                 </form>
94 94
 
95 95
             </td>
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
                     <br/>
168 168
                     <br/>
169 169
                     <form action='edit_silverbullet.php?inst_id=<?php echo $my_inst->identifier; ?>&profile_id=<?php echo $profile_list->identifier; ?>' method='POST'>
170
-                        <button <?php echo ( is_array($completeness) ? "disabled" : "" ); ?> type='submit' name='sb_action' value='sb_edit'><?php echo _("Manage User Base"); ?></button>
170
+                        <button <?php echo (is_array($completeness) ? "disabled" : ""); ?> type='submit' name='sb_action' value='sb_edit'><?php echo _("Manage User Base"); ?></button>
171 171
                     </form>
172 172
                 </div>
173 173
 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
                 if (isset($URL['device-specific:redirect'])) {
303 303
                     $displayurl = $URL['device-specific:redirect'][0];
304 304
                 } else {
305
-                    $displayurl = ( isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == "on" ? 'https://' : 'http://') . $_SERVER['SERVER_NAME'] . dirname(dirname($_SERVER['SCRIPT_NAME'])) . "?idp=" . $my_inst->identifier . "&amp;profile=" . $profile_list->identifier;
305
+                    $displayurl = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == "on" ? 'https://' : 'http://') . $_SERVER['SERVER_NAME'] . dirname(dirname($_SERVER['SCRIPT_NAME'])) . "?idp=" . $my_inst->identifier . "&amp;profile=" . $profile_list->identifier;
306 306
                 }
307 307
                 echo "<a href='$displayurl' style='white-space: nowrap; text-align: center;'>";
308 308
                 $uri = "data:image/png;base64," . base64_encode($uiElements->pngInjectConsortiumLogo(QRcode::png($displayurl, FALSE, QR_ECLEVEL_Q, QRCODE_PIXELS_PER_SYMBOL), QRCODE_PIXELS_PER_SYMBOL));
Please login to merge, or discard this patch.
web/admin/edit_profile.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
                 </td>
280 280
                 <td>
281 281
                     <input type='checkbox' <?php
282
-                    echo ($verify != FALSE ? "checked" : "" );
282
+                    echo ($verify != FALSE ? "checked" : "");
283 283
                     ?> name='verify_support' onclick='
284 284
                             if (this.form.elements["verify_support"].checked !== true || this.form.elements["realm"].value.length == 0) {
285 285
                                 this.form.elements["hint_support"].setAttribute("disabled", "disabled");
@@ -287,48 +287,48 @@  discard block
 block discarded – undo
287 287
                                 this.form.elements["hint_support"].removeAttribute("disabled");
288 288
                             }
289 289
                             ;'/>
290
-                    <span id='hint_label' style='<?php echo ($realm == "" ? "color:#999999" : "" ); ?>'>
290
+                    <span id='hint_label' style='<?php echo ($realm == "" ? "color:#999999" : ""); ?>'>
291 291
                         <?php echo _("Prefill user input with realm suffix:"); ?>
292 292
                     </span>
293
-                    <input type='checkbox' <?php echo ($verify == FALSE ? "disabled" : "" ); ?> name='hint_support' <?php echo ( $hint != FALSE ? "checked" : "" ); ?> />
293
+                    <input type='checkbox' <?php echo ($verify == FALSE ? "disabled" : ""); ?> name='hint_support' <?php echo ($hint != FALSE ? "checked" : ""); ?> />
294 294
                 </td>
295 295
             </tr>
296 296
             <tr>
297 297
 
298 298
                 <!-- checkbox and input field for anonymity support, available only when realm is known-->
299 299
                 <td>
300
-                    <span id='anon_support_label' style='<?php echo ($realm == "" ? "color:#999999" : "" ); ?>'>
300
+                    <span id='anon_support_label' style='<?php echo ($realm == "" ? "color:#999999" : ""); ?>'>
301 301
                         <?php echo _("Enable Anonymous Outer Identity:"); ?>
302 302
                     </span>
303 303
                 </td>
304 304
                 <td>
305
-                    <input type='checkbox' <?php echo ($useAnon != FALSE ? "checked" : "" ) . ($realm == "" ? " disabled" : "" ); ?> name='anon_support' onclick='
305
+                    <input type='checkbox' <?php echo ($useAnon != FALSE ? "checked" : "") . ($realm == "" ? " disabled" : ""); ?> name='anon_support' onclick='
306 306
                             if (this.form.elements["anon_support"].checked !== true) {
307 307
                                 this.form.elements["anon_local"].setAttribute("disabled", "disabled");
308 308
                             } else {
309 309
                                 this.form.elements["anon_local"].removeAttribute("disabled");
310 310
                             }
311 311
                             ;'/>
312
-                    <input type='text' <?php echo ($checkuserOuter == FALSE ? "disabled" : "" ); ?> name='anon_local' value='<?php echo $anonLocal; ?>'/>
312
+                    <input type='text' <?php echo ($checkuserOuter == FALSE ? "disabled" : ""); ?> name='anon_local' value='<?php echo $anonLocal; ?>'/>
313 313
                 </td>    
314 314
             </tr>
315 315
             <tr>
316 316
 
317 317
                 <!-- checkbox and input field for check realm outer id, available only when realm is known-->
318 318
                 <td>
319
-                    <span id='checkuser_label' style='<?php echo ($realm == "" ? "color:#999999" : "" ); ?>'>
319
+                    <span id='checkuser_label' style='<?php echo ($realm == "" ? "color:#999999" : ""); ?>'>
320 320
                         <?php echo _("Use special Outer Identity for realm checks:"); ?>
321 321
                     </span>
322 322
                 </td>
323 323
                 <td>
324
-                    <input type='checkbox' <?php echo ($checkuserOuter != FALSE ? "checked" : "" ) . ($realm == "" ? " disabled" : "" ); ?> name='checkuser_support' onclick='
324
+                    <input type='checkbox' <?php echo ($checkuserOuter != FALSE ? "checked" : "") . ($realm == "" ? " disabled" : ""); ?> name='checkuser_support' onclick='
325 325
                             if (this.form.elements["checkuser_support"].checked !== true) {
326 326
                                 this.form.elements["checkuser_local"].setAttribute("disabled", "disabled");
327 327
                             } else {
328 328
                                 this.form.elements["checkuser_local"].removeAttribute("disabled");
329 329
                             }
330 330
                             ;'/>
331
-                    <input type='text' <?php echo ($checkuserOuter == FALSE ? "disabled" : "" ); ?> name='checkuser_local' value='<?php echo $checkuserValue; ?>'/>
331
+                    <input type='text' <?php echo ($checkuserOuter == FALSE ? "disabled" : ""); ?> name='checkuser_local' value='<?php echo $checkuserValue; ?>'/>
332 332
                 </td>
333 333
             </tr>
334 334
         </table>
@@ -344,14 +344,14 @@  discard block
 block discarded – undo
344 344
     <p>
345 345
 
346 346
         <?php
347
-        echo "<span id='redirect_label' style='" . ($realm == "" ? "color:#999999" : "" ) . "'><label for='redirect'>" . _("Redirect end users to own web page:") . "</label></span>
348
-                          <input type='checkbox'  name='redirect' id='redirect' " . ($blacklisted === FALSE ? "" : "checked " ) . "onclick='
347
+        echo "<span id='redirect_label' style='" . ($realm == "" ? "color:#999999" : "") . "'><label for='redirect'>" . _("Redirect end users to own web page:") . "</label></span>
348
+                          <input type='checkbox'  name='redirect' id='redirect' " . ($blacklisted === FALSE ? "" : "checked ") . "onclick='
349 349
                               if (this.form.elements[\"redirect\"].checked != true) {
350 350
                                 this.form.elements[\"redirect_target\"].setAttribute(\"disabled\", \"disabled\");
351 351
                               } else {
352 352
                                 this.form.elements[\"redirect_target\"].removeAttribute(\"disabled\");
353 353
                               };'/>
354
-                          <input type='text' name='redirect_target' " . ($blacklisted !== FALSE ? "value='$blacklisted'" : "disabled" ) . "/>";
354
+                          <input type='text' name='redirect_target' " . ($blacklisted !== FALSE ? "value='$blacklisted'" : "disabled") . "/>";
355 355
         ?>
356 356
     </p>
357 357
 
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
     function priority(string $eapType, bool $isenabled, int $priority) {
376 376
         echo "<td><select id='$eapType-priority' name='$eapType-priority' " . (!$isenabled ? "disabled='disabled'" : "") . ">";
377 377
         for ($a = 1; $a < 7; $a = $a + 1) {
378
-            echo "<option id='$eapType-$a' value='$a' " . ( $isenabled && $a == $priority ? "selected" : "" ) . ">$a</option>";
378
+            echo "<option id='$eapType-$a' value='$a' " . ($isenabled && $a == $priority ? "selected" : "") . ">$a</option>";
379 379
         }
380 380
         echo "</select></td>";
381 381
     }
Please login to merge, or discard this patch.
web/user/API.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     'getUserCerts',
40 40
 ];
41 41
 
42
-function getRequest($varName,$filter) {
42
+function getRequest($varName, $filter) {
43 43
     $safeText = ["options"=>["regexp"=>"/^[\w\d-]+$/"]];
44 44
     switch ($filter) {
45 45
         case 'safe_text':
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 
58 58
 // make sure this is a known action
59 59
 $actionR = getRequest('action', 'safe_text');
60
-$action = array_search($actionR,LISTOFACTIONS) ? $actionR : FALSE;
60
+$action = array_search($actionR, LISTOFACTIONS) ? $actionR : FALSE;
61 61
 if ($action === FALSE) {
62 62
     exit;
63 63
 }
@@ -65,18 +65,18 @@  discard block
 block discarded – undo
65 65
 $lang = $langR ? $validator->supportedLanguage($langR) : FALSE;
66 66
 $deviceR = getRequest('device', 'safe_text');
67 67
 $device = $deviceR ? $validator->Device($deviceR) : FALSE;
68
-$idpR = getRequest('idp','int');
68
+$idpR = getRequest('idp', 'int');
69 69
 $idp = $idpR ? $validator->IdP($idpR)->identifier : FALSE;
70
-$profileR = getRequest('profile','int');
70
+$profileR = getRequest('profile', 'int');
71 71
 $profile = $profileR ? $validator->Profile($profileR)->identifier : FALSE;
72
-$federationR = getRequest('federation','safe_text');
72
+$federationR = getRequest('federation', 'safe_text');
73 73
 $federation = $federationR ? $validator->Federation($deviceR)->identifier : FALSE;
74
-$disco = getRequest('disco','int');
75
-$width = getRequest('width','int') ?? 0;
76
-$height = getRequest('height','int') ?? 0;
77
-$sort = getRequest('sort','int') ?? 0;
78
-$generatedforR = getRequest('generatedfor','safe_text') ?? 'user';
79
-$token = getRequest('token','safe_text');
74
+$disco = getRequest('disco', 'int');
75
+$width = getRequest('width', 'int') ?? 0;
76
+$height = getRequest('height', 'int') ?? 0;
77
+$sort = getRequest('sort', 'int') ?? 0;
78
+$generatedforR = getRequest('generatedfor', 'safe_text') ?? 'user';
79
+$token = getRequest('token', 'safe_text');
80 80
 
81 81
 
82 82
 switch ($action) {
Please login to merge, or discard this patch.
devices/apple_mobileconfig/mobileconfigSuperclass.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
       <key>PayloadIdentifier</key>
73 73
          <string>" . self::$iPhonePayloadPrefix . ".$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile.$this->lang</string>
74 74
       <key>PayloadOrganization</key>
75
-         <string>" . htmlspecialchars(iconv("UTF-8", "UTF-8//IGNORE", $this->attributes['general:instname'][0]), ENT_XML1, 'UTF-8') . ( $this->attributes['internal:profile_count'][0] > 1 ? " (" . htmlspecialchars(iconv("UTF-8", "UTF-8//IGNORE", $this->attributes['profile:name'][0]), ENT_XML1, 'UTF-8') . ")" : "") . "</string>
75
+         <string>" . htmlspecialchars(iconv("UTF-8", "UTF-8//IGNORE", $this->attributes['general:instname'][0]), ENT_XML1, 'UTF-8') . ($this->attributes['internal:profile_count'][0] > 1 ? " (" . htmlspecialchars(iconv("UTF-8", "UTF-8//IGNORE", $this->attributes['profile:name'][0]), ENT_XML1, 'UTF-8') . ")" : "") . "</string>
76 76
       <key>PayloadType</key>
77 77
          <string>Configuration</string>
78 78
       <key>PayloadUUID</key>
@@ -325,9 +325,9 @@  discard block
 block discarded – undo
325 325
         $retval .= "
326 326
                          </array>";
327 327
         if ($eapType['INNER'] == \core\common\EAP::NE_SILVERBULLET) {
328
-            $retval .= "<key>UserName</key><string>".$this->clientCert["username"]."</string>";
328
+            $retval .= "<key>UserName</key><string>" . $this->clientCert["username"] . "</string>";
329 329
         }
330
-        $retval .="
330
+        $retval .= "
331 331
                       <key>TTLSInnerAuthentication</key>
332 332
                          <string>" . ($eapType['INNER'] == \core\common\EAP::NONE ? "PAP" : "MSCHAPv2") . "</string>
333 333
                    </dict>";
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
                   <key>PayloadVersion</key>
505 505
                      <integer>1</integer>
506 506
                 </dict>",
507
-            "UUID" => $payloadUUID,];
507
+            "UUID" => $payloadUUID, ];
508 508
     }
509 509
 
510 510
     private function expiryBlock() {
Please login to merge, or discard this patch.
web/skins/eduroam2016/user/js/cat_js.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -208,13 +208,13 @@  discard block
 block discarded – undo
208 208
        if(j.local_url !== undefined && j.local_url) 
209 209
          txt = txt+'<tr><td><?php escaped_echo(_("WWW:")); ?></td><td><a href="'+j.local_url+'" target="_blank">'+j.local_url+'</a></td></tr>';
210 210
        if(j.local_email !== undefined && j.local_email) 
211
-         txt = txt+'<tr><td><?php escaped_echo(_("email:"));?></td><td><a href=mailto:"'+j.local_email+'">'+j.local_email+'</a></td></tr>';
211
+         txt = txt+'<tr><td><?php escaped_echo(_("email:")); ?></td><td><a href=mailto:"'+j.local_email+'">'+j.local_email+'</a></td></tr>';
212 212
        if(j.local_phone !== undefined && j.local_phone) 
213
-         txt = txt+'<tr><td><?php escaped_echo(_("tel:"));?></td><td>'+j.local_phone+'</td></tr>';
213
+         txt = txt+'<tr><td><?php escaped_echo(_("tel:")); ?></td><td>'+j.local_phone+'</td></tr>';
214 214
        if(txt) 
215
-         txt = "<table><tr><th colspan='2'><?php escaped_echo(sprintf(_("If you encounter problems, then you can obtain direct assistance from your %s at:"),$cat->nomenclature_inst)); ?></th></tr>"+txt+'</table>';
215
+         txt = "<table><tr><th colspan='2'><?php escaped_echo(sprintf(_("If you encounter problems, then you can obtain direct assistance from your %s at:"), $cat->nomenclature_inst)); ?></th></tr>"+txt+'</table>';
216 216
         else 
217
-         txt = "<table><tr><th colspan='2'><?php escaped_echo(sprintf(_("If you encounter problems you should ask for help at your %s"),$cat->nomenclature_inst)); ?>.</th></tr></table>";
217
+         txt = "<table><tr><th colspan='2'><?php escaped_echo(sprintf(_("If you encounter problems you should ask for help at your %s"), $cat->nomenclature_inst)); ?>.</th></tr></table>";
218 218
       $("#user_info").html(txt);
219 219
       $("#user_info").show();
220 220
       resetDevices();
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
           $("#g_"+v.id).addClass('alertButton');
228 228
           $("#cross_icon_"+v.id).show();
229 229
           $("#"+v.id).addClass('disabledDevice');
230
-          $("#download_button_header_"+v.id).html("<?php escaped_echo(sprintf(_("This device cannot be configured with settings provided by your %s"),$cat->nomenclature_inst))?>");
230
+          $("#download_button_header_"+v.id).html("<?php escaped_echo(sprintf(_("This device cannot be configured with settings provided by your %s"), $cat->nomenclature_inst))?>");
231 231
           $("#info_b_"+v.id+",#g_info_b_"+v.id).hide();
232 232
         } else  {
233 233
           if(v.status == -1)
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
           $("#"+v.id+",#g_"+v.id).addClass('additionalInfo');
240 240
           $("#"+v.id+",#g_"+v.id).click(function(event){
241 241
             i_div = $("#info_"+$(this).attr('id'));
242
-            t = "<?php escaped_echo(_("Your site administrator has specified that this device should be configured with resources located on a local page. When you click <b>Continue</b> this page will be opened in a new window/tab."))?>"+"<br><span class='redirect_link'><a href='"+v.redirect+"' target='_blank'><?php escaped_echo(_("Continue"));?></a></span>";
242
+            t = "<?php escaped_echo(_("Your site administrator has specified that this device should be configured with resources located on a local page. When you click <b>Continue</b> this page will be opened in a new window/tab."))?>"+"<br><span class='redirect_link'><a href='"+v.redirect+"' target='_blank'><?php escaped_echo(_("Continue")); ?></a></span>";
243 243
             i_div.html(t);
244 244
             $(".redirect_link").click(function(event) {
245 245
                i_div.hide();
@@ -247,13 +247,13 @@  discard block
 block discarded – undo
247 247
                
248 248
           });
249 249
         } else if(v.device_customtext != '0' || v.eap_customtext != '0' || v.message != '0' || v.status > 0) {
250
-          var continue_text = "<?php escaped_echo(_("Continue"));?>";
250
+          var continue_text = "<?php escaped_echo(_("Continue")); ?>";
251 251
           $("#"+v.id+",#g_"+v.id).addClass('additionalInfo');
252 252
           $("#"+v.id+",#g_"+v.id).click(function(event){
253 253
             i_div = $("#info_"+$(this).attr('id'));
254 254
             if(v.status > 0) {
255
-              t = "<?php escaped_echo(sprintf(_("This device cannot be configured with settings provided by your %s"),$cat->nomenclature_inst))?>";
256
-              continue_text = "<?php escaped_echo(_("Close"));?>";
255
+              t = "<?php escaped_echo(sprintf(_("This device cannot be configured with settings provided by your %s"), $cat->nomenclature_inst))?>";
256
+              continue_text = "<?php escaped_echo(_("Close")); ?>";
257 257
             } else {
258 258
             t = i_div.html();
259 259
             if(v.message != '0') {
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
   }
323 323
   
324 324
   function infoCAT(k,subK,title) {
325
-      $.post('<?php echo $Gui->skinObject->findResourceUrl("BASE","user/cat_info.php")?>', {page: k, subpage: subK, lang: lang}, function(data) {
325
+      $.post('<?php echo $Gui->skinObject->findResourceUrl("BASE", "user/cat_info.php")?>', {page: k, subpage: subK, lang: lang}, function(data) {
326 326
           showInfo(data, title)});
327 327
   }
328 328
 
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
    $("#loading_ico").css('left',x+'px');
332 332
    $("#loading_ico").attr('src','resources/images/icons/loading9.gif');
333 333
    $("#loading_ico").show();
334
-   window.location.replace("<?php echo $Gui->skinObject->findResourceUrl("BASE","admin/overview_user.php")?>?lang="+lang);
334
+   window.location.replace("<?php echo $Gui->skinObject->findResourceUrl("BASE", "admin/overview_user.php")?>?lang="+lang);
335 335
 }
336 336
 
337 337
 
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
     return(Math.round(windowWidth/2));
354 354
 }
355 355
 
356
-<?php if($idpId) { 
356
+<?php if ($idpId) { 
357 357
         print "front_page = 0;\n";
358 358
 } ?>
359 359
 
@@ -477,13 +477,13 @@  discard block
 block discarded – undo
477 477
    "overlay":true,"cookie":true,"type":false,
478 478
    "country":true,"location":true,
479 479
    "title":"<?php escaped_echo($cat->nomenclature_inst) ?>",
480
-   "subtitle":"<?php escaped_echo(sprintf(_("Select your <strong>%s<\/strong>"),$cat->nomenclature_inst)) ?>",
481
-   "textHelp": "<?php escaped_echo(sprintf(_("Help, my %s is not on the list"),$cat->nomenclature_inst)) ?>",
482
-   "textHelpMore": "<?php escaped_echo(sprintf(_("This system relies on information supplied by local %s administrators. If your %s is not on the list, then nag them to add information to the %s database."),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $cat->nomenclature_inst, CONFIG['APPEARANCE']['productname'])); ?>",
480
+   "subtitle":"<?php escaped_echo(sprintf(_("Select your <strong>%s<\/strong>"), $cat->nomenclature_inst)) ?>",
481
+   "textHelp": "<?php escaped_echo(sprintf(_("Help, my %s is not on the list"), $cat->nomenclature_inst)) ?>",
482
+   "textHelpMore": "<?php escaped_echo(sprintf(_("This system relies on information supplied by local %s administrators. If your %s is not on the list, then nag them to add information to the %s database."), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $cat->nomenclature_inst, CONFIG['APPEARANCE']['productname'])); ?>",
483 483
    "textLocateMe": "<?php escaped_echo(_("Locate me more accurately using HTML5 Geo-Location")) ?>",
484 484
    "textShowProviders": "<?php escaped_echo(sprintf(_("Show %ss in"), $cat->nomenclature_inst)) ?>",
485 485
    "textAllCountries": "<?php escaped_echo(_("all countries")) ?>",
486
-   "textSearch" : "<?php escaped_echo(sprintf(_("or search for an %s, in example Univerity of Oslo"),$cat->nomenclature_inst)) ?>",
486
+   "textSearch" : "<?php escaped_echo(sprintf(_("or search for an %s, in example Univerity of Oslo"), $cat->nomenclature_inst)) ?>",
487 487
    "textShowAllCountries": "<?php escaped_echo(_("show all countries")) ?>",
488 488
    "textLimited1" : "<?php escaped_echo(_("Results limited to"))?>",
489 489
    "textLimited2" : "<?php escaped_echo(_("entries - show more"))?>",
Please login to merge, or discard this patch.