View GitHub Repository CAT

Schedule Inspection
Subscribe
Passed
Push — master ( 87e53a...e7e40e )
by Tomasz
03:39
created
Status
Category
Toggle Patches
core/common/OutsideComm.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -172,9 +172,9 @@
 
 block discarded – undo
172 172 
                 $totalFailures = 0;
173 173 
                 foreach ($decoded_response['messages'] as $message) {
174 174 
                     if ($message['status'] == 0) {
175 
-                        $loggerInstance->debug(2, $message['message-id']. ": Success");
175 
+                        $loggerInstance->debug(2, $message['message-id'] . ": Success");
176 176 
                     } else {
177 
-                        $loggerInstance->debug(2, $message['message-id']. ": Failed (failure code = ".$message['status'].")");
177 
+                        $loggerInstance->debug(2, $message['message-id'] . ": Failed (failure code = " . $message['status'] . ")");
178 178 
                         $totalFailures++;
179 179 
                     }
180 180 
                 }
Please login to merge, or discard this patch.
core/diag/Telepath.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch 
@@ -120,6 +120,9 @@
 
 block discarded – undo
120 120 
         return Telepath::STATUS_GOOD;
121 121 
     }
122 122
123 
+    /**
124 
+     * @param string $homeFlr
125 
+     */
123 126 
     private function checkNROFlow($visitedFlr, $homeFlr) {
124 127 
         // TODO: this is a stub, need eduroam OT API to query the current server status
125 128 
         // APIQueryNRODirect($visitedFlr, $homeFlr);
Please login to merge, or discard this patch.
web/skins/classic/basic.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -142,7 +142,7 @@  discard block
 
 block discarded – undo
142 142 
     public function listIdPs() {
143 143 
         $instList = $this->orderIdentityProviders($this->country->identifier);
144 144 
         $out = '';
145 
-        $out .= sprintf(_("Select your %s"), $this->nomenclature_inst );
145 
+        $out .= sprintf(_("Select your %s"), $this->nomenclature_inst);
146 146 
         $out .= '<select name="idp" onchange="submit_form(this)">';
147 147 
         if (!empty($instList)) {
148 148 
             if (!isset($this->idp)) {
 
@@ -236,7 +236,7 @@  discard block
 
 block discarded – undo
236 236 
                 }
237 237 
             }
238 238 
             $out .= '>' . $disp . '</option>';
239 
-            $deviceRedirects .= 'redirects[' . $iterator . '] = ' . ( $oneDevice['redirect'] ? 1 : 0 ) . ';';
239 
+            $deviceRedirects .= 'redirects[' . $iterator . '] = ' . ($oneDevice['redirect'] ? 1 : 0) . ';';
240 240 
             $iterator++;
241 241 
         }
242 242 
         $out .= '</select>';
 
@@ -430,7 +430,7 @@  discard block
 
 block discarded – undo
430 430 
         </script>
431 431 
     </head>
432 432 
     <body style="">
433 
-        <?php print '<div id="motd">' . ( isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp' ) . '</div>'; ?>
433 
+        <?php print '<div id="motd">' . (isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp') . '</div>'; ?>
434 434 
         <form name="my_form" method="POST" action="<?php echo $_SERVER['SCRIPT_NAME'] ?>" accept-charset='UTF-8'>
435 435 
             <img src="<?php echo $skinObject->findResourceUrl("IMAGES", "consortium_logo.png"); ?>" style="width: 20%; padding-right:20px; padding-top:0px; float:right" alt="logo" />
436 436 
             <?php
Please login to merge, or discard this patch.
web/admin/edit_federation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -40,7 +40,7 @@  discard block
 
 block discarded – undo
40 40 
         ?>
41 41 
     </h1>
42 42 
     <div class='infobox'>
43 
-        <h2><?php echo sprintf(_("%s Properties"),$uiElements->nomenclature_fed); ?></h2>
43 
+        <h2><?php echo sprintf(_("%s Properties"), $uiElements->nomenclature_fed); ?></h2>
44 44 
         <table>
45 45 
             <tr>
46 46 
                 <td><?php echo _("Country:"); ?></td>
 
@@ -57,7 +57,7 @@  discard block
 
 block discarded – undo
57 57 
               <input type='hidden' name='MAX_FILE_SIZE' value='" . CONFIG['MAX_UPLOAD_SIZE'] . "'>";
58 58 
     ?>
59 59 
     <fieldset class="option_container">
60 
-        <legend><strong><?php echo sprintf(_("%s Properties"),$uiElements->nomenclature_fed); ?></strong></legend>
60 
+        <legend><strong><?php echo sprintf(_("%s Properties"), $uiElements->nomenclature_fed); ?></strong></legend>
61 61 
         <?php
62 62 
         $optionDisplay = new \web\lib\admin\OptionDisplay($fed_options, "FED");
63 63 
         echo $optionDisplay->prefilledOptionTable("fed");
Please login to merge, or discard this patch.
web/lib/admin/GeoWidget.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -37,7 +37,7 @@
 
 block discarded – undo
37 37 
      */
38 38 
     public function insertInHead($inst_country, $inst_name) {
39 39 
         $cat = new \core\CAT();
40 
-        return "<script type='text/javascript' src='https://maps.googleapis.com/maps/api/js?key=".CONFIG['APPEARANCE']['google_maps_api_key']."'></script>
40 
+        return "<script type='text/javascript' src='https://maps.googleapis.com/maps/api/js?key=" . CONFIG['APPEARANCE']['google_maps_api_key'] . "'></script>
41 41 
     <script type='text/javascript'>
42 42 
         // some global variables;
43 43 
         var center_lat=49.6114885608729;
Please login to merge, or discard this patch.
web/admin/edit_idp_result.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -90,7 +90,7 @@
 
 block discarded – undo
90 90
91 91 
 if (isset(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) && count(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) > 0) {
92 92 
     foreach (CONFIG_CONFASSISTANT['CONSORTIUM']['ssid'] as $ssidname) {
93 
-        $ssids[] = $ssidname . " " . (isset(CONFIG_CONFASSISTANT['CONSORTIUM']['tkipsupport']) && CONFIG_CONFASSISTANT['CONSORTIUM']['tkipsupport'] === TRUE ? _("(WPA2/AES and WPA/TKIP)") : _("(WPA2/AES)") );
93 
+        $ssids[] = $ssidname . " " . (isset(CONFIG_CONFASSISTANT['CONSORTIUM']['tkipsupport']) && CONFIG_CONFASSISTANT['CONSORTIUM']['tkipsupport'] === TRUE ? _("(WPA2/AES and WPA/TKIP)") : _("(WPA2/AES)"));
94 94 
     }
95 95 
 }
96 96
Please login to merge, or discard this patch.
web/user/tou.inc.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -11,7 +11,7 @@  discard block
 
 block discarded – undo
11 11 
 /*
12 12 
 */
13 13
14 
-        $Tou =  [
14 
+        $Tou = [
15 15 
     'title' => _("Terms of Use"),
16 16 
     'short' => "<p>The purpose of this service is to make eduroam configuration easier for end users and eduroam
17 17 
 Identity Providers by making available customised and securely configured eduroam installers.</p>
 
@@ -49,7 +49,7 @@  discard block
 
 block discarded – undo
49 49 
     they are from the same user group. You are not allowed to share them to an unlimited
50 50 
     audience (e.g. on a publicly accessible web server).</li>
51 51 
 <li>If You are an eduroam Identity Provider administrator, you are allowed to download and pass on the Installers to
52 
-your own ".CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution']." end users, e.g. on the support web pages of your ".CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution'].", on Welcome Package CDs or USB sticks, etc.</li>
52 
+your own ".CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution'] . " end users, e.g. on the support web pages of your " . CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution'] . ", on Welcome Package CDs or USB sticks, etc.</li>
53 53 
 <li>If You are a third-party not affiliated with eduroam, you are only allowed to download and pass on
54 54 
 the Metadata and/or the Installers after having received written permission by the eduroam Operations team.</li>
55 55 
 </ul>
Please login to merge, or discard this patch.
web/user/tou.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -52,7 +52,7 @@
 
 block discarded – undo
52 52 
     they are from the same user group. You are not allowed to share them to an unlimited
53 53 
     audience (e.g. on a publicly accessible web server).</li>
54 54 
 <li>If You are an eduroam Identity Provider administrator, you are allowed to download and pass on the Installers to
55 
-your own <?php echo CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution'];?> end users, e.g. on the support web pages of your <?php echo CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution'];?>, on Welcome Package CDs or USB sticks, etc.</li>
55 
+your own <?php echo CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution']; ?> end users, e.g. on the support web pages of your <?php echo CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution']; ?>, on Welcome Package CDs or USB sticks, etc.</li>
56 56 
 <li>If You are a third-party not affiliated with eduroam, you are only allowed to download and pass on
57 57 
 the Metadata and/or the Installers after having received written permission by the eduroam Operations team.</li>
58 58 
 </ul>
Please login to merge, or discard this patch.
utils/notify_invitation_expiry.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -44,7 +44,7 @@  discard block
 
 block discarded – undo
44 44 
     $admins = $this_fed->listFederationAdmins();
45 45 
     $mailtext = "Hello,
46 46
47 
-invitation tokens for the following new ". CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution'] ." have recently expired:
47 
+invitation tokens for the following new ". CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution'] . " have recently expired:
48 48
49 49 
 ";
50 50 
     foreach ($listofinstnames as $instname) {
 
@@ -54,7 +54,7 @@  discard block
 
 block discarded – undo
54 54 
     if ($numberofexistingidps > 0) {
55 55 
         $mailtext .= "
56 56
57 
-Additionally, $numberofexistingidps invitations for an existing ". CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution']." have expired.
57 
+Additionally, $numberofexistingidps invitations for an existing " . CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_institution'] . " have expired.
58 58 
         ";
59 59 
     }
60 60 
     $mailtext .= "
Please login to merge, or discard this patch.