Passed
Push — release_2_1 ( 81e271...fc59fc )
by Tomasz
12:32
created
web/admin/inc/sendinvite.inc.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  *          <base_url>/copyright.php after deploying the software
21 21
  */
22 22
 
23
-require_once dirname(dirname(dirname(__DIR__))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(__DIR__)))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $auth->authenticate();
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
         $idp = $validator->existingIdP($_GET['inst_id']);
103 103
         // editing IdPs is done from within the popup. When we're done, send the 
104 104
         // user back to the popup (append the result of the operation later)
105
-        $redirectDestination = "manageAdmins.inc.php?inst_id=" . $idp->identifier . "&";
105
+        $redirectDestination = "manageAdmins.inc.php?inst_id=".$idp->identifier."&";
106 106
         if (count($validAddresses) == 0) {
107
-            header("Location: $redirectDestination" . "invitation=INVALIDSYNTAX");
107
+            header("Location: $redirectDestination"."invitation=INVALIDSYNTAX");
108 108
             exit(1);
109 109
         }
110 110
         // is the user primary admin of this IdP?
@@ -113,13 +113,13 @@  discard block
 block discarded – undo
113 113
         $fedadmin = $userObject->isFederationAdmin($idp->federation);
114 114
         // check if he is either one, if not, complain
115 115
         if (!$is_owner && !$fedadmin) {
116
-            echo "<p>" . sprintf(_("Something's wrong... you are a %s admin, but not for the %s the requested %s belongs to!"), $uiElements->nomenclatureFed, $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant) . "</p>";
116
+            echo "<p>".sprintf(_("Something's wrong... you are a %s admin, but not for the %s the requested %s belongs to!"), $uiElements->nomenclatureFed, $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant)."</p>";
117 117
             exit(1);
118 118
         }
119 119
 
120 120
         $prettyprintname = $idp->name;
121 121
         $newtokens = $mgmt->createTokens($fedadmin, $validAddresses, $idp);
122
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP " . $idp->identifier . " - Token created for " . implode(",", $validAddresses));
122
+        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP ".$idp->identifier." - Token created for ".implode(",", $validAddresses));
123 123
         $introtext = "CO-ADMIN";
124 124
         $participant_type = $idp->type;
125 125
         break;
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
         $participant_type = $validator->partType($_POST['participant_type']);
136 136
         $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($newcountry);
137 137
         if ($new_idp_authorized_fedadmin !== TRUE) {
138
-            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureParticipant . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
138
+            throw new Exception("Something's wrong... you want to create a new ".$uiElements->nomenclatureParticipant.", but are not a ".$uiElements->nomenclatureFed." admin for the ".$uiElements->nomenclatureFed." it should be in!");
139 139
         }
140 140
         $federation = $validator->existingFederation($newcountry);
141 141
         $prettyprintname = $newinstname;
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
         // send the user back to his federation overview page, append the result of the operation later
144 144
         // do the token creation magic
145 145
         $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $newinstname, 0, $newcountry, $participant_type);
146
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "ORG FUTURE  - Token created for $participant_type " . implode(",", $validAddresses));
146
+        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "ORG FUTURE  - Token created for $participant_type ".implode(",", $validAddresses));
147 147
         break;
148 148
     case OPERATION_MODE_NEWFROMDB:
149 149
         $redirectDestination = "../overview_federation.php?";
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
         $extinfo = $catInstance->getExternalDBEntityDetails($newexternalid);
157 157
         $new_idp_authorized_fedadmin = $userObject->isFederationAdmin($extinfo['country']);
158 158
         if ($new_idp_authorized_fedadmin !== TRUE) {
159
-            throw new Exception("Something's wrong... you want to create a new " . $uiElements->nomenclatureParticipant . ", but are not a " . $uiElements->nomenclatureFed . " admin for the " . $uiElements->nomenclatureFed . " it should be in!");
159
+            throw new Exception("Something's wrong... you want to create a new ".$uiElements->nomenclatureParticipant.", but are not a ".$uiElements->nomenclatureFed." admin for the ".$uiElements->nomenclatureFed." it should be in!");
160 160
         }
161 161
         $federation = $validator->existingFederation($extinfo['country']);
162 162
         $newcountry = $extinfo['country'];
@@ -180,14 +180,14 @@  discard block
 block discarded – undo
180 180
         $introtext = "EXISTING-FED";
181 181
         // do the token creation magic
182 182
         $newtokens = $mgmt->createTokens(TRUE, $validAddresses, $prettyprintname, $newexternalid);
183
-        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP FUTURE  - Token created for " . implode(",", $validAddresses));
183
+        $loggerInstance->writeAudit($_SESSION['user'], "NEW", "IdP FUTURE  - Token created for ".implode(",", $validAddresses));
184 184
         break;
185 185
     default: // includes OPERATION_MODE_INVALID
186 186
         // second param is TRUE, so the variable *will* contain a string
187 187
         // i.e. ignore Scrutinizer type warning later
188 188
         $wrongcontent = print_r($_POST, TRUE);
189 189
         echo "<pre>Wrong parameters in POST:
190
-" . htmlspecialchars(/** @scrutinizer ignore-type */ $wrongcontent) . "
190
+" . htmlspecialchars(/** @scrutinizer ignore-type */ $wrongcontent)."
191 191
 </pre>";
192 192
         exit(1);
193 193
 }
@@ -212,14 +212,14 @@  discard block
 block discarded – undo
212 212
 }
213 213
 
214 214
 if (count($status) == 0) {
215
-    header("Location: $redirectDestination" . "invitation=FAILURE");
215
+    header("Location: $redirectDestination"."invitation=FAILURE");
216 216
     exit;
217 217
 }
218 218
 $finalDestParams = "invitation=SUCCESS";
219 219
 if (count($status) < count($totalSegments)) { // only a subset of mails was sent, update status
220 220
     $finalDestParams = "invitation=PARTIAL";
221 221
 }
222
-$finalDestParams .= "&successcount=" . count($status);
222
+$finalDestParams .= "&successcount=".count($status);
223 223
 if ($allEncrypted === TRUE) {
224 224
     $finalDestParams .= "&transportsecurity=ENCRYPTED";
225 225
 } elseif ($allClear === TRUE) {
@@ -228,4 +228,4 @@  discard block
 block discarded – undo
228 228
     $finalDestParams .= "&transportsecurity=PARTIAL";
229 229
 }
230 230
 
231
-header("Location: $redirectDestination" . $finalDestParams);
231
+header("Location: $redirectDestination".$finalDestParams);
Please login to merge, or discard this patch.
web/admin/inc/manageDBLink.inc.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  */
21 21
 ?>
22 22
 <?php
23
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $auth->authenticate();
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
 // if we have a pushed close button, submit attributes and send user back to the overview page
37 37
 // if external DB sync is disabled globally, the user never gets to this page. If he came here *anyway* -> send him back immediately.
38
-if ((isset($_POST['submitbutton']) && $_POST['submitbutton'] == web\lib\common\FormElements::BUTTON_CLOSE ) || \config\Master::DB['enforce-external-sync'] == FALSE) {
38
+if ((isset($_POST['submitbutton']) && $_POST['submitbutton'] == web\lib\common\FormElements::BUTTON_CLOSE) || \config\Master::DB['enforce-external-sync'] == FALSE) {
39 39
     header("Location: ../overview_federation.php");
40 40
     exit;
41 41
 }
@@ -92,9 +92,9 @@  discard block
 block discarded – undo
92 92
     $cat = new \core\CAT();
93 93
     switch ($my_inst->getExternalDBSyncState()) {
94 94
         case \core\IdP::EXTERNAL_DB_SYNCSTATE_SYNCED:
95
-            printf(_("This %s is linked to the %s database."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name']) . "</p>";
96
-            echo "<p>" . sprintf(_("The following information about the IdP is stored in the %s DB and %s DB:"), \config\Master::APPEARANCE['productname'], \config\ConfAssistant::CONSORTIUM['display_name']) . "</p>";
97
-            echo "<table><tr><td>" . sprintf(_("Information in <strong>%s Database</strong>"), \config\Master::APPEARANCE['productname']) . "</td><td>" . sprintf(_("Information in <strong>%s Database</strong>"), \config\ConfAssistant::CONSORTIUM['display_name']) . "</td></tr>";
95
+            printf(_("This %s is linked to the %s database."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name'])."</p>";
96
+            echo "<p>".sprintf(_("The following information about the IdP is stored in the %s DB and %s DB:"), \config\Master::APPEARANCE['productname'], \config\ConfAssistant::CONSORTIUM['display_name'])."</p>";
97
+            echo "<table><tr><td>".sprintf(_("Information in <strong>%s Database</strong>"), \config\Master::APPEARANCE['productname'])."</td><td>".sprintf(_("Information in <strong>%s Database</strong>"), \config\ConfAssistant::CONSORTIUM['display_name'])."</td></tr>";
98 98
             echo "<tr><td>";
99 99
             // left-hand side: CAT DB
100 100
             echo "<table>";
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
                 } else {
107 107
                     $language = \config\Master::LANGUAGES[$name['lang']]['display'] ?? "(unsupported language)";
108 108
                 }
109
-                echo "<tr><td>" . sprintf(_("%s Name (%s)"), $uiElements->nomenclatureParticipant, $language) . "</td><td>" . $name['value'] . "</td></tr>";
109
+                echo "<tr><td>".sprintf(_("%s Name (%s)"), $uiElements->nomenclatureParticipant, $language)."</td><td>".$name['value']."</td></tr>";
110 110
             }
111 111
 
112 112
             $admins = $my_inst->listOwners();
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
                 if (count($username) == 0) {
118 118
                     $username[0]['value'] = _("Unnamed User");
119 119
                 }
120
-                echo "<tr><td>" . _("Administrator [invited as]") . "</td><td>" . $username[0]['value'] . " [" . $admin['MAIL'] . "]</td></tr>";
120
+                echo "<tr><td>"._("Administrator [invited as]")."</td><td>".$username[0]['value']." [".$admin['MAIL']."]</td></tr>";
121 121
             }
122 122
             echo "</table>";
123 123
             // end of left-hand side
@@ -125,38 +125,38 @@  discard block
 block discarded – undo
125 125
             // right-hand side: external DB
126 126
             $externalid = $my_inst->getExternalDBId();
127 127
             if (is_bool($externalid)) { // we are in SYNCED state so this cannot happen
128
-                throw new Exception("We are in SYNCSTATE_SYNCED but still there is no external DB Id available for the " . $uiElements->nomenclatureParticipant . "!");
128
+                throw new Exception("We are in SYNCSTATE_SYNCED but still there is no external DB Id available for the ".$uiElements->nomenclatureParticipant."!");
129 129
             }
130 130
 
131 131
             $extinfo = $cat->getExternalDBEntityDetails($externalid);
132 132
 
133 133
             echo "<table>";
134 134
             foreach ($extinfo['names'] as $lang => $name) {
135
-                echo "<tr><td>" . sprintf(_("%s Name (%s)"), $uiElements->nomenclatureParticipant, $lang) . "</td><td>$name</td>";
135
+                echo "<tr><td>".sprintf(_("%s Name (%s)"), $uiElements->nomenclatureParticipant, $lang)."</td><td>$name</td>";
136 136
             }
137 137
             foreach ($extinfo['admins'] as $number => $admin_details) {
138
-                echo "<tr><td>" . _("Administrator email") . "</td><td>" . $admin_details['email'] . "</td></tr>";
138
+                echo "<tr><td>"._("Administrator email")."</td><td>".$admin_details['email']."</td></tr>";
139 139
             }
140 140
             echo "</table>";
141 141
             // end of right-hand side
142 142
             echo "</td></tr></table>";
143
-            echo "<p>" . _("If this mapping is not correct any more, you can remove the link:") . " ";
143
+            echo "<p>"._("If this mapping is not correct any more, you can remove the link:")." ";
144 144
             echo "<form name='form-unlink-inst' action='inc/manageDBLink.inc.php?inst_id=$my_inst->identifier' method='post' accept-charset='UTF-8'>";
145
-            echo "<button type='submit' class='delete' name='submitbutton' id='submit' value='" . web\lib\common\FormElements::BUTTON_DELETE . "'>" . _("Unlink") . "</button></form>";
145
+            echo "<button type='submit' class='delete' name='submitbutton' id='submit' value='".web\lib\common\FormElements::BUTTON_DELETE."'>"._("Unlink")."</button></form>";
146 146
             break;
147 147
         case \core\IdP::EXTERNAL_DB_SYNCSTATE_NOT_SYNCED:
148 148
             $temparray = [];
149
-            printf(_("This %s is not yet linked to the %s database."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name']) . " ";
150
-            echo "<strong>" . _("This means that its profiles are not made available on the user download page.") . "</strong> ";
149
+            printf(_("This %s is not yet linked to the %s database."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name'])." ";
150
+            echo "<strong>"._("This means that its profiles are not made available on the user download page.")."</strong> ";
151 151
             printf(_("You can link it to the %s database below."), \config\ConfAssistant::CONSORTIUM['display_name']);
152 152
             $candidates = $my_inst->getExternalDBSyncCandidates($my_inst->type);
153 153
             echo "<br/><form name='form-link-inst' action='inc/manageDBLink.inc.php?inst_id=$my_inst->identifier' method='post' accept-charset='UTF-8'>";
154
-            printf(_("Please select an entity from the %s DB which corresponds to this CAT %s."), \config\ConfAssistant::CONSORTIUM['display_name'], $uiElements->nomenclatureParticipant) . " ";
154
+            printf(_("Please select an entity from the %s DB which corresponds to this CAT %s."), \config\ConfAssistant::CONSORTIUM['display_name'], $uiElements->nomenclatureParticipant)." ";
155 155
             if (count($candidates) > 0) {
156 156
                 printf(_("Particularly promising entries (names in CAT and %s DB are a 100%% match) are on top of the list."), \config\ConfAssistant::CONSORTIUM['display_name']);
157 157
             }
158 158
             echo "<table>";
159
-            echo "<tr><th>" . _("Link to this entity?") . "</th><th>" . sprintf(_("%s Name"), $uiElements->nomenclatureParticipant) . "</th><th>" . _("Administrators") . "</th></tr>";
159
+            echo "<tr><th>"._("Link to this entity?")."</th><th>".sprintf(_("%s Name"), $uiElements->nomenclatureParticipant)."</th><th>"._("Administrators")."</th></tr>";
160 160
 
161 161
             foreach ($candidates as $candidate) {
162 162
                 $info = $cat->getExternalDBEntityDetails($candidate);
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
                 }
167 167
                 echo "</td><td>";
168 168
                 foreach ($info['admins'] as $number => $admin_details) {
169
-                    echo "[E-Mail] " . $admin_details['email'] . "<br/>";
169
+                    echo "[E-Mail] ".$admin_details['email']."<br/>";
170 170
                 }
171 171
                 echo "</td></tr>";
172 172
                 $temparray[] = $candidate;
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
             $buffer = "";
179 179
 
180 180
             foreach ($unmappedentities as $v) {
181
-                $buffer .= "<option value='" . $v['ID'] . "'>[ID " . $v['ID'] . "] " . $v['name'] . "</option>";
181
+                $buffer .= "<option value='".$v['ID']."'>[ID ".$v['ID']."] ".$v['name']."</option>";
182 182
             }
183 183
 
184 184
             if ($buffer != "") {
@@ -189,9 +189,9 @@  discard block
 block discarded – undo
189 189
             }
190 190
             // issue a big red warning if there are no link candidates at all in the federation
191 191
             if (empty($buffer) && empty($candidates)) {
192
-                echo "<tr><td style='color:#ff0000' colspan='2'>" . sprintf(_('There is no single unmapped %s in the external database for this %s!'), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed) . "</td></tr>";
192
+                echo "<tr><td style='color:#ff0000' colspan='2'>".sprintf(_('There is no single unmapped %s in the external database for this %s!'), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed)."</td></tr>";
193 193
             }
194
-            echo "</table><button type='submit' name='submitbutton' id='submit' value='" . web\lib\common\FormElements::BUTTON_SAVE . "' disabled >" . _("Create Link") . "</button></form>";
194
+            echo "</table><button type='submit' name='submitbutton' id='submit' value='".web\lib\common\FormElements::BUTTON_SAVE."' disabled >"._("Create Link")."</button></form>";
195 195
             break;
196 196
         default:
197 197
     }
Please login to merge, or discard this patch.
web/admin/inc/manageNewInst.inc.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  */
21 21
 ?>
22 22
 <?php
23
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $uiElements = new \web\lib\admin\UIElements();
@@ -57,30 +57,30 @@  discard block
 block discarded – undo
57 57
 <?php
58 58
 echo sprintf(_("On this page, you can add a new %s to your %s. Please fill out the form below to send out an email invitation to the new %s administrator."), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant);
59 59
 if (\config\Master::DB['enforce-external-sync']) {
60
-    echo "<p>" . sprintf(_("You can either register a known %s (as defined in the %s database) or create a totally new %s."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name'], $uiElements->nomenclatureParticipant) . "</p>";
61
-    echo "<p>" . sprintf(_("The latter one is typically for an %s which is yet in a testing phase and therefore doesn't appear in the %s database yet."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name']) . "</p>";    
60
+    echo "<p>".sprintf(_("You can either register a known %s (as defined in the %s database) or create a totally new %s."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name'], $uiElements->nomenclatureParticipant)."</p>";
61
+    echo "<p>".sprintf(_("The latter one is typically for an %s which is yet in a testing phase and therefore doesn't appear in the %s database yet."), $uiElements->nomenclatureParticipant, \config\ConfAssistant::CONSORTIUM['display_name'])."</p>";    
62 62
 }
63 63
 ?>
64 64
 <hr/>
65 65
 <img alt='Loading ...' src='../resources/images/icons/loading51.gif' id='spin' style='position:absolute;left: 50%; top: 50%; transform: translate(-100px, -50px); display:none;'>
66 66
 <form name='sendinvite' action='inc/sendinvite.inc.php' method='post' accept-charset='UTF-8'>
67 67
     <table>
68
-            <caption><?php echo _("Invitation Details");?></caption>
68
+            <caption><?php echo _("Invitation Details"); ?></caption>
69 69
             <tr>
70
-                <th class="wai-invisible" scope="col"><?php echo _("From database or ad-hoc?");?></th>
71
-                <th class="wai-invisible" scope="col"><?php echo _("Name");?></th>
72
-                <th class="wai-invisible" scope="col"><?php echo _("Type");?></th>
73
-                <th class="wai-invisible" scope="col"><?php echo _("Country");?></th>
70
+                <th class="wai-invisible" scope="col"><?php echo _("From database or ad-hoc?"); ?></th>
71
+                <th class="wai-invisible" scope="col"><?php echo _("Name"); ?></th>
72
+                <th class="wai-invisible" scope="col"><?php echo _("Type"); ?></th>
73
+                <th class="wai-invisible" scope="col"><?php echo _("Country"); ?></th>
74 74
             </tr>
75 75
         <?php
76 76
         if (\config\Master::DB['enforce-external-sync']) {
77 77
             echo "<tr><td>
78
-                <input type='radio' name='creation' value='existing'>" . sprintf(_("Existing %s:"), $uiElements->nomenclatureParticipant) . "</input>
78
+                <input type='radio' name='creation' value='existing'>" . sprintf(_("Existing %s:"), $uiElements->nomenclatureParticipant)."</input>
79 79
                      </td>";
80 80
 
81 81
             echo "<td colspan='3'>
82 82
                 <select id='externals' name='externals' onchange='document.sendinvite.creation[0].checked=true; document.sendinvite.mailaddr.value=this.options[this.selectedIndex].id;'>
83
-                    <option value='FREETEXT'>" . sprintf(_("--- select %s here ---"),$uiElements->nomenclatureParticipant) . "</option>";
83
+                    <option value='FREETEXT'>" . sprintf(_("--- select %s here ---"), $uiElements->nomenclatureParticipant)."</option>";
84 84
 
85 85
             foreach ($feds as $fed_value) {
86 86
                 $thefed = new \core\Federation(strtoupper($fed_value['value']));
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
                 $entities = $thefed->listExternalEntities(TRUE, NULL);
90 90
 
91 91
                 foreach ($entities as $v) {
92
-                    echo "<option id='" . $v['contactlist'] . "' value='" . $v['ID'] . "'>[" . $fed_value['value'] . "] " . $v['name'] . "</option>";
92
+                    echo "<option id='".$v['contactlist']."' value='".$v['ID']."'>[".$fed_value['value']."] ".$v['name']."</option>";
93 93
                 }
94 94
             }
95 95
 
@@ -98,16 +98,16 @@  discard block
 block discarded – undo
98 98
         ?>
99 99
         <tr>
100 100
             <td>
101
-                <input type='radio' name='creation' value='new'><?php echo sprintf(_("New %s"),$uiElements->nomenclatureParticipant); ?></input>
101
+                <input type='radio' name='creation' value='new'><?php echo sprintf(_("New %s"), $uiElements->nomenclatureParticipant); ?></input>
102 102
             </td>
103 103
             <td>
104 104
                 <?php echo _("Name"); ?><input type='text' size='30' id='name' name='name' onchange='document.sendinvite.creation[1].checked = true'/>
105 105
             </td>
106 106
             <td>
107 107
                 <select name="participant_type">
108
-                    <option value="IdPSP" selected><?php printf(_("%s and %s"),$uiElements->nomenclatureIdP, $uiElements->nomenclatureHotspot)?></option>
109
-                    <option value="IdP"><?php printf(_("%s"),$uiElements->nomenclatureIdP)?></option>
110
-                    <option value="SP"><?php printf(_("%s"),$uiElements->nomenclatureHotspot)?></option>
108
+                    <option value="IdPSP" selected><?php printf(_("%s and %s"), $uiElements->nomenclatureIdP, $uiElements->nomenclatureHotspot)?></option>
109
+                    <option value="IdP"><?php printf(_("%s"), $uiElements->nomenclatureIdP)?></option>
110
+                    <option value="SP"><?php printf(_("%s"), $uiElements->nomenclatureHotspot)?></option>
111 111
                 </select>
112 112
             </td>
113 113
             <td><?php echo $uiElements->nomenclatureFed; ?>
Please login to merge, or discard this patch.
web/admin/inc/manageAdmins.inc.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  */
21 21
 ?>
22 22
 <?php
23
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $languageInstance = new \core\common\Language();
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
                 $ownermgmt = new \core\UserManagement();
83 83
                 $ownermgmt->addAdminToIdp($my_inst, $_SESSION['user']);
84 84
             } else {
85
-                echo "Fatal Error: you wanted to take control over an " . \config\ConfAssistant::CONSORTIUM['nomenclature_participant'] . ", but are not a " . \config\ConfAssistant::CONSORTIUM['nomenclature_federation'] . " operator!";
85
+                echo "Fatal Error: you wanted to take control over an ".\config\ConfAssistant::CONSORTIUM['nomenclature_participant'].", but are not a ".\config\ConfAssistant::CONSORTIUM['nomenclature_federation']." operator!";
86 86
                 exit(1);
87 87
             }
88 88
             break;
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
                 default:
119 119
                     throw new Exception("Error: unknown encryption status of invitation!?!");
120 120
             }
121
-            echo $uiElements->boxRemark(ngettext("The invitation email was sent successfully.", "All invitation emails were sent successfully.", $counter) . " " . $cryptText, _("Sent successfully."));
121
+            echo $uiElements->boxRemark(ngettext("The invitation email was sent successfully.", "All invitation emails were sent successfully.", $counter)." ".$cryptText, _("Sent successfully."));
122 122
             break;
123 123
         case "FAILURE":
124 124
             echo $uiElements->boxError(_("No invitation email could be sent!"), _("Sending failure!"));
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
                 default:
139 139
                     throw new Exception("Error: unknown encryption status of invitation!?!");
140 140
             }
141
-            echo $uiElements->boxWarning(sprintf(_("Some invitation emails were sent successfully (%s in total), the others failed."), $counter) . " " . $cryptText, _("Partial success."));
141
+            echo $uiElements->boxWarning(sprintf(_("Some invitation emails were sent successfully (%s in total), the others failed."), $counter)." ".$cryptText, _("Partial success."));
142 142
             break;
143 143
         case "INVALIDSYNTAX":
144 144
             echo $uiElements->boxError(_("The invitation email address was malformed, no invitation was sent!"), _("The invitation email address was malformed, no invitation was sent!"));
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
                 <?php echo $invite; ?>
191 191
             </td>
192 192
             <td>
193
-                <form action='inc/manageAdmins.inc.php?inst_id=<?php echo $my_inst->identifier ?>' method='post' <?php echo ( $oneowner['ID'] != $_SESSION['user'] ? "onsubmit='popupRedirectWindow(this); return false;'" : "" ); ?> accept-charset='UTF-8'>
193
+                <form action='inc/manageAdmins.inc.php?inst_id=<?php echo $my_inst->identifier ?>' method='post' <?php echo ($oneowner['ID'] != $_SESSION['user'] ? "onsubmit='popupRedirectWindow(this); return false;'" : ""); ?> accept-charset='UTF-8'>
194 194
                     <input type='hidden' name='admin_id' value='<?php echo $oneowner['ID']; ?>'></input>
195 195
                     <button type='submit' name='submitbutton' class='delete' value='<?php echo web\lib\common\FormElements::BUTTON_DELETE; ?>'><?php echo _("Delete Administrator") ?></button>
196 196
                 </form>
@@ -207,10 +207,10 @@  discard block
 block discarded – undo
207 207
 $loggerInstance = new \core\common\Logging();
208 208
 $loggerInstance->debug(4, "Displaying pending invitations for $my_inst->identifier.\n");
209 209
 if (count($pending_invites) > 0) {
210
-    echo "<strong>" . _("Pending invitations for this IdP") . "</strong>";
210
+    echo "<strong>"._("Pending invitations for this IdP")."</strong>";
211 211
     echo "<table>";
212 212
     foreach ($pending_invites as $invitee) {
213
-        echo "<tr><td>" . $invitee['mail'] . "</td><td>" . sprintf(_("(expires %s)"), $invitee['expiry']) . "</td></tr>";
213
+        echo "<tr><td>".$invitee['mail']."</td><td>".sprintf(_("(expires %s)"), $invitee['expiry'])."</td></tr>";
214 214
     }
215 215
     echo "</table>";
216 216
 }
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
 
233 233
     if (!$is_admin_himself) {
234 234
         echo "<form action='inc/manageAdmins.inc.php?inst_id=$my_inst->identifier' method='post' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'>
235
-    <button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_TAKECONTROL . "'>" . sprintf(_("Take control of this %s"), $uiElements->nomenclatureParticipant) . "</button>
235
+    <button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_TAKECONTROL."'>".sprintf(_("Take control of this %s"), $uiElements->nomenclatureParticipant)."</button>
236 236
 </form>";
237 237
     }
238 238
 }
Please login to merge, or discard this patch.
web/admin/action_enrollment.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 ?>
31 31
 <?php
32 32
 
33
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
33
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
34 34
 
35 35
 $auth = new \web\lib\admin\Authentication();
36 36
 $deco = new \web\lib\admin\PageDecoration();
@@ -41,11 +41,11 @@  discard block
 block discarded – undo
41 41
 $auth->authenticate();
42 42
 
43 43
 if (!isset($_GET['token'])) {
44
-    $elements->errorPage(_("Error creating new IdP binding!"),_("This page needs to be called with a valid invitation token!"));
44
+    $elements->errorPage(_("Error creating new IdP binding!"), _("This page needs to be called with a valid invitation token!"));
45 45
 }
46 46
 
47 47
 if (\config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL && $_GET['token'] == "SELF-REGISTER") {
48
-    $elements->errorPage(_("Error creating new IdP binding!"),_("You tried to register in self-service, but this deployment does not allow self-service!"));
48
+    $elements->errorPage(_("Error creating new IdP binding!"), _("You tried to register in self-service, but this deployment does not allow self-service!"));
49 49
 }
50 50
 
51 51
 switch ($_GET['token']) {
@@ -55,22 +55,22 @@  discard block
 block discarded – undo
55 55
         $federation = \config\ConfAssistant::CONSORTIUM['selfservice_registration'];
56 56
         break;
57 57
     default:
58
-        $token = $validator->token(filter_input(INPUT_GET,'token',FILTER_SANITIZE_STRING));
58
+        $token = $validator->token(filter_input(INPUT_GET, 'token', FILTER_SANITIZE_STRING));
59 59
         $checkval = $usermgmt->checkTokenValidity($token);
60 60
 }
61 61
 
62 62
 if ($checkval < 0) {
63 63
     echo $deco->pageheader(_("Error creating new IdP binding!"), "ADMIN-IDP");
64
-    echo "<h1>" . _("Error creating new IdP binding!") . "</h1>";
64
+    echo "<h1>"._("Error creating new IdP binding!")."</h1>";
65 65
     switch ($checkval) {
66 66
         case \core\UserManagement::TOKENSTATUS_FAIL_ALREADYCONSUMED:
67
-            echo "<p>" . sprintf(_("Sorry... this token has already been used. The %s is already created. If you got the invitation from a mailing list, probably someone else used it before you."), $elements->nomenclatureParticipant) . "</p>";
67
+            echo "<p>".sprintf(_("Sorry... this token has already been used. The %s is already created. If you got the invitation from a mailing list, probably someone else used it before you."), $elements->nomenclatureParticipant)."</p>";
68 68
             break;
69 69
         case \core\UserManagement::TOKENSTATUS_FAIL_EXPIRED:
70
-            echo "<p>" . sprintf(_("Sorry... this token has expired. Invitation tokens are valid for 24 hours. The %s administrator can create a new one for you."), $elements->nomenclatureFed) . "</p>";
70
+            echo "<p>".sprintf(_("Sorry... this token has expired. Invitation tokens are valid for 24 hours. The %s administrator can create a new one for you."), $elements->nomenclatureFed)."</p>";
71 71
             break;
72 72
         default:
73
-            echo "<p>" . _("Sorry... you have come to the enrollment page without a valid token. Are you a nasty person? If not, you should go to <a href='overview_user.php'>your profile page</a> instead.") . "</p>";
73
+            echo "<p>"._("Sorry... you have come to the enrollment page without a valid token. Are you a nasty person? If not, you should go to <a href='overview_user.php'>your profile page</a> instead.")."</p>";
74 74
     }
75 75
     echo $deco->footer();
76 76
     throw new Exception("Terminating because something is wrong with the token we received.");
@@ -85,12 +85,12 @@  discard block
 block discarded – undo
85 85
     case "SELF-REGISTER":
86 86
         $fed = new \core\Federation($federation);
87 87
         $newidp = new \core\IdP($fed->newIdP(core\IdP::TYPE_IDPSP, $user, "FED", "SELFSERVICE"));
88
-        $loggerInstance->writeAudit($user, "MOD", "IdP " . $newidp->identifier . " - selfservice registration");
88
+        $loggerInstance->writeAudit($user, "MOD", "IdP ".$newidp->identifier." - selfservice registration");
89 89
         break;
90 90
     default:
91 91
         $newidp = $usermgmt->createIdPFromToken($token, $user);
92 92
         $usermgmt->invalidateToken($token);
93
-        $loggerInstance->writeAudit($user, "MOD", "IdP " . $newidp->identifier . " - Token used and invalidated");
93
+        $loggerInstance->writeAudit($user, "MOD", "IdP ".$newidp->identifier." - Token used and invalidated");
94 94
         break;
95 95
 }
96 96
 
Please login to merge, or discard this patch.
utils/notify_invitation_expiry.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 // please run this as a cron job every hour
23 23
 
24
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
24
+require_once dirname(dirname(__FILE__))."/config/_config.php";
25 25
 
26 26
 // iterate through all federations and see if there are recently expired 
27 27
 // invitations for any of them
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     $admins = $this_fed->listFederationAdmins();
56 56
     $mailtext = "Hello,
57 57
 
58
-invitation tokens for the following new ". \config\ConfAssistant::CONSORTIUM['nomenclature_participant'] ." have recently expired:
58
+invitation tokens for the following new ". \config\ConfAssistant::CONSORTIUM['nomenclature_participant']." have recently expired:
59 59
 
60 60
 ";
61 61
     foreach ($listofinstnames as $instname) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     if ($numberofexistingidps > 0) {
66 66
         $mailtext .= "
67 67
 
68
-Additionally, $numberofexistingidps invitations for an existing ". \config\ConfAssistant::CONSORTIUM['nomenclature_participant']." have expired.
68
+Additionally, $numberofexistingidps invitations for an existing ".\config\ConfAssistant::CONSORTIUM['nomenclature_participant']." have expired.
69 69
         ";
70 70
     }
71 71
     $mailtext .= "
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
 Greetings,
75 75
 
76
-A humble " . \config\Master::APPEARANCE['productname'] . " cron job
76
+A humble " . \config\Master::APPEARANCE['productname']." cron job
77 77
 ";
78 78
 
79 79
     foreach ($admins as $admin) {
Please login to merge, or discard this patch.
web/admin/edit_participant_result.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  *          <base_url>/copyright.php after deploying the software
21 21
  */
22 22
 
23
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $loggerInstance = new \core\common\Logging();
@@ -33,15 +33,15 @@  discard block
 block discarded – undo
33 33
 $myInstOriginal = $validator->existingIdP($_GET['inst_id'], $_SESSION['user']);
34 34
 $instId = $myInstOriginal->identifier;
35 35
 
36
-$hello = _("To whom it may concern,") . "\n\n";
37
-$bye = _("This mail is merely a cross-check because these changes can be security-relevant. If the change was expected, you do not need to take any action.") . "\n\n" .
38
-        _("Greetings, ") . "\n\n" .
36
+$hello = _("To whom it may concern,")."\n\n";
37
+$bye = _("This mail is merely a cross-check because these changes can be security-relevant. If the change was expected, you do not need to take any action.")."\n\n".
38
+        _("Greetings, ")."\n\n".
39 39
         \config\Master::APPEARANCE['productname_long'];
40 40
 
41 41
 switch ($_POST['submitbutton']) {
42 42
     case web\lib\common\FormElements::BUTTON_DELETE:
43 43
         $myInstOriginal->destroy();
44
-        $loggerInstance->writeAudit($_SESSION['user'], "DEL", "IdP " . $instId);
44
+        $loggerInstance->writeAudit($_SESSION['user'], "DEL", "IdP ".$instId);
45 45
         header("Location: overview_user.php");
46 46
         exit;
47 47
     case web\lib\common\FormElements::BUTTON_FLUSH_AND_RESTART:
@@ -51,9 +51,9 @@  discard block
 block discarded – undo
51 51
         }
52 52
         // flush all IdP attributes and send user to creation wizard
53 53
         $myInstOriginal->flushAttributes();
54
-        $loggerInstance->writeAudit($_SESSION['user'], "DEL", "IdP starting over" . $instId);
55
-        $text = $hello .
56
-                sprintf(_("the %s %s / %s / (previously known as) '%s' has deleted all properties and is starting over freshly. This means that its not recognisable by its name any more, and it may assume a different name in the future. You will get another mail if and when the name change happens."), $ui->nomenclatureParticipant, strtoupper($myInstOriginal->federation), $myInstOriginal->identifier, $myInstOriginal->name) . "\n\n" .
54
+        $loggerInstance->writeAudit($_SESSION['user'], "DEL", "IdP starting over".$instId);
55
+        $text = $hello.
56
+                sprintf(_("the %s %s / %s / (previously known as) '%s' has deleted all properties and is starting over freshly. This means that its not recognisable by its name any more, and it may assume a different name in the future. You will get another mail if and when the name change happens."), $ui->nomenclatureParticipant, strtoupper($myInstOriginal->federation), $myInstOriginal->identifier, $myInstOriginal->name)."\n\n".
57 57
                 $bye;
58 58
         $fed = new core\Federation($myInstOriginal->federation);
59 59
         foreach ($fed->listFederationAdmins() as $id) {
@@ -72,19 +72,19 @@  discard block
 block discarded – undo
72 72
             exit(0);
73 73
         }
74 74
         $inst_name = $myInstOriginal->name;
75
-        echo "<h1>" . sprintf(_("Submitted attributes for IdP '%s'"), $inst_name) . "</h1>";
75
+        echo "<h1>".sprintf(_("Submitted attributes for IdP '%s'"), $inst_name)."</h1>";
76 76
         echo "<table>";
77 77
         echo $optionParser->processSubmittedFields($myInstOriginal, $_POST, $_FILES);
78 78
         echo "</table>";
79 79
 // delete cached logo, if present
80
-        $dir = ROOT . '/web/downloads/logos/';
81
-        $globResult = glob($dir . $myInstOriginal->identifier . "_*.png");
80
+        $dir = ROOT.'/web/downloads/logos/';
81
+        $globResult = glob($dir.$myInstOriginal->identifier."_*.png");
82 82
         if ($globResult === FALSE) { // we should catch the improbable error condition
83 83
             $globResult = [];
84 84
         }
85 85
         array_map('unlink', $globResult);
86 86
         $loggerInstance->debug(4, "UNLINK from $dir\n");
87
-        $loggerInstance->writeAudit($_SESSION['user'], "MOD", "IdP " . $myInstOriginal->identifier . " - attributes changed");
87
+        $loggerInstance->writeAudit($_SESSION['user'], "MOD", "IdP ".$myInstOriginal->identifier." - attributes changed");
88 88
 
89 89
 // re-instantiate ourselves... profiles need fresh data
90 90
         $myInstReinstantiated = $validator->existingIdP($_GET['inst_id'], $_SESSION['user']);
@@ -93,10 +93,10 @@  discard block
 block discarded – undo
93 93
         if (count($significantChanges) > 0) {
94 94
             // send a notification/alert mail to someone we know is in charge
95 95
             /// were made to the *Identity Provider* *LU* / integer number of IdP / (previously known as) Name
96
-            $text = $hello . sprintf(_("significant changes were made to the %s %s / %s / (previously known as) '%s'."), $ui->nomenclatureParticipant, strtoupper($myInstOriginal->federation), $myInstOriginal->identifier, $myInstOriginal->name) . "\n\n";
96
+            $text = $hello.sprintf(_("significant changes were made to the %s %s / %s / (previously known as) '%s'."), $ui->nomenclatureParticipant, strtoupper($myInstOriginal->federation), $myInstOriginal->identifier, $myInstOriginal->name)."\n\n";
97 97
             if (isset($significantChanges[\core\IdP::INSTNAME_CHANGED])) {
98
-                $text .= sprintf(_("The %s has changed its name. The details are below:"), $ui->nomenclatureParticipant) . "\n\n";
99
-                $text .= $significantChanges[\core\IdP::INSTNAME_CHANGED] . "\n\n";
98
+                $text .= sprintf(_("The %s has changed its name. The details are below:"), $ui->nomenclatureParticipant)."\n\n";
99
+                $text .= $significantChanges[\core\IdP::INSTNAME_CHANGED]."\n\n";
100 100
             }
101 101
             $text .= $bye;
102 102
             // (currently, send hard-wired to NRO - future: for linked insts, check eduroam DBv2 and send to registered admins directly)
@@ -112,12 +112,12 @@  discard block
 block discarded – undo
112 112
 
113 113
         if (isset(\config\ConfAssistant::CONSORTIUM['ssid']) && count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0) {
114 114
             foreach (\config\ConfAssistant::CONSORTIUM['ssid'] as $ssidname) {
115
-                $ssids[] = $ssidname . " " . _("(WPA2/AES)");
115
+                $ssids[] = $ssidname." "._("(WPA2/AES)");
116 116
             }
117 117
         }
118 118
 
119 119
         foreach ($myInstReinstantiated->getAttributes("media:SSID") as $ssidname) {
120
-            $ssids[] = $ssidname['value'] . " " . _("(WPA2/AES)");
120
+            $ssids[] = $ssidname['value']." "._("(WPA2/AES)");
121 121
         }
122 122
 
123 123
         echo "<table>";
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         if (count($ssids) > 0) {
126 126
             $printedlist = "";
127 127
             foreach ($ssids as $names) {
128
-                $printedlist = $printedlist . "$names ";
128
+                $printedlist = $printedlist."$names ";
129 129
             }
130 130
             echo $uiElements->boxOkay(sprintf(_("Your installers will configure the following SSIDs: <strong>%s</strong>"), $printedlist), _("SSIDs configured"));
131 131
         }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
         $myfed = new \core\Federation($myInstReinstantiated->federation);
147 147
         $allow_sb = $myfed->getAttributes("fed:silverbullet");
148 148
         // only show IdP parts if fed has enabled hosted services && participant is an SP-type
149
-        if (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_SILVERBULLET'] == "LOCAL" && count($allow_sb) > 0 && preg_match("/IdP/", $myInstReinstantiated->type) ) {
149
+        if (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_SILVERBULLET'] == "LOCAL" && count($allow_sb) > 0 && preg_match("/IdP/", $myInstReinstantiated->type)) {
150 150
 // show the new profile jumpstart buttons only if we do not have any profile at all
151 151
             if (count($myInstReinstantiated->listProfiles()) == 0) {
152 152
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
                 // did we get an email address? then, show the silverbullet jumpstart button
155 155
                 // otherwise, issue a smartass comment
156 156
                 if (count($myInstReinstantiated->getAttributes("support:email")) > 0) {
157
-                    echo "<form method='post' action='edit_silverbullet.php?inst_id=$instId' accept-charset='UTF-8'><button type='submit'>" . sprintf(_("Continue to %s properties"), \core\ProfileSilverbullet::PRODUCTNAME) . "</button></form>";
157
+                    echo "<form method='post' action='edit_silverbullet.php?inst_id=$instId' accept-charset='UTF-8'><button type='submit'>".sprintf(_("Continue to %s properties"), \core\ProfileSilverbullet::PRODUCTNAME)."</button></form>";
158 158
                 } else {
159 159
                     echo "<table>";
160 160
                     echo $uiElements->boxError(sprintf(_("You did not submit an e-mail address. This is required for %s. Please go to the %s dashboard and edit your helpdesk settings to include a helpdesk e-mail address."), core\ProfileSilverbullet::PRODUCTNAME, $ui->nomenclatureParticipant), _("No support e-mail!"));
@@ -162,11 +162,11 @@  discard block
 block discarded – undo
162 162
                 }
163 163
 
164 164
                 if (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_RADIUS'] == "LOCAL") {
165
-                    echo "<br/><form method='post' action='edit_profile.php?inst_id=$instId' accept-charset='UTF-8'><button type='submit'>" . _("Continue to RADIUS/EAP profile definition") . "</button></form>";
165
+                    echo "<br/><form method='post' action='edit_profile.php?inst_id=$instId' accept-charset='UTF-8'><button type='submit'>"._("Continue to RADIUS/EAP profile definition")."</button></form>";
166 166
                 }
167 167
             }
168 168
         }
169
-        echo "<br/><form method='post' action='overview_org.php?inst_id=$instId' accept-charset='UTF-8'><button type='submit'>" . _("Continue to dashboard") . "</button></form>";
169
+        echo "<br/><form method='post' action='overview_org.php?inst_id=$instId' accept-charset='UTF-8'><button type='submit'>"._("Continue to dashboard")."</button></form>";
170 170
 
171 171
         break;
172 172
     default:
Please login to merge, or discard this patch.
core/IdPlist.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -330,7 +330,7 @@
 block discarded – undo
330 330
                 case 'device-specific:redirect':
331 331
                     $redirect = $opt[1];
332 332
                     if (!empty($profile->device_id)) {
333
-                        $redirect .= ':' . $profile->device_id;
333
+                        $redirect .= ':'.$profile->device_id;
334 334
                     }
335 335
                     break;
336 336
                 case 'profile:name': 
Please login to merge, or discard this patch.
devices/ms/DeviceVista7.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
                 $delProfiles[] = $ssid;
77 77
             }
78 78
             if ($cipher == 'TKIP') {
79
-                $delProfiles[] = $ssid . ' (TKIP)';
79
+                $delProfiles[] = $ssid.' (TKIP)';
80 80
             }
81 81
         }
82 82
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
             $iterator = 0;
87 87
             foreach ($allSSID as $ssid => $cipher) {
88 88
                 if ($cipher == 'TKIP') {
89
-                    $windowsProfile[$iterator] = $this->writeWLANprofile($ssid . ' (TKIP)', $ssid, 'WPA', 'TKIP', $eapConfig, $iterator);
89
+                    $windowsProfile[$iterator] = $this->writeWLANprofile($ssid.' (TKIP)', $ssid, 'WPA', 'TKIP', $eapConfig, $iterator);
90 90
                     $iterator++;
91 91
                 }
92 92
                 $windowsProfile[$iterator] = $this->writeWLANprofile($ssid, $ssid, 'WPA2', 'AES', $eapConfig, $iterator);
@@ -148,10 +148,10 @@  discard block
 block discarded – undo
148 148
         $profileFileCont = '<EAPConfig><EapHostConfig xmlns="http://www.microsoft.com/provisioning/EapHostConfig">
149 149
 <EapMethod>
150 150
 <Type xmlns="http://www.microsoft.com/provisioning/EapCommon">' .
151
-                $this->selectedEap["OUTER"] . '</Type>
151
+                $this->selectedEap["OUTER"].'</Type>
152 152
 <VendorId xmlns="http://www.microsoft.com/provisioning/EapCommon">0</VendorId>
153 153
 <VendorType xmlns="http://www.microsoft.com/provisioning/EapCommon">0</VendorType>
154
-<AuthorId xmlns="http://www.microsoft.com/provisioning/EapCommon">' . $authorId . '</AuthorId>
154
+<AuthorId xmlns="http://www.microsoft.com/provisioning/EapCommon">' . $authorId.'</AuthorId>
155 155
 </EapMethod>
156 156
 ';
157 157
 
@@ -164,9 +164,9 @@  discard block
 block discarded – undo
164 164
             $profileFileCont .= '
165 165
 <Config xmlns="http://www.microsoft.com/provisioning/EapHostConfig">
166 166
 <EAPIdentityProviderList xmlns="urn:ietf:params:xml:ns:yang:ietf-eap-metadata">
167
-<EAPIdentityProvider ID="' . $this->deviceUUID . '" namespace="urn:UUID">
167
+<EAPIdentityProvider ID="' . $this->deviceUUID.'" namespace="urn:UUID">
168 168
 <ProviderInfo>
169
-<DisplayName>' . $this->translateString($attr['general:instname'][0]) . '</DisplayName>
169
+<DisplayName>' . $this->translateString($attr['general:instname'][0]).'</DisplayName>
170 170
 </ProviderInfo>
171 171
 <AuthenticationMethods>
172 172
 <AuthenticationMethod>
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
                 if ($outerUser == '') {
179 179
                     $profileFileCont .= '<AnonymousIdentity>@</AnonymousIdentity>';
180 180
                 } else {
181
-                    $profileFileCont .= '<AnonymousIdentity>' . $outerUser . '@' . $realm . '</AnonymousIdentity>';
181
+                    $profileFileCont .= '<AnonymousIdentity>'.$outerUser.'@'.$realm.'</AnonymousIdentity>';
182 182
                 }
183 183
             }
184 184
             $profileFileCont .= '</ClientSideCredential>
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
             $profileFileCont .= '
197 197
 </ServerSideCredential>
198 198
 <InnerAuthenticationMethod>
199
-<NonEAPAuthMethod>' .$innerMethod. '</NonEAPAuthMethod>
199
+<NonEAPAuthMethod>' .$innerMethod.'</NonEAPAuthMethod>
200 200
 </InnerAuthenticationMethod>
201 201
 <VendorSpecific>
202 202
 <SessionResumption>false</SessionResumption>
@@ -221,11 +221,11 @@  discard block
 block discarded – undo
221 221
 </eapTls:CredentialsSource>
222 222
 <eapTls:ServerValidation>
223 223
 <eapTls:DisableUserPromptForServerValidation>true</eapTls:DisableUserPromptForServerValidation>
224
-<eapTls:ServerNames>' . $servers . '</eapTls:ServerNames>';
224
+<eapTls:ServerNames>' . $servers.'</eapTls:ServerNames>';
225 225
             if ($caArray) {
226 226
                 foreach ($caArray as $certAuthority) {
227 227
                     if ($certAuthority['root']) {
228
-                        $profileFileCont .= "<eapTls:TrustedRootCA>" . $certAuthority['sha1'] . "</eapTls:TrustedRootCA>\n";
228
+                        $profileFileCont .= "<eapTls:TrustedRootCA>".$certAuthority['sha1']."</eapTls:TrustedRootCA>\n";
229 229
                     }
230 230
                 }
231 231
             }
@@ -257,11 +257,11 @@  discard block
 block discarded – undo
257 257
 <msPeap:EapType>
258 258
 <msPeap:ServerValidation>
259 259
 <msPeap:DisableUserPromptForServerValidation>true</msPeap:DisableUserPromptForServerValidation> 
260
-<msPeap:ServerNames>' . $servers . '</msPeap:ServerNames>';
260
+<msPeap:ServerNames>' . $servers.'</msPeap:ServerNames>';
261 261
             if ($caArray) {
262 262
                 foreach ($caArray as $certAuthority) {
263 263
                     if ($certAuthority['root']) {
264
-                        $vistaExt .= "<msPeap:TrustedRootCA>" . $certAuthority['sha1'] . "</msPeap:TrustedRootCA>\n";
264
+                        $vistaExt .= "<msPeap:TrustedRootCA>".$certAuthority['sha1']."</msPeap:TrustedRootCA>\n";
265 265
                     }
266 266
                 }
267 267
             }
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
 <msChapV2:UseWinLogonCredentials>false</msChapV2:UseWinLogonCredentials> 
275 275
 </msChapV2:EapType>
276 276
 </baseEap:Eap>
277
-<msPeap:EnableQuarantineChecks>' . $nea . '</msPeap:EnableQuarantineChecks>
277
+<msPeap:EnableQuarantineChecks>' . $nea.'</msPeap:EnableQuarantineChecks>
278 278
 <msPeap:RequireCryptoBinding>false</msPeap:RequireCryptoBinding>
279 279
 </msPeap:EapType>
280 280
 </baseEap:Eap>
@@ -286,11 +286,11 @@  discard block
 block discarded – undo
286 286
 <EapType xmlns="http://www.microsoft.com/provisioning/MsPeapConnectionPropertiesV1">
287 287
 <ServerValidation>
288 288
 <DisableUserPromptForServerValidation>true</DisableUserPromptForServerValidation>
289
-<ServerNames>' . $servers . '</ServerNames>';
289
+<ServerNames>' . $servers.'</ServerNames>';
290 290
             if ($caArray) {
291 291
                 foreach ($caArray as $certAuthority) {
292 292
                     if ($certAuthority['root']) {
293
-                        $w7Ext .= "<TrustedRootCA>" . $certAuthority['sha1'] . "</TrustedRootCA>\n";
293
+                        $w7Ext .= "<TrustedRootCA>".$certAuthority['sha1']."</TrustedRootCA>\n";
294 294
                     }
295 295
                 }
296 296
             }
@@ -303,14 +303,14 @@  discard block
 block discarded – undo
303 303
 <UseWinLogonCredentials>false</UseWinLogonCredentials> 
304 304
 </EapType>
305 305
 </Eap>
306
-<EnableQuarantineChecks>' . $nea . '</EnableQuarantineChecks>
306
+<EnableQuarantineChecks>' . $nea.'</EnableQuarantineChecks>
307 307
 <RequireCryptoBinding>false</RequireCryptoBinding>
308 308
 ';
309 309
             if ($useAnon) {
310 310
                 $w7Ext .= '<PeapExtensions>
311 311
 <IdentityPrivacy xmlns="http://www.microsoft.com/provisioning/MsPeapConnectionPropertiesV2">
312 312
 <EnableIdentityPrivacy>true</EnableIdentityPrivacy>
313
-<AnonymousUserName>' . $outerUser . '</AnonymousUserName>
313
+<AnonymousUserName>' . $outerUser.'</AnonymousUserName>
314 314
 </IdentityPrivacy>
315 315
 </PeapExtensions>
316 316
             ';
@@ -328,8 +328,8 @@  discard block
 block discarded – undo
328 328
         $profileFileContEnd = '</EapHostConfig></EAPConfig>
329 329
 ';
330 330
         $returnArray = [];
331
-        $returnArray['vista'] = $profileFileCont . $vistaExt . $profileFileContEnd;
332
-        $returnArray['w7'] = $profileFileCont . $w7Ext . $profileFileContEnd;
331
+        $returnArray['vista'] = $profileFileCont.$vistaExt.$profileFileContEnd;
332
+        $returnArray['w7'] = $profileFileCont.$w7Ext.$profileFileContEnd;
333 333
         return $returnArray;
334 334
     }
335 335
 
@@ -348,10 +348,10 @@  discard block
 block discarded – undo
348 348
     private function writeWLANprofile($wlanProfileName, $ssid, $auth, $encryption, $eapConfig, $profileNumber) {
349 349
         $profileFileCont = '<?xml version="1.0"?>
350 350
 <WLANProfile xmlns="http://www.microsoft.com/networking/WLAN/profile/v1">
351
-<name>' . $wlanProfileName . '</name>
351
+<name>' . $wlanProfileName.'</name>
352 352
 <SSIDConfig>
353 353
 <SSID>
354
-<name>' . $ssid . '</name>
354
+<name>' . $ssid.'</name>
355 355
 </SSID>
356 356
 <nonBroadcast>true</nonBroadcast>
357 357
 </SSIDConfig>
@@ -361,8 +361,8 @@  discard block
 block discarded – undo
361 361
 <MSM>
362 362
 <security>
363 363
 <authEncryption>
364
-<authentication>' . $auth . '</authentication>
365
-<encryption>' . $encryption . '</encryption>
364
+<authentication>' . $auth.'</authentication>
365
+<encryption>' . $encryption.'</encryption>
366 366
 <useOneX>true</useOneX>
367 367
 </authEncryption>
368 368
 ';
@@ -392,9 +392,9 @@  discard block
 block discarded – undo
392 392
             mkdir('vista');
393 393
         }
394 394
         $vistaFileName = "vista/wlan_prof-$profileNumber.xml";
395
-        file_put_contents($vistaFileName, $profileFileCont . $eapConfig['vista'] . $closing);
395
+        file_put_contents($vistaFileName, $profileFileCont.$eapConfig['vista'].$closing);
396 396
         $sevenFileName = "w7/wlan_prof-$profileNumber.xml";
397
-        file_put_contents($sevenFileName, $profileFileCont . $eapConfig['w7'] . $closing);
397
+        file_put_contents($sevenFileName, $profileFileCont.$eapConfig['w7'].$closing);
398 398
         $this->loggerInstance->debug(2, "Installer has been written into directory $this->FPATH\n");
399 399
         $this->loggerInstance->debug(4, "WLAN_Profile:$wlanProfileName:$encryption\n");
400 400
         return("\"$wlanProfileName\" \"$encryption\"");
@@ -431,8 +431,8 @@  discard block
 block discarded – undo
431 431
             mkdir('vista');
432 432
         }
433 433
         
434
-        file_put_contents("vista/lan_prof.xml", $profileFileCont . $eapConfig['vista'] . $closing);
435
-        file_put_contents("w7/lan_prof.xml", $profileFileCont . $eapConfig['w7'] . $closing);
434
+        file_put_contents("vista/lan_prof.xml", $profileFileCont.$eapConfig['vista'].$closing);
435
+        file_put_contents("w7/lan_prof.xml", $profileFileCont.$eapConfig['w7'].$closing);
436 436
         
437 437
     }
438 438
 
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
     private function writeMainNSH($eap, $attr) {
447 447
         $this->loggerInstance->debug(4, "writeMainNSH");
448 448
         $this->loggerInstance->debug(4, $attr);
449
-        $this->loggerInstance->debug(4, "MYLANG=" . $this->lang . "\n");
449
+        $this->loggerInstance->debug(4, "MYLANG=".$this->lang."\n");
450 450
 
451 451
         $eapOptions = [
452 452
             \core\common\EAP::PEAP => ['str' => 'PEAP', 'exec' => 'user'],
@@ -477,8 +477,8 @@  discard block
 block discarded – undo
477 477
         $this->loggerInstance->debug(4, "EAP_STR=$eapStr\n");
478 478
         $this->loggerInstance->debug(4, $eap);
479 479
 
480
-        $fcontents .= '!define ' . $eapStr;
481
-        $fcontents .= "\n" . '!define EXECLEVEL "' . $execLevel . '"';
480
+        $fcontents .= '!define '.$eapStr;
481
+        $fcontents .= "\n".'!define EXECLEVEL "'.$execLevel.'"';
482 482
         $fcontents .= $this->writeNsisDefines($attr);
483 483
         file_put_contents('main.nsh', $fcontents);
484 484
     }
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
         }
508 508
         foreach ($caArray as $certAuthority) {
509 509
             $store = $certAuthority['root'] ? "root" : "ca";
510
-            $contentCerts .= '!insertmacro install_ca_cert "' . $certAuthority['file'] . '" "' . $certAuthority['sha1'] . '" "' . $store . "\"\n";
510
+            $contentCerts .= '!insertmacro install_ca_cert "'.$certAuthority['file'].'" "'.$certAuthority['sha1'].'" "'.$store."\"\n";
511 511
         }
512 512
         fwrite($fileHandleCerts, $contentCerts);
513 513
         fclose($fileHandleCerts);
Please login to merge, or discard this patch.