Passed
Push — release_2_1 ( 81e271...fc59fc )
by Tomasz
12:32
created
devices/ms/MsPeapProfile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     {
39 39
         $element = new \core\DeviceXMLmain();
40 40
         $element->setChild('ServerValidation', $this->getPeapServerValidation());
41
-        $element->setChild('FastReconnect','true');
41
+        $element->setChild('FastReconnect', 'true');
42 42
         $element->setChild('InnerEapOptional', 'false');
43 43
         $element->setChild('Eap', $this->getMsChapV2(), self::MS_BASEEAPCONN_NS);
44 44
         $element->setChild('EnableQuarantineChecks', $this->nea);
Please login to merge, or discard this patch.
devices/ms/MsOneX.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,8 +43,8 @@
 block discarded – undo
43 43
     {
44 44
         $element = new \core\DeviceXMLmain();
45 45
         $element->setChild('Type', $this->eapConfig->type, self::MS_EAPCOMMON_NS);
46
-        $element->setChild('VendorId',0, self::MS_EAPCOMMON_NS);
47
-        $element->setChild('VendorType',0, self::MS_EAPCOMMON_NS);
46
+        $element->setChild('VendorId', 0, self::MS_EAPCOMMON_NS);
47
+        $element->setChild('VendorType', 0, self::MS_EAPCOMMON_NS);
48 48
         $element->setChild('AuthorId', $this->eapConfig->authorId, self::MS_EAPCOMMON_NS);
49 49
         return($element);
50 50
     }
Please login to merge, or discard this patch.
devices/ms/MsWlanProfile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
         $dom = new \DOMDocument('1.0', 'utf-8');
74 74
         $root = $dom->createElement($rootname);
75 75
         $dom->appendChild($root);
76
-        $ns = $dom->createAttributeNS( null, 'xmlns' );
76
+        $ns = $dom->createAttributeNS(null, 'xmlns');
77 77
         $ns->value = "http://www.microsoft.com/networking/WLAN/profile/v1";
78 78
         $root->appendChild($ns);        
79 79
         \core\DeviceXMLmain::marshalObject($dom, $root, 'WLANprofile', $this->getWLANprofile(), '', true);
Please login to merge, or discard this patch.
core/DeviceXMLmain.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
                 $node->appendChild($childNode);
212 212
             }
213 213
             if (!empty($namespace)) {
214
-                $ns = $domElement->createAttributeNS(null,'xmlns');
214
+                $ns = $domElement->createAttributeNS(null, 'xmlns');
215 215
                 $ns->value = $namespace;
216 216
                 $childNode->appendChild($ns);  
217 217
             }
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
                 $nextChild = $domElement->createElement($nameC, $cl);    
239 239
                 $childNode->appendChild($nextChild);
240 240
                 if (!empty($namespaceC)) {
241
-                    $ns = $domElement->createAttributeNS(null,'xmlns');
241
+                    $ns = $domElement->createAttributeNS(null, 'xmlns');
242 242
                     $ns->value = $namespaceC;
243 243
                     $nextChild->appendChild($ns);  
244 244
                 }
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
                             $childNode->appendChild($nextChild);
261 261
                         }
262 262
                         if (!empty($namespaceC)) {
263
-                            $ns = $domElement->createAttributeNS(null,'xmlns');
263
+                            $ns = $domElement->createAttributeNS(null, 'xmlns');
264 264
                             $ns->value = $namespaceC;
265 265
                             $nextChild->appendChild($ns);  
266 266
                         }
Please login to merge, or discard this patch.
config/ConfAssistant-template.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
                     ], 
91 91
                 'condition' => TRUE],
92 92
             'OpenRoaming® (%REALM%)' => [
93
-                'ssid' => [],     /* OpenRoaming has left SSIDs behind */
93
+                'ssid' => [], /* OpenRoaming has left SSIDs behind */
94 94
                 'oi' => [
95 95
                     '5A03BA0000', /* OpenRoaming/AllIdentities/SettlementFree/NoPersonalData/BaselineQoS */
96 96
                     '5A03BA0800', /* OpenRoaming/EduIdentities/SettlementFree/NoPersonalData/BaselineQoS */
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
         'makensis' => 'makensis',
156 156
         'zip' => 'zip',
157 157
         'trust-store-mozilla' => '/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem',
158
-        'trust-store-custom' => __DIR__ . "/known-roots.pem",
158
+        'trust-store-custom' => __DIR__."/known-roots.pem",
159 159
     ];
160 160
 
161 161
     /**
@@ -193,13 +193,13 @@  discard block
 block discarded – undo
193 193
             'db' => 'radacct',
194 194
             'user' => 'someuser',
195 195
             'pass' => 'somepass',
196
-            'readonly' => TRUE,],
196
+            'readonly' => TRUE, ],
197 197
         'RADIUS_2' => [
198 198
             'host' => 'auth-2.hosted.eduroam.org',
199 199
             'db' => 'radacct',
200 200
             'user' => 'someuser',
201 201
             'pass' => 'somepass',
202
-            'readonly' => TRUE,],
202
+            'readonly' => TRUE, ],
203 203
     ];
204 204
 
205 205
     /**
Please login to merge, or discard this patch.
web/admin/inc/profileAutodetectCA.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
  */
21 21
 ?>
22 22
 <?php
23
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $languageInstance = new \core\common\Language();
Please login to merge, or discard this patch.
web/admin/overview_user.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 namespace core;
23 23
 
24
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
24
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
25 25
 
26 26
 $instMgmt = new \core\UserManagement();
27 27
 $deco = new \web\lib\admin\PageDecoration();
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
             <?php echo $uiElements->infoblock($user->getAttributes(), "user", "User"); ?>
62 62
             <tr>
63 63
                 <td>
64
-                    <?php echo "" . _("Unique Identifier") ?>
64
+                    <?php echo ""._("Unique Identifier") ?>
65 65
                 </td>
66 66
                 <td>
67 67
                 </td>
@@ -74,14 +74,14 @@  discard block
 block discarded – undo
74 74
     <div>
75 75
         <?php
76 76
         if (\config\Master::DB['USER']['readonly'] === FALSE) {
77
-            echo "<a href='edit_user.php'><button>" . _("Edit User Details") . "</button></a>";
77
+            echo "<a href='edit_user.php'><button>"._("Edit User Details")."</button></a>";
78 78
         }
79 79
 
80 80
         if ($user->isFederationAdmin()) {
81
-            echo "<form action='overview_federation.php' method='GET' accept-charset='UTF-8'><button type='submit'>" . sprintf(_('Click here for %s management tasks'), $uiElements->nomenclatureFed) . "</button></form>";
81
+            echo "<form action='overview_federation.php' method='GET' accept-charset='UTF-8'><button type='submit'>".sprintf(_('Click here for %s management tasks'), $uiElements->nomenclatureFed)."</button></form>";
82 82
         }
83 83
         if ($user->isSuperadmin()) {
84
-            echo "<form action='112365365321.php' method='GET' accept-charset='UTF-8'><button type='submit'>" . _('Click here to access the superadmin page') . "</button></form>";
84
+            echo "<form action='112365365321.php' method='GET' accept-charset='UTF-8'><button type='submit'>"._('Click here to access the superadmin page')."</button></form>";
85 85
         }
86 86
         ?>
87 87
     </div>
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         if (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_SILVERBULLET'] == "LOCAL") {
95 95
             $target = "https://wiki.geant.org/x/6Zg7Bw"; // Managed IdP manual
96 96
         }
97
-        $helptext = "<h3 style='display:inline;'>" . sprintf(_("(Need help? Refer to the <a href='%s'>%s administrator manual</a>)"), $target, $uiElements->nomenclatureParticipant) . "</h3>";
97
+        $helptext = "<h3 style='display:inline;'>".sprintf(_("(Need help? Refer to the <a href='%s'>%s administrator manual</a>)"), $target, $uiElements->nomenclatureParticipant)."</h3>";
98 98
     } else {
99 99
         $helptext = "";
100 100
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
         // we need to run the Federation constructor
104 104
         $cat = new \core\CAT;
105 105
         /// first parameter: number of Identity Providers; second param is the literal configured term for 'Identity Provider' (you may or may not be able to add a plural suffix for your locale)
106
-        echo "<h2>" . sprintf(ngettext("You are managing the following <span style='display:none'>%d </span>%s:", "You are managing the following <strong>%d</strong> %s:", sizeof($hasInst)), sizeof($hasInst), $uiElements->nomenclatureParticipant) . "</h2>";
106
+        echo "<h2>".sprintf(ngettext("You are managing the following <span style='display:none'>%d </span>%s:", "You are managing the following <strong>%d</strong> %s:", sizeof($hasInst)), sizeof($hasInst), $uiElements->nomenclatureParticipant)."</h2>";
107 107
         $instlist = [];
108 108
         $my_idps = [];
109 109
         $myFeds = [];
@@ -196,14 +196,14 @@  discard block
 block discarded – undo
196 196
                         <td>
197 197
                             <?php
198 198
                             if ($blessedUser && \config\Master::DB['INST']['readonly'] === FALSE) {
199
-                                echo "<div style='white-space: nowrap;'><form method='post' action='inc/manageAdmins.inc.php?inst_id=" . $the_inst->identifier . "' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'><button type='submit'>" . _("Add/Remove Administrators") . "</button></form></div>";
199
+                                echo "<div style='white-space: nowrap;'><form method='post' action='inc/manageAdmins.inc.php?inst_id=".$the_inst->identifier."' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'><button type='submit'>"._("Add/Remove Administrators")."</button></form></div>";
200 200
                             }
201 201
                             ?>
202 202
                         </td>
203 203
                         <td> <!-- danger zone --> 
204 204
 
205 205
                             <form action='edit_participant_result.php?inst_id=<?php echo $the_inst->identifier; ?>' method='post' accept-charset='UTF-8'>
206
-                                <button class='delete' type='submit' name='submitbutton' value='<?php echo \web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php echo ( \config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL ? sprintf(_("After deleting the %s, you can not recreate it yourself - you need a new invitation token from the %s administrator!"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed) . " " : "" ) . sprintf(_("Do you really want to delete your %s %s?"), $uiElements->nomenclatureParticipant, $the_inst->name); ?>')"><?php echo sprintf(_("Delete %s"), $uiElements->nomenclatureParticipant); ?></button>
206
+                                <button class='delete' type='submit' name='submitbutton' value='<?php echo \web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php echo (\config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL ? sprintf(_("After deleting the %s, you can not recreate it yourself - you need a new invitation token from the %s administrator!"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed)." " : "").sprintf(_("Do you really want to delete your %s %s?"), $uiElements->nomenclatureParticipant, $the_inst->name); ?>')"><?php echo sprintf(_("Delete %s"), $uiElements->nomenclatureParticipant); ?></button>
207 207
                             </form>
208 208
                             <form action='edit_participant_result.php?inst_id=<?php echo $the_inst->identifier; ?>' method='post' accept-charset='UTF-8'>
209 209
                                 <button class='delete' type='submit' name='submitbutton' value='<?php echo \web\lib\common\FormElements::BUTTON_FLUSH_AND_RESTART; ?>' onclick="return confirm('<?php echo sprintf(_("This action will delete all properties of the %s and start over the configuration from scratch. Do you really want to reset all settings of the %s %s?"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureParticipant, $the_inst->name); ?>')"><?php echo sprintf(_("Reset all %s settings"), $uiElements->nomenclatureParticipant); ?></button>
@@ -218,18 +218,18 @@  discard block
 block discarded – undo
218 218
         </table>
219 219
         <?php
220 220
     } else {
221
-        echo "<h2>" . sprintf(_("You are not managing any %s."), $uiElements->nomenclatureParticipant) . "</h2>";
221
+        echo "<h2>".sprintf(_("You are not managing any %s."), $uiElements->nomenclatureParticipant)."</h2>";
222 222
     }
223 223
     if (\config\Master::DB['INST']['readonly'] === FALSE) {
224 224
         if (\config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL) {
225
-            echo "<p>" . sprintf(_("Please ask your %s administrator to invite you to become an %s administrator."), $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant) . "</p>";
225
+            echo "<p>".sprintf(_("Please ask your %s administrator to invite you to become an %s administrator."), $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant)."</p>";
226 226
             echo "<hr/>
227 227
              <div style='white-space: nowrap;'>
228 228
                 <form action='action_enrollment.php' method='get' accept-charset='UTF-8'>" .
229
-            sprintf(_("Did you receive an invitation token to manage an %s? Please paste it here:"), $uiElements->nomenclatureParticipant) .
229
+            sprintf(_("Did you receive an invitation token to manage an %s? Please paste it here:"), $uiElements->nomenclatureParticipant).
230 230
             "        <input type='text' id='token' name='token'/>
231 231
                     <button type='submit'>" .
232
-            _("Go!") . "
232
+            _("Go!")."
233 233
                     </button>
234 234
                 </form>
235 235
              </div>";
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
             <div style='white-space: nowrap;'>
239 239
         <form action='action_enrollment.php' method='get'><button type='submit' accept-charset='UTF-8'>
240 240
                 <input type='hidden' id='token' name='token' value='SELF-REGISTER'/>" .
241
-            sprintf(_("New %s Registration"), $uiElements->nomenclatureParticipant) . "
241
+            sprintf(_("New %s Registration"), $uiElements->nomenclatureParticipant)."
242 242
             </button>
243 243
         </form>
244 244
         </div>";
Please login to merge, or discard this patch.
devices/eap_config/DeviceXML.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
         $dom = new \DOMDocument('1.0', 'utf-8');
145 145
         $root = $dom->createElement($rootname);
146 146
         $dom->appendChild($root);
147
-        $ns = $dom->createAttributeNS( 'http://www.w3.org/2001/XMLSchema-instance', 'xsi:noNamespaceSchemaLocation' );
147
+        $ns = $dom->createAttributeNS('http://www.w3.org/2001/XMLSchema-instance', 'xsi:noNamespaceSchemaLocation');
148 148
         $ns->value = "eap-metadata.xsd";
149 149
         $root->appendChild($ns);
150 150
         $this->openRoamingToU = sprintf(_("I have read and agree to OpenRoaming Terms of Use at %s."), "https://wballiance.com/openroaming/toc-2020/");
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
                 if ($netDefinition['condition'] === 'internal:openroaming' &&
182 182
                         $this->attributes['internal:openroaming']) {
183 183
                     $this->setORtou();
184
-                    if (preg_match("/^ask/",$this->attributes['media:openroaming'][0])) {
184
+                    if (preg_match("/^ask/", $this->attributes['media:openroaming'][0])) {
185 185
                         $orNetwork = $netDefinition;
186 186
                         continue;                        
187 187
                     }
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
     }
239 239
     
240 240
     private function setORtou() {
241
-        if (preg_match("/preagreed/",$this->attributes['media:openroaming'][0])) {
241
+        if (preg_match("/preagreed/", $this->attributes['media:openroaming'][0])) {
242 242
             $this->addORtou = false;
243 243
         } else {
244 244
             $this->addORtou = true;
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
         $authMethods = new \core\DeviceXMLmain();
263 263
         $authMethods->setChild('AuthenticationMethod', $this->authMethodsList);
264 264
         $eapIdp->setChild('AuthenticationMethods', $authMethods);
265
-        $eapIdp->setChild('CredentialApplicability', $this->getCredentialApplicability($ssids,$oids));
265
+        $eapIdp->setChild('CredentialApplicability', $this->getCredentialApplicability($ssids, $oids));
266 266
 // TODO   $eap_idp->setChild('ValidUntil',$this->getValidUntil());
267 267
         $eapIdp->setChild('ProviderInfo', $this->providerInfo);
268 268
 // TODO   $eap_idp->setChild('VendorSpecific',$this->getVendorSpecific());
@@ -416,7 +416,7 @@  discard block
 block discarded – undo
416 416
                 $lng = $lngAttr['lang'] === 'any' ? \config\Master::APPEARANCE['defaultlocale'] : $lngAttr['lang'];
417 417
                 $tou .= "\n".$this->openRoamingToUArray[$lng];
418 418
                 $touObj->setValue($tou);
419
-                $out[] =  $touObj;
419
+                $out[] = $touObj;
420 420
             } 
421 421
         } else {
422 422
             $tou = $standardTou[0];
Please login to merge, or discard this patch.
web/admin/overview_org.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -654,7 +654,7 @@
 block discarded – undo
654 654
                             </button>
655 655
                             <span style='color: red;'>
656 656
                             <?php if ($hasMail == 0) { 
657
-                              echo _("Helpdesk mail address is required but missing!");  
657
+                                echo _("Helpdesk mail address is required but missing!");  
658 658
                             }
659 659
                             ?>
660 660
                             </span>
Please login to merge, or discard this patch.
Spacing   +47 added lines, -47 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 function displaySilverbulletPropertyWidget(&$theProfile, $readonly, &$uiElements) {
32 32
     ?>
@@ -43,14 +43,14 @@  discard block
 block discarded – undo
43 43
                 <ul style='margin:1px'>
44 44
                     <?php
45 45
                     foreach ($completeness as $missing_attrib) {
46
-                        echo "<li>" . $uiElements->displayName($missing_attrib) . "</li>";
46
+                        echo "<li>".$uiElements->displayName($missing_attrib)."</li>";
47 47
                     }
48 48
                     ?>
49 49
                 </ul>
50 50
             </div>
51 51
             <?php
52 52
         } else {
53
-            echo sprintf(_("You can create up to %d users."), $maxusers[0]['value']) . "<br/>" . sprintf(_("Their credentials will carry the name <strong>%s</strong>."), $theProfile->realm);
53
+            echo sprintf(_("You can create up to %d users."), $maxusers[0]['value'])."<br/>".sprintf(_("Their credentials will carry the name <strong>%s</strong>."), $theProfile->realm);
54 54
         }
55 55
         ?>
56 56
         <br/>
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         if ($readonly === FALSE) {
60 60
             ?>
61 61
             <form action='edit_silverbullet.php?inst_id=<?php echo $theProfile->institution; ?>&amp;profile_id=<?php echo $theProfile->identifier; ?>' method='POST'>
62
-                <button <?php echo ( is_array($completeness) ? "disabled" : "" ); ?> type='submit' name='sb_action' value='sb_edit'><?php echo _("Manage User Base"); ?></button>
62
+                <button <?php echo (is_array($completeness) ? "disabled" : ""); ?> type='submit' name='sb_action' value='sb_edit'><?php echo _("Manage User Base"); ?></button>
63 63
             </form>
64 64
             <?php
65 65
         }
@@ -94,21 +94,21 @@  discard block
 block discarded – undo
94 94
                 $has_overrides = TRUE;
95 95
             }
96 96
         }
97
-        $buffer_eaptypediv = "<div style='margin-bottom:40px; float:left;'>" . _("<strong>EAP Types</strong> (in order of preference):") . "<br/>";
97
+        $buffer_eaptypediv = "<div style='margin-bottom:40px; float:left;'>"._("<strong>EAP Types</strong> (in order of preference):")."<br/>";
98 98
         $typelist = $theProfile->getEapMethodsinOrderOfPreference();
99 99
         $allcomplete = TRUE;
100 100
         foreach ($typelist as $eaptype) {
101 101
             $buffer_eaptypediv .= $eaptype->getPrintableRep();
102 102
             $completeness = $theProfile->isEapTypeDefinitionComplete($eaptype);
103 103
             if ($completeness === true) {
104
-                $buffer_eaptypediv .= " <div class='acceptable'>" . _("OK") . "</div>";
104
+                $buffer_eaptypediv .= " <div class='acceptable'>"._("OK")."</div>";
105 105
             } else {
106 106
                 $buffer_eaptypediv .= " <div class='notacceptable'>";
107 107
                 $buffer_eaptypediv .= _("Information needed!");
108 108
                 if (is_array($completeness)) {
109 109
                     $buffer_eaptypediv .= "<ul style='margin:1px'>";
110 110
                     foreach ($completeness as $missing_attrib) {
111
-                        $buffer_eaptypediv .= "<li>" . $uiElements->displayName($missing_attrib) . "</li>";
111
+                        $buffer_eaptypediv .= "<li>".$uiElements->displayName($missing_attrib)."</li>";
112 112
                     }
113 113
                     $buffer_eaptypediv .= "</ul>";
114 114
                 }
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
             foreach ($attribs as $attrib) {
121 121
                 if ($attrib['level'] == \core\Options::LEVEL_METHOD && !preg_match("/^internal:/", $attrib['name']) && !$justOnce) {
122 122
                     $justOnce = TRUE;
123
-                    $buffer_eaptypediv .= "<img src='../resources/images/icons/Letter-E-blue-icon.png' alt='" . _("Options on EAP Method/Device level are in effect.") . "'>";
123
+                    $buffer_eaptypediv .= "<img src='../resources/images/icons/Letter-E-blue-icon.png' alt='"._("Options on EAP Method/Device level are in effect.")."'>";
124 124
                 }
125 125
             }
126 126
             $buffer_eaptypediv .= "<br/>";
@@ -166,11 +166,11 @@  discard block
 block discarded – undo
166 166
                 if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] == "LOCAL") {
167 167
                     $diagUrl = "../diag/";
168 168
                 } else {
169
-                    $diagUrl = \config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] . "/diag/";
169
+                    $diagUrl = \config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS']."/diag/";
170 170
                 }
171 171
                 ?>
172
-                <form action='<?php echo $diagUrl . "action_realmcheck.php?inst_id=" . $theProfile->institution . "&profile_id=" . $theProfile->identifier ?>' method='post' accept-charset='UTF-8'>
173
-                    <input type='hidden' name='comefrom' value='<?php echo htmlspecialchars($link . $_SERVER['SCRIPT_NAME']); ?>'/>
172
+                <form action='<?php echo $diagUrl."action_realmcheck.php?inst_id=".$theProfile->institution."&profile_id=".$theProfile->identifier ?>' method='post' accept-charset='UTF-8'>
173
+                    <input type='hidden' name='comefrom' value='<?php echo htmlspecialchars($link.$_SERVER['SCRIPT_NAME']); ?>'/>
174 174
                     <button type='submit' name='profile_action' value='check' <?php echo ($has_realm ? "" : "disabled='disabled'"); ?> title='<?php echo _("The realm can only be checked if you configure the realm!"); ?>'>
175 175
                         <?php echo _("Check realm reachability"); ?>
176 176
                     </button>
@@ -203,9 +203,9 @@  discard block
 block discarded – undo
203 203
                 ?>
204 204
                 <div style='display: flex;'>
205 205
                     <?php
206
-                    $idpLevelUrl = $link . dirname(dirname($_SERVER['SCRIPT_NAME'])) . "?idp=" . $theProfile->institution;
207
-                    $displayurl = $idpLevelUrl . "&amp;profile=" . $theProfile->identifier;
208
-                    $QRurl = $idpLevelUrl . "&profile=" . $theProfile->identifier;
206
+                    $idpLevelUrl = $link.dirname(dirname($_SERVER['SCRIPT_NAME']))."?idp=".$theProfile->institution;
207
+                    $displayurl = $idpLevelUrl."&amp;profile=".$theProfile->identifier;
208
+                    $QRurl = $idpLevelUrl."&profile=".$theProfile->identifier;
209 209
                     $qrCode = new \chillerlan\QRCode\QRCode(new \chillerlan\QRCode\QROptions([
210 210
                                 'outputType' => \chillerlan\QRCode\QRCode::OUTPUT_IMAGE_PNG,
211 211
                                 'eccLevel' => \chillerlan\QRCode\QRCode::ECC_H,
@@ -217,9 +217,9 @@  discard block
 block discarded – undo
217 217
                     if (empty($rawQr)) {
218 218
                         throw new Exception("Something went seriously wrong during QR code generation!");
219 219
                     }
220
-                    $uri = "data:image/png;base64," . base64_encode($uiElements->pngInjectConsortiumLogo($rawQr, web\lib\admin\UIElements::QRCODE_PIXELS_PER_SYMBOL));
220
+                    $uri = "data:image/png;base64,".base64_encode($uiElements->pngInjectConsortiumLogo($rawQr, web\lib\admin\UIElements::QRCODE_PIXELS_PER_SYMBOL));
221 221
                     $size = getimagesize($uri);
222
-                    echo "<img width='" . ($size[0] / 4) . "' height='" . ($size[1] / 4) . "' src='$uri' alt='QR-code'/>";
222
+                    echo "<img width='".($size[0] / 4)."' height='".($size[1] / 4)."' src='$uri' alt='QR-code'/>";
223 223
 
224 224
                     //echo "<nobr>$displayurl</nobr></a>";
225 225
                     echo "<p>$displayurl</p></a>";
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
             <h2><?php
264 264
                 switch ($deploymentObject->consortium) {
265 265
                     case "eduroam":
266
-                        $displayname = config\ConfAssistant::CONSORTIUM['name'] . " " . core\DeploymentManaged::PRODUCTNAME;
266
+                        $displayname = config\ConfAssistant::CONSORTIUM['name']." ".core\DeploymentManaged::PRODUCTNAME;
267 267
                         break;
268 268
                     case "OpenRoaming":
269 269
                         $displayname = "OpenRoaming ANP";
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
                     default:
272 272
                         throw new Exception("We are supposed to operate on a roaming consortium we don't know.");
273 273
                 }
274
-                echo $displayname . " (<span style='color:" . ( $deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>" . _("inactive") : "green;'>" . _("active") ) . "</span>)";
274
+                echo $displayname." (<span style='color:".($deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>"._("inactive") : "green;'>"._("active"))."</span>)";
275 275
                 ?></h2>
276 276
             <table>
277 277
                 <caption><?php echo _("Deployment Details"); ?></caption>
@@ -285,13 +285,13 @@  discard block
 block discarded – undo
285 285
                     <td><strong><?php echo _("Your primary RADIUS server") ?></strong><br/>
286 286
                         <?php
287 287
                         if ($deploymentObject->host1_v4 !== NULL) {
288
-                            echo _("IPv4") . ": " . $deploymentObject->host1_v4;
288
+                            echo _("IPv4").": ".$deploymentObject->host1_v4;
289 289
                         }
290 290
                         if ($deploymentObject->host1_v4 !== NULL && $deploymentObject->host1_v6 !== NULL) {
291 291
                             echo "<br/>";
292 292
                         }
293 293
                         if ($deploymentObject->host1_v6 !== NULL) {
294
-                            echo _("IPv6") . ": " . $deploymentObject->host1_v6;
294
+                            echo _("IPv6").": ".$deploymentObject->host1_v6;
295 295
                         }
296 296
                         ?>
297 297
                     </td>
@@ -299,9 +299,9 @@  discard block
 block discarded – undo
299 299
                     <td><?php echo $deploymentObject->port1; ?></td>
300 300
                     <td>
301 301
                         <?php
302
-                        echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_1]['icon'] .
303
-                        "' alt='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] .
304
-                        "' title='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . "'>";
302
+                        echo "<img src='".$radiusMessages[$deploymentObject->radius_status_1]['icon'].
303
+                        "' alt='".$radiusMessages[$deploymentObject->radius_status_1]['text'].
304
+                        "' title='".$radiusMessages[$deploymentObject->radius_status_1]['text']."'>";
305 305
                         ?>
306 306
                     </td>
307 307
                 </tr>
@@ -309,22 +309,22 @@  discard block
 block discarded – undo
309 309
                     <td><strong><?php echo _("Your backup RADIUS server") ?><br/></strong>
310 310
                         <?php
311 311
                         if ($deploymentObject->host2_v4 !== NULL) {
312
-                            echo _("IPv4") . ": " . $deploymentObject->host2_v4;
312
+                            echo _("IPv4").": ".$deploymentObject->host2_v4;
313 313
                         }
314 314
                         if ($deploymentObject->host2_v4 !== NULL && $deploymentObject->host2_v6 !== NULL) {
315 315
                             echo "<br/>";
316 316
                         }
317 317
                         if ($deploymentObject->host2_v6 !== NULL) {
318
-                            echo _("IPv6") . ": " . $deploymentObject->host2_v6;
318
+                            echo _("IPv6").": ".$deploymentObject->host2_v6;
319 319
                         }
320 320
                         ?></td>
321 321
                     <td><?php echo _("RADIUS port number: ") ?></td>
322 322
                     <td><?php echo $deploymentObject->port2; ?></td>
323 323
                     <td>
324 324
                         <?php
325
-                        echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_2]['icon'] .
326
-                        "' alt='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] .
327
-                        "' title='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . "'>";
325
+                        echo "<img src='".$radiusMessages[$deploymentObject->radius_status_2]['icon'].
326
+                        "' alt='".$radiusMessages[$deploymentObject->radius_status_2]['text'].
327
+                        "' title='".$radiusMessages[$deploymentObject->radius_status_2]['text']."'>";
328 328
                         ?>
329 329
                     </td>
330 330
                 </tr>
@@ -376,12 +376,12 @@  discard block
 block discarded – undo
376 376
                             if (array_key_exists('FAILURE', $res) && $res['FAILURE'] > 0) {
377 377
                                 echo '<br>';
378 378
                                 if ($res['FAILURE'] == 2) {
379
-                                    echo ' <span style="color: red;">' . _("Activation failure.") . '</span>';
379
+                                    echo ' <span style="color: red;">'._("Activation failure.").'</span>';
380 380
                                 } else {
381 381
                                     if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
382
-                                        echo ' <span style="color: red;">' . _("Activation failure for your primary RADIUS server.") . '</span>';
382
+                                        echo ' <span style="color: red;">'._("Activation failure for your primary RADIUS server.").'</span>';
383 383
                                     } else {
384
-                                        echo ' <span style="color: red;">' . _("Activation failure for your backup RADIUS server.") . '</span>';
384
+                                        echo ' <span style="color: red;">'._("Activation failure for your backup RADIUS server.").'</span>';
385 385
                                     }
386 386
                                 }
387 387
                             }
@@ -416,12 +416,12 @@  discard block
 block discarded – undo
416 416
                                 if ($res['FAILURE'] > 0) {
417 417
                                     echo '<br>';
418 418
                                     if ($res['FAILURE'] == 2) {
419
-                                        echo ' <span style="color: red;">' . _("Failure during deactivation, your request is queued for handling") . '</span>';
419
+                                        echo ' <span style="color: red;">'._("Failure during deactivation, your request is queued for handling").'</span>';
420 420
                                     } else {
421 421
                                         if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
422
-                                            echo ' <span style="color: red;">' . _("Deactivation failure for your primary RADIUS server, your request is queued.") . '</span>';
422
+                                            echo ' <span style="color: red;">'._("Deactivation failure for your primary RADIUS server, your request is queued.").'</span>';
423 423
                                         } else {
424
-                                            echo ' <span style="color: red;">' . _("Deactivation failure for your backup RADIUS server, your request is queued.") . '</span>';
424
+                                            echo ' <span style="color: red;">'._("Deactivation failure for your backup RADIUS server, your request is queued.").'</span>';
425 425
                                         }
426 426
                                     }
427 427
                                 }
@@ -442,24 +442,24 @@  discard block
 block discarded – undo
442 442
         </div>
443 443
         <div style='width:20px;'></div> <!-- QR code space, reserved -->
444 444
         <div style='display: table-cell; min-width:200px;'>
445
-            <?php $tablecaption = _("Hotspot Usage Statistics");?>
445
+            <?php $tablecaption = _("Hotspot Usage Statistics"); ?>
446 446
             <h1><?php echo $tablecaption; ?></h1>
447
-            <h2><?php echo _("5 most recent authentications");?></h2>
448
-            <p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)");?></p>
447
+            <h2><?php echo _("5 most recent authentications"); ?></h2>
448
+            <p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)"); ?></p>
449 449
             <table class='authrecord'>
450
-    <caption><?php echo $tablecaption;?></caption>
450
+    <caption><?php echo $tablecaption; ?></caption>
451 451
     <tr style='text-align: left;'>
452
-        <th scope="col"><strong><?php echo _("Timestamp (UTC)");?></strong></th>
453
-        <th scope="col"><strong><?php echo _("Realm");?></strong></th>
454
-        <th scope="col"><strong><?php echo _("MAC Address");?></strong></th>
455
-        <th scope="col"><strong><?php echo _("Chargeable-User-Identity");?></strong></th>
456
-        <th scope="col"><strong><?php echo _("Result");?></strong></th>
457
-        <th scope="col"><strong><?php echo _("AP Identifier");?></strong></th>
452
+        <th scope="col"><strong><?php echo _("Timestamp (UTC)"); ?></strong></th>
453
+        <th scope="col"><strong><?php echo _("Realm"); ?></strong></th>
454
+        <th scope="col"><strong><?php echo _("MAC Address"); ?></strong></th>
455
+        <th scope="col"><strong><?php echo _("Chargeable-User-Identity"); ?></strong></th>
456
+        <th scope="col"><strong><?php echo _("Result"); ?></strong></th>
457
+        <th scope="col"><strong><?php echo _("AP Identifier"); ?></strong></th>
458 458
     </tr>
459 459
     <?php
460
-    $userAuthData = $deploymentObject->retrieveStatistics(0,5);
460
+    $userAuthData = $deploymentObject->retrieveStatistics(0, 5);
461 461
     foreach ($userAuthData as $oneRecord) {
462
-        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail" )."'>"
462
+        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail")."'>"
463 463
                 . "<td>".$oneRecord['activity_time']."</td>"
464 464
                 . "<td>".$oneRecord['realm']."</td>"
465 465
                 . "<td>".$oneRecord['mac']."</td>"
@@ -670,7 +670,7 @@  discard block
 block discarded – undo
670 670
                         <div>
671 671
                             <input type="hidden" name="consortium" value="eduroam"/>
672 672
                             <button type='submit' <?php echo ($hasMail > 0 ? "" : "disabled"); ?> name='profile_action' value='new'>
673
-                                <?php echo sprintf(_("Add %s deployment ..."), \config\ConfAssistant::CONSORTIUM['name'] . " " . \core\DeploymentManaged::PRODUCTNAME); ?>
673
+                                <?php echo sprintf(_("Add %s deployment ..."), \config\ConfAssistant::CONSORTIUM['name']." ".\core\DeploymentManaged::PRODUCTNAME); ?>
674 674
                             </button>
675 675
                             <span style='color: red;'>
676 676
                             <?php if ($hasMail == 0) { 
Please login to merge, or discard this patch.