Test Failed
Push — master ( 09c8f5...34d199 )
by Stefan
10:35 queued 11s
created
web/admin/inc/deploymentStats.inc.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
  * ******************************************************************************
10 10
  */
11 11
 
12
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
12
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
13 13
 
14 14
 $auth = new \web\lib\admin\Authentication();
15 15
 $auth->authenticate();
@@ -37,21 +37,21 @@  discard block
 block discarded – undo
37 37
 ?>
38 38
 
39 39
 <h1><?php $tablecaption = _("Deployment Usage Records"); echo $tablecaption; ?></h1>
40
-<p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)");?></p>
40
+<p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)"); ?></p>
41 41
 <table class='authrecord'>
42
-    <caption><?php echo $tablecaption;?></caption>
42
+    <caption><?php echo $tablecaption; ?></caption>
43 43
     <tr>
44
-        <th scope="col"><strong><?php echo _("Timestamp (UTC)");?></strong></th>
45
-        <th scope="col"><strong><?php echo _("Realm");?></strong></th>
46
-        <th scope="col"><strong><?php echo _("MAC Address");?></strong></th>
47
-        <th scope="col"><strong><?php echo _("Chargeable-User-Identity");?></strong></th>
48
-        <th scope="col"><strong><?php echo _("Result");?></strong></th>
49
-        <th scope="col"><strong><?php echo _("AP Identifier");?></strong></th>
44
+        <th scope="col"><strong><?php echo _("Timestamp (UTC)"); ?></strong></th>
45
+        <th scope="col"><strong><?php echo _("Realm"); ?></strong></th>
46
+        <th scope="col"><strong><?php echo _("MAC Address"); ?></strong></th>
47
+        <th scope="col"><strong><?php echo _("Chargeable-User-Identity"); ?></strong></th>
48
+        <th scope="col"><strong><?php echo _("Result"); ?></strong></th>
49
+        <th scope="col"><strong><?php echo _("AP Identifier"); ?></strong></th>
50 50
     </tr>
51 51
     <?php
52 52
     $userAuthData = $deployment->retrieveStatistics($backlogTime);
53 53
     foreach ($userAuthData as $oneRecord) {
54
-        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail" )."'>"
54
+        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail")."'>"
55 55
                 . "<td>".$oneRecord['activity_time']."</td>"
56 56
                 // $oneRecord['CN'] is a simple string, not an array, so disable Scrutinizer type check here
57 57
                 . "<td>".$oneRecord['realm']."</td>"
Please login to merge, or discard this patch.
core/DeploymentManaged.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
                 $serverCandidates[IdPlist::geoDistance($adminLocation, ['lat' => $iterator->location_lat, 'lon' => $iterator->location_lon])] = $iterator->server_id;
291 291
             }
292 292
             if ($clients > $maxSupportedClients * 0.9) {
293
-                $this->loggerInstance->debug(1, "A RADIUS server for Managed SP (" . $iterator->server_id . ") is serving at more than 90% capacity!");
293
+                $this->loggerInstance->debug(1, "A RADIUS server for Managed SP (".$iterator->server_id.") is serving at more than 90% capacity!");
294 294
             }
295 295
         }
296 296
         if (count($serverCandidates) == 0 && $federation != "DEFAULT") {
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
             $conditional1 = "AND activity_time > DATE_SUB(NOW(), INTERVAL $backlog SECOND)";
330 330
             $conditional2 = "";
331 331
         }
332
-        $stats = $this->databaseHandle->exec("SELECT activity_time, realm, mac, cui, result, ap_id FROM activity WHERE operatorname = ? $conditional1 ORDER BY activity_time $conditional2", "s", $opName );
332
+        $stats = $this->databaseHandle->exec("SELECT activity_time, realm, mac, cui, result, ap_id FROM activity WHERE operatorname = ? $conditional1 ORDER BY activity_time $conditional2", "s", $opName);
333 333
         return mysqli_fetch_all($stats, \MYSQLI_ASSOC);
334 334
     }
335 335
         
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
     {
447 447
         $customAttrib = $this->getAttributes("managedsp:operatorname");
448 448
         if (count($customAttrib) == 0) {
449
-            return "1sp." . $this->identifier . "-" . $this->institution . \config\ConfAssistant::SILVERBULLET['realm_suffix'];
449
+            return "1sp.".$this->identifier."-".$this->institution.\config\ConfAssistant::SILVERBULLET['realm_suffix'];
450 450
         }
451 451
         return $customAttrib[0]["value"];
452 452
     }
@@ -462,13 +462,13 @@  discard block
 block discarded – undo
462 462
     {
463 463
 
464 464
         $hostname = "radius_hostname_$idx";
465
-        $ch = curl_init("http://" . $this->$hostname);
465
+        $ch = curl_init("http://".$this->$hostname);
466 466
         if ($ch === FALSE) {
467 467
             $res = 'FAILURE';
468 468
         } else {
469 469
             curl_setopt($ch, CURLOPT_POST, 1);
470 470
             curl_setopt($ch, CURLOPT_POSTFIELDS, $post);
471
-            $this->loggerInstance->debug(1, "Posting to http://" . $this->$hostname . ": $post\n");
471
+            $this->loggerInstance->debug(1, "Posting to http://".$this->$hostname.": $post\n");
472 472
             curl_setopt($ch, CURLOPT_FOLLOWLOCATION, 1);
473 473
             curl_setopt($ch, CURLOPT_HEADER, 0);
474 474
             curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
@@ -507,19 +507,19 @@  discard block
 block discarded – undo
507 507
         } else {
508 508
             $txt = $remove ? _('Profile deactivation failed') : _('Profile activation/modification failed');
509 509
         }
510
-        $txt = $txt . ' ';
510
+        $txt = $txt.' ';
511 511
         if (array_count_values($response)[$status] == 2) {
512
-            $txt = $txt . _('on both RADIUS servers: primary and backup') . '.';
512
+            $txt = $txt._('on both RADIUS servers: primary and backup').'.';
513 513
         } else {
514 514
             if ($response['res[1]'] == $status) {
515
-                $txt = $txt . _('on primary RADIUS server') . '.';
515
+                $txt = $txt._('on primary RADIUS server').'.';
516 516
             } else {
517
-                $txt = $txt . _('on backup RADIUS server') . '.';
517
+                $txt = $txt._('on backup RADIUS server').'.';
518 518
             }
519 519
         }
520 520
         $mail = \core\common\OutsideComm::mailHandle();
521 521
         $email = $this->getAttributes("support:email")[0]['value'];
522
-        $mail->FromName = \config\Master::APPEARANCE['productname'] . " Notification System";
522
+        $mail->FromName = \config\Master::APPEARANCE['productname']." Notification System";
523 523
         $mail->addAddress($email);
524 524
         if ($status == 'OK') {
525 525
             $mail->Subject = _('RADIUS profile update problem fixed');
@@ -553,7 +553,7 @@  discard block
 block discarded – undo
553 553
             return NULL;
554 554
         }
555 555
         $timeout = 10;
556
-        curl_setopt($ch, CURLOPT_URL, 'http://' . $host);
556
+        curl_setopt($ch, CURLOPT_URL, 'http://'.$host);
557 557
         curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
558 558
         curl_setopt($ch, CURLOPT_TIMEOUT, $timeout);
559 559
         curl_exec($ch);
@@ -645,33 +645,33 @@  discard block
 block discarded – undo
645 645
     {
646 646
         $remove = ($this->status == \core\AbstractDeployment::INACTIVE) ? 0 : 1;
647 647
         $toPost = ($onlyone ? array($onlyone => '') : array(1 => '', 2 => ''));
648
-        $toPostTemplate = 'instid=' . $this->institution . '&deploymentid=' . $this->identifier . '&secret=' . $this->secret . '&country=' . $this->getAttributes("internal:country")[0]['value'] . '&';
648
+        $toPostTemplate = 'instid='.$this->institution.'&deploymentid='.$this->identifier.'&secret='.$this->secret.'&country='.$this->getAttributes("internal:country")[0]['value'].'&';
649 649
         if ($remove) {
650
-            $toPostTemplate = $toPostTemplate . 'remove=1&';
650
+            $toPostTemplate = $toPostTemplate.'remove=1&';
651 651
         } else {
652
-            $toPostTemplate = $toPostTemplate . 'operatorname=' . $this->getOperatorName() . '&'; 
652
+            $toPostTemplate = $toPostTemplate.'operatorname='.$this->getOperatorName().'&'; 
653 653
             if ($this->getAttributes("managedsp:vlan")[0]['value'] ?? NULL) {
654 654
                 $allRealms = $this->getAllRealms();
655 655
                 if (!empty($allRealms)) {
656
-                    $toPostTemplate = $toPostTemplate . 'vlan=' . $this->getAttributes("managedsp:vlan")[0]['value'] . '&';
657
-                    $toPostTemplate = $toPostTemplate . 'realmforvlan[]=' . implode('&realmforvlan[]=', $allRealms) . '&';
656
+                    $toPostTemplate = $toPostTemplate.'vlan='.$this->getAttributes("managedsp:vlan")[0]['value'].'&';
657
+                    $toPostTemplate = $toPostTemplate.'realmforvlan[]='.implode('&realmforvlan[]=', $allRealms).'&';
658 658
                 }
659 659
             }
660 660
         }
661 661
         foreach (array_keys($toPost) as $key) {
662
-            $elem = 'port' . $key;
663
-            $toPost[$key] = $toPostTemplate . 'port=' . $this->$elem;
662
+            $elem = 'port'.$key;
663
+            $toPost[$key] = $toPostTemplate.'port='.$this->$elem;
664 664
         }
665 665
         $response = array();
666 666
         foreach ($toPost as $key => $value) {
667
-            $this->loggerInstance->debug(1, 'toPost ' . $toPost[$key] . "\n");
668
-            $response['res[' . $key . ']'] = $this->sendToRADIUS($key, $toPost[$key]);
667
+            $this->loggerInstance->debug(1, 'toPost '.$toPost[$key]."\n");
668
+            $response['res['.$key.']'] = $this->sendToRADIUS($key, $toPost[$key]);
669 669
         }
670 670
         if ($onlyone) {
671
-            $response['res[' . ($onlyone == 1) ? 2 : 1 . ']'] = \core\AbstractDeployment::RADIUS_OK;
671
+            $response['res['.($onlyone == 1) ? 2 : 1.']'] = \core\AbstractDeployment::RADIUS_OK;
672 672
         }
673 673
         foreach (array('OK', 'FAILURE') as $status) {
674
-            if ( ( ($status == 'OK' && $notify) || ($status == 'FAILURE') ) && ( in_array($status, $response) ) ) {
674
+            if ((($status == 'OK' && $notify) || ($status == 'FAILURE')) && (in_array($status, $response))) {
675 675
                 $this->sendMailtoAdmin($remove, $response, $status);
676 676
             }
677 677
         }
Please login to merge, or discard this patch.
web/skins/modern/diag/diag.php 1 patch
Spacing   +68 added lines, -68 removed lines patch added patch discarded remove patch
@@ -47,9 +47,9 @@  discard block
 block discarded – undo
47 47
 $Gui->loggerInstance->debug(4, $operatingSystem);
48 48
 $uiElements = new web\lib\admin\UIElements();
49 49
 if ($operatingSystem) {
50
-    print "recognisedOS = '" . $operatingSystem['device'] . "';\n";
50
+    print "recognisedOS = '".$operatingSystem['device']."';\n";
51 51
 }
52
-require dirname(__DIR__) . '/user/js/cat_js.php';
52
+require dirname(__DIR__).'/user/js/cat_js.php';
53 53
 
54 54
 ?>
55 55
 </script>
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 <div id='wrap' style='background-image:url("<?php echo $Gui->skinObject->findResourceUrl("IMAGES", "beta.png"); ?>");'>
62 62
 <form id="cat_form" name="cat_form" accept-charset="UTF-8" action="<?php echo $_SERVER['SCRIPT_NAME']; ?>" method="POST">
63 63
 <?php
64
-require dirname(__DIR__) . '/diag/js/diag_js.php';
64
+require dirname(__DIR__).'/diag/js/diag_js.php';
65 65
 echo $divs->divHeading($visibility);
66 66
 $Gui->languageInstance->setTextDomain("diagnostics");
67 67
 ?>
@@ -79,12 +79,12 @@  discard block
 block discarded – undo
79 79
     </div>
80 80
     <div id="main_body">
81 81
         <div id="user_page">
82
-            <?php echo $divs->divPagetitle(_("Diagnostics site") . " (<span style='color:red'>beta</span>)", ""); ?>
82
+            <?php echo $divs->divPagetitle(_("Diagnostics site")." (<span style='color:red'>beta</span>)", ""); ?>
83 83
             <div id="user_info" style='padding-top: 10px;'>
84 84
             <div id='diagnostic_choice'>
85
-                <?php echo _("The diagnostics system will do its best to identify and resolve your problems!") . ' ' . _("Please help the system by answering the questions as precisely as possible.") . "<br/>" . _("Are you a") . ' '; ?>
86
-                <input type='radio' name='diagnostic_usertype' value='0'><?php echo _("end-user") . ' ' . _("or"); ?>   
87
-                <input type='radio' name='diagnostic_usertype' value='1' <?php if ($admin == 1) { echo " checked"; } ?> > <?php echo _("eduroam administrator") .'?'; ?>
85
+                <?php echo _("The diagnostics system will do its best to identify and resolve your problems!").' '._("Please help the system by answering the questions as precisely as possible.")."<br/>"._("Are you a").' '; ?>
86
+                <input type='radio' name='diagnostic_usertype' value='0'><?php echo _("end-user").' '._("or"); ?>   
87
+                <input type='radio' name='diagnostic_usertype' value='1' <?php if ($admin == 1) { echo " checked"; } ?> > <?php echo _("eduroam administrator").'?'; ?>
88 88
             </div>
89 89
             <div id='diagnostic_enduser' style='display: none;'>
90 90
                 <h2><?php echo _("Tools for End Users"); ?></h2>
@@ -94,24 +94,24 @@  discard block
 block discarded – undo
94 94
                 ?>
95 95
                 </p>
96 96
                 <?php
97
-                    echo '<div id="before_stage_1"><h3>' . _("The system needs some information on your home institution - issuer of your account") . '</h3>';
97
+                    echo '<div id="before_stage_1"><h3>'._("The system needs some information on your home institution - issuer of your account").'</h3>';
98 98
                     echo _("What is the realm part of your user account (the part behind the @ of 'your.username@<strong>realm.tld</strong>'):");
99 99
                 ?>
100 100
                 <input type='text' name='user_realm' id='user_realm' value=''>
101 101
                 <?php
102
-                    echo '<div id="realm_by_select"><br/>' . _("alternatively") . '<br/>';
103
-                    echo _("You can select your home institution from the following list") . '<br/>';
102
+                    echo '<div id="realm_by_select"><br/>'._("alternatively").'<br/>';
103
+                    echo _("You can select your home institution from the following list").'<br/>';
104 104
                     echo '<div id="select_idp_country"><a href="" id="idp_countries_list">';    
105
-                    echo '<span id="realmselect">' . _("Click to select your country/region and organisation") . '</span></a></div>';
105
+                    echo '<span id="realmselect">'._("Click to select your country/region and organisation").'</span></a></div>';
106 106
                 ?>
107 107
                 <div id="select_idp_area" style="display:none;">
108 108
                 </div>
109 109
                 </div>
110 110
                 <div id="position_info">
111 111
                     <?php
112
-                        echo '<h3>' . _("Optionally, to improve tests, you can provide information on your current location") . '</h3>';
112
+                        echo '<h3>'._("Optionally, to improve tests, you can provide information on your current location").'</h3>';
113 113
                         echo '<div id="select_sp_country"><a href="" id="sp_countries_list">';    
114
-                        echo '<span id="spselect">' . _("Click to select a location in which you have an eduroam problem") . '</span></a></div>';
114
+                        echo '<span id="spselect">'._("Click to select a location in which you have an eduroam problem").'</span></a></div>';
115 115
                     ?>
116 116
                     <div id="select_sp_area" style="display:none;">
117 117
                     </div>
@@ -144,11 +144,11 @@  discard block
 block discarded – undo
144 144
                             echo 'none';
145 145
                         }
146 146
                         echo ";'>";
147
-                        echo '<h3>' . _("What is the nature of the problem?") . '</h3>';
148
-                        echo '<input type="radio" name="problem_type" value="0"' . (($sp==1)? ' checked' : '') . '>';
149
-                        echo _("I suspect a technical problem at a particular IdP") . '<br>';
147
+                        echo '<h3>'._("What is the nature of the problem?").'</h3>';
148
+                        echo '<input type="radio" name="problem_type" value="0"'.(($sp == 1) ? ' checked' : '').'>';
149
+                        echo _("I suspect a technical problem at a particular IdP").'<br>';
150 150
                         echo '<input type="radio" name="problem_type" value="1">';
151
-                        echo _("I want to report abuse of network resources by a roaming user") . '<br>';
151
+                        echo _("I want to report abuse of network resources by a roaming user").'<br>';
152 152
                         echo '<input type="radio" name="problem_type" value="2">';
153 153
                         echo _("I suspect a technical problem for one of my users at a particular SP");
154 154
                         echo "<div id='idp_contact_area'></div>";
@@ -157,9 +157,9 @@  discard block
 block discarded – undo
157 157
                         echo "</div>"; 
158 158
                     } else {
159 159
                         echo "0\">";
160
-                        echo _("This service is for authenticated admins only.") . '<br>';
161
-                        echo "<a href=\"diag.php?admin=1\">" .
162
-                             _("eduroam® admin access is needed") . "</a>";
160
+                        echo _("This service is for authenticated admins only.").'<br>';
161
+                        echo "<a href=\"diag.php?admin=1\">".
162
+                             _("eduroam® admin access is needed")."</a>";
163 163
                     }
164 164
                 ?>
165 165
             </div> 
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
         return false;
236 236
     });
237 237
     $(document).on('change', '#idp_country' , function() {
238
-        var comment = <?php echo '"' . _("Fetching institutions list") . '..."'; ?>;  
238
+        var comment = <?php echo '"'._("Fetching institutions list").'..."'; ?>;  
239 239
         var id = $(this).attr('id');
240 240
         var k = id.indexOf('_');
241 241
         var type = id.substr(0,k);
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
                         var shtml = '';
254 254
                         var select = '';
255 255
                         if (type !== 'asp') {
256
-                            shtml = <?php echo '"<td>' . _("Select institution:") . '</td><td>"'; ?>;
256
+                            shtml = <?php echo '"<td>'._("Select institution:").'</td><td>"'; ?>;
257 257
                         }
258 258
                         select = '<select id="' + type + '_inst" name="' + type + '_inst" style="margin-left:0px; width:400px;"><option value=""></option>';
259 259
                         for (var i in institutions) {
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
                     } else {
275 275
                         if (data.status === 0) {
276 276
                             inProgress(0);
277
-                            var msg = <?php echo '"' . _("The database does not contain the information needed to help you in realm selection for this country. You have to provide the realm you are interested in.") . '"'; ?>;
277
+                            var msg = <?php echo '"'._("The database does not contain the information needed to help you in realm selection for this country. You have to provide the realm you are interested in.").'"'; ?>;
278 278
                             alert(msg);
279 279
                             $('#select_idp_country').show();
280 280
                             $('#select_idp_area').hide();
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
                 },
284 284
                 error:function() {
285 285
                     inProgress(0);
286
-                    var msg = <?php echo '"' . _("Can not search in database. You have to provide the realm you are interested in.") . '"'; ?>;
286
+                    var msg = <?php echo '"'._("Can not search in database. You have to provide the realm you are interested in.").'"'; ?>;
287 287
                     alert(msg);
288 288
                     $('#select_idp_country').show();
289 289
                     $('#select_idp_area').hide();
@@ -299,9 +299,9 @@  discard block
 block discarded – undo
299 299
     });
300 300
     $(document).on('change', '#select_sp_problem' , function() {
301 301
         if ($('#select_sp_problem').val().substr(0,6) == 'abuse-') {
302
-            $('#realm_in_db_admin').text(<?php echo '"' . _("Check if this realm is registered") . '"'; ?>);
302
+            $('#realm_in_db_admin').text(<?php echo '"'._("Check if this realm is registered").'"'; ?>);
303 303
         } else {
304
-            $('#realm_in_db_admin').text(<?php echo '"' . _("Check this realm") . '"'; ?>);
304
+            $('#realm_in_db_admin').text(<?php echo '"'._("Check this realm").'"'; ?>);
305 305
         }
306 306
         $('#realm_in_db_admin').hide();
307 307
         $('#admin_realm').val('');
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
         clear_sp_question();
310 310
     });
311 311
     $(document).on('change', '#sp_country, #asp_country' , function() {
312
-        var comment = <?php echo '"' . _("Fetching institutions list") . '..."'; ?>;  
312
+        var comment = <?php echo '"'._("Fetching institutions list").'..."'; ?>;  
313 313
         var id = $(this).attr('id');
314 314
         var k = id.indexOf('_');
315 315
         var type = id.substr(0,k);
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
                         var shtml = '';
328 328
                         var select = '';
329 329
                         if (type !== 'asp') {
330
-                            shtml = <?php echo '"<td>' . _("Select institution:") . '</td><td>"'; ?>;
330
+                            shtml = <?php echo '"<td>'._("Select institution:").'</td><td>"'; ?>;
331 331
                         }
332 332
                         select = '<select id="' + type + '_inst" name="' + type + '_inst" style="margin-left:0px; width:400px;"><option value=""></option>';
333 333
                         for (var i in hotspots) {
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
                             inProgress(0);
351 351
                             var select = '<select id="' + type + '_inst" name="' + type + '_inst" style="margin-left:0px; width:400px;"><option value="">';
352 352
                             var shtml = '<td></td><td>';
353
-                            select = select + <?php echo '"' . _("Other location") . '"'; ?> + '</option></select></td>';
353
+                            select = select + <?php echo '"'._("Other location").'"'; ?> + '</option></select></td>';
354 354
                             if (type !== 'asp') {
355 355
                                 $('#row_' + type + '_institution').html('');
356 356
                                 $('#row_' + type + '_institution').append(shtml + select);
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
             $('#start_test_area').hide();
385 385
             return false;
386 386
         }
387
-        var comment = <?php echo '"' . _("Fetching realms list") . '..."'; ?>;
387
+        var comment = <?php echo '"'._("Fetching realms list").'..."'; ?>;
388 388
         inProgress(1, comment);
389 389
         $.ajax({
390 390
             url: "findRealm.php",
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
                     var realms = data.realms;
397 397
                     var realmselect = '';
398 398
                     if (realms.length > 1) {
399
-                        realmselect = <?php echo '"<td>' . _("Check realm(s):") . '</td>"'; ?>;
399
+                        realmselect = <?php echo '"<td>'._("Check realm(s):").'</td>"'; ?>;
400 400
                         realmselect = realmselect + '<td>' + "<span style='margin-left: 10px'>";
401 401
                         for (var i in realms) {
402 402
                             realmselect = realmselect + '<input type="radio" name="realm" ';
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
408 408
                         }
409 409
                         realmselect = realmselect + '</span></td>';
410 410
                     } else {
411
-                        realmselect = <?php echo '"<td>' . _("Realm:") . '</td>"'; ?>;
411
+                        realmselect = <?php echo '"<td>'._("Realm:").'</td>"'; ?>;
412 412
                         realmselect = realmselect + '<td>' + "<span style='margin-left: 10px'>";
413 413
                         realmselect = realmselect + realms[0] + '</span>';
414 414
                         realmselect = realmselect + '<input type="hidden" name="realm" value="' + realms[0] + '">';
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
             clear_sp_question();
461 461
             t = 1;
462 462
         }
463
-        var comment = <?php echo '"' . _("Running realm tests") . '..."'; ?>;
463
+        var comment = <?php echo '"'._("Running realm tests").'..."'; ?>;
464 464
         inProgress(1, comment);
465 465
         /*waiting(comment);*/
466 466
         $.ajax({
@@ -519,7 +519,7 @@  discard block
 block discarded – undo
519 519
         testSociopath('', answer);
520 520
     });
521 521
     $('#realmtest').click(function(event){
522
-        var comment = <?php echo '"<br><br>' . _("Running realm tests") . '..."'; ?>;
522
+        var comment = <?php echo '"<br><br>'._("Running realm tests").'..."'; ?>;
523 523
         inProgress(1, comment);
524 524
         $('#start_test_area').hide();
525 525
         if ($('#select_sp_area').is(':hidden')) {
@@ -567,13 +567,13 @@  discard block
 block discarded – undo
567 567
                         reset_footer();
568 568
                         testSociopath(realm, 0);
569 569
                     } else {
570
-                        var title = <?php echo '"' . _("Diagnostics results for selected realms") . '"'; ?>;
571
-                        result = '<div class="padding"><h3>' + <?php echo '"' . _("An unknown problem occured") . '"'; ?>;
570
+                        var title = <?php echo '"'._("Diagnostics results for selected realms").'"'; ?>;
571
+                        result = '<div class="padding"><h3>' + <?php echo '"'._("An unknown problem occured").'"'; ?>;
572 572
                         result = result + '</h3>'
573 573
                         if (r.length == 1) {
574
-                            result = result + <?php echo '"' . _("This test includes checking of the following realm") . '"'; ?>;
574
+                            result = result + <?php echo '"'._("This test includes checking of the following realm").'"'; ?>;
575 575
                         } else {    
576
-                            result = result + <?php echo '"' . _("This test includes checking of the following realms") . '"'; ?>;
576
+                            result = result + <?php echo '"'._("This test includes checking of the following realms").'"'; ?>;
577 577
                         }
578 578
                         result = result + ': '
579 579
                         for (var i=0; i < r.length; i++) {
@@ -583,7 +583,7 @@  discard block
 block discarded – undo
583 583
                             result = result + r[i];
584 584
                         }
585 585
                         result = result + '.<br>';
586
-                        result = result + <?php echo '"' . _("You should report this to") . '"'; ?> + ' <a href="mailto:[email protected]">[email protected]</a>';
586
+                        result = result + <?php echo '"'._("You should report this to").'"'; ?> + ' <a href="mailto:[email protected]">[email protected]</a>';
587 587
                         result = result + '</div>';
588 588
                         $('#after_stage_1').hide();
589 589
                         $('#before_stage_1').show();
@@ -651,43 +651,43 @@  discard block
 block discarded – undo
651 651
             success:function(data) {
652 652
                 if (data.status === 1) {
653 653
                     var result = '';
654
-                    var title = <?php echo '"' . _("eduroam admin report submission") . '"'; ?>;
654
+                    var title = <?php echo '"'._("eduroam admin report submission").'"'; ?>;
655 655
                     result = '<div class="padding">';
656 656
                     if (type == 'idp_send') {
657
-                        result = result + '<h3>'+ <?php echo '"' . _("SP contacting IdP due to technical problems or abuse") . '"'; ?> + '</h3>';
657
+                        result = result + '<h3>'+ <?php echo '"'._("SP contacting IdP due to technical problems or abuse").'"'; ?> + '</h3>';
658 658
                         result = result + '<table>';
659
-                        result = result + '<tr><td>' + <?php echo '"' . _("Reason") . '"'; ?> + '</td><td>' + data.reason + '</td></tr>';
660
-                        result = result + '<tr><td>' + <?php echo '"' . _("Event's timestamp") . '"'; ?> + '</td><td>' + data.timestamp + '</td></tr>';
661
-                        result = result + '<tr><td>' + <?php echo '"' . _("Calling-Station-Id") . '"'; ?> + '</td><td>' + data.mac + '</td></tr>';
662
-                        result = result + '<tr><td>' + <?php echo '"' . _("Additional description") . '"'; ?> +'</td><td>' + data.freetext + '</td></tr>';
663
-                        result = result + '<tr><td>' + <?php echo '"' . _("An email to contact the reporter") . '"'; ?> + '</td><td>' + data.email + '</td></tr>';
664
-                        result = result + '<tr><td>' + <?php echo '"' . _("Test result") . '" '; ?> +'</td><td>';
659
+                        result = result + '<tr><td>' + <?php echo '"'._("Reason").'"'; ?> + '</td><td>' + data.reason + '</td></tr>';
660
+                        result = result + '<tr><td>' + <?php echo '"'._("Event's timestamp").'"'; ?> + '</td><td>' + data.timestamp + '</td></tr>';
661
+                        result = result + '<tr><td>' + <?php echo '"'._("Calling-Station-Id").'"'; ?> + '</td><td>' + data.mac + '</td></tr>';
662
+                        result = result + '<tr><td>' + <?php echo '"'._("Additional description").'"'; ?> +'</td><td>' + data.freetext + '</td></tr>';
663
+                        result = result + '<tr><td>' + <?php echo '"'._("An email to contact the reporter").'"'; ?> + '</td><td>' + data.email + '</td></tr>';
664
+                        result = result + '<tr><td>' + <?php echo '"'._("Test result").'" '; ?> +'</td><td>';
665 665
                         if (data.tests_result == 1) {
666
-                            result = result + <?php echo '"' . _("failure") . '"'; ?>;
666
+                            result = result + <?php echo '"'._("failure").'"'; ?>;
667 667
                         } else {
668
-                            result = result + <?php echo '"' . _("success") . '"'; ?>;
668
+                            result = result + <?php echo '"'._("success").'"'; ?>;
669 669
                         }
670 670
                         result = result + '</td></tr>';
671
-                        result = result + '<tr><td>' + <?php echo '"' . _("Test URL") . '" '; ?> +'</td><td><a href="' + data.testurl + '">' + data.testurl + '</a></td></tr>';
672
-                        result = result + '<tr><td>' + <?php echo '"' . _("Email to IdP administrators ") . '"'; ?> + ' ';
671
+                        result = result + '<tr><td>' + <?php echo '"'._("Test URL").'" '; ?> +'</td><td><a href="' + data.testurl + '">' + data.testurl + '</a></td></tr>';
672
+                        result = result + '<tr><td>' + <?php echo '"'._("Email to IdP administrators ").'"'; ?> + ' ';
673 673
                         if (data.emailsent == 1) {
674
-                            result = result + <?php echo '"' . _("send successfully") . '"'; ?>;
674
+                            result = result + <?php echo '"'._("send successfully").'"'; ?>;
675 675
                         } else {
676
-                            result = result + <?php echo '"' . _("not sent - failure while sending") . '"'; ?>;
676
+                            result = result + <?php echo '"'._("not sent - failure while sending").'"'; ?>;
677 677
                         }
678 678
                         result = result + '</td><td></td></tr>';
679 679
                     }
680 680
                     if (type == 'sp_send') {
681
-                        result = result + '<h3>'+ <?php echo '"' . _("IdP contacting SP due to technical problems or abuse") . '"'; ?> + '</h3>';
681
+                        result = result + '<h3>'+ <?php echo '"'._("IdP contacting SP due to technical problems or abuse").'"'; ?> + '</h3>';
682 682
                         result = result + '<table>';
683
-                        result = result + '<tr><td>' + <?php echo '"' . _("Reason") . '"'; ?> + '</td><td>' + data.reason + '</td></tr>';
684
-                        result = result + '<tr><td>' + <?php echo '"' . _("SP's Operator-Name") . '"'; ?> + '</td><td>' + data.opname + '</td></tr>';
685
-                        result = result + '<tr><td>' + <?php echo '"' . _("User's outer ID") . '"'; ?> + '</td><td>' + data.outerid + '</td></tr>';
686
-                        result = result + '<tr><td>' + <?php echo '"' . _("IdP email") . '"'; ?> + '</td><td>' + data.email + '</td></tr>';
687
-                        result = result + '<tr><td>' + <?php echo '"' . _("Event's timestamp") . '"'; ?> + '</td><td>' + data.timestamp + '</td></tr>';
688
-                        result = result + '<tr><td>' + <?php echo '"' . _("Calling-Station-Id") . '"'; ?> + '</td><td>' + data.mac + '</td></tr>';
689
-                        result = result + '<tr><td>' + <?php echo '"' . _("Additional description") . '"'; ?> +'</td><td>' + data.freetext + '</td></tr>';
690
-                        result = result + '<tr><td>' + <?php echo '"' . _("How to contact the user") . '"'; ?> +'</td><td>' + data.cdetails + '</td></tr>';
683
+                        result = result + '<tr><td>' + <?php echo '"'._("Reason").'"'; ?> + '</td><td>' + data.reason + '</td></tr>';
684
+                        result = result + '<tr><td>' + <?php echo '"'._("SP's Operator-Name").'"'; ?> + '</td><td>' + data.opname + '</td></tr>';
685
+                        result = result + '<tr><td>' + <?php echo '"'._("User's outer ID").'"'; ?> + '</td><td>' + data.outerid + '</td></tr>';
686
+                        result = result + '<tr><td>' + <?php echo '"'._("IdP email").'"'; ?> + '</td><td>' + data.email + '</td></tr>';
687
+                        result = result + '<tr><td>' + <?php echo '"'._("Event's timestamp").'"'; ?> + '</td><td>' + data.timestamp + '</td></tr>';
688
+                        result = result + '<tr><td>' + <?php echo '"'._("Calling-Station-Id").'"'; ?> + '</td><td>' + data.mac + '</td></tr>';
689
+                        result = result + '<tr><td>' + <?php echo '"'._("Additional description").'"'; ?> +'</td><td>' + data.freetext + '</td></tr>';
690
+                        result = result + '<tr><td>' + <?php echo '"'._("How to contact the user").'"'; ?> +'</td><td>' + data.cdetails + '</td></tr>';
691 691
                     }
692 692
                     result = result + '</div>';
693 693
                     showInfo(result, title);
@@ -712,7 +712,7 @@  discard block
 block discarded – undo
712 712
                         $(this).removeClass('visible_row').addClass('hidden_row');
713 713
                     }
714 714
                 });
715
-                $('#admin_realm').attr('title', <?php echo '"' . _("Wrong format of realm") . '"'; ?>);
715
+                $('#admin_realm').attr('title', <?php echo '"'._("Wrong format of realm").'"'; ?>);
716 716
             } else {
717 717
                 $('#admin_realm').removeClass('error_input');
718 718
                 $('#admin_realm').attr('title', '');
@@ -722,7 +722,7 @@  discard block
 block discarded – undo
722 722
     $(document).on('keyup change', '#email' , function() {
723 723
         if ($(this).val().length == 0 || !isEmail($(this).val())) {
724 724
             $('#email').addClass('error_input');
725
-            $('#email').attr('title', <?php echo '"' . _("Wrong format of email") . '"'; ?>);
725
+            $('#email').attr('title', <?php echo '"'._("Wrong format of email").'"'; ?>);
726 726
         } else {
727 727
             $('#email').removeClass('error_input');
728 728
             $('#email').attr('title', '');
@@ -735,7 +735,7 @@  discard block
 block discarded – undo
735 735
         if ($('#mac').val().length > 0) {
736 736
             if ($('#mac').val().length != 17) {
737 737
                 $('#mac').addClass('error_input');
738
-                $('#mac').attr('title', <?php echo '"' . _("MAC address is incomplete") . '"'; ?>);
738
+                $('#mac').attr('title', <?php echo '"'._("MAC address is incomplete").'"'; ?>);
739 739
             } else {
740 740
                 $('#mac').removeClass('error_input'); 
741 741
                 $('#mac').attr('title', '');
@@ -744,7 +744,7 @@  discard block
 block discarded – undo
744 744
         if ($(this).attr('id') == 'email' &&  $(this).val().length > 0) {
745 745
             if (!isEmail($(this).val())) {
746 746
                 $('#email').addClass('error_input');
747
-                $('#email').attr('title', <?php echo '"' . _("Wrong format of email") . '"'; ?>);
747
+                $('#email').attr('title', <?php echo '"'._("Wrong format of email").'"'; ?>);
748 748
             } else {
749 749
                 $('#email').removeClass('error_input');
750 750
                 $('#email').attr('title', '');
@@ -753,7 +753,7 @@  discard block
 block discarded – undo
753 753
         if ($(this).attr('id') == 'outer_id' &&  $(this).val().length > 0) {
754 754
             if (!isEmail($(this).val(), true)) {
755 755
                 $('#outer_id').addClass('error_input');
756
-                $('#outer_id').attr('title', <?php echo '"' . _("Wrong format of outer ID") . '"'; ?>);
756
+                $('#outer_id').attr('title', <?php echo '"'._("Wrong format of outer ID").'"'; ?>);
757 757
             } else {
758 758
                 $('#outer_id').removeClass('error_input');
759 759
                 $('#outer_id').attr('title', '');
@@ -762,7 +762,7 @@  discard block
 block discarded – undo
762 762
         if ($(this).attr('id') == 'opname' && $('#opname').val().length > 0) {
763 763
             if (!isOperatorName($(this).val())) {
764 764
                 $('#opname').addClass('error_input');
765
-                $('#opname').attr('title', <?php echo '"' . _("Wrong string given as OperatorName") . '"'; ?>);
765
+                $('#opname').attr('title', <?php echo '"'._("Wrong string given as OperatorName").'"'; ?>);
766 766
                 $('#spmanually').show();
767 767
             } else {
768 768
                 $('#opname').removeClass('error_input');
Please login to merge, or discard this patch.