GEANT / CAT

web/admin/lib/view/html/UnaryTag.php

Spacing +9 added lines, -9 removed lines

@@ -32,11 +32,11 @@ 
      * 
      * @param string $name
      */
-    public function __construct($name){
+    public function __construct($name) {
         $this->name = $name;
     }
     
-    public function setTab($tab){
+    public function setTab($tab) {
         $this->tab = $tab;
     }
     
@@ -45,7 +45,7 @@ 
      * @param string $name
      * @param string $value
      */
-    public function addAttribute($name, $value){
+    public function addAttribute($name, $value) {
         $this->attributes [] = new Attribute($name, $value);
     }
     
@@ -54,18 +54,18 @@ 
      * @param string $attributeString
      * @return string
      */
-    protected function composeTagString($attributeString){
-        return "\n" . $this->tab . "<".$this->name.$attributeString.">";
+    protected function composeTagString($attributeString) {
+        return "\n" . $this->tab . "<" . $this->name . $attributeString . ">";
     }
     
-    public function __toString(){
+    public function __toString() {
         $attributeString = "";
         foreach ($this->attributes as $attribute) {
             $attributeString .= $attribute;
         }
-        if(isset($this->name)){
+        if (isset($this->name)) {
             return $this->composeTagString($attributeString);
-        }else{
+        } else {
             return "";
         }
     }
@@ -75,7 +75,7 @@ 
      * {@inheritDoc}
      * @see \lib\html\PageElement::render()
      */
-    public function render(){
+    public function render() {
         echo $this->__toString();
     }
     

Braces +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     public function __toString(){
         if(!empty($this->name) && !empty($this->value)){
             return ' ' . $this->name . '="' . $this->value . '"';
-        }else{
+        } else{
             return '';
         }
     }

web/admin/lib/view/html/Attribute.php

Braces +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     public function __toString(){
         if(!empty($this->name) && !empty($this->value)){
             return ' ' . $this->name . '="' . $this->value . '"';
-        }else{
+        } else{
             return '';
         }
     }

Spacing +5 added lines, -5 removed lines

@@ -7,7 +7,7 @@ 
  * @author Zilvinas Vaira
  *
  */
-class Attribute implements HtmlElement{
+class Attribute implements HtmlElement {
     
     /**
      * 
@@ -26,15 +26,15 @@ 
      * @param string $name
      * @param string $value
      */
-    public function __construct($name, $value){
+    public function __construct($name, $value) {
         $this->name = str_replace('"', '', $name);
         $this->value = str_replace('"', '', $value);
     }
     
-    public function __toString(){
-        if(!empty($this->name) && !empty($this->value)){
+    public function __toString() {
+        if (!empty($this->name) && !empty($this->value)) {
             return ' ' . $this->name . '="' . $this->value . '"';
-        }else{
+        } else {
             return '';
         }
     }

web/admin/lib/view/html/JSButton.php

Spacing +3 added lines, -3 removed lines

@@ -6,7 +6,7 @@ 
  * @author Zilvinas Vaira
  *
  */
-class JSButton extends Button{
+class JSButton extends Button {
     
     const REVOKE_CREDENTIAL_ACTION = 'revokeCredential';
     const DELETE_USER_ACTION = 'deleteUser';
@@ -16,12 +16,12 @@ 
     
     private $action = "";
     
-    public function __construct($title, $action, $name = '', $value = '', $type = 'button', $class = ''){
+    public function __construct($title, $action, $name = '', $value = '', $type = 'button', $class = '') {
         parent::__construct($title, $type, $name, $value, $class);
         $this->action = $action;
     }
     
     protected function composeNameValueString() {
-        return ' onclick="'.$this->action.'(\''.$this->name.'\',\''.$this->value.'\')"';
+        return ' onclick="' . $this->action . '(\'' . $this->name . '\',\'' . $this->value . '\')"';
     }
 }
\ No newline at end of file

web/admin/lib/view/InfoBlockTable.php

Spacing +5 added lines, -5 removed lines

@@ -4,7 +4,7 @@ 
 use lib\view\html\Table;
 use lib\view\html\Row;
 
-class InfoBlockTable implements PageElement{
+class InfoBlockTable implements PageElement {
     
     /**
      * 
@@ -18,22 +18,22 @@ 
      */
     private $decorator;
     
-    public function __construct($title){
+    public function __construct($title) {
         $this->table = new Table();
         $this->table->addAttribute("cellpadding", 5);
-        $this->decorator = new TitledBlockDecorator($this->table, $title,  PageElement::INFOBLOCK_CLASS);
+        $this->decorator = new TitledBlockDecorator($this->table, $title, PageElement::INFOBLOCK_CLASS);
     }
     
     /**
      * @param array $rowArray
      */
-    public function addRow($rowArray){
+    public function addRow($rowArray) {
         $row = new Row($rowArray);
         $row->addCellAttribute(0, 'style', 'font-weight:bold;');
         $this->table->addRow($row);
     }
     
-    public function render(){
+    public function render() {
         $this->decorator->render();
     }
 }
\ No newline at end of file

web/admin/lib/view/Page.php

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
  * @author Zilvinas Vaira
  *
  */
-interface Page{
+interface Page {
     
     /**
      * 

web/admin/lib/view/TitledBlockDecorator.php

Spacing +2 added lines, -2 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 namespace lib\view;
 
-class TitledBlockDecorator extends PageElementDecorator{
+class TitledBlockDecorator extends PageElementDecorator {
     
     /**
      * 
@@ -15,7 +15,7 @@ 
      * @param string $class
      * @param string $title
      */
-    public function __construct($element, $title, $class = ""){
+    public function __construct($element, $title, $class = "") {
         parent::__construct($element, $class);
         $this->title = $title;
         

tests/unit/lib/view/html/CompositeTagTest.php

Spacing +4 added lines, -4 removed lines

@@ -3,13 +3,13 @@ 
 use lib\view\html\CompositeTag;
 use lib\view\html\Tag;
 
-class CompositeTagTest extends \PHPUnit_Framework_TestCase{
+class CompositeTagTest extends \PHPUnit_Framework_TestCase {
     
     private $compositeTag;
     
     private $tag;
     
-    protected function setup(){
+    protected function setup() {
         $this->compositeTag = new CompositeTag('div');
         $this->tag = new Tag('p');
     }
@@ -24,7 +24,7 @@ 
         $this->assertTrue(in_array($this->tag, $tags));
     }
     
-    public function testToString(){
+    public function testToString() {
         $string = $this->compositeTag->__toString();
         $this->assertEquals('<div>', substr(trim($string), 0, 5));
         $this->assertEquals('</div>', substr(trim($string), -6));
@@ -34,7 +34,7 @@ 
         $this->assertEquals('<div>', substr(trim($string), 0, 5));
         $this->assertEquals('</div>', substr(trim($string), -6));
         
-        $string = str_replace(array('<div>','</div>'), '', $string);
+        $string = str_replace(array('<div>', '</div>'), '', $string);
         $this->assertEquals('<p>', substr(trim($string), 0, 3));
         $this->assertEquals('</p>', substr(trim($string), -4));
     }

tests/unit/lib/view/html/ButtonTest.php

Spacing +6 added lines, -6 removed lines

@@ -2,11 +2,11 @@ 
 
 use lib\view\html\Button;
 
-class ButtonTest extends \PHPUnit_Framework_TestCase{
+class ButtonTest extends \PHPUnit_Framework_TestCase {
     
     private $title;
     
-    protected function setup(){
+    protected function setup() {
         $this->title = 'Some title';
     }
     
@@ -27,10 +27,10 @@ 
         $button = new Button($this->title, $type, $name, $value, $class);
         $string = $button->__toString();
     
-        $this->assertNotEquals(strpos($string, 'type="'.$type.'"'), false);
-        $this->assertNotEquals(strpos($string, 'name="'.$name.'"'), false);
-        $this->assertNotEquals(strpos($string, 'value="'.$value.'"'), false);
-        $this->assertNotEquals(strpos($string, 'class="'.$class.'"'), false);
+        $this->assertNotEquals(strpos($string, 'type="' . $type . '"'), false);
+        $this->assertNotEquals(strpos($string, 'name="' . $name . '"'), false);
+        $this->assertNotEquals(strpos($string, 'value="' . $value . '"'), false);
+        $this->assertNotEquals(strpos($string, 'class="' . $class . '"'), false);
         $this->assertNotEquals(strpos($string, $this->title), false);
     }
     

tests/unit/lib/view/InstitutionPageBuilderTest.php

Spacing +10 added lines, -10 removed lines

@@ -5,32 +5,32 @@
 
 const CONFIG = ['APPEARANCE' => ['productname' => 'Test Product']];
 
-function valid_IdP($input, $owner){
-    if ($input == 1){
+function valid_IdP($input, $owner) {
+    if ($input == 1) {
         return new MockInstitution();
-    }else{
-        throw new Exception('IdP '.$input.' not found in database!');
+    } else {
+        throw new Exception('IdP ' . $input . ' not found in database!');
     }
 }
 
-class MockInstitution{
+class MockInstitution {
     public $name = "Test name";
 }
 
-class InstitutionPageBuilderTest extends \PHPUnit_Framework_TestCase{
+class InstitutionPageBuilderTest extends \PHPUnit_Framework_TestCase {
     
     protected function setup() {
         $_SESSION['user'] = "user";
     }
     
-    public function testConstructorSuccess(){
-        $_GET['inst_id']=1;
+    public function testConstructorSuccess() {
+        $_GET['inst_id'] = 1;
         $builder = new InstitutionPageBuilder("Testing Page", PageBuilder::ADMIN_IDP_USERS);
         $this->assertTrue($builder->isReady());
     }
     
-    public function testConstructorFailure(){
-        $_GET['inst_id']=-1;
+    public function testConstructorFailure() {
+        $_GET['inst_id'] = -1;
         $builder = new InstitutionPageBuilder("Testing Page", PageBuilder::ADMIN_IDP_USERS);
         $this->assertFalse($builder->isReady());
         

Braces +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 function valid_IdP($input, $owner){
     if ($input == 1){
         return new MockInstitution();
-    }else{
+    } else{
         throw new Exception('IdP '.$input.' not found in database!');
     }
 }