Test Failed
Push — master ( 8a6b78...bb7a16 )
by Maja
25:00
created
web/admin/edit_hotspot.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 $deco = new \web\lib\admin\PageDecoration();
32 32
 $validator = new \web\lib\common\InputValidation();
@@ -36,12 +36,12 @@  discard block
 block discarded – undo
36 36
 $myfed = new \core\Federation($my_inst->federation);
37 37
 
38 38
 if (!isset($_GET['deployment_id'])) {
39
-    if (isset($_POST['consortium']) && ( $_POST['consortium'] == "eduroam" ||
40
-            ( $_POST['consortium'] == "OpenRoaming" && count($myfed->getAttributes("fed:openroaming")) > 0 )
39
+    if (isset($_POST['consortium']) && ($_POST['consortium'] == "eduroam" ||
40
+            ($_POST['consortium'] == "OpenRoaming" && count($myfed->getAttributes("fed:openroaming")) > 0)
41 41
             )
42 42
     ) {
43 43
         $my_inst->newDeployment(\core\AbstractDeployment::DEPLOYMENTTYPE_MANAGED, $_POST['consortium']);
44
-        header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
44
+        header("Location: overview_org.php?inst_id=".$my_inst->identifier);
45 45
         exit(0);
46 46
     } else {
47 47
         throw new Exception("Desired consortium for Managed SP needs to be specified, and allowed!");
@@ -99,19 +99,19 @@  discard block
 block discarded – undo
99 99
                 if (isset($_POST['agreement']) && $_POST['agreement'] == "true") {
100 100
                     $deployment->addAttribute("hiddenmanagedsp:tou_accepted", NULL, 1);
101 101
                 }
102
-                header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
102
+                header("Location: overview_org.php?inst_id=".$my_inst->identifier);
103 103
                 exit(0);
104 104
             case web\lib\common\FormElements::BUTTON_DELETE:
105 105
                 $response = $deployment->setRADIUSconfig();
106 106
                 if (in_array('OK', $response)) {
107 107
                     $deployment->deactivate();
108 108
                 }
109
-                header("Location: overview_org.php?inst_id=" . $my_inst->identifier . '&' . urldecode(http_build_query($response)));
109
+                header("Location: overview_org.php?inst_id=".$my_inst->identifier.'&'.urldecode(http_build_query($response)));
110 110
                 exit(0);
111 111
             case web\lib\common\FormElements::BUTTON_REMOVESP:
112 112
                 error_log("MGW Remove deployment ".serialize($deployment));
113 113
                 $deployment->remove();
114
-                header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
114
+                header("Location: overview_org.php?inst_id=".$my_inst->identifier);
115 115
                 exit(0);
116 116
             case web\lib\common\FormElements::BUTTON_ACTIVATE:
117 117
                 if (count($deployment->getAttributes("hiddenmanagedsp:tou_accepted")) > 0) {
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
                     if (in_array('OK', $response)) {
120 120
                         $deployment->activate();
121 121
                     }
122
-                    header("Location: overview_org.php?inst_id=" . $my_inst->identifier . '&' . urldecode(http_build_query($response)));
122
+                    header("Location: overview_org.php?inst_id=".$my_inst->identifier.'&'.urldecode(http_build_query($response)));
123 123
                     exit(0);
124 124
                 } else {
125 125
                     throw new Exception("Activate button pushed without acknowledged ToUs!");
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
                 } else {
149 149
                     $response = ['NOOP', 'NOOP'];
150 150
                 }
151
-                header("Location: overview_org.php?inst_id=" . $my_inst->identifier . '&' . urldecode(http_build_query($response)));
151
+                header("Location: overview_org.php?inst_id=".$my_inst->identifier.'&'.urldecode(http_build_query($response)));
152 152
                 exit(0);
153 153
             default:
154 154
                 throw new Exception("Unknown button action requested!");
@@ -157,10 +157,10 @@  discard block
 block discarded – undo
157 157
     if (isset($_POST['command'])) {
158 158
         switch ($_POST['command']) {
159 159
         case web\lib\common\FormElements::BUTTON_CLOSE:
160
-            header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
160
+            header("Location: overview_org.php?inst_id=".$my_inst->identifier);
161 161
             exit(0);
162 162
         default:
163
-            header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
163
+            header("Location: overview_org.php?inst_id=".$my_inst->identifier);
164 164
             exit(0);
165 165
         }
166 166
     }
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
     echo $uiElements->instLevelInfoBoxes($my_inst);
188 188
     $deploymentOptions = $deployment->getAttributes();
189 189
     echo "<form enctype='multipart/form-data' action='edit_hotspot.php?inst_id=$my_inst->identifier&amp;deployment_id=$deployment->identifier' method='post' accept-charset='UTF-8'>
190
-                <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::MAX_UPLOAD_SIZE . "'>";
190
+                <input type='hidden' name='MAX_FILE_SIZE' value='".\config\Master::MAX_UPLOAD_SIZE."'>";
191 191
     $optionDisplay = new \web\lib\admin\OptionDisplay($deploymentOptions, \core\Options::LEVEL_PROFILE);
192 192
     ?>
193 193
     <fieldset class='option_container' id='managedsp_override'>
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
                 <!-- input for VLAN identifier for home users-->
222 222
                 <td>
223 223
                     <span id='vlan_label'>
224
-                        <?php echo sprintf(_("VLAN tag for own users%s:"), ($vlan === NULL ? "" : " " . _("(unset with '0')"))); ?>
224
+                        <?php echo sprintf(_("VLAN tag for own users%s:"), ($vlan === NULL ? "" : " "._("(unset with '0')"))); ?>
225 225
                     </span>
226 226
                 </td>
227 227
                 <td>
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
     </fieldset>
242 242
 
243 243
     <?php
244
-    echo "<p><button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_SAVE . "'>" . _("Save data") . "</button><button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_org.php?inst_id=$my_inst->identifier\"'>" . _("Discard changes") . "</button></p></form>";
244
+    echo "<p><button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_SAVE."'>"._("Save data")."</button><button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_org.php?inst_id=$my_inst->identifier\"'>"._("Discard changes")."</button></p></form>";
245 245
     echo $deco->footer();
246 246
 
247 247
     
248 248
\ No newline at end of file
Please login to merge, or discard this patch.
core/DeploymentManaged.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
                 $serverCandidates[IdPlist::geoDistance($adminLocation, ['lat' => $iterator->location_lat, 'lon' => $iterator->location_lon])] = $iterator->server_id;
291 291
             }
292 292
             if ($clients > $maxSupportedClients * 0.9) {
293
-                $this->loggerInstance->debug(1, "A RADIUS server for Managed SP (" . $iterator->server_id . ") is serving at more than 90% capacity!");
293
+                $this->loggerInstance->debug(1, "A RADIUS server for Managed SP (".$iterator->server_id.") is serving at more than 90% capacity!");
294 294
             }
295 295
         }
296 296
         if (count($serverCandidates) == 0 && $federation != "DEFAULT") {
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
             $conditional1 = "AND activity_time > DATE_SUB(NOW(), INTERVAL $backlog SECOND)";
330 330
             $conditional2 = "";
331 331
         }
332
-        $stats = $this->databaseHandle->exec("SELECT activity_time, realm, mac, cui, result FROM activity WHERE operatorname = ? $conditional1 ORDER BY activity_time $conditional2", "s", $opName );
332
+        $stats = $this->databaseHandle->exec("SELECT activity_time, realm, mac, cui, result FROM activity WHERE operatorname = ? $conditional1 ORDER BY activity_time $conditional2", "s", $opName);
333 333
         return mysqli_fetch_all($stats, \MYSQLI_ASSOC);
334 334
     }
335 335
         
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
     {
447 447
         $customAttrib = $this->getAttributes("managedsp:operatorname");
448 448
         if (count($customAttrib) == 0) {
449
-            return "1sp." . $this->identifier . "-" . $this->institution . \config\ConfAssistant::SILVERBULLET['realm_suffix'];
449
+            return "1sp.".$this->identifier."-".$this->institution.\config\ConfAssistant::SILVERBULLET['realm_suffix'];
450 450
         }
451 451
         return $customAttrib[0]["value"];
452 452
     }
@@ -462,13 +462,13 @@  discard block
 block discarded – undo
462 462
     {
463 463
 
464 464
         $hostname = "radius_hostname_$idx";
465
-        $ch = curl_init("http://" . $this->$hostname);
465
+        $ch = curl_init("http://".$this->$hostname);
466 466
         if ($ch === FALSE) {
467 467
             $res = 'FAILURE';
468 468
         } else {
469 469
             curl_setopt($ch, CURLOPT_POST, 1);
470 470
             curl_setopt($ch, CURLOPT_POSTFIELDS, $post);
471
-            $this->loggerInstance->debug(1, "Posting to http://" . $this->$hostname . ": $post\n");
471
+            $this->loggerInstance->debug(1, "Posting to http://".$this->$hostname.": $post\n");
472 472
             curl_setopt($ch, CURLOPT_FOLLOWLOCATION, 1);
473 473
             curl_setopt($ch, CURLOPT_HEADER, 0);
474 474
             curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
@@ -507,19 +507,19 @@  discard block
 block discarded – undo
507 507
         } else {
508 508
             $txt = $remove ? _('Profile deactivation failed') : _('Profile activation/modification failed');
509 509
         }
510
-        $txt = $txt . ' ';
510
+        $txt = $txt.' ';
511 511
         if (array_count_values($response)[$status] == 2) {
512
-            $txt = $txt . _('on both RADIUS servers: primary and backup') . '.';
512
+            $txt = $txt._('on both RADIUS servers: primary and backup').'.';
513 513
         } else {
514 514
             if ($response['res[1]'] == $status) {
515
-                $txt = $txt . _('on primary RADIUS server') . '.';
515
+                $txt = $txt._('on primary RADIUS server').'.';
516 516
             } else {
517
-                $txt = $txt . _('on backup RADIUS server') . '.';
517
+                $txt = $txt._('on backup RADIUS server').'.';
518 518
             }
519 519
         }
520 520
         $mail = \core\common\OutsideComm::mailHandle();
521 521
         $email = $this->getAttributes("support:email")[0]['value'];
522
-        $mail->FromName = \config\Master::APPEARANCE['productname'] . " Notification System";
522
+        $mail->FromName = \config\Master::APPEARANCE['productname']." Notification System";
523 523
         $mail->addAddress($email);
524 524
         if ($status == 'OK') {
525 525
             $mail->Subject = _('RADIUS profile update problem fixed');
@@ -553,7 +553,7 @@  discard block
 block discarded – undo
553 553
             return NULL;
554 554
         }
555 555
         $timeout = 10;
556
-        curl_setopt($ch, CURLOPT_URL, 'http://' . $host);
556
+        curl_setopt($ch, CURLOPT_URL, 'http://'.$host);
557 557
         curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
558 558
         curl_setopt($ch, CURLOPT_TIMEOUT, $timeout);
559 559
         curl_exec($ch);
@@ -645,33 +645,33 @@  discard block
 block discarded – undo
645 645
     {
646 646
         $remove = ($this->status == \core\AbstractDeployment::INACTIVE) ? 0 : 1;
647 647
         $toPost = ($onlyone ? array($onlyone => '') : array(1 => '', 2 => ''));
648
-        $toPostTemplate = 'instid=' . $this->institution . '&deploymentid=' . $this->identifier . '&secret=' . $this->secret . '&country=' . $this->getAttributes("internal:country")[0]['value'] . '&';
648
+        $toPostTemplate = 'instid='.$this->institution.'&deploymentid='.$this->identifier.'&secret='.$this->secret.'&country='.$this->getAttributes("internal:country")[0]['value'].'&';
649 649
         if ($remove) {
650
-            $toPostTemplate = $toPostTemplate . 'remove=1&';
650
+            $toPostTemplate = $toPostTemplate.'remove=1&';
651 651
         } else {
652
-            $toPostTemplate = $toPostTemplate . 'operatorname=' . $this->getOperatorName() . '&'; 
652
+            $toPostTemplate = $toPostTemplate.'operatorname='.$this->getOperatorName().'&'; 
653 653
             if ($this->getAttributes("managedsp:vlan")[0]['value'] ?? NULL) {
654 654
                 $allRealms = $this->getAllRealms();
655 655
                 if (!empty($allRealms)) {
656
-                    $toPostTemplate = $toPostTemplate . 'vlan=' . $this->getAttributes("managedsp:vlan")[0]['value'] . '&';
657
-                    $toPostTemplate = $toPostTemplate . 'realmforvlan[]=' . implode('&realmforvlan[]=', $allRealms) . '&';
656
+                    $toPostTemplate = $toPostTemplate.'vlan='.$this->getAttributes("managedsp:vlan")[0]['value'].'&';
657
+                    $toPostTemplate = $toPostTemplate.'realmforvlan[]='.implode('&realmforvlan[]=', $allRealms).'&';
658 658
                 }
659 659
             }
660 660
         }
661 661
         foreach (array_keys($toPost) as $key) {
662
-            $elem = 'port' . $key;
663
-            $toPost[$key] = $toPostTemplate . 'port=' . $this->$elem;
662
+            $elem = 'port'.$key;
663
+            $toPost[$key] = $toPostTemplate.'port='.$this->$elem;
664 664
         }
665 665
         $response = array();
666 666
         foreach ($toPost as $key => $value) {
667
-            $this->loggerInstance->debug(1, 'toPost ' . $toPost[$key] . "\n");
668
-            $response['res[' . $key . ']'] = $this->sendToRADIUS($key, $toPost[$key]);
667
+            $this->loggerInstance->debug(1, 'toPost '.$toPost[$key]."\n");
668
+            $response['res['.$key.']'] = $this->sendToRADIUS($key, $toPost[$key]);
669 669
         }
670 670
         if ($onlyone) {
671
-            $response['res[' . ($onlyone == 1) ? 2 : 1 . ']'] = \core\AbstractDeployment::RADIUS_OK;
671
+            $response['res['.($onlyone == 1) ? 2 : 1.']'] = \core\AbstractDeployment::RADIUS_OK;
672 672
         }
673 673
         foreach (array('OK', 'FAILURE') as $status) {
674
-            if ( ( ($status == 'OK' && $notify) || ($status == 'FAILURE') ) && ( in_array($status, $response) ) ) {
674
+            if ((($status == 'OK' && $notify) || ($status == 'FAILURE')) && (in_array($status, $response))) {
675 675
                 $this->sendMailtoAdmin($remove, $response, $status);
676 676
             }
677 677
         }
Please login to merge, or discard this patch.
web/lib/admin/UIElements.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
             sprintf(_("%s: Do not terminate EAP"), \core\ProfileSilverbullet::PRODUCTNAME) => "fed:silverbullet-noterm",
137 137
             sprintf(_("%s: max users per profile"), \core\ProfileSilverbullet::PRODUCTNAME) => "fed:silverbullet-maxusers",
138 138
             sprintf(_("Mint %s with CA on creation"), $this->nomenclatureIdP) => "fed:minted_ca_file",
139
-            sprintf(_("OpenRoaming: Allow %s Opt-In"),$this->nomenclatureParticipant) => "fed:openroaming",
139
+            sprintf(_("OpenRoaming: Allow %s Opt-In"), $this->nomenclatureParticipant) => "fed:openroaming",
140 140
             _("OpenRoaming: Custom NAPTR Target") => "fed:openroaming_customtarget",
141 141
             $ssidText => "media:SSID",
142 142
             $passpointOiText => "media:consortium_OI",
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         $find = array_keys($displayNames, $input, TRUE);
149 149
 
150 150
         if (count($find) == 0) { // this is an error! throw an Exception
151
-            throw new \Exception("The translation of an option name was requested, but the option is not known to the system: " . htmlentities($input));
151
+            throw new \Exception("The translation of an option name was requested, but the option is not known to the system: ".htmlentities($input));
152 152
         }
153 153
         \core\common\Entity::outOfThePotatoes();
154 154
         // none of the strings have HTML in them, only translators can provide own text for it -> no threat, but complained about by the security review
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 
171 171
         foreach ($optionlist as $option) {
172 172
             $type = $optioninfo->optionType($option['name']);
173
-            if (preg_match('/^' . $class . '/', $option['name']) && $option['level'] == "$level") {
173
+            if (preg_match('/^'.$class.'/', $option['name']) && $option['level'] == "$level") {
174 174
                 // all non-multilang attribs get this assignment ...
175 175
                 $language = "";
176 176
                 $content = $option['value'];
@@ -188,19 +188,19 @@  discard block
 block discarded – undo
188 188
                         $locationMarkers[] = $coords;
189 189
                         break;
190 190
                     case "file":
191
-                        $retval .= "<tr><td>" . $this->displayName($option['name']) . "</td><td>$language</td><td>";
191
+                        $retval .= "<tr><td>".$this->displayName($option['name'])."</td><td>$language</td><td>";
192 192
                         switch ($option['name']) {
193 193
                             case "general:logo_file":
194 194
                             case "fed:logo_file":
195
-                                $retval .= $this->previewImageinHTML('ROWID-' . $option['level'] . '-' . $option['row']);
195
+                                $retval .= $this->previewImageinHTML('ROWID-'.$option['level'].'-'.$option['row']);
196 196
                                 break;
197 197
                             case "eap:ca_file":
198 198
                             // fall-through intended: display both the same way
199 199
                             case "fed:minted_ca_file":
200
-                                $retval .= $this->previewCAinHTML('ROWID-' . $option['level'] . '-' . $option['row']);
200
+                                $retval .= $this->previewCAinHTML('ROWID-'.$option['level'].'-'.$option['row']);
201 201
                                 break;
202 202
                             case "support:info_file":
203
-                                $retval .= $this->previewInfoFileinHTML('ROWID-' . $option['level'] . '-' . $option['row']);
203
+                                $retval .= $this->previewInfoFileinHTML('ROWID-'.$option['level'].'-'.$option['row']);
204 204
                                 break;
205 205
                             default:
206 206
                         }
@@ -210,10 +210,10 @@  discard block
 block discarded – undo
210 210
                             // do not display the option at all; it gets auto-set by the ProfileSilverbullet constructor and doesn't have to be seen
211 211
                             break;
212 212
                         }
213
-                        $retval .= "<tr><td>" . $this->displayName($option['name']) . "</td><td>$language</td><td><strong>" . ($content == "on" ? _("on") : _("off") ) . "</strong></td></tr>";
213
+                        $retval .= "<tr><td>".$this->displayName($option['name'])."</td><td>$language</td><td><strong>".($content == "on" ? _("on") : _("off"))."</strong></td></tr>";
214 214
                         break;
215 215
                     default:
216
-                        $retval .= "<tr><td>" . $this->displayName($option['name']) . "</td><td>$language</td><td><strong>$content</strong></td></tr>";
216
+                        $retval .= "<tr><td>".$this->displayName($option['name'])."</td><td>$language</td><td><strong>$content</strong></td></tr>";
217 217
                 }
218 218
             }
219 219
         }
@@ -222,11 +222,11 @@  discard block
 block discarded – undo
222 222
             $locationCount = 0;
223 223
             foreach ($locationMarkers as $g) {
224 224
                 $locationCount++;
225
-                $marker .= '<marker name="' . $locationCount . '" lat="' . $g['lat'] . '" lng="' . $g['lon'] . '" />';
225
+                $marker .= '<marker name="'.$locationCount.'" lat="'.$g['lat'].'" lng="'.$g['lon'].'" />';
226 226
             }
227 227
             $marker .= '<\/markers>'; // some validator says this should be escaped
228 228
             $jMarker = json_encode($locationMarkers);
229
-            $retval .= '<tr><td><script>markers=\'' . $marker . '\'; jmarkers = \'' . $jMarker . '\';</script></td><td></td><td></td></tr>';
229
+            $retval .= '<tr><td><script>markers=\''.$marker.'\'; jmarkers = \''.$jMarker.'\';</script></td><td></td><td></td></tr>';
230 230
         }
231 231
         \core\common\Entity::outOfThePotatoes();
232 232
         return $retval;
@@ -242,11 +242,11 @@  discard block
 block discarded – undo
242 242
         \core\common\Entity::intoThePotatoes();
243 243
         $idpoptions = $myInst->getAttributes();
244 244
         $retval = "<div class='infobox'>
245
-        <h2>" . sprintf(_("General %s details"), $this->nomenclatureParticipant) . "</h2>
245
+        <h2>" . sprintf(_("General %s details"), $this->nomenclatureParticipant)."</h2>
246 246
         <table>
247 247
             <tr>
248 248
                 <td>
249
-                    " . _("Country:") . "
249
+                    " . _("Country:")."
250 250
                 </td>
251 251
                 <td>
252 252
                 </td>
@@ -256,16 +256,16 @@  discard block
 block discarded – undo
256 256
         $retval .= $myFed->name;
257 257
         $retval .= "</strong>
258 258
                 </td>
259
-            </tr>" . $this->infoblock($idpoptions, "general", "IdP") . "
259
+            </tr>" . $this->infoblock($idpoptions, "general", "IdP")."
260 260
         </table>
261 261
     </div>";
262 262
 
263 263
         $blocks = [["support", _("Global Helpdesk Details")], ["media", _("Media Properties")]];
264 264
         foreach ($blocks as $block) {
265 265
             $retval .= "<div class='infobox'>
266
-            <h2>" . $block[1] . "</h2>
266
+            <h2>" . $block[1]."</h2>
267 267
             <table>" .
268
-                    $this->infoblock($idpoptions, $block[0], "IdP") .
268
+                    $this->infoblock($idpoptions, $block[0], "IdP").
269 269
                     "</table>
270 270
         </div>";
271 271
         }
@@ -280,12 +280,12 @@  discard block
 block discarded – undo
280 280
      */
281 281
     private function displaySize(int $number) {
282 282
         if ($number > 1024 * 1024) {
283
-            return round($number / 1024 / 1024, 2) . " MiB";
283
+            return round($number / 1024 / 1024, 2)." MiB";
284 284
         }
285 285
         if ($number > 1024) {
286
-            return round($number / 1024, 2) . " KiB";
286
+            return round($number / 1024, 2)." KiB";
287 287
         }
288
-        return $number . " B";
288
+        return $number." B";
289 289
     }
290 290
 
291 291
     /**
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
         $ref = $validator->databaseReference($cAReference);
340 340
         $rawResult = UIElements::getBlobFromDB($ref['table'], $ref['rowindex'], FALSE);
341 341
         if (is_bool($rawResult)) { // we didn't actually get a CA!
342
-            $retval = "<div class='ca-summary'>" . _("There was an error while retrieving the certificate from the database!") . "</div>";
342
+            $retval = "<div class='ca-summary'>"._("There was an error while retrieving the certificate from the database!")."</div>";
343 343
             \core\common\Entity::outOfThePotatoes();
344 344
             return $retval;
345 345
         }
@@ -355,14 +355,14 @@  discard block
 block discarded – undo
355 355
 
356 356
         $details['name'] = preg_replace('/(.)\/(.)/', "$1<br/>$2", $details['name']);
357 357
         $details['name'] = preg_replace('/\//', "", $details['name']);
358
-        $certstatus = ( $details['root'] == 1 ? "R" : "I");
359
-        $certTooltip = ( $details['root'] == 1 ? _("Root CA") : _("Intermediate CA"));
358
+        $certstatus = ($details['root'] == 1 ? "R" : "I");
359
+        $certTooltip = ($details['root'] == 1 ? _("Root CA") : _("Intermediate CA"));
360 360
         if ($details['ca'] == 0 && $details['root'] != 1) {
361
-            $retval = "<div class='ca-summary' style='background-color:red'><div style='position:absolute; right: 0px; width:20px; height:20px; background-color:maroon;  border-radius:10px; text-align: center;'><div style='padding-top:3px; font-weight:bold; color:#ffffff;'>S</div></div>" . _("This is a <strong>SERVER</strong> certificate!") . "<br/>" . $details['name'] . "</div>";
361
+            $retval = "<div class='ca-summary' style='background-color:red'><div style='position:absolute; right: 0px; width:20px; height:20px; background-color:maroon;  border-radius:10px; text-align: center;'><div style='padding-top:3px; font-weight:bold; color:#ffffff;'>S</div></div>"._("This is a <strong>SERVER</strong> certificate!")."<br/>".$details['name']."</div>";
362 362
             \core\common\Entity::outOfThePotatoes();
363 363
             return $retval;
364 364
         }
365
-        $retval = "<div class='ca-summary'                                ><div style='position:absolute; right: 0px; width:20px; height:20px; background-color:#0000ff; border-radius:10px; text-align: center;'><div title='$certTooltip' style='padding-top:3px; font-weight:bold; color:#ffffff;'>$certstatus</div></div>" . $details['name'] . "</div>";
365
+        $retval = "<div class='ca-summary'                                ><div style='position:absolute; right: 0px; width:20px; height:20px; background-color:#0000ff; border-radius:10px; text-align: center;'><div title='$certTooltip' style='padding-top:3px; font-weight:bold; color:#ffffff;'>$certstatus</div></div>".$details['name']."</div>";
366 366
         \core\common\Entity::outOfThePotatoes();
367 367
         return $retval;
368 368
     }
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
      */
376 376
     public function previewImageinHTML($imageReference) {
377 377
         \core\common\Entity::intoThePotatoes();
378
-        $retval = "<img style='max-width:150px' src='inc/filepreview.php?id=" . $imageReference . "' alt='" . _("Preview of logo file") . "'/>";
378
+        $retval = "<img style='max-width:150px' src='inc/filepreview.php?id=".$imageReference."' alt='"._("Preview of logo file")."'/>";
379 379
         \core\common\Entity::outOfThePotatoes();
380 380
         return $retval;
381 381
     }
@@ -392,13 +392,13 @@  discard block
 block discarded – undo
392 392
         $ref = $validator->databaseReference($fileReference);
393 393
         $fileBlob = UIElements::getBlobFromDB($ref['table'], $ref['rowindex'], FALSE);
394 394
         if (is_bool($fileBlob)) { // we didn't actually get a file!
395
-            $retval = "<div class='ca-summary'>" . _("There was an error while retrieving the file from the database!") . "</div>";
395
+            $retval = "<div class='ca-summary'>"._("There was an error while retrieving the file from the database!")."</div>";
396 396
             \core\common\Entity::outOfThePotatoes();
397 397
             return $retval;
398 398
         }
399 399
         $decodedFileBlob = base64_decode($fileBlob);
400 400
         $fileinfo = new \finfo();
401
-        $retval = "<div class='ca-summary'>" . _("File exists") . " (" . $fileinfo->buffer($decodedFileBlob, FILEINFO_MIME_TYPE) . ", " . $this->displaySize(strlen($decodedFileBlob)) . ")<br/><a href='inc/filepreview.php?id=$fileReference'>" . _("Preview") . "</a></div>";
401
+        $retval = "<div class='ca-summary'>"._("File exists")." (".$fileinfo->buffer($decodedFileBlob, FILEINFO_MIME_TYPE).", ".$this->displaySize(strlen($decodedFileBlob)).")<br/><a href='inc/filepreview.php?id=$fileReference'>"._("Preview")."</a></div>";
402 402
         \core\common\Entity::outOfThePotatoes();
403 403
         return $retval;
404 404
     }
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
             $retval .= "<tr><td>";
427 427
         }
428 428
         $finalCaption = ($caption !== NULL ? $caption : $uiMessages[$level]['text']);
429
-        $retval .= "<img class='icon' src='" . $uiMessages[$level]['icon'] . "' alt='" . $finalCaption . "' title='" . $finalCaption . "'/>";
429
+        $retval .= "<img class='icon' src='".$uiMessages[$level]['icon']."' alt='".$finalCaption."' title='".$finalCaption."'/>";
430 430
         if (!$omittabletags) {
431 431
             $retval .= "</td><td>";
432 432
         }
@@ -508,8 +508,8 @@  discard block
 block discarded – undo
508 508
             return "";
509 509
         }
510 510
 
511
-        $loggerInstance->debug(4, "Consortium logo is at: " . ROOT . "/web/resources/images/consortium_logo_large.png");
512
-        $logogd = imagecreatefrompng(ROOT . "/web/resources/images/consortium_logo_large.png");
511
+        $loggerInstance->debug(4, "Consortium logo is at: ".ROOT."/web/resources/images/consortium_logo_large.png");
512
+        $logogd = imagecreatefrompng(ROOT."/web/resources/images/consortium_logo_large.png");
513 513
         if ($logogd === FALSE) { // consortium logo is bogus; don't do anything
514 514
             return "";
515 515
         }
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
535 535
         imagecolorallocate($whiteimage, 255, 255, 255);
536 536
         // also make sure the initial placement is a multitude of 12; otherwise "two half" symbols might be affected
537 537
         $targetplacementx = (int) ($symbolsize * round(($sizeinput[0] / 2 - ($targetwidth - $symbolsize + 1) / 2) / $symbolsize));
538
-        $targetplacementy = (int) ($symbolsize * round(($sizeinput[1] / 2 - ($targetheight - $symbolsize + 1 ) / 2) / $symbolsize));
538
+        $targetplacementy = (int) ($symbolsize * round(($sizeinput[1] / 2 - ($targetheight - $symbolsize + 1) / 2) / $symbolsize));
539 539
         imagecopyresized($inputgd, $whiteimage, $targetplacementx - $symbolsize, $targetplacementy - $symbolsize, 0, 0, $targetwidth + 2 * $symbolsize, $targetheight + 2 * $symbolsize, $targetwidth + 2 * $symbolsize, $targetheight + 2 * $symbolsize);
540 540
         imagecopyresized($inputgd, $logogd, $targetplacementx, $targetplacementy, 0, 0, $targetwidth, $targetheight, $sizelogo[0], $sizelogo[1]);
541 541
         ob_start();
@@ -585,9 +585,9 @@  discard block
 block discarded – undo
585 585
                 $message = "Your configuration appears to be fine.";
586 586
                 break;
587 587
             default:
588
-                throw new Exception("The result code level " . $test->test_result['global'] . " is not defined!");
588
+                throw new Exception("The result code level ".$test->test_result['global']." is not defined!");
589 589
         }
590
-        $out .= $this->boxFlexible($test->test_result['global'], "<br><strong>Test Summary</strong><br>" . $message . "<br>See below for details<br><hr>");
590
+        $out .= $this->boxFlexible($test->test_result['global'], "<br><strong>Test Summary</strong><br>".$message."<br>See below for details<br><hr>");
591 591
         foreach ($test->out as $testValue) {
592 592
             foreach ($testValue as $o) {
593 593
                 $out .= $this->boxFlexible($o['level'], $o['message']);
Please login to merge, or discard this patch.