Passed
Branch master (a194fe)
by Brook
04:47
created
web/user/js/roll.php 1 patch
Indentation   +6 added lines, -7 removed lines patch added patch discarded remove patch
@@ -68,13 +68,12 @@
 block discarded – undo
68 68
 
69 69
 <?php
70 70
 /**
71
-  * The OS object holds operating system descriptions
72
-  * @param name is the main title
73
-  * @param subtitle - the subtitle
74
-  * @param path - the path to the scriin-dump image
75
-  * @param signed - if true show information that the module is signed
76
-    
77
-*/
71
+ * The OS object holds operating system descriptions
72
+ * @param name is the main title
73
+ * @param subtitle - the subtitle
74
+ * @param path - the path to the scriin-dump image
75
+ * @param signed - if true show information that the module is signed
76
+ */
78 77
 ?>
79 78
 
80 79
 function OS(name, subtitle, path, signed) {
Please login to merge, or discard this patch.
web/user/js/cat_js.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
 }
332 332
 
333 333
 <?php if(isset($_REQUEST['idp']) && $_REQUEST['idp']) { 
334
-      print "front_page = 0;\n";
334
+        print "front_page = 0;\n";
335 335
 } ?>
336 336
 
337 337
 function showTOU(){
@@ -469,9 +469,9 @@  discard block
 block discarded – undo
469 469
     $p_id = (isset($_REQUEST['profile']) && $_REQUEST['profile']) ? $_REQUEST['profile'] : 0; 
470 470
     if(! is_numeric($p_id))
471 471
         exit;
472
-   print 'listProfiles('.$_REQUEST['idp'].','.$p_id.');';
472
+    print 'listProfiles('.$_REQUEST['idp'].','.$p_id.');';
473 473
 }
474
- ?>
474
+    ?>
475 475
 
476 476
 $(".signin").click(function(event){
477 477
      pressedButton = $(this);
@@ -532,12 +532,12 @@  discard block
 block discarded – undo
532 532
         });
533 533
 DiscoJuice.Constants.Countries = {
534 534
 <?php 
535
-  $C = $Gui->printCountryList(1);
536
-     $ret = '';
537
-   foreach ($C as $key => $val) {
535
+    $C = $Gui->printCountryList(1);
536
+        $ret = '';
537
+    foreach ($C as $key => $val) {
538 538
     $ret .= "'$key': \"$val\",";
539
-   }
540
-   echo substr($ret, 0, -1);
539
+    }
540
+    echo substr($ret, 0, -1);
541 541
 ?>
542 542
         };
543 543
 
Please login to merge, or discard this patch.
web/user/cat_back.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 
17 17
 // extract request parameters; action is mandatory
18 18
 if(!isset($_REQUEST['action']))
19
-   exit;
19
+    exit;
20 20
 
21 21
 $action  = $_REQUEST['action'];
22 22
 $id      = ( isset($_REQUEST['id'])      ? $_REQUEST['id']      : FALSE );
Please login to merge, or discard this patch.
web/download.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,8 +42,8 @@
 block discarded – undo
42 42
 $p = new Profile($profile_id);
43 43
 
44 44
 if(!$p->institution || $p->institution !== $inst_id) {
45
-  header("HTTP/1.0 404 Not Found");
46
-  return;
45
+    header("HTTP/1.0 404 Not Found");
46
+    return;
47 47
 }
48 48
 
49 49
 // now we generate the installer
Please login to merge, or discard this patch.
core/RADIUSTests.php 1 patch
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -328,7 +328,6 @@
 block discarded – undo
328 328
      * - RETVAL_NOT_CONFIGURED; needs Config::$RADIUSTESTS['TLS-discoverytag']
329 329
      * - RETVAL_INVALID (at least one format error)
330 330
      * - RETVAL_OK (all fine)
331
-
332 331
      * @return int one of two RETVALs above
333 332
      */
334 333
     public function NAPTR_compliance() {
Please login to merge, or discard this patch.
web/user/faq.php 1 patch
Indentation   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -2,63 +2,63 @@  discard block
 block discarded – undo
2 2
 $FAQ = [];
3 3
 
4 4
 array_push($FAQ,
5
-      [
5
+        [
6 6
         'title'=>sprintf(_("My institution is not listed. Can't I just use any of the other ones?")),
7 7
         'text'=>sprintf(_("No! The installers contain security settings which are specific to the institution. If you are not from that institution, your computer will detect that you are about to send your username and credential to an unauthorised server and will abort the login. Using a different institution installer is <i>guaranteed to not work</i>!"))
8
-         ]);
8
+            ]);
9 9
 
10 10
 array_push($FAQ,
11
-      [
11
+        [
12 12
         'title'=>sprintf(_("What can I do to get my institution listed?")),
13 13
         'text'=>sprintf(_("Contact %s administrators at your home institution and complain. It will take at most one hour of their time to get things done."),CONFIG['CONSORTIUM']['name'])
14 14
 ]);
15 15
 
16 16
 array_push($FAQ,
17
-      [
17
+        [
18 18
         'title'=>sprintf(_("My device is not listed! Does that mean I can't do %s?"),CONFIG['CONSORTIUM']['name']),
19 19
         'text'=>sprintf(_("No. The CAT tool can only support Operating Systems which can be automatically configured in some way. Many other devices can still be used with %s, but must be configured manually. Please contact your %s Identity Provider to get help in setting up such a device."),CONFIG['CONSORTIUM']['name'],CONFIG['CONSORTIUM']['name'])
20
-      ]);
20
+        ]);
21 21
 
22 22
 array_push($FAQ,
23
-      [
23
+        [
24 24
         'title'=>sprintf(_("I can connect to %s simply by providing username and password, what is the point of using an installer?"),CONFIG['CONSORTIUM']['name']),
25 25
         'text'=>sprintf(_("When you are connecting from an unconfigured device your security is at risk. The very point of preconfiguration is to set up security, when this is done, your device will first confirm that it talks to the correct authentication server and will never send your password to an untrusted one."))
26 26
 ]);
27 27
 
28 28
 if (CONFIG['CONSORTIUM']['name'] == "eduroam") {
29
-   array_push($FAQ,
30
-         [
31
-           'title'=>sprintf(_("What is this eduroam thing anyway?")),
32
-           'text'=>sprintf(_("eduroam is a global WiFi roaming consortium which gives members of education and research access to the internet <i>for free</i> on all eduroam hotspots on the planet. There are several million eduroam users already, enjoying free internet access on more than 6.000 hotspots! Visit <a href='http://www.eduroam.org'>the eduroam homepage</a> for more details."))
33
-         ]);
29
+    array_push($FAQ,
30
+            [
31
+            'title'=>sprintf(_("What is this eduroam thing anyway?")),
32
+            'text'=>sprintf(_("eduroam is a global WiFi roaming consortium which gives members of education and research access to the internet <i>for free</i> on all eduroam hotspots on the planet. There are several million eduroam users already, enjoying free internet access on more than 6.000 hotspots! Visit <a href='http://www.eduroam.org'>the eduroam homepage</a> for more details."))
33
+            ]);
34 34
 }
35 35
 
36 36
 array_push($FAQ,
37
-      [
37
+        [
38 38
         'title'=>sprintf(_("Is it safe to use %s installers?"),CONFIG['APPEARANCE']['productname']),
39 39
         'text'=>sprintf(_("%s installers configure security settings on your device, therefore you should be sure that you are using genuine ones."),CONFIG['APPEARANCE']['productname']).' '.( isset(CONFIG['CONSORTIUM']['signer_name']) && CONFIG['CONSORTIUM']['signer_name'] != "" ? sprintf(_("This is why %s installers are digitally signed by %s. Watch out for a system message confirming this."),CONFIG['APPEARANCE']['productname'],CONFIG['CONSORTIUM']['signer_name']):""),
40 40
         
41 41
 ]);
42 42
 
43 43
 array_push($FAQ,
44
-      [
44
+        [
45 45
         'title'=>_("Windows 'SmartScreen' or 'Internet Explorer' tell me that the file is not commonly downloaded and possibly harmful. Should I be concerned?"),
46 46
         'text'=>_("Contrary to what the name suggests, 'SmartScreen' isn't actually very smart. The warning merely means that the file has not yet been downloaded by enough users to make Microsoft consider it popular (which would strangely enough make it be considered 'safe'). This message alone is not a security problem.")." ".(isset(CONFIG['CONSORTIUM']['signer_name']) && CONFIG['CONSORTIUM']['signer_name'] != "" ? sprintf(_("So long as the file is carrying a valid signature from %s, the download is safe."),CONFIG['CONSORTIUM']['signer_name'])." ":"").sprintf(_("Please see also Microsoft's FAQ regarding SmartScreen at %s."),"<a href='http://windows.microsoft.com/en-US/windows7/SmartScreen-Filter-frequently-asked-questions-IE9?SignedIn=1'>Microsoft FAQ</a>")
47 47
         
48 48
 ]);
49 49
 
50 50
 array_push($FAQ,
51
-      [
51
+        [
52 52
         'title'=>sprintf(_("I can see %s network and my device is configured but it does not connect, what can be the cause?"),CONFIG['CONSORTIUM']['name']),
53
-      'text'=>sprintf(_("There can be a number of different reasons. The network you see may not be a genuine %s one and your device silently drops the connection attempt; there may be something wrong with the configuration of the network; your account may have expired; there may be a connection problem with your home authentication server; you may have broken the regulations of the network you are using and have been refused access as a consequence. You should contact your home institution and report the problem, the administrators should be able to trace your connections."),CONFIG['CONSORTIUM'][
53
+        'text'=>sprintf(_("There can be a number of different reasons. The network you see may not be a genuine %s one and your device silently drops the connection attempt; there may be something wrong with the configuration of the network; your account may have expired; there may be a connection problem with your home authentication server; you may have broken the regulations of the network you are using and have been refused access as a consequence. You should contact your home institution and report the problem, the administrators should be able to trace your connections."),CONFIG['CONSORTIUM'][
54 54
 'name'])
55 55
 ]);
56 56
 
57 57
 array_push($FAQ,
58
-      [
58
+        [
59 59
         'title'=>sprintf(_("I have a question about this web site. Whom should I contact?")),
60 60
         'text'=>sprintf(_("You should send a mail to %s."),CONFIG['APPEARANCE']['support-contact']['display'])
61
-      ]);
61
+        ]);
62 62
 
63 63
 /**
64 64
  * This is a template for further FAQ entries. Simply copy&paste and add more
@@ -81,8 +81,8 @@  discard block
 block discarded – undo
81 81
     <?php
82 82
     $i =0;
83 83
     foreach ($FAQ as $faq) {
84
-       print '<a href="#toc'.$i.'">'.$faq['title']."</a><br>\n";
85
-       $i++;
84
+        print '<a href="#toc'.$i.'">'.$faq['title']."</a><br>\n";
85
+        $i++;
86 86
     }
87 87
     ?>
88 88
     </div>
@@ -90,8 +90,8 @@  discard block
 block discarded – undo
90 90
     <?php
91 91
     $i =0;
92 92
     foreach ($FAQ as $faq) {
93
-      print "<dt><a name=toc$i>".$faq['title']."</a></dt>\n<dd>".$faq['text']."</dd>\n";
94
-      $i++;
93
+        print "<dt><a name=toc$i>".$faq['title']."</a></dt>\n<dd>".$faq['text']."</dd>\n";
94
+        $i++;
95 95
     }
96 96
     ?>
97 97
 </dl>
Please login to merge, or discard this patch.
core/CAT.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -112,12 +112,12 @@
 block discarded – undo
112 112
     }
113 113
 
114 114
         /**
115
-     * Lists all identity providers in the database
116
-     * adding information required by DiscoJuice.
117
-     * @param int $activeOnly if and set to non-zero will
118
-     * cause listing of only those institutions which have some valid profiles defined.
119
-     *
120
-     */
115
+         * Lists all identity providers in the database
116
+         * adding information required by DiscoJuice.
117
+         * @param int $activeOnly if and set to non-zero will
118
+         * cause listing of only those institutions which have some valid profiles defined.
119
+         *
120
+         */
121 121
     public function listAllIdentityProviders($activeOnly = 0, $country = 0) {
122 122
         $handle = DBConnection::handle("INST");
123 123
         $handle->exec("SET SESSION group_concat_max_len=10000");
Please login to merge, or discard this patch.
devices/redirect_dev/RedirectDev.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -2,15 +2,15 @@
 block discarded – undo
2 2
 require_once('DeviceConfig.php');
3 3
 
4 4
 class Device_RedirectDev extends DeviceConfig {
5
-   /**
6
-    * Constructs a Device object.
7
-    *
8
-    * @final not to be redefined
9
-    */
5
+    /**
6
+     * Constructs a Device object.
7
+     *
8
+     * @final not to be redefined
9
+     */
10 10
     final public function __construct() {
11 11
         parent::__construct();
12
-      $this->setSupportedEapMethods([EAPTYPE_NONE]);
13
-      $this->loggerInstance->debug(4,"RedirectEx called");
12
+        $this->setSupportedEapMethods([EAPTYPE_NONE]);
13
+        $this->loggerInstance->debug(4,"RedirectEx called");
14 14
     }
15 15
     public function writeDeviceInfo() {
16 16
         $out = "<p>";
Please login to merge, or discard this patch.