Profile

Complexity

Total Complexity

150

Size/Duplication

Total Lines	786
Duplicated Lines	3.82 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes	3
Bugs	1	Features	0

25 Methods

Rating	Name	Duplication	Size	Complexity
F	__construct()	20	236	34
A	profileFromRealm()	0	7	2
A	updateFreshness()	0	3	1
A	getFreshness()	0	6	2
B	testCache()	0	15	5
A	updateCache()	0	7	1
A	incrementDownloadStats()	0	8	3
B	getUserDownloadStats()	0	19	6
A	addAttribute()	0	8	3
A	addSupportedEapMethod()	0	7	1
A	destroy()	0	6	1
A	flushSupportedEapMethods()	0	4	1
A	setAnonymousIDSupport()	0	3	2
A	setRealmCheckUser()	0	6	3
A	setInputVerificationPreference()	0	6	3
A	setRealm()	0	5	1
A	getEapMethodsinOrderOfPreference()	0	12	4
C	getAttributes()	0	32	13
C	isEapTypeDefinitionComplete()	0	37	13
C	listDevices()	0	45	13
D	getCollapsedAttributes()	10	45	18
A	getSufficientConfig()	0	18	3
B	readyForShowtime()	0	20	9
B	prepShowtime()	0	18	6
A	getShowtime()	0	11	2

<?php

/* * ********************************************************************************
 * (c) 2011-15 GÉANT on behalf of the GN3, GN3plus and GN4 consortia
 * License: see the LICENSE file in the root directory
 * ********************************************************************************* */
?>
<?php

/**
 * This file contains the Profile class.
 *
 * @author Stefan Winter <stefan.winter@restena.lu>
 * @author Tomasz Wolniewicz <twoln@umk.pl>
 *
 * @package Developer
 *
 */
/**
 * necessary includes
 */
require_once('Helper.php');
require_once('IdP.php');
require_once('EAP.php');
require_once('X509.php');
require_once('EntityWithDBProperties.php');
require_once('devices/devices.php');

define("HIDDEN", -1);
define("AVAILABLE", 0);
define("UNAVAILABLE", 1);
define("INCOMPLETE", 2);
define("NOTCONFIGURED", 3);

/**
 * This class represents an EAP Profile.
 * Profiles can inherit attributes from their IdP, if the IdP has some. Otherwise,
 * one can set attribute in the Profile directly. If there is a conflict between
 * IdP-wide and Profile-wide attributes, the more specific ones (i.e. Profile) win.
 *
 * @author Stefan Winter <stefan.winter@restena.lu>
 * @author Tomasz Wolniewicz <twoln@umk.pl>
 *
 * @license see LICENSE file in root directory
 *
 * @package Developer
 */
class Profile extends EntityWithDBProperties {

    /**
     * This array holds the supported EAP types (in "array" OUTER/INNER representation). They are not synced against the DB after instantiation.
     * 
     * @var array
     */
    private $priv_eaptypes;
    
    /**
     * Class constructor for existing profiles (use IdP::newProfile() to actually create one). Retrieves all attributes and 
     * supported EAP types from the DB and stores them in the priv_ arrays.
     * 
     * @param int $p_id identifier of the profile in the DB
     * @param IdP $idp_object optionally, the institution to which this Profile belongs. Saves the construction of the IdP instance. If omitted, an extra query and instantiation is executed to find out.
     */
    public function __construct($p_id, $idp_object = 0) {
        debug(3, "--- BEGIN Constructing new Profile object ... ---\n");
        
        $this->databaseType = "INST";
        $this->entityOptionTable = "profile_option";
        $this->entityIdColumn = "profile_id";
        $this->identifier = $p_id;
        $this->attributes = [];
        
        $profile = DBConnection::exec($this->databaseType, "SELECT inst_id, realm, use_anon_outer, checkuser_outer, checkuser_value, verify_userinput_suffix as verify, hint_userinput_suffix as hint FROM profile WHERE profile_id = $p_id");
        debug(4, $profile);
        if (!$profile || $profile->num_rows == 0) {
            debug(2, "Profile $p_id not found in database!\n");
            throw new Exception("Profile $p_id not found in database!");
            return;

return; does not seem to be reachable.

        }
        $a = mysqli_fetch_object($profile);
        if (!($idp_object instanceof IdP)) {
            $this->institution = $a->inst_id;
            $idp = new IdP($this->institution);
        } else {
            $idp = $idp_object;
            $this->institution = $idp->name;
        }
        $temparray = [];
        $optioninstance = Options::instance();

        $this->realm = $a->realm;
        $this->use_anon_outer = $a->use_anon_outer;
        $this->lang_index = CAT::get_lang();
        $this->inst_name = $idp->name;

        $this->checkuser_outer = $a->checkuser_outer;

The property checkuser_outer does not exist. Did you maybe forget to declare it?

        $this->checkuser_value = $a->checkuser_value;

The property checkuser_value does not exist. Did you maybe forget to declare it?

        $this->verify = $a->verify;

The property verify does not exist. Did you maybe forget to declare it?

        $this->hint = $a->hint;

The property hint does not exist. Did you maybe forget to declare it?

        
        // fetch all atributes from this profile from DB

        $AllAttributes = DBConnection::exec($this->databaseType, "SELECT option_name, option_value, device_id, eap_method_id as method, row 
                FROM $this->entityOptionTable
                WHERE $this->entityIdColumn = $this->identifier");

        while ($a = mysqli_fetch_object($AllAttributes)) {

            $optinfo = $optioninstance->optionType($a->option_name);
            $lang = "";
            if ($optinfo['type'] != "file") {
                $temparray[] = [
                    "name" => $a->option_name,
                    "value" => $a->option_value,
                    "level" => ($a->device_id == NULL && $a->method == 0 ? "Profile" : "Method" ),
                    "row" => $a->row,
                    "device" => $a->device_id,
                    "flag" => $optinfo['flag'],
                    "eapmethod" => EAP::EAPMethodArrayFromId($a->method)];
            } else {
                // suppress E_NOTICE on the following... we are testing *if*
                // we have a serialized value - so not having one is fine and
                // shouldn't throw E_NOTICE
                if (@unserialize($a->option_value) !== FALSE) { // multi-lang
                    $content = unserialize($a->option_value);
                    $lang = $content['lang'];
                    $content = $content['content'];
                } else { // single lang, direct content
                    $content = $a->option_value;
                }

                $content = base64_decode($content);

                $temparray[] = [
                    "name" => $a->option_name,
                    "value" => ( $lang == "" ? $content : serialize(['lang' => $lang, 'content' => $content])),
                    "level" => ($a->device_id == NULL && $a->method == 0 ? "Profile" : "Method" ),
                    "row" => $a->row,
                    "flag" => $optinfo['flag'],
                    "device" => $a->device_id,
                    "eapmethod" => EAP::EAPMethodArrayFromId($a->method)];
            }

            /*

53% of this comment could be valid code. Did you maybe forget this after debugging?

              "name" => $a->option_name,
              "row" => $a->row,
              "level" => ($a->device_id == NULL && $a->method == NULL ? "Profile" : "Method" ),
              "device" => $a->device_id,
              "eapmethod" => $a->method);

             */
        }
        // add internal attributes

        $temparray[] = ["name" => "internal:profile_count",
            "value" => $idp->profileCount(),
            "level" => "Profile",
            "row" => 0,
            "flag" => NULL,
            "device" => NULL,
            "eapmethod" => NULL];
        
        $temparray[] = ["name" => "internal:checkuser_outer",
            "value" => $this->checkuser_outer,
            "level" => "Profile",
            "row" => 0,
            "flag" => NULL,
            "device" => NULL,
            "eapmethod" => NULL];
        
        $temparray[] = ["name" => "internal:checkuser_value",
            "value" => $this->checkuser_value,
            "level" => "Profile",
            "row" => 0,
            "flag" => NULL,
            "device" => NULL,
            "eapmethod" => NULL];
        
        $temparray[] = ["name" => "internal:verify_userinput_suffix",
            "value" => $this->verify,
            "level" => "Profile",
            "row" => 0,
            "flag" => NULL,
            "device" => NULL,
            "eapmethod" => NULL];
        
        $temparray[] = ["name" => "internal:hint_userinput_suffix",
            "value" => $this->hint,
            "level" => "Profile",
            "row" => 0,
            "flag" => NULL,
            "device" => NULL,
            "eapmethod" => NULL];
        
        // strip local@ off of the realm value
        $strippedrealm = preg_replace('/^.*@/', '', $this->realm);
        $temparray[] = ["name" => "internal:realm",
            "value" => $strippedrealm,
            "level" => "Profile",
            "row" => 0,
            "flag" => NULL,
            "device" => NULL,
            "eapmethod" => NULL];
        // FALSE or TRUE

50% of this comment could be valid code. Did you maybe forget this after debugging?

        $temparray[] = ["name" => "internal:use_anon_outer",
            "value" => $this->use_anon_outer,
            "level" => "Profile",
            "row" => 0,
            "flag" => NULL,
            "device" => NULL,
            "eapmethod" => NULL];
        // the local part, if set (otherwise use default value)
        if (preg_match('/@/', $this->realm)) {
            $temparray[] = ["name" => "internal:anon_local_value",
                "value" => substr($this->realm, 0, strpos($this->realm, '@')),
                "level" => "Profile",
                "row" => 0,
                "flag" => NULL,
                "device" => NULL,
                "eapmethod" => NULL];
        } else {
            $temparray[] = ["name" => "internal:anon_local_value",
                "value" => "anonymous",
                "level" => "Profile",
                "row" => 0,
                "flag" => NULL,
                "device" => NULL,
                "eapmethod" => NULL];
        }

        // now, fetch IdP-wide attributes

        $idpoptions = $idp->getAttributes();

        foreach ($idpoptions as $the_attr)
            $temparray[] = [
                "name" => $the_attr["name"],
                "value" => $the_attr["value"],
                "level" => $the_attr["level"],
                "row" => $the_attr["row"],
                "flag" => $the_attr["flag"],
                "device" => NULL,
                "eapmethod" => NULL,
            ];

        // check sanity (device and eapmethod are mutually exclusive) and first batch of adding (method level)

        foreach ($temparray as $attrib) {
            if ($attrib["device"] != NULL && $attrib["eapmethod"] != NULL)
                debug(2, "Sanity check failed - device and eapmethod are set!\n");
        }

        foreach ($temparray as $attrib) {
            if ($attrib["device"] != NULL || $attrib["eapmethod"] != NULL)
                $this->attributes[] = $attrib;
        }
        // pick all attributes which are profile specific and place into final array if no eap/device-specific exists

        foreach ($temparray as $attrib) {

This code seems to be duplicated across your project.

            if ($attrib["level"] == "Profile") {
                $ignore = "";
                foreach ($this->attributes as $approved_attrib)
                    if ($attrib["name"] == $approved_attrib["name"] && $approved_attrib["level"] != "IdP" && $approved_attrib["level"] != "Profile")
                        $ignore = "YES";
                if ($ignore != "YES")
                    $this->attributes[] = $attrib;
            }
        }

        // now, add IdP-wide attribs

        foreach ($temparray as $attrib) {

This code seems to be duplicated across your project.

            if ($attrib["level"] == "IdP") {
                $ignore = "";
                foreach ($this->attributes as $approved_attrib)
                    if ($attrib["name"] == $approved_attrib["name"] && $approved_attrib["level"] != "IdP")
                        $ignore = "YES";
                if ($ignore != "YES")
                    $this->attributes[] = $attrib;
            }
        }

        $this->name = getLocalisedValue($this->getAttributes('profile:name', 0, 0), $this->lang_index);

        $eap_m = DBConnection::exec($this->databaseType, "SELECT eap_method_id 
                                                        FROM supported_eap supp 
                                                        WHERE supp.profile_id = $this->identifier 
                                                        ORDER by preference");
        $returnarray = [];
        while ($eap = (mysqli_fetch_object($eap_m))) {
            $eaptype = EAP::EAPMethodArrayFromId($eap->eap_method_id);
            $returnarray[] = $eaptype;
        }
        debug(4, "Looks like this profile supports the following EAP types: ");
        debug(4, $returnarray);
        $this->priv_eaptypes = $returnarray;

        debug(3, "--- END Constructing new Profile object ... ---\n");
    }

    /**
     * find a profile, given its realm
     */
    public static function profileFromRealm($realm) {
        $exec_query = DBConnection::exec($this->databaseType, "SELECT profile_id FROM profile WHERE realm LIKE '%@$realm'");

The variable $this does not exist. Did you forget to declare it?

        if ($a = mysqli_fetch_object($exec_query)) {
            return $a->profile_id;
        } else
            return FALSE;
    }
    
    /**
     * update the last_changed timestamp for this profile
     */
    public function updateFreshness() {
        DBConnection::exec($this->databaseType, "UPDATE profile SET last_change = CURRENT_TIMESTAMP WHERE profile_id = $this->identifier");
    }

    /**
     * gets the last-modified timestamp (useful for caching "dirty" check)
     */
    public function getFreshness() {
        $exec_update = DBConnection::exec($this->databaseType, "SELECT last_change FROM profile WHERE profile_id = $this->identifier");
        if ($a = mysqli_fetch_object($exec_update)) {
            return $a->last_change;
        }
    }

    /**
     * tests if the configurator needs to be regenerated
     * returns the configurator path or NULL if regeneration is required
     */

    /**
     * This function tests if the configurator needs to be regenerated (properties of the Profile may have changed since the last configurator generation).
     * 
     * @param string $device device ID to check
     * @return mixed a string with the path to the configurator download, or NULL if it needs to be regenerated
     */
    public function testCache($device) {
        $returnValue = NULL;
        $escapedDevice = DBConnection::escape_value($this->databaseType, $device);
        $result = DBConnection::exec($this->databaseType, "SELECT download_path, mime, UNIX_TIMESTAMP(installer_time) AS tm FROM downloads WHERE profile_id = $this->identifier AND device_id = '$escapedDevice' AND lang = '$this->lang_index'");
        if ($result && $cache = mysqli_fetch_object($result)) {
            $exec_update = DBConnection::exec($this->databaseType, "SELECT UNIX_TIMESTAMP(last_change) AS last_change FROM profile WHERE profile_id = $this->identifier");
            if ($lc = mysqli_fetch_object($exec_update)->last_change) {
                if ($lc < $cache->tm) {
                    debug(4, "Installer cached:$cache->download_path\n");
                    $returnValue = ['cache'=>$cache->download_path,'mime'=>$cache->mime];
                }
            }
        }
        return $returnValue;
    }

    /**
     * Updates database with new installler location
     * 
     * @param string device the device identifier string
     * @param string path the path where the new installer can be found
     */
    public function updateCache($device, $path,$mime) {
        $escapedDevice = DBConnection::escape_value($this->databaseType, $device);
        $escapedPath   = DBConnection::escape_value($this->databaseType, $path);
        DBConnection::exec($this->databaseType, "INSERT INTO downloads (profile_id,device_id,download_path,mime,lang,installer_time) 
                                        VALUES ($this->identifier, '$escapedDevice', '$escapedPath', '$mime', '$this->lang_index', CURRENT_TIMESTAMP ) 
                                        ON DUPLICATE KEY UPDATE download_path = '$escapedPath', mime = '$mime', installer_time = CURRENT_TIMESTAMP");
    }

    /**
     * Log a new download for our stats
     * 
     * @param device the device id string
     * @param area either admin or user
     * @return TRUE if incrementing worked, FALSE if not
     */
    public function incrementDownloadStats($device, $area) {
        $device = DBConnection::escape_value($this->databaseType, $device);
        if ($area == "admin" || $area == "user") {
            DBConnection::exec(Profile::$DB_TYPE, "INSERT INTO downloads (profile_id, device_id, lang, downloads_$area) VALUES ($this->identifier, '$device','$this->lang_index', 1) ON DUPLICATE KEY UPDATE downloads_$area = downloads_$area + 1");
            return TRUE;
        }
        return FALSE;
    }

    /**
     * Retrieve current download stats from database, either for one specific device or for all devices
     * @param string $device the device id string
     * @return mixed user downloads of this profile; if device is given, returns the counter as int, otherwise an array with devicename => counter
     */
    public function getUserDownloadStats($device = 0) {
        $returnarray = [];
        $numbers_q = DBConnection::exec($this->databaseType, "SELECT device_id, SUM(downloads_user) AS downloads_user FROM downloads WHERE profile_id = $this->identifier GROUP BY device_id");
        while ($a = mysqli_fetch_object($numbers_q))
            $returnarray[$a->device_id] = $a->downloads_user;
        if ($device !== 0) {
            if (isset($returnarray[$device]))
                return $returnarray[$device];
            else
                return 0;
        }
        // we should pretty-print the device names
        $finalarray = [];
        $devlist = Devices::listDevices();
        foreach ($returnarray as $dev_id => $count)
            if (isset($devlist[$dev_id]))
                    $finalarray[$devlist[$dev_id]['display']] = $count;
        return $finalarray;
    }

    /**
     * adds an attribute to this profile; not the usual function from EntityWithDBProperties
     * because this class also has per-EAP-type and per-device sub-settings
     *
     * @param string $attr_name name of the attribute to set

There is no parameter named $attr_name. Was it maybe removed?

     * @param string $attr_value value of the attribute to set

There is no parameter named $attr_value. Was it maybe removed?

     * @param int $eap_type identifier of the EAP type in the database. 0 if the attribute is valid for all EAP types.

There is no parameter named $eap_type. Was it maybe removed?

     * @param string $device identifier of the device in the databse. Omit the argument if attribute is valid for all devices.
     */
    public function addAttribute($attrName, $attrValue, $eapType, $device = 0) {
        $escapedAttrName = DBConnection::escape_value(Profile::$DB_TYPE, $attrName);
        $escapedAttrValue = DBConnection::escape_value(Profile::$DB_TYPE, $attrValue);
        
        DBConnection::exec($this->databaseType, "INSERT INTO $this->entityOptionTable ($this->entityIdColumn, option_name, option_value, eap_method_id" . ($device !== 0 ? ",device_id" : "") . ") 
                          VALUES(". $this->identifier . ", '$escapedAttrName', '$escapedAttrValue', $eapType" . ($device !== 0 ? ",'". DBConnection::escape_value($this->databaseType, $device) . "'" : "" ) . ")");
        $this->updateFreshness();
    }

    /**
     * register new supported EAP method for this profile
     *
     * @param array $type The EAP Type, as defined in class EAP
     * @param int $preference preference of this EAP Type. If a preference value is re-used, the order of EAP types of the same preference level is undefined.
     *
     */
    public function addSupportedEapMethod($type, $preference) {
        DBConnection::exec($this->databaseType, "INSERT INTO supported_eap (profile_id, eap_method_id, preference) VALUES ("
                . $this->identifier . ", "
                . EAP::EAPMethodIdFromArray($type) . ", "
                . $preference . ")");
        $this->updateFreshness();
    }

    /**
     * Deletes the profile from database and uninstantiates itself.
     *
     */
    public function destroy() {
        DBConnection::exec($this->databaseType, "DELETE FROM profile_option WHERE profile_id = $this->identifier");
        DBConnection::exec($this->databaseType, "DELETE FROM supported_eap WHERE profile_id = $this->identifier");
        DBConnection::exec($this->databaseType, "DELETE FROM profile WHERE profile_id = $this->identifier");
        unset($this);
    }

    /**
     * Removes all supported EAP methods
     */
    public function flushSupportedEapMethods() {
        DBConnection::exec($this->databaseType, "DELETE FROM supported_eap WHERE profile_id = $this->identifier");
        $this->updateFreshness();
    }

    /** Toggle anonymous outer ID support.
     *
     * @param boolean $shallwe TRUE to enable outer identities (needs valid $realm), FALSE to disable
     *
     */
    public function setAnonymousIDSupport($shallwe) {
        DBConnection::exec($this->databaseType, "UPDATE profile SET use_anon_outer = " . ($shallwe == true ? "1" : "0") . " WHERE profile_id = $this->identifier");

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

    }
    
    /** Toggle special username for realm checks
     *
     * @param boolean $shallwe TRUE to enable outer identities (needs valid $realm), FALSE to disable
     * @param string $localpart the username
     *
     */
    public function setRealmCheckUser($shallwe,$localpart = NULL) {
        DBConnection::exec($this->databaseType, 
                "UPDATE profile SET checkuser_outer = " . ($shallwe == true ? "1" : "0") . 

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

                ( $localpart !== NULL ? ", checkuser_value = '$localpart' " : "") .
                " WHERE profile_id = $this->identifier");
    }

    /** should username be verified or even prefilled?
     * 
     */
    public function setInputVerificationPreference($verify,$hint) {
        DBConnection::exec($this->databaseType, 
                "UPDATE profile SET verify_userinput_suffix = " . ($verify == true ? "1" : "0") . 
                ", hint_userinput_suffix = ". ($hint == true ? "1" : "0") .
                " WHERE profile_id = $this->identifier");
    }
    
    /**
     * Specifies the realm of this profile.
     * 
     * @param string $realm the realm (potentially with the local@ part that should be used for anonymous identities)
     */
    public function setRealm($realm) {
        $escapedRealm = DBConnection::escape_value($this->databaseType, $realm);
        DBConnection::exec(Profile::$DB_TYPE, "UPDATE profile SET realm = '$escapedRealm' WHERE profile_id = $this->identifier");
        $this->realm = $escapedRealm;
    }

    /**
     * Produces an array of EAP methods supported by this profile, ordered by preference
     * 
     * @param int $complete_only if set and non-zero limits the output to methods with complete information
     * @return array list of EAP methods, (in "array" OUTER/INNER representation)
     */
    public function getEapMethodsinOrderOfPreference($complete_only = 0) {
        $temparray = [];

        if ($complete_only == 0) {
            return $this->priv_eaptypes;
        } else {
            foreach ($this->priv_eaptypes as $type)
                if ($this->isEapTypeDefinitionComplete($type) === true)
                    $temparray[] = $type;
            return($temparray);
        }
    }

    /** Returns an array of the profile's attributes.
     * 
     * @param string option_name the name of a specific option. If set, only returns option values for this option name
     * @param eapmethod the EAP type, in array ("OUTER/INNER") notation. If set, returns only attributes which are specific to that EAP type
     * @param string device the device ID string. If set, returns only attributes which are specific to that device
     * @return array attributes of the profile
     */
    public function getAttributes($option_name = 0, $eapmethod = 0, $device = 0) {

        $outarray = [];
        $temparray = [];
        if ($eapmethod) {
            foreach ($this->attributes as $the_attr) 
                if ($the_attr["eapmethod"] == $eapmethod)
                    $temparray[] = $the_attr;
        } else
        if ($device) {
            foreach ($this->attributes as $the_attr)
                if ($the_attr["device"] == $device)
                    $temparray[] = $the_attr;
        };

        foreach ($this->attributes as $the_attr)
            if ($the_attr["device"] == NULL && $the_attr["eapmethod"] == NULL)
                $temparray[] = $the_attr;


        // return only options by one name, if asked for

        if ($option_name) {
            foreach ($temparray as $the_attr)
                if ($the_attr["name"] == $option_name)
                    $outarray[] = $the_attr;
        } else {
            $outarray = $temparray;
        }

        return $outarray;
    }

    /**
     * Performs a sanity check for a given EAP type - did the admin submit enough information to create installers for him?
     * 
     * @param array $eaptype the EAP type in "array" OUTER/INNER representation
     * @return mixed TRUE if the EAP type is complete; an array of missing attribues if it's incomplete; FALSE if it's incomplete for other reasons
     */
    public function isEapTypeDefinitionComplete($eaptype) {
        $missing = [];
        // TLS, TTLS, PEAP outer phase need a CA certficate and a Server Name
        if ($eaptype["OUTER"] == PEAP || $eaptype["OUTER"] == TLS || $eaptype["OUTER"] == TTLS || $eaptype["OUTER"] == FAST) {

            $cn_option = $this->getAttributes("eap:server_name", $eaptype);

$eaptype is of type array<string,?,{"OUTER":"?"}>, but the function expects a integer.

            $ca_option = $this->getAttributes("eap:ca_file", $eaptype);

$eaptype is of type array<string,?,{"OUTER":"?"}>, but the function expects a integer.

            /* echo "<pre>";

63% of this comment could be valid code. Did you maybe forget this after debugging?

              print_r($options);
              echo "</pre>"; */
            if (count($ca_option) > 0 && count($cn_option) > 0) {// see if we have at least one root CA cert
                foreach ($ca_option as $one_ca) {
                    $x509 = new X509();
                    $ca_parsed = $x509->processCertificate($one_ca['value']);
                    if ($ca_parsed['root'] == 1)
                        return true;
                }
                $missing[] = "eap:ca_file";
            }
            if (count($ca_option) == 0)
                $missing[] = "eap:ca_file";
            if (count($cn_option) == 0)
                $missing[] = "eap:server_name";
            return $missing;
        } elseif ($eaptype["OUTER"] == PWD || $eaptype["INNER"] == NE_SILVERBULLET) {
            /*

58% of this comment could be valid code. Did you maybe forget this after debugging?

              $cn_option = $this->getAttributes("eap:server_name", $eaptype);
              if (count($cn_option) > 0) */
            return true;
            /* $missing[] = "eap:server_name";

58% of this comment could be valid code. Did you maybe forget this after debugging?

              return $missing; */
        }

        // we have no idea; let's say false

        return false;
    }

    /**
     * list all devices marking their availabiblity and possible redirects
     *
     * @param string $locale for text-based attributes, either returns values for the default value, or if specified here, in the locale specified
     * @return array of device ids display names and their status
     */
    public function listDevices($locale = 0) {
        if ($locale == 0)
            $locale = $this->lang_index;
        $redirect_url = 0;

$redirect_url is not used, you could remove the assignment.

        $message = 0;

$message is not used, you could remove the assignment.

        $returnarray = [];
        $redirect = $this->getAttributes("device-specific:redirect", 0, 0);
        if ($redirect) {

The expression $redirect of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $v = unserialize($redirect[0]['value']);
            return [['id' => '0', 'redirect' => $v['content']]];
        }
        $preferred_eap = $this->getEapMethodsinOrderOfPreference(1);
        $EAP_options = [];
        foreach (Devices::listDevices() as $d => $D) {
            $factory = new DeviceFactory($d);
            $dev = $factory->device;
            $redirect_url = getLocalisedValue($this->getAttributes("device-specific:redirect", 0, $d), $locale);
            $dev_status = AVAILABLE;
            if(isset($D['options']) && isset($D['options']['message']) && $D['options']['message']) 
               $message = $D['options']['message'];
            else
               $message = 0;

            if ($redirect_url === 0) {

The strict comparison === seems to always evaluate to false as the types of $redirect_url (string) and 0 (integer) can never be identical. Maybe you want to use a loose comparison == instead?

                if(isset($D['options']) && isset($D['options']['redirect']) && $D['options']['redirect']) {
                   $dev_status = HIDDEN;
                }  else {
                   $eap = $dev->getPreferredEapType($preferred_eap);
                   if ($eap) {
                       if (isset($EAP_options["eap-specific:customtext"][serialize($eap)]))
                           $eap_customtext = $EAP_options["eap-specific:customtext"][serialize($eap)];
                       else {
                           $eap_customtext = getLocalisedValue($this->getAttributes("eap-specific:customtext", $eap, 0), $locale);
                           $EAP_options["eap-specific:customtext"][serialize($eap)] = $eap_customtext;
                       }
                       $device_customtext = getLocalisedValue($this->getAttributes("device-specific:customtext", 0, $d), $locale);
                   } else {
                    $dev_status = UNAVAILABLE;
                   }
               }
            }
            $returnarray[] = ['id' => $d, 'display' => $D['display'], 'status' => $dev_status, 'redirect' => $redirect_url, 'eap_customtext' => $eap_customtext, 'device_customtext' => $device_customtext, 'message' => $message, 'options'=>$D['options']];

The variable $eap_customtext does not seem to be defined for all execution paths leading up to this point.

The variable $device_customtext does not seem to be defined for all execution paths leading up to this point.

        }
        return $returnarray;
    }

    /**
     * prepare profile attributes for device modules
     * Gets profile attributes taking into account the most specific level on which they may be defined
     * as wel as the chosen language.
     * can be called with an optional $eap argument
     * 
     * @param array $eap if specified, retrieves attributes specific to the given EAP type
     * @return array list of attributes in collapsed style (index is the attrib name, value is an array of different values)
     */
    public function getCollapsedAttributes($eap = 0) {
        $attr = $this->getAttributes(0, $eap);
        $temp1 = [];
        foreach ($attr as $b) {
            $name = $b['name'];
            $temp1[] = $name;
            $level = $b['level'];
//            $S[$l] = $z[$l];

70% of this comment could be valid code. Did you maybe forget this after debugging?

            $value = $b['value'];
            if (!isset($temp[$name][$level]))
                $temp[$name][$level] = [];

$temp was never initialized. Although not strictly required by PHP, it is generally a good practice to add $temp = array(); before regardless.

            if ($b['flag'] == 'ML') {
                $v = unserialize($value);
                $value = [$v['lang'] => $v['content']];
            }
            $temp[$name][$level][] = $value;

The variable $temp does not seem to be defined for all execution paths leading up to this point.

            $flags[$name] = $b['flag'];

$flags was never initialized. Although not strictly required by PHP, it is generally a good practice to add $flags = array(); before regardless.

        }
        foreach ($temp1 as $name) {
            if ($flags[$name] == 'ML') {

The variable $flags does not seem to be defined for all execution paths leading up to this point.

                $S = [];
                if (isset($temp[$name]['Profile'])) {

This code seems to be duplicated across your project.

                    foreach ($temp[$name]['Profile'] as $z)
                        foreach ($z as $l => $w)
                            $S[$l] = $w;
                }
                if (!$S && isset($temp[$name]['IdP'])) {

The expression $S of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This code seems to be duplicated across your project.

                    foreach ($temp[$name]['IdP'] as $z)
                        foreach ($z as $l => $w)
                            $S[$l] = $w;
                }
                $out[$name]['langs'] = $S;

$out was never initialized. Although not strictly required by PHP, it is generally a good practice to add $out = array(); before regardless.

                if (isset($S[$this->lang_index]) || isset($S['C']))
                    $out[$name][0] = (isset($S[$this->lang_index])) ? $S[$this->lang_index] : $S['C'];

The variable $out does not seem to be defined for all execution paths leading up to this point.

            } else {
                if (isset($temp[$name]['Method']))
                    $out[$name] = $temp[$name]['Method'];
                elseif (isset($temp[$name]['Profile']))
                    $out[$name] = $temp[$name]['Profile'];
                else
                    $out[$name] = $temp[$name]['IdP'];
            }
        }
        return($out);
    }

    /**
     * 
     */
    public function getSufficientConfig() {
        $result = DBConnection::exec($this->databaseType, "SELECT sufficient_config FROM profile WHERE profile_id = " . $this->identifier);
        $r = mysqli_fetch_row($result);
        /* echo "<pre>";

63% of this comment could be valid code. Did you maybe forget this after debugging?

          print_r($r);
          echo "</pre>"; */
        if ($r[0] === NULL) { // we have never recorded the state; do it now
            // this case only occurs during DB migration from
            // 1.0 to 1.1 until everybody has run their profile
            // view or updated once
            $this->prepShowtime();
            return $this->getSufficientConfig();
        } elseif ($r[0] == "0") {
            return FALSE;
        } else {
            return TRUE;
        }
    }

    /**
     * Checks if the profile has enough information to have something to show to end users. This does not necessarily mean
     * that there's a fully configured EAP type - it is sufficient if a redirect has been set for at least one device.
     * 
     * @return boolean TRUE if enough information for showtime is set; FALSE if not
     */
    public function readyForShowtime() {
        $proper_config = FALSE;
        $attribs = $this->getCollapsedAttributes();
        // do we have enough to go live? Check if any of the configured EAP methods is completely configured ...
        if (sizeof($this->getEapMethodsinOrderOfPreference(1)) > 0)
            $proper_config = TRUE;
        // if not, it could still be that general redirect has been set
        if (!$proper_config) {
            if (isset($attribs['device-specific:redirect']))
                $proper_config = TRUE;
            // TODO: or maybe just a per-device redirect? would be good enough...
        }
        // do we know at least one SSID to configure, or work with wired? If not, it's not ready...
        if (!isset($attribs['media:SSID']) &&
                !isset($attribs['media:SSID_with_legacy']) &&
                (!isset(Config::$CONSORTIUM['ssid']) || count(Config::$CONSORTIUM['ssid']) == 0) &&
                !isset($attribs['media:wired']))
            $proper_config = FALSE;
        return $proper_config;
    }

    /**
     * set the showtime and QR-user attributes if prepShowTime says that there is enough info *and* the admin flagged the profile for showing
     */
    public function prepShowtime() {
        $proper_config = $this->readyForShowtime();
        if ($proper_config)
            DBConnection::exec($this->databaseType, "UPDATE profile SET sufficient_config = TRUE WHERE profile_id = " . $this->identifier);
        else
            DBConnection::exec($this->databaseType, "UPDATE profile SET sufficient_config = FALSE WHERE profile_id = " . $this->identifier);
        $attribs = $this->getCollapsedAttributes();
        // if not enough info to go live, set FALSE
        // even if enough info is there, admin has the ultimate say: 
        //   if he doesn't want to go live, no further checks are needed, set FALSE as well
        if (!$proper_config || !isset($attribs['profile:production']) || (isset($attribs['profile:production']) && $attribs['profile:production'][0] != "on")) {
            DBConnection::exec($this->databaseType, "UPDATE profile SET showtime = FALSE WHERE profile_id = " . $this->identifier);
            return;
        } else { 
            DBConnection::exec($this->databaseType, "UPDATE profile SET showtime = TRUE WHERE profile_id = " . $this->identifier);
            return;
        }
    }

    /**
     * Checks if the profile is shown (showable) to end users
     * @return boolean TRUE if profile is shown; FALSE if not
     */
    public function getShowtime() {
        $result = DBConnection::exec($this->databaseType, "SELECT showtime FROM profile WHERE profile_id = " . $this->identifier);
        $r = mysqli_fetch_row($result);
        /* echo "<pre>";

63% of this comment could be valid code. Did you maybe forget this after debugging?

          print_r($r);
          echo "</pre>"; */
        if ($r[0] == "0")
            return FALSE;
        else
            return TRUE;
    }

    /**
     * current language
     * @var string
     */
    private $lang_index;

    /**
     * DB identifier of the parent institution of this profile
     * @var int
     */
    public $institution;

    /**
     * name of the parent institution of this profile in the current language
     * @var string
     */
    public $inst_name;

    /**
     * realm of this profile (empty string if unset)
     * @var string
     */
    public $realm;

    /**
     * boolean value: should anonymous outer IDs be used or not?
     * @var boolean
     */
    public $use_anon_outer;

}