GEANT / CAT

web/admin/edit_idp.php

Braces +23 added lines, -14 removed lines

@@ -31,10 +31,11 @@ 
 $idpoptions = $my_inst->getAttributes();
 $inst_name = $my_inst->name;
 
-if ($wizard_style)
+if ($wizard_style) {
     $cat = defaultPagePrelude(sprintf(_("%s: IdP enrollment wizard (step 2)"), Config::$APPEARANCE['productname']));
-else
+} else {
     $cat = defaultPagePrelude(sprintf(_("%s: Editing IdP '%s'"), Config::$APPEARANCE['productname'], $inst_name));
+}
 // let's check if the inst handle actually exists in the DB and user is authorised
 ?>
 <script src="js/option_expand.js" type="text/javascript"></script>
@@ -43,9 +44,10 @@ 
 
 <?php
 $additional = FALSE;
-foreach ($idpoptions as $optionname => $optionvalue)
+foreach ($idpoptions as $optionname => $optionvalue) {
     if ($optionvalue['name'] == "general:geo_coordinates")
         $additional = TRUE;
+}
 geo_widget_head($my_inst->federation, $inst_name)
 ?>
 <script>
@@ -74,10 +76,11 @@ 
 
     <h1>
 <?php
-if ($wizard_style)
+if ($wizard_style) {
     echo _("Step 2: General Information about your IdP");
-else
+} else {
     printf(_("Editing IdP information for '%s'"), $inst_name);
+}
 ?>
     </h1>
     <div class='infobox'>
@@ -98,9 +101,10 @@ 
 echo "<form enctype='multipart/form-data' action='edit_idp_result.php?inst_id=$my_inst->identifier" . ($wizard_style ? "&wizard=true" : "") . "' method='post' accept-charset='UTF-8'>
               <input type='hidden' name='MAX_FILE_SIZE' value='" . Config::$MAX_UPLOAD_SIZE . "'>";
 
-if ($wizard_style)
+if ($wizard_style) {
     echo "<p>" .
     _("Hello, newcomer. Your institution is new to us. This wizard will ask you several questions about your IdP, so that we can generate beautiful profiles for you in the end. All of the information below is optional, but it is important to fill out as many fields as possible for the benefit of your end users.") . "</p>";
+}
 ?>
     <fieldset class="option_container">
         <legend><strong><?php echo _("General Information"); ?></strong></legend>
@@ -143,12 +147,14 @@ 
     echo "<strong>" . ( count(Config::$CONSORTIUM['ssid']) > 0 ? _("Additional SSIDs:") : _("SSIDs:")) . " </strong>";
     if (count(Config::$CONSORTIUM['ssid']) > 0) {
         $ssidlist = "";
-        foreach (Config::$CONSORTIUM['ssid'] as $ssid)
-            $ssidlist .= ", '<strong>" . $ssid . "</strong>'";
+        foreach (Config::$CONSORTIUM['ssid'] as $ssid) {
+                    $ssidlist .= ", '<strong>" . $ssid . "</strong>'";
+        }
         $ssidlist = substr($ssidlist, 2);
         echo sprintf(ngettext("We will always configure this SSID for WPA2/AES: %s.", "We will always configure these SSIDs for WPA2/AES: %s.", count(Config::$CONSORTIUM['ssid'])), $ssidlist);
-        if (Config::$CONSORTIUM['tkipsupport'])
-            echo " " . _("They will also be configured for WPA/TKIP if the device supports multiple encryption types.");
+        if (Config::$CONSORTIUM['tkipsupport']) {
+                    echo " " . _("They will also be configured for WPA/TKIP if the device supports multiple encryption types.");
+        }
         echo "<br/>" . sprintf(_("It is also possible to define custom additional SSIDs with the options '%s' and '%s' below."), display_name("media:SSID"), display_name("media:SSID_with_legacy"));
     } else {
         echo _("Please configure which SSIDs should be configured in the installers.");
@@ -160,8 +166,9 @@ 
     echo "<strong>" . ( count(Config::$CONSORTIUM['ssid']) > 0 ? _("Additional Hotspot 2.0 / Passpoint Consortia:") : _("Hotspot 2.0 / Passpoint Consortia:")) . " </strong>";
     if (count(Config::$CONSORTIUM['interworking-consortium-oi']) > 0) {
         $consortiumlist = "";
-        foreach (Config::$CONSORTIUM['interworking-consortium-oi'] as $oi)
-            $consortiumlist .= ", '<strong>" . $oi . "</strong>'";
+        foreach (Config::$CONSORTIUM['interworking-consortium-oi'] as $oi) {
+                    $consortiumlist .= ", '<strong>" . $oi . "</strong>'";
+        }
         $consortiumlist = substr($consortiumlist, 2);
         echo sprintf(ngettext("We will always configure this Consortium OI: %s.", "We will always configure these Consortium OIs: %s.", count(Config::$CONSORTIUM['interworking-consortium-oi'])), $consortiumlist);
         
@@ -190,11 +197,12 @@ 
     <fieldset class="option_container">
         <legend><strong><?php echo _("Helpdesk Details for all users"); ?></strong></legend>
 <?php
-if ($wizard_style)
+if ($wizard_style) {
     echo "<p>" .
     _("If your IdP provides a helpdesk for its users, it would be nice if you would tell us the pointers to this helpdesk. Some site installers might be able to signal this information to the user if he gets stuck.") . "</p>
         <p>" .
     _("If you enter a value here, it will be added to the site installers for all your users, and will be displayed on the download page. If you operate separate helpdesks for different user groups (we call this 'profiles'), or operate no help desk at all (shame on you!), you can also leave any of these fields empty and optionally specify per-profile helpdesk information later in this wizard.") . "</p>";
+}
 ?>
 
         <table id="expandable_support_options">
@@ -206,9 +214,10 @@ 
 <!--    <fieldset class="option_container">
         <legend><strong><?php echo _("EAP details for all users"); ?></strong></legend>
 <?php
-if ($wizard_style)
+if ($wizard_style) {
     echo "<p>" . _("Most EAP methods need server-side authentication details, like the CA certificate and/or server name(s) of your authentication servers. If all the EAP methods you support work with the same CA and or Common Names of servers, you can enter them here and they will be added as trust anchors in all profiles. If the details differ per profile or per EAP-type, you can also enter them in the individual profiles later.") . "</p>
         <p>" . sprintf(_("<strong>Note well: </strong>The server-side validation is a cornerstone of %s; without it, users are subject to man-in-the-middle attacks! We will not generate site installers without Trusted CA anchors and server names."), Config::$CONSORTIUM['name']) . "</p>";
+}
 ?>
         <table id="expandable_eapserver_options">
         <?php

web/admin/logout_check.php

Braces +5 added lines, -4 removed lines

@@ -18,10 +18,11 @@
 if ($ls['Code'] === 'urn:oasis:names:tc:SAML:2.0:status:Success' && !isset($ls['SubCode'])) {
     /* Successful logout. */
     $url = htmlspecialchars($_SERVER['HTTP_HOST']) . substr($_SERVER['PHP_SELF'], 0, strrpos($_SERVER['PHP_SELF'], "/admin/logout_check.php"));
-    if ($_SERVER['HTTPS'] == "on")
-        $url = "https://" . $url;
-    else
-        $url = "http://" . $url;
+    if ($_SERVER['HTTPS'] == "on") {
+            $url = "https://" . $url;
+    } else {
+            $url = "http://" . $url;
+    }
 
     header("Location: $url");
 } else {

web/admin/edit_user_result.php

Braces +2 added lines, -1 removed lines

@@ -31,10 +31,11 @@
 <?php
 $remaining_attribs = $user->beginflushAttributes();
 
-if (isset($_POST['option']))
+if (isset($_POST['option'])) {
     foreach ($_POST['option'] as $opt_id => $optname)
         if ($optname == "user:fedadmin") {
             echo "Security violation: user tried to make himself federation administrator!";
+}
             exit(1);
         }
 ?>

web/admin/overview_federation.php

Braces +21 added lines, -16 removed lines

@@ -128,19 +128,21 @@ 
     if (isset($_GET['invitation'])) {
         echo "<div class='ca-summary' style='position:relative;'><table>";
 
-        if ($_GET['invitation'] == "SUCCESS")
-            echo UI_remark(_("The invitation email was sent successfully."), _("The invitation email was sent."));
-        else if ($_GET['invitation'] == "FAILURE")
-            echo UI_error(_("The invitation email could not be sent!"), _("The invitation email could not be sent!"));
-        else
-            echo UI_error(_("Error: unknown result code of invitation!?!"), _("Unknown result!"));
+        if ($_GET['invitation'] == "SUCCESS") {
+                    echo UI_remark(_("The invitation email was sent successfully."), _("The invitation email was sent."));
+        } else if ($_GET['invitation'] == "FAILURE") {
+                    echo UI_error(_("The invitation email could not be sent!"), _("The invitation email could not be sent!"));
+        } else {
+                    echo UI_error(_("Error: unknown result code of invitation!?!"), _("Unknown result!"));
+        }
 
         echo "</table></div>";
     }
-    if (Config::$CONSORTIUM['name'] == 'eduroam')
-        $helptext = "<h3>" . sprintf(_("Need help? Refer to the <a href='%s'>Federation Operator manual</a>"),"https://wiki.geant.org/x/KQB_AQ")."</h3>";
-    else
-        $helptext = "";
+    if (Config::$CONSORTIUM['name'] == 'eduroam') {
+            $helptext = "<h3>" . sprintf(_("Need help? Refer to the <a href='%s'>Federation Operator manual</a>"),"https://wiki.geant.org/x/KQB_AQ")."</h3>";
+    } else {
+            $helptext = "";
+    }
     echo $helptext;
 
     ?>
@@ -153,8 +155,9 @@ 
             $feds = $user->getAttributes("user:fedadmin");
             $pending_invites = $mgmt->listPendingInvitations();
 
-            if (Config::$DB['enforce-external-sync'])
-                echo "<th>" . sprintf(_("%s Database Sync Status"), Config::$CONSORTIUM['name']) . "</th>";
+            if (Config::$DB['enforce-external-sync']) {
+                            echo "<th>" . sprintf(_("%s Database Sync Status"), Config::$CONSORTIUM['name']) . "</th>";
+            }
             ?>
             <th><?php echo _("Administrator Management"); ?></th>
         </tr>
@@ -165,10 +168,11 @@ 
 
             // extract only pending invitations for *this* fed
             $display_pendings = FALSE;
-            foreach ($pending_invites as $oneinvite)
-                if (strtoupper($oneinvite['country']) == strtoupper($thefed->identifier)) {
+            foreach ($pending_invites as $oneinvite) {
+                            if (strtoupper($oneinvite['country']) == strtoupper($thefed->identifier)) {
                     // echo "PENDINGS!";
                     $display_pendings = TRUE;
+            }
                 }
 
             $idps = $thefed->listIdentityProviders();
@@ -253,8 +257,8 @@ 
                                </strong>
                             </td>
                          </tr>";
-                foreach ($pending_invites as $oneinvite)
-                    if (strtoupper($oneinvite['country']) == strtoupper($thefed->identifier)) {
+                foreach ($pending_invites as $oneinvite) {
+                                    if (strtoupper($oneinvite['country']) == strtoupper($thefed->identifier)) {
                         echo "<tr>
                                     <td>" .
                         $oneinvite['name'] . "
@@ -263,6 +267,7 @@ 
                         $oneinvite['mail'] . "
                                     </td>
                                     <td colspan=2>";
+                }
                         echo "<form method='post' action='overview_federation.php' accept-charset='UTF-8'>
                                 <input type='hidden' name='invitation_id' value='" . $oneinvite['token'] . "'/>
                                 <button class='delete' type='submit' name='submitbutton' value='" . BUTTON_DELETE . "'>" . _("Revoke Invitation") . "</button>

web/admin/radius_tests.php

Braces +43 added lines, -30 removed lines

@@ -36,13 +36,15 @@ 
   foreach (array_reverse($dn) as $k => $v) {
       if(is_array ($v)) {
          foreach ($v as $V) {
-            if($out) 
-               $out .= ',';
+            if($out) {
+                           $out .= ',';
+            }
             $out .= "$k=$V";
          }
       } else {
-         if($out) 
-            $out .= ',';
+         if($out) {
+                     $out .= ',';
+         }
          $out .= "$k=$v";
       }
   }
@@ -61,8 +63,9 @@ 
     $udp_result = $testsuite->UDP_reachability_result[$host];
     if(isset($udp_result['certdata']) && count($udp_result['certdata'])) {
        foreach ($udp_result['certdata'] as $certdata) {
-          if($certdata['type'] != 'server' && $certdata['type'] != 'totally_selfsigned' )
-             continue;
+          if($certdata['type'] != 'server' && $certdata['type'] != 'totally_selfsigned' ) {
+                       continue;
+          }
           $server_cert =  [
              'subject' => printDN($certdata['subject']),
              'issuer' => printDN($certdata['issuer']),
@@ -77,9 +80,9 @@ 
     $ret['server_cert'] = $server_cert;
     if(isset($udp_result['incoming_server_names'][0]) ) {
         $ret['server'] = sprintf(_("Connected to %s."), $udp_result['incoming_server_names'][0]);
+    } else {
+            $ret['server'] = 0;
     }
-    else
-        $ret['server'] = 0;
     $ret['level'] = L_OK;
     $ret['time_millisec'] = sprintf("%d", $udp_result['time_millisec']);
     if (isset($udp_result['cert_oddities']) && count($udp_result['cert_oddities']) > 0) {
@@ -100,8 +103,9 @@ 
     return $ret;
 }
 
-if (!isset($_REQUEST['test_type']) || !$_REQUEST['test_type'])
+if (!isset($_REQUEST['test_type']) || !$_REQUEST['test_type']) {
     exit;
+}
 
 $test_type = $_REQUEST['test_type']; 
 $check_realm = valid_Realm($_REQUEST['realm']); 
@@ -119,8 +123,9 @@ 
    exit;
 */
 $hostindex = $_REQUEST['hostindex']; 
-if(!is_numeric($hostindex))
+if(!is_numeric($hostindex)) {
   exit;
+}
 
 
 $returnarray = [];
@@ -235,10 +240,11 @@ 
         switch ($testresult) {
             case RETVAL_CONVERSATION_REJECT:
                 $level = $returnarray['result'][$i]['level'];
-                if($level > L_OK)
-                    $message = _("<strong>Test partially successful</strong>: a bidirectional RADIUS conversation with multiple round-trips was carried out, and ended in an Access-Reject as planned.") . ' ' . $additional_message[$level];
-                else
-                    $message = _("<strong>Test successful</strong>: a bidirectional RADIUS conversation with multiple round-trips was carried out, and ended in an Access-Reject as planned.");
+                if($level > L_OK) {
+                                    $message = _("<strong>Test partially successful</strong>: a bidirectional RADIUS conversation with multiple round-trips was carried out, and ended in an Access-Reject as planned.") . ' ' . $additional_message[$level];
+                } else {
+                                    $message = _("<strong>Test successful</strong>: a bidirectional RADIUS conversation with multiple round-trips was carried out, and ended in an Access-Reject as planned.");
+                }
                 break;
             case RETVAL_IMMEDIATE_REJECT:
                 $message = _("<strong>Test FAILED</strong>: the request was rejected immediately, without EAP conversation. This is not necessarily an error: if the RADIUS server enforces that outer identities correspond to an existing username, then this result is expected (Note: you could configure a valid outer identity in your profile settings to get past this hurdle). In all other cases, the server appears misconfigured or it is unreachable.");
@@ -276,23 +282,28 @@ 
             } else {
                 $returnarray['message'] = $testsuite->return_codes[$testsuite->TLS_CA_checks_result[$host]['status']]["message"];
                 $returnarray['level'] = L_OK;
-                if ($testsuite->TLS_CA_checks_result[$host]['status'] != RETVAL_CONNECTION_REFUSED)
-                    $returnarray['message'] .= ' (' . sprintf(_("elapsed time: %d"), $testsuite->TLS_CA_checks_result[$host]['time_millisec']) . '&nbsp;ms)';
-                else
-                    $returnarray['level'] = L_ERROR;
+                if ($testsuite->TLS_CA_checks_result[$host]['status'] != RETVAL_CONNECTION_REFUSED) {
+                                    $returnarray['message'] .= ' (' . sprintf(_("elapsed time: %d"), $testsuite->TLS_CA_checks_result[$host]['time_millisec']) . '&nbsp;ms)';
+                } else {
+                                    $returnarray['level'] = L_ERROR;
+                }
                 if ($testsuite->TLS_CA_checks_result[$host]['status'] == RETVAL_OK) {
                     $returnarray['certdata'] = [];
                     $returnarray['certdata']['subject'] = $testsuite->TLS_CA_checks_result[$host]['certdata']['subject'];
                     $returnarray['certdata']['issuer'] = $testsuite->TLS_CA_checks_result[$host]['certdata']['issuer'];
                     $returnarray['certdata']['extensions'] = [];
-                    if (isset($testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['subjectaltname']))
-                        $returnarray['certdata']['extensions']['subjectaltname'] = $testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['subjectaltname'];
-                    if (isset($testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['policyoid']))
-                        $returnarray['certdata']['extensions']['policies'] = join(' ', $testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['policyoid']);
-                    if (isset($testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['crlDistributionPoint']))
-                        $returnarray['certdata']['extensions']['crldistributionpoints'] = $testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['crlDistributionPoint'];
-                    if (isset($testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['authorityInfoAccess']))
-                        $returnarray['certdata']['extensions']['authorityinfoaccess'] = $testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['authorityInfoAccess'];
+                    if (isset($testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['subjectaltname'])) {
+                                            $returnarray['certdata']['extensions']['subjectaltname'] = $testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['subjectaltname'];
+                    }
+                    if (isset($testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['policyoid'])) {
+                                            $returnarray['certdata']['extensions']['policies'] = join(' ', $testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['policyoid']);
+                    }
+                    if (isset($testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['crlDistributionPoint'])) {
+                                            $returnarray['certdata']['extensions']['crldistributionpoints'] = $testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['crlDistributionPoint'];
+                    }
+                    if (isset($testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['authorityInfoAccess'])) {
+                                            $returnarray['certdata']['extensions']['authorityinfoaccess'] = $testsuite->TLS_CA_checks_result[$host]['certdata']['extensions']['authorityInfoAccess'];
+                    }
                 }
                 $returnarray['cert_oddities'] = [];
             }
@@ -306,10 +317,11 @@ 
         $k = 0;
         // the host member of the array may not exist if RETVAL_SKIPPED came out
         // (e.g. no client cert to test with). Be prepared for that
-        if (isset($testsuite->TLS_clients_checks_result[$host]))
-            foreach ($testsuite->TLS_clients_checks_result[$host]['ca'] as $type => $cli) {
+        if (isset($testsuite->TLS_clients_checks_result[$host])) {
+                    foreach ($testsuite->TLS_clients_checks_result[$host]['ca'] as $type => $cli) {
                 foreach ($cli as $key => $val) {
                     $returnarray['ca'][$k][$key] = $val;
+        }
                 }
                 $k++;
             }
@@ -347,8 +359,9 @@ 
             $oids = check_policy($data);
             if (!empty($oids)) {
                 $printedres .= '<li>' . _("Certificate policies") . ':';
-                foreach ($oids as $k => $o)
-                    $printedres .= " $o ($k)";
+                foreach ($oids as $k => $o) {
+                                    $printedres .= " $o ($k)";
+                }
             }
             if (($crl = certificate_get_field($data, 'crlDistributionPoints'))) {
                 $printedres .= '<li>' . _("crlDistributionPoints") . ': ' . $crl;

web/admin/overview_idp.php

Braces +48 added lines, -31 removed lines

@@ -28,8 +28,9 @@ 
 
 // delete stored realm
 
-if (isset($_SESSION['check_realm']))
+if (isset($_SESSION['check_realm'])) {
     unset($_SESSION['check_realm']);
+}
 
 
 geo_widget_head($my_inst->federation, $my_inst->name);
@@ -95,15 +96,17 @@ 
         </div>
         <?php
         $loadmap = FALSE;
-        foreach ($idpoptions as $optionname => $optionvalue)
-            if ($optionvalue['name'] == "general:geo_coordinates")
+        foreach ($idpoptions as $optionname => $optionvalue) {
+                    if ($optionvalue['name'] == "general:geo_coordinates")
                 $loadmap = TRUE;
-        if ($loadmap)
-            echo '
+        }
+        if ($loadmap) {
+                    echo '
 <div class="infobox"  style="width:270px;">
 <div id="map" style="width:100%; height:150px"></div>
 </div>
 ';
+        }
         ?>
     </div>
     <table>
@@ -131,8 +134,8 @@ 
     <h2><?php _("Available Support actions"); ?></h2>
     <table>
         <?php
-        if (count(Config::$RADIUSTESTS['UDP-hosts']) > 0 || Config::$RADIUSTESTS['TLS-discoverytag'] != "")
-            echo "<tr>
+        if (count(Config::$RADIUSTESTS['UDP-hosts']) > 0 || Config::$RADIUSTESTS['TLS-discoverytag'] != "") {
+                    echo "<tr>
                         <td>" . _("Check another realm's reachability") . "</td>
                         <td><form method='post' action='action_realmcheck.php?inst_id=$my_inst->identifier' accept-charset='UTF-8'>
                               <input type='text' name='realm' id='realm'>
@@ -140,7 +143,9 @@ 
                             </form>
                         </td>
                     </tr>";
-        if (Config::$CONSORTIUM['name'] == "eduroam") // SW: APPROVED
+        }
+        if (Config::$CONSORTIUM['name'] == "eduroam") {
+            // SW: APPROVED
             echo "<tr>
                         <td>" . _("Check server status of European federations") . "</td>
                         <td>
@@ -149,14 +154,17 @@ 
                            </form>
                         </td>
                     </tr>";
+        }
         ?>
     </table>
     <hr/>
     <h2><?php echo _("Profiles for this institution"); ?></h2>
     <?php
     $profiles_for_this_idp = $my_inst->listProfiles();
-    if (count($profiles_for_this_idp) == 0) // no profiles yet.
+    if (count($profiles_for_this_idp) == 0) {
+        // no profiles yet.
         echo _("There are not yet any profiles for your institution.");
+    }
 
     foreach ($profiles_for_this_idp as $profile_list) {
         echo "<div style='display: table-row; margin-bottom: 20px;'>";
@@ -170,9 +178,10 @@ 
         // readiness - but want to display it before!
 
         $has_overrides = FALSE;
-        foreach ($attribs as $attrib)
-            if ($attrib['level'] == "Profile" && !preg_match("/^(internal:|profile:name|profile:description)/", $attrib['name']))
+        foreach ($attribs as $attrib) {
+                    if ($attrib['level'] == "Profile" && !preg_match("/^(internal:|profile:name|profile:description)/", $attrib['name']))
                 $has_overrides = TRUE;
+        }
 
         $buffer_eaptypediv = "<div style='margin-bottom:40px; float:left;'>" . _("<strong>EAP Types</strong> (in order of preference):") . "<br/>";
         $typelist = $profile_list->getEapMethodsinOrderOfPreference();
@@ -196,9 +205,10 @@ 
                 $allcomplete = FALSE;
             };
             $eapattribs = $profile_list->getAttributes(0, $eaptype);
-            foreach ($attribs as $attrib)
-                if ($attrib['level'] == "Method" && !preg_match("/^internal:/", $attrib['name']))
+            foreach ($attribs as $attrib) {
+                            if ($attrib['level'] == "Method" && !preg_match("/^internal:/", $attrib['name']))
                     $buffer_eaptypediv .= "<img src='../resources/images/icons/Letter-E-blue-icon.png' alt='" . _("Option override on EAP Method level is in effect.") . "'>";
+            }
             $buffer_eaptypediv .= "<br/>";
         }
         $buffer_headline = "<h2 style='overflow:auto;'>";
@@ -206,23 +216,27 @@ 
         $buffer_headline .= "<div style='float:right;'>";
         $sufficient_config = $profile_list->getSufficientConfig();
         $showtime = $profile_list->getShowtime();
-        if ($has_overrides)
-            $buffer_headline .= UI_remark("", _("Option override on profile level is in effect."), TRUE);
-        if (!$allcomplete)
-            $buffer_headline .= UI_error("", _("The information in this profile is incomplete."), TRUE);
-        if ($showtime)
-            $buffer_headline .= UI_okay("", _("This profile is shown on the user download interface."), TRUE);
-        else if ($sufficient_config)
-            $buffer_headline .= UI_warning("", sprintf(_("This profile is NOT shown on the user download interface, even though we have enough information to show. To enable the profile, add the attribute \"%s\" and tick the corresponding box."), display_name("profile:production")), TRUE);
+        if ($has_overrides) {
+                    $buffer_headline .= UI_remark("", _("Option override on profile level is in effect."), TRUE);
+        }
+        if (!$allcomplete) {
+                    $buffer_headline .= UI_error("", _("The information in this profile is incomplete."), TRUE);
+        }
+        if ($showtime) {
+                    $buffer_headline .= UI_okay("", _("This profile is shown on the user download interface."), TRUE);
+        } else if ($sufficient_config) {
+                    $buffer_headline .= UI_warning("", sprintf(_("This profile is NOT shown on the user download interface, even though we have enough information to show. To enable the profile, add the attribute \"%s\" and tick the corresponding box."), display_name("profile:production")), TRUE);
+        }
         $buffer_headline .= "</div>";
 
         $buffer_headline .= sprintf(_("Profile: %s"), $profile_name) . "</h2>";
 
         echo $buffer_headline;
 
-        if (array_search(EAP::$TTLS_PAP, $typelist) !== FALSE && array_search(EAP::$TTLS_GTC, $typelist) === FALSE && array_search(EAP::$PEAP_MSCHAP2, $typelist) === FALSE && array_search(EAP::$TTLS_MSCHAP2, $typelist) === FALSE)
-        /// Hmmm... IdP Supports TTLS-PAP, but not TTLS-GTC nor anything based on MSCHAPv2. That locks out Symbian users; and is easy to circumvent. Tell the admin...
+        if (array_search(EAP::$TTLS_PAP, $typelist) !== FALSE && array_search(EAP::$TTLS_GTC, $typelist) === FALSE && array_search(EAP::$PEAP_MSCHAP2, $typelist) === FALSE && array_search(EAP::$TTLS_MSCHAP2, $typelist) === FALSE) {
+                /// Hmmm... IdP Supports TTLS-PAP, but not TTLS-GTC nor anything based on MSCHAPv2. That locks out Symbian users; and is easy to circumvent. Tell the admin...
             $buffer_eaptypediv .= "<p>" . sprintf(_("Read this <a href='%s'>tip</a>."), "https://confluence.terena.org/display/H2eduroam/eap-types#eap-types-choices") . "</p>";
+        }
 
         $buffer_eaptypediv .= "</div>";
         echo $buffer_eaptypediv;
@@ -230,12 +244,13 @@ 
         $has_realm = $profile_list->getAttributes("internal:realm");
         $has_realm = $has_realm[0]['value'];
         echo "<div class='profilemodulebuttons' style='float:right;'>";
-        if (count(Config::$RADIUSTESTS['UDP-hosts']) > 0 || ( count(Config::$RADIUSTESTS['TLS-clientcerts']) > 0 && Config::$RADIUSTESTS['TLS-discoverytag'] != ""))
-            echo "<form action='action_realmcheck.php?inst_id=$my_inst->identifier&amp;profile_id=$profile_list->identifier' method='post' accept-charset='UTF-8'>
+        if (count(Config::$RADIUSTESTS['UDP-hosts']) > 0 || ( count(Config::$RADIUSTESTS['TLS-clientcerts']) > 0 && Config::$RADIUSTESTS['TLS-discoverytag'] != "")) {
+                    echo "<form action='action_realmcheck.php?inst_id=$my_inst->identifier&amp;profile_id=$profile_list->identifier' method='post' accept-charset='UTF-8'>
                               <button type='submit' name='profile_action' value='check' " . ($has_realm ? "" : "disabled='disabled' title='" . _("The realm can only be checked if you configure the realm!") . "'") . ">
                                   " . _("Check realm reachability") . "
                               </button>
                           </form>";
+        }
         echo "<form action='overview_installers.php?inst_id=$my_inst->identifier&amp;profile_id=$profile_list->identifier' method='post' accept-charset='UTF-8'>
                               <button type='submit' name='profile_action' value='check' " . ($has_eaptypes ? "" : "disabled='disabled'  title='" . _("You have not fully configured any supported EAP types!") . "'") . ">
                                   " . _("Installer Fine-Tuning and Download") . "
@@ -261,10 +276,11 @@ 
         if ($profile_list->getShowtime()) {
             echo "<div style='display: table-cell; text-align:center;'><p><strong>" . _("User Download Link") . "</strong></p>";
             $URL = $profile_list->getCollapsedAttributes();
-            if (isset($URL['device-specific:redirect']))
-                $displayurl = $URL['device-specific:redirect'][0];
-            else
-                $displayurl = ( isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == "on" ? 'https://' : 'http://' ) . $_SERVER['SERVER_NAME'] . dirname(dirname($_SERVER['SCRIPT_NAME'])) . "?idp=" . $my_inst->identifier . "&amp;profile=" . $profile_list->identifier;
+            if (isset($URL['device-specific:redirect'])) {
+                            $displayurl = $URL['device-specific:redirect'][0];
+            } else {
+                            $displayurl = ( isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == "on" ? 'https://' : 'http://' ) . $_SERVER['SERVER_NAME'] . dirname(dirname($_SERVER['SCRIPT_NAME'])) . "?idp=" . $my_inst->identifier . "&amp;profile=" . $profile_list->identifier;
+            }
             echo "<a href='$displayurl' style='white-space: nowrap; text-align: center;'>";
             $uri = "data:image/png;base64," . base64_encode(png_inject_consortium_logo(QRcode::png($displayurl, FALSE, QR_ECLEVEL_Q, 12)));
             $size = getimagesize($uri);
@@ -277,8 +293,9 @@ 
             echo "<div style='width:20px;'></div>";
             echo "<div style='display: table-cell; min-width:200px;'><p><strong>" . _("User Downloads") . "</strong></p><table>";
             $stats = $profile_list->getUserDownloadStats();
-            foreach ($stats as $dev => $count)
-                echo "<tr><td><strong>$dev</strong></td><td>$count</td></tr>";
+            foreach ($stats as $dev => $count) {
+                            echo "<tr><td><strong>$dev</strong></td><td>$count</td></tr>";
+            }
             echo "</table></div>";
         }
         echo "</div>";

web/admin/action_realmcheck.php

Braces +40 added lines, -28 removed lines

@@ -23,10 +23,11 @@ 
 $error_message ='';
 $my_inst = valid_IdP($_REQUEST['inst_id'], $_SESSION['user']);
 
-if (isset($_GET['profile_id']))
+if (isset($_GET['profile_id'])) {
     $my_profile = valid_Profile($_GET['profile_id'], $my_inst->identifier);
-else
+} else {
     $my_profile = NULL;
+}
 if ($my_profile != NULL) {
    $cr = $my_profile->getAttributes("internal:realm");
    if ($cr) {
@@ -43,16 +44,18 @@ 
          $_SESSION['check_realm'] = $check_realm;
       }
    } else {
-      if(!empty($_SESSION['check_realm']))
-         $check_realm = $_SESSION['check_realm'];
-      else
-         $check_realm = FALSE;
+      if(!empty($_SESSION['check_realm'])) {
+               $check_realm = $_SESSION['check_realm'];
+      } else {
+               $check_realm = FALSE;
+      }
+   }
+   if($check_realm) {
+         $testsuite = new RADIUSTests($check_realm);
+   } else {
+         $error_message = _("No valid realm name given, cannot execute any checks!");
+   }
    }
-   if($check_realm)
-      $testsuite = new RADIUSTests($check_realm);
-   else
-      $error_message = _("No valid realm name given, cannot execute any checks!");
-}
 
 $translate = _("STATIC");
 $translate = _("DYNAMIC");
@@ -433,10 +436,11 @@ 
    $(".server_cert").hide();
 <?php
 foreach (Config::$RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
-    if ($check_thorough)
-        $extraarg = "profile_id: ".$my_profile->identifier.", ";
-    else
-        $extraarg = "";
+    if ($check_thorough) {
+            $extraarg = "profile_id: ".$my_profile->identifier.", ";
+    } else {
+            $extraarg = "";
+    }
     
    print "
 $(\"#src".$hostindex."_img\").attr('src',icon_loading);
@@ -556,8 +560,9 @@ 
               } else {
                 echo UI_message(L_ERROR,sprintf(_("Realm is <strong>%s</strong> "), _(($naptr > 0 ? "DYNAMIC" : "STATIC"))) . _("but there were DNS errors! Check them!") . " " . _("You should re-run the tests after fixing the errors; more errors might be uncovered at that point. The exact error causes are listed below."));
                 echo "</table><div class='notacceptable'><table>";
-                foreach ($testsuite->listerrors() as $details)
-                   echo "<tr><td>" . $details['TYPE'] . "</td><td>" . $details['TARGET'] . "</td></tr>";
+                foreach ($testsuite->listerrors() as $details) {
+                                   echo "<tr><td>" . $details['TYPE'] . "</td><td>" . $details['TARGET'] . "</td></tr>";
+                }
                 echo "</table></div>";
               }
               echo '</div>';
@@ -573,9 +578,13 @@ 
               ';
                   foreach ($testsuite->NAPTR_hostname_records as $hostindex => $addr) {
                       $host = '';
-                      if ($addr['family'] == "IPv6") $host .= '[';
+                      if ($addr['family'] == "IPv6") {
+                          $host .= '[';
+                      }
                       $host .= $addr['IP'];
-                      if ($addr['family'] == "IPv6") $host .= ']';
+                      if ($addr['family'] == "IPv6") {
+                          $host .= ']';
+                      }
                       $host .= ':' . $addr['port'];
 /*if($addr['family'] == "IPv6")
    continue;*/
@@ -728,11 +737,12 @@ 
                           echo "<tr><td>" . _("Password:") . "</td><td><input type='text' id='password' class='mandatory' name='password'/></td></tr>";
                }
                       // ask for cert + privkey if TLS-based method is active
-                      if (in_array(EAP::$TLS, $prof_compl))
-                          echo "<tr><td colspan='2'><strong>" . _("Certificate-based EAP types") . "</strong></td></tr>
+                      if (in_array(EAP::$TLS, $prof_compl)) {
+                                                echo "<tr><td colspan='2'><strong>" . _("Certificate-based EAP types") . "</strong></td></tr>
                         <tr><td>" . _("Certificate file (.p12 or .pfx):") . "</td><td><input type='file' id='cert' accept='application/x-pkcs12' name='cert'/></td></tr>
                         <tr><td>" . _("Certificate password, if any:") . "</td><td><input type='text' id='privkey' name='privkey_pass'/></td></tr>
                         <tr><td>" . _("Username, if different from certificate Subject:") . "</td><td><input type='text' id='tls_username' name='tls_username'/></td></tr>";
+                      }
                       echo "<tr><td colspan='2'><button id='submit_credentials'>" . _("Submit credentials") . "</button></td></tr></table></form>";
                       echo "<div id='live_login_results' style='display:none'>";
                       foreach (Config::$RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
@@ -762,13 +772,15 @@ 
     var realm = '<?php echo $check_realm; ?>';
     run_udp();
 <?php
-    if ($naptr > 0) 
-       echo "run_dynamic();";
-    else
-       echo '$("#tabs-d-li").hide();';
-    if (!$check_thorough) 
-       echo '$("#tabs-through").hide();';
-?>
+    if ($naptr > 0) {
+           echo "run_dynamic();";
+    } else {
+           echo '$("#tabs-d-li").hide();';
+    }
+    if (!$check_thorough) {
+           echo '$("#tabs-through").hide();';
+    }
+    ?>
 </script>
     <?php footer() ?>
 

web/admin/action_fedcheck.php

Braces +32 added lines, -21 removed lines

@@ -44,10 +44,11 @@ 
     // NAPTR existence check
     $tabletext .= "<td>";
     $naptr = $testsuite->NAPTR();
-    if ($naptr != RETVAL_NOTCONFIGURED)
-        switch ($naptr) {
+    if ($naptr != RETVAL_NOTCONFIGURED) {
+            switch ($naptr) {
             case RETVAL_NONAPTR:
                 $tabletext .= _("No NAPTR records");
+    }
                 break;
             case RETVAL_ONLYUNRELATEDNAPTR:
                 $tabletext .= sprintf(_("No associated NAPTR records"));
@@ -62,23 +63,26 @@ 
 
     if ($naptr > 0) {
         $naptr_valid = $testsuite->NAPTR_compliance();
-        if ($naptr_valid == RETVAL_INVALID)
-            $NAPTR_issues = true;
+        if ($naptr_valid == RETVAL_INVALID) {
+                    $NAPTR_issues = true;
+        }
     }
 
     // SRV resolution
 
     if ($naptr > 0 && $naptr_valid == RETVAL_OK) {
         $srv = $testsuite->NAPTR_SRV();
-        if ($srv == RETVAL_INVALID)
-            $NAPTR_issues = true;
+        if ($srv == RETVAL_INVALID) {
+                    $NAPTR_issues = true;
+        }
     }
 
     // IP addresses for the hosts
     if ($naptr > 0 && $naptr_valid == RETVAL_OK && $srv > 0) {
         $hosts = $testsuite->NAPTR_hostnames();
-        if ($hosts == RETVAL_INVALID)
-            $NAPTR_issues = true;
+        if ($hosts == RETVAL_INVALID) {
+                    $NAPTR_issues = true;
+        }
     }
 
     if ($NAPTR_issues) {
@@ -94,14 +98,17 @@ 
         $testsuite->UDP_reachability($hostindex, true, true);
         $results = $testsuite->UDP_reachability_result[$hostindex];
         //echo "<pre>".print_r($results,true)."</pre>";
-        if ($results['packetflow_sane'] != TRUE)
-            $UDP_errors = true;
-        if (empty($results['packetflow'][11]))
-            $UDP_errors = true;
+        if ($results['packetflow_sane'] != TRUE) {
+                    $UDP_errors = true;
+        }
+        if (empty($results['packetflow'][11])) {
+                    $UDP_errors = true;
+        }
         if (count($results['cert_oddities']) > 0) {
-            foreach ($results['cert_oddities'] as $oddity)
-                if ($oddity['level'] > $cert_biggest_oddity)
+            foreach ($results['cert_oddities'] as $oddity) {
+                            if ($oddity['level'] > $cert_biggest_oddity)
                     $cert_biggest_oddity = $oddity['level'];
+            }
         }
     }
     
@@ -122,8 +129,9 @@ 
     if ($naptr > 0 && count($testsuite->NAPTR_hostname_records) > 0) {
         foreach ($testsuite->NAPTR_hostname_records as $hostindex => $addr) {
             $retval = $testsuite->TLS_clients_side_check($addr);
-            if ($retval != RETVAL_OK && $retval != RETVAL_SKIPPED)
-                $dynamic_errors = true;
+            if ($retval != RETVAL_OK && $retval != RETVAL_SKIPPED) {
+                            $dynamic_errors = true;
+            }
         }
     }
     if (!$dynamic_errors) {
@@ -165,10 +173,11 @@ 
 $profiles_showtime = [];
 $profiles_readyconf = [];
 
-foreach ($allIDPs as $index => $oneidp)
+foreach ($allIDPs as $index => $oneidp) {
     foreach ($oneidp['instance']->listProfiles() as $profile)
         if ($profile->getShowtime()) {
             $profiles_showtime[] = ['idp' => $oneidp['instance'], 'profile' => $profile];
+}
         } else if ($profile->readyForShowtime()) {
             $profiles_confready[] = ['idp' => $oneidp['instance'], 'profile' => $profile];
         }
@@ -176,16 +185,18 @@ 
 if (count($profiles_showtime) > 0) {
     echo "<h2>" . _("Profiles marked as visible (V)") . "</h2>" . "<table>";
     echo rowdescription();
-    foreach ($profiles_showtime as $oneprofile)
-        echo profilechecks($oneprofile['idp'],$oneprofile['profile']);
+    foreach ($profiles_showtime as $oneprofile) {
+            echo profilechecks($oneprofile['idp'],$oneprofile['profile']);
+    }
     echo "</table>";
 }
 
 if (count($profiles_confready) > 0) {
     echo "<h2>" . _("Profiles with sufficient configuration, not marked as visible (C)") . "</h2>" . "<table>";
     echo rowdescription();
-    foreach ($profiles_confready as $oneprofile)
-        echo profilechecks($oneprofile['idp'],$oneprofile['profile']);
+    foreach ($profiles_confready as $oneprofile) {
+            echo profilechecks($oneprofile['idp'],$oneprofile['profile']);
+    }
     echo "</table>";
 }
 ?>

web/admin/edit_idp_result.php

Braces +11 added lines, -6 removed lines

@@ -74,8 +74,9 @@ 
 $my_inst->commitFlushAttributes($killlist);
 // delete cached logo, if present
 $logofile = dirname(dirname(__FILE__)) . "/downloads/logos/" . $my_inst->identifier . ".png";
-if (is_file($logofile))
+if (is_file($logofile)) {
     unlink($logofile);
+}
 
 CAT::writeAudit($_SESSION['user'], "MOD", "IdP " . $my_inst->identifier . " - attributes changed");
 
@@ -87,27 +88,31 @@ 
 
 $ssids = [];
 
-if (isset(Config::$CONSORTIUM['ssid']) && count(Config::$CONSORTIUM['ssid']) > 0)
+if (isset(Config::$CONSORTIUM['ssid']) && count(Config::$CONSORTIUM['ssid']) > 0) {
     foreach (Config::$CONSORTIUM['ssid'] as $ssidname)
         $ssids[] = $ssidname . " " . (isset(Config::$CONSORTIUM['tkipsupport']) && Config::$CONSORTIUM['tkipsupport'] === TRUE ? _("(WPA2/AES and WPA/TKIP)") : _("(WPA2/AES)") );
+}
 
 $custom_ssids_wpa2 = $my_inst->getAttributes("media:SSID");
 $custom_ssids_wpa = $my_inst->getAttributes("media:SSID_with_legacy");
 $wired_support = $my_inst->getAttributes("media:wired");
 
-if (count($custom_ssids_wpa) > 0)
+if (count($custom_ssids_wpa) > 0) {
     foreach ($custom_ssids_wpa as $ssidname)
         $ssids[] = $ssidname['value'] . " " . _("(WPA2/AES and WPA/TKIP)");
+}
 
-if (count($custom_ssids_wpa2) > 0)
+if (count($custom_ssids_wpa2) > 0) {
     foreach ($custom_ssids_wpa2 as $ssidname)
         $ssids[] = $ssidname['value'] . " " . _("(WPA2/AES)");
+}
 
 echo "<table>";
 if (count($ssids) > 0) {
     $printedlist = "";
-    foreach ($ssids as $names)
-        $printedlist = $printedlist . "$names ";
+    foreach ($ssids as $names) {
+            $printedlist = $printedlist . "$names ";
+    }
     echo UI_okay(sprintf(_("Your installers will configure the following SSIDs: <strong>%s</strong>"), $printedlist), _("SSIDs configured"));
 };
 if (count($wired_support) > 0) {