GCTC-NTGC / TalentCloud

app/Traits/RememberDeviceTrait.php

<?php

namespace App\Traits;

use Illuminate\Support\Str;

trait RememberDeviceTrait
{
    /**
     * The column name of the "remember device" token.
     *
     * @var string
     */
    protected $rememberDeviceTokenName = 'remember_device_token';

    /**
     * Get the token value for the "remember device" session.
     *
     * @return string|null
     */
    public function getRememberDeviceToken()
    {
        if (!empty($this->getRememberDeviceTokenName())) {
            return (string)$this->{$this->getRememberDeviceTokenName()};
        }
    }

    /**
     * Set the token value for the "remember device" session.
     *
     * @param  string $value
     * @return void
     */
    public function setRememberDeviceToken($value)
    {
        if (!empty($this->getRememberDeviceTokenName())) {
            $this->{$this->getRememberDeviceTokenName()} = $value;
        }
    }

    /**
     * Get the column name for the "remember device" token.
     *
     * @return string
     */
    public function getRememberDeviceTokenName()
    {
        return $this->rememberDeviceTokenName;
    }

    /**
     * Refresh the "remember device" token for the User.
     *
     * @return void
     */
    public function cycleRememberDeviceToken()
    {
        $this->setRememberDeviceToken(Str::random(60));
        $timestamps = $this->timestamps;
        $this->timestamps = false;

The property timestamps does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->timestamps = $timestamps;
    }

    /**
     * Get a key to be used by a cookie for the
     * remember device token.
     *
     * @return string
     */
    public function getRememberDeviceKey(): string
    {
        return 'remember_device_' . sha1(static::class);
    }
}