App\Services\Validation\Rules\ValidIdRule

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	passes()	0	4	1
A	message()	0	3	1
A	__construct()	0	3	1

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;

class ValidIdRule implements Rule
{
    /**
     * The fully qualified classname of the model to check.
     *
     * @var string
     */
    protected $className;

    /**
     * Create a rule that tests that a value is a valid id for the specified eloquent model.
     *
     * @param string $className

Missing parameter comment

     */
    public function __construct(string $className)
    {
        $this->className = $className;
    }

    /**
     * Determine if the validation rule passes.
     *
     * @param  string  $attribute

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  mixed  $value

Missing parameter comment

     * @return bool

Expected "boolean" but found "bool" for function return type

     */
    public function passes($attribute, $value)

Method \App\Services\Validation\Rules\ValidIdRule::passes() does not have parameter type hint for its parameter $attribute but it should be possible to add it based on @param annotation "string".

Method \App\Services\Validation\Rules\ValidIdRule::passes() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

Type hint "string" missing for $attribute

    {
        $model = $this->className;
        return $model::where('id', $value)->exists();
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()

Method \App\Services\Validation\Rules\ValidIdRule::message() does not have return type hint for its return value but it should be possible to add it based on @return annotation "string".

    {
        return Lang::get('validation.invalid_id');

The expression return Illuminate\Support\Facades\Lang::get('validation.invalid_id') also could return the type array which is incompatible with the documented return type string.

    }
}