HandleOutput::getFunctions() - Code Metrics - Inspection of "added null state handler function, need approval o..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — task/add_null_states ( 93767f )

unknown

created 2019-03-07 20:44 UTC

HandleOutput::getFunctions() A

↳ Parent: HandleOutput

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	2
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

1		<?php namespace App\Utilities;
		0 ignored issues – show Coding Style introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
2
3		use Twig_Extension;
4		use Twig_SimpleFunction;
5		use Twig_SimpleFilter;
6
7		class HandleOutput extends Twig_Extension {
		0 ignored issues – show Coding Style introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report Missing doc comment for class HandleOutput Loading history... Coding Style introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report Opening brace of a class must be on the line after the definition Loading history...
8		/**
9		* Functions
10		* @return void
		0 ignored issues – show Coding Style introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report There must be exactly one blank line before the tags in a doc comment Loading history...
11		*/
12	16	public function getFunctions() {
13		return [
		1 ignored issue – show Bug Best Practice introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report The expression `return array(new Twig_Si...this, 'handleOutput')))` returns the type `array<integer,Twig_SimpleFunction>` which is incompatible with the documented return type `void`. Loading history...
14	16	new Twig_SimpleFunction('handleOutput', [$this, 'handleOutput']),
15		];
16		}
17
18	3	public function handleOutput($output, $outputHtml, $nullHtml) {
		0 ignored issues – show Coding Style introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report Missing doc comment for function handleOutput() Loading history...
19	3	if( !empty($output) ) {
		0 ignored issues – show Coding Style introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report Expected "if (...) {\n"; found "if(...) {\n" Loading history...
20	3	echo $outputHtml;
21		} else {
22		echo $nullHtml;
23		}
24	3	}
25		}
26		?>
		0 ignored issues – show Best Practice introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
27

GCTC-NTGC / TalentCloud

Push — task/add_null_states ( 93767f )

HandleOutput::getFunctions() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like