ApplicationController::destroy() - Code Metrics - Inspection of "Display impact newlines on job poster; removed 2nd..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — hotfix/381_389_remote_impact_f... ( 49867d...99e2e4 )

by Tristan

created 2018-11-07 21:50 UTC

ApplicationController::destroy() A

↳ Parent: ApplicationController

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
eloc	6
dl	0
loc	13
ccs	0
cts	6
cp	0
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	6

<?php


namespace App\Http\Controllers;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Auth;
use App\Models\JobApplication;
use App\Models\Skill;

class ApplicationController extends Controller

{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $applications = Auth::user()->applicant->job_applications;

        return view('applicant/application_index', [

            "application_index" => Lang::get('applicant/application_index'),
            "applications" => $applications,
            "departments_template" => Lang::get('common/lookup/departments'),
            "manager_profile_photo" => '/images/user.png', //TODO: get real photo
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }


    /**
     * Display specified application
     *
     * @param  \App\Models\JobApplication  $application

     * @return \Illuminate\Http\Response

     */
    public function show(JobApplication $application)
    {
        $criteria = [
            'essential' => $application->job_poster->criteria->filter(function($value, $key) {
            'essential' => $application->job_poster->criteria->filter(function($value, /** @scrutinizer ignore-unused */ $key) {
                return $value->criteria_type->name == 'essential';
            }),
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
            'asset' => $application->job_poster->criteria->filter(function($value, $key) {
            'asset' => $application->job_poster->criteria->filter(function($value, /** @scrutinizer ignore-unused */ $key) {
                return $value->criteria_type->name == 'asset';
            }),
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
        ];

        return view('common/application_preview', [


            /* Application Template Data */
                "application_template" => Lang::get("applicant/application_template"),
                "application_preview" => true,
                "preferred_language_template" => Lang::get('common/preferred_language'),
                "citizenship_declaration_template" => Lang::get('common/citizenship_declaration'),
                "veteran_status_template" => Lang::get('common/veteran_status'),

            /* Job Data */
                "job" => $application->job_poster,

            /* Skills Data */
                "skills" => Skill::all(),
                "skill_template" => Lang::get("common/skills"),
                'reference_template' => Lang::get('common/references'),
                'sample_template' => Lang::get('common/work_samples'),
                "criteria" => $criteria,

            /* Applicant Data */
                "applicant" => $application->applicant,
                "job_application" => $application,
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    /**
     * Delete the particular resource from storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @param  \App\Models\JobApplication  $application

     * @return \Illuminate\Http\Response

     */
    public function destroy(Request $request, JobApplication $application)
    {
        $this->authorize('delete', $application);

        $application->delete();

        if($request->ajax()) {

            return [

                "message" => 'Application deleted'
            ];
        }

        return redirect()->back();

    }

}


GCTC-NTGC / TalentCloud

Push — hotfix/381_389_remote_impact_f... ( 49867d...99e2e4 )

ApplicationController::destroy() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like