ApplicantProfileController::editAuthenticated() - Code Metrics - Inspection of "update dependencies" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — task/talent-dot-test ( 0ef1e8...074f28 )

by Grant

created 2019-04-02 21:40 UTC

ApplicantProfileController::editAuthenticated() A

↳ Parent: ApplicantProfileController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	2
dl	0
loc	4
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Auth;
use Illuminate\Auth\GuardHelpers;
use Illuminate\Http\Request;
use App\Models\Lookup\ApplicantProfileQuestion;
use App\Models\Applicant;
use App\Models\ApplicantProfileAnswer;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Hash;
use App\Services\Validation\Requests\UpdateApplicationProfileValidator;

class ApplicantProfileController extends Controller
{

    protected $answerFormInputName = 'applicantProfileAnswer';


    /**
     * Display the specified resource.
     *
     * @param  Request               $request

     * @param  \App\Models\Applicant $applicant

     * @return \Illuminate\View\View|\Illuminate\Contracts\View\Factory
     */
    public function show(Request $request, Applicant $applicant)
    public function show(/** @scrutinizer ignore-unused */ Request $request, Applicant $applicant)
    {
        //TODO:
        //Josh, to loop through answers&question data, leverage this data structure:
        // applicant
        //     [applicant_profile_answers]
        //         answer
        //         applicant_profile_question
        //             id
        //             value // The question text
        //             description // Question description text

        return view(
            'manager/applicant_profile',
            [
                /* Localization Strings*/
                'profile' => Lang::get('manager/applicant_profile'), // Change text

                /* User Data */
                'user' => $applicant->user,
                'applicant' => $applicant,
                'profile_photo_url' => '/images/user.png', //TODO: get real photos
            ]
        );
    }

    /**
     * Show the form for editing the logged-in applicant's profile
     *
     * @param  Request $request

     * @return \Illuminate\Http\RedirectResponse
     */
    public function editAuthenticated(Request $request): \Illuminate\Http\RedirectResponse
    {
        $applicant = $request->user()->applicant;
        return redirect(route('profile.about.edit', $applicant));
    }

    /**
     * Show the form for editing an applicant profile
     *
     * @param  Request               $request   Incoming request object.
     * @param  \App\Models\Applicant $applicant Applicant to view and edit.
     * @return \Illuminate\View\View|\Illuminate\Contracts\View\Factory
     */
    public function edit(Request $request, Applicant $applicant)
    {
        $profileQuestions = ApplicantProfileQuestion::all();

        $profileText = Lang::get('applicant/applicant_profile');

        $profileQuestionForms = [];
        foreach ($profileQuestions as $question) {
            $answerObj = $applicant->applicant_profile_answers
                ->where('applicant_profile_question_id', $question->id)->first();
            $answer = $answerObj ? $answerObj->answer : null;

            $formValues = [
                'id' => $question->id,
                'question' => $question->question,
                'description' => $question->description,
                'answer' => $answer,
                'answer_label' => $profileText['about_section']['answer_label'],
                'input_name' => $this->answerFormInputName.'['.$question->id.']'
            ];
            array_push($profileQuestionForms, $formValues);
        }

        return view(
            'applicant/profile_01_about',
            [
            /* Localized strings*/
            'profile' => $profileText,
            /* Applicant Profile Questions */
            'applicant_profile_questions' => $profileQuestionForms,
            /* User Data */
            'user' => $applicant->user,
            'applicant' => $applicant,
            'profile_photo_url' => '/images/user.png', //TODO: get real photos

            'form_submit_action' => route('profile.about.update', $applicant)
            ]
        );
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  Request               $request   Incoming request.
     * @param  \App\Models\Applicant $applicant Applicant object to update.
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, Applicant $applicant): \Illuminate\Http\RedirectResponse
    {
        $questions = ApplicantProfileQuestion::all();

        $validator = new UpdateApplicationProfileValidator($applicant);
        $validator->validate($request->all());

        foreach ($questions as $question) {
            $answerName = $this->answerFormInputName . '.' . $question->id;
            if ($request->has($answerName)) {
                $answer = ApplicantProfileAnswer::where(
                    ['applicant_id' => $applicant->id,
                    'applicant_profile_question_id' => $question->id]
                )
                            ->first();
                if ($answer == null) {
                    $answer = new ApplicantProfileAnswer();
                    $answer->applicant_id =$applicant->id;
                    $answer->applicant_profile_question_id = $question->id;
                }
                $answer->answer = $request->input($answerName);
                $answer->save();
            }
        }

        $input = $request->input();
        $applicant->fill(
            [
            'tagline' => $input['tagline'],
            'twitter_username' => $input['twitter_username'],
            'linkedin_url' => $input['linkedin_url'],
            ]
        );
        $applicant->save();

        $user = $applicant->user;
        $user->fill(
            [
            'name' => $input['profile_name'],
            'email' => $input['profile_email'], //TODO make changing email harder!
            ]
        );
        if ($input['new_password']) {
            $user->password =  Hash::make($input['new_password']); //TODO: change password in seperate form!
        }
        $user->save();

        return redirect()->route('profile.about.edit', $applicant);
    }
}


GCTC-NTGC / TalentCloud

Push — task/talent-dot-test ( 0ef1e8...074f28 )

ApplicantProfileController::editAuthenticated() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like