UpdateJobPoster::rules() - Code Metrics - Inspection of "Abstracted textarea dependant code from WordCounte..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/word_counter ( c4ec23...76dc11 )

by Yonathan

created 2019-08-01 14:57 UTC

UpdateJobPoster::rules() A

↳ Parent: UpdateJobPoster

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	50
dl	0
loc	52
rs	9.0909
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Support\Facades\Config;
use App\Services\Validation\Rules\ValidIdRule;
use App\Models\Lookup\Department;
use App\Models\Lookup\Province;
use App\Models\Lookup\SecurityClearance;
use App\Models\Lookup\LanguageRequirement;
use App\Models\JobPoster;
use App\Models\Lookup\Frequency;

class UpdateJobPoster extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return boolean
     */
    public function authorize(): bool
    {
        $job = $this->route('job');
        // Published jobs cannot be updated.
        return $job && $job->published_at === null;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return string[]
     */
    public function rules(): array
    {
        $dateFormat = Config::get('app.api_datetime_format');
        $dateFormatRule = "date_format:$dateFormat";
        $sliderRule = 'between:1,4';
        return [

            'term_qty' => 'nullable|numeric',
            'open_date_time' =>['nullable', $dateFormatRule],
            'close_date_time' => ['nullable', $dateFormatRule],
            'start_date_time' =>['nullable', $dateFormatRule],
            'department_id' => ['nullable', new ValidIdRule(Department::class)],
            'province_id' => ['nullable', new ValidIdRule(Province::class)],
            'security_clearance_id' => ['nullable', new ValidIdRule(SecurityClearance::class)],
            'language_requirement_id' => ['nullable', new ValidIdRule(LanguageRequirement::class)],
            'salary_min' => 'nullable|numeric',
            'salary_max' => 'nullable|numeric',
            'noc' => 'nullable|numeric',
            'classification_code' => 'nullable|regex:/[A-Z]{2}/',
            'classification_level' => 'nullable|numeric',
            'remote_work_allowed' => 'nullable|boolean',
            'team_size' => 'nullable|numeric',
            'work_env_features' => 'nullable|array',
            'work_env_features.*' => 'boolean', // Ensure work_env_features is an array of boolean flags.
            'fast_vs_steady' => ['nullable', $sliderRule],
            'horizontal_vs_vertical' => ['nullable', $sliderRule],
            'experimental_vs_ongoing' => ['nullable', $sliderRule],
            'citizen_facing_vs_back_office' => ['nullable', $sliderRule],
            'collaborative_vs_independent' => ['nullable', $sliderRule],
            'telework_allowed_frequency_id' => ['nullable', new ValidIdRule(Frequency::class)],
            'flexible_hours_frequency_id' => ['nullable', new ValidIdRule(Frequency::class)],
            'en.city' => 'nullable|string',
            'en.title' => 'nullable|string',
            'en.dept_impact' => 'nullable|string',
            'en.team_impact' => 'nullable|string',
            'en.hire_impact' => 'nullable|string',
            'en.division' => 'nullable|string',
            'en.branch' => 'nullable|string',
            'en.education' => 'nullable|string',
            'en.work_env_description' => 'nullable|string',
            'en.culture_summary' => 'nullable|string',
            'en.culture_special' => 'nullable|string',
            'fr.city' => 'nullable|string',
            'fr.title' => 'nullable|string',
            'fr.dept_impact' => 'nullable|string',
            'fr.team_impact' => 'nullable|string',
            'fr.hire_impact' => 'nullable|string',
            'fr.division' => 'nullable|string',
            'fr.branch' => 'nullable|string',
            'fr.education' => 'nullable|string',
            'fr.work_env_description' => 'nullable|string',
            'fr.culture_summary' => 'nullable|string',
            'fr.culture_special' => 'nullable|string',
        ];
    }
}


1			<?php
2
3			namespace App\Http\Requests;
4
5			use Illuminate\Foundation\Http\FormRequest;
6			use Illuminate\Support\Facades\Config;
7			use App\Services\Validation\Rules\ValidIdRule;
8			use App\Models\Lookup\Department;
9			use App\Models\Lookup\Province;
10			use App\Models\Lookup\SecurityClearance;
11			use App\Models\Lookup\LanguageRequirement;
12			use App\Models\JobPoster;
13			use App\Models\Lookup\Frequency;
14
15			class UpdateJobPoster extends FormRequest
16			{
17			/**
18			* Determine if the user is authorized to make this request.
19			*
20			* @return boolean
21			*/
22			public function authorize(): bool
23			{
24			$job = $this->route('job');
25			// Published jobs cannot be updated.
26			return $job && $job->published_at === null;
27			}
28
29			/**
30			* Get the validation rules that apply to the request.
31			*
32			* @return string[]
33			*/
34			public function rules(): array
35			{
36			$dateFormat = Config::get('app.api_datetime_format');
37			$dateFormatRule = "date_format:$dateFormat";
38			$sliderRule = 'between:1,4';
39			return [
			0 ignored issues – show Bug Best Practice introduced 2019-07-11 23:50 UTC by Report Bug Copy Issue Report The expression `return array('term_qty' ...' => 'nullable\|string')` returns an array which contains values of type `array<integer,App\Servic...>\|array<integer,string>` which are incompatible with the documented value type `string`. Loading history...
40			'term_qty' => 'nullable\|numeric',
41			'open_date_time' =>['nullable', $dateFormatRule],
42			'close_date_time' => ['nullable', $dateFormatRule],
43			'start_date_time' =>['nullable', $dateFormatRule],
44			'department_id' => ['nullable', new ValidIdRule(Department::class)],
45			'province_id' => ['nullable', new ValidIdRule(Province::class)],
46			'security_clearance_id' => ['nullable', new ValidIdRule(SecurityClearance::class)],
47			'language_requirement_id' => ['nullable', new ValidIdRule(LanguageRequirement::class)],
48			'salary_min' => 'nullable\|numeric',
49			'salary_max' => 'nullable\|numeric',
50			'noc' => 'nullable\|numeric',
51			'classification_code' => 'nullable\|regex:/[A-Z]{2}/',
52			'classification_level' => 'nullable\|numeric',
53			'remote_work_allowed' => 'nullable\|boolean',
54			'team_size' => 'nullable\|numeric',
55			'work_env_features' => 'nullable\|array',
56			'work_env_features.*' => 'boolean', // Ensure work_env_features is an array of boolean flags.
57			'fast_vs_steady' => ['nullable', $sliderRule],
58			'horizontal_vs_vertical' => ['nullable', $sliderRule],
59			'experimental_vs_ongoing' => ['nullable', $sliderRule],
60			'citizen_facing_vs_back_office' => ['nullable', $sliderRule],
61			'collaborative_vs_independent' => ['nullable', $sliderRule],
62			'telework_allowed_frequency_id' => ['nullable', new ValidIdRule(Frequency::class)],
63			'flexible_hours_frequency_id' => ['nullable', new ValidIdRule(Frequency::class)],
64			'en.city' => 'nullable\|string',
65			'en.title' => 'nullable\|string',
66			'en.dept_impact' => 'nullable\|string',
67			'en.team_impact' => 'nullable\|string',
68			'en.hire_impact' => 'nullable\|string',
69			'en.division' => 'nullable\|string',
70			'en.branch' => 'nullable\|string',
71			'en.education' => 'nullable\|string',
72			'en.work_env_description' => 'nullable\|string',
73			'en.culture_summary' => 'nullable\|string',
74			'en.culture_special' => 'nullable\|string',
75			'fr.city' => 'nullable\|string',
76			'fr.title' => 'nullable\|string',
77			'fr.dept_impact' => 'nullable\|string',
78			'fr.team_impact' => 'nullable\|string',
79			'fr.hire_impact' => 'nullable\|string',
80			'fr.division' => 'nullable\|string',
81			'fr.branch' => 'nullable\|string',
82			'fr.education' => 'nullable\|string',
83			'fr.work_env_description' => 'nullable\|string',
84			'fr.culture_summary' => 'nullable\|string',
85			'fr.culture_special' => 'nullable\|string',
86			];
87			}
88			}
89

GCTC-NTGC / TalentCloud

Push — feature/word_counter ( c4ec23...76dc11 )

UpdateJobPoster::rules() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like